There it goes. It fixed the problem I was seeing here
https://gerrit.fd.io/r/c/vpp/+/36057
On 27/04/22 16:24, Renato Botelho do Couto wrote:
Sure! I'll work on it
Thanks!
On Wed, 27 Apr 2022 at 16:21 Klement Sekera <klem...@graphiant.com
<mailto:klem...@graphiant.com>> wrote:
Hi Renato,
I see that some special char conversion cases are already covered in
vapi_c_gen.py:
713 include_guard = "__included_%s" % (
714 j.replace(".", "_").replace("/", "_").replace("-",
"_").replace(
715 "+", "_"))
716 print("#ifndef %s" % include_guard)
would you mind contributing a patch?
same change would be required in vapi_cpp_gen.py ...
Regards,
Klement
> On 27 Apr 2022, at 21:06, Renato Botelho do Couto via lists.fd.io
<http://lists.fd.io> <renato=netgate....@lists.fd.io
<mailto:netgate....@lists.fd.io>> wrote:
>
> We use Jenkins to build VPP and after adding some matrix
configuration to one of our Jenkinsfiles I noticed VPP stop building.
>
> When Jenkins builds the same project and use a second executor,
it adds '@2' to the end of ${WORKSPACE} directory name and I figured
out this is the cause of the breakage we saw here.
>
> It seems like VPP adds some dynamic #defines using full path of
file, like:
>
> #define
__included__var_lib_jenkins_workspace_tnsr_devel_test_build@2_work_vpp_build_root_build_vpp_native_vpp_CMakeFiles_vlibmemory_memclnt_api_json
>
> And then compiler throws the error:
>
> CMakeFiles/vpp-api/vapi/../vapi/memclnt.api.vapi.h:2:68: error:
ISO C99 requires whitespace after the macro name
[-Werror,-Wc99-extensions]
>
> Based on what I read Jenkins doesn't allow this behavior to be
changed so it may end up happening more times and break builds. Or
am I missing something?
>
> Thanks!
> --
> Renato Botelho do Couto
> Software Engineer
>
>
>
--
Renato Botelho do Couto
Software Engineer
Netgate, Inc.
--
Renato Botelho do Couto
Software Engineer
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#21297): https://lists.fd.io/g/vpp-dev/message/21297
Mute This Topic: https://lists.fd.io/mt/90738221/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
