Re: [vpp-dev] Some NAT API Error Values

2022-11-23 Thread Jon Loeliger via lists.fd.io
On Wed, Nov 23, 2022 at 12:25 PM filvarga wrote: > Hi, > > Thank you for your notes and pointing out the issue. Feel free to submit > any changes in the future and add appropriate people to your review (based > on maintainers list). > Thanks, will do! For now I am posting a quick fix. As the na

[vpp-dev] Some NAT API Error Values

2022-11-23 Thread Jon Loeliger via lists.fd.io
Hi VPPeople, I would like to open a discussion about some strange code and return values from a few of the NAT CLI and API interface functions. My quest for a reasonable handling when my management plane attempted to enable an already-enabled NAT 44 ED feature was handled poorly. It turns out, r

Re: [vpp-dev] Wireguard Peer Route Table Questions

2022-04-05 Thread Jon Loeliger via lists.fd.io
Hey VPP-ers, I have posted a suggested solution to this issue here: https://gerrit.fd.io/r/c/vpp/+/35896 Feel free to review! jdl On Mon, Apr 4, 2022 at 12:45 PM Jon Loeliger via lists.fd.io wrote: > Folks, > > I have a scenario where setting up a Wireguard interface and pe

[vpp-dev] Wireguard Peer Route Table Questions

2022-04-04 Thread Jon Loeliger via lists.fd.io
Folks, I have a scenario where setting up a Wireguard interface and peer causes VPP to segfault. I think the situation is simply that the function always_inline uword wg_output_tun_inline (vlib_main_t *vm, vlib_node_runtime_t *node, vlib_frame_t *frame, u8 is_ip4, u

Re: [vpp-dev] move to clang-format

2020-12-17 Thread Jon Loeliger via lists.fd.io
On Sun, Dec 13, 2020 at 6:15 AM Damjan Marion via lists.fd.io wrote: > > Hi, > > I was playing a bit with clang-format as replacement to gnu indent which > we use today[1]. > > While it is impossible to render exact same result like gnu indent, good > thing is that clang-format can be used only o

Re: [vpp-dev] Message posting policy change

2020-12-16 Thread Jon Loeliger via lists.fd.io
On Wed, Dec 16, 2020 at 6:47 AM Dave Barach wrote: > Folks, > > > > Any objections to reconfiguring the vpp-dev@lists.fd.io group to reject > messages from non-list-members? > > > > Thanks... Dave > Ja, do it. jdl -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View

Re: [vpp-dev] #vpp #vpp-memif #vppcom

2020-12-14 Thread Jon Loeliger via lists.fd.io
On Fri, Dec 11, 2020 at 3:13 PM wrote: > in our application I have to send out multicast packets, but the packet is > getting dropped in vpp > > #vpp #vpp-memif #vppcom Folks, You know, these subject lines are near meaningless. Could we please have real English descriptions, questions or usefu

Re: [vpp-dev] bihash change

2020-09-30 Thread Jon Loeliger via lists.fd.io
On Wed, Sep 30, 2020 at 8:11 AM Damjan Marion via lists.fd.io wrote: > > Just a heads-up on under-the-hood change[1] which is merged few minutes > ago and which affects all features that use bihash. > Now, bihash is allocating memory from the (main) heap, instead of > mmap()-ing it’s own alloc ar

Re: [vpp-dev] table lookup api?

2020-09-29 Thread Jon Loeliger via lists.fd.io
On Tue, Sep 29, 2020 at 9:31 AM wrote: > Hi Jon, > > > > I see, thanks. I have to go back to the drawing board. > > > > I am developing a P4 to VPP compiler. If VPP has any API to create a > table and lookup the table, it would ease compiler development. I am > chasing lookup because the looku

Re: [vpp-dev] vnet_classify_add_del_table API?

2020-09-29 Thread Jon Loeliger via lists.fd.io
On Fri, Sep 25, 2020 at 4:35 PM hemant via lists.fd.io wrote: > In the classify API mentioned in the subject of this email, I could use an > example with tables to understand table_index, next_table_index, and > miss_next_index. I know VPP maintains an index for a table. > > > > Say, the tables

Re: [vpp-dev] table lookup api?

2020-09-29 Thread Jon Loeliger via lists.fd.io
On Mon, Sep 28, 2020 at 1:15 PM hemant via lists.fd.io wrote: > I have created a table in VPP using the vnet_classify_add_del_session() > API. > > > > What API do I use to lookup this table? > > > > Thanks, > > > > Hemant > There is no API to do a Classifier table lookup. When the table was cr

Re: (Q about fixing endianness bugs in handlers) Re: [vpp-dev] Proposal for VPP binary API stability

2020-05-17 Thread Jon Loeliger via lists.fd.io
On Sat, May 16, 2020 at 10:02 AM Christian Hopps wrote: > > I know we use the binary APIs, I believe Netgate does as well. I'm sure > there are others too (might be good to collect a list of these folks if one > doesn't exist yet). > Indeed, Netgate uses the binary APIs extensively. jdl -=-=-=-

Re: [vpp-dev] Question regarding ICMP NAT behavior

2020-05-15 Thread Jon Loeliger via lists.fd.io
On Fri, May 15, 2020 at 2:38 PM Jon Loeliger wrote: > > So, here is the same scenario using vppctl to set up the test case. > > vpp# nat44 add static mapping icmp local 192.168.0.53 external outside > vpp# show nat44 static mappings > NAT44 static mappings: > local 192.168.0.53 external 192.168.

Re: [vpp-dev] Question regarding ICMP NAT behavior

2020-05-15 Thread Jon Loeliger via lists.fd.io
On Thu, May 14, 2020 at 11:23 AM Jon Loeliger via lists.fd.io wrote: > Did the ICMP mapping open more than was expected or intended here? > > I chased this down in the code a bit, but I'm not sure what the _intent_ > is supposed to be. > When "address only" is tru

[vpp-dev] Question regarding ICMP NAT behavior

2020-05-14 Thread Jon Loeliger via lists.fd.io
Hi vpp-devers, We have a report of an unexpected behavior when using a static NAT with ICMP. It appears that configuring an outside interface to allow ICMP also allows forwarding of all protocols as well. If you start with, say, a blocked TCP on port 22 and an SNMP on port 161, then adding a NAT

Re: [vpp-dev] route lookup api

2020-04-28 Thread Jon Loeliger via lists.fd.io
t; Thanks, > -daw- (wearing the friendly VPP release manager hat) > > On 4/27/2020 5:02 PM, Christian Hopps wrote: > > On Apr 27, 2020, at 11:44 AM, Jon Loeliger via lists.fd.io > wrote: > > > > On Wed, Feb 19, 2020 at 4:47 AM Christian Hopps > wrote: > > &g

Re: [vpp-dev] route lookup api

2020-04-27 Thread Jon Loeliger via lists.fd.io
On Wed, Feb 19, 2020 at 4:47 AM Christian Hopps wrote: > > > On Feb 19, 2020, at 2:02 AM, Neale Ranns via Lists.Fd.Io cisco@lists.fd.io> wrote: > > > > > > Hi Chris, > > > > Adding an API to dump a single route would be a welcome addition to the > API. > > Ok, I'll do that then. Hey Chris,

Re: [vpp-dev] QinQ and dot1ad any

2019-12-19 Thread Jon Loeliger via Lists.Fd.Io
On Wed, Dec 18, 2019 at 2:38 PM John Lo (loj) wrote: > Hi Jon, > > > > You are right on both counts. It is the combination of dot1q/ad-any and > exact-match that we should reject. It is also correct the check should be > at lower level to reject the combination for both API and CLI. > > > > Reg

Re: [vpp-dev] QinQ and dot1ad any

2019-12-18 Thread Jon Loeliger via Lists.Fd.Io
On Tue, Dec 17, 2019 at 8:13 AM John Lo (loj) via Lists.Fd.Io wrote: > > Thus, sub-interface with "inner-dot1q any" is not an exact match > sub-interface by definition since no match is present on inner tag. > > I suppose the CLI: > >> create sub-interfaces GigabitEthernet3/0/3 50 dot1ad 50 inner

Re: [vpp-dev] Ipv6 neighbor not getting discovered

2019-12-03 Thread Jon Loeliger via Lists.Fd.Io
On Tue, Dec 3, 2019 at 10:09 AM Rajith PR wrote: > Hello Team, > > During integration of our software with VPP 19.08 we have found that ipv6 > neighbor does not get discovered on first sw_if_index on which ipv6 is > enabled. > Do you have a small test case available? > Based on our understandi

Re: [vpp-dev] Requirements for DPDK pmd/feature testing in CSIT vpp-device-test jobs

2019-11-21 Thread Jon Loeliger via Lists.Fd.Io
On Thu, Nov 21, 2019 at 6:55 AM Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io wrote: > > a +2 triggers a pre-commit gate where VOM and the dist builds and the > extended tests are run. > > > If everything passes, the change is merged, if not, the +2 is removed. > > >

Re: [vpp-dev] [VCL] hoststack app crash with invalid memfd segment address

2019-11-21 Thread Jon Loeliger via Lists.Fd.Io
On Thu, Nov 21, 2019 at 4:50 AM wanghanlin wrote: > Hi Florin, > I have applied the patch, and found some problems in my case. I have not > right to post it in gerrit, so I post here. > Why don't you register with Gerrit, like this: https://wiki.fd.io/view/DEV/Setting_up_Gerrit HTH, jdl -=-=-

[vpp-dev] VLAN tag-rewrite questions

2019-11-11 Thread Jon Loeliger via Lists.Fd.Io
John, et al., The vppctl command "set interface l2 tag-rewrite" and the associated API call "l2_interface_vlan_tag_rewrite" allow an interface to have an L2 tag-rewrite rule applied or removed from an interface. That interface is usually a subif, but it may also apply to a regular (ethernet) inte

Re: [vpp-dev] A few MAP-T Clarifications

2019-11-07 Thread Jon Loeliger via Lists.Fd.Io
On Thu, Nov 7, 2019 at 7:23 AM Ole Troan wrote: > Dear Jon, > > I think were we left this last was a "shared TODO" list. > Yeah, sorry, I got tasked with something else for a bit... > The MAP specific shallow virtual reassembly has been generalised, and > moved to a separate component. > SVR n

[vpp-dev] FIB Route Sources

2019-11-06 Thread Jon Loeliger via Lists.Fd.Io
Neale, We have a use case where we would like to be able to determine a more-fine-grained reason for introducing routes into the FIBs. All the routes we introduce will come via some API call, but on behalf of different sources. Specifically, they will come from a user-supplied static route, diff

Re: [vpp-dev] A few MAP-T Clarifications

2019-11-06 Thread Jon Loeliger via Lists.Fd.Io
Ole, Waaay back in April, we had a small exchange here on the topic of some MAP-T/E behavior. Bottom line was some functionality needed to be homogenized. We wrote: On Tue, Apr 16, 2019 at 2:35 AM Ole Troan wrote: > Hi Jon, > > Apologies for the delay in answering. Swapped out all my knowled

Re: [vpp-dev] VPP Interfaces from with (Docker) Containers?

2019-10-08 Thread Jon Loeliger via Lists.Fd.Io
On Mon, Oct 7, 2019 at 2:21 PM Damjan Marion wrote: > > BTW I strongly suggest that you don't use uio_pci_generic. > Last we looked, any integration with QAT was only available using the uio_pci_generic driver. Will QAT work with the vfio-pci driver these days? If so, awesome! If not, that wil

Re: [vpp-dev] VPP Interfaces from with (Docker) Containers?

2019-10-07 Thread Jon Loeliger via Lists.Fd.Io
On Mon, Oct 7, 2019 at 11:04 AM Benoit Ganne (bganne) wrote: > > In each of the cases above where I said "still doesn't work", when the > > /dev/uio* is present, it is found. However, it then leads to this > > error as reported by vppctl's "show log" command: > > I did not check uio. I do use vp

Re: [vpp-dev] VPP Interfaces from with (Docker) Containers?

2019-10-07 Thread Jon Loeliger via Lists.Fd.Io
On Fri, Oct 4, 2019 at 3:33 AM Benoit Ganne (bganne) wrote: > Hi, > > Yes containers usually do not update /dev after creation, so any device > that shows up dynamically afterwards won't be available by default. Note > this is not specific to VPP. OK cool, that is what it was looking like... T

[vpp-dev] VPP Interfaces from with (Docker) Containers?

2019-10-03 Thread Jon Loeliger via Lists.Fd.Io
Folks, and maybe Damjan in particular?, I am trying to run VPP from within a Docker container using the Ligato framework for head-banging. The head-banging part is working. The VPP interface binding part, not so much. >From what I can tell, VPP sees the PCI devices, but then grouses that the /d

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io
On Mon, Jun 17, 2019 at 3:43 PM Damjan Marion wrote: > > On 17 Jun 2019, at 22:41, Jon Loeliger wrote: > > On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion wrote: > >> >> I tried to be as much descriptive as possible in those messages, but >> looks like I failed :( >> > > Damjan, > > No problem.

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io
On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion wrote: > > I tried to be as much descriptive as possible in those messages, but looks > like I failed :( > Damjan, No problem. I am working on some improvements. For example, fixing these problems: $ echo "Consolidate IPv6 link-local-address func

Re: [vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io
And now this: === ERROR === Unknown feature 'Consolidate' in commit 'Subject:' line. Feature must exist in MAINTAINERS file. If this commit intruduces new feature, then this commit must add new entry into the MAINTAINERS file. ==

[vpp-dev] Triggering a Verify Job?

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io
Folks, I am failing to trigger a "verify job" using the Review keyword "recheck" on one of my patches. Can someone remind me how to clear up my dumbness? Thanks! jdl -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13302): https://lists.fd.io/g/vpp

[vpp-dev] Commit Subjects

2019-06-17 Thread Jon Loeliger via Lists.Fd.Io
Folks, I received this during a build of a patch I submitted: === ERROR === Unknown feature 'IPv6' in commit 'Subject:' line. Feature must exist in MAINTAINERS file. If this commit intruduces new feature, then this commit must add new entry into the

Re: [vpp-dev] IPv6 Link-local Address Questions

2019-06-13 Thread Jon Loeliger via Lists.Fd.Io
On Thu, Jun 13, 2019 at 11:21 AM Ole Troan wrote: > Hi Jon, > > Thanks for bringing up my favorite topic! > Happy to step on those land mines! :-) Uh, is that "Duplicate but slightly wrong functions", "bit-byte-numbering issues", or "link-local addressing"? :-) > > I am happy to submit a patc

[vpp-dev] IPv6 Link-local Address Questions

2019-06-13 Thread Jon Loeliger via Lists.Fd.Io
Folks, I have stumbled across two functions that purport to construct a link-local IPv6 address from a MAC address. A laudable goal, but the details need some review. One function can be found in src/vnet/ip/ip6.h: always_inline void ip6_link_local_address_from_ethernet_mac_address (ip6_address

Re: [vpp-dev] Weird Error Number

2019-05-14 Thread Jon Loeliger via Lists.Fd.Io
On Wed, May 8, 2019 at 7:24 AM Ole Troan wrote: > Hi Jon, > > > Can anyone shed some light here? > > I guess the purpose of a positive value is to indicate that you can try > again with the same arguments and get a different response, > as opposed to a negative value. > > I would be in favour of