On Thu, Jun 13, 2019 at 11:21 AM Ole Troan <otr...@employees.org> wrote:
> Hi Jon, > > Thanks for bringing up my favorite topic! > Happy to step on those land mines! :-) Uh, is that "Duplicate but slightly wrong functions", "bit-byte-numbering issues", or "link-local addressing"? :-) > > I am happy to submit a patch to fix this situation, but I'd like to make > sure we get it right. :-) > > > > Here's what I think we should do: > > - Remove the function ip6_link_local_address_from_ethernet_address() > as it > > contains the incorrect bit, (1 << 6). > > - Replace the one use of that function with a call to > > Yes, please! > ip6_link_local_address_from_ethernet_mac_address() instead. > > - Answer the bit-wise XOR vs OR question ...? > > XOR is correct. > Excellent. Patch in a moment. Local testing... > Cheers > Ole > Thanks! jdl
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13282): https://lists.fd.io/g/vpp-dev/message/13282 Mute This Topic: https://lists.fd.io/mt/32054012/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
