[virtio-dev] Re: [PATCH RFC net-next v2 0/4] virtio/vsock: support datagrams

2023-04-19 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org because this thread is starting to touch the spec. On Wed, Apr 19, 2023 at 12:00:17PM +0200, Stefano Garzarella wrote: > Hi Bobby, > > On Fri, Apr 14, 2023 at 11:18:40AM +, Bobby Eshleman wrote: > > CC'ing Cong. > > > > On Fri, Apr 14, 2023 at 12:25:56A

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-19 Thread Enrico Granata
Inlined Thanks, - Enrico Thanks, - Enrico On Wed, Apr 19, 2023 at 12:39 AM Alexander Gordeev wrote: > > On 17.04.23 16:43, Cornelia Huck wrote: > > On Mon, Apr 17 2023, Alexander Gordeev > > wrote: > > > >> Hi Alexandre, > >> > >> Thanks for you letter! Sorry, it took me some time to write a

RE: [virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description

2023-04-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, April 19, 2023 7:27 AM > > On Wed, Apr 19, 2023 at 04:25:13PM +0800, Zhu, Lingshan wrote: > > > > +The driver writes an MSI-X vector number here for Configuration > change > > > > +interrupts. > > > Hmm I think it's "the vector", no

[virtio-dev] RE: [PATCH v1] transport-mmio: Replace virtual queue with virtqueue

2023-04-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, April 19, 2023 3:13 AM > > On Wed, Apr 19, 2023 at 04:56:38AM +0300, Parav Pandit wrote: > > Basic facilities define the virtqueue construct for device <-> driver > > communication. > > > > PCI transport and individual devices description also refer

[virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Michael S. Tsirkin
On Wed, Apr 19, 2023 at 01:35:32PM +, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Wednesday, April 19, 2023 9:33 AM > > > > On Tue, Apr 11 2023, Parav Pandit wrote: > > > > > Queue is a verb and noun both. Replacing it with enqueue avoids > > > ambiguity around plural queues no

[virtio-dev] RE: [PATCH v14 02/11] content.tex Replace virtqueue number with index

2023-04-19 Thread Parav Pandit
> From: Halil Pasic > Sent: Wednesday, April 19, 2023 12:09 PM > > When VIRTIO_F_NOTIFICATION_DATA has not been negotiated, this > > notification involves sending the -virtqueue number to the device > > (method depending on the transport). > > +virtqueue index to the device (method depending

[virtio-dev] Re: [PATCH v14 02/11] content.tex Replace virtqueue number with index

2023-04-19 Thread Halil Pasic
On Wed, 19 Apr 2023 04:46:30 +0300 Parav Pandit wrote: > Replace virtqueue number with index to align to rest of the > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > > --- > changelog: > v11->v12: > - new patch > --- > content.tex

Re: [virtio-dev] Virtio-loopback: PoC of a new Hardware Abstraction Layer for non-Hypervisor environments based on Virtio

2023-04-19 Thread Timos Ampelikiotis
Hello Xuan, The main differences between virtio-loopback and vDUSE are mainly: 1) the data sharing mechanism 2) the Virtio/Vhost-user devices which are supported by each solution In particular, Virtio-loopback implements a zero-copy memory mapping mechanism, the data are directly accessible b

[virtio-dev] RE: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Parav Pandit
> From: Cornelia Huck > Sent: Wednesday, April 19, 2023 9:33 AM > > On Tue, Apr 11 2023, Parav Pandit wrote: > > > Queue is a verb and noun both. Replacing it with enqueue avoids > > ambiguity around plural queues noun vs verb; similar to virtio fs > > device description. > > Personally, I d

[virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Cornelia Huck
On Tue, Apr 11 2023, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. Personally, I don't think this patch adds much, but I don't really mind it, either. > > Suggested-

Re: [virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description

2023-04-19 Thread Michael S. Tsirkin
On Wed, Apr 19, 2023 at 04:25:13PM +0800, Zhu, Lingshan wrote: > > > On 4/19/2023 3:05 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 11, 2023 at 10:42:19PM +0300, Parav Pandit wrote: > > > config_msix_vector is the register that holds the MSI-X vector number > > > for receiving configuration chan

Re: [virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description

2023-04-19 Thread Zhu, Lingshan
On 4/19/2023 3:05 PM, Michael S. Tsirkin wrote: On Tue, Apr 11, 2023 at 10:42:19PM +0300, Parav Pandit wrote: config_msix_vector is the register that holds the MSI-X vector number for receiving configuration change related interrupts. It is not "for MSI-X". Hence, replace the confusing text

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-19 Thread Alexander Gordeev
On 17.04.23 16:43, Cornelia Huck wrote: On Mon, Apr 17 2023, Alexander Gordeev wrote: Hi Alexandre, Thanks for you letter! Sorry, it took me some time to write an answer. First of all I'd like to describe my perspective a little bit because it seems, that in many cases we (and other people

[virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 11:03:58PM +0300, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. > > Suggested-by: Michael S. Tsirkin Heh, kind of. but ok. > Signed-off-by: P

[virtio-dev] Re: [PATCH v1] transport-mmio: Replace virtual queue with virtqueue

2023-04-19 Thread Michael S. Tsirkin
On Wed, Apr 19, 2023 at 04:56:38AM +0300, Parav Pandit wrote: > Basic facilities define the virtqueue construct for device <-> driver > communication. > > PCI transport and individual devices description also refers to it as > virtqueue. > > MMIO refers to it as 'virtual queue'. > > Align MMIO t

[virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description

2023-04-19 Thread Michael S. Tsirkin
On Wed, Apr 19, 2023 at 03:05:11AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 11, 2023 at 10:42:19PM +0300, Parav Pandit wrote: > > config_msix_vector is the register that holds the MSI-X vector number > > for receiving configuration change related interrupts. > > > > It is not "for MSI-X". >

[virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc

2023-04-19 Thread Michael S. Tsirkin
On Wed, Apr 19, 2023 at 03:08:30AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 11, 2023 at 10:42:20PM +0300, Parav Pandit wrote: > > queue_msix_vector register is for receiving interrupts from the device > > for the virtqueue. > > > > "for MSI-X" is confusing term. > > > > Also it is the regis

[virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc

2023-04-19 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 10:42:20PM +0300, Parav Pandit wrote: > queue_msix_vector register is for receiving interrupts from the device > for the virtqueue. > > "for MSI-X" is confusing term. > > Also it is the register that driver "writes" to, similar to > many other registers such as queue_desc,

[virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description

2023-04-19 Thread Michael S. Tsirkin
On Tue, Apr 11, 2023 at 10:42:19PM +0300, Parav Pandit wrote: > config_msix_vector is the register that holds the MSI-X vector number > for receiving configuration change related interrupts. > > It is not "for MSI-X". > > Hence, replace the confusing text with appropriate one. > > Reviewed-by: M