Re: [vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2017-01-01 Thread Klaus Schmidinger
On 28.12.2016 15:26, glenvt18 wrote: Just an observation. That code from vdr.c that calls GetDeviceForTransponder() (for example, when a VPS timer is about to start) can only interrupt tasks with priority < LIVEPRIORITY anyway. It looks like disabling priority checking can't do much harm here. Is

Re: [vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2016-12-28 Thread glenvt18
Just an observation. That code from vdr.c that calls GetDeviceForTransponder() (for example, when a VPS timer is about to start) can only interrupt tasks with priority < LIVEPRIORITY anyway. It looks like disabling priority checking can't do much harm here. Is that what you originally meant? BTW.

Re: [vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2016-12-27 Thread Klaus Schmidinger
On 22.12.2016 16:07, glenvt18 wrote: I understand. But this code looks confusing (at least). And, just to draw your attention, there is no priority checking here unless MaySwitchTransponder() returns true on the second call (which would be really ugly). Thus, for example, this code (vdr.c:1109)

Re: [vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2016-12-22 Thread glenvt18
I understand. But this code looks confusing (at least). And, just to draw your attention, there is no priority checking here unless MaySwitchTransponder() returns true on the second call (which would be really ugly). Thus, for example, this code (vdr.c:1109) if (NeedsTransponder |

Re: [vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2016-12-22 Thread Klaus Schmidinger
On 26.05.2016 17:58, glenvt18 wrote: d->MaySwitchTransponder(Channel) is always false here Please review, Sergey Chernyavskiy. --- device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device.c b/device.c index 18867cd..542d120 100644 --- a/device.c +++ b/device.c @@ -34

[vdr] [PATCH] cDevice::GetDeviceForTransponder(): fix a typo

2016-05-26 Thread glenvt18
d->MaySwitchTransponder(Channel) is always false here Please review, Sergey Chernyavskiy. --- device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device.c b/device.c index 18867cd..542d120 100644 --- a/device.c +++ b/device.c @@ -342,7 +342,7 @@ cDevice *cDevice::GetDevi