Re: [v8-users] git cl upload fails on cpplint preexisting errors

2018-05-02 Thread 'Hidy Han' via v8-users
Ah, I realize a wrong cpplint.py in /usr/bin was used. I adjusted my PATH order. Thanks, Jakob! On Wednesday, May 2, 2018 at 4:51:08 PM UTC-7, Jakob Kummerow wrote: > > "git cl lint" is known not to work for V8, becauses it doesn't go through > tools/presubmit.py which defines a few skipped lint

Re: [v8-users] git cl upload fails on cpplint preexisting errors

2018-05-02 Thread Jakob Kummerow
"git cl lint" is known not to work for V8, becauses it doesn't go through tools/presubmit.py which defines a few skipped linting rules (explaining the reports you're seeing). "git cl presubmit" should work. "tools/presubmit.py" should work too. What does "which cpplint.py" return? It should find