Ah, I realize a wrong cpplint.py in /usr/bin was used. I adjusted my PATH order. Thanks, Jakob!
On Wednesday, May 2, 2018 at 4:51:08 PM UTC-7, Jakob Kummerow wrote: > > "git cl lint" is known not to work for V8, becauses it doesn't go through > tools/presubmit.py which defines a few skipped linting rules (explaining > the reports you're seeing). > > "git cl presubmit" should work. > > "tools/presubmit.py" should work too. What does "which cpplint.py" return? > It should find the cpplint.py in depot_tools. > > On Wed, May 2, 2018 at 2:21 PM 'Hidy Han' via v8-users < > v8-u...@googlegroups.com <javascript:>> wrote: > >> When I run git cl upload, presubmit fails due to lint checker. git cl >> lint gives some errors on preexisting code: >> >> include/v8-inspector.h:5: #ifndef header guard has wrong style, please >> use: INCLUDE_V8_INSPECTOR_H_ [build/header_guard] [5] >> include/v8-inspector.h:290: #endif line should be "#endif // >> INCLUDE_V8_INSPECTOR_H_" [build/header_guard] [5] >> include/v8-inspector.h:228: Add #include <utility> for pair<> >> [build/include_what_you_use] [4] >> include/v8-inspector.h:66: Add #include <string> for string >> [build/include_what_you_use] [4] >> include/v8-inspector.h:147: Add #include <vector> for vector<> >> [build/include_what_you_use] [4] >> Done processing include/v8-inspector.h >> src/inspector/v8-stack-trace-impl.cc:276: Add #include <string> for >> string [build/include_what_you_use] [4] >> src/inspector/v8-stack-trace-impl.cc:372: Add #include <utility> for >> move [build/include_what_you_use] [4] >> Done processing src/inspector/v8-stack-trace-impl.cc >> Total errors found: 7 >> >> git cl presubmit -v shows that errors are found by ~/v8/v8/PRESUBMIT.py. >> If I run tools/presubmit.py, C++ lint check shows "Failed to process ..." >> on all files. >> >> Does someone know what is this error about? >> Thanks! >> >> -- >> -- >> v8-users mailing list >> v8-u...@googlegroups.com <javascript:> >> http://groups.google.com/group/v8-users >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-users+u...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
