Re: [v8-users] Seg Fault Checking If a Value is a String

2020-02-26 Thread Jakob Kummerow
V8_31BIT_SMIS_ON_64BIT_ARCH is a dependency of V8_COMPRESS_POINTERS, but you don't need to set it separately, as it is implied by the latter. (They are split because we wanted to be able to test the former without the latter.) On Wed, Feb 26, 2020 at 4:13 AM Joel Scarfone wrote: > Looks like it

Re: [v8-users] Seg Fault Checking If a Value is a String

2020-02-25 Thread Joel Scarfone
Looks like it was the V8_COMPRESS_POINTERS define. I didn't use V8_31BIT_SMIS_ON_64BIT_ARCH however, could you elaborate more on what that define does? On Tuesday, 25 February 2020 17:12:05 UTC-5, Ben Noordhuis wrote: > > On Mon, Feb 24, 2020 at 7:35 PM Joel Scarfone > wrote: > > > > V8 Vers

Re: [v8-users] Seg Fault Checking If a Value is a String

2020-02-25 Thread Ben Noordhuis
On Mon, Feb 24, 2020 at 7:35 PM Joel Scarfone wrote: > > V8 Version: 8.0.426.23 > > Hi all! When updating V8 I found a segmentation fault in tests. I managed to > reproduce it with the following code (initialization code stripped, can > provide full example upon request): > > Local str = String

[v8-users] Seg Fault Checking If a Value is a String

2020-02-24 Thread Joel Scarfone
V8 Version: 8.0.426.23 Hi all! When updating V8 I found a segmentation fault in tests. I managed to reproduce it with the following code (initialization code stripped, can provide full example upon request): Local str = String::NewFromUtf8(isolate, "Hello", v8::NewStringType::kNormal)