V8_31BIT_SMIS_ON_64BIT_ARCH is a dependency of V8_COMPRESS_POINTERS, but you don't need to set it separately, as it is implied by the latter. (They are split because we wanted to be able to test the former without the latter.)
On Wed, Feb 26, 2020 at 4:13 AM Joel Scarfone <[email protected]> wrote: > Looks like it was the V8_COMPRESS_POINTERS define. I didn't use > V8_31BIT_SMIS_ON_64BIT_ARCH however, could you elaborate more on what that > define does? > > On Tuesday, 25 February 2020 17:12:05 UTC-5, Ben Noordhuis wrote: >> >> On Mon, Feb 24, 2020 at 7:35 PM Joel Scarfone <[email protected]> >> wrote: >> > >> > V8 Version: 8.0.426.23 >> > >> > Hi all! When updating V8 I found a segmentation fault in tests. I >> managed to reproduce it with the following code (initialization code >> stripped, can provide full example upon request): >> > >> > Local<String> str = String::NewFromUtf8(isolate, "Hello", >> v8::NewStringType::kNormal) >> > .ToLocalChecked(); Local<Value> val = Local<Value>::Cast(str); >> Persistent<Value> persistentVal(isolate, val); >> persistentVal.Get(isolate)->IsString(); // seg fault >> > >> > >> > This worked on previous version. Is this now invalid? >> >> Can you verify that V8 and your code are compiled using the same >> compiler flags? More specifically: defines? >> >> A number of people have reported crashes after recent upgrades that >> could be traced back to V8 turning on pointer compression but the >> downstream projects missing the requisite V8_COMPRESS_POINTERS and >> V8_31BIT_SMIS_ON_64BIT_ARCH defines. >> > -- > -- > v8-users mailing list > [email protected] > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-users/8a7a1a0e-bb0d-4044-8301-8bb9b7d01b2f%40googlegroups.com > <https://groups.google.com/d/msgid/v8-users/8a7a1a0e-bb0d-4044-8301-8bb9b7d01b2f%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAKSzg3S%3DaV%2BD-Dm7TGKuSTkeTcVd9uFg3Y1GFT2WpXR4TgksBw%40mail.gmail.com.
