Re: [blink-dev] Re: [v8-dev] Re: [v8-users] Intent to Ship: Intl.Segmenter

2020-08-21 Thread Chris Harrelson
LGTM2 On Fri, Aug 21, 2020 at 12:24 PM Yoav Weiss wrote: > *LGTM1* > > On Fri, Aug 21, 2020 at 6:43 PM Joshua Bell wrote: > >> >> >> On Fri, Aug 21, 2020 at 1:16 AM Ross Kirsling >> wrote: >> >>> >>> >>> On Fri, Aug 21, 2020 at 12:05 AM Frank Tang wrote: >>> On Tue, Aug 18, 202

Re: [blink-dev] Re: [v8-dev] Re: [v8-users] Intent to Ship: Intl.Segmenter

2020-08-21 Thread Yoav Weiss
*LGTM1* On Fri, Aug 21, 2020 at 6:43 PM Joshua Bell wrote: > > > On Fri, Aug 21, 2020 at 1:16 AM Ross Kirsling wrote: > >> >> >> On Fri, Aug 21, 2020 at 12:05 AM Frank Tang wrote: >> >>> >>> >>> On Tue, Aug 18, 2020 at 1:33 AM Yoav Weiss wrote: >>> On Tue, Aug 18, 2020 at 1:10

Re: [v8-dev] Re: [v8-users] Intent to Ship: Intl.Segmenter

2020-08-21 Thread Frank Tang
On Fri, Aug 21, 2020 at 1:15 AM Ross Kirsling wrote: > > > On Fri, Aug 21, 2020 at 12:05 AM Frank Tang wrote: > >> >> >> On Tue, Aug 18, 2020 at 1:33 AM Yoav Weiss wrote: >> >>> >>> >>> On Tue, Aug 18, 2020 at 1:10 AM Frank Tang wrote: >>> For m87 Contact emailsft...@chromium.or

[v8-users] Re: Debugging embedded V8 with ChromeDevTools

2020-08-21 Thread Elmi Ahmadov
There could a few things that influence cut off messages, could you please post how do you convert V8 `StringBuffer` message to a string format that Boost can send to CDT. you have to implement `runMessageLoopOnPause` and `schedulePauseOnNextStatement` methods to stop the execution. If you don'

[v8-users] Re: Debugging embedded V8 with ChromeDevTools

2020-08-21 Thread Immanuel Haffner
Hi Elmi, I am using boost web sockets now, just like you do ;) So cut off messages are not the fault of sockpp. In the "Console" tab of CDT i see an error Connection is closed, can't dispatch pending call I suspect that V8 simply finished execution, in which case I stop the WebSocket server a

[v8-users] Re: Debugging embedded V8 with ChromeDevTools

2020-08-21 Thread Elmi Ahmadov
Hi Immanuel, Seems the messages that come from V8 instance are cut off, maybe because of sockpp. They are also not complete, there should be a response for each request but in your case there are only 3 responses. The logic to wait the V8 instance should be done in `runMessageLoopOnPause` meth

Re: [v8-dev] Re: [v8-users] Intent to Ship: Intl.Segmenter

2020-08-21 Thread Ross Kirsling
On Fri, Aug 21, 2020 at 12:05 AM Frank Tang wrote: > > > On Tue, Aug 18, 2020 at 1:33 AM Yoav Weiss wrote: > >> >> >> On Tue, Aug 18, 2020 at 1:10 AM Frank Tang wrote: >> >>> For m87 >>> >>> Contact emailsft...@chromium.org, s...@chromium.org >>> >>> Explainer >>> https://github.com/tc39/propos

[v8-users] Re: Debugging embedded V8 with ChromeDevTools

2020-08-21 Thread Immanuel Haffner
Here is what the network messages in CDT look like: [image: cdt_network.png] I guess the execution doesn't wait for CDT. My WebAssembly function is executed right away and the connection is closed. How do I make my `v8::Isolate` instance wait for commands from CDT? Am Donnerstag, 20. August 202

Re: [v8-dev] Re: [v8-users] Intent to Ship: Intl.Segmenter

2020-08-21 Thread Frank Tang
On Tue, Aug 18, 2020 at 1:33 AM Yoav Weiss wrote: > > > On Tue, Aug 18, 2020 at 1:10 AM Frank Tang wrote: > >> For m87 >> >> Contact emailsft...@chromium.org, s...@chromium.org >> >> Explainer >> https://github.com/tc39/proposal-intl-segmenter >> >> Specificationhttps://tc39.github.io/proposal-i