Tim is right that we don't need to restore flags before AC_MSG_ERROR
because it's going to abort.
Here's some other comments (based on line numbers from the v1.2 branch):
- I'm not sure why you removed PTHREAD_LIBS="$pl" on line 483?
- Why move LIBS="$orig_LIBS" away from line 538? Don't you
On Thu, 2007-09-27 at 14:18 -0400, Tim Prins wrote:
> Åke Sandgren wrote:
> > On Thu, 2007-09-27 at 09:09 -0400, Tim Prins wrote:
> >> Hi Ake,
> >>
> >> Looking at the svn logs it looks like you reported the problems with
> >> these checks quite a while ago and we fixed them (in r13773
> >> https
Åke Sandgren wrote:
On Thu, 2007-09-27 at 09:09 -0400, Tim Prins wrote:
Hi Ake,
Looking at the svn logs it looks like you reported the problems with
these checks quite a while ago and we fixed them (in r13773
https://svn.open-mpi.org/trac/ompi/changeset/13773), but we never moved
them to the
On Thu, 2007-09-27 at 09:09 -0400, Tim Prins wrote:
> Hi Ake,
>
> Looking at the svn logs it looks like you reported the problems with
> these checks quite a while ago and we fixed them (in r13773
> https://svn.open-mpi.org/trac/ompi/changeset/13773), but we never moved
> them to the 1.2 branch
Hi Ake,
Looking at the svn logs it looks like you reported the problems with
these checks quite a while ago and we fixed them (in r13773
https://svn.open-mpi.org/trac/ompi/changeset/13773), but we never moved
them to the 1.2 branch.
I will ask for this to be moved to the 1.2 branch.
However
Hi!
There are a couple of bugs in the configure scripts regarding threads
checking.
In ompi_check_pthread_pids.m4 the actual code for testing is wrong and
is also missing a CFLAG save/add-THREAD_CFLAGS/restore resulting in the
linking always failing for the -pthread test with gcc.
config.log look
