Tim is right that we don't need to restore flags before AC_MSG_ERROR
because it's going to abort.
Here's some other comments (based on line numbers from the v1.2 branch):
- I'm not sure why you removed PTHREAD_LIBS="$pl" on line 483?
- Why move LIBS="$orig_LIBS" away from line 538? Don't you also need
it for the "success" case?
- Ditto for line 553.
On Sep 27, 2007, at 8:44 PM, Åke Sandgren wrote:
On Thu, 2007-09-27 at 14:18 -0400, Tim Prins wrote:
Åke Sandgren wrote:
On Thu, 2007-09-27 at 09:09 -0400, Tim Prins wrote:
Hi Ake,
Looking at the svn logs it looks like you reported the problems
with
these checks quite a while ago and we fixed them (in r13773
https://svn.open-mpi.org/trac/ompi/changeset/13773), but we
never moved
them to the 1.2 branch.
Yes, it's the same. Since i never saw it in the source i tried
once more
with some more explanations just in case :-)
I will ask for this to be moved to the 1.2 branch.
Good.
However, the changes made for ompi_config_pthreads.m4 are
different than
you are suggesting now. Is this changeset good enough, or are there
other changes you think should be made?
The ones i sent today are slightly more correct. There where 2
missing
LIBS="$orig_LIBS" in the failure cases.
But do we really need these? It looks like configure aborts in these
cases (I am not a autoconf wizard, so I could be completely wrong
here).
I don't know. I just put them in since it was the right thing to
do. And
there where other variables that was reset in those places.
--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se Phone: +46 90 7866134 Fax: +46 90 7866126
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
_______________________________________________
users mailing list
us...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/users
--
Jeff Squyres
Cisco Systems
