Re: Optimizing for many short connections

2022-06-07 Thread Clebert Suconic
the image.png you sent could not be delivered by the infra for some reason. It's rare an occasion where I affirm I am 100% sure about something. I usually always keep a margin for the changing my opinion, or just being wrong.. But on this case I am 1% sure you will hit the bug I fixed. The i

Re: Optimizing for many short connections

2022-06-07 Thread Ben Warrick
@Clebert: Thanks for finding this. Here is some more evidence for you. This is only one monkey on my back right now, but I do plan on upgrading. I'll get you some feedback for sure. If I can manage, I want to try reproducing this in a lower environment. [image: image.png] On Tue, Jun 7, 2022 at 5

Re: Optimizing for many short connections

2022-06-07 Thread Clebert Suconic
@Ben Warrick: BTW When I said "you are likely" hitting the bug, I was just using polite words... I am 100% sure you are hitting that condition by creating one session per message. You should definitely look to upgrade or cherry-pick the fix to your own branch. On Tue, Jun 7, 2022 at 3:14 PM Cleb

Re: Optimizing for many short connections

2022-06-07 Thread Clebert Suconic
The release candidate : https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.23.0 I would appreciate your feedback here or even better on the dev list at the voting thread. On Tue, Jun 7, 2022 at 12:52 PM Clebert Suconic wrote: > right, but since I'm just releasing it would be g

Re: Optimizing for many short connections

2022-06-07 Thread Clebert Suconic
right, but since I'm just releasing it would be great to hear his feedback on top of the release candidate itself. On Tue, Jun 7, 2022 at 12:38 PM Justin Bertram wrote: > > A snapshot [1] is always a possibility as well. > > > Justin > > [1] > https://repository.apache.org/content/repositories/sn

Re: Optimizing for many short connections

2022-06-07 Thread Justin Bertram
A snapshot [1] is always a possibility as well. Justin [1] https://repository.apache.org/content/repositories/snapshots/org/apache/activemq/apache-artemis/2.23.0-SNAPSHOT/ On Tue, Jun 7, 2022 at 11:34 AM Clebert Suconic wrote: > I am preparing artemis 2.23.0 at the moment... > > The way a rel

Re: Optimizing for many short connections

2022-06-07 Thread Clebert Suconic
I am preparing artemis 2.23.0 at the moment... The way a release works in apache, you send it for vote and it will be officially released after 72 hours of a passing vote. but you should have a candidate release today that you can try it out. Based on the current diffs it should be fairly safe for

Re: Optimizing for many short connections

2022-06-06 Thread Ben Warrick
Hi Clebert, Yeah, I can use whatever I want after I prove it out in lower environments. Thanks, Ben On Mon, Jun 6, 2022 at 10:06 PM Clebert Suconic wrote: > Can you use jdk 11? > > On Mon, Jun 6, 2022 at 8:32 PM Clebert Suconic > wrote: > > > You are likely hitting the bug I fixed at: > > >

Re: Optimizing for many short connections

2022-06-06 Thread Clebert Suconic
Can you use jdk 11? On Mon, Jun 6, 2022 at 8:32 PM Clebert Suconic wrote: > You are likely hitting the bug I fixed at: > > https://github.com/apache/activemq-artemis/pull/4098 > > I introduced a Thread Local Leakage. I thought by setting > threadLocal.set(null) I would be clearing it... and in f

Re: Optimizing for many short connections

2022-06-06 Thread Clebert Suconic
You are likely hitting the bug I fixed at: https://github.com/apache/activemq-artemis/pull/4098 I introduced a Thread Local Leakage. I thought by setting threadLocal.set(null) I would be clearing it... and in fact I just updated the threadLocal variable with null. That ThreadLocal is created for

Re: Optimizing for many short connections

2022-06-03 Thread Francesco Nigro
Some more info about it here https://netty.io/wiki/tcp-fast-open.html Given that Netty can makes use of it and Artemis can as well: if it's not present in the doc it means we need to expose it in the acceptor configuration (for epoll) and...we love contributions :) But I suggest first to give it a

Re: Optimizing for many short connections

2022-06-03 Thread Ben Warrick
Hi Francesco, I don't find anything in the Artemis docs about TCP_FAST_OPEN. It must not be an exposed configuration on Artemis? Where do I find more on this? Thanks, Ben On Fri, Jun 3, 2022 at 4:08 PM Francesco Nigro wrote: > Are coming, not commenting: typo introduced by the the phone, sorr

Re: Optimizing for many short connections

2022-06-03 Thread Francesco Nigro
Are coming, not commenting: typo introduced by the the phone, sorry! Il ven 3 giu 2022, 22:07 Francesco Nigro ha scritto: > Hi Ben, > > You can use TCP_FAST_OPEN on Artemis acceptors in case connections are > commenting from the came clients (I don't remember if is an exposes Netty > configurati

Re: Optimizing for many short connections

2022-06-03 Thread Francesco Nigro
Hi Ben, You can use TCP_FAST_OPEN on Artemis acceptors in case connections are commenting from the came clients (I don't remember if is an exposes Netty configuration) or...submit a PR to let Artemis separate (multiple) threads to accept connections but, as you said, this is just an anti-pattern a

Optimizing for many short connections

2022-06-03 Thread Ben Warrick
I'm running Artemis 2.14, and one of the systems publishing to it creates a lot of separate tasks -- from its perspective. I can see on Artemis that the Total connection count vs Total messages acknowledged is pretty close, so it's apparent that the client system is making use of the anti-pattern o