Re: S2-015 actionCleanup too many warnings

2013-06-08 Thread Maurizio Cucchiara
It should be already fixed. Please see DefaultActionMapper [1] and WW-4098 [2] [1] http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java?r1=1490149&r2=1490165&diff_format=h [2] https://issues.apache.org/jira/browse/WW-40

Re: S2-015 actionCleanup too many warnings

2013-06-07 Thread Antonios Gkogkakis
The reason behind the regex is to avoid injecting java code with ognl in action names see http://struts.apache.org/release/2.3.x/docs/s2-015.html for details On 7 June 2013 16:54, Dave Newton wrote: > Personally, I don't think it matters if it starts with an uppercase, a > number, an underscor

Re: S2-015 actionCleanup too many warnings

2013-06-07 Thread Dave Newton
Personally, I don't think it matters if it starts with an uppercase, a number, an underscore, etc. What was the original reason behind the regex? To normalize the names? On Jun 7, 2013 11:41 AM, "Antonios Gkogkakis" wrote: > You are right, but I didn't want to restrict it to just camelCase. My p

Re: S2-015 actionCleanup too many warnings

2013-06-07 Thread Antonios Gkogkakis
You are right, but I didn't want to restrict it to just camelCase. My point was that the regex shipped with 2.3.14.3 may be too restrictive and it gives warnings for commonly used action names Antonios On 7 June 2013 16:32, Edward W. Rouse wrote: > I'm no regex guru but I think you mean "[a-z]

RE: S2-015 actionCleanup too many warnings

2013-06-07 Thread Edward W. Rouse
I'm no regex guru but I think you mean "[a-z]*[ a-zA-Z0-9]*[.\\-_!/]*" to prevent starting with a number or uppercase. > -Original Message- > From: Antonios Gkogkakis [mailto:gkogk...@tcd.ie] > Sent: Friday, June 07, 2013 7:41 AM > To: Struts Users Mailing List > Subject: S2-015 actionClea