The reason behind the regex is to avoid injecting java code with ognl in action names
see http://struts.apache.org/release/2.3.x/docs/s2-015.html for details On 7 June 2013 16:54, Dave Newton <davelnew...@gmail.com> wrote: > Personally, I don't think it matters if it starts with an uppercase, a > number, an underscore, etc. > > What was the original reason behind the regex? To normalize the names? > On Jun 7, 2013 11:41 AM, "Antonios Gkogkakis" <gkogk...@tcd.ie> wrote: > > > You are right, but I didn't want to restrict it to just camelCase. My > point > > was that the regex shipped with 2.3.14.3 may be too restrictive and > > it gives warnings for commonly used action names > > > > Antonios > > > > > > On 7 June 2013 16:32, Edward W. Rouse <ero...@comsquared.com> wrote: > > > > > I'm no regex guru but I think you mean "[a-z]*[ a-zA-Z0-9]*[.\\-_!/]*" > to > > > prevent starting with a number or uppercase. > > > > > > > -----Original Message----- > > > > From: Antonios Gkogkakis [mailto:gkogk...@tcd.ie] > > > > Sent: Friday, June 07, 2013 7:41 AM > > > > To: Struts Users Mailing List > > > > Subject: S2-015 actionCleanup too many warnings > > > > > > > > Hi all, > > > > > > > > we updated to the latest version and everything works smoothly. > > > > > > > > A minor issue that we observed is that we get a lot of warning > messages > > > > from DefaultActionMapper#cleanupActionName that our action didn't > match > > > > the > > > > allowed names > > > > > > > > Our actions are named using camelCase e.g smsNotification, which I > > > > imagine > > > > is not unusual. > > > > > > > > The current regular expression used to match actions > > > > is "[a-z]*[A-Z]*[0-9]*[.\\-_!/]*" > > > > which doesn't allow camelCase. I think the authors meant something > > > > closer > > > > to [a-zA-Z0-9]*[.\\-_!/]* > > > > > > > > we have changed it through the constant and eliminated the warnings, > so > > > > I'm > > > > just sending it as a suggestion. > > > > > > > > Regards, > > > > Antonios > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: user-unsubscr...@struts.apache.org > > > For additional commands, e-mail: user-h...@struts.apache.org > > > > > > > > > > > >
