Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-08 Thread Shengkai Fang
Sorry for the typo... I mean it will not take too much time. Best, Shengkai Shengkai Fang 于2021年3月9日周二 上午10:25写道: > Hi, Yuval. > > I have opened a ticket about this[1]. But I don't think we have any > solution to solve. > > Do you have time to help us to solve this? I think it will take too mu

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-08 Thread Shengkai Fang
Hi, Yuval. I have opened a ticket about this[1]. But I don't think we have any solution to solve. Do you have time to help us to solve this? I think it will take too much time. [1] https://issues.apache.org/jira/browse/FLINK-21675 Yuval Itzchakov 于2021年3月8日周一 下午9:18写道: > Thank you Shenkai, >

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-08 Thread Yuval Itzchakov
Thank you Shenkai, That does explain what I'm seeing. Jark / Shenkai - Is there any workaround to get Flink to work with push watermarks and predicate pushdown until this is resolved? On Mon, Mar 8, 2021 at 4:54 AM Shengkai Fang wrote: > Hi, Yuval, Jark, Timo. > > Currently the watermark push d

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-07 Thread Shengkai Fang
Hi, Yuval, Jark, Timo. Currently the watermark push down happens in the logical rewrite phase but the filter push down happens in the local phase, which means the planner will first check the Filter push down and then check the watermark push down. I think we need a rule to transpose between the

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-07 Thread Yuval Itzchakov
Hi Jark, Even after implementing both, I don't see the watermark being pushed to the tablesource in the logical plan and avoids predicate pushdown from running. On Sun, Mar 7, 2021, 15:43 Jark Wu wrote: > Hi Yuval, > > That's correct you will always get a LogicalWatermarkAssigner if you > assig

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-07 Thread Jark Wu
Hi Yuval, That's correct you will always get a LogicalWatermarkAssigner if you assigned a watermark. If you implement SupportsWatermarkPushdown, the LogicalWatermarkAssigner will be pushed into TableSource, and then you can push Filter into source if source implement SupportsFilterPushdown. Best,

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-05 Thread Yuval Itzchakov
Hi Timo, After investigating this further, this is actually non related to implementing SupportsWatermarkPushdown. Once I create a TableSchema for my custom source's RowData, and assign it a watermark (see my example in the original mail), the plan will always include a LogicalWatermarkAssigner. T

Re: LocalWatermarkAssigner causes predicate pushdown to be skipped

2021-03-05 Thread Timo Walther
Hi Yuval, sorry that nobody replied earlier. Somehow your email fell through the cracks. If I understand you correctly, could would like to implement a table source that implements both `SupportsWatermarkPushDown` and `SupportsFilterPushDown`? The current behavior might be on purpose. Filt