[math] Add module-info.java

2024-03-14 Thread Gili Tzabari
Hi, I'd like Commons Math to add module-info.java to all the components. I noticed that you are adding a "Automatic-Module" entry in META-INF but this isn't enough for jlink (and related tools) to work properly. We absolutely need to add module-info.java. You just need to add a few lines to

Re: [math] Add module-info.java

2024-03-14 Thread Gary Gregory
The commons-parent POM automatically creates module-info.java files. A Commons component should not have to do anything beyond using a recent version. Gary On Thu, Mar 14, 2024, 8:03 PM Gili Tzabari wrote: > Hi, > > I'd like Commons Math to add module-info.java to all the components. I > notice

Re: [math] Add module-info.java

2024-03-14 Thread Gili
Hi Gary, I noticed that you are generating both Automatic-Module and module-info.java. Isn't this problematic? Shouldn't you drop the automatic module? Also, I don't see the root pom adding any "export" statement to the module-info file. Has anyone tested that thr output actually works as expecte