Hi Gary, I noticed that you are generating both Automatic-Module and module-info.java. Isn't this problematic? Shouldn't you drop the automatic module?
Also, I don't see the root pom adding any "export" statement to the module-info file. Has anyone tested that thr output actually works as expected? Gili On Thu, Mar 14, 2024, 20:50 Gary Gregory <garydgreg...@gmail.com> wrote: > The commons-parent POM automatically creates module-info.java files. A > Commons component should not have to do anything beyond using a recent > version. > > Gary > > On Thu, Mar 14, 2024, 8:03 PM Gili Tzabari <gili.tzab...@gmail.com> wrote: > > > Hi, > > > > I'd like Commons Math to add module-info.java to all the components. I > > noticed that you are adding a "Automatic-Module" entry in META-INF but > > this isn't enough for jlink (and related tools) to work properly. We > > absolutely need to add module-info.java. > > > > You just need to add a few lines to pom.xml to turn your releases into > > multirelease JAR files and you're done. Here is the code I lifted from > > > > > https://medium.com/@ankitagrahari.rkgit/multi-release-functionality-8fc423b6c94e > > : > > > > |<execution> <id>java11</id> <goals><goal>compile</goal></goals> > > <configuration> <release>11</release> > > > <compileSourceRoots>${project.basedir}/src/main/java11</compileSourceRoots> > > > > <multiReleaseOutput>true</multiReleaseOutput> </configuration> > > </execution> | > > > > || > > > > |Gili| > > >
