This bug was fixed in the package cryptsetup - 2:2.2.2-3ubuntu2.5
---
cryptsetup (2:2.2.2-3ubuntu2.5) focal; urgency=medium
[ Chengen Du ]
* Refine proc mounts entries traversal (LP: #2054390)
- d/i/h/cryptroot: Backport upstream commit 95fd4be9b4c6: d/functions:
get_mnt
The proposed package in Focal has been successfully verified according
to the test plan, and the results align with expectations.
root@focal:~# apt policy cryptsetup-initramfs
cryptsetup-initramfs:
Installed: 2:2.2.2-3ubuntu2.5
Candidate: 2:2.2.2-3ubuntu2.5
Version table:
*** 2:2.2.2-3ubunt
Hello Chengen, or anyone else affected,
Accepted cryptsetup into focal-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/cryptsetup/2:2.2.2-3ubuntu2.5 in a
few hours, and then in the -proposed repository.
Please help us by testing this new package. See
> as well as the one for Focal currently in the upload queue, if
possible!
See my comment in
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/1830110/comments/13,
and let me know what you think please.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which
This bug was fixed in the package cryptsetup - 2:2.4.3-1ubuntu1.3
---
cryptsetup (2:2.4.3-1ubuntu1.3) jammy; urgency=medium
* Refine proc mounts entries traversal (LP: #2054390)
- d/functions: Backport upstream commit 95fd4be9b4c6: d/functions:
get_mnt_devno(): Speed up ex
> I'll work with Chengen (or someone else) on the autopkgtests in a
future SRU if that sounds agreeable
Yes, that works and would be awesome, thanks!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054
This bug was fixed in the package cryptsetup - 2:2.7.0-1ubuntu4.2
---
cryptsetup (2:2.7.0-1ubuntu4.2) noble; urgency=medium
* Refine proc mounts entries traversal (LP: #2054390)
- d/functions: Backport upstream commit 95fd4be9b4c6: d/functions:
get_mnt_devno(): Speed up ex
Hi Andreas,
thanks for the investigation! I think, given this bug is fairly old and
the autopkgtests have been disabled for Jammy, it would be preferable to
have the bug fixed. I'd like to see autopkgtests for Jammy fixed as
well, and have updated bug 1983522 accordingly.
I'll work with Chengen (
The jammy cryptsetup tests were disabled[1] due to LP: #1983522[2]. To
have them run again, we will need to backport the fixes from that bug to
jammy. This is something that could be staged in a follow-up SRU, or
added to this one.
Given this bug here is over a year old already, I suspect you woul
I don't understand the jammy cryptsetup autopkgtests, they are all
showing as "denylisted/blacklisted"[1]:
blacklisted cryptsetup/2:2.4.3-1ubuntu1.3 2025-02-07 18:37:26 UTC
0h 00m 00s - denylisted 9317151a-4566-4be6-aa74-035cacfebd0f
log artifacts ♻
The reported regression in Noble involves an error occurring while
processing the `mandos-client` package, which does not appear to be
related to this issue.
161s Setting up mandos-client (1.8.16-1ubuntu4) ...
170s gpg: key 5F3A09F160B7A22B was created 77 seconds in the future (time warp
or clock
Hello Chengen, or anyone else affected,
Accepted cryptsetup into noble-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/cryptsetup/2:2.7.0-1ubuntu4.2 in a
few hours, and then in the -proposed repository.
Please help us by testing this new package. See
Hi Chengen,
Apologies for taking long; I wanted to make sure this was well tested
before uploading. I've been running tests with encrypted rootfs using a
PPA with your patches [0], and didn't spot any regressions so far. I've
also confirmed the performance improvements according to the
description
** Changed in: cryptsetup (Ubuntu Focal)
Status: Incomplete => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054390
Title:
Refine proc mounts entries traversal
To manage notific
Hi Heitor,
As referenced in the corresponding bug report [1], the ZFS-related logic should
ideally be backported to Focal.
However, the reason for not doing so remains unclear.
Since the issue is unrelated to the reported bug, addressing it as part of this
fix might not be appropriate.
[1] http
** Description changed:
[Impact]
The shell's read builtin iterates through /proc/mounts one line at a time.
This becomes problematic when LDAP automount maps generate a large number of
entries in /proc/mounts. It can lead to timeout issues, especially when
iterating through the entries twic
Hi Chengen,
thanks for the additional details! The performance improvements are
considerable enough that I think we should attempt to SRU this. Some
comments before we proceed:
For Jammy/Noble, the patch has a ZFS-specific section. Is there a reason
why this isn't needed in Focal as well? AFAIK,
Hi Mauricio,
Thank you for the update. The test plan has been revised accordingly.
** Description changed:
[Impact]
The shell's read builtin iterates through /proc/mounts one line at a time.
This becomes problematic when LDAP automount maps generate a large number of
entries in /proc/mount
Also, it would be nice to measure/validate the performance improvement
with a fake, synthetic, very large /proc/mounts file (e.g., mount -o
bind /tmp/fake-mounts /proc/mounts), in the order of the problematic
LDAP file mentioned in the [Impact] section, since this is what the SRU
is about: i.e., ol
** Description changed:
[Impact]
- The shell's read builtin iterates through /proc/mounts one byte at a time.
This becomes problematic when LDAP automount maps generate a large number of
entries in /proc/mounts. It can lead to timeout issues, especially when
iterating through the entries twic
Hi Chengen,
I'm resuming the reviews for these SRUs.
At the moment, the Test Plan section is a bit vague:
Can you please clarify what is the expected output of running cryptroot?
And IMHO it could be improved with a specific test for regressions (the key
point in SRUs is to maintain stability/a
The proposed change is already applied in Oracular and Plucky.
$ rmadison -a source cryptsetup
...
cryptsetup | 2:2.7.2-2ubuntu1 | oracular | source
cryptsetup | 2:2.7.2-2ubuntu1 | plucky | source
$ pull-lp-source cryptsetup
Found cryptsetup 2:2.7.2-2ubuntu1 in plucky
$ grep
Debdiff for Noble
** Patch added:
"lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5837060/+files/lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
--
You r
Debdiff for Jammy
** Patch added:
"lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5837059/+files/lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
--
You r
Debdiff for Focal
** Patch removed: "lp2054390_focal_refine_proc_mounts_entries_traversal.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5747548/+files/lp2054390_focal_refine_proc_mounts_entries_traversal.debdiff
** Patch removed: "lp2054390_jammy_refin
@mfo Could you please find some time to verify this patch? The patch set
is lp2054390-XXX-d-functions-get_mnt_devno-Speed-up-execution-time-
on.debdiff. Your assistance would be greatly appreciated.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed
There are no issues with the patch; it turned out to be a
misunderstanding. We are currently awaiting the SE sponsor's review.
** Changed in: cryptsetup (Ubuntu Focal)
Status: Incomplete => In Progress
** Changed in: cryptsetup (Ubuntu Jammy)
Status: Incomplete => In Progress
** Ch
Ubuntu 23.10 (Mantic Minotaur) has reached end of life, so this bug will
not be fixed for that specific release.
** Changed in: cryptsetup (Ubuntu Mantic)
Status: Incomplete => Won't Fix
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Removed subscription of ubuntu-sponsors.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054390
Title:
Refine proc mounts entries traversal
To manage notifications about this bug go to:
https://bugs
No, please ignore it for now; there's an issue/regression identified in
the patch.
** Changed in: cryptsetup (Ubuntu Noble)
Status: In Progress => Incomplete
** Changed in: cryptsetup (Ubuntu Mantic)
Status: In Progress => Incomplete
** Changed in: cryptsetup (Ubuntu Jammy)
Is this ready for review/sponsoring?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054390
Title:
Refine proc mounts entries traversal
To manage notifications about this bug go to:
https://bugs.lau
Following the discussion with the SRU sponsor (i.e., @mfo/@halves), the
SRU will be put on hold until the Noble release. The patch is not
considered critical for the release, as it focuses on optimization
rather than bug fixes. It would be advantageous to opt for a safer
approach, allowing for addi
** Description changed:
[Impact]
- When LDAP automount maps generate a substantial number of entries in
/proc/mounts, it has the potential to induce a timeout issue, particularly
during the process of iterating through the entries twice in the cryptroot hook.
+ The shell's read builtin iterate
Debdiff for Noble
** Patch added:
"lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761411/+files/lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
** Change
Upstream has merged the patch [1]. I have backported the new patch for
SRU.
[1] https://salsa.debian.org/cryptsetup-
team/cryptsetup/-/merge_requests/36
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2
Debdiff for Mantic
** Patch added:
"lp2054390-mantic-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761410/+files/lp2054390-mantic-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
--
Yo
Debdiff for Jammy
** Patch added:
"lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761409/+files/lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
--
You r
Debdiff for Focal
** Patch added:
"lp2054390-focal-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff"
https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761407/+files/lp2054390-focal-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff
--
You r
Unsubscribing ~ubuntu-sponsors for now. Please re-subscribe once ready.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054390
Title:
Refine proc mounts entries traversal
To manage notifications abo
blocked per last comment.
** Changed in: cryptsetup (Ubuntu Noble)
Status: In Progress => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054390
Title:
Refine proc mounts entries t
There is some feedback from upstream regarding this implementation [1].
Before proceeding with the SRU process, I will reach out to them to
confirm that the patch won't introduce any regressions. I'll keep the
bug updated with their response.
[1] https://salsa.debian.org/cryptsetup-
team/cryptsetu
41 matches
Mail list logo
