Review: Approve
looks reasonable, ack!
--
https://code.launchpad.net/~pfsmorigo/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/393571
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubu
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 233ee46..c06b93a 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -2908,12 +2916,19 @@ def find_latest_release(release_num, iso_type):
>
> text = re.compile(r'<[^>]+>').sub('', html).split('\n')
> matches = []
>
I just ripped out domifaddr support because we wanted to standardize on the
same configuration for everyone and domifaddr support was limited and wouldn't
allow resolving from the host.
https://git.launchpad.net/ubuntu-qa-tools/commit/vm-tools/uvt?id=43be4941455b466d7be5e263ee6f345be7377277
Per
Review: Needs Fixing
I'd be pretty surprised if a tool created an ssh key for me without asking,
could you please ask the user first for confirmation and specify where and what
type of key will be created?
Make sure you create the .ssh directory with 700 permissions.
--
https://code.launchpad.
Review: Approve
Looks good, thanks!
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460670
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu
Review: Approve
Looks good, thanks!
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460672
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu
Review: Needs Fixing
Prompt looks good!
I would switch makedirs() to mkdir(), we shouldn't be creating the user home
directory, something clearly went wrong if we need to do that.
Please set permissions to 0o700 not 0o755, and use the mode parameter of
mkdir() instead of doing a separate chmod
Review: Approve
looks good, thanks!
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460669
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu
Yeah, I think prompting the user is best here too, especially since these
directories could be anywhere depending on what the user selected, and the use
of extended acls isn't immediately obvious.
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460694
Your tea
Review: Approve
Yep, looks good.
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460676
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bu
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460694
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bugco
Review: Approve
Yeah, pulling your branch doesn't show the conflict for me either...
The rest LGTM.
--
https://code.launchpad.net/~alexmurray/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/461223
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
I really don't want uvt to be available in the snap store. It's not meant for
general use, it does a whole bunch of things in an insecure fashion and
hardcodes a bunch of stuff in the virtual machines it creates.
I don't want to get bug reports about it. I don't want to get CVEs assigned to
it.
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 0702939..068df2f 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -1578,7 +1635,9 @@ def vm_start_wait(vm_name, timeout=1800, quiet=False,
> clone_name=None):
>
> def vm_ping(vm_name):
> '''Attempts to ping a VM'''
So, adding the uvt ssh command is fine. And you can add the ssh known host and
'StrictHostKeyChecking=accept-new' changes by default. The gpg --homedir option
by default is fine too, if it works properly with the updated $HOME.
The rest can be snap-specific behind is_snap()
--
https://code.lau
Does gpg --lock-never work?
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/462951
Your team Ubuntu Bug Control is requested to review the proposed merge of
~jslarraz/ubuntu-qa-tools:uvt-snap into ubuntu-qa-tools:master.
__
Diff comments:
> diff --git a/vm-tools/uvt b/vm-tools/uvt
> index 0702939..068df2f 100755
> --- a/vm-tools/uvt
> +++ b/vm-tools/uvt
> @@ -3341,9 +3412,11 @@ def check_required_tools():
>'kvm-ok' : 'cpu-checker',
>'gzip' : 'gzip',
>'c
Review: Approve
ACK, LGTM, thanks!
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/462951
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-
Review: Approve
LGTM, ack.
--
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/464752
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bugcontr
Review: Needs Fixing
This won't work with older python versions AFAIK:
>>> datetime.datetime.now(datetime.UTC).replace(tzinfo=None)
Traceback (most recent call last):
File "", line 1, in
AttributeError: module 'datetime' has no attribute 'UTC'
--
https://code.launchpad.net/~hlibk/ubuntu-qa-t
Use this instead:
datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None)
--
https://code.launchpad.net/~hlibk/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/477994
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
__
The proposal to merge ~hlibk/ubuntu-qa-tools:unembargo-warning into
ubuntu-qa-tools:master has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~hlibk/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/477994
--
Your team Ubuntu Bug Control is subscribed t
The proposal to merge ~hlibk/ubuntu-qa-tools:unembargo-warning into
ubuntu-qa-tools:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~hlibk/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/477994
--
Your team Ubuntu Bug Control is subscribed t
Review: Approve
Looks good, thanks!
--
https://code.launchpad.net/~hlibk/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/477994
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bu
The proposal to merge
~octagalland/ubuntu-qa-tools:unembargo_default_to_release_pocket_for_ppas into
ubuntu-qa-tools:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/479086
--
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/479086
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bu
@octagalland Thanks for the comment, I do think your explanation makes
sense...perhaps you could clean up the esm code that overrides the pocket since
it will no longer be necessary with your change?
--
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/479086
Yo
Which PPA are you trying to unembargo to? There's already code to handle
overriding the pocket when unembargoing to an ESM ppa, is that insufficient?
--
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/479086
Your team Ubuntu Bug Control is requested to review t
Review: Approve
LGTM, ack. Thanks!
--
https://code.launchpad.net/~iconstantin/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/484496
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubun
The proposal to merge ~iconstantin/ubuntu-qa-tools:add-embargo-check into
ubuntu-qa-tools:master has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~iconstantin/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/484496
--
Your team Ubuntu Bug Control is
The proposal to merge ~iconstantin/ubuntu-qa-tools:add-embargo-check into
ubuntu-qa-tools:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~iconstantin/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/484496
--
Your team Ubuntu Bug Control is
The proposal to merge ~alexmurray/ubuntu-qa-tools:uvt-upgrade-reliability-fix
into ubuntu-qa-tools:master has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~alexmurray/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/482614
--
Your team Ubuntu Bug Con
Review: Approve
Looks good, thanks Alex. Ack.
--
https://code.launchpad.net/~alexmurray/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/482614
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad
The proposal to merge ~alexmurray/ubuntu-qa-tools:uvt-upgrade-reliability-fix
into ubuntu-qa-tools:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~alexmurray/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/482614
--
Your team Ubuntu Bug Con
The proposal to merge ~elisehdy/ubuntu-qa-tools:uvt-username-fix into
ubuntu-qa-tools:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~elisehdy/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/486873
--
Your team Ubuntu Bug Control is sub
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~elisehdy/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/486873
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.
___
Mailing list: https://launchpad.net/~ubuntu-bugco
36 matches
Mail list logo
