Review: Needs Fixing

Prompt looks good!

I would switch makedirs() to mkdir(), we shouldn't be creating the user home 
directory, something clearly went wrong if we need to do that.

Please set permissions to 0o700 not 0o755, and use the mode parameter of 
mkdir() instead of doing a separate chmod.

Thanks!
-- 
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460669
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.


_______________________________________________
Mailing list: https://launchpad.net/~ubuntu-bugcontrol
Post to     : ubuntu-bugcontrol@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-bugcontrol
More help   : https://help.launchpad.net/ListHelp

Reply via email to