Re: [PATCH] cmd: go: Flush cache before jumping to app/image

2020-02-12 Thread Stefan
Hi Mauro, On 12.02.20 14:50, Mauro Condarelli wrote: Hi Stefan, On 2/12/20 2:22 PM, Stefan wrote: Hi Mauro, On 12.02.20 14:09, Mauro Condarelli wrote: Hi Daniel, Hi Stefan, I'll test this ASAP, but, in the meantime, please have a look at the strange (and perhaps related) code in arch

Re: [PATCH v5] Add support for SoM "VoCore2".

2020-02-12 Thread Stefan
ate mode 100644 include/configs/vocore2.h Apart from the other comments, the MAINTAINERS file is missing. Please add it in the next patch version. Thanks, Stefan

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Stefan
Hi Simon, On 13.02.20 08:40, Simon Goldschmidt wrote: Sorry if it seems I ignored this mail yesterday, I just found it now :) On Wed, Feb 12, 2020 at 10:05 AM Stefan Roese wrote: On 12.02.20 09:57, Weijie Gao wrote: And more general: why do we need to code this in every loader? I think

Re: [PATCH v5] Add support for SoM "VoCore2".

2020-02-13 Thread Stefan
On 13.02.20 10:18, Mauro Condarelli wrote: Thanks Stefan. On 2/13/20 7:50 AM, Stefan wrote: On 12.02.20 16:30, Mauro Condarelli wrote: Small patch series to add support for VoCore/VoCore2 board. VoCore is open hardware and runs OpenWrt/LEDE. It has WIFI, USB, UART, 20+ GPIOs but is only one

Fixing low-speed USB keyboard detection

2020-02-25 Thread Stefan
b1b018beb0c93f4c38c2985bc6 to workaround non-working keyboards. My suggested change will kind of revert that workaround. So there is some trade-off. Stefan

Re: Fixing low-speed USB keyboard detection

2020-02-29 Thread Stefan
bus 0 for devices..." was printed or otherwise there was the error "Timeout poll on interrupt endpoint" and the keyboard was not usable. This patch reverts the workaround from 5da2dc9789abecb1b018beb0c93f4c38c2985bc6 for non-working keyboards.” Stefan > Am 29.02.2020 um 13

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-11 Thread Stefan
ome files might have changes in the meantime. Thanks, Stefan Maybe this helps you with development. If you have a bootable patch set (you can do MMC later) for your VoCore2 board, please submit a regular patch series based on that branch so that we can review again. I *do* have a bootable patc

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-11 Thread Stefan
On 11.02.20 13:34, Mauro Condarelli wrote: Thanks for the fast answer, Stefan. On 2/11/20 12:16 PM, Stefan wrote: Hi Mauro, ===8< https://gitlab.denx.de/u-boot/custodians/u-boot-mips/commits/testing I tried to use this repo/branch, but something is wrong (or I goofed badly). Jus

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-11 Thread Stefan
use u-boot.bin. A quick remark on this, as I've forgotten to write about this: I would like to change the resulting image name from this specific "u-boot-mips.bin" to the already known "u-boot-with-spl.bin" name. There is no need to introduce a new name here and there is nothing "mtmips" specific in this image type. Thanks, Stefan

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-11 Thread Stefan
16. The u-boot-mips/testing is based on u-boot-mips/next and only contains Weijie's v3 patches from 14/20 to 20/20. For u-boot-mips/next I intend to create a pull request soon. The existing mtmips boards should still work without SPL support. Maybe Stefan could give it a quick test. Maybe I messed

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-12 Thread Stefan
Hi Mauro, On 12.02.20 10:23, Mauro Condarelli wrote: Hi Stefan, Hi Daniel, On 2/12/20 7:39 AM, Stefan wrote: Hi Mauro, Hi Daniel, On 11.02.20 19:05, Mauro Condarelli wrote: ===8<--- What *does NOT* work is loading RAM version or, to be more precise: It works IF (and only if) you load

Re: [PATCH] cmd: go: Flush cache before jumping to app/image

2020-02-12 Thread Stefan
Hi Daniel, On 12.02.20 14:00, Daniel Schwierzeck wrote: On Wed, Feb 12, 2020 at 1:21 PM Stefan Roese wrote: It has been noticed on MT7628/88 platforms, that booting the RAM image does not work reliably. Sometimes it works and sometimes not. Debugging showed that this "might"

Re: [PATCH] cmd: go: Flush cache before jumping to app/image

2020-02-12 Thread Stefan
Hi Mauro, On 12.02.20 14:09, Mauro Condarelli wrote: Hi Daniel, Hi Stefan, I'll test this ASAP, but, in the meantime, please have a look at the strange (and perhaps related) code in arch/mips/mach-mtmips/cpu.c You are most likely referring to the code in last_stage_init() that also

Re: [PATCH v3 00/20] Refactor the architecture parts of mt7628

2020-02-12 Thread Stefan
boot support for mtmips platform (respectively don't use the u-boot.bin intended for SPL payload as RAM boot binary) or we keep the special RAM boot configs. I assume that you are also okay with the cache flush approach? I'll send v2 of this patch pretty soon if nobody objects. Thanks, Stefan

Re: [U-Boot] [PATCH] drivers/net/4xx_enet.c: Fix build warning

2012-05-21 Thread stefan
n Cc: Joe Hershberger Acked-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] NAND: Remove ONFI detection message to from bootup log

2012-05-21 Thread stefan
On Fri, 18 May 2012 18:19:34 -0500, Scott Wood wrote: On Mon, May 07, 2012 at 09:29:30PM -, Stefan Roese wrote: Without this patch, boot shows this messages upon NAND detection: NAND: ONFI flash detected ONFI param page 0 valid ONFI flash detected ONFI param page 0 valid 128 MiB With

Re: [U-Boot] [PATCH V5 RESEND 0/3] mtd/NAND: Support for FSMC controller

2012-05-24 Thread stefan
moves the obsolete SPEAr specific driver. Are you okay with this patchset version? If yes, please go ahead and push it upstream via your repository. There are some other SPEAr related patches depending on this set that I would like to push. Thanks, S

[U-Boot] [PATCH 0/4] vybrid/tower fixes and enhancements

2014-03-11 Thread stefan
From: Stefan Agner This patch series addresses several fixes and enhancements for the vybrid tower. The patches are originally by Marcel Ziswiler which should remain the Author of the patches, I picked them up since some changes I'm going to submit are building upon them. Changes v3: - M

[U-Boot] [PATCH 2/4] arm: vf610: add uart0 clock/iomux definitions

2014-03-11 Thread stefan
From: Marcel Ziswiler Add CCM_CCGR0_UART0_CTRL_MASK clock definition and add TX/RX iomux definitions for UART0 (aka. SCI0). Signed-off-by: Marcel Ziswiler [ste...@agner.ch: regrouped patch] Signed-off-by: Stefan Agner --- arch/arm/include/asm/arch-vf610/crm_regs.h| 1 + arch/arm/include

[U-Boot] [PATCH 1/4] arm: vf610: fix anadig register struct

2014-03-11 Thread stefan
("&anadig->pll3_ctrl=0x%p\n", &anadig->pll3_ctrl); printf("&anadig->pll5_ctrl=0x%p\n", &anadig->pll5_ctrl); Signed-off-by: Marcel Ziswiler [ste...@agner.ch: regrouped patch] Signed-off-by: Stefan Agner --- arch/arm/include/asm/arch-vf610/crm_re

[U-Boot] [PATCH 4/4] arm: vf610: fix double iomux configuration for vf610twr board

2014-03-11 Thread stefan
From: Marcel Ziswiler Get rid of double VF610_PAD_DDR_A15__DDR_A_15 iomux configuration. Signed-off-by: Marcel Ziswiler --- board/freescale/vf610twr/vf610twr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c index 69

[U-Boot] [PATCH 3/4] arm: vf610: add enet1 support

2014-03-11 Thread stefan
- VF610_PAD_PTA6__RMII0_CLKOUT iomux definition required for internal (e.g. crystal-less) Ethernet clocking. Signed-off-by: Marcel Ziswiler [ste...@agner.ch: regrouped patch] Signed-off-by: Stefan Agner --- arch/arm/include/asm/arch-vf610/crm_regs.h| 4 arch/arm/include/asm/arch-vf610/imx-regs.h| 1

Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-17 Thread Stefan
ut that these are unexplained magic constants from Allwinner's code. Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] tools: make imxheader size align on page size

2014-04-16 Thread stefan
From: Stefan Agner The i.MX V2 headers total size is 0x7fc. The header is placed in front of the U-Boot binary which of course is aligned to text base. Hence the header starting point is not page aligned (e.g. at 0x3f400404). This is still a valid header, which boots fine using serial loader

[U-Boot] [PATCH] arm: vf610: add DDR_SEL_PAD_CONTR register

2014-04-23 Thread stefan
From: Stefan Agner Set DDR_SEL_PAD_CONTR register explicitly to DDR3 which solves RAM issues with newer silicon (1.1). This register was added in revision 4 of the Vybrid Reference Manual. Signed-off-by: Stefan Agner --- arch/arm/include/asm/arch-vf610/imx-regs.h | 1 + board/freescale

Re: [U-Boot] [PATCH v7 02/13] lib: strto: fix metric suffix parsing in strtoul[l]

2018-09-03 Thread Stefan
On 03.09.2018 08:49, Miquel Raynal wrote: Hi Stefan, Stefan Roese wrote on Sat, 1 Sep 2018 10:48:25 +0200: On 31.08.2018 16:57, Miquel Raynal wrote: While 1kB or 1kiB will be parsed correctly, 1k will return the right amount, but the metric suffix will not be escaped once the char pointer

Re: [U-Boot] [PATCH v7 10/13] cmd: mtd: add 'mtd' command

2018-09-03 Thread Stefan
On 03.09.2018 08:54, Miquel Raynal wrote: Hi Stefan, Stefan Roese wrote on Sat, 1 Sep 2018 10:59:56 +0200: On 31.08.2018 16:57, Miquel Raynal wrote: There should not be a 'nand' command, a 'sf' command and certainly not a new 'spi-nand' command. Write a '

Re: [U-Boot] [PATCH 2/4] serial: protect access to serial rx buffer

2018-09-03 Thread Stefan
Hi Patrick, On 03.09.2018 15:35, Patrick DELAUNAY wrote: Hi Simon and Stefan, Sorry for my late answer (I just come back from my summer holiday) From: s...@google.com On Behalf Of Simon Glass Sent: mercredi 8 août 2018 11:56 On 3 August 2018 at 05:38, Patrick Delaunay wrote: Add test to

Re: [U-Boot] [PATCH 2/4] serial: protect access to serial rx buffer

2018-09-04 Thread Stefan
Hi Patrick, On 04.09.2018 09:56, Patrick DELAUNAY wrote: Hi Stefan From: Stefan Sent: lundi 3 septembre 2018 16:03 Hi Patrick, On 03.09.2018 15:35, Patrick DELAUNAY wrote: Hi Simon and Stefan, Sorry for my late answer (I just come back from my summer holiday) From: s...@google.com On

Re: [U-Boot] [PATCH 1/6 v3] mips: Add basic MediaTek MT7620/88 support

2018-09-05 Thread Stefan
Hi Daniel, On 05.09.2018 13:45, Daniel Schwierzeck wrote: On 16.08.2018 15:27, Stefan Roese wrote: This patch adds basic support for the MediaTek MT7620/88 SoCs. Parts of the code is copied from the MediaTek GitHub repository: https://github.com/MediaTek-Labs/linkit-smart-uboot.git The

Re: [U-Boot] [RFC PATCH v1] mips: add atomic operations

2018-09-07 Thread Stefan
#x27;t have the time right now for this. Thanks, Stefan arch/mips/include/asm/atomic.h | 151 + 1 file changed, 151 insertions(+) create mode 100644 arch/mips/include/asm/atomic.h diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h

[U-Boot] [RFC PATCH] fpga: zynq: Add encrypted bitstream support with auto detect

2018-06-08 Thread stefan
From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- drivers/fpga/zynqpl.c | 73 --- 1 file changed, 57 insertions(+), 16 deletions(-) diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c index fd37d18..6622750 100644

Re: [U-Boot] [PATCH 0/4] Rationalise atomic.h implementations

2018-09-09 Thread Stefan
e/asm/atomic.h | 44 + include/asm-generic/atomic.h | 150 +++ 4 files changed, 153 insertions(+), 232 deletions(-) create mode 100644 include/asm-generic/atomic.h Thanks Chris for taking care of this. For the whole series: Reviewed-by: Stefan Roese T

Re: [U-Boot] [PATCH] Fix --noheader on fw_printenv

2018-02-08 Thread stefan
oot@nrr-922:~# fw_printenv -n arch > arm > > The single argument it's expecting isn't taken from getopt parsing, > but instead from the remaining argv arguments. That makes sense. But the commit log text above is kind of unrelated/not relevant, I would just use this two l

Re: [U-Boot] [PATCH 1/4] mtd: nand: mxs_nand: use self init

2018-01-30 Thread stefan
On 29.01.2018 17:01, Stefan Agner wrote: > From: Stefan Agner > > Instead of completing initialization via scan_bbt callback use > NAND self init to initialize the GPMI (MXS) NAND controller. > > Signed-off-by: Stefan Agner > --- > > drivers/mtd/nand/Kconfig

Re: [U-Boot] [PATCH] Convert CONFIG_APBH_DMA et al to Kconfig

2018-02-05 Thread stefan
MA_BURST8 if ARCH_MX6 || ARCH_MX7 With that, you should be able to implement your change with just removing APBH_DMA from the headers and adding the dependency to Kconfig files without any defconfig changes. -- Stefan > > Signed-off-by: Adam Ford > --- > configs/apx4devkit_d

Re: [U-Boot] [PATCH V2] Convert CONFIG_APBH_DMA et al to Kconfig

2018-02-05 Thread stefan
On 05.02.2018 14:33, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_APBH_DMA >CONFIG_APBH_DMA_BURST >CONFIG_APBH_DMA_BURST8 > > Signed-off-by: Adam Ford > --- > Changes in V2: > Rebase on [U-Boot,v2,1/6] Convert CONFIG_NAND_MXS to Kconfig > Make the NAND controller

Re: [U-Boot] [PATCH v2 1/6] Convert CONFIG_NAND_MXS to Kconfig

2018-02-05 Thread stefan
On 02.02.2018 22:44, Stefan Agner wrote: > From: Stefan Agner > > This converts CONFIG_NAND_MXS to Kconfig. > > Signed-off-by: Stefan Agner > --- > > Changes in v2: > - Extend the patchset with "Convert CONFIG_NAND_MXS to Kconfig" patch > > c

Re: [U-Boot] [PATCH V2] Convert CONFIG_APBH_DMA et al to Kconfig

2018-02-05 Thread stefan
| 1 + Just sent out a patchset ("arm: imx: convert MX23/28 and MXS NAND to Kconfig") which should properly convert NAND MXS to Kconfig. Can you rebase again? It really lead to no defconfig changes. Can you add me to cc in v3? Sorry for the hassle. -- Stefan > drivers/dma

Re: [U-Boot] [PATCH 1/4] arm: imx: mx23: Move MX23 selection to Kconfig

2018-02-06 Thread stefan
On 05.02.2018 23:05, Fabio Estevam wrote: > On Mon, Feb 5, 2018 at 7:33 PM, Stefan Agner wrote: > >> --- a/arch/arm/mach-imx/mx2/Kconfig >> +++ b/arch/arm/mach-imx/mx2/Kconfig > > mx23 and mx28 fits better into /arch/arm/mach-imx/mxs/Kconfig > >>

Re: [U-Boot] [PATCH V3] Convert CONFIG_APBH_DMA et al to Kconfig

2018-02-06 Thread stefan
On 06.02.2018 15:34, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_APBH_DMA >CONFIG_APBH_DMA_BURST >CONFIG_APBH_DMA_BURST8 > > Signed-off-by: Adam Ford Thanks, that looks good to me! Reviewed-by: Stefan Agner -- Stefan > --- > V

Re: [U-Boot] [PATCH v3 1/2] i.MX6: nand: add nandbcb update command

2018-02-07 Thread stefan
only a few write cycles on the first NAND block...). We then use U-Boot to write the firmware itself. It seems that firmware size in the BCB is not strictly required. Presumably the boot ROM uses the imx header to determine the size... Any thoughts? -- Stefan > > for nand boot, up on reset boo

Re: [PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

2023-02-22 Thread Stefan Roese
ABLED or CONFIG_IS_ENABLED instead? And I just checked that "bubt" is not compiled for CONFIG_BLK not defined. So please depend this file on CONFIG_BLK in Kconfig and remove the non CONFIG_BLK code here. Thanks, Stefan + +#ifdef CONFIG_SUPPORT_EMMC_BOOT +#ifdef CONFIG_BLK + orig

Re: [PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

2023-02-22 Thread Stefan Roese
Hi Pali, On 2/22/23 19:06, Pali Rohár wrote: On Wednesday 22 February 2023 10:55:54 Stefan Roese wrote: Hi Pali, On 2/21/23 21:18, Pali Rohár wrote: Support for burning into the correct eMMC HW boot partition was broken and removed in commit 96be2f072768 ("mvebu: bubt: Drop dead

Re: [PATCH v3 65/95] omap: Correct an SPL build error with watchdog

2023-02-22 Thread Stefan Roese
ensure that the code is enabled in SPL as well as PPL. I am not sure what the plan is for getting rid of the old watchdog stuff. +Stefan Roese for that Frankly, I don't know what PPL_WATCHDOG is. Searching the current code base shows nothing. As to the plans of getting rid of the o

Re: [PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

2023-02-23 Thread Stefan Roese
l cleanup patch which removes usage of non-CONFIG_BLK code from the whole command. As it does not make sense to not-have it in MMC and have it in SATA. Handling this via a follow-up patch is even better. Thanks for working on this. Thanks, Stefan

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-24 Thread Stefan Roese
-CONFIG_CMD_MVEBU_BUBT=y You are removing the bubt cmd here. This is most likely a mistake. So please re-send the patches with a correct subject and also without removing the bubt cmd support. Thanks, Stefan CONFIG_ENV_OVERWRITE=y CONFIG_ENV_MIN_ENTRIES=128 CONFIG_ARP_TIMEOUT=200 @@ -59,7

Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

2023-02-26 Thread Stefan Roese
he DTS parsing problem, they can be removed. I'd like to hear from Stefan and Pali if this approach sounds good. All the best, Tony Well, the maximal SPI speed depends on the wiring. You can have on the board some SPI device which does not support high frequency. But having some sane d

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-26 Thread Stefan Roese
at is your thinking on this? Thanks, Stefan Pali Rohár (59): tools: kwbimage: Fix generating, verifying and extracting SDIO kwbimage tools: kwboot: Fix parsing SDIO kwbimage arm: mvebu: spl: Fix parsing SDIO kwbimage cmd: mvebu/bubt: Fix parsing SDIO kwbimage tools: kwb

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-27 Thread Stefan Roese
Hi Martin, Hi Pali, On 2/27/23 12:29, Martin Rowe wrote: On Mon, 27 Feb 2023 at 08:04, Pali Rohár <mailto:p...@kernel.org>> wrote: On Monday 27 February 2023 08:44:30 Stefan Roese wrote: > Hi Pali, > > On 2/25/23 23:00, Pali Rohár wrote: > > On

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-28 Thread Stefan Roese
Hi Pali, On 2/28/23 08:03, Stefan Roese wrote: Hi Martin, Hi Pali, On 2/27/23 12:29, Martin Rowe wrote: On Mon, 27 Feb 2023 at 08:04, Pali Rohár <mailto:p...@kernel.org>> wrote:     On Monday 27 February 2023 08:44:30 Stefan Roese wrote: > Hi Pali, > > On 2

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-28 Thread Stefan Roese
Hi Pali, On 2/28/23 10:54, Pali Rohár wrote: On Tuesday 28 February 2023 08:03:47 Stefan Roese wrote: Hi Martin, Hi Pali, On 2/27/23 12:29, Martin Rowe wrote: On Mon, 27 Feb 2023 at 08:04, Pali Rohár mailto:p...@kernel.org>> wrote: On Monday 27 February 2023 08:44:30 Stefan Roese

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-28 Thread Stefan Roese
Hi Pali, On 2/28/23 11:10, Pali Rohár wrote: On Tuesday 28 February 2023 11:01:55 Stefan Roese wrote: Hi Pali, On 2/28/23 10:54, Pali Rohár wrote: On Tuesday 28 February 2023 08:03:47 Stefan Roese wrote: Hi Martin, Hi Pali, On 2/27/23 12:29, Martin Rowe wrote: On Mon, 27 Feb 2023 at 08:04

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-28 Thread Stefan Roese
patches. I have not created / sent more patches. If there is missing some patch on Github I can double check it... Most likely I have fat-fingered myself something here. Please forget about this. My fault. Ok. So do you have all patches in the correct form? Yes. All fine. Thanks, Stefan

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-03-01 Thread Stefan Roese
+++- tools/mkimage.c | 11 +- 22 files changed, 768 insertions(+), 281 deletions(-) copy configs/{clearfog_defconfig => clearfog_sata_defconfig} (98%) copy configs/{db-88f6820-amc_defconfig => db-88f6820-amc_nand_defconfig} (92%) Applied to u-boot-marvell/next Thanks, Stefan

Please pull u-boot-marvell/next

2023-03-01 Thread Stefan Roese
any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=286&view=results Thanks, Stefan The following changes since commit f10905b4b7b9b6888e2532cdfb3536d2244676cb: Merge tag 'tpm-next-28022023' of https://source.denx.de/u-boot/custodians/u-boot-tpm into next (20

Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection

2023-03-05 Thread Stefan Roese
are recognized by A385 bootrom (and not the only one described in the HW spec, which is incomplete). Stefan, do you have some AXP board with SATA boot source? Because I'm adding it for completeness in the last sixth patch. No, theadorable only boots from SPI NOR. Thanks, Stefan

Re: [PATCH u-boot-mvebu] ddr: marvell: a38x: Remove unused file seq_exec.h

2023-03-05 Thread Stefan Roese
On 3/4/23 13:26, Pali Rohár wrote: DDR code does not use seq_exec.h, so remove it. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/ddr/marvell/a38x/ddr3_init.h | 1 - drivers/ddr/marvell/a38x/seq_exec.h | 64 2 files

Re: [RESEND PATCH] arm: mvebu: Set common SPI flash default speed and mode

2023-03-05 Thread Stefan Roese
spelling of SF_DEFAULT_MODE Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index cdb1776a66..8f744e2177 100644 --- a/arch

Re: [PATCH] arm: mvebu: Use 4K sector for Thecus N2350 SPI flash

2023-03-06 Thread Stefan Roese
On 2/17/23 04:34, Tony Dinh wrote: Since the SPI flash chip mx25l3205d on this board has 4K-sector capability, enable it for the envs. Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- configs/n2350_defconfig | 2 +- 1 file changed, 1 insertion(+), 1

Please pull u-boot-marvell/master

2023-03-06 Thread Stefan Roese
://dev.azure.com/sr0718/u-boot/_build/results?buildId=287&view=results Thanks, Stefan The following changes since commit 33fb2d130e28982b488c2a54978031835ed2aa71: Merge tag 'dm-pull-29feb23' of https://source.denx.de/u-boot/custodians/u-boot-dm (2023-03-01 16:07:24 -0500) are availa

Re: [GIT PULL] Please pull u-boot-mmc master

2023-03-10 Thread Stefan Roese
these all fixes of specific issues? If not, I'd rather take this to -next. Thanks! The stuff from me can easily go into next. Same for my patches. Thanks, Stefan

Default value for bootcmd not defined

2023-03-15 Thread Stefan Nagy
or simple users like me, so I thought it might not be intended that the default value for the bootcmd entry is (still) distro_bootcmd. Regards, Stefan. [1] https://u-boot.readthedocs.io/en/latest/board/rockchip/rockchip.html -- E-Mails signieren & verschlüsseln · https://ema

Re: [PATCH] console: Use flush() before panic and reset

2023-03-16 Thread Stefan Roese
nabled by default and should be available in all cases IMHO. Thanks, Stefan

Re: [PATCH v3 3/5] x86: conga-qeval20-qa3-e3845: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Stefan Roese
0-qa3-e3845: Adjust CONFIG_TEXT_BASE") Reviewed-by: Stefan Roese Thanks, Stefan --- Changes in v3: - Add new patch arch/x86/dts/conga-qeval20-qa3-e3845.dts | 2 +- configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 + configs/conga-qeval20-qa3-e3845

Re: [PATCH v3 4/5] x86: dfi-bt700: Fix up adjustment of CONFIG_TEXT_BASE

2023-03-16 Thread Stefan Roese
djust CONFIG_TEXT_BASE") Reviewed-by: Stefan Roese Thanks, Stefan --- Changes in v3: - Add new patch arch/x86/dts/dfi-bt700.dtsi | 2 +- configs/dfi-bt700-q7x-151_defconfig | 1 + configs/theadorable-x86-dfi-bt700_defconfig | 1 + 3 files changed, 3 insert

Re: [PATCH] console: Use flush() before panic and reset

2023-03-16 Thread Stefan Roese
/arm/lib/reset.c +++ b/arch/arm/lib/reset.c @@ -25,6 +25,7 @@ #include #include #include +#include Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] arm: kirkwood: Enable Debug UART for Zyxel NSA310S

2023-03-16 Thread Stefan Roese
On 3/13/23 04:35, Tony Dinh wrote: It's useful to enable Debug UART for future DM Serial regression tests for Kirkwood boards. Also, see background discussion in this thread: https://lists.denx.de/pipermail/u-boot/2023-March/512010.html Signed-off-by: Tony Dinh Reviewed-by: Stefan

Re: [PATCH RFC u-boot-mvebu] arm: kirkwood: Move internal registers in arch_very_early_init() function

2023-03-16 Thread Stefan Roese
On 3/11/23 11:57, Pali Rohár wrote: Same change as was done for mvebu in commit 5bb2c550b11e ("arm: mvebu: Move internal registers in arch_very_early_init() function") but for kirkwood. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- Hello! Please tes

[QUESTION] Device tree for gmii-to-rgmii phy driver

2023-03-16 Thread Stefan Herbrechtsmeier
,gmii-to-rgmii-1.0";        phy-handle = <ðphy0>;        phy-mode = "rgmii-id";    };     }; }; This does not work in u-boot because the phy framework ignores the phy-handle of the MAC for the gmii2rgmii but the gmii2rgmii driver itself checks the phy-mode of the MAC. What is the correct device tree and thereby proper implementation? Regards   Stefan

[PATCH] fs: fat: do not mangle short filenames

2023-03-17 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Do not mangle lower or mixed case filenames which fit into the upper case 8.3 short filename. This ensures FAT standard compatible short filenames (SFN) to support systems without long filename (LFN) support like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for

[PATCH] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-03-20 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Read the phy mode of the external phy from the device tree if available. Signed-off-by: Stefan Herbrechtsmeier --- drivers/net/phy/xilinx_gmii2rgmii.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b

Re: [PATCH] fs: fat: do not mangle short filenames

2023-03-21 Thread Stefan Herbrechtsmeier
Am 20.03.2023 um 18:01 schrieb Tom Rini: On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier Do not mangle lower or mixed case filenames which fit into the upper case 8.3 short filename. This ensures FAT standard compatible short filenames

Re: [PATCH] fs: fat: do not mangle short filenames

2023-03-21 Thread Stefan Herbrechtsmeier
Am 21.03.2023 um 16:35 schrieb Tom Rini: On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote: Am 20.03.2023 um 18:01 schrieb Tom Rini: On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier Do not mangle lower or mixed case

[PATCH v2] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-03-22 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Read the phy mode of the external phy from the device tree if available and check that it is a RGMII variant. Signed-off-by: Stefan Herbrechtsmeier --- Changes in v2: - Check that the external phy mode is a RGMII variant drivers/net/phy/xilinx_gmii2rgmii.c | 9

[PATCH] test: fs: Check fat short file name

2023-03-22 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Ensure that a freshly written fat file with a lower case filename which fits into the upper case 8.3 short filename is not mangeled with a tilde and number. Signed-off-by: Stefan Herbrechtsmeier --- test/py/tests/test_fs/test_ext.py | 36

Re: [PATCH] fs: fat: do not mangle short filenames

2023-03-22 Thread Stefan Herbrechtsmeier
Am 21.03.2023 um 16:54 schrieb Tom Rini: On Tue, Mar 21, 2023 at 04:53:22PM +0100, Stefan Herbrechtsmeier wrote: Am 21.03.2023 um 16:35 schrieb Tom Rini: On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote: Am 20.03.2023 um 18:01 schrieb Tom Rini: On Fri, Mar 17, 2023 at

[PATCH] arm64: dts: rockchip: rk3568: Add ODROID-M1 board support

2023-07-05 Thread Stefan Agner
Add ODROID-M1 board support. Board device tree rk3568-odroid-m1.dts from v6.4. Signed-off-by: Stefan Agner --- arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi | 29 + arch/arm/dts/rk3568-odroid-m1.dts | 744 ++ configs

Re: [PATCH] arm64: dts: rockchip: rk3568: Add ODROID-M1 board support

2023-07-05 Thread Stefan Agner
On 2023-07-05 18:24, Jonas Karlman wrote: > Hi Stefan, > On 2023-07-05 18:16, Stefan Agner wrote: >> Add ODROID-M1 board support. Board device tree rk3568-odroid-m1.dts >> from v6.4. > > I sent out a series that add support for ODROID-M1 a few days ago. > Please see h

Re: [PATCH 2/2] board: rockchip: Add Hardkernel ODROID-M1

2023-07-05 Thread Stefan Agner
e. I've also tested it on an ODORID-M1 with 8GB of memory, it boots fine from SD card. Reviewed-by: Stefan Agner Tested-by: Stefan Agner One thing I've noticed is that USB isn't working when I use the stock SPL (2017.09) running from the SPI RAM and upstream U-Boot (by writing

Re: [PATCH 2/2] board: rockchip: Add Hardkernel ODROID-M1

2023-07-06 Thread Stefan Agner
On 2023-07-06 07:08, Jonas Karlman wrote: > On 2023-07-06 01:27, Stefan Agner wrote: >> On 2023-07-02 22:47, Jonas Karlman wrote: >>> Hardkernel ODROID-M1 is a single board computer with a RK3568B2 SoC, >>> a slightly modified version of the RK3568 SoC. >>> &g

Re: [PATCH] lzma: Fix decompression speed regression

2023-07-07 Thread Stefan Roese
-- 1 file changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Simon Glass +Stefan Roese I wonder if we need a more general fix? IIRC, we already have some code in the watchdog IF making sure, that the WDT reset is not called too often. I need to re-check here. And yes, we should pro

Re: [PATCH] lzma: Fix decompression speed regression

2023-07-07 Thread Stefan Roese
Hi Christophe, On 7/7/23 11:27, Christophe Leroy wrote: Le 07/07/2023 à 11:09, Stefan Roese a écrit : [Vous ne recevez pas souvent de courriers de s...@denx.de. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Hi Simon, Hi Christophe, On 7/6/23 17:57

Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits

2023-07-10 Thread Stefan Roese
nel.org/u-boot/20230413205750.10641-1-p...@kernel.org/ Oh, oh, I think I get it now. You're wondering why I guess: https://patchwork.ozlabs.org/project/uboot/patch/20230505193710.n35h2ofq6fogk4bq@pali/ https://patchwork.ozlabs.org/project/uboot/patch/20230516184943.7206-1-p...@kernel.org/ haven't be

Re: [PATCH v2 1/6] arm: mvebu: ac5: Add nand-controller node

2023-07-13 Thread Stefan Roese
On 7/10/23 00:47, Chris Packham wrote: The AC5/AC5X SoC has a NAND flash controller. Add this to the SoC device tree. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/ac5-98dx25xx.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a

Re: [PATCH v2 2/6] arm: mvebu: ac5: Define mvebu_get_nand_clock()

2023-07-13 Thread Stefan Roese
On 7/10/23 00:47, Chris Packham wrote: The NF_CLK for the AC5 SoC runs at 400MHz. There's no strapping or gating require so just add a mvebu_get_nand_clock() that returns this value. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/alle

Re: [PATCH v2 3/6] mtd: nand: pxa3xx: Add support for the Marvell AC5 SoC

2023-07-13 Thread Stefan Roese
On 7/10/23 00:47, Chris Packham wrote: The NAND flash controller (NFC) on the AC5/AC5X SoC is the same as the NFC used on other Marvell SoCs. It does have the additional restriction of only supporting SDR timing modes up to 3. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks

Re: [PATCH v2 4/6] mtd: nand: pxa3xx: Enable devbus/nand arbiter on Armada 8K

2023-07-13 Thread Stefan Roese
ckham Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/mtd/nand/raw/pxa3xx_nand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/pxa3xx_nand.c b/drivers/mtd/nand/raw/pxa3xx_nand.c index 9dee580ab9c2..d502e967f92c 100644 --- a/drivers/mtd/nan

Re: [PATCH v2 5/6] arm: mvebu: Add Allied Telesis x240 board

2023-07-13 Thread Stefan Roese
ckham Reviewed-by: Stefan Roese Thanks, Stefan --- Notes: Changes in v2: - drop CONFIG_DEBUG_UART arch/arm/dts/Makefile | 3 +- arch/arm/dts/ac5-98dx35xx-atl-x240.dts | 212 + arch/arm/mach-mvebu/Kconfig| 7 + board/alliedte

Re: [PATCH v2 6/6] arm: mvebu: Remove unused alias from RC AC5X dts

2023-07-13 Thread Stefan Roese
On 7/10/23 00:47, Chris Packham wrote: The sar-reg0 alias was left over from an earlier iteration of the patches adding support for this board. Remove the unused alias. Fixes: 6cc8b5db40 ("arm: mvebu: Add RD-AC5X board") Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Than

Re: [PATCH] arm: mvebu: Clean up Thecus N2350 board DTS

2023-07-13 Thread Stefan Roese
On 6/6/23 23:45, Tony Dinh wrote: - Update the Thecus N2350 DTS to conform with latest device-tree binding and styles. - Correct typo in mdio node. Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- arch/arm/dts/armada-385-thecus-n2350.dts | 210

Re: [PATCH] arm: mvebu: Enable gpio-fan for Thecus N2350 board

2023-07-13 Thread Stefan Roese
-marvell/master Thanks, Stefan --- arch/arm/dts/armada-385-thecus-n2350.dts | 15 +++ board/thecus/n2350/n2350.c | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts b/arch/arm/dts/armada-385-thecus-n2350.dts

Re: [PATCH v2 0/6] Support for AC5X NAND and AT-x240 board

2023-07-13 Thread Stefan Roese
Armada 8K arm: mvebu: Add Allied Telesis x240 board arm: mvebu: Remove unused alias from RC AC5X dts Applied to u-boot-marvell/master Thanks, Stefan arch/arm/dts/Makefile | 3 +- arch/arm/dts/ac5-98dx25xx.dtsi | 9 ++ arch/arm/

Please pull u-boot-marvell/master

2023-07-13 Thread Stefan Roese
(Chris) Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=305&view=results Thanks, Stefan The following changes since commit bf5152d0108683bbaabf9d7a7988f61649fc33f4: M

[PATCH] cyclic: Add ratelimiting schedule() via CYCLIC_RATELIMIT_US

2023-07-13 Thread Stefan Roese
forms, that high frequent calls to schedule() (replaced from WATCHDOG_RESET) may lead to a performance degration. When a high frequent calling into schedule() is detected, a warning is logged only once to help indentify this frantic caller. Signed-off-by: Stefan Roese Cc: Simon Glass Cc: Chris

Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits

2023-07-13 Thread Stefan Roese
Hi, (added Jaehoon Chung to Cc) On 7/10/23 18:03, Stefan Roese wrote: On 7/10/23 17:17, Tom Rini wrote: On Mon, Jul 10, 2023 at 04:10:39PM +0200, Pali Rohár wrote: On Sunday 25 June 2023 21:08:19 Tom Rini wrote: On Sun, Jun 25, 2023 at 05:15:34PM +0200, Pali Rohár wrote: On Sunday 25 June

Re: [PATCH] cyclic: Add ratelimiting schedule() via CYCLIC_RATELIMIT_US

2023-07-14 Thread Stefan Roese
Hi Simon, On 7/13/23 22:51, Simon Glass wrote: Hi Stefan, On Thu, 13 Jul 2023 at 08:17, Stefan Roese wrote: This patch adds the new Kconfig option CONFIG_CYCLIC_RATELIMIT_US which defines the min allowed time after with a new call into the cyclic infrastructure is allowed. This results in a

Re: [PATCH 1/5] drivers: watchdog: add mcf watchdog support

2023-07-18 Thread Stefan Roese
wdt_start(struct udevice *dev, u64 timeout_ms, ulong flags); So there should be no need to convert to ms here in this function. Please double-check here again. Thanks, Stefan + mcf_watchdog_init(priv->base, priv->fixed_divider, + timeout * 1000); + + retur

Re: [PATCH 2/5] m68k: move watchdog functions in mcf_wdt driver

2023-07-18 Thread Stefan Roese
be completely removed. Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/arch/m68k/cpu/mcf523x/cpu.c b/arch/m68k/cpu/mcf523x/cpu.c index ba2c228911..bef67767b4 100644 --- a/arch/m68k/cpu/mcf523x/cpu.c +++ b/arch/m68k/cpu/mcf523x/cpu.c @@ -12,7 +12,6 @@ #include #include #include

Re: [PATCH 3/5] m68k: dts: add watchdog node

2023-07-18 Thread Stefan Roese
rce tree. Is this the official version of the Coldfire WDT DT node? Just checking.. Thanks, Stefan + uart0: uart@fc06 { compatible = "fsl,mcf-uart"; reg = <0xfc06 0x40>; diff --git a/arch/m68k/dts/mcf523x.d

  1   2   3   4   5   6   7   8   9   10   >