Hi Simon, thanks for the review.
On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> Hi Nicolas,
>
> On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> wrote:
> >
> > Add the following functions to get a specific device's DMA ran
On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> wrote:
> >
> > Add test to validate dev->dma_offset is properly set on devices.
> >
> > Signed-off-by: Nicolas Saenz Julienne
> > ---
>
On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> wrote:
> >
> > By reusing DT nodes already available in sandbox's test DT introduce a
> > test to validate dev_phys_to_bus()/dev_bus_to_phys().
> >
On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> Hi Nicolas,
>
> On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> wrote:
> >
> > So far we've been content with passing physical addresses when
> > configuring memory addresses into XHCI controll
On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> wrote:
> >
> > This will allow us to use DM variants of phys_to_bus()/bus_to_phys()
> > when relevant.
> >
> > Signed-off-by: Nicolas Saenz Julien
On Mon, 2020-12-21 at 09:47 -0700, Simon Glass wrote:
> Hi Nicolas,
>
> On Mon, 21 Dec 2020 at 07:23, Nicolas Saenz Julienne
> wrote:
> >
> > On Fri, 2020-12-18 at 19:28 -0700, Simon Glass wrote:
> > > On Tue, 15 Dec 2020 at 10:23, Nicolas Saenz Julienne
> &g
with buildman
- Add tests to all DM changes
- Make code conditional with config option
- Correct OF refcount
- Add config changes
- Address small changes as per reviews
Changes since v1:
- Fix some issues in 'dm: Introduce xxx_get_dma_range()'
- Fix some typos in commit messages
- Change DT
The Raspberry Pi Foundation released the new RPi400 which we want to
detect, so we can enable Ethernet on it and know the correct device tree
file name.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- The RPi Foundation introduced a RPi400 specific device tree, so use
that
re the
device's initialization, parse it before the probe call an provide the
DMA offset in 'struct udevice' for the address translation code to use
it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v2:
- Comment functions and struct variables
- C
when using
custom ones.
Signed-off-by: Nicolas Saenz Julienne
---
board/raspberrypi/rpi/rpi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
index b66698e4a9..abcf41a5a8 100644
--- a/board/raspberrypi/rpi/rpi.c
+++ b/board
Introduce some new nodes in sandbox's test device-tree and dm tests in
order to validate dev_get_dma_range().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
arch/sandbox/dts/test.dts
7;re doing so (specifically the XHCI
firmware load operation, which is handled by the co-processor after
u-boot has correctly configured the PCIe controller).
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/pcie_brcmstb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(
rom and to address
spaces.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v2:
- Return ENOENT instead of ENODEV
- Refcount of nodes
Changes since v1:
- Fix wrong arguments in of_get_dma_range()'s call to
of_translate_dma_address()
- Fix build in SPL/TP
e not integrated into the
device model.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v2:
- Use CONFIG_DM_DMA
include/phys2bus.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/phys2bus.h b/include/phys2bus.h
index dc9b8
Add test to validate dev->dma_offset is properly set on devices.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
arch/sandbox/dts/test.dts | 4
configs/sandbox64_defconfig|
By reusing DT nodes already available in sandbox's test DT introduce a
test to validate dev_phys_to_bus()/dev_bus_to_phys().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
- Use ut_assert_addr()
te
This will allow us to use DM variants of phys_to_bus()/bus_to_phys()
when relevant.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3
- Don't call phys_to_bus()/bus_to_phys(), we only support DM
drivers/mmc/sdhci.c | 7 ---
include/mmc.h
oduce xhci_virt_to_bus() and xhci_bus_to_virt() to cater with these
limitations, and make sure we don't break non DM users.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Don't call phys_to_bus()/bus_to_phys(), we only support DM
drivers/usb/host/x
The DM_DMA option is needed in order to translate physical address into
bus addresses on a per-device basis.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
configs/rpi_4_32b_defconfig | 1 +
configs/rpi_4_defconfig | 1 +
configs/rpi_arm64_defconfig | 1 +
3 files
The 'brcm,bcm2711-hdmi0' compatible string is used on RPi4 instead of
'brcm,bcm2835-hdmi' since the IP core was upgraded (now called VC6
instead of VC4). This has no functional change as far as u-boot driver
is concerned. So simply add the compatible string.
Signed-off-by: Ni
The Raspberry Pi Foundation released the new RPi400 which we want to
detect, so we can enable Ethernet on it and know the correct device tree
file name.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- The RPi Foundation introduced a RPi400 specific device tree, so use
that
messages
- Change DTB file name for RPi400
- Address Matthias' comments
Nicolas Saenz Julienne (13):
rpi: Add identifier for the new RPi400
rpi: Add identifier for the new CM4
pci: pcie-brcmstb: Fix inbound window configurations
dm: Introduce xxx_get_dma_range()
dm: test: Add test ca
when using
custom ones.
Signed-off-by: Nicolas Saenz Julienne
---
board/raspberrypi/rpi/rpi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
index b66698e4a9..abcf41a5a8 100644
--- a/board/raspberrypi/rpi/rpi.c
+++ b/board
7;re doing so (specifically the XHCI
firmware load operation, which is handled by the co-processor after
u-boot has correctly configured the PCIe controller).
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/pcie_brcmstb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(
Introduce some new nodes in sandbox's test device-tree and dm tests in
order to validate dev_get_dma_range().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
arch/sandbox/dts/test.dts
re the
device's initialization, parse it before the probe call an provide the
DMA offset in 'struct udevice' for the address translation code to use
it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v4:
- Use macros to access dma_offset
Changes sinc
rom and to address
spaces.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v2:
- Return ENOENT instead of ENODEV
- Refcount of nodes
Changes since v1:
- Fix wrong arguments in of_get_dma_range()'s call to
of_translate_dma_address()
- Fix build in SPL/TP
e not integrated into the
device model.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Reviewed-by: Stefan Roese
---
Changes since v4:
- Introduce macros for !DM case to make API usage cleaner
Changes since v2:
- Use CONFIG_DM_DMA
include/phys2bus.h | 17 +
1
Add test to validate dev->dma_offset is properly set on devices.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
arch/sandbox/dts/test.dts | 4
configs/sandbox64_defconfig|
By reusing DT nodes already available in sandbox's test DT introduce a
test to validate dev_phys_to_bus()/dev_bus_to_phys().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v3:
- Use ut_assertok() instead of ut_assert(!func())
- Use ut_assert_addr()
te
oduce xhci_virt_to_bus() and xhci_bus_to_virt() to cater with these
limitations, and make sure we don't break non DM users.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Reviewed-by: Stefan Roese
---
Changes since v4:
- Introduce macro to access ctrl->dev
- No need
This will allow us to use DM variants of phys_to_bus()/bus_to_phys()
when relevant.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
Changes since v4:
- Introduce mmc->dev access macros to avoid ifdefs
- No need to create mmc_phys_to_bus()
Changes since v3:
- Don
The 'brcm,bcm2711-hdmi0' compatible string is used on RPi4 instead of
'brcm,bcm2835-hdmi' since the IP core was upgraded (now called VC6
instead of VC4). This has no functional change as far as u-boot driver
is concerned. So simply add the compatible string.
Signed-off-by: Ni
The DM_DMA option is needed in order to translate physical address into
bus addresses on a per-device basis.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
---
configs/rpi_4_32b_defconfig | 1 +
configs/rpi_4_defconfig | 1 +
configs/rpi_arm64_defconfig | 1 +
3 files
On Wed, 2020-12-23 at 19:55 +0100, Nicolas Saenz Julienne wrote:
> So far we've been content with passing physical addresses when
> configuring memory addresses into XHCI controllers, but not all
> platforms have buses with transparent mappings. Specifically the
> Raspberry Pi 4 m
Hi Peter, thanks for taking the time to test this, I'll send a new hopefully
definitive version soon.
On Tue, 2020-12-29 at 10:58 +, Peter Robinson wrote:
> Hi Nicolas,
>
> With the xhci patch snippet the pci/xhci crash I was seeing is now gone.
Yes that was unfortunate, I tested most revisi
Hi Peter, sorry for the late reply, but I was on holidays.
On Mon, 2021-01-04 at 13:13 +, Peter Robinson wrote:
> On Sun, Jan 3, 2021 at 5:36 PM Nicolas Saenz Julienne
> wrote:
> >
> > Hi Peter, thanks for taking the time to test this, I'll send a new hopefully
>
The Raspberry Pi Foundation released the new RPi400 which we want to
detect, so we can enable Ethernet on it and know the correct device tree
file name.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
---
board/raspberrypi/rpi/rpi.c | 5 +
1
xxx_get_dma_range()'
- Fix some typos in commit messages
- Change DTB file name for RPi400
- Address Matthias' comments
Nicolas Saenz Julienne (13):
rpi: Add identifier for the new RPi400
rpi: Add identifier for the new CM4
pci: pcie-brcmstb: Fix inbound window configurations
dm:
when using
custom ones.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
---
board/raspberrypi/rpi/rpi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
index b66698e4a9..abcf41a5a8
7;re doing so (specifically the XHCI
firmware load operation, which is handled by the co-processor after
u-boot has correctly configured the PCIe controller).
Signed-off-by: Nicolas Saenz Julienne
Tested-by: Peter Robinson
---
drivers/pci/pcie_brcmstb.c | 12 +---
1 file changed, 5 insert
Introduce some new nodes in sandbox's test device-tree and dm tests in
order to validate dev_get_dma_range().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
arch/sandbox/dts/test.dts | 17 ++
test/dm/Makefile | 1 +
te
re the
device's initialization, parse it before the probe call an provide the
DMA offset in 'struct udevice' for the address translation code to use
it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
Changes since v5:
- Use dev_has_ofnode(
rom and to address
spaces.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
common/fdt_support.c | 73 +++
drivers/core/of_addr.c | 78 ++
drivers/core/ofnode.c | 9 +
dr
Add test to validate dev->dma_offset is properly set on devices.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
arch/sandbox/dts/test.dts | 4
configs/sandbox64_defconfig| 1 +
configs/sandbox_defconfig |
e not integrated into the
device model.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Reviewed-by: Stefan Roese
Tested-by: Peter Robinson
---
include/phys2bus.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/phys2bus.h b/include/phys2bus.h
By reusing DT nodes already available in sandbox's test DT introduce a
test to validate dev_phys_to_bus()/dev_bus_to_phys().
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
test/dm/Makefile | 1 +
test/dm/phys2bus.c
This will allow us to use DM variants of phys_to_bus()/bus_to_phys()
when relevant.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
drivers/mmc/sdhci.c | 12 +++-
include/mmc.h | 6 ++
2 files changed, 13 insertions(+), 5
oduce xhci_virt_to_bus() and xhci_bus_to_virt() to cater with these
limitations, and make sure we don't break non DM users.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Reviewed-by: Stefan Roese
Tested-by: Peter Robinson
---
Changes since v5:
- Add missing address tranlation
The DM_DMA option is needed in order to translate physical address into
bus addresses on a per-device basis.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Simon Glass
Tested-by: Peter Robinson
---
configs/rpi_4_32b_defconfig | 1 +
configs/rpi_4_defconfig | 1 +
configs
The 'brcm,bcm2711-hdmi0' compatible string is used on RPi4 instead of
'brcm,bcm2835-hdmi' since the IP core was upgraded (now called VC6
instead of VC4). This has no functional change as far as u-boot driver
is concerned. So simply add the compatible string.
Signed-off-by: Ni
It's important for u-boot to properly reset RPi4's PCIe controller in
order for Linux to run the board's USB firmware load rountines.
---
Nicolas Saenz Julienne (2):
usb: xhci-pci: Add DM_FLAG_OS_PREPARE flag
pci: brcmstb: Cleanup controller state before handover
drivers/pci
The PCIe bus the controller is connected to might need to be removed
prior the handover. Make sure xhci-pci is also removed so as to avoid
unexpected timeouts or hangs.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
s USB chip.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/pcie_brcmstb.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/pci/pcie_brcmstb.c b/drivers/pci/pcie_brcmstb.c
index bd645d7896..90225f6779 100644
--- a/drivers/pci/pcie_brcmstb.c
+++ b/driver
e by using the correct address types in the compare (both
> physical in this case).
>
> Signed-off-by: Stefan Roese
> Cc: Aaron Williams
> Cc: Chandrakala Chavva
> Cc: Ran Wang
> Cc: Nicolas Saenz Julienne
> Cc: Marek Vasut
> Cc: Bin Meng
> ---
> dri
+Matthias, just so you're aware.
On Fri, 2021-01-15 at 11:33 +0100, Stefan Roese wrote:
> On 15.01.21 11:27, Nicolas Saenz Julienne wrote:
> > On Fri, 2021-01-15 at 08:52 +0100, Stefan Roese wrote:
> > > Testing with v2021.01 on MIPS Octeon has shown, that the latest pat
+Matthias, just so you're aware.
On Fri, 2021-01-15 at 11:33 +0100, Stefan Roese wrote:
> On 15.01.21 11:27, Nicolas Saenz Julienne wrote:
> > On Fri, 2021-01-15 at 08:52 +0100, Stefan Roese wrote:
> > > Testing with v2021.01 on MIPS Octeon has shown, that the latest pat
he console list, and
console_stop() is called on the struct stdio_dev pointer that no
longer exists.
This series mitigates this by making sure the pointer is really a stdio
device prior performing the stop operation. It's not ideal, but I
couldn't figure out a nicer way to fix this.
Regard
stdio_valid() will confirm that a struct stdio_dev pointer is indeed
valid.
Signed-off-by: Nicolas Saenz Julienne
---
common/stdio.c | 11 +++
include/stdio_dev.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/common/stdio.c b/common/stdio.c
index abf9b1e915..69b7d2692d
Don't start/stop an stdio device that might have been already freed.
Signed-off-by: Nicolas Saenz Julienne
Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles")
---
common/console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/console.c b/common/console.c
i
On Wed, 2021-01-20 at 07:18 -0700, Simon Glass wrote:
> Hi Nicolas,
>
> On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne
> wrote:
> >
> > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles')
> > introduces a use after free in usb_k
Hi Mark!
On Sat, 2021-03-13 at 10:24 +0100, Mark Kettenis wrote:
[...]
> Fortunately Nicolas Saenz Julienne recently introduced
> dev_phys_to_bus() and dev_bus_to_phys() interfaces to do this. Those
> interfaces make use of a dma-ranges property in the device tree which
> doesn&#x
Hi Mark,
> Hi Nicolas,
>
> > On Sat, 2021-03-13 at 10:24 +0100, Mark Kettenis wrote:
> > [...]
> > > Fortunately Nicolas Saenz Julienne recently introduced
> > > dev_phys_to_bus() and dev_bus_to_phys() interfaces to do this. Those
> > > interfaces ma
[ Adding Matthias for the SMBIOS part ]
On Fri, 2021-04-09 at 00:00 -0700, Roman Shaposhnik wrote:
> On Thu, Apr 8, 2021 at 8:59 PM Sean Anderson wrote:
> > On 4/8/21 8:18 PM, Roman Shaposhnik wrote:
> > > Hi!
> > >
> > > first time poster, long time lurker here. Over at Project EVE
> > > https:
sure this
happens in between the PCIe configuration and xHCI startup.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci-pci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index c1f60da541..5c17ea6932 100644
--- a/d
off-by: Nicolas Saenz Julienne
---
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x/include/mach/msg.h | 7
arch/arm/mach-bcm283x/msg.c | 41 +++
3 files changed, 61 insertions(+)
diff --git a/arch/arm/mach-bcm283x/include/mach
oment.
Patch 2 is a little invasive, but I couldn't find a mechanism in u-boot
similar to Linux's PCI quirks.
Nicolas Saenz Julienne (2):
arm: rpi: Add function to trigger VL805's firmware load
usb: xhci: Load Raspberry Pi 4 VL805's firmware
arch/arm/mach-bcm283x
On Tue, 2020-04-28 at 19:59 +0200, Marek Vasut wrote:
> On 4/28/20 7:44 PM, Nicolas Saenz Julienne wrote:
> > When needed, RPi4's co-processor (called VideoCore) has to be instructed
> > to load VL805's firmware (the chip providing xHCI support). VideCore's
> &g
Hi Bin,
On Wed, 2020-04-29 at 14:51 +0800, Bin Meng wrote:
> Hi Nicolas,
>
> On Wed, Apr 29, 2020 at 1:45 AM Nicolas Saenz Julienne
> wrote:
> > When needed, RPi4's co-processor (called VideoCore) has to be instructed
> > to load VL805's firmware (the chip p
On Wed, 2020-04-29 at 08:18 +0200, Marek Szyprowski wrote:
> Hi Nicolas,
>
> On 28.04.2020 19:44, Nicolas Saenz Julienne wrote:
> > When needed, RPi4's co-processor (called VideoCore) has to be instructed
> > to load VL805's firmware (the chip providing xHCI su
On Wed, 2020-04-29 at 14:05 +0200, Marek Vasut wrote:
> On 4/29/20 12:10 PM, Nicolas Saenz Julienne wrote:
> > On Tue, 2020-04-28 at 19:59 +0200, Marek Vasut wrote:
> > > On 4/28/20 7:44 PM, Nicolas Saenz Julienne wrote:
> > > > When needed, RPi4's co-pro
On Wed, 2020-04-29 at 14:37 +0200, Marek Vasut wrote:
> On 4/29/20 2:36 PM, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-04-29 at 14:05 +0200, Marek Vasut wrote:
> > > On 4/29/20 12:10 PM, Nicolas Saenz Julienne wrote:
> > > > On Tue, 2020-04-28 at 19:59 +0200, Mar
off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Rename function so it's not mistaken with regular firmware loading
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x/include/mach/msg.h | 7
arch/arm/mach-bcm283x/msg.c | 43
oment.
Note that this builds on top of Sylwester Nawrocki's "USB host support
for Raspberry Pi 4 board" series.
---
Changes since v1:
- Rename function
- Use callback in xhci-pci.c
Nicolas Saenz Julienne (2):
arm: rpi: Add function to trigger VL805's firmware load
usb:
sure this
happens in between the PCIe configuration and xHCI startup.
Introduce a callback in xhci_pci_probe() to run this platform specific
routine.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Create callback
board/raspberrypi/rpi/rpi.c | 12
drivers/usb/
On Thu, 2020-04-30 at 15:31 +0200, Mark Kettenis wrote:
> > From: Nicolas Saenz Julienne
> > Date: Thu, 30 Apr 2020 15:04:32 +0200
> >
> > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware
> > may either be loaded directly from a
[ Adding Matthias as he's the board maintainer ]
On Tue, 2020-05-05 at 19:15 +0800, Bin Meng wrote:
> On Mon, May 4, 2020 at 8:45 PM Sylwester Nawrocki
> wrote:
> > From: Marek Szyprowski
> >
> > This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI
> > and USB commands. To ge
Hi Matthias,
On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote:
>
> On 30/04/2020 15:04, Nicolas Saenz Julienne wrote:
> > When needed, RPi4's co-processor (called VideoCore) has to be instructed
> > to load VL805's firmware (the chip providing xHCI suppor
On Tue, 2020-05-05 at 15:39 +0200, Matthias Brugger wrote:
>
> On 05/05/2020 14:53, Nicolas Saenz Julienne wrote:
> > Hi Matthias,
> >
> > On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote:
> > > On 30/04/2020 15:04, Nicolas Saenz Julienne wrote:
> &g
t;
> Thanks,
> Sylwester
I tested the whole series with rpi_4_defconfig and rpi_arm64_defconfig.
Tested-by: Nicolas Saenz Julienne
Regards,
Nicolas
> Marek Szyprowski (4):
> rpi4: shorten a mapping for the DRAM
> rpi4: add a mapping for the PCIe XHCI controller MMIO registers
sed from dma-ranges DT property and a fixed 4GB region is used.
>
> The patch has been tested on RPI4 board, i.e. on BCM2711 SoC with VL805
> USB Host Controller.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Sylwester Nawrocki
I don't know if it's a little
Supporting USB keyboards out of the box is both handy for development
and production. Notably if u-boot is used to boot into GRUB.
Signed-off-by: Nicolas Saenz Julienne
---
Note that rpi_arm64_defconfig already supports USB keyboard. This is to
be applied on top of Sylwester Nawrocki's
On Tue, 2020-05-05 at 16:59 +0200, Matthias Brugger wrote:
[...]
> > > > > > +#ifdef CONFIG_BCM2711
> > > > >
> > > > > This won't work with rpi_arm64_defconfig.
> > > > > Can't we just evaluate at runtime if we need to do anything in
> > > > > xhci_pci_fixup.
> > > >
> > > > I can't see why, who
parsed from dma-ranges DT property and a fixed 4GB region is used.
>
> The patch has been tested on RPI4 board, i.e. on BCM2711 SoC with VL805
> USB Host Controller.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Sylwester Nawrocki
> ---
If it's OK with
since v1:
- Rename function
- Use callback in xhci-pci.c
Nicolas Saenz Julienne (2):
arm: rpi: Add function to trigger VL805's firmware load
usb: xhci: Load Raspberry Pi 4 VL805's firmware
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x/include/mach/
sure this
happens in between the PCIe configuration and xHCI startup.
Introduce a callback in xhci_pci_probe() to run this platform specific
routine.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Get rid of #ifdef CONFIG_BCM2711
- Get rid of redundant error message
Changes
off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Correct wrong function name in comment
- Add better comment on rpi_firmware_init_vl805()
Changes since v1:
- Rename function so it's not mistaken with regular firmware loading
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
a
Hi Bin,
On Wed, 2020-05-06 at 13:33 +0800, Bin Meng wrote:
> Hi Nicolas,
>
> On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne
> wrote:
> > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware
> > may either be loaded directly from an EEPR
Hi, I'll try to add my two cents.
On Wed, 2020-05-06 at 08:47 -0600, Simon Glass wrote:
> > +config PCI_BRCMSTB
> > + bool "Broadcom STB PCIe controller"
> > + depends on DM_PCI
> > + depends on ARCH_BCM283X
> > + help
> > + Say Y here if you want to enable Broadcom
Hi Jim,
On Fri, 2020-05-08 at 10:25 -0400, Jim Quinlan wrote:
> > > > +static int brcm_pcie_probe(struct udevice *dev)
> > > > +{
> > > > + struct udevice *ctlr = pci_get_controller(dev);
> > > > + struct pci_controller *hose = dev_get_uclass_priv(ctlr);
> > > > + struct brcm_pci
On Tue, 2020-05-05 at 18:26 +0200, Nicolas Saenz Julienne wrote:
> Newer revisions of the RPi4 need their xHCI chip, VL805, firmware to be
> loaded explicitly. Earlier versions didn't need that as they where using
> an EEPROM for that purpose. This series takes care of setting up
Hi All,
I'm working on enabling the VIA805 XCHI controller found on the new Raspberry
Pi 4. The controller sits behind a PCIe bus, which I've already implemented[1]
and will submit once the XCHI issues are resolved, as it's worthless otherwise.
The XHCI initialization gets stuck after issuing the
On Wed, 2020-04-01 at 20:50 +0200, Marek Vasut wrote:
> On 4/1/20 7:30 PM, Nicolas Saenz Julienne wrote:
> > Hi All,
>
> Hi,
>
> > I'm working on enabling the VIA805 XCHI controller found on the new
> > Raspberry
> > Pi 4. The controller sits behind a PCI
On Wed, 2020-04-01 at 22:14 +0200, Marek Vasut wrote:
> On 4/1/20 10:13 PM, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-04-01 at 20:50 +0200, Marek Vasut wrote:
> > > On 4/1/20 7:30 PM, Nicolas Saenz Julienne wrote:
> > > > Hi All,
> > >
> > >
the XHCI PCI device.
>
> Signed-off-by: Marek Szyprowski
> Reviewed-by: Jaehoon Chung
> ---
> This fixes the issue observed on ARM 32bit after upgrading the RPi4
> firmware files, described some time ago here:
> https://lists.denx.de/pipermail/u-boot/2021-February/442317.html
Hi Andy, Simon
On Wed, 2021-01-20 at 17:57 +0200, Andy Shevchenko wrote:
> On Wed, Jan 20, 2021 at 4:05 PM Nicolas Saenz Julienne
> wrote:
> >
> > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles')
> > introduces a use after free in usb_
On Sat, 2021-01-23 at 19:03 -0700, Simon Glass wrote:
> Hi Nicolas,
>
> On Wed, 20 Jan 2021 at 07:05, Nicolas Saenz Julienne
> wrote:
> >
> > stdio_valid() will confirm that a struct stdio_dev pointer is indeed
> > valid.
> >
> > Signed-off-by: N
Nicolas
---
Changes since v1:
- Comment new function
- Add comment stating this needs a proper fix
Nicolas Saenz Julienne (2):
stdio: Introduce stdio_valid()
console: Don't start/stop console if stdio device invalid
common/console.c| 9 +
common/stdio.c | 11 ++
stdio_valid() will confirm that a struct stdio_dev pointer is indeed
valid.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Properly document function
common/stdio.c | 11 +++
include/stdio_dev.h | 11 +++
2 files changed, 22 insertions(+)
diff --git a
Don't start/stop an stdio device that might have been already freed.
Signed-off-by: Nicolas Saenz Julienne
Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles")
---
Changes since v1:
- Add comment stating this should be properly fixed
common/console.c | 9 +
1
1 - 100 of 204 matches
Mail list logo
