Re: [U-Boot] SAMSUNG: serial: remove compiler warnings

2010-07-08 Thread Minkyu Kang
On 6 July 2010 21:02, Minkyu Kang wrote: > remove below warnings > serial_s5p.c: In function 'serial_getc_dev': > serial_s5p.c:136: warning: dereferencing type-punned pointer will break > strict-aliasing rules > serial_s5p.c: In function 'serial_putc_dev

Re: [U-Boot] [PATCH 1/2] S5P: support mmc driver

2010-07-20 Thread Minkyu Kang
Dear Wolfgang, On 6 July 2010 21:06, Minkyu Kang wrote: > This patch adds support mmc driver for s5p SoC > > Signed-off-by: Minkyu Kang > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > --- >  arch/arm/include/asm/arch-s5pc1xx/cpu.h |    2 + >  arch/arm/

Re: [U-Boot] [PATCH 1/2] S5P: support mmc driver

2010-08-02 Thread Minkyu Kang
On 21 July 2010 10:14, Minkyu Kang wrote: > Dear Wolfgang, > > On 6 July 2010 21:06, Minkyu Kang wrote: >> This patch adds support mmc driver for s5p SoC >> >> Signed-off-by: Minkyu Kang >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Kyungmin Par

Re: [U-Boot] [PATCH 2/2] s5p_goni: enable mmc0

2010-08-02 Thread Minkyu Kang
On 6 July 2010 21:07, Minkyu Kang wrote: > Adds the board_mmc_init function and enable the mmc command > > Signed-off-by: Minkyu Kang > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > --- >  board/samsung/goni/goni.c  |   37 +++

[U-Boot] Please pull u-boot-samsung/master

2010-08-03 Thread Minkyu Kang
Please pull u-boot-samsung/master. Thanks. The following changes since commit 2271d3ddccfbd4a7640121669ff9b013b1fea361: Minkyu Kang (1): Merge branch 'master' of git://git.denx.de/u-boot are available in the git repository at: git://git.denx.de/u-boot-samsung master Mink

Re: [U-Boot] [PATCH 1/2] S5P: support mmc driver

2010-08-03 Thread Minkyu Kang
Dear Wolfgang, On 4 August 2010 07:33, Wolfgang Denk wrote: > Dear Minkyu Kang, > > In message <4c331c61.9070...@samsung.com> you wrote: >> This patch adds support mmc driver for s5p SoC > ... > >> +#ifdef DEBUG_S5P_HSMMC >> +#define dbg(x...)    

[U-Boot] [PATCH] S5P: mmc: use the standard debug macro

2010-08-04 Thread Minkyu Kang
Use the standard debug macro instead of the costom macro Signed-off-by: Minkyu Kang Cc: Wolfgang Denk --- drivers/mmc/s5p_mmc.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/mmc/s5p_mmc.c b/drivers/mmc/s5p_mmc.c index 669b1d0

Re: [U-Boot] [PATCH v3 1/4] exynos: Properly zero initialize host in s5p_sdhci_init()

2015-10-13 Thread Minkyu Kang
++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/4] exynos: Fix passing of errors in exynos_mmc_init()

2015-10-13 Thread Minkyu Kang
t() fails. > > v2: Only fail in process_nodes() if we fail on all > available nodes. > > Acked-by: Przemyslaw Marczak > Signed-off-by: Tobias Jakobi > --- > drivers/mmc/s5p_sdhci.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) >

Re: [U-Boot] [PATCH V3 0/2] *Enhance Odroid board

2015-10-13 Thread Minkyu Kang
; >> Changes in V2: >> * Expand commit messages >> * Better code consistency >> >> Signed-off-by: Guillaume GARDET >> Cc: Przemyslaw Marczak >> Cc: Minkyu Kang >> >> --- >> >> Guillaume GARDET (2): >>o

Re: [U-Boot] [PATCH v3 4/4] exynos: more debug and cleanup in do_sdhci_init()

2015-10-13 Thread Minkyu Kang
sertions(+), 9 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/4] exynos: be more verbose in process_nodes()

2015-10-13 Thread Minkyu Kang
nged, 7 insertions(+), 5 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] please pull u-boot-samsung master

2015-10-16 Thread Minkyu Kang
/s5p_sdhci.c | 50 +++--- include/configs/odroid.h | 16 +++ 2 files changed, 42 insertions(+), 24 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/5] smdkv310: clean up checkpatch issues

2015-10-23 Thread Minkyu Kang
RNING: Avoid unnecessary line continuations + gd->bd->bi_dram[2].size = get_ram_size((long *)PHYS_SDRAM_3, \ WARNING: Avoid unnecessary line continuations + gd->bd->bi_dram[3].size = get_ram_size((long *)PHYS_SDRAM_4, \ Signed-off-by: Minkyu Kang --- board/samsung/sm

[U-Boot] [PATCH 1/5] arm: exynos: clean up checkpatch issues

2015-10-23 Thread Minkyu Kang
ERROR: space prohibited before that ',' (ctx:WxW) + writel(val , &drex0->concontrol); ^ ERROR: space prohibited before that ',' (ctx:WxW) + writel(val , &drex1->concontrol); ^ Signed-off-by: Min

[U-Boot] [PATCH 5/5] samsung: clean up checkpatch issues

2015-10-23 Thread Minkyu Kang
mode_name[i][0], Signed-off-by: Minkyu Kang --- board/samsung/common/misc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index e0e2c48..e46c6c6 100644 --- a/board/samsung/common/misc.c +++

[U-Boot] [PATCH 4/5] odroid: clean up checkpatch issues

2015-10-23 Thread Minkyu Kang
This patch will fix these checkpatch issues. +static const char *mmc_regulators[] = { CHECK: Blank lines aren't necessary before a close brace '}' + +} Signed-off-by: Minkyu Kang --- board/samsung/odroid/odroid.c | 15 +++ 1 file changed, 7 insertions(+), 8 del

[U-Boot] [PATCH 3/5] smdk2410: clean up checkpatch issues

2015-10-23 Thread Minkyu Kang
Hz */ ERROR: spaces required around that '==' (ctx:VxV) +#if USB_CLOCK==0 ERROR: spaces required around that '==' (ctx:VxV) +#elif USB_CLOCK==1 CHECK: spaces required around that ':' (ctx:VxV) + "bne 1b":"=r" (loops):"0" (loo

Re: [U-Boot] [RFC] odroid: Add support for the ODROID-X board variant

2015-10-23 Thread Minkyu Kang
ONFIG_SYS_MEM_TOP_HIDE (1UL << 20UL) > @@ -75,6 +76,7 @@ > "uInitrd fat 0 1;" \ > "exynos4412-odroidu3.dtb fat 0 1;" \ > "exynos4412-odroidx2.dtb fat 0 1;" \ > + "exynos4412-odroidx.dtb fat 0 1;" \ > ""PARTS_BOOT" part 0 1;" \ > ""PARTS_ROOT" part 0 2\0" \ > > @@ -209,8 +211,8 @@ > #define CONFIG_USB_ETHER_SMSC95XX > > /* > - * Supported Odroid boards: X3, U3 > - * TODO: Add Odroid X support > + * Supported Odroid boards: X, X2, U3 > + * TODO: Add Odroid U2 support > */ > #define CONFIG_MISC_COMMON > #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG > Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: sdhci: assigned to current clock value for host->clock

2015-10-29 Thread Minkyu Kang
gt; + if (mmc->clock != host->clock) { > + if (!sdhci_set_clock(mmc, mmc->clock)) > + host->clock = mmc->clock; I think it's better to move into sdhci_set_clock function. > + } > > /* Set bus width */ > ctrl =

Re: [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins

2015-11-01 Thread Minkyu Kang
rk properly, > after call this function. > > Tested-on: Odroid U3 and Odroid X2. > > Signed-off-by: Przemyslaw Marczak > Cc: Guillaume GARDET > Cc: Lukasz Majewski > Cc: Jaehoon Chung > Cc: Minkyu Kang > Cc: Simon Glass > --- > arch/arm/mach-exynos/pinmu

Re: [U-Boot] [PATCH V3 00/14] Add board detection for Odroid XU3 / XU3Lite / XU4

2015-11-01 Thread Minkyu Kang
create mode 100644 doc/device-tree-bindings/pmic/s2mps11.txt > create mode 100644 drivers/adc/Kconfig > create mode 100644 drivers/adc/Makefile > create mode 100644 drivers/adc/adc-uclass.c > create mode 100644 drivers/adc/exynos-adc.c > create mode 100644 drivers/a

Re: [U-Boot] [PATCH 2/2] s5p sdhci: call pinmux for card's gpio pins before use them

2015-11-01 Thread Minkyu Kang
d U3 and Odroid X2. > > Signed-off-by: Przemyslaw Marczak > Cc: Guillaume GARDET > Cc: Lukasz Majewski > Cc: Jaehoon Chung > Cc: Minkyu Kang > Cc: Simon Glass > --- > drivers/mmc/s5p_sdhci.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) >

Re: [U-Boot] [PATCH 2/5] smdkv310: clean up checkpatch issues

2015-11-01 Thread Minkyu Kang
On 23/10/15 17:32, Minkyu Kang wrote: > This patch will fix these checkpatch issues. > > WARNING: Avoid unnecessary line continuations > + gd->bd->bi_dram[0].size = get_ram_size((long *)PHYS_SDRAM_1, \ > > WARNING: Avoid unnecessary line continuations > +

Re: [U-Boot] [PATCH 5/5] samsung: clean up checkpatch issues

2015-11-01 Thread Minkyu Kang
On 23/10/15 17:32, Minkyu Kang wrote: > This patch will fix these checkpatch issues. > > CHECK: Alignment should match open parenthesis > + printf("Enter: %s %s\n", mode_name[mode][0], > + mode_info[mode

Re: [U-Boot] [PATCH 4/5] odroid: clean up checkpatch issues

2015-11-01 Thread Minkyu Kang
On 23/10/15 17:32, Minkyu Kang wrote: > This patch will fix these checkpatch issues. > > +static const char *mmc_regulators[] = { > > CHECK: Blank lines aren't necessary before a close brace '}' > + > +} > > Signed-off-by: Minkyu Kang >

Re: [U-Boot] [PATCH 1/5] arm: exynos: clean up checkpatch issues

2015-11-01 Thread Minkyu Kang
On 23/10/15 17:32, Minkyu Kang wrote: > This patch will fix these checkpatch issues. > > ERROR: Macros with complex values should be enclosed in parentheses > +#define DEFAULT_DQS_X4 (DEFAULT_DQS << 24) || (DEFAULT_DQS << > 16) \ > +

Re: [U-Boot] [PATCH 3/5] smdk2410: clean up checkpatch issues

2015-11-01 Thread Minkyu Kang
On 23/10/15 17:32, Minkyu Kang wrote: > This patch will fix these checkpatch issues. > > ERROR: spaces required around that '==' (ctx:VxV) > +#if FCLK_SPEED==0/* Fout = 203MHz, Fin = 12MHz for Audio */ > > ERROR: spaces required around that '==&

[U-Boot] please pull u-boot-samsung master

2015-11-02 Thread Minkyu Kang
de5f9733f653091d4b227914d04432099a6448dc: samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) Minkyu Kang (5): arm: exynos: clean up checkpatch issues smdkv310: clean up checkpatch issues smdk2410

Re: [U-Boot] please pull u-boot-samsung master

2015-11-03 Thread Minkyu Kang
Dear Przemyslaw Marczak, 2015년 11월 4일 수요일, Tom Rini님이 작성한 메시지: > On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: > > > Dear Tom, > > > > The following changes since commit > 0e067a65f57189703668826d9841fea477026bf6: > > > > x86: Sele

Re: [U-Boot] please pull u-boot-samsung master

2015-11-04 Thread Minkyu Kang
Dear Przemyslaw Marczak, On 4 November 2015 at 18:37, Przemyslaw Marczak wrote: > Hello Minkyu, > > On 11/04/2015 03:05 AM, Minkyu Kang wrote: > >> Dear Przemyslaw Marczak, >> >> 2015년 11월 4일 수요일, Tom Rini> >> On Tue, Nov 03, 2015 at 02:02:57PM +090

Re: [U-Boot] [PATCH] sandbox: adc: Add missing header file

2015-11-04 Thread Minkyu Kang
+enum sandbox_adc_status { > + SANDBOX_ADC_INACTIVE = 0, > + SANDBOX_ADC_ACTIVE, > +}; > + > +#define SANDBOX_ADC_VSS_VALUE 0 > + > +#endif > -- > 1.9.1 > > _______ > U-Boot mailing list > U-Boot@list

[U-Boot] [v2] please pull u-boot-samsung master

2015-11-04 Thread Minkyu Kang
58cb44cf6623faeebd9b04ac44cf11d2eb39ea36: sandbox: adc: Add missing header file (2015-11-05 12:58:04 +0900) Minkyu Kang (5): arm: exynos: clean up checkpatch issues smdkv310: clean up checkpatch issues smdk2410

Re: [U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

2018-12-03 Thread Minkyu Kang
f I don't seen an overall Samsung PR, > thanks! > It's OK to take this patch by you. Acked-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/8] ARM: Odroid XU3: Enable DM_MMC support which is necessary for CONFIG_BLK

2018-08-06 Thread Minkyu Kang
include/configs/exynos5-common.h | 1 + > 5 files changed, 27 insertions(+), 21 deletions(-) > > -- > 2.11.0 > applied to u-boot-samsung. Thanks, Minkyu Kang. > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] arm: exynos4: fix warning of dts

2018-08-06 Thread Minkyu Kang
2018년 8월 2일 (목) 17:44, Minkyu Kang 님이 작성: > Hi, > > 2018년 7월 31일 (화) 21:58, Tom Rini 님이 작성: > >> On Tue, Jul 31, 2018 at 04:12:42PM +0900, Minkyu Kang wrote: >> >> > remove this warning: avoid_unnecessary_addr_size >> > >> > Signed-off-by:

Re: [U-Boot] [PATCH 2/3] arm: exynos5: fix warning of dts

2018-08-06 Thread Minkyu Kang
2018년 7월 31일 (화) 16:14, Minkyu Kang 님이 작성: > remove this warning: avoid_unnecessary_addr_size > > Signed-off-by: Minkyu Kang > --- > arch/arm/dts/exynos5.dtsi | 2 -- > arch/arm/dts/exynos5250-pinctrl-uboot.dtsi | 4 > arch/arm/dts/exynos54xx-p

Re: [U-Boot] [PATCH 3/3] arm: spring: fix alias of mmc correctly

2018-08-06 Thread Minkyu Kang
2018년 7월 31일 (화) 16:14, Minkyu Kang 님이 작성: > Signed-off-by: Minkyu Kang > --- > arch/arm/dts/exynos5250-spring.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/exynos5250-spring.dts > b/arch/arm/dts/exynos5250-spring.dts > index

[U-Boot] please pull u-boot-samsung master

2018-08-07 Thread Minkyu Kang
/odroid.h | 36 include/configs/snow.h| 3 +++ 14 files changed, 51 insertions(+), 62 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] script: Make get_default_envs.sh script exclude tools/env

2018-06-04 Thread Minkyu Kang
[ -z "${env_obj_file_path}" ] && \ > { echoerr "File '${ENV_OBJ_FILE}' not found!"; exit 1; } > > -- > 1.7.9.5 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] board: samsung: add missing line breaks for pr_err()

2018-06-04 Thread Minkyu Kang
("Regulator %s value setting error: %d", dev->name, > ret); > + pr_err("Regulator %s value setting error: %d\n", > dev->name, ret); > return ret; > } > > ret = regulator_set_value(d

[U-Boot] please pull u-boot-samsung master

2018-06-06 Thread Minkyu Kang
-parent property arch/arm/dts/exynos5.dtsi | 29 ++--- 1 files changed, 2 insertions(+), 27 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] please pull u-boot-samsung master

2018-06-06 Thread Minkyu Kang
Hi, 2018년 6월 7일 (목) 00:09, Tom Rini 님이 작성: > On Wed, Jun 06, 2018 at 09:55:18PM +0900, Minkyu Kang wrote: > > > Dear Tom, > > > > The following changes since commit > 0315d6959fdd9d2a4d89016c311e9c8c8d239a10: > > > > ARM: mvebu: a38x: Add missing SPDX l

Re: [U-Boot] [PATCH 2/4] arm: odroid: Increase default env size in preparation for distro_bootcmd.

2018-06-07 Thread Minkyu Kang
CONFIG_ENV_OFFSET (SZ_1K * 1280) /* 1.25 MiB offset */ > #define CONFIG_ENV_OVERWRITE > > -- > 2.11.0 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Thanks, Minkyu Ka

Re: [U-Boot] Logo for U-Boot

2018-06-11 Thread Minkyu Kang
and for printed materials, > >> etc, where a CC license works better) would be good. > >> > >>> I tend to agree that it looks nice :). > >>> > >>> It may mean we need a new web design too though, as the colors in the > >>> logo probably don't work terribly well with the current blue. > >> > >> We can worry about that later. > > > > I think the logo as here is fine: > > > > > https://www.xypron.de/projects/u-boot/images/Circle-icons-submarine-orange-teal.svg > > This logo was GPLv2+. Tom, didn't you say we needed something with > creative commons license? > > > > > What do you think about putting the word U-Boot inside it? Something > like this: > > > > https://drive.google.com/open?id=1HsiXbZhtn8URhbdAeiW802t5Y0Tyqnuv > > I have collected all suggestions here: > > https://www.xypron.de/projects/u-boot/logo.html > > Best regards > > Heinrich > > > > > Regards, > > Simon > > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot I like this one! :) Suggested by: Alexander Graf Source: https://commons.wikimedia.org/wiki/File:Circle-icons-submarine.svg Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-16 Thread Minkyu Kang
le var. > > Guillaume > > > > >> #include > >> #include > >> #include > >> -- > >> 2.17.1 > >> > >> ___ > >> U-Boot mailing list > >> U-Boot@lists.denx.de > >

Re: [U-Boot] [PATCH v2 0/4] arm: odroid: Convert to distro_bootcmd.

2018-07-25 Thread Minkyu Kang
ootcmd. > > > > include/configs/odroid.h | 36 > > 1 file changed, 20 insertions(+), 16 deletions(-) > > > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Di

Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-26 Thread Minkyu Kang
Hi, 2018년 7월 16일 (월) 18:04, Minkyu Kang 님이 작성: > Hi, > > 2018년 7월 16일 (월) 17:49, Guillaume Gardet 님이 작성: > >> Hi, >> >> >> Le 13/07/2018 à 19:20, Peter Robinson a écrit : >> > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET >>

Re: [U-Boot] [PATCH v2 0/4] arm: odroid: Convert to distro_bootcmd.

2018-07-26 Thread Minkyu Kang
Hi, 2018년 7월 25일 (수) 16:45, Minkyu Kang 님이 작성: > Hi, > > 2018년 7월 25일 (수) 16:25, Lukasz Majewski 님이 작성: > >> Hi Vagrant, >> >> > Switch odroid platform to use distro_bootcmd, adjusting to use >> > standardized environment variable names, and use

[U-Boot] [PATCH 1/3] arm: exynos4: fix warning of dts

2018-07-31 Thread Minkyu Kang
remove this warning: avoid_unnecessary_addr_size Signed-off-by: Minkyu Kang --- arch/arm/dts/exynos4210-pinctrl-uboot.dtsi | 4 arch/arm/dts/exynos4210-universal_c210.dts | 2 -- arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi | 4 3 files changed, 10 deletions(-) diff --git a/arch/arm

[U-Boot] [PATCH 2/3] arm: exynos5: fix warning of dts

2018-07-31 Thread Minkyu Kang
remove this warning: avoid_unnecessary_addr_size Signed-off-by: Minkyu Kang --- arch/arm/dts/exynos5.dtsi | 2 -- arch/arm/dts/exynos5250-pinctrl-uboot.dtsi | 4 arch/arm/dts/exynos54xx-pinctrl-uboot.dtsi | 8 3 files changed, 14 deletions(-) diff --git a/arch

[U-Boot] [PATCH 3/3] arm: spring: fix alias of mmc correctly

2018-07-31 Thread Minkyu Kang
Signed-off-by: Minkyu Kang --- arch/arm/dts/exynos5250-spring.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/exynos5250-spring.dts b/arch/arm/dts/exynos5250-spring.dts index b73b572..7633d36 100644 --- a/arch/arm/dts/exynos5250-spring.dts +++ b/arch/arm/dts

Re: [U-Boot] [PATCH 1/3] arm: exynos4: fix warning of dts

2018-08-02 Thread Minkyu Kang
Hi, 2018년 7월 31일 (화) 21:58, Tom Rini 님이 작성: > On Tue, Jul 31, 2018 at 04:12:42PM +0900, Minkyu Kang wrote: > > > remove this warning: avoid_unnecessary_addr_size > > > > Signed-off-by: Minkyu Kang > > --- > > arch/arm/dts/exynos4210-pinctrl-uboot.dtsi |

Re: [U-Boot] [RFT 1/8] exynos: Redo detection of revision when all resources are ready

2019-02-11 Thread Minkyu Kang
we do a soft reset from Linux (which disabled >> LDO4). > > This I understand but isn't the board type used BEFORE the power init? > Power init cannot be moved early as it depends on having proper > resources (as I wrote in commit msg)... so only board detection can be > moved later. But if setting up resources (e.g. regulators) requires > board type then it is circular dependency... so I asked - isn't board > type used before power init? > I'm not sure but, it looks that can be moved to after power_init. But, please verify carefully before you re-post. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code

2018-12-20 Thread Minkyu Kang
44 arch/arm/mach-s5pc1xx/pinmux.c > create mode 100644 drivers/sound/max98088.c > create mode 100644 drivers/sound/max98088.h > Do you want a pick patches up to your tree? Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] exynos5-dt-types: add missing dtb file for Odroid HC1/HC2

2018-12-20 Thread Minkyu Kang
t;\ >> "root part 0 2\0" >> >> -- >> 2.19.1 >> > > Gentle ping on this patch series. > > -Best Regards > Anand > > Oops.. Applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] odroid: Update README.odroid for support of Odroid HC1

2018-12-20 Thread Minkyu Kang
droidxu3-lite.dtb >> - exynos5422-odroidxu4.dtb >> +- exynos5422-odroidhc1.dtb >> >> Supported kernel files are: >> - Image.itb > > Reviewed-by: Lukasz Majewski > > > Best regards, > > Lukasz M

Re: [U-Boot] [PATCH] Revert "arm: config: fix default console only to specify the device"

2018-12-25 Thread Minkyu Kang
root/arm\0" \ > "bootblock=" CONFIG_BOOTBLOCK "\0" \ > diff --git a/include/configs/trats2.h b/include/configs/trats2.h > index f1e4cbad30..9c6b2bbc8d 100644 > --- a/include/configs/trats2.h > +++ b/include/conf

Re: [U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

2018-12-26 Thread Minkyu Kang
Hi, On 21/12/18 22:57, Guillaume Gardet wrote: > Hi Tom, > > Le 04/12/2018 à 05:47, Minkyu Kang a écrit : >> Dear Tom, >> >> On 04/12/18 05:23, Tom Rini wrote: >>> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote: >>> >>>&g

[U-Boot] please pull u-boot-samsung master

2018-12-26 Thread Minkyu Kang
roid_xu3.h| 5 +++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h| 4 ++-- 8 files changed, 19 insertions(+), 14 deletions(-) -- Thanks, M

Re: [U-Boot] please pull u-boot-samsung master

2018-12-27 Thread Minkyu Kang
Dear Guillaume GARDET, On 28/12/18 00:41, Tom Rini wrote: > On Thu, Dec 27, 2018 at 12:49:53PM +0900, Minkyu Kang wrote: > >> Dear Tom, >> >> The following changes since commit 1f2e948d6d53f77a2ddb2dde3531b0d5bc2815ad: >> >> Prepare v2019.01-rc2 (2018-12-17

Re: [U-Boot] [PATCH] exynos: allow SPL to build in thumb mode

2019-01-03 Thread Minkyu Kang
o be able to use thumb for exynos5 SPL. > > > Signed-off-by: Guillaume GARDET > > Cc: Albert Aribaud > Cc: Minkyu Kang > Cc: Tom Rini > > --- > arch/arm/mach-exynos/include/mach/system.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[U-Boot] [V2] please pull u-boot-samsung master

2019-01-03 Thread Minkyu Kang
| 4 ++-- include/configs/trats2.h | 4 ++-- 9 files changed, 21 insertions(+), 15 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [V2] please pull u-boot-samsung master

2019-01-04 Thread Minkyu Kang
Hi, On Fri, 4 Jan 2019 at 22:11, Tom Rini wrote: > On Fri, Jan 04, 2019 at 09:34:57AM +0900, Minkyu Kang wrote: > > > Hi, > > > > The following changes since commit > 1f2e948d6d53f77a2ddb2dde3531b0d5bc2815ad: > > > > Prepare v2019.01-rc2 (2018-12-17 2

Re: [U-Boot] [PATCH] exynos: Leave the compiler to choose the register to avoid possible r0 corruption

2019-01-06 Thread Minkyu Kang
Hi, On 04/01/19 17:23, Guillaume GARDET wrote: > Reported-by: Siarhei Siamashka > Signed-off-by: Guillaume GARDET > > Cc: Albert Aribaud > Cc: Minkyu Kang > Cc: Tom Rini > --- > arch/arm/mach-exynos/include/mach/system.h | 3 +-- > 1 file changed, 1 insertion(+

[U-Boot] [V3] please pull u-boot-samsung master

2019-01-06 Thread Minkyu Kang
s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h| 4 ++-- include/configs/trats.h| 4 ++-- include/configs/trats2.h | 4 ++-- 9 files changed, 20 insertions(+), 15 deletions(-) -- Thanks, M

Re: [U-Boot] [PATCH v3 08/10] samsung: mmc: Drop old MMC init code

2019-01-16 Thread Minkyu Kang
nged, 90 deletions(-) > Reviewed-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 07/10] samsung: Drop board_enable_audio_codec()

2019-01-16 Thread Minkyu Kang
;en_gpio), S5P_GPIO_PULL_NONE); > - > -#ifdef CONFIG_SOUND_MAX98095 > - /* Enable MAX98095 Codec */ > - gpio_request(EXYNOS5_GPIO_X17, "max98095_enable"); > - gpio_direction_output(EXYNOS5_GPIO_X17, 1); > - gpio_set_pull(EXYNOS5_GPIO_X17,

Re: [U-Boot] [PATCH v3 02/10] exynos: Drop duplicate 'model' line

2019-01-16 Thread Minkyu Kang
devstr); > #endif > -#ifdef CONFIG_BOARD_TYPES > void set_board_type(void); > const char *get_board_type(void); > -#endif > > #endif /* __SAMSUNG_MISC_COMMON_H__ */ > Reviewed-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 03/10] exynos: Convert to use CONFIG_BLK

2019-01-16 Thread Minkyu Kang
+ > arch/arm/mach-s5pc1xx/Makefile | 1 + > arch/arm/mach-s5pc1xx/pinmux.c | 20 > 4 files changed, 30 insertions(+) > create mode 100644 arch/arm/mach-s5pc1xx/pinmux.c > Reviewed-by: Minkyu Kang Thanks, Minkyu Kang. _

Re: [U-Boot] [PATCH v3 01/10] Convert CONFIG_BOARD_TYPES to Kconfig

2019-01-16 Thread Minkyu Kang
- > include/configs/odroid.h | 1 - > include/configs/odroid_xu3.h | 1 - > scripts/config_whitelist.txt | 1 - > 10 files changed, 12 insertions(+), 13 deletions(-) > Reviewed-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code

2019-01-16 Thread Minkyu Kang
Hi, On 17/01/19 06:42, Simon Glass wrote: > Hi Minkyu, > > On Fri, 21 Dec 2018 at 10:35, Simon Glass wrote: >> >> Hi Minkyu, >> >> On Thu, 20 Dec 2018 at 17:40, Minkyu Kang wrote: >>> >>> Dear Simon Glass, >>> >>> On 17/12/1

Re: [U-Boot] [PATCH] ARM: Samsung: Add Exynos5422-based Odroid HC2 support

2018-10-16 Thread Minkyu Kang
-dt.c Hunk #1 FAILED at 179. Hunk #2 FAILED at 192. 2 out of 2 hunks FAILED checking file configs/odroid-xu3_defconfig checking file include/samsung/exynos5-dt-types.h Hunk #1 FAILED at 9. 1 out of 2 hunks FAILED Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] ARM: Samsung: Add Exynos5422-based Odroid HC2 support

2018-10-22 Thread Minkyu Kang
amsung/common/exynos5-dt-types.c | 16 +--- > board/samsung/common/exynos5-dt.c | 4 ++-- > configs/odroid-xu3_defconfig| 2 +- > include/samsung/exynos5-dt-types.h | 2 ++ > 4 files changed, 18 insertions(+), 6 deletions(-) > Pleas

Re: [U-Boot] [PATCH v2] ARM: Samsung: Add Exynos5422-based Odroid HC2 support

2018-10-23 Thread Minkyu Kang
xu3_defconfig| 2 +- > include/samsung/exynos5-dt-types.h | 2 ++ > 4 files changed, 18 insertions(+), 6 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] please pull u-boot-samsung master

2018-10-23 Thread Minkyu Kang
+--- board/samsung/common/exynos5-dt.c | 4 ++-- configs/odroid-xu3_defconfig| 2 +- include/samsung/exynos5-dt-types.h | 2 ++ 4 files changed, 18 insertions(+), 6 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing

Re: [U-Boot] [PATCH 09/25] sandbox: cros_ec: exynos: Drop use of cros_ec_get_error()

2018-11-06 Thread Minkyu Kang
> board/sandbox/sandbox.c | 9 ++--- > common/cros_ec.c | 12 > 3 files changed, 12 insertions(+), 19 deletions(-) > Acked-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] [PATCH 4/9] dfu: mmc: add support for in-partition offset

2018-11-19 Thread Minkyu Kang
rtinfo.start+offset; please add space. partinfo.start + offset > + dfu->data.mmc.lba_size = partinfo.size-offset; partinfo.size - offset > dfu->data.mmc.lba_blk_size = partinfo.blksz; > } else if (!strcmp(entity_type, "fat")) { > dfu->layout = DFU_FS_FAT; > Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 9/9] ARM: Exynos: Add Exynos5433 based TM2 board support

2018-11-19 Thread Minkyu Kang
gpio input gpa21 || > itest.l *0x105c080c == 0x12345671; then run download; else run bootkernel; > fi; reset\0" \ > + "fdt_high=0x\0" \ > + "bootargs=console=ttySAC1,115200 > earlycon=exynos4210,0x14C2 ess_setup=0x2600 loglevel=7 > root=/dev/mmcblk0p18 rootfstype=ext4 rootwait\0" \ > + "bootkernel=echo Booting kernel; run > boarddetect; run loadkernel; bootm 0x3008#$board\0" \ > + "boarddetect=if itest.l *0x138000b4 == > 0x0063f9ff; then setenv board tm2e; elif itest.l *0x138000b4 == 0x0059f9ff; > then setenv board tm2; else setenv board unknown; fi; echo Detected $board > board\0" \ > + "loadkernel=part start mmc 0 9 > kernel_sect; part size mmc 0 9 kernel_size; mmc read 0x3000 $kernel_sect > $kernel_size\0" \ > + "muicsetusb=i2c dev 0; i2c mw 25 c 9; > i2c mw 25 d 3b; i2c mw 25 e 05; i2c mw 25 16 10\0" \ > + "displayimg=unzip 200d 6700; > mw.l 138000b4 0059f9ff; mw.l 138001a0 67e1; mw.l 13800200 1680; mw.l > 13801410 1; mw.l 13802040 e018; sleep 1; mw.l 13802040 e008\0" \ > + "download=echo Thor mode enabled; run > muicsetusb; run displayimg; mw.l 0x105c080c 0; thor 0 mmc 0\0" Please keep 80 characters. > + > +#define CONFIG_ENV_SIZE 0x1000 > + > +#endif /* __SAMSUNG_TM2_H */ > Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 8/9] ARM: Exynos: Add minimal support for ARM 64bit based Exynos5433 SoC

2018-11-19 Thread Minkyu Kang
#ifdef CONFIG_CPU_V7A > writel(0x1, samsung_get_base_swreset()); > #endif > +#ifdef CONFIG_ARCH_EXYNOS5433 > + writel(0x1, (void *)0x105C0400); Please don't use address directly. > +#endif > } > > #ifndef CONFIG_SYS_DCACHE_OFF > diff --git a/

Re: [U-Boot] [PATCH 0/7] Exynos4412 SPL support

2018-10-03 Thread Minkyu Kang
t defined here spl/arch/arm/mach-exynos/clock_init_exynos4412.o: In function `system_clock_init': /home/share/Work/u-boot-samsung/arch/arm/mach-exynos/clock_init_exynos4412.c:34: multiple definition of `system_clock_init' spl/arch/arm/mach-exynos/clock_init_exynos4210.o:/home/sh

Re: [U-Boot] please pull u-boot-samsung master

2016-06-14 Thread Minkyu Kang
2016년 6월 10일 금요일, Tom Rini님이 작성한 메시지: > On Fri, Jun 10, 2016 at 03:03:37PM +0900, Minkyu Kang wrote: > > On 30/05/16 11:39, Simon Glass wrote: > > > Hi Minkyu, > > > > > > On 30 May 2016 at 14:31, Minkyu Kang > wrote: > > >> > > >&

Re: [U-Boot] [PATCH] mmc: dw_mmc: fix the wrong AND operation

2016-06-26 Thread Minkyu Kang
t; } else { > - if ((dwmci_readl(host, DWMCI_RINTSTS) && > + if ((dwmci_readl(host, DWMCI_RINTSTS) & > DWMCI_INTMSK_TXDR)) { >

[U-Boot] please pull u-boot-samsung master

2016-06-27 Thread Minkyu Kang
(+), 2 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-07-06 Thread Minkyu Kang
os.c. (It's working fine.) >> >> I will send the patch-set for exynos dwmmc and sdhci controller. >> So i need to know which repository and branch are correct. :) >> >> Then it's helpful to me for working dm. I think that i can help you for >> checking on mmc side with DM. > > OK I see, thanks. > > Reviewed-by: Simon Glass > This patch has been delegated to me, but cannot apply to u-boot-samsung. should go to dm tree? Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ARM: exynos4: dts: add the prefix '/' for aliases nodes

2016-07-12 Thread Minkyu Kang
ts/exynos4210-universal_c210.dts | 4 ++-- > arch/arm/dts/exynos4412-odroid.dts | 4 ++-- > arch/arm/dts/exynos4412-trats2.dts | 6 +++--- > 5 files changed, 10 insertions(+), 10 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang. __

Re: [U-Boot] [PATCH 0/5] mmc: exynos_dw_mmc: clean the unnecessary codes

2016-07-12 Thread Minkyu Kang
s > mmc: exynos_dw_mmc: use the 4bit bus-width by default > > arch/arm/mach-exynos/include/mach/dwmmc.h | 1 - > drivers/mmc/exynos_dw_mmc.c | 78 > ++- > 2 files changed, 14 insertions(+), 65 deletions(-)

Re: [U-Boot] [PATCH] mmc: exynos_dw_mmc: support the Driver mode for Exynos

2016-07-12 Thread Minkyu Kang
> 1 file changed, 72 insertions(+) > applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] please pull u-boot-samsung master

2016-07-14 Thread Minkyu Kang
clude/mach/dwmmc.h | 1 - drivers/mmc/exynos_dw_mmc.c| 148 +++ 7 files changed, 95 insertions(+), 74 deletions(-) -- Thanks, Minkyu Kang. ___

Re: [U-Boot] [PATCH 2/2] pinctrl: Add pinctrl driver support for Exynos7420 SoC

2016-04-11 Thread Minkyu Kang
ation is reusable on other Exynos >> SoCs as well. >> >> The Exynos pinctrl driver supports only device tree based pin >> configuration. The bindings used are similar to the ones used in the >> linux kernel. >> >> Cc: Masahiro Yamada >> Cc: Simon Glass

Re: [U-Boot] [PATCH V2 6/6] gpio: exynos(s5p): remove gpio_xlate routine

2016-04-11 Thread Minkyu Kang
_value, > .get_function = exynos_gpio_get_function, > - .xlate = exynos_gpio_xlate, > }; > > static int gpio_exynos_probe(struct udevice *dev) > Acked-by: Minkyu Kang Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] exynos: Set CNTFRQ

2016-04-14 Thread Minkyu Kang
89 100644 >> --- a/include/configs/exynos-common.h >> +++ b/include/configs/exynos-common.h >> @@ -31,6 +31,7 @@ >> >> /* input clock of PLL: 24MHz input clock */ >> #define CONFIG_SYS_CLK_FREQ 2400 >> +#define CONFIG_TIMER_CLK_FREQ

Re: [U-Boot] [PATCH] odroid: Update README with correct firmware link and XU4 support

2016-04-14 Thread Minkyu Kang
; >> >> 4. Boot media layout >> @@ -120,6 +121,7 @@ Supported fdt files are: >> - exynos4412-odroidx2.dtb >> - exynos4412-odroidu3.dtb >> - exynos5422-odroidxu3.dtb >> +- exynos5422-odroidxu4.dtb >> >> Supported kernel files are: >> - Image.itb >> -- >> 1.9.1 >> > > Reviewed-by: Anand Moon > > Best Regards. > -Anand Moon > > Applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] arm: exynos: realign the code to allow support for newer 64-bit platforms

2016-04-18 Thread Minkyu Kang
latforms and so some of > the older platform support code would not be required for the newer > 64-bit Exynos platforms. > > Cc: Minkyu Kang > Signed-off-by: Thomas Abraham > --- > arch/arm/Kconfig |1 - > arch/arm/mach-exynos/Kconfig

Re: [U-Boot] [PATCH 7/9] arm: exynos: realign the code to allow support for newer 64-bit platforms

2016-04-21 Thread Minkyu Kang
Hi, On 18/04/16 23:11, Thomas Abraham wrote: > Hi Mr. Kang, > > On Mon, Apr 18, 2016 at 4:39 PM, Minkyu Kang wrote: >> Dear Thomas Abraham, >> >> On 13/04/16 19:43, Thomas Abraham wrote: >>> From: Thomas Abraham >>> >>> The existing E

[U-Boot] please pull u-boot-samsung master

2016-04-26 Thread Minkyu Kang
++ include/configs/exynos-common.h | 1 + 2 files changed, 7 insertions(+), 4 deletions(-) -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 00/25] exynos: video: Convert exynos LCD driver to use driver model

2016-05-09 Thread Minkyu Kang
Hi Jaehoon, On 08/05/16 06:25, Simon Glass wrote: > Hi, > > On 1 March 2016 at 18:51, Minkyu Kang wrote: >> Hi, >> >> On 29/02/16 16:18, Jaehoon Chung wrote: >>> Hi, >>> >>> On 02/29/2016 01:23 PM, Simon Glass wrote: >>>&

Re: [U-Boot] [PATCH] Use correct spelling of "U-Boot"

2016-01-30 Thread Minkyu Kang
t mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > Reviewed-by: Minkyu Kang -- from. prom. www.promsoft.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] exynos: Set CNTFRQ

2016-02-10 Thread Minkyu Kang
gt; +#define CONFIG_TIMER_CLK_FREQ2400 patch looks good but, Please make sure that it doesn't have a different value with system clock, always. (If you expected it) #define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ > > #def

Re: [U-Boot] [PATCH v2 00/25] exynos: video: Convert exynos LCD driver to use driver model

2016-02-23 Thread Minkyu Kang
to master >> - Rebase to master >> > > What do you think we should do about applying this series? > Although we have to do remaining work, I think applying is possible without next work. Board maintainers, what do you think? Remaining Work: - MIPI display driver - s5pc2

<    9   10   11   12   13   14   15   16   >