Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-03-04 Thread Michal Suchánek
On Sat, Mar 04, 2023 at 01:54:12PM -0600, Samuel Holland wrote: > On 2/20/23 13:42, Michal Suchánek wrote: > > On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: > >> > >> On 2/20/23 05:46, Michal Suchánek wrote: > >>> On Sun, Feb 19, 2023 at

Re: [PATCH 3/6] clk: Fix error handling in clk_get_parent()

2023-03-04 Thread Michal Suchánek
On Sat, Mar 04, 2023 at 01:58:17PM -0600, Samuel Holland wrote: > On 2/20/23 04:39, Michal Suchánek wrote: > > On Sun, Feb 19, 2023 at 11:59:36PM -0600, Samuel Holland wrote: > >> Do not return both NULL and error pointers. The function is only > >> documented

Re: [PATCH] pci: Fix device_find_first_child() return value handling

2023-07-17 Thread Michal Suchánek
Hello, On Sun, Jul 16, 2023 at 05:53:24PM +0200, Marek Vasut wrote: > This function only ever returns 0, but may not assign the second > parameter. Same thing for device_find_next_child(). Do not assign > ret to stop proliferation of this misuse. > > Reported-by: Jonas Karlman > Signed-off-by: M

Re: [PATCH] am33xx: ignore return value from usb_ether_init()

2023-08-31 Thread Michal Suchánek
follow suit in the am33xx code. then there is the question what point is there in having a return value in this function at all. Anyway, it's fine to not check the return value in the caller if there is no use for the error. Reviewed-by: Michal Suchánek > > Do not cause the

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-09-17 Thread Michal Suchánek
Hello, On Sat, Sep 17, 2022 at 09:02:53AM -0600, Simon Glass wrote: > Hi Michal, > > On Wed, 31 Aug 2022 at 11:44, Simon Glass wrote: > > > > Hi Michal, > > > > On Wed, 31 Aug 2022 at 01:39, Michal Suchánek wrote: > > > > > > Hello, > >

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-09-24 Thread Michal Suchánek
Hello, On Sat, Sep 17, 2022 at 07:04:25PM +0200, Michal Suchánek wrote: > Hello, > > On Sat, Sep 17, 2022 at 09:02:53AM -0600, Simon Glass wrote: > > Hi Michal, > > > > On Wed, 31 Aug 2022 at 11:44, Simon Glass wrote: > > > > > > Hi Michal, >

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-09-25 Thread Michal Suchánek
On Sun, Sep 25, 2022 at 08:15:31AM -0600, Simon Glass wrote: > Hi Michal, > > On Sat, 24 Sept 2022 at 14:10, Michal Suchánek wrote: > > > > Hello, > > > > On Sat, Sep 17, 2022 at 07:04:25PM +0200, Michal Suchánek wrote: > > > Hello, > > > &g

Re: [RESEND 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-09-28 Thread Michal Suchánek
On Wed, Sep 28, 2022 at 10:26:35AM +0100, Lee Jones wrote: > On Fri, 09 Sep 2022, Kever Yang wrote: > > > Hi Lee Jones, > > > > On 2022/9/8 15:44, Lee Jones wrote: > > > On Thu, 11 Aug 2022, Lee Jones wrote: > > > > > > > This set fixes several issues found on the Rock Pi 4. > > > > > > > > For

Re: [PATCH v5 09/15] cmd: List all uclass devices regardless of probe error

2022-10-02 Thread Michal Suchánek
Hello, On Thu, Sep 29, 2022 at 04:00:42AM -0600, Simon Glass wrote: > On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > > > There are a few commands that iterate uclass with > > uclass_first_device/uclass_next_device or the _err variant. > > > > Use the _check class iterator variant to ge

Re: [PATCH v5 04/15] bootstd: Fix listing boot devices

2022-10-02 Thread Michal Suchánek
On Thu, Sep 29, 2022 at 04:00:32AM -0600, Simon Glass wrote: > Hi Michal, > > On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > > > bootdev_list() uses uclass_*_device_err() to iterate devices. > > However, the only value _err adds is returning an error when the device > > pointer is null

Re: [PATCH v4 04/21] dm: blk: Add probe in blk_first_device/blk_next_device

2022-10-02 Thread Michal Suchánek
On Thu, Sep 29, 2022 at 04:00:26AM -0600, Simon Glass wrote: > Hi Michal, > > On Sun, 25 Sept 2022 at 02:28, Michal Suchanek wrote: > > > > The description claims that the device is probed but it isn't. > > > > Add the device_probe() call. > > > > Also consolidate the iteration into one function.

Re: [PATCH] power: pmic: rk8xx: Workaround pmic failure when probed before relocation

2022-08-08 Thread Michal Suchánek
On Mon, Aug 08, 2022 at 01:26:23PM -0600, Simon Glass wrote: > Hi Michal, > > On Sat, 6 Aug 2022 at 13:54, Michal Suchánek wrote: > > > > On Sat, Aug 06, 2022 at 12:21:29PM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On

Re: ethernet dt aliases implications in U-Boot and Linux

2022-08-08 Thread Michal Suchánek
On Mon, Aug 08, 2022 at 03:57:55PM -0400, Sean Anderson wrote: > Hi Tim, > > On 8/8/22 3:18 PM, Tim Harvey wrote: > > Greetings, > > > > I'm trying to understand if there is any implication of 'ethernet' > > aliases in Linux such as: > > aliases { > > ethernet0 = &eqos; >

Re: ethernet dt aliases implications in U-Boot and Linux

2022-08-08 Thread Michal Suchánek
On Mon, Aug 08, 2022 at 02:38:35PM -0700, Stephen Hemminger wrote: > On Mon, 8 Aug 2022 23:09:45 +0200 > Michal Suchánek wrote: > > > On Mon, Aug 08, 2022 at 03:57:55PM -0400, Sean Anderson wrote: > > > Hi Tim, > > > > > > On 8/8/22 3:18

Re: ethernet dt aliases implications in U-Boot and Linux

2022-08-10 Thread Michal Suchánek
On Wed, Aug 10, 2022 at 03:11:48AM +0200, Andrew Lunn wrote: > > Is something like the following really that crazy of an idea? > > diff --git a/net/core/dev.c b/net/core/dev.c > > index e0878a500aa9..a679c74a63c6 100644 > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -1151,6 +1151,15 @@ st

Re: ethernet dt aliases implications in U-Boot and Linux

2022-08-10 Thread Michal Suchánek
On Wed, Aug 10, 2022 at 05:17:56PM +0200, Andrew Lunn wrote: > > > I guess you are new to the netdev list :-) > > > > > > This is one of those FAQ sort of things, discussed every > > > year. Anything like this is always NACKed. I don't see why this time > > > should be any different. > > > > > >

Re: [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-08-11 Thread Michal Suchánek
-by: YouMin Chen > Signed-off-by: Lee Jones > Tested-by: Xavier Drudis Ferran Also does not cause any regression on a Pinebook Pro Tested-by: Michal Suchánek Thanks Michal > Reviewed-by: Kever Yang > --- > drivers/ram/rockchip/sdram_rk3399.c | 36 +

Re: [PATCH v2] dm: core: Do not stop uclass iteration on error.

2022-08-18 Thread Michal Suchánek
On Thu, Aug 18, 2022 at 11:49:53AM -0600, Simon Glass wrote: > Hi Michal, > > On Wed, 17 Aug 2022 at 02:28, Michal Suchanek wrote: > > > > When probing a device fails NULL pointer is returned, and other devices > > cannot be iterated. Skip to next device on error instead. > > > > Fixes: 6494d708b

Re: [PATCH] doc: dm: clarify activation.

2022-08-19 Thread Michal Suchánek
Hello, On Sat, Aug 20, 2022 at 08:27:05AM +0200, Heinrich Schuchardt wrote: > On 8/4/22 22:30, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 4 Aug 2022 at 13:42, Michal Suchánek wrote: > > > > > > On Thu, Aug 04, 2022 at 01:22:53PM -060

Re: [PATCH 1/2] patman: do not hardcode coverage tool

2022-08-30 Thread Michal Suchánek
On Tue, Aug 30, 2022 at 12:01:55PM +0200, Quentin Schulz wrote: > Hi Michal, > > On 8/25/22 08:49, Michal Suchanek wrote: > > The coverage tool name varies across distributions. > > > > Add COVERAGE variable to specify the tool name. > > > > Also there is one place where prefix is prepended to t

Re: [PATCH 2/2] tests: Do not hardcode sudo tool

2022-08-30 Thread Michal Suchánek
On Thu, Aug 25, 2022 at 09:01:08AM -0600, Simon Glass wrote: > Hi Michal, > > On Wed, 24 Aug 2022 at 23:51, Michal Suchanek wrote: > > > > In some situations it may be needed to pass parameters to sudo or to use > > a different tool to gain root access. Add SUDO variable to specify the > > sudo t

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-30 Thread Michal Suchánek
On Sat, Aug 27, 2022 at 07:52:27PM -0600, Simon Glass wrote: > Hi Michal, > > On Fri, 19 Aug 2022 at 14:23, Michal Suchanek wrote: > > > > When probing a device fails NULL pointer is returned, and other devices > > cannot be iterated. Skip to next device on error instead. > > > > Fixes: 6494d708b

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-30 Thread Michal Suchánek
On Tue, Aug 30, 2022 at 09:56:52AM -0600, Simon Glass wrote: > Hi Michal, > > On Tue, 30 Aug 2022 at 04:23, Michal Suchánek wrote: > > > > On Sat, Aug 27, 2022 at 07:52:27PM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On F

Re: [PATCH v3] dm: core: Do not stop uclass iteration on error

2022-08-31 Thread Michal Suchánek
Hello, On Tue, Aug 30, 2022 at 09:15:12PM -0600, Simon Glass wrote: > Hi Michal, > > On Tue, 30 Aug 2022 at 10:48, Michal Suchánek wrote: > > > > On Tue, Aug 30, 2022 at 09:56:52AM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On T

Re: [PATCH 1/2] patman: do not hardcode coverage tool

2022-08-31 Thread Michal Suchánek
Hello, On Wed, Aug 31, 2022 at 12:08:32PM +0200, Quentin Schulz wrote: > Hi Michal, > > On 8/30/22 12:11, Michal Suchánek wrote: > > On Tue, Aug 30, 2022 at 12:01:55PM +0200, Quentin Schulz wrote: > > > Hi Michal, > > > > > > On 8/25/22 08:49, Michal

Re: [PATCH v2 1/2] spl: enable regulator-boot-on and disable regulator-force-boot-off

2022-09-01 Thread Michal Suchánek
Hello, On Thu, Sep 01, 2022 at 08:36:23PM +0800, Kever Yang wrote: > Hi Quentin, > >     I don't think we need to add regulators_enable_boot_on/off callback in > SPL framework, > > the rk3399-puma/Qseven is the only board need to do this in the SPL right > now. > >     The hardware design for S

Re: [PATCH 2/2] serial: introduce CONFIG_CONSOLE_FLUSH_ON_NEWLINE

2023-09-25 Thread Michal Suchánek
Hello, On Mon, Sep 25, 2023 at 01:01:01PM +0200, Rasmus Villemoes wrote: > When debugging, one sometimes only gets partial output lines or > nothing at all from the last printf, because the uart has a largish > buffer, and the code after the printf() may cause the CPU to hang > before the uart IP

Re: [PATCH] pci: Fix device_find_first_child() return value handling

2023-07-26 Thread Michal Suchánek
Hello, On Wed, Jul 26, 2023 at 06:49:57PM -0600, Simon Glass wrote: > Hi Marek, > > On Mon, 17 Jul 2023 at 11:03, Marek Vasut wrote: > > > > On 7/17/23 09:42, Michal Suchánek wrote: ... > > > More generally, what is the overall vision for these functio

Re: Problem upon startup with halted USB device on RaspberryPi 4

2023-08-13 Thread Michal Suchánek
Hello, On Sat, Aug 12, 2023 at 08:31:56PM +0200, Massimo Pegorer wrote: > Hi Harry, > > Il giorno lun 7 ago 2023 alle ore 11:02 Harry Waschkeit < > harry.waschk...@conplement.de> ha scritto: > > > Hi, > > > > I have a RaspberryPi 4 where on one USB port a Sierra Wireless LTE > > module (EM7455)

Re: [PATCH] rockchip: rk3399: pass platform parameter to TF-A by default

2022-12-18 Thread Michal Suchánek
Hello, On Sun, Dec 18, 2022 at 06:00:13PM +0800, Kever Yang wrote: > Hi Quentin, > >     I would prefer you to remove SPL_ATF_NO_PLATFORM_PARAM in those boards > you have test, then we will have no end of this problem. > > there may have some boards using legacy ATF binary but still want to us

Re: [PATHv11 01/43] submodule: add lwIP as git submodule

2023-11-30 Thread Michal Suchánek
Hello, On Wed, Nov 29, 2023 at 07:45:28PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 27 Nov 2023 at 11:16, Tom Rini wrote: > > > > On Mon, Nov 27, 2023 at 06:56:44PM +0600, Maxim Uvarov wrote: > > > > > add external lwIP library as a git submodule. > > > Use STABLE-2_2_0_RELEASE tag. > > >

SPI bus not probed

2020-09-27 Thread Michal Suchánek
Hello, When I enable SPI support I do not get a SPI bus. Config: --- a/configs/orangepi_zero_defconfig +++ b/configs/orangepi_zero_defconfig @@ -11,3 +11,21 @@ CONFIG_CONSOLE_MUX=y CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_OHCI_HCD=y +CONFIG_SPI=y +CONFIG_DM_SPI=y +CONFIG_DM_SPI_FLA

Re: SPI bus not probed

2020-09-28 Thread Michal Suchánek
On Sun, Sep 27, 2020 at 10:35:30PM +0200, Michal Suchánek wrote: > Hello, > > When I enable SPI support I do not get a SPI bus. > > Config: > --- a/configs/orangepi_zero_defconfig > +++ b/configs/orangepi_zero_defconfig > @@ -11,3 +11,21 @@ CONFIG_CONSOLE_MUX=

Re: [PATCH 00/18] Add support for MediaTek MT7620 SoC

2020-10-16 Thread Michal Suchánek
Hello, I would suggest to use --thread with format-patch when sending patches. Thanks Michal On Fri, Oct 16, 2020 at 03:35:01PM +0800, Weijie Gao wrote: > This series will add support for MediaTek MT7620 SoC with two reference boards > and related drivers. > > The MediaTek MT7620 is a 2x2 802.

rk3399 after reboot mmc1 is inaceessible

2022-07-03 Thread Michal Suchánek
Hello, after rebooting rk3399 Pinebook Pro mmc1 is no longer accessible from u-boot, and video is not working, only cold boot works. This is not a problem anymore when Linux is loaded from another device. Any idea how to debug this? Thanks Michal U-Boot TPL 2022.07-rc5 (May 16 2022 - 12:00:00

Re: [PATCH 2/2] cmd: boot: add brom cmd to reboot to FEL mode

2022-07-04 Thread Michal Suchánek
Hello, On Sun, Jul 03, 2022 at 11:23:26PM +0100, Andre Przywara wrote: > On Sun, 3 Jul 2022 21:20:22 +0200 > Michal Suchanek wrote: > > Hi Michal, > > > p-boot uses RTC GPR 1 value 0xb0010fe1 to flag FEL boot on A64 > > > > Default to the same. > > Please don't add any more #ifdef's to U-Boo

Re: [PATCH 0/2] Command for entering mask rom USB download mode

2022-07-04 Thread Michal Suchánek
On Sun, Jul 03, 2022 at 11:22:51PM +0100, Andre Przywara wrote: > On Sun, 3 Jul 2022 21:20:20 +0200 > Michal Suchanek wrote: > > Hi, > > > many ARM SoCs have a mask rom feature that provides interface for > > downloading firmware over USB. > > > > Downstream rockchip u-boot has 'brom' or 'rbro

Re: [PATCH 0/2] Command for entering mask rom USB download mode

2022-07-04 Thread Michal Suchánek
On Sun, Jul 03, 2022 at 06:26:22PM -0500, Samuel Holland wrote: > Hi Michal, > > On 7/3/22 2:20 PM, Michal Suchanek wrote: > > > > Hello, > > > > many ARM SoCs have a mask rom feature that provides interface for > > downloading firmware over USB. > > > > Downstream rockchip u-boot has 'brom' or

Re: [PATCH v2 1/2] power: pmic: rk8xx: Support sysreset shutdown method

2022-07-07 Thread Michal Suchánek
Hello, this causes regression on pinebook pro: resetting ... System reset not supported on this platform ### ERROR ### Please RESET the board ### Is there something missing in the DT for this board? Or perhaps a fallback should be provided in absence of the PMIC? Thanks Michal On Fri, May 27

Re: rk3399 after reboot mmc1 is inaceessible

2022-07-09 Thread Michal Suchánek
read error Trying to boot from SPI Trying to boot from MMC2 Sending CMD16 Sending CMD17 mmc_load_image_raw_sector: mmc block read error SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### On Sun, Jul 03, 2022 at 01:59:15PM +0200, Michal Suchánek wrote: > He

Re: [PATCH v4 04/21] dm: blk: Add probe in blk_first_device/blk_next_device

2022-10-10 Thread Michal Suchánek
On Sun, Oct 02, 2022 at 07:10:40PM -0600, Simon Glass wrote: > Hi Michal, > > On Sun, 2 Oct 2022 at 13:34, Michal Suchánek wrote: > > > > On Thu, Sep 29, 2022 at 04:00:26AM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On Su

Re: [PATCH v4 04/21] dm: blk: Add probe in blk_first_device/blk_next_device

2022-10-10 Thread Michal Suchánek
On Mon, Oct 10, 2022 at 09:49:20PM +0200, Michal Suchánek wrote: > On Sun, Oct 02, 2022 at 07:10:40PM -0600, Simon Glass wrote: > > Hi Michal, > > > > On Sun, 2 Oct 2022 at 13:34, Michal Suchánek wrote: > > > > > > On Thu, Sep 29, 2022 at 04:00:26AM -060

Re: [PATCH 1/2] image: Suppress string truncation warning

2022-10-13 Thread Michal Suchánek
On Thu, Oct 13, 2022 at 09:29:22AM +0200, Rasmus Villemoes wrote: > On 12/10/2022 21.47, Michal Suchanek wrote: > > In file included from ../tools/imagetool.h:24, > > from ../tools/default_image.c:16: > > In function ‘image_set_name’, > > inlined from ‘image_set_header’ at ../t

Re: [PATCH v2 1/2] image: Fix string truncation warning

2022-10-13 Thread Michal Suchánek
On Thu, Oct 13, 2022 at 10:16:56AM +0200, Michal Suchanek wrote: > In file included from ../tools/imagetool.h:24, > from ../tools/default_image.c:16: > In function ‘image_set_name’, > inlined from ‘image_set_header’ at ../tools/default_image.c:133:2: > ../include/image.h:786:9:

Re: [PATCH] sandbox: Eliminate CONFIG_HOST_32/64BIT

2022-10-14 Thread Michal Suchánek
Hello, On Fri, Oct 14, 2022 at 08:40:52AM +0200, Heinrich Schuchardt wrote: > From: Heinrich Schuchardt > > Building sandbox_defconfig on 32bit systems requires manual configuration. > we should void this. > > The compiler provides symbol __LP64__. This is enough to know if the host > is a 64bi

Re: [PATCH] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Michal Suchánek
On Fri, Oct 14, 2022 at 05:05:26AM +0200, Heinrich Schuchardt wrote: > On 10/13/22 22:28, Michal Suchanek wrote: > > Currently sandbox configuration defautls to 64bit and there is no > > automation for building 32bit sandbox on 32bit hosts. > > > > cpp does not know about target specification, cod

Re: [PATCH] sandbox: Eliminate CONFIG_HOST_32/64BIT

2022-10-14 Thread Michal Suchánek
On Fri, Oct 14, 2022 at 01:33:33PM +0200, Heinrich Schuchardt wrote: > On 10/14/22 10:33, Michal Suchánek wrote: > > Hello, > > > > On Fri, Oct 14, 2022 at 08:40:52AM +0200, Heinrich Schuchardt wrote: > > > From: Heinrich Schuchardt > > > > >

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-15 Thread Michal Suchánek
On Sat, Oct 15, 2022 at 06:54:02AM +0200, Heinrich Schuchardt wrote: > On 10/14/22 22:52, Michal Suchanek wrote: > > Currently sandbox configuration defautls to 64bit and there is no > > automation for building 32bit sandbox on 32bit hosts. > > > > Use _LP64 macro as heuristic for detecting 64bit

Re: [PATCH 1/1] sandbox: make sandbox system reset configurable

2022-10-15 Thread Michal Suchánek
Hello, On Sat, Oct 15, 2022 at 10:39:19AM +0200, Heinrich Schuchardt wrote: > To test the watchdog system reset we need to disable the default sandbox > system reset. > > The following settings provide the reset command via watchdog on the > sandbox: > > CONFIG_WDT_GPIO=n > CONFIG_WDT_SA

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-15 Thread Michal Suchánek
On Sat, Oct 15, 2022 at 09:05:53PM +0200, Heinrich Schuchardt wrote: > On 10/15/22 20:39, Simon Glass wrote: > > Hi Heinrich, > > > > On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt > > wrote: > > > > > > On 10/15/22 19:53, Simon Glass wrote: > > > > Hi Michal, > > > > > > > > On Fri, 14 Oct

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: > k210 is 64bit but the driver and tests are also built in sandbox, and > that can be built 32bit. > > BIT(32) does not work on 32bit, shift before subtraction to fit into > 32bit integer with BIT values. Also see https://patchwork

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
> > On 10/16/22 10:40, Heinrich Schuchardt wrote: > > > > > > > > > > > > > > > On 10/16/22 16:19, Sean Anderson wrote: > > > > > > On 10/16/22 07:46, Heinrich Schuchardt wrote: > > > > > > > > > &g

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-17 Thread Michal Suchánek
On Sat, Oct 15, 2022 at 10:27:43PM +0200, Heinrich Schuchardt wrote: > On 10/15/22 21:46, Simon Glass wrote: > > Hi Heinrich, > > > > On Sat, 15 Oct 2022 at 13:29, Heinrich Schuchardt > > wrote: > > > > > > > > > > > > Am 15. Oktober 2022 21:24:36 MESZ schrieb Simon Glass : > > > > Hi Heinric

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-22 Thread Michal Suchánek
On Fri, Oct 21, 2022 at 06:05:51PM -0700, Simon Glass wrote: > Hi, > > On Mon, 17 Oct 2022 at 01:28, Michal Suchánek wrote: > > > > On Sat, Oct 15, 2022 at 10:27:43PM +0200, Heinrich Schuchardt wrote: > > > On 10/15/22 21:46, Simon Glass wrote: > > > > H

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2022-10-23 Thread Michal Suchánek
On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: > > > Am 22. Oktober 2022 23:22:01 MESZ schrieb Michal Suchanek : > >SANDBOX_BITS_PER_LONG is the number of bits in long on the sandbox > >platform. > > Please, explain in the commit message what this patch is good for. For se

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2022-10-23 Thread Michal Suchánek
On Sun, Oct 23, 2022 at 09:56:29AM +0200, Heinrich Schuchardt wrote: > On 10/23/22 09:50, Michal Suchánek wrote: > > On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 22. Oktober 2022 2

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-02-08 Thread Michal Suchánek
Hello, On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: > > > Hi Michal, > > thanks for testing! Do you consider keyboard as working once it is detected > without > 'usb_kbd usb_kbd: Timeout poll on interrupt endpoint', or judging from > subsequent > typing? Note that issue is

Re: [PATCH] lmb: Bump CONFIG_LMB_MAX_REGIONS

2023-02-08 Thread Michal Suchánek
Hello, On Wed, Feb 08, 2023 at 01:25:50PM -0500, Tom Rini wrote: > On Wed, Feb 08, 2023 at 07:24:25PM +0100, Francesco Dolcini wrote: > > Hello, > > > > On Fri, Jan 27, 2023 at 08:54:55AM -0500, Tom Rini wrote: > > > On Fri, Jan 27, 2023 at 02:00:12PM +0100, Michal Suchanek wrote: > > > > It is r

Re: [PATCH] lmb: Bump CONFIG_LMB_MAX_REGIONS

2023-02-17 Thread Michal Suchánek
Hello, On Sun, Feb 12, 2023 at 06:45:36PM -0500, Tom Rini wrote: > On Wed, Feb 08, 2023 at 02:50:16PM -0500, Tom Rini wrote: > > On Wed, Feb 08, 2023 at 08:11:34PM +0100, Michal Suchánek wrote: > > > Hello, > > > > > > On Wed, Feb 08, 2023 at 01:25:50PM -0500,

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Michal Suchánek
Hello, On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: > log_ret() cannot work with unsigned values, and the assignment to 'ret' > incorrectly truncates the rate from long to int. > > Fixes: 5c5992cb90cf ("clk: Add debugging for return values") > Signed-off-by: Samuel Holland > -

Re: [PATCH 3/6] clk: Fix error handling in clk_get_parent()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:36PM -0600, Samuel Holland wrote: > Do not return both NULL and error pointers. The function is only > documented as returning error pointers. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers") > Signed-off-by: Samuel Holland > --- > > driver

Re: [PATCH 4/6] clk: Fix rate caching in clk_get_parent_rate()

2023-02-20 Thread Michal Suchánek
if (!pclk->rate || IS_ERR_VALUE(pclk->rate) || > + pclk->flags & CLK_GET_RATE_NOCACHE) > pclk->rate = clk_get_rate(pclk); > > return pclk->rate; With the current code that randomly returns one or the other this is the correct thing to do. Reviewed-by: Michal Suchánek Thanks Michal

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > return error pointers. clk_valid() should not consider these pointers > to be valid. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers")

Re: [PATCH 5/6] clk: Remove an unneeded check from clk_get_parent_rate()

2023-02-20 Thread Michal Suchánek
return -ENODEV; > > - ops = clk_dev_ops(pclk->dev); > - if (!ops->get_rate) > - return -ENOSYS; > - > /* Read the 'rate' if not already set or if proper flag set*/ > if (!pclk->rate || IS_ERR_VALUE(pclk->rate) || > pclk->flags & CLK_GET_RATE_NOCACHE) Reviewed-by: Michal Suchánek Thanks Michal

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Michal Suchánek
Hello, On Mon, Feb 20, 2023 at 11:08:41AM -0500, Sean Anderson wrote: > On 2/20/23 05:37, Michal Suchánek wrote: > > Hello, > > > > On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: > > > log_ret() cannot work with unsigned values, and the assignm

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: > > On 2/20/23 05:46, Michal Suchánek wrote: > > On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > > > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > > > re

Re: [PATCH v2 1/2] power: pmic: rk8xx: Support sysreset shutdown method

2022-07-15 Thread Michal Suchánek
On Fri, Jul 15, 2022 at 12:10:47PM -0500, Chris Morgan wrote: > On Thu, Jul 07, 2022 at 10:41:34AM +0200, Michal Suchánek wrote: > > Hello, > > > > this causes regression on pinebook pro: > > > > resetting ... > > System reset not supported on this plat

Re: [PATCH v2 1/2] power: pmic: rk8xx: Support sysreset shutdown method

2022-07-16 Thread Michal Suchánek
On Fri, Jul 15, 2022 at 07:18:07PM +0200, Michal Suchánek wrote: > On Fri, Jul 15, 2022 at 12:10:47PM -0500, Chris Morgan wrote: > > On Thu, Jul 07, 2022 at 10:41:34AM +0200, Michal Suchánek wrote: > > > Hello, > > > > > > this causes regression on

Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

2022-07-18 Thread Michal Suchánek
On Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz wrote: > Hi Xavier, > > On 7/15/22 18:30, Xavier Drudis Ferran wrote: > > Spi0 is not needed in SPL and SPL could be a little smaller without it, > > but then the SF_DEFAULT_BOOT would have to be 0 to refer to spi1, and > > that's confusing,

Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

2022-07-18 Thread Michal Suchánek
On Mon, Jul 18, 2022 at 11:09:56AM +0200, Xavier Drudis Ferran wrote: > El Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz deia: > > Hi Xavier, > > > > On 7/15/22 18:30, Xavier Drudis Ferran wrote: > > > Spi0 is not needed in SPL and SPL could be a little smaller without it, > > > but then t

Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

2022-07-18 Thread Michal Suchánek
On Mon, Jul 18, 2022 at 03:01:25PM +0200, Quentin Schulz wrote: > Hi Michal, > > On 7/18/22 13:00, Michal Suchánek wrote: > > On Mon, Jul 18, 2022 at 11:09:56AM +0200, Xavier Drudis Ferran wrote: > > > El Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz

Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

2022-07-18 Thread Michal Suchánek
On Mon, Jul 18, 2022 at 03:14:33PM +0200, Xavier Drudis Ferran wrote: > El Mon, Jul 18, 2022 at 01:00:03PM +0200, Michal Suchánek deia: > > > mmc@fe31: 3 > > mmc@fe32: 1 (SD) > > mmc@fe33: 0 (eMMC) > > > > This is not consistent with any of the

Re: [bug] boot failure on pinebook pro due to rk8xx changes in 2022.07

2022-07-19 Thread Michal Suchánek
Hello, On Mon, Jul 18, 2022 at 05:37:18PM -0500, Chris Morgan wrote: > On Mon, Jul 18, 2022 at 03:39:43PM +0200, Jan Palus wrote: > > u-boot 2022.07 successfully finds and loads kernel (5.18.3) on my > > Pinebook Pro however boot process fails when loading rk808 module: > > > > rk3x-i2c ff3c000

Re: [PATCH] Revert "power: pmic: rk8xx: Support sysreset shutdown method"

2022-07-25 Thread Michal Suchánek
Hello, On Sat, Jul 23, 2022 at 10:42:36AM -0600, Simon Glass wrote: > Hi Chris, > > On Fri, 22 Jul 2022 at 11:32, Chris Morgan wrote: > > > > From: Chris Morgan > > > > This reverts commit ad607512f5757f4485968efd5bcf2c0245a8a235. > > > > It was found during extensive testing that this causes p

Re: [PATCH] dm: core: Do not stop uclass iteration on error.

2022-08-04 Thread Michal Suchánek
Hello, On Thu, Aug 04, 2022 at 01:22:57PM -0600, Simon Glass wrote: > Hi Michal, > > On Thu, 4 Aug 2022 at 11:59, Michal Suchanek wrote: > > > > When probing a device fails NULL pointer is returned, and other devices > > cannot be iterated. Skip to next device on error instead. > > > > Fixes: 64

Re: [PATCH] doc: dm: clarify activation.

2022-08-04 Thread Michal Suchánek
On Thu, Aug 04, 2022 at 01:22:53PM -0600, Simon Glass wrote: > Hi Michal, > > On Thu, 4 Aug 2022 at 11:58, Michal Suchanek wrote: > > > > Explain when devices should get activated. > > > > Signed-off-by: Michal Suchanek > > --- > > doc/develop/driver-model/design.rst | 22 --

Re: [PATCH] power: pmic: rk8xx: Workaround pmic failure when probed before relocation

2022-08-05 Thread Michal Suchánek
On Fri, Aug 05, 2022 at 10:48:26AM -0600, Simon Glass wrote: > Hi Michal, > > On Fri, 5 Aug 2022 at 05:32, Michal Suchanek wrote: > > > > When the sysreset is added as child of the pmic the pmic is probed > > before relocation. That probe fails, and subsequent attempts to probe > > after reloacti

Re: [PATCH] power: pmic: rk8xx: Workaround pmic failure when probed before relocation

2022-08-06 Thread Michal Suchánek
On Sat, Aug 06, 2022 at 12:21:29PM -0600, Simon Glass wrote: > Hi Michal, > > On Fri, 5 Aug 2022 at 14:07, Michal Suchánek wrote: > > > > On Fri, Aug 05, 2022 at 10:48:26AM -0600, Simon Glass wrote: > > > Hi Michal, > > > > > > On

rk3399 TPL memory setup code triggers clock frequency limit assertion

2022-08-07 Thread Michal Suchánek
Hello, when compiled with clock debug rk3399 cannot be booted because memory setup code triggers clock assertion: U-Boot TPL 2022.07-00038-g61e11a8e9f-dirty (Aug 07 2022 - 16:13:17) TPL PLL at ff76: fbdiv=50, refdiv=1, postdiv1=2, postdiv2=1, vco=120 khz, output=60 khz TPL PLL at ff7

Re: rk3399 TPL memory setup code triggers clock frequency limit assertion

2022-08-07 Thread Michal Suchánek
On Sun, Aug 07, 2022 at 08:31:56PM +0530, Jagan Teki wrote: > On Sun, Aug 7, 2022 at 8:14 PM Michal Suchánek wrote: > > > > Hello, > > > > when compiled with clock debug rk3399 cannot be booted because memory > > setup code triggers clock assertion: > > &

Re: [SPAM] rk3399 TPL memory setup code triggers clock frequency limit assertion

2022-08-08 Thread Michal Suchánek
On Mon, Aug 08, 2022 at 04:28:33PM +0200, Xavier Drudis Ferran wrote: > El Sun, Aug 07, 2022 at 04:44:04PM +0200, Michal Suchánek deia: > > Hello, > > > > when compiled with clock debug rk3399 cannot be booted because memory > > setup code triggers clock assertion:

Re: [PATCH] arm: rockchip: rk3399: Program PLL clock for DDR at 50 MHz in documented range

2022-08-08 Thread Michal Suchánek
https://www.rockchip.fr/Rockchip%20RK3399%20TRM%20V1.4%20Part1.pdf > > Link: [2] https://patchwork.ozlabs.org/project/uboot/list/?series=305766 > > Signed-off-by: Xavier Drudis Ferran The incorrect clock settings trigger an assert and prevent the board from booting when clock debuggin

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 13:58:30 +0200 Marek Vasut wrote: > On 7/1/19 5:56 PM, Michal Suchanek wrote: > > Causes unbound key repeat on error otherwise. > > > > Signed-off-by: Michal Suchanek > > --- > > common/usb_kbd.c | 7 +++ > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff

Re: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 13:59:49 +0200 Marek Vasut wrote: > On 7/1/19 5:56 PM, Michal Suchanek wrote: > > Signed-off-by: Michal Suchanek > > --- > > common/usb.c | 9 + > > include/usb.h | 2 ++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/common/usb.c b/common/usb.c > > inde

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 15:11:07 +0200 Marek Vasut wrote: > On 7/2/19 3:04 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 13:58:30 +0200 > > Marek Vasut wrote: > > > >> On 7/1/19 5:56 PM, Michal Suchanek wrote: > >>> Causes unbound key repeat on

Re: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 22:16:02 +0800 Bin Meng wrote: > Hi Michal, > > On Tue, Jul 2, 2019 at 10:14 PM Michal Suchánek wrote: > > > > On Tue, 2 Jul 2019 13:59:49 +0200 > > Marek Vasut wrote: > > > > > On 7/1/19 5:56 PM, Michal Suchanek wrote

Re: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 22:29:42 +0800 Bin Meng wrote: > Hi Michal, > > On Tue, Jul 2, 2019 at 10:25 PM Michal Suchánek wrote: > > > > On Tue, 2 Jul 2019 22:16:02 +0800 > > Bin Meng wrote: > > > > > Hi Michal, > > > > > > O

Re: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 23:11:01 +0800 Bin Meng wrote: > Hi Michal, > > On Tue, Jul 2, 2019 at 10:58 PM Michal Suchánek wrote: > > > > On Tue, 2 Jul 2019 22:29:42 +0800 > > Bin Meng wrote: > > > > > Hi Michal, > > > > > > O

Re: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 23:39:42 +0800 Bin Meng wrote: > On Tue, Jul 2, 2019 at 11:30 PM Michal Suchánek wrote: > > > > On Tue, 2 Jul 2019 23:11:01 +0800 > > Bin Meng wrote: > > > > > Hi Michal, > > > > > > On Tue, Jul 2, 2019 at 10:58 PM Mich

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 18:58:54 +0200 Marek Vasut wrote: > On 7/2/19 4:22 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 15:11:07 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 3:04 PM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 19:50:05 +0200 Michal Suchánek wrote: > On Tue, 2 Jul 2019 18:58:54 +0200 > Marek Vasut wrote: > > > On 7/2/19 4:22 PM, Michal Suchánek wrote: > > > On Tue, 2 Jul 2019 15:11:07 +0200 > > > Marek Vasut wrote: > > > >

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 20:38:27 +0200 Marek Vasut wrote: > On 7/2/19 7:50 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 18:58:54 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 4:22 PM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

Re: [U-Boot] [PATCH v2 2/9] usb: sl811-hcd: return -ENOTSUPP from unimplemented submit_int_msg

2019-07-02 Thread Michal Suchánek
On Tue, 2 Jul 2019 20:41:04 +0200 Marek Vasut wrote: > On 7/2/19 7:55 PM, Michal Suchanek wrote: > > Commit message is still missing ... > > > Signed-off-by: Michal Suchanek > [...] It says "usb: sl811-hcd: return -ENOTSUPP from unimplemented submit_int_msg" Thanks Michal

Re: [U-Boot] [PATCH v2 3/9] usb_kdb: only process events succesfully received

2019-07-03 Thread Michal Suchánek
On Wed, 3 Jul 2019 09:37:42 +0800 Bin Meng wrote: > Hi Michal, > > On Wed, Jul 3, 2019 at 1:57 AM Michal Suchanek wrote: > > > > On error the data buffer does not contain valid data so do not submit it > > for processing. Usually it will contain the last data recieved so the > > last pressed ke

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-03 Thread Michal Suchánek
On Tue, 2 Jul 2019 23:20:28 +0200 Marek Vasut wrote: > On 7/2/19 9:31 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 20:38:27 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 7:50 PM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-03 Thread Michal Suchánek
On Wed, 3 Jul 2019 13:26:50 +0200 Marek Vasut wrote: > On 7/3/19 11:46 AM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 23:20:28 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 9:31 PM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

Re: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully received

2019-07-03 Thread Michal Suchánek
On Wed, 3 Jul 2019 13:48:00 +0200 Marek Vasut wrote: > On 7/3/19 1:43 PM, Michal Suchánek wrote: > > On Wed, 3 Jul 2019 13:26:50 +0200 > > Marek Vasut wrote: > > > >> On 7/3/19 11:46 AM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

Re: [U-Boot] [PATCH v2 2/9] usb: sl811-hcd: return -ENOTSUPP from unimplemented submit_int_msg

2019-07-04 Thread Michal Suchánek
On Tue, 2 Jul 2019 23:20:52 +0200 Marek Vasut wrote: > On 7/2/19 9:35 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 20:41:04 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 7:55 PM, Michal Suchanek wrote: > >> > >> Commit message is stil

Re: [U-Boot] [PATCH v2 5/9] usb: storage: submit_int_msg -> usb_int_msg

2019-07-04 Thread Michal Suchánek
On Wed, 3 Jul 2019 09:39:10 +0800 Bin Meng wrote: > On Wed, Jul 3, 2019 at 1:57 AM Michal Suchanek wrote: > > > > Use the wrapper because the unwrapped function prototype will be changed > > in the following patch. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: usb_submit_int_msg -> usb

Re: [U-Boot] [PATCH v2 2/9] usb: sl811-hcd: return -ENOTSUPP from unimplemented submit_int_msg

2019-07-04 Thread Michal Suchánek
On Thu, 4 Jul 2019 18:19:20 +0200 Marek Vasut wrote: > On 7/4/19 6:00 PM, Michal Suchánek wrote: > > On Tue, 2 Jul 2019 23:20:52 +0200 > > Marek Vasut wrote: > > > >> On 7/2/19 9:35 PM, Michal Suchánek wrote: > >>> On Tue, 2 Jul 20

  1   2   >