On Wed, 3 Jul 2019 09:37:42 +0800 Bin Meng <bmeng...@gmail.com> wrote:
> Hi Michal, > > On Wed, Jul 3, 2019 at 1:57 AM Michal Suchanek <msucha...@suse.de> wrote: > > > > On error the data buffer does not contain valid data so do not submit it > > for processing. Usually it will contain the last data recieved so the > > last pressed key will be repeated indefinitely on device failure. > > > > Signed-off-by: Michal Suchanek <msucha...@suse.de> > > --- > > v2: fix indentation > > --- > > common/usb_kbd.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/common/usb_kbd.c b/common/usb_kbd.c > > index 020f0d4117f7..74206d2de74f 100644 > > --- a/common/usb_kbd.c > > +++ b/common/usb_kbd.c > > @@ -317,10 +317,9 @@ static inline void usb_kbd_poll_for_event(struct > > usb_device *dev) > > struct usb_kbd_pdata *data = dev->privptr; > > > > /* Submit a interrupt transfer request */ > > - usb_submit_int_msg(dev, data->intpipe, &data->new[0], > > data->intpktsize, > > - data->intinterval); > > - > > - usb_kbd_irq_worker(dev); > > + if (!usb_submit_int_msg(dev, data->intpipe, &data->new[0], > > + data->intpktsize, data->intinterval)) > > The indentation still looks incorrect. It should align to one > character after the open parenthesis. It looks correct after the function is renamed twice in following patches. > > > + usb_kbd_irq_worker(dev); Anyway, the problem I was referring to was excessive indentation of this line in previous version of the patch. Thanks Michal _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
