Re: [PATCH v3 3/9] usb: dwc3-generic: Reorder include

2025-01-22 Thread Mattijs Korpershoek
y: Patrice Chotard > Cc: Marek Vasut Reviewed-by: Mattijs Korpershoek > > --- > > Changes in v3: > - Update comment by adding "Remove useless include files" > > Changes in v2: > - remove useless include files > > drivers/usb/dwc3/dwc3-generic.c | 2

Re: [PATCH v3 4/9] usb: dwc3-generic: Add STih407 support

2025-01-22 Thread Mattijs Korpershoek
eckpatch.pl --git --u-boot --git master..HEAD -- Commit 2a4d2432f669 ("usb: dwc3-generic: Add STih407 support") -- WARNING: please write a paragraph that describes the config symbol fully #42: FILE: drivers/usb/dwc3/Kconfig:90: +confi

[PATCH] boot: android: Check kcmdline's for NULL in android_image_get_kernel()

2025-01-13 Thread Mattijs Korpershoek
;boot: android: fix extra command line support") Signed-off-by: Aaron Kling Signed-off-by: Mattijs Korpershoek --- Thanks to Aaron for reporting this on the aosp-devs discord and for fixing this. --- boot/image-android.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

Re: [PATCH] configs: am62x_evm_*: Set DFU buffer size to 256k

2025-01-16 Thread Mattijs Korpershoek
_BUF_SIZE to the erase sector size, which still fits > within the post-relocation heap size in SPL. > > Fixes: dfc2dff5a844 ("configs: am62x_evm_*: Enable USB and DFU support") > > Signed-off-by: Jonathan Humphreys Reviewed-by: Mattijs Korpershoek >

Re: [PATCH v4 6/8] usb: dwc2: Extract macro definitions to common header

2025-01-16 Thread Mattijs Korpershoek
eader to reduce duplication. > > Signed-off-by: Kongyang Liu > Reviewed-by: Marek Vasut > Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/common/dwc2_core.h | 430 > + > dr

Re: [PATCH v4 7/8] usb: dwc2: Unify flush and reset logic with v4.20a support

2025-01-16 Thread Mattijs Korpershoek
Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > > --- > This commit does not add the handling of ret returned from the > dwc2_core_reset, dwc2_flush_tx_fifo and dwc2_flush_rx_fifo, because this > may involve changes to the code logi

Re: [PATCH v4 8/8] usb: dwc2: Replace uint_t types with u

2025-01-16 Thread Mattijs Korpershoek
g checkpatch.pl warnings. > > Signed-off-by: Kongyang Liu > Reviewed-by: Marek Vasut > Tested-by: Peter Robinson > Signed-off-by: Junhui Liu Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/dwc2_udc_otg.c | 4 +- > drivers/usb/host/dwc2.c | 100 > +

Re: [PATCH v2] usb: dwc3: core: Fix timeout check

2025-01-16 Thread Mattijs Korpershoek
NING: 'Tested-by:' is the preferred signature form #16: Tested-By: Varadarajan Narayanan total: 0 errors, 1 warnings, 0 checks, 33 lines checked > Signed-off-by: Varadarajan Narayanan I think Marek can fix-up that when he applies, but if you send a v3 to correct this, feel free to add

Re: [PATCH] usb: xhci-dwc3: Bail out if "dr_mode" is "peripheral"

2025-01-16 Thread Mattijs Korpershoek
Hi Siddharth, On lun., déc. 09, 2024 at 15:20, Roger Quadros wrote: > Hi Siddharth, > > On 06/12/2024 13:04, Siddharth Vadapalli wrote: >> Since the compatible "snps,dwc3" can be specified in the device-tree for >> the Designware USB Controller configured for not only Host and OTG modes >> of op

Re: [PATCH v2 8/9] board: stih410-b2260: Remove board_usb_init/cleanup()

2025-01-16 Thread Mattijs Korpershoek
init,cleanup}() getting removed! Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > board/st/stih410-b2260/board.c | 29 - > 1 file changed, 29 deletions(-) > > diff --git a/board/st/stih410-b2260/board.c b/board/st/stih4

Re: [PATCH v2 3/9] usb: dwc3-generic: Reorder include

2025-01-16 Thread Mattijs Korpershoek
removed the unused includes. A sentence like: "While at it, also remove the unused includes" would be nice to have. If you need to send v3 for other reasons than this comment, please consider adding it. In case, this is a nitpick, so: Reviewed-by: Mattijs Korpershoek > > Signed-of

Re: [PATCH v2 4/9] usb: dwc3-generic: Add STih407 support

2025-01-16 Thread Mattijs Korpershoek
Hi Patrice, Thank you for the patch. On jeu., janv. 16, 2025 at 09:17, Patrice Chotard wrote: > Add STi glue logic to manage the DWC3 HC on STiH407 > SoC family. It configures the internal glue logic and > syscfg registers. > > Signed-off-by: Patrice Chotard > Cc: Marek Vasut > > --- > > Cha

Re: [PATCH v2 6/9] usb: dwc3: Remove dwc3 glue driver support for STi

2025-01-16 Thread Mattijs Korpershoek
Hi Patrice, Thank you for the patch. On jeu., janv. 16, 2025 at 09:17, Patrice Chotard wrote: > STi is now using the dwc3-generic driver, dwc3-sti-glue driver > can be removed. > > Signed-off-by: Patrice Chotard > Cc: Marek Vasut Reviewed-by: Mattijs Korpershoek > -

Re: [PATCH] usb: xhci-dwc3: Bail out if "dr_mode" is "peripheral"

2025-01-16 Thread Mattijs Korpershoek
On jeu., janv. 16, 2025 at 15:48, Siddharth Vadapalli wrote: > On Thu, Jan 16, 2025 at 10:36:45AM +0100, Mattijs Korpershoek wrote: >> Hi Siddharth, > > Hello Mattijs, > >> >> On lun., déc. 09, 2024 at 15:20, Roger Quadros wrote: >> >> > Hi Siddha

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2025-01-16 Thread Mattijs Korpershoek
Hi Jon, Sorry for the (very) late reply. I had some long holidays in between and since this is a difficult topic for me, I kept pushing this to the end of my backlog. On mer., déc. 18, 2024 at 17:09, Jon Humphreys wrote: > Mattijs Korpershoek writes: > >> Hi Jonathan, >> &g

Re: [PATCH 00/43] test: Improvements to ut command and test-suite running

2025-01-16 Thread Mattijs Korpershoek
Hi Simon, Thank you for the series. On mer., janv. 15, 2025 at 06:30, Simon Glass wrote: > The current method of running unit tests relies on subcommands of the > ut command. Only the code in each subcommand knows how to find the tests > related to that subcomand. > > This is not ideal and we n

Re: [PATCH] MAINTAINERS: move myself to reviewers for avb/ab

2025-01-09 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On jeu., janv. 09, 2025 at 12:28, Igor Opaniuk wrote: > As Mattijs Korpershoek is in fact doing overall > maintenance of AVB/AB code, move myself to reviewers. > > CC: Mattijs Korpershoek > Signed-off-by: Igor Opaniuk Thanks for staying

Re: [PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties

2025-02-13 Thread Mattijs Korpershoek
off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek Some question below. > --- > Cc: Dragan Simic > Cc: Joe Hershberger > Cc: Mattijs Korpershoek > Cc: Quentin Schulz > Cc: Rasmus Villemoes > Cc: Simon Glass > Cc: Tom Rini > Cc:

Re: [PATCH v2 1/2] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-13 Thread Mattijs Korpershoek
Hi Michal, Thank you for testing this. On lun., févr. 10, 2025 at 13:40, Michal Simek wrote: > On 2/6/25 16:47, Jonathan Humphreys wrote: >> The current implementation of EFI capsule update uses set_dfu_alt_info() to >> set the dfu_alt_info environment variable with the settings it requires. >>

[GIT PULL] Please pull u-boot-dfu-20250321

2025-03-21 Thread Mattijs Korpershoek
Hi Tom, Please find the following fix for master: Usb gadget: - Fix NXP UUU tool compatibility regression with dwc3 gadget CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/25275 Thanks, Mattijs The following changes since commit 7ad543619463e8817b3044041ac74749a217bbe0

Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool

2025-03-24 Thread Mattijs Korpershoek
for SPL builds, and only for the ep1in interrupt-in endpoint. >> >> Fixes: 1918b8010c32 ("usb: dwc3: gadget: Convert epautoconf workaround to >> match_ep callback") >> Signed-off-by: Marek Vasut >> --- >> Cc: Alexander Sverdlin >> Cc: Felipe Balb

Re: usb:composite: data abort on second ums launch

2025-03-24 Thread Mattijs Korpershoek
Hi, Thank you for the report. On lun., mars 24, 2025 at 15:03, Marek Vasut wrote: > On 3/24/25 11:42 AM, Zixun LI wrote: >> Hi, >> >> I encountered a data abort on the 2nd "ums 0 mmc 0" command on >> u-boot-at91 2024.07 with sam9x60-curiosity board. >> >> U-Boot> ums 0 mmc 0 >> UMS: LUN 0, de

Re: [PATCH] usb: dwc3: gadget: Fix excepts/expects typo

2025-03-24 Thread Mattijs Korpershoek
--- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Mattijs Korpershoek > Cc: Neil Armstrong > Cc: Thinh Nguyen > Cc: Tom Rini > Cc: u-boot@lists.denx.de > --- > drivers/usb/dwc3/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Mattijs Korpershoek > [...] > -- > 2.47.2

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-20 Thread Mattijs Korpershoek
Hi Michael, Thank you for the patch. On mer., mars 12, 2025 at 08:36, Michael Walle wrote: > Fastboot works either over TCP, UDP or USB. The latter doesn't have > anything to do with networking, thus should work just fine with > regardless which network stack is selected. In practice, header sy

Re: [PATCH 3/3] configs: phycore_am62x_a53_defconfig: Enable gpio

2025-04-04 Thread Mattijs Korpershoek
interact > with GPIOs from the U-Boot shell. > > Signed-off-by: Daniel Schultz Reviewed-by: Mattijs Korpershoek > --- > configs/phycore_am62x_a53_defconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configs/phycore_am62x_a53_defconfig > b/config

Re: [PATCH v2 2/3] ARM: dts: sam9x60: Add USB gadget DT node.

2025-04-05 Thread Mattijs Korpershoek
ly the patches. Eugen, This is assigned to me on patchwork: https://patchwork.ozlabs.org/project/uboot/list/?series=450655 Can I pick up all 3 patches or do you prefer to pick up [2/3] and [3/3] ? Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/sam9x60.dtsi | 13 + &

Re: [PATCH v2 1/3] usb: gadget: atmel: Add SAM9X60 support

2025-04-05 Thread Mattijs Korpershoek
add compatible "microchip,sam9x60-udc". > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > arch/arm/mach-at91/include/mach/atmel_usba_udc.h | 2 +- > drivers/usb/gadget/atmel_usba_udc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-)

Re: usb:composite: data abort on second ums launch

2025-04-05 Thread Mattijs Korpershoek
Hi Zixun, On lun., mars 24, 2025 at 18:33, Zixun LI wrote: > On Mon, Mar 24, 2025 at 6:21 PM Mattijs Korpershoek > wrote: >> I've tried to reproduce this on master (2025.04-rc4-g244e61fbb7f5) and I >> don't reproduce this with the VIM3 board using >>

Re: Rate of innovation in the project (Was: Re: Rate of change in the project)

2025-04-05 Thread Mattijs Korpershoek
On mar., avril 01, 2025 at 11:18, Tom Rini wrote: > On Wed, Apr 02, 2025 at 04:45:37AM +1300, Simon Glass wrote: >> Hi Tom, >> >> On Tue, 1 Apr 2025 at 04:51, Tom Rini wrote: >> > >> > On Fri, Mar 28, 2025 at 11:42:20PM +, Simon Glass wrote: >> > > Hi Tom, >> > > >> > > On Mon, 10 Mar 2025

Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool

2025-04-05 Thread Mattijs Korpershoek
t-in endpoint. > > Fixes: 1918b8010c32 ("usb: dwc3: gadget: Convert epautoconf workaround to > match_ep callback") > Signed-off-by: Marek Vasut > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Marek Vasut > Cc: Mattijs Korpershoek > C

[PATCH 2/4] usb: gadget: f_mass_storage: Drop invalid kfree() in fsg_common_release()

2025-03-28 Thread Mattijs Korpershoek
free. The memory from common->luns will be reclaimed when we kfree(common) later in fgs_common_release(). Reported-by: Zixun LI Signed-off-by: Mattijs Korpershoek --- drivers/usb/gadget/f_mass_storage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/f_mass_

[PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices

2025-03-28 Thread Mattijs Korpershoek
handling and freeing the buffers in the unbind callback. [1] https://lore.kernel.org/r/all/CA+GyqebHib_N7szGKkR0Ejac1rmoDQp+0a8t7ROng=pe3g9...@mail.gmail.com/ Signed-off-by: Mattijs Korpershoek --- This should go into next since it's not an urgent fix. --- --- Mattijs Korpershoek (4):

[PATCH 3/4] usb: gadget: f_mass_storage: Fix NULL dereference in fsg_add()

2025-03-28 Thread Mattijs Korpershoek
-off-by: Mattijs Korpershoek --- drivers/usb/gadget/f_mass_storage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index 6f464185bd39..fcce6d12f56b 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb

[PATCH 4/4] usb: gadget: f_mass_storage: Fix memory leak of fsg buffers

2025-03-28 Thread Mattijs Korpershoek
mmon_release() in fsg_unbind(). Reported-by: Zixun LI Signed-off-by: Mattijs Korpershoek --- drivers/usb/gadget/f_mass_storage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index fcce6d12f56b..71dc58da3f03 100644 -

Re: usb:composite: data abort on second ums launch

2025-03-28 Thread Mattijs Korpershoek
Hi Zixun, On jeu., mars 27, 2025 at 14:46, Mattijs Korpershoek wrote: > Hi Zixun, Marek, > > On lun., mars 24, 2025 at 18:40, Mattijs Korpershoek > wrote: > >> Hi Zixun, >> >> On lun., mars 24, 2025 at 18:33, Zixun LI wrote: >> >> resetting ...

[PATCH 1/4] usb: gadget: f_mass_storage: Remove kref structure use

2025-03-28 Thread Mattijs Korpershoek
The kref structure is locally to f_mass_storage and is not used anywhere beside in fsg_common_release(). Remove it and use struct fsg_common* instead. No functional change. Signed-off-by: Mattijs Korpershoek --- drivers/usb/gadget/f_mass_storage.c | 13 +++-- 1 file changed, 3

[GIT PULL] Please pull u-boot-dfu-20250410 into master

2025-04-10 Thread Mattijs Korpershoek
Gary Bisson (1): bootstd: android: avoid possible null pointer dereference Marek Vasut (1): usb: dwc3: gadget: Fix excepts/expects typo Mattijs Korpershoek (4): usb: gadget: f_mass_storage: Remove kref structure use usb

Re: [PATCH 1/3] usb: gadget: f_acm: Claim requested USB endpoints

2025-04-10 Thread Mattijs Korpershoek
ivers. > > Fixes: fc2b399ac03b ("usb: gadget: Add CDC ACM function") > Signed-off-by: Stephan Gerhold Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/f_acm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers

Re: [PATCH 5/7] binman: Workaround lz4 cli padding in test cases

2025-04-10 Thread Mattijs Korpershoek
h solves: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/38 Tested-by: Mattijs Korpershoek > --- > > tools/binman/ftest.py | 7 +-- > tools/binman/test/184_compress_section_size.dts | 1 + > 2 files changed, 6 insertions(+), 2 deletions(-)

Re: [PATCH 2/3] usb: gadget: f_acm: Allow restarting ACM console after stopping it

2025-04-10 Thread Mattijs Korpershoek
to make sure a start operation after a stop > operation registers the gadget again. > > Fixes: fc2b399ac03b ("usb: gadget: Add CDC ACM function") > Signed-off-by: Stephan Gerhold Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/f_acm.c | 1 + > 1 file changed

Re: [PATCH 3/3] usb: gadget: introduce 'enabled' flag in struct usb_ep

2025-04-10 Thread Mattijs Korpershoek
roducing crashes when adapting new > gadget drivers from Linux. > > Signed-off-by: Stephan Gerhold Reviewed-by: Mattijs Korpershoek > --- > include/linux/usb/gadget.h | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-)

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-04-10 Thread Mattijs Korpershoek
Hi, On Wed, 12 Mar 2025 08:36:55 +0100, Michael Walle wrote: > Fastboot works either over TCP, UDP or USB. The latter doesn't have > anything to do with networking, thus should work just fine with > regardless which network stack is selected. In practice, header symbols > are used inside common co

Re: [PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices

2025-04-10 Thread Mattijs Korpershoek
Hi, On Fri, 28 Mar 2025 09:15:40 +0100, Mattijs Korpershoek wrote: > Zixun has reported an odd problem in [1]. > > He encountered a data abort on the 2nd "ums 0 mmc 0" command with > sam9x60-curiosity board: > > U-Boot> ums 0 mmc 0 > UMS: LUN 0, dev mmc 0, hwp

Re: [PATCH] bootstd: android: avoid possible null pointer dereference

2025-04-10 Thread Mattijs Korpershoek
Hi, On Wed, 02 Apr 2025 16:42:19 +0200, Gary Bisson wrote: > - avb_slot_verify_data_free() doesn't check its data parameter > - out_data can be null if avb_slot_verify() fails to allocate memory > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] boot

Re: [PATCH] usb: dwc3: gadget: Fix excepts/expects typo

2025-04-10 Thread Mattijs Korpershoek
Hi, On Mon, 24 Mar 2025 15:39:43 +0100, Marek Vasut wrote: > Fix the excepts typo to expects , no functional change. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] usb: dwc3: gadget: Fix excepts/expects typo https://source.denx.de/u-boot/c

Re: (subset) [PATCH v2 1/3] usb: gadget: atmel: Add SAM9X60 support

2025-04-10 Thread Mattijs Korpershoek
Hi, On Mon, 31 Mar 2025 18:26:07 +0200, Zixun LI wrote: > Compared to SAM9X5 the only difference is the DPRAM memory from the > USB High Speed Device Port (UDPHS) hardware block was increased, > so we can reuse the same endpoint data. > > Also add compatible "microchip,sam9x60-udc". > > > [...]

[PATCH] MAINTAINERS: Update email of Mattijs Korpershoek

2025-03-28 Thread Mattijs Korpershoek
My preferred email address is mkorpersh...@kernel.org now. This updates the MAINTAINERS files and adds an entry in the .mailmap file. Signed-off-by: Mattijs Korpershoek --- .mailmap| 1 + MAINTAINERS | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.mailmap

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-28 Thread Mattijs Korpershoek
n keeping the #if and not >> > keeping it, please ignore this comment. >> >> No, because net_loop(), net_set_state() and NETLOOP_SUCCESS is only >> defined in net-legacy.h. Thus we need this ifdeffery.. Unless of >> course, we add the enums and function stubs to the new

Re: [PATCH v2 2/3] ARM: dts: sam9x60: Add USB gadget DT node.

2025-04-01 Thread Mattijs Korpershoek
On mar., avril 01, 2025 at 13:40, Eugen Hristev wrote: > On 4/1/25 13:10, Mattijs Korpershoek wrote: >> Hi Zixun, >> >> Thank you for the patch. >> >> On lun., mars 31, 2025 at 18:26, Zixun LI wrote: >> >>> Add the USB gadget DT node for th

[GIT PULL] Please pull u-boot-dfu-next-20250310

2025-03-15 Thread Mattijs Korpershoek
Hi Tom, Please find the following developments/cleanups for next: Usb gadget: - Remove legacy CONFIG_USB_DEVICE - Remove legacy usbtty driver CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/25060 Thanks, Mattijs The following changes since commit 743c15b9fdd2f639012a2

[PATCH] tools/make_pip: Use virtualenv when invoking pip

2025-04-09 Thread Mattijs Korpershoek
ipt. Note: This has been reported on [1] [1] https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/37 Signed-off-by: Mattijs Korpershoek --- This has been tested in docker on ubuntu:24.04 after running: $ apt install python3 python3-virtualenv with: $ ./scripts/make_pip.sh u_boot_pylib "

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-17 Thread Mattijs Korpershoek
B:0; And after rebooting the board, we are on the newly flashed bootloader. So, to me: Tested-by: Mattijs Korpershoek I do need some more time to review, though. Thank you for your patience! > --- > Changes in v2: > - Dropped applied virtio erase patch > - Reorganize patches, intro

Re: [PATCH] tools/make_pip: Use virtualenv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
On mer., avril 16, 2025 at 10:25, Mattijs Korpershoek wrote: > Hi Tom, > > On mar., avril 15, 2025 at 11:59, Tom Rini wrote: > >> On Wed, Apr 09, 2025 at 09:46:34AM +0200, Mattijs Korpershoek wrote: >> >>> Recent Ubuntu versions (24.04+) disallow pip by def

[PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
pip script. Note: This has been reported on [1] [1] https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/37 Signed-off-by: Mattijs Korpershoek --- This has been tested in docker on ubuntu:24.04 after running: $ apt install python3 python3-venv with: $ ./scripts/make_pip.sh u_boot_pylib

Re: [PATCH] cmd: Kconfig: Fix typos

2025-04-22 Thread Mattijs Korpershoek
Hi Aristo, Thank you for the patch. On dim., avril 20, 2025 at 16:12, Aristo Chen wrote: > fix the following typos > - from "categorys" to "categories" > - from "indivdually" to "individually" > > Signed-off-by: Aristo Chen Reviewed-by:

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On mer., avril 09, 2025 at 09:58, neil.armstr...@linaro.org wrote: > From: Dmitrii Merkurev > > Introduce fastboot block flashing functions and helpers > to be shared with the MMC implementation. > > The write logic comes from the mmc implementation, while > th

Re: Maintenance of Python tools

2025-04-23 Thread Mattijs Korpershoek
Hi Simon, On mar., avril 22, 2025 at 17:39, Simon Glass wrote: > Hi, > > Tom has indicated that he would like Patman to move out of his tree. I > suggested on another thread[1] that I maintain it in my 'sjg' tree, so > here is a new thread to discuss this. > > I have already done this for the qe

Re: [PATCH 0/3] usb: gadget: Fix issues when using f_acm with ci_udc

2025-04-23 Thread Mattijs Korpershoek
Hi, On Mon, 07 Apr 2025 16:59:34 +0200, Stephan Gerhold wrote: > The ACM console does not work properly with ci_udc, it crashes immediately > when setting it up, because usb_ep_disable() is called on an USB endpoint > that was never enabled before. There are also some other issues in f_acm > where

Re: (subset) [PATCH 0/5] fix dfu alt buffer clearing

2025-04-23 Thread Mattijs Korpershoek
Hi, On Mon, 07 Apr 2025 19:05:24 +0200, Vincent Stehlé wrote: > This patch series applies the same fix in five different locations (the > detailed description of the fix is in the patches). > > I did validate statically by looking at the assembly before/after for all > five cases, using the follo

[GIT PULL] Please pull u-boot-dfu-20250424 into master

2025-04-24 Thread Mattijs Korpershoek
Hi Tom, Please find the following fixes/developments for master: Usb gadget: - Fix ACM gadget release - Allow ACM gadget restart after releasing it - Add 'enabled' flag to usb_ep structure DFU: - Fix alt buffer clearing for DeveloperBox board CI Job: - https://source.denx.de/u-boot/custodians/u

Re: Maintenance of Python tools

2025-04-23 Thread Mattijs Korpershoek
Hi Simon, On mer., avril 23, 2025 at 06:28, Simon Glass wrote: > Hi Mattijs, > > On Wed, 23 Apr 2025 at 01:07, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On mar., avril 22, 2025 at 17:39, Simon Glass wrote: >> >> > Hi, >> >

Re: [PATCH v2 1/1] bootm: improve error message when gzip decompression buffer is too small

2025-04-30 Thread Mattijs Korpershoek
return code from zunzip() instead of overwriting > it with -1 > > By providing clearer hints when decompression fails due to insufficient > buffer size, this change helps users diagnose and fix boot failures more > easily. > > Signed-off-by: Aristo Chen Reviewed-by: M

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

2025-04-30 Thread Mattijs Korpershoek
the default for BOOTSTAGE_RECORD_COUNT to 50. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > boot/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/Kconfig b/boot/Kconfig > index fb37d912bc9..2456856a572 100644 &g

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-30 Thread Mattijs Korpershoek
Hi George, On mer., avril 30, 2025 at 11:58, george chan wrote: > Hi Mattijs, > CC: Casey, > > Thx for your reply. > > > 在 2025年4月29日週二 16:30,Mattijs Korpershoek 寫道: > >> Hi George, >> >> Thank you for contributing. >> >> On lun., av

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
On mer., avril 16, 2025 at 16:26, Quentin Schulz wrote: > Hi Mattijs, > > On 4/16/25 4:21 PM, Mattijs Korpershoek wrote: >> Hi Quentin, >> >> Thank you for the review. >> >> On mer., avril 16, 2025 at 14:47, Quentin Schulz >> wrote: >>

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
Hi Quentin, Thank you for the review. On mer., avril 16, 2025 at 14:47, Quentin Schulz wrote: > Hi Mattijs, > > On 4/16/25 2:36 PM, Mattijs Korpershoek wrote: >> Recent Ubuntu versions (24.04+) disallow pip by default when >> installing packages. The recommended approac

Re: [PATCH 1/5] fwu: developerbox: fix dfu alt buffer clearing

2025-04-14 Thread Mattijs Korpershoek
instead. > > Fixes: 6b403ca4dcf4 ("fwu: DeveloperBox: add support for FWU") > Signed-off-by: Vincent Stehlé > Cc: Masahisa Kojima > Cc: Tom Rini > Cc: Jassi Brar Reviewed-by: Mattijs Korpershoek > --- > board/socionext/developerbox/fwu_plat.c | 2 +

Re: [PATCH 2/5] board: st: common: fix dfu alt buffer clearing

2025-04-14 Thread Mattijs Korpershoek
' instead. > > Fixes: ec2933e543df ("board: stm32mp1: move set_dfu_alt_info in st common > directory") > Signed-off-by: Vincent Stehlé > Cc: Patrick Delaunay > Cc: Patrice Chotard > Cc: Tom Rini > Cc: Marek Vasut Reviewed-by: Mattijs Korpershoek > ---

Re: [PATCH 2/5] board: st: common: fix dfu alt buffer clearing

2025-04-14 Thread Mattijs Korpershoek
On lun., avril 14, 2025 at 14:24, Mattijs Korpershoek wrote: > Hi Vincent, > > Thank you for the patch. > > On lun., avril 07, 2025 at 19:05, Vincent Stehlé > wrote: > >> The set_dfu_alt_info() function calls the ALLOC_CACHE_ALIGN_BUFFER() >> macro to decl

Re: [PATCH RFT v2 0/3] fastboot: add support for generic block flashing

2025-04-14 Thread Mattijs Korpershoek
Hey Neil, On lun., avril 14, 2025 at 11:13, Neil Armstrong wrote: > Hi Mattijs, > > On 09/04/2025 09:58, neil.armstr...@linaro.org wrote: >> This serie permits using any block device as target >> for fastboot by moving the generic block logic into >> a common set of helpers and also use them as

Re: [PATCH] tools/make_pip: Use virtualenv when invoking pip

2025-04-16 Thread Mattijs Korpershoek
Hi Tom, On mar., avril 15, 2025 at 11:59, Tom Rini wrote: > On Wed, Apr 09, 2025 at 09:46:34AM +0200, Mattijs Korpershoek wrote: > >> Recent Ubuntu versions (24.04+) disallow pip by default when >> installing packages. The recommended approach is to use a virtualenv >>

Re: [PATCH 1/1] doc: u-boot-test-reset: mention power cycling

2025-05-05 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for the patch. On sam., mai 03, 2025 at 12:12, Heinrich Schuchardt wrote: > Using power cycling is a valid option to implement u-boot-test-reset. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > doc/develop/py_testing.r

Re: [PATCH 1/1] doc: describe u-boot-test-release

2025-05-05 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for the patch. On sam., mai 03, 2025 at 12:14, Heinrich Schuchardt wrote: > The scripts u-boot-test-release is called at the end of testing. > Describe it. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > doc/deve

Re: [PATCH] configs: phycore_am62x_a53_defconfig: Remove CONFIG_SYS_BOOTM_LEN

2025-04-29 Thread Mattijs Korpershoek
e A53 defconfig and use the correct > default config. > > Signed-off-by: Daniel Schultz Reviewed-by: Mattijs Korpershoek > --- > configs/phycore_am62x_a53_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/phycore_am62x_a53_defconfig > b/c

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
On mar., avril 29, 2025 at 11:45, Dmitrii Merkurev wrote: >> >> Dmitrii, are you okay to re-licence this code under GPL v2 (which is >> common licence for this project) >> > > Yes, I'm ok with that. Fantastic, thanks a lot for answering so quickly!

Re: [PATCH RFT v2 1/3] fastboot: blk: introduce fastboot block flashing support

2025-04-29 Thread Mattijs Korpershoek
On mer., avril 23, 2025 at 09:38, Neil Armstrong wrote: > Hi, > > On 22/04/2025 15:17, Mattijs Korpershoek wrote: >> Hi Neil, >> >> Thank you for the patch. > > Thx for the review > >> >> On mer., avril 09, 2025 at 09:58, neil.armstr...@

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-29 Thread Mattijs Korpershoek
Hi George, Thank you for contributing. On lun., avril 28, 2025 at 15:53, Casey Connolly wrote: > Hi George, > > Thanks a lot for the series, it's super exciting to see support for > booting Android on top of U-Boot :D > > On 4/27/25 13:25, George Chan via B4 Relay wrote: >> This is a series o

Re: [PATCH 2/2] usb: gadget: Remove the legacy usbtty driver

2025-02-28 Thread Mattijs Korpershoek
Hi Tom, Thank you for the patch. On jeu., févr. 27, 2025 at 14:51, Tom Rini wrote: > The lone user of this driver has been removed for some time. Remove this > driver as well. > > Signed-off-by: Tom Rini > --- > Cc: Marek Vasut > Cc: Mattijs Korpershoek &g

Re: [PATCH 1/2] usb: gadget: Remove final remnants of CONFIG_USB_DEVICE

2025-03-10 Thread Mattijs Korpershoek
Hi, On Thu, 27 Feb 2025 14:51:00 -0600, Tom Rini wrote: > The lone user of the legacy USB device framework have been removed for > some time. Remove the final parts of the code that were missed. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu-next) [1/2]

Re: [PATCH 1/2] usb: gadget: Remove final remnants of CONFIG_USB_DEVICE

2025-02-28 Thread Mattijs Korpershoek
> drivers/usb/gadget/ep0.c | 619 - > lib/efi_loader/efi_boottime.c | 2 - > 7 files changed, 1255 deletions(-) > delete mode 100644 drivers/usb/gadget/core.c > delete mode 100644 drivers/usb/gadget/ep0.c I'm always happy to see dead code go. Thanks for doing this! Reviewed-by: Mattijs Korpershoek > [...]

[PATCH v2] usb: dwc3: am62: Use UCLASS_NOP for glue driver

2025-02-28 Thread Mattijs Korpershoek
. Use UCLASS_NOP instead as done in the dwc3-generic-wrapper. Reviewed-by: Siddharth Vadapalli Signed-off-by: Mattijs Korpershoek --- This is a small cleanup intended for next. This has been tested on AM62X SK EVM using: => fastboot usb 0 $ fastboot devices Android Fastb

Re: [PATCH] usb: dwc3: am62: Use UCLASS_NOP for glue driver

2025-02-27 Thread Mattijs Korpershoek
Hi Siddharth, Thank you for the the review. On jeu., févr. 27, 2025 at 13:44, Siddharth Vadapalli wrote: > On Wed, Feb 26, 2025 at 03:47:11PM +0100, Mattijs Korpershoek wrote: > > Hello Mattijs, > >> The dwc3 driver allows SoC-specific configuration via the dwc3_glu

Re: [PATCH v3 1/3] xilinx: dfu: Fill directly update_info.dfu_string

2025-02-14 Thread Mattijs Korpershoek
ate when switch is done. > > Signed-off-by: Michal Simek Reviewed-by: Mattijs Korpershoek > --- > board/xilinx/versal/board.c | 3 +++ > board/xilinx/zynq/board.c| 3 +++ > board/xilinx/zynqmp/zynqmp.c | 3 +++ > 3 files changed, 9 insertions(+) >

Re: [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-14 Thread Mattijs Korpershoek
dfu_alt_info environment variable as part of the EFI capsule update > operation. > > The fix is fully implemented in a subsequent patch that removes the capsule > update dfu_alt_info support in set_dfu_alt_info(). > > Signed-off-by: Jonathan Humphreys Reviewed-by: Mattijs Korpershoek > ---

[PATCH] usb: dwc3: am62: Use UCLASS_NOP for glue driver

2025-02-26 Thread Mattijs Korpershoek
as done in the dwc3-generic-wrapper. Signed-off-by: Mattijs Korpershoek --- This is a small cleanup intended for next. This has been tested on AM62X SK EVM using: => fastboot usb 0 $ fastboot devices Android Fastboot --- drivers/usb/dwc3/dwc3-am62.c | 2 +- 1 file changed, 1 in

Re: [PATCH v3 2/2] env: mmc: Clean up env_mmc_load() ifdeffery

2025-02-25 Thread Mattijs Korpershoek
tation to use of > if (IS_ENABLED(...)). As a result, drop __maybe_unused from > mmc_env_is_redundant_in_both_boot_hwparts(). > > Signed-off-by: Marek Vasut Nice cleanup! Reviewed-by: Mattijs Korpershoek > ---

Re: [PATCH v3 1/2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties

2025-02-25 Thread Mattijs Korpershoek
does > mmc_offset(mmc, 0) == mmc_offset(mmc, 1). If OF_CONTROL is not > in use, this gets optimized back to original macro compare, but > if OF_CONTROL is in use, this also takes into account the DT > properties u-boot,mmc-env-offset and u-boot,mmc-env-offset-redundant. > > Signed-

Re: [PATCH] usb: dwc3: am62: Use UCLASS_NOP for glue driver

2025-02-27 Thread Mattijs Korpershoek
On jeu., févr. 27, 2025 at 15:55, Siddharth Vadapalli wrote: [...] >> I can't write that down, because that's not true. Some glue drivers (like >> dwc3-meson-g12a) need to be SIMPLE_BUS because they rely on >> .child_pre_probe() and .child_post_remove(). > > Understood. Thank you for clarifying

Re: [PATCH 03/18] gadget: f_thor: annotate switch/case fallthrough

2025-03-31 Thread Mattijs Korpershoek
nds still print an error > message. > > Annotate the switch/case fallthrough in this case, to make this clear to > the compiler. > > Signed-off-by: Andre Przywara Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/f_thor.c | 1 + > 1 file changed, 1 inser

Re: [PATCH 1/3] configs: phycore_am64x_a53_defconfig: Enable remoteproc cmd

2025-03-31 Thread Mattijs Korpershoek
ch as M4 or R5 cores > in the AM64x soc. > > Signed-off-by: Daniel Schultz Reviewed-by: Mattijs Korpershoek > --- > configs/phycore_am64x_a53_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/phycore_am64x_a53_defconfig > b/configs/phycore_

Re: [PATCH 2/3] configs: phycore_am62x_a53_defconfig: Enable remoteproc cmd

2025-03-31 Thread Mattijs Korpershoek
h as the M4 core > in the AM62x soc. > > Signed-off-by: Daniel Schultz Reviewed-by: Mattijs Korpershoek > --- > configs/phycore_am62x_a53_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/phycore_am62x_a53_defconfig > b/configs/phycore_am62x_a

Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support

2025-03-31 Thread Mattijs Korpershoek
Hi Eugen, On lun., mars 31, 2025 at 12:26, Eugen Hristev wrote: > On 3/31/25 12:05, Mattijs Korpershoek wrote: >> Hi Eugen, Zixun, >> >> On lun., mars 24, 2025 at 11:23, Eugen Hristev >> wrote: >> >>> On 3/22/25 22:56, Zixun LI wrote: >>>

[GIT PULL] Please pull u-boot-dfu-20250321

2025-03-28 Thread Mattijs Korpershoek
Hi Tom, Please find the following fix for master: Usb gadget: - Fix NXP UUU tool compatibility regression with dwc3 gadget CI Job: - https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/25275 Thanks, Mattijs The following changes since commit 7ad543619463e8817b3044041ac74749a217bbe0

Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support

2025-03-31 Thread Mattijs Korpershoek
Hi Eugen, Zixun, On lun., mars 24, 2025 at 11:23, Eugen Hristev wrote: > On 3/22/25 22:56, Zixun LI wrote: >> Add compatible "microchip,sam9x60-udc" and device tree binding. >> Compared to SAM9X5 the only difference is the DPRAM memory from the >> USB High Speed Device Port (UDPHS) hardware bloc

Re: [PATCH] bootstd: android: avoid possible null pointer dereference

2025-04-03 Thread Mattijs Korpershoek
Hi Gary, Thank you for the patch. On mer., avril 02, 2025 at 16:42, Gary Bisson wrote: > - avb_slot_verify_data_free() doesn't check its data parameter > - out_data can be null if avb_slot_verify() fails to allocate memory > > Signed-off-by: Gary Bisson Reviewed-by: Ma

Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool

2025-03-24 Thread Mattijs Korpershoek
Hi Francesco, On lun., mars 24, 2025 at 09:03, Francesco Dolcini wrote: > Hello Mattijs, Marek > > On Thu, Mar 20, 2025 at 10:47:02AM +0100, Mattijs Korpershoek wrote: >> On mer., mars 19, 2025 at 23:07, Marek Vasut wrote: >> >> > The UUU tool excepts the int

Re: [PATCH 0/4] usb: gadget: f_mass_storage: Fix crashes on low memory devices

2025-03-29 Thread Mattijs Korpershoek
Hi Zixun, On ven., mars 28, 2025 at 18:38, Zixun LI wrote: > On Fri, Mar 28, 2025 at 9:15 AM Mattijs Korpershoek > wrote: >> This series fixes the above mentioned crash by introducing proper error >> handling and freeing the buffers in the unbind callback. > > Hi Mattij

Re: [ANN] U-Boot v2025.04-rc5 released

2025-03-25 Thread Mattijs Korpershoek
Hi Tom, On lun., mars 24, 2025 at 20:01, Tom Rini wrote: > Hey all, > > So it's release day and I have tagged and pushed things out. This will > be merged to -next shortly. > > One thing to note is that just today a bug was reported due to a missing > 'fallthrough;' line and in turn we need to f

Re: usb:composite: data abort on second ums launch

2025-03-27 Thread Mattijs Korpershoek
Hi Zixun, Marek, On lun., mars 24, 2025 at 18:40, Mattijs Korpershoek wrote: > Hi Zixun, > > On lun., mars 24, 2025 at 18:33, Zixun LI wrote: > > resetting ... [...] > >> >> Each time when ums is called 2*FSG_BUFLEN, 256kB buffer is allocated &

Re: [PATCH v4 12/14] cmd: add spawn and wait commands

2025-04-04 Thread Mattijs Korpershoek
> + */ Nitpick: Is this the correct copyright? For the test code in the next patch you used * Copyright 2025, Linaro Ltd. Besides that: Reviewed-by: Mattijs Korpershoek [...] > +

<    4   5   6   7   8   9   10   >