Hi Greg,
On ven., avril 19, 2024 at 15:21, Greg Malysa wrote:
> Hi Mattijs,
>
>> Please avoid top-posting when replying, it makes following the
>> discussion more difficult:
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discuss
>gadget, 1);
>> @@ -2383,6 +2386,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget
>> *gadget)
>>
>> /* disable interrupt for device */
>> writel(0, &priv_dev->regs->usb_ien);
>> +writel(0, &priv_dev->regs->usb_pwr);
>> writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
>>
>> return ret;
>>
>> base-commit: bc39e06778168a34bb4e0a34fbee4edbde4414d8
>
> Since this is gadget stuff, +CC Mattijs , that should go through their tree.
>
> Thanks!
Thank you Marek for CC'ing me, I missed this patch.
Reviewed-by: Mattijs Korpershoek
Hi,
On Wed, 24 Apr 2024 13:09:11 +0530, Ravi Gunasekaran wrote:
> When the device port is in a low power state [U3/L2/Not Connected],
> accesses to usb device registers may take a long time. This could lead to
> potential core hang when the controller registers are accessed after the
> port is dis
Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/dwc3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index c0c8c16fd9c2..8a70bc682322 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/dr
; Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/gadget/f_acm.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c
> index de42e0189e8d..ba216128ab27 100644
> ---
Hi Caleb,
Thank you for the patch.
On mer., janv. 31, 2024 at 14:57, Caleb Connolly
wrote:
> UFS storage often uses a 4096-byte sector size, add support for dynamic
> sector sizes based loosely on the Linux implementation.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs
Hi Caleb,
Thank you for the patch.
On mer., janv. 31, 2024 at 14:57, Caleb Connolly
wrote:
> The priv struct was wrong in dump_boot_mappings(). Causing errors when
> compiling with -DDEBUG. Fix this.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
&
>
> Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
> Reported-by: Dan Carpenter
> Link:
> https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/
> Signed-off-by: Sean Anderson
Reviewed-by: Mattijs Korpershoek
> ---
Hi Caleb,
On Thu, Feb 01, 2024 at 14:24, Caleb Connolly wrote:
> On 01/02/2024 09:34, Mattijs Korpershoek wrote:
>> Hi Caleb,
>>
>> Thank you for the patch.
>>
>> On mer., janv. 31, 2024 at 14:57, Caleb Connolly
>> wrote:
>>
>>> The Q
Hi,
On Thu, 01 Feb 2024 13:18:51 -0500, Sean Anderson wrote:
> The return value of write_sparse_chunk_raw is unsigned, so the existing
> check has no effect. Use IS_ERR_VALUE to detect error instead, which is
> what write_sparse_chunk_raw does itself.
>
>
Thanks, Applied to https://source.denx.
Hi Sjoerd,
Thank you for the patch.
On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote:
> Enable USB host as well as USB gadget and DFU support for a53; For the
> r5 due to the smaller available size create a config fragment for DFU
> supports which disables support for persistent storage to
-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> common/avb_verify.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index 48ba8db51e5..59f2c25e0de 100644
> --- a/common/avb_ver
nd line.
>
> [1] https://www.kernel.org/doc/Documentation/process/license-rules.rst
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Nitpick in the title: itdentifiers -> identifiers.
If no other remarks in the series, will fix when applying.
> ---
&
-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> common/avb_verify.c | 31 ++-
> 1 file changed, 18 insertions(+), 13 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index 938a5383b5d..ed58239cf8a 100644
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Introduce AVB_OPS_CHECK macro for checking AvbOps before using
> it to avoid code duplication.
> Simplify and add more context for prints where it's needed.
>
> Signed-off-by: Igor
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Introduce str_avb_io_error() and str_avb_slot_error() functions,
> that provide a pointer to AVB runtime error message.
>
> Signed-off-by: Igor Opaniuk
Re
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Add info about slot_suffix param for avb verify.
>
> Signed-off-by: Igor Opaniuk
> ---
>
> doc/android/avb2.rst | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig")
Add it back to fix AVB verification on VIM3/VIM3L.
Fixes: 7cfbba36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig")
Co-developed-by: Guillaume La Roque
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
configs/k
setting correct
> androidboot.verifiedbootstate kernel cmdline parameter.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Nitpick: the error handling migration could have been part of PATCH 5/7
but it's fine to keep as is.
> ---
>
> cmd/avb.c | 50 +-
Hi Igor,
On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote:
> Hi everyone,
>
> I'm currently planning a big overhaul of the current implementation of
> AVB/AB in U-Boot during the 2024 year, which I have barely touched since
> 2019. I used to believe that it was stillborn, but looks like it's
additions (AVB, AB) of myself to the MAINTAINERS file
Mattijs Korpershoek (2):
MAINTAINERS: add Mattijs for Android AB
MAINTAINERS: add Mattijs for Android AVB
Sean Anderson (1):
lib: sparse: Fix error checking for
Hi Igor,
On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote:
> Hi Dan,
>
> On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter
> wrote:
>>
>> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote:
>> > From: Igor Opaniuk
>> >
>> > mmc_switch_part() is used for switching between hw partitio
Hi Igor,
Thank you for the patch.
On ven., févr. 09, 2024 at 20:20, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Simplify and add more context for prints where it's needed.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes
Hi Igor,
Thank you for the patch.
On ven., févr. 09, 2024 at 20:20, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Sync usage info with the one cmd/avb.c.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2:
> - Address Matti
Hi Igor,
Thank you for the patch.
On mar., févr. 13, 2024 at 08:36, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Add information about a custodian tree [1] for AVB/AB, which is
> maintained by Mattijs Korpershoek.
>
> [1] https://source.denx.de/u-boot/custodians/u-boot-d
Hi Marek,
Thank you for your review.
On mar., févr. 13, 2024 at 12:55, Marek Vasut wrote:
> On 2/13/24 08:32, Igor Opaniuk wrote:
>> From: Igor Opaniuk
>>
>> Add information about a custodian tree [1] for AVB/AB, which is
>> maintained by Mattijs Ko
Hi Igor,
On mar., févr. 13, 2024 at 12:19, Igor Opaniuk wrote:
> Hi Mattijs,
>
> On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek
> wrote:
>>
>> Hi Igor,
>>
>> On lun., févr. 12, 2024 at 09:05, Igor Opaniuk
>> wrote:
>>
>> > Hi Dan
Hi,
On Tue, 13 Feb 2024 08:36:38 +0100, Igor Opaniuk wrote:
> Add information about a custodian tree [1] for AVB/AB, which is
> maintained by Mattijs Korpershoek.
>
> [1] https://source.denx.de/u-boot/custodians/u-boot-dfu
>
>
Thanks, Applied to https://source.denx.de/u-boot
Hi,
On Fri, 09 Feb 2024 20:20:38 +0100, Igor Opaniuk wrote:
> This is the first patch series for incoming major
> improvements for AVB implementation, that include:
> - Simplify and add more context for debug/error prints where it's needed.
> - Move SPDX license identifiers to the first line, so i
Hi Igor,
On Fri, Feb 09, 2024 at 17:17, Igor Opaniuk wrote:
> Hello Mattijs,
>
> On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek
> wrote:
>>
>> Hi Igor,
>>
>> On ven., févr. 09, 2024 at 11:14, Igor Opaniuk
>> wrote:
>>
>> > Hi eve
Hi Alexey,
Thank you for the patch.
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> Currently, fastboot protocol in U-Boot has no opportunity
> to execute vendor custom code with verifed boot. This patch
> introduce new fastboot subcommand fastboot oem board:,
> which allow to run cu
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> An example of how we use fastboot oeam board subcommand
> for Sean Anderson.
>
> 1 - OEM_BOARD_WRITE_BOOTLOADER_CMD:
>
> We use it for custom Amlogic bootloader + tpl
> flashing protocol.
>
> 2 - OEM_BOARD_ERASE_CMD:
>
> Custom logic for
11 bytes
> => optee_rpmb read_pvalue test_variable 11
> Read 11 bytes, value = test_value
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on sandbox
> ---
>
> cmd/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 del
Hi Tom,
Here are some developments for master including:
- Fix avb_verify command with SD cards
- Add u-boot-dfu maintainer tree for AB/AVB
- Avb: report verified boot state based on lock state
- Misc avb refactors improve code quality
The CI job is at
https://source.denx.de/u-boot/custodians/u
Hi Jonas, thank you for the patch.
On lun., févr. 26, 2024 at 13:36, Jonas Karlman wrote:
> On 2024-02-26 11:18, Marek Vasut wrote:
>> On 2/26/24 10:50 AM, Jonas Karlman wrote:
>>> On 2024-02-26 09:22, Marek Vasut wrote:
On 2/26/24 8:54 AM, Jonas Karlman wrote:
> On 2024-02-26 02:47, To
Android.
[1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards
[2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Mattijs Korpershoek (6):
configs: sei610: fix typo in header comment
configs: meson64_android: fix bad indent in EXTRA_ENV_SETTINGS
s/510/610/
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/sei610.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/sei610.h b/include/configs/sei610.h
index 6d093161c9..9eeffdd72c 100644
--- a/include/configs/sei610
both lines seem to be joined together which is not the case for the
meson64.h EXTRA_ENV_SETTINGS.
Add a newline for consistency.
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
el quite a lot on their
public documentation [1]
Load the boot partition by label instead of by index
[1] https://source.android.com/devices/bootloader/partitions
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 10 ++
1 file changed
To display the bootup logo, we read the gpt and assume that the
partition with index "2" will be the "logo" partition.
This might not always be the case, and it's very error-prone.
Load the logo partition by label instead of by index.
Signed-off-by: Guillaume La Roqu
Right now, when running fastboot we use a hard-coded "0" for the
device number.
Use the Kconfig option named CONFIG_FASTBOOT_USB_DEV instead.
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 4 ++--
1 file changed, 2 insert
e La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index 56545a72f8..3b61d5f703 100644
--- a/include/configs/meson64_andro
son handling to use the BCB, which
is the standard Android way.
[1] https://android.googlesource.com/device/amlogic/yukawa
[2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Mattijs Korpershoek (5):
Revert "ARM: meson: Add support for fastboot_set_rebo
ned-off-by: Mattijs Korpershoek
---
arch/arm/mach-meson/board-common.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/arch/arm/mach-meson/board-common.c
b/arch/arm/mach-meson/board-common.c
index 1690b6b1e6..7ceba7cede 100644
--- a/arch/arm/mach-meson/board-comm
gular recovery mode or
fastbootd mode.
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index ce08346b70..f9f2b26416 100644
--- a/include/co
ng sm calls.
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index 3b61d5f703..d732032d1f 100644
-
SEI-610 and SEI-510 are both for Android boards based on Yukawa[1]
Enable the BCB command to enable the standard Android boot flow.
[1] https://android.googlesource.com/device/amlogic/yukawa/
Signed-off-by: Mattijs Korpershoek
---
configs/sei510_defconfig | 1 +
configs/sei610_defconfig | 1
Right now meson64_android does not know how to boot into Android
Recovery: it simply falls back to "fastboot" mode in the bootloader.
Implement the boot to recovery.
While at it, use the standard BCB way instead of a sm for consistency.
Signed-off-by: Mattijs Korpershoek
---
inclu
ng sm calls.
Signed-off-by: Mattijs Korpershoek
Acked-by: Neil Armstrong
---
include/configs/meson64_android.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index 3b61d5f70
son handling to use the BCB, which
is the standard Android way.
[1] https://android.googlesource.com/device/amlogic/yukawa
[2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Changes in v2:
* re-ordered commits
* added Neil's Acked-by
Mattijs Korpershoek (5):
conf
gular recovery mode or
fastbootd mode.
Signed-off-by: Mattijs Korpershoek
Acked-by: Neil Armstrong
---
include/configs/meson64_android.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index ce08346b70..f9f2b26416 1
ned-off-by: Mattijs Korpershoek
Acked-by: Neil Armstrong
---
arch/arm/mach-meson/board-common.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/arch/arm/mach-meson/board-common.c
b/arch/arm/mach-meson/board-common.c
index 1690b6b1e6..7ceba7cede 100644
--- a/arc
SEI-610 and SEI-510 are both for Android boards based on Yukawa[1]
Enable the BCB command to enable the standard Android boot flow.
[1] https://android.googlesource.com/device/amlogic/yukawa/
Signed-off-by: Mattijs Korpershoek
Acked-by: Neil Armstrong
---
configs/sei510_defconfig | 1
Right now meson64_android does not know how to boot into Android
Recovery: it simply falls back to "fastboot" mode in the bootloader.
Implement the boot to recovery.
While at it, use the standard BCB way instead of a sm for consistency.
Signed-off-by: Mattijs Korpershoek
Acke
Hi Neil,
Neil Armstrong writes:
> On 30/07/2021 10:55, Mattijs Korpershoek wrote:
>> The SEI-610 and SEI-510 boards are well supported in the
>> Android Open Source project via the yukawa [1] platform.
>>
>> Their U-Boot version, despite being public [2] is not in m
On Mon, Jul 04, 2022 at 16:10, "Neil Armstrong" wrote:
> This is a preliminary documentation introducing different
> boot sequences, and notably the recovery mode.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Mattijs Korpershoek
> ---
> doc/board
neric fastboot_set_reboot_flag")
because "fastboot reboot bootloader" will access the "misc" partition.
Signed-off-by: Mattijs Korpershoek
---
This fix has been used for over a year in the AOSP tree at [1]
[1]
https://android.googlesource.com/device/amlogic/yukawa/+/c
Hi Alistair,
Thank you for your patch.
On lun., sept. 26, 2022 at 22:02, Alistair Delva wrote:
> From: Jiyong Park
>
> Previously Android AVB supported block devices only on eMMC. This change
> eliminates the restriction by using the generic block driver model.
>
> The `avb init' command is mo
Hi Sean,
Thank you for your review.
On Mon, Oct 10, 2022 at 11:38, Sean Anderson wrote:
> On 10/10/22 4:05 AM, Mattijs Korpershoek wrote:
>> Before erasing (or flashing) an mmc hardware partition, such as
>> mmc0boot0 or mmc0boot1, we select it using blk_dselect_hwpart().
>
On Tue, Oct 11, 2022 at 17:39, Marek Vasut wrote:
> On 10/11/22 09:12, neil.armstr...@linaro.org wrote:
>> On 10/10/2022 19:16, Marek Vasut wrote:
>>> On 10/10/22 18:22, Neil Armstrong wrote:
>>>> Hi,
>>>
>>> Hi,
>>>
>>>> On
On mar., oct. 11, 2022 at 13:40, Alistair Delva wrote:
> On Mon, Oct 10, 2022 at 7:53 AM Mattijs Korpershoek
> wrote:
>>
>> Hi Alistair,
>>
>> Thank you for your patch.
>>
>> On lun., sept. 26, 2022 at 22:02, Alistair Delva wrote:
>>
>>
On Tue, Oct 11, 2022 at 11:52, Sean Anderson wrote:
> On 10/11/22 8:07 AM, Mattijs Korpershoek wrote:
>> Hi Sean,
>>
>> Thank you for your review.
>>
>> On Mon, Oct 10, 2022 at 11:38, Sean Anderson wrote:
>>
>>> On 10/10/22 4:05 AM, Mattijs Kor
Error: mmc 2:misc read failed (-2)
Add a fail-safe in __bcb_load() to ensure we will always read from the
user(0) hwpartition.
This fixes the following fastboot sequence:
$ fastboot erase mmc2boot1# switch to hwpart1
$ fastboot reboot bootloader # switch to hwpart0, then reads GPT
Signed-off-
In some cases, the param variable is wrong, and in other cases we have
undocumented arguments.
Fix the docs.
Signed-off-by: Mattijs Korpershoek
---
---
include/blk.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/blk.h b/include/blk.h
index 8806c382d4e7
On ven., oct. 14, 2022 at 09:55, Simon Glass wrote:
> Hi Mattijs,
>
> On Thu, 13 Oct 2022 at 06:57, Mattijs Korpershoek
> wrote:
>>
>> In some cases, the param variable is wrong, and in other cases we have
>> undocumented arguments.
>>
>> Fix the docs
In some cases, the param variable is wrong, and in other cases we have
undocumented arguments.
Fix the docs.
Signed-off-by: Mattijs Korpershoek
---
Changes in v2:
* Don't edit blk_foreach_probe() comment as it's just returing (Simon)
* Link to v1:
https://lore.kernel.org/r/202210
On Mon, Jan 30, 2023 at 07:41, Simon Glass wrote:
> This converts 3 usages of this option to the non-SPL form, since there is
> no SPL_FASTBOOT_FLASH defined in Kconfig
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> drivers/fastboot/fb_get
On Mon, Jan 30, 2023 at 07:42, Simon Glass wrote:
> This converts 5 usages of this option to the non-SPL form, since there is
> no SPL_FASTBOOT_FLASH_MMC defined in Kconfig
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> drivers/fast
On Mon, Jan 30, 2023 at 07:42, Simon Glass wrote:
> This converts 3 usages of this option to the non-SPL form, since there is
> no SPL_FASTBOOT_FLASH_NAND defined in Kconfig
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> drivers/fast
ndr_boot_img_hdr_v3
> andr_vendor_boot_img_hdr_v3_v4 -> andr_vendor_img_hdr
Re-tested the whole series on Khadas vim3l board with boot header v2.
Tested-by: Mattijs Korpershoek
>
> Safae Ouajih (17):
> android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0
>
>
> To maintain support for version v0, v1 and v2 while introducing
> version 3 and 4, this struct name must change to refer to the header
> structure before v3.
>
> Signed-off-by: Safae Ouajih
Reviewed-by: Mattijs Korpershoek
> ---
> boot/image-android.c | 26 +++
ons
>>
>> Signed-off-by: Safae Ouajih
>> ---
>> cmd/abootimg.c | 18 +++---
>> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
ontents(const struct andr_boot_img_hdr_v0 *hdr);
>> bool android_image_print_dtb_contents(ulong hdr_addr);
>> +bool is_android_boot_image_header(const struct andr_boot_img_hdr_v0 *hdr);
>
> Please add a full comment
>
>>
>> /**
>> * board_fit_config_name_match() - Check for a matching board name
>> --
>> 2.34.1
>>
>
> With that:
>
> Reviewed-by: Simon Glass
>
> Regards,
> SImon
Reviewed-by: Mattijs Korpershoek
https://android.googlesource.com/platform/system/tools/mkbootimg
>>
>> Signed-off-by: Safae Ouajih
>> ---
>> include/android_image.h | 183 +++-
>> 1 file changed, 182 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass
>
> You might consider using the sphinx style for struct comments so you
> can include this header file into the docs directly.
Reviewed-by: Mattijs Korpershoek
| 27 +++
>> include/image.h | 2 ++
>> 3 files changed, 103 insertions(+), 1 deletion(-)
>>
>
> Reviewed-by: Simon Glass
>
> But please comment struct andr_image_data.
>
> [..]
Reviewed-by: Mattijs Korpershoek
>
>> diff --
ds,
>> > Simon
>>
>> Hi Simon,
>>
>> Thank you for the review.
>>
>> Content print for boot image header v4 can be supported
>>
>> and only requires updating the existing functions.
>>
>> This is something I intend to support later on.
>
> OK thanks
>
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
r message when v1,v2 header version are not used.
>>
>> Signed-off-by: Safae Ouajih
>> ---
>> boot/image-android.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass
>
> log_err() might be better
>
Reviewed-by: Matt
In version 3 and 4 of boot image header, the vendor specific
>> > vendor-spefcific
>> >
>> >> command line are located in vendor boot image. Thus, using
>> > use the
>> >
>> >> extra command line to add those cmd to bootargs.
nsertions(+), 14 deletions(-)
>>
>
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
>
> nits below
>
>> diff --git a/boot/image-android.c b/boot/image-android.c
>> index cb4fc22b00..edeeaaaee0 100644
>> --- a/boot/image-android.c
>> +++
On Thu, Jan 26, 2023 at 17:55, Simon Glass wrote:
> Hi Safae,
>
> On Thu, 26 Jan 2023 at 09:05, Safae Ouajih wrote:
>>
>> This enables the support for boot image header version 3 and 4
>> using abootimg command.
>>
>> In order to use version 3 or 4:
>>
>> 1- Vendor boot image address should be g
mage-android.c| 58 +++--
>> include/android_image.h | 11
>> 2 files changed, 67 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
>
> nit below
>
> [..]
>
>> diff --git a/in
On lun., févr. 06, 2023 at 00:50, Safae Ouajih wrote:
> Update the Android documentation to describe version 3 and 4 of boot
> image header.
>
> Signed-off-by: Safae Ouajih
> ---
Reviewed-by: Mattijs Korpershoek
> doc/android/boot-image.rst | 13 -
>
;
>
> Here is a link to see the related android boot flow changes on KHADAS vim3l
> as an example:
> https://gitlab.baylibre.com/baylibre/amlogic/atv/u-boot/-/commits/souajih/BootImagev4/
Re-tested the whole series on Khadas vim3l board with boot header v2.
Tested-by: Mattijs Korpershoe
On Mon, Feb 06, 2023 at 00:50, Safae Ouajih wrote:
> Move from andr_boot_img_hdr_v0 to andr_image_data
> structure to prepare for boot image header
> version 3 and 4.
>
> Signed-off-by: Safae Ouajih
> ---
> boot/image-android.c | 121 +++
> cmd/abootimg.c
t;
> Signed-off-by: Safae Ouajih
Reviewed-by: Mattijs Korpershoek
> ---
> boot/bootm.c | 8 +++
> boot/image-android.c | 54
> boot/image-board.c | 3 +--
> boot/image-fdt.c | 3 ++-
> cmd/abootimg.c
t;
> Signed-off-by: Safae Ouajih
Reviewed-by: Mattijs Korpershoek
> ---
> boot/bootm.c | 8 +++
> boot/image-android.c | 54
> boot/image-board.c | 3 +--
> boot/image-fdt.c | 3 ++-
> cmd/abootimg.c
v3_v4_parse_hdr()
> - android_vendor_boot_image_v3_v4_parse_hdr()
>
> Update android_image_get_data() to support v3 and v4
>
> Signed-off-by: Safae Ouajih
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
> boot/image-android.c| 80 +++--
> include/
vendor boot image.
>
> Support the new vendor ramdisk.
>
> Signed-off-by: Safae Ouajih
> Reviewed-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
> boot/image-android.c | 13 +++--
> include/image.h | 4 ++--
> 2 files changed, 13 insertions(+), 4 deletio
es updating vendor boot image and/or generating a new image.
>
> Print an error message when the boot image header version is
> greater than 2.
>
> Signed-off-by: Safae Ouajih
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/fastboot/fb_mmc.c | 8
> 1 file
dor_boot_load_addr
>
> 2- "ramdisk_addr_r" env variable (ramdisk address) should be set to host
> the ramdisk : generic ramdisk + vendor ramdisk
>
> Replace "struct andr_boot_img_hdr_v0*" by "void *" in
> some functions since v3 and v4 are now s
Ctrl-c
Other tests:
* ums 0 mmc 2 # can list / mount partitions from host
* usb start; usb storage # list usb thumb drive
* all defconfigs have been build tested
[1]
https://lore.kernel.org/u-boot/938b9439-9014-5ee8-1627-16af508bf...@linaro.org/
Signed-off-by: Mattijs Korpershoek
---
M
usb" (dwc2) driver is
probed()/removed() instead.
This is achieved via the glue driver, which gets notified each time one
of its children is probed()/removed.
Note: this change should be harmless without DM_USB_GADGET=y
because the amlogic-g12a-usb driver is not probed via driver model.
Signed-
Note: Only configs having both CONFIG_USB_DWC3_MESON_G12A=y *and*
USB_GADGET_DWC2_OTG=y have been updated.
Signed-off-by: Mattijs Korpershoek
---
arch/arm/mach-meson/board-g12a.c | 127 --
configs/bananapi-m5_defconfig | 1 +
configs/beel
On Tue, Oct 11, 2022 at 19:57, neil.armstr...@linaro.org wrote:
> On 11/10/2022 18:36, Mattijs Korpershoek wrote:
>> On Tue, Oct 11, 2022 at 17:39, Marek Vasut wrote:
>>
>>> On 10/11/22 09:12, neil.armstr...@linaro.org wrote:
>>>> On 10/10/2022 19:16, Marek
;
>
> Here is a link to see the related android boot flow changes on KHADAS vim3l
> as an example:
> https://gitlab.baylibre.com/baylibre/amlogic/atv/u-boot/-/commits/souajih/BootImagev4/
Tested the whole series on Khadas vim3l board with boot header v2.
Tested-by: Mat
Permit redefining SYS_MALLOC_LEN for board specific configs.
This is especially useful for Android with AVB, which requires a malloc
length of 128M.
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64.h | 2 ++
1 file changed, 2 insertions(+)
diff
libre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Guillaume La Roque (2):
configs: meson64_android: boot android via abootimg
configs: sei510/610: android bootflow via abootimg
Mattijs Korpershoek (7):
configs: meson64: permit redefining SYS_MALLOC_LEN
configs: meson64_android: inc
To prepare for AVB support, increase SYS_MALLOC_LEN to 128M.
This value has been found by testing the following on khadas vim3l:
=> avb init
=> avb verify
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 4
1 file changed, 4 insertions(+)
diff --git a/i
-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 55 ++-
1 file changed, 47 insertions(+), 8 deletions(-)
diff --git a/include/configs/meson64_android.h
b/include/configs/meson64_android.h
index 48a23b6e41..83fa25bfb1
BOOT_CMD might be different based on CONFIG_CMD_ABOOTIMG.
To prepare for abootimg support, extract the boot command
to a dedicated macro.
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
include/configs/meson64_android.h | 6 --
1 file changed, 4 insertions(+), 2
401 - 500 of 979 matches
Mail list logo
