Hi Igor, On lun., févr. 12, 2024 at 09:05, Igor Opaniuk <igor.opan...@gmail.com> wrote:
> Hi Dan, > > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter <dan.carpen...@linaro.org> > wrote: >> >> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: >> > From: Igor Opaniuk <igor.opan...@gmail.com> >> > >> > mmc_switch_part() is used for switching between hw partitions >> > on eMMC (boot0, boot1, user, rpmb). >> > There is no need to do that for SD card. >> > >> >> Is this a clean up or a bugfix? What are the visible effects for the >> user? > avb cmd fails for SD cards, as mmc_switch_part() fails after trying to access > EXT_CSD register, which obviously is not available. Does this means that we only need this patch to fix AVB commands when booting from SD cards? If yes, I propose adding the following note to the commit message: "This fixes the avb command usage on on SD cards." If you agree, I can do this while applying. If not, we can keep the message as is. >> >> regards, >> dan carpenter >> > > > -- > Best regards - Atentamente - Meilleures salutations > > Igor Opaniuk > > mailto: igor.opan...@gmail.com > skype: igor.opanyuk > http://ua.linkedin.com/in/iopaniuk