Re: [PATCH v1 0/5] Implement fastboot multiresponce

2023-11-09 Thread Mattijs Korpershoek
Hi Svyatoslav, Ion, Thank you for these series. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is obtaine

Re: [PATCH 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-09 Thread Mattijs Korpershoek
rt MMC interface. Extend it to allow various block > device interfaces. > > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen This breaks vim3/vim

Re: [PATCH 2/2] cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-09 Thread Mattijs Korpershoek
> > Co-developed-by: Cody Schuffelen > Signed-off-by: Cody Schuffelen > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen I cou

Re: [PATCH 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-09 Thread Mattijs Korpershoek
On jeu., nov. 09, 2023 at 10:40, Mattijs Korpershoek wrote: > Hi Dmitrii, > > Thank you for your patch. > > Thank you as well for taking the time to upstream things from: > https://android.googlesource.com/platform/external/u-boot/ > > On jeu., nov. 09, 2023 at 00:36, Dm

Re: eMMC broken on SK-AM62

2023-11-09 Thread Mattijs Korpershoek
Hi Maxime, Nishanth, On mer., nov. 08, 2023 at 16:05, Maxime Ripard wrote: > Hi Nishanth, > > I've been trying for the last few days to get an SK-AM62 to boot from > the eMMC user data area. > > I finally got the jumper configuration to make the CPU boot from there > thanks to Mattijs, but it lo

Re: [PATCH v1 0/5] Implement fastboot multiresponce

2023-11-09 Thread Mattijs Korpershoek
Hi Svyatoslav, On jeu., nov. 09, 2023 at 11:01, Svyatoslav Ryhel wrote: > 9 листопада 2023 р. 10:41:30 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, Ion, >> >>Thank you for these series. >> >>On mar., nov. 07, 2023 at 14:42, Svyatoslav R

Re: [PATCH] usb: gadget: f_mass_storage: Stop ums on START-STOP UNIT SCSI command

2023-11-13 Thread Mattijs Korpershoek
Hi, On Tue, 07 Nov 2023 01:09:59 +0100, Marek Vasut wrote: > Exit the UMS handler loop in case START-STOP UNIT SCSI command is > received. This is sent e.g. by the util-linux eject(1) command and > indicates to the device that it is supposed to spin down the media > and enter low power state. > >

Re: [PATCH v2 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-14 Thread Mattijs Korpershoek
Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen I confirm that I can reboot from U-Boot into other modes (like fastbootd) using the default U-boot environment Tested-by: Mattijs Korpershoek

Re: [PATCH 0/2] cmd: bcb: extend BCB APIs to support Android boot flow

2023-11-14 Thread Mattijs Korpershoek
rev wrote: > Following patches introduce various block interfaces support > and extend API of BCB (bootloader control block) to reuse it > for Android boot flow of Cuttlefish virtual device. > > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) &

Re: [PATCH v1 1/5] fastboot: multiresponse support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > From: Ion Agorria > > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required

Re: [PATCH v1 2/5] fastboot: implement "getvar all"

2023-11-14 Thread Mattijs Korpershoek
), uses fastboot multiresponse. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Some small comments below. With those addressed, please add: Reviewed-by: Mattijs Korpershoek > --- > doc/android/fastboot-protocol.rst | 3 ++ > drivers/fastboot/fb_comma

Re: [PATCH v1 5/5] fastboot: add oem console command support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > From: Ion Agorria > > "oem console" serves to read console record buffer. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > --- > doc/android/fastboot.rst | 1 + > driv

Re: [PATCH v1 5/5] fastboot: add oem console command support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, On mar., nov. 14, 2023 at 12:30, Svyatoslav Ryhel wrote: > 14 листопада 2023 р. 12:24:52 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, >> >>Thank you for your patch. >> >>On mar., nov. 07, 2023 at 14:42, Svyatoslav Ry

Re: [PATCH v2 1/2] usb: ci: Fix gadget reinit

2023-11-21 Thread Mattijs Korpershoek
;buffer overflow". > > Fixed by clearing the primed buffers with the `epflush` (`ENDPTFLUSH`) > register. > > Signed-off-by: Simon Holesch > Reviewed-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - use wait_for_bit_le32(), clrbits

Re: [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err

2023-11-21 Thread Mattijs Korpershoek
Hi Simon, Thank you for your patch. On lun., nov. 20, 2023 at 01:08, Simon Holesch wrote: > Add missing newline in pr_err. > > Signed-off-by: Simon Holesch > Reviewed-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - add commit message

Re: [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err

2023-11-21 Thread Mattijs Korpershoek
Hi Marek, On lun., nov. 20, 2023 at 03:07, Marek Vasut wrote: > On 11/20/23 01:08, Simon Holesch wrote: >> Add missing newline in pr_err. >> >> Signed-off-by: Simon Holesch >> Reviewed-by: Marek Vasut >> --- >> >> Changes in v2: >> - add commit message body >> >> Thanks for the review! > >

Re: [PATCH v2 1/2] usb: ci: Fix gadget reinit

2023-11-21 Thread Mattijs Korpershoek
Hi, On Mon, 20 Nov 2023 01:08:34 +0100, Simon Holesch wrote: > The ChipIdea device controller wasn't properly cleaned up when disabled. > So enabling it again left it in a broken state. The problem occurred for > example when the host unbinds the driver and binds it again. > > During the first se

Re: [PATCH v2 1/5] fastboot: multiresponse support

2023-11-21 Thread Mattijs Korpershoek
ll the required data is obtained. This behavior > can be adjusted using multiresponce ability (getting multiple lines > of response) proposed in this patch. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek > --- >

Re: [PATCH v2 3/5] common: console: introduce overflow and isempty calls

2023-11-21 Thread Mattijs Korpershoek
nsole.h @@ -145,6 +145,12 @@ static inline int console_in_puts(const char *str) return 0; } +static inline bool console_record_isempty(void) +{ + /* Always empty */ + return true; +} + With that addressed, please add: Reviewed-by: Mattijs Korpershoek > int console_in_puts

Re: [PATCH v2 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-21 Thread Mattijs Korpershoek
a > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek > --- > boot/bootmeth_extlinux.c | 2 +- > common/console.c | 2 +- > include/membuff.h| 5 +++-- > lib/membuff.c| 4 ++-- > 4 files changed, 7 insertions(+), 6 deletions(-) > >

Re: [PATCH v2 5/5] fastboot: add oem console command support

2023-11-21 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch On mer., nov. 15, 2023 at 17:38, Svyatoslav Ryhel wrote: > From: Ion Agorria > > "oem console" serves to read console record buffer. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattij

Re: [PATCH V2 0/4] arm: dts: k3-am625*: Upgrade kernel dts to v6.7-rc1

2023-11-21 Thread Mattijs Korpershoek
dtsi > arm: dts: k3-am625-beagleplay-u-boot: drop duplicate bootph-nodes > arm: dts: k3-am625-sk-r5/u-boot: Drop duplicate bootph-nodes Boot tested eMMC boot on AM62 SK EVM. For the whole series: Tested-by: Mattijs Korpershoek # am625 sk > > arch/arm/dts/k3-am62-main.dtsi

Re: [PATCH v2 2/5] fastboot: implement "getvar all"

2023-11-21 Thread Mattijs Korpershoek
), uses fastboot multiresponse. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > Reviewed-by: Mattijs Korpershoek > --- > doc/android/fastboot-protocol.rst | 3 ++ > drivers/fastboot/fb_command.c | 3 ++ > drivers/fastboot/fb_getvar.c |

Re: [PATCH v5 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-21 Thread Mattijs Korpershoek
thore > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > Changes in v5: > - Adjust motivation for patch, since the EFI hang is fixed > > Changes in v4: > - Don't rename the legacy-USB functions > - Add a bit more detail to the comment > &g

Re: [PATCH v3 0/3] Improve the experience with USB gadgets

2023-11-21 Thread Mattijs Korpershoek
Hi, On Tue, 10 Oct 2023 11:03:01 +0200, Miquel Raynal wrote: > Try to ease the use of USB gadgets for people not fully aware of all the > terms and constraints. With more helpful error messages a little bit of > guidance anyone should be able to adapt to the bind/unbind game that is > now necessar

[PATCH] doc: sending_patches.rst: s/Superseeded/Superseded

2023-11-21 Thread Mattijs Korpershoek
This is a common typo listed in scripts/spelling.txt. Fix it to match the patchwork status, which is superseded. Signed-off-by: Mattijs Korpershoek --- doc/develop/sending_patches.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/develop/sending_patches.rst b/doc

[GIT PULL] Please pull u-boot-dfu-20231124

2023-11-24 Thread Mattijs Korpershoek
Hi Tom, Here are some fixes for master including: - Fix reinit for ChipIdea controller - Add missing newline in fastboot error handling This CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/18703 Thanks, Mattijs The following changes since commit 24ca49b33af98d54d6

[GIT PULL] Please pull u-boot-dfu-next-20231124

2023-11-24 Thread Mattijs Korpershoek
Hi Tom, Here are some developments for next including: - Make dfu entity name size configurable in KConfig - Implement start-stop for UMS (graceful shutdown via eject) - Improve help messages for cmd/bind - Improve help message for udc bind failures The CI job is at https://source.denx.de/u-boo

Re: [PATCH v4 1/7] usb: dwc3: Add dwc3 glue driver for am62

2024-05-02 Thread Mattijs Korpershoek
Hi Martyn, On mer., mai 01, 2024 at 14:56, Martyn Welch wrote: > On Tue, 2024-01-16 at 11:22 +0100, Mattijs Korpershoek wrote: >> > + /* Program PHY PLL refclk by reading syscon property */ >> > + ret = regmap_update_bits(syscon, args.args[0], >> > PHY_PLL_REFCL

Re: [PATCH 14/81] block: Remove and add needed includes

2024-05-02 Thread Mattijs Korpershoek
Hi Tom, Thank you for the patch. On mer., mai 01, 2024 at 19:30, Tom Rini wrote: > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > Cc: Tom Rini > Cc: To

Re: [PATCH 25/81] dfu: Remove and add needed includes

2024-05-02 Thread Mattijs Korpershoek
Hi Tom, Thank you for the patch. On mer., mai 01, 2024 at 19:30, Tom Rini wrote: > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek Since this is quite a big series, I'm

Re: [PATCH 28/81] fastboot: Remove and add needed includes

2024-05-02 Thread Mattijs Korpershoek
Hi Tom, Thank you for the patch. On mer., mai 01, 2024 at 19:30, Tom Rini wrote: > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > Cc: Mattijs Korpersho

Re: [PATCH 73/81] usb: Remove and add needed includes

2024-05-02 Thread Mattijs Korpershoek
ean 'get_mem'? [-Wimplicit-function-declaration] 464 | unsigned long ts = get_timer(0); |^ | get_mem Adding: "#include " fixes the warning. With the above fix included: Reviewed-by: Mattijs Korpershoek > #include > #include > #include &g

Re: [PATCH 73/81] usb: Remove and add needed includes

2024-05-03 Thread Mattijs Korpershoek
Hi Tom, On jeu., mai 02, 2024 at 08:51, Tom Rini wrote: > On Thu, May 02, 2024 at 09:40:52AM +0200, Mattijs Korpershoek wrote: >> Hi Tom, >> >> Thank you for the patch >> >> On mer., mai 01, 2024 at 19:31, Tom Rini wrote: >> >> > Remove fro

Re: [PATCH v5 3/6] arm: dts: k3-am625-sk: Enable usb port in u-boot

2024-05-07 Thread Mattijs Korpershoek
Hi Martyn, Thank you for the patch. On lun., mai 06, 2024 at 15:38, Martyn Welch wrote: > From: Sjoerd Simons > > Enable usb0 in all boot phases for use with DFU > > Signed-off-by: Sjoerd Simons > Reviewed-by: Alexander Sverdlin > Signed-off-by: Martyn Welch

Re: [PATCH v5 4/6] configs: am62x_evm_*: Enable USB and DFU support

2024-05-07 Thread Mattijs Korpershoek
than the > fragment as this is known not to be supported on all boards that can > support DFU. > > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch Reviewed-by: Mattijs Korpershoek > --- > Changes in v5: > - Switch to config fragment for a53 most DFU config

Re: [PATCH v5 5/6] beagleplay: Add DFU support

2024-05-07 Thread Mattijs Korpershoek
nts. > > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch Reviewed-by: Mattijs Korpershoek I've tested usb gadget on Beagle Play board using fastboot. Also tested DFU mode via snagboot. Tested-by: Mattijs Korpershoek > --- > Changes in v5: > - Use existing con

Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards

2024-05-07 Thread Mattijs Korpershoek
Hi Benjamin, Thank you for the patch. On ven., mai 03, 2024 at 09:00, Benjamin Hahn wrote: > Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. > > Signed-off-by: Benjamin Hahn Reviewed-by: Mattijs Korpershoek This is assigned to me on patchwork. I can pick it up

Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards

2024-05-14 Thread Mattijs Korpershoek
Hi, On Fri, 03 May 2024 09:00:38 +0200, Benjamin Hahn wrote: > Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boa

Re: [PATCH 1/6] usb: dwc3: gadget: combine return points into a single one

2024-05-14 Thread Mattijs Korpershoek
ebug something or if we need to add more code > before returning. > > Let's combine all three return points into a single > one just by introducing a local 'ret' variable. > > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Sverdlin Reviewe

Re: [PATCH 2/6] usb: dwc3: gadget: clear SUSPHY bit before ep cmds

2024-05-14 Thread Mattijs Korpershoek
hat > DWC3_GUSB2PHY(n).SUSPHY bit is cleared. > > This patch implements that particular detail. > > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Sverdlin Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/gadget.c | 23 +++ > 1

Re: [PATCH 3/6] usb: dwc3: gadget: only resume USB2 PHY in <=HIGHSPEED

2024-05-14 Thread Mattijs Korpershoek
PEED. If we're > gonna work on SUPERSPEED or SUPERSPEED+, there's no > point in resuming the USB2 PHY. > > Fixes: 2b0f11df84bb ("usb: dwc3: gadget: clear SUSPHY bit before ep cmds") > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Sverdl

Re: [PATCH 4/6] usb: dwc3: gadget: Check ENBLSLPM before sending ep command

2024-05-14 Thread Mattijs Korpershoek
DWC_usb3 3.30a and DWC_usb31 1.90a programming guide section 3.2.2 > > Signed-off-by: Thinh Nguyen > Signed-off-by: Felipe Balbi > Signed-off-by: Alexander Sverdlin Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/gadget.c | 29 +++-- > 1 fil

Re: [PATCH 5/6] usb: dwc3: gadget: properly check ep cmd

2024-05-14 Thread Mattijs Korpershoek
When checking for StartTransfer > command, we need to make sure to match only lower 4 > bits which contain the actual command and ignore the > rest. > > Reported-by: Janusz Dziedzic > Signed-off-by: Felipe Balbi > [A. Sverdlin: cherry-picked only DWC3_DEPCMD_CMD() define] > S

Re: [PATCH 6/6] usb: dwc3: gadget: Disable GUSB2PHYCFG.SUSPHY for End Transfer

2024-05-14 Thread Mattijs Korpershoek
x27;ve dropped Greg from the cc list as I understand by [1] that he prefers to not receives responses on this. Reviewed-by: Mattijs Korpershoek [1] https://lore.kernel.org/r/all/2024041354-exciting-suggest-b896@gregkh/ > --- > drivers/usb/dwc3/gadget.c | 3 ++- > 1 file changed, 2 inserti

[PATCH 0/2] MAINTAINERS: updates for fastboot and usb gadget

2024-05-14 Thread Mattijs Korpershoek
d patches. While at it, also update FASTBOOT entry to point towards the u-boot-dfu tree. [1] https://lore.kernel.org/all/20240412202611.3565052-1-alexander.sverd...@siemens.com/ Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): MAINTAINERS: add tree link for fastboot

[PATCH 1/2] MAINTAINERS: add tree link for fastboot

2024-05-14 Thread Mattijs Korpershoek
Fastboot patches go through the u-boot-dfu tree. Add a link in the maintainers file for it. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6853288975c0..05217db79f7e 100644 --- a/MAINTAINERS +++ b

[PATCH 2/2] MAINTAINERS: add usb gadget regex to u-boot-dfu tree

2024-05-14 Thread Mattijs Korpershoek
We try to split work with Marek on USB as following: - Mattijs handles usb gadget - Marek handles the rest of usb Add additional gadget patterns to the maintainers file so that I get cc'ed more often on USB gadget patches. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 2 ++ 1

Re: [PATCH 0/6] usb: dwc3: gadget: avoid EP command timeout

2024-05-15 Thread Mattijs Korpershoek
Hi, On Fri, 12 Apr 2024 22:26:00 +0200, A. Sverdlin wrote: > From: Alexander Sverdlin > > While there are happy users who successfully have been using DFU on TI > AM62x [1][2], there are also others who were not so lucky up to now [3]. > > I felt into latter category and was wondering why I obs

[v2][PATCH 0/2] MAINTAINERS: updates for fastboot and USB gadget

2024-05-16 Thread Mattijs Korpershoek
d patches. While at it, also update FASTBOOT entry to point towards the u-boot-dfu tree. [1] https://lore.kernel.org/all/20240412202611.3565052-1-alexander.sverd...@siemens.com/ Signed-off-by: Mattijs Korpershoek --- Changes in v2: - Updated commit message (s/usb/USB) for patch 2 - Added ch9 i

[v2][PATCH 1/2] MAINTAINERS: add tree link for fastboot

2024-05-16 Thread Mattijs Korpershoek
Fastboot patches go through the u-boot-dfu tree. Add a link in the maintainers file for it. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6853288975c0..05217db79f7e 100644 --- a/MAINTAINERS +++ b

[v2][PATCH 2/2] MAINTAINERS: add USB gadget regex to u-boot-dfu tree

2024-05-16 Thread Mattijs Korpershoek
We try to split work with Marek on USB as following: - Mattijs handles USB gadget - Marek handles the rest of USB Add additional gadget patterns to the maintainers file so that I get cc'ed more often on USB gadget patches. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 3 +++ 1

Re: [v2][PATCH 2/2] MAINTAINERS: add USB gadget regex to u-boot-dfu tree

2024-05-16 Thread Mattijs Korpershoek
Hi Marek, Thank you for the review. On jeu., mai 16, 2024 at 12:23, Marek Vasut wrote: > On 5/16/24 11:15 AM, Mattijs Korpershoek wrote: >> We try to split work with Marek on USB as following: >> - Mattijs handles USB gadget >> - Marek handles the rest of USB >>

Re: [v2][PATCH 0/2] MAINTAINERS: updates for fastboot and USB gadget

2024-05-16 Thread Mattijs Korpershoek
Hi, On Thu, 16 May 2024 11:15:40 +0200, Mattijs Korpershoek wrote: > I've noticed that I'm missing quite some USB gadget patches such as [1] > since I'm not always cc'ed. > > With Marek, we agreed on the following split: > - I take care of USB gad

[GIT PULL] Please pull u-boot-dfu-20240516

2024-05-16 Thread Mattijs Korpershoek
urn points into a single one usb: dwc3: gadget: clear SUSPHY bit before ep cmds usb: dwc3: gadget: only resume USB2 PHY in <=HIGHSPEED usb: dwc3: gadget: properly check ep cmd Mattijs Korpershoek (2): MAINTAINERS: add tree link for fastboot MAINTAINERS: add USB gadg

Re: [PATCH] android: Fix ramdisk loading for bootimage v3+

2024-05-22 Thread Mattijs Korpershoek
oot is missing some of the necessary tools > to complete virtual AB OTA. > > Signed-off-by: Roman Stratiienko Reviewed-by: Mattijs Korpershoek [1] https://lore.kernel.org/r/CAGphcdnC124V_D6x06P6apnE+L+PVJSp+88h0FFY449CBgY=p...@mail.gmail.com > --- > boot/image-android.c | 17 ++

Re: [PATCH] abootimg: Add init_boot image support

2024-05-22 Thread Mattijs Korpershoek
Hi Roman, Thank you for the patch. On dim., mai 19, 2024 at 12:53, Roman Stratiienko wrote: > Quote from [1]: > > "For devices launching with Android 13, the generic ramdisk is removed > from the boot image and placed in a separate init_boot image. > This change leaves the boot image with only

Re: [PATCH] abootimg: Add init_boot image support

2024-05-22 Thread Mattijs Korpershoek
Hi Roman, On jeu., mai 23, 2024 at 00:35, Roman Stratiienko wrote: [...] >> > >> > static struct cmd_tbl cmd_abootimg_sub[] = { >> > - U_BOOT_CMD_MKENT(addr, 3, 1, do_abootimg_addr, "", ""), >> > + U_BOOT_CMD_MKENT(addr, 4, 1, do_abootimg_addr, "", ""), >> > U_BOOT_CMD_MKENT(dum

Re: [PATCH v2] abootimg: Add init_boot image support

2024-05-22 Thread Mattijs Korpershoek
the boot image with only the GKI kernel." > > While at it, update wrong error handling message when vendor_boot > cannot be loaded. > > [1]: https://source.android.com/docs/core/architecture/partitions/generic-boot > Signed-off-by: Roman Stratiienko Reviewed-by: Mattijs Ko

Re: [PATCH v3] abootimg: Add init_boot image support

2024-05-23 Thread Mattijs Korpershoek
the boot image with only the GKI kernel." > > While at it, update wrong error handling message when vendor_boot > cannot be loaded. > > [1]: https://source.android.com/docs/core/architecture/partitions/generic-boot > Signed-off-by: Roman Stratiienko > Reviewed-by: Mattijs Ko

[PATCH] image: Set load_end on partial loads

2024-05-23 Thread Mattijs Korpershoek
he image_decomp() logic to always report the decompressed size, even when a partial decompression happened. Signed-off-by: Mattijs Korpershoek --- This has been tested on an AM62X SK EVM board with a big lz4 image and the default CONFIG_SYS_BOOTM_LEN of 0x80. This has also been tested on sandb

[PATCH] doc: cmd: bootmeth: Fix extlinunx -> extlinux typo

2024-05-24 Thread Mattijs Korpershoek
Fix a trivial typo in the bootmeth documentation. Signed-off-by: Mattijs Korpershoek --- doc/usage/cmd/bootmeth.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage/cmd/bootmeth.rst b/doc/usage/cmd/bootmeth.rst index 2903977ee54d..bac9fdf85cdc 100644 --- a/doc/usage

Re: [PATCH 1/3] abootcmd: Add load subcommand

2024-05-28 Thread Mattijs Korpershoek
Hi Roman, Thank you for the patch. On dim., mai 19, 2024 at 19:18, Roman Stratiienko wrote: > What it does: > 1. Allocates the memory in HEAP to fit the partition > 2. Loads partition into memory. In the following patch of this series, >loading will be optimized to avoid loading an empty s

Re: [PATCH 2/3] avb: Implement get_preloaded_partition callback

2024-05-28 Thread Mattijs Korpershoek
to the starting address of the partition > + * @out_num_bytes_preloaded: amount of bytes pre-loaded in memory > + * > + * @return: > + * AVB_IO_RESULT_OK, if partition was found or was not found Add: AVB_IO_RESULT_ERROR_IO, if partition size is smaller than requested With both s

Re: [PATCH 3/3] abootimg: Implement smart image load feature

2024-05-28 Thread Mattijs Korpershoek
Hi Roman, Thank you for the patch. On dim., mai 19, 2024 at 19:18, Roman Stratiienko wrote: > Load only part of the boot partition that contains valuable > information, thus improving the boot time. > > Signed-off-by: Roman Stratiienko > --- > boot/image-android.c | 70 ++

Re: [PATCH] usb: dwc3: gadget: fix crash in dwc3_gadget_giveback()

2024-05-28 Thread Mattijs Korpershoek
request.dma before calling dwc3_flush_cache() and later > the usb_gadget_unmap_request() functions since it means that > usb_gadget_map_request() hasn't been called yet. > > Fixes: fd15b58c1a9 ("dwc3: flush cache only if there is a buffer attached to > a request") > S

Re: [PATCH v2 1/8] dfu: add scsi backend

2024-05-28 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On lun., mai 27, 2024 at 19:17, Caleb Connolly wrote: > This is extremely similar to the MMC backend, but there are some notable > differences. > > Works with a DFU string like > > scsi 4=u-boot-bin part 11 > > Where "4" is the SCSI dev number (sequential

Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x

2024-05-29 Thread Mattijs Korpershoek
Hi Dhruva, On mer., mai 29, 2024 at 11:39, Dhruva Gole wrote: > Hi Sjoerd, > > On Aug 21, 2023 at 14:20:26 -0400, Tom Rini wrote: >> On Mon, Aug 21, 2023 at 04:13:32PM +, Marcel Ziswiler wrote: >> > Hi Sjoerd >> > >> > On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote: >> > > On Wed, 2

Re: [PATCH v2 0/5] arm: meson: Switch to using upstream DT for GXL, GXM, AXG, G12A, G12B & SM1 SoCs

2024-04-02 Thread Mattijs Korpershoek
lab.com/amlogic-foss/amlogic-u-boot-autotest/-/pipelines/1233461384 > > Signed-off-by: Neil Armstrong > --- > Changes in v2: > - add change to remove prefix in fdtfile > - collected review tags > - Link to v1: > https://lore.kernel.org/r/20240319-u-boot-of-upstream-v1-0-f8

Re: [PATCH v5 16/16] usb: gadget: UMS: fix 64-bit division on ARM32

2024-04-02 Thread Mattijs Korpershoek
[1] https://lore.kernel.org/r/87a5mqei67@baylibre.com > --- > Cc: Mattijs Korpershoek > --- > drivers/usb/gadget/f_mass_storage.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/gadget/f_mass_storage.c > b/d

Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

2024-04-02 Thread Mattijs Korpershoek
Hi, On Sun, 17 Mar 2024 05:42:52 +0100, Marek Vasut wrote: > The dm_usb_gadget_handle_interrupts() has no place in board code. Move > this into DWC3 driver. The OMAP implementation is special, add new weak > dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt > handling should

[GIT PULL] Please pull u-boot-dfu-next-20240402

2024-04-02 Thread Mattijs Korpershoek
Hi Tom, Here are some developments for next including: - Implement Qualcomm wrapper for dwc3 - Multiple sector size support for UMS - CDC ACM gadget initialization fix - Refactor board code from dwc3 to prepare better interrupt support - Bugfix for for qcom-smmu when compiling with -DDEBUG The C

[GIT PULL] Please pull u-boot-dfu-20240402

2024-04-02 Thread Mattijs Korpershoek
Hi Tom, Here are some fixes for master including: - Fix #if logic in android_ab command - Fix ANDROID_AB_BACKUP_OFFSET in android_ab The CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20142 Thanks, Mattijs The following changes since commit 425dc46a2c8ebe6d1a5a7d

Re: [PATCH v1] MAINTAINERS: add entries for tee-related orphaned files

2024-04-04 Thread Mattijs Korpershoek
implementation > - Documentation, including device tree bindings > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek > --- > > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0462ade4ac6..0f7325d6045 1

[PATCH] doc: build: update docker image to latest

2024-04-04 Thread Mattijs Korpershoek
commit cacc0b2678c0 ("CI: Move to latest container image") updated the docker container image. Reflect the change in the documentation. Signed-off-by: Mattijs Korpershoek --- Note: maybe we can consider doing the doc change each time we update .gitlab-ci.yml ? --- doc/build/dock

[PATCH] doc: build: fix gen_compile_commands section level

2024-04-04 Thread Mattijs Korpershoek
ot;. This fixes the HTML rendering. Signed-off-by: Mattijs Korpershoek --- doc/build/gen_compile_commands.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/build/gen_compile_commands.rst b/doc/build/gen_compile_commands.rst index 50305cec4a83..d503764f9e3f 100644 --- a/

Re: [PATCH 1/4] virtio: blk: introduce virtio-block erase support

2024-04-05 Thread Mattijs Korpershoek
4 at 18:59, Dmitrii Merkurev wrote: > Co-developed-by: Cody Schuffelen > Signed-off-by: Cody Schuffelen > Signed-off-by: Dmitrii Merkurev > Cc: Tuomas Tynkkynen > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Ying-Chun Liu (PaulLiu) I'm not super familiar with virtio,

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2024-04-05 Thread Mattijs Korpershoek
Hi Dmitrii, Thank you for the patch and sorry for the review delay. On mer., mars 06, 2024 at 18:59, Dmitrii Merkurev wrote: > Signed-off-by: Dmitrii Merkurev > Cc: Patrick Delaunay > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Ying-Chun Liu (PaulLiu) > --- > dri

Re: [PATCH 3/4] fastboot: blk: introduce fastboot block flashing support

2024-04-05 Thread Mattijs Korpershoek
ick Delaunay > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Ying-Chun Liu (PaulLiu) This change (when applied along with 1/4 and 2/4) introduces a build for sandbox: $ make sandbox_defconfig $ make [...] drivers/fastboot/fb_mmc.c: In function 'fastboot_mmc_erase': driv

Re: [PATCH 4/4] fastboot: integrate block flashing back-end

2024-04-05 Thread Mattijs Korpershoek
: Patrick Delaunay > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Ying-Chun Liu (PaulLiu) > --- > drivers/fastboot/fb_command.c | 8 > drivers/fastboot/fb_common.c | 15 +++ > drivers/fastboot/fb_getvar.c | 8 +++- > 3 files changed, 26 insert

Re: [RFC PATCH v2 1/2] fastboot: introduce 'oem board' subcommand

2024-04-05 Thread Mattijs Korpershoek
o others, I have re-considered this and I'm willing to pick it up. Please rebase, as this no longer applies. Also see some review comments below > > On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote: >> Hi Alexey, >> >> Thank you for the patch. >>

Re: [RFC PATCH v2 1/2] fastboot: introduce 'oem board' subcommand

2024-04-05 Thread Mattijs Korpershoek
Hi Alexey, On lun., mars 04, 2024 at 14:11, Alexey Romanov wrote: > Hello, > > On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote: >> Hi Alexey, >> >> Thank you for the patch. >> >> On jeu., f'evr. 01, 2024 at 12:20, Alexey Roma

Re: [RFC PATCH v2 2/2] board: ad401: example of fastboot oem board realization

2024-04-05 Thread Mattijs Korpershoek
Hi Alexey, On lun., mars 04, 2024 at 14:03, Alexey Romanov wrote: > Hello Mattijs, > > On Thu, Feb 15, 2024 at 10:24:11AM +0100, Mattijs Korpershoek wrote: >> On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov >> wrote: >> >> > An example of how we us

Re: [PATCH v3 1/1] fastboot: introduce 'oem board' subcommand

2024-04-09 Thread Mattijs Korpershoek
t; > - flashing: > > $ fastboot stage bootloader.img > $ fastboot oem board:write_bootloader > > - erasing: > > $ fastboot oem board:erase_env > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek Thank you for being patient on this topic! I'll

Re: [PATCH] doc: build: update docker image to latest

2024-04-09 Thread Mattijs Korpershoek
Hi Tom, Thank you for the review. On lun., avril 08, 2024 at 14:11, Tom Rini wrote: > On Fri, Apr 05, 2024 at 08:16:19AM +0200, Mattijs Korpershoek wrote: > > >> commit cacc0b2678c0 ("CI: Move to latest container image") updated the >> docker container image. &

Re: [PATCH v4 1/1] fastboot: introduce 'oem board' subcommand

2024-04-10 Thread Mattijs Korpershoek
>$ fastboot stage bootloader.img >> >$ fastboot oem board:write_bootloader >> > >> > - erasing: >> > >> >$ fastboot oem board:erase_env >> > >> > Signed-off-by: Alexey Romanov >> > Reviewed-by: Mattijs Korper

Re: [PATCH v2 12/16] arm: dts: k3-am625-sk-u-boot: Add sysreset-controller node

2024-04-11 Thread Mattijs Korpershoek
i-u-boot/commit/?h=ti-u-boot-2023.04&id=c5296d943c2c84dd6dcb3b91305d006ac46f3157 Before patch: => reset resetting ... System reset not supported on this platform ### ERROR ### Please RESET the board ### With patch applied: => reset resetting ... Tested-by: Mattijs Korpershoek # on

Re: [PATCH v3 0/1] Introduce fastboot oem board command

2024-04-16 Thread Mattijs Korpershoek
Hi, On Mon, 08 Apr 2024 13:15:51 +0300, Alexey Romanov wrote: > Changes V1 -> V2 [1]: > - Added an example of using the command as requested > by Sean Anderson [2]. > > Changes V2 -> V3 [3]: > - Rebase over uboot/master. > - Add documentation. > - Remove example added in V2 [1]. > >

Re: [PATCH] usb: dwc2: update reset method for host and device mode

2024-04-16 Thread Mattijs Korpershoek
has been completed. > > Signed-off-by: Kongyang Liu I've compared this with the equivalent Linux patch found here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=65dc2e725286106f99c6f6b78e3d9c52c15f3a9c Reviewed-by: Mattijs Korpershoek Also tested on V

Re: [PATCH] usb: dwc2: update reset method for host and device mode

2024-04-16 Thread Mattijs Korpershoek
On mar., avril 16, 2024 at 10:50, Mattijs Korpershoek wrote: > Hi Kongyang, > > Thank you for the patch. > > On jeu., mars 28, 2024 at 21:14, Kongyang Liu > wrote: > >> Starting from version 4.20a, there has been a change in the reset method. >> A new bi

Re: [PATCH] usb: dwc2: Add in version 4xx compatibility

2024-04-16 Thread Mattijs Korpershoek
Hi Greg, Thank you for the contribution. On mar., mars 26, 2024 at 11:36, Greg Malysa wrote: Please avoid top-posting when replying, it makes following the discussion more difficult: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-

Re: [PATCH 1/2] dfu: add scsi backend

2024-04-16 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On mar., avril 09, 2024 at 15:55, Caleb Connolly wrote: > This is extremely similar to the MMC backend, but there are some notable > differences. > > Works with a DFU string like > > scsi 4=u-boot-bin part 11 > > Where "4" is the SCSI dev number (sequenti

Re: [PATCH 2/2] disk: expose partition type flags

2024-04-16 Thread Mattijs Korpershoek
gned-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > disk/part_efi.c | 1 + > include/part.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/disk/part_efi.c b/disk/part_efi.c > index 4ce9243ef25c..d3ce4dd01dcd 100644 > --- a/dis

Re: [PATCH] usb: dwc3: support USB 3.1 controllers

2024-04-16 Thread Mattijs Korpershoek
Hi Caleb,; Thank you for the patch. On jeu., avril 11, 2024 at 18:05, Caleb Connolly wrote: > The revision is different for these, add the additional check as in > xhci-dwc3 core_init code. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > drive

Re: [PATCH v2 12/16] arm: dts: k3-am625-sk-u-boot: Add sysreset-controller node

2024-04-16 Thread Mattijs Korpershoek
Hi Jon, On jeu., avril 11, 2024 at 15:30, Jon Humphreys wrote: > Mattijs Korpershoek writes: > >> Hi Jonathan, >> >> Thank you for the patch. >> >> On lun., avril 08, 2024 at 17:31, Jonathan Humphreys >> wrote: >> >>> Signed-off-by:

Re: [PATCH] usb: musb-new: sunxi: support usage with DM_USB_GADGET

2024-04-16 Thread Mattijs Korpershoek
Hi, On ven., avril 12, 2024 at 18:54, Aren wrote: > On Thu, Apr 11, 2024 at 04:46:17PM +1000, John Watts wrote: >> On Sun, Dec 31, 2023 at 03:38:37PM -0500, Aren Moynihan wrote: >> > Add support for building the sunxi-musb driver with DM_USB_GADGET >> > including adding a separate IRQ handling f

Re: [PATCH] Kconfig: Remove all default n options

2024-04-16 Thread Mattijs Korpershoek
gt; > Signed-off-by: Michal Simek Reviewed-by: Mattijs Korpershoek > --- > > boot/Kconfig | 1 - > cmd/Kconfig | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/boot/Kconfig b/boot/Kconfig > index 777e408e2438..bb61e8b24f1c 100644 > --- a/boot/Kconfig &g

Re: [PATCH v4 1/1] fastboot: introduce 'oem board' subcommand

2024-04-18 Thread Mattijs Korpershoek
gt; > $ fastboot stage bootloader.img > $ fastboot oem board:write_bootloader > > - erasing: > > $ fastboot oem board:erase_env > > Signed-off-by: Alexey Romanov > Reviewed-by: Mattijs Korpershoek After applying this patch on master, it seems that the CI broke:

Re: [PATCH v5 0/1] Introduce fastboot oem board command

2024-04-18 Thread Mattijs Korpershoek
Hi, On Thu, 18 Apr 2024 13:01:28 +0300, Alexey Romanov wrote: > Changes V1 -> V2 [1]: > - Added an example of using the command as requested > by Sean Anderson [2]. > > Changes V2 -> V3 [3]: > - Rebase over uboot/master. > - Add documentation. > - Remove example added in V2 [1]. > >

[GIT PULL] Please pull u-boot-dfu-20240419

2024-04-19 Thread Mattijs Korpershoek
Hi Tom, Here is a new development for master: - new "fastboot oem board" command This CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20427 Thanks, Mattijs The following changes since commit 2c3fa4b8add3cb6a440184ab67debc6867d383c0: sandbox: don't call os_close

<    1   2   3   4   5   6   7   8   9   10   >