Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-05 Thread Mattijs Korpershoek
Bulk(R):LIBUSB_ERROR_IO(0s) > > The "fastboot reboot" command detaches the USB when it still needs to be > used. So let's detach the USB just before the reset. > > CC: Mattijs Korpershoek > Fixes: 5f7e01e9d5d800 ("usb: gadget: fastboot: detach usb on reboot com

Re: [PATCH] usb: gadget: fastboot: detach usb just before rebooting

2023-01-05 Thread Mattijs Korpershoek
gt;> 3:72>Start Cmd:FB: reboot >> 3:72>Fail Bulk(R):LIBUSB_ERROR_IO(0s) >> >> The "fastboot reboot" command detaches the USB when it still needs to be >> used. So let's detach the USB just before the reset. >> >> CC: Mattijs Korper

Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-05 Thread Mattijs Korpershoek
On Thu, Jan 05, 2023 at 10:10, Dario Binacchi wrote: > Hi Mattijs, > > On Thu, Jan 5, 2023 at 10:06 AM Mattijs Korpershoek > wrote: >> >> On Wed, Jan 04, 2023 at 17:46, Dario Binacchi >> wrote: >> >> > The patch fixes the following error when

Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-05 Thread Mattijs Korpershoek
On Thu, Jan 05, 2023 at 14:25, Dario Binacchi wrote: > Hi Mattijs, > > On Thu, Jan 5, 2023 at 12:03 PM Mattijs Korpershoek > wrote: >> >> On Thu, Jan 05, 2023 at 10:10, Dario Binacchi >> wrote: >> >> > Hi Mattijs, >> > >> >

Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-06 Thread Mattijs Korpershoek
On Thu, Jan 05, 2023 at 14:25, Dario Binacchi wrote: > Hi Mattijs, > > On Thu, Jan 5, 2023 at 12:03 PM Mattijs Korpershoek > wrote: >> >> On Thu, Jan 05, 2023 at 10:10, Dario Binacchi >> wrote: >> >> > Hi Mattijs, >> > >> >

Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-10 Thread Mattijs Korpershoek
Hi Dario, On Sat, Jan 07, 2023 at 17:45, Dario Binacchi wrote: > Hi Mattijs, > > On Fri, Jan 6, 2023 at 5:42 PM Mattijs Korpershoek > wrote: >> >> On Thu, Jan 05, 2023 at 14:25, Dario Binacchi >> wrote: >> >> > Hi Mattijs, >> > &g

Re: [PATCH v3] usb: gadget: fastboot: detach usb just before rebooting

2023-01-10 Thread Mattijs Korpershoek
rt Cmd:FB: reboot > 3:72>Fail Bulk(R):LIBUSB_ERROR_IO(0s) > > The "fastboot reboot" command detaches the USB when it still needs to be > used. So let's detach the USB just before the reset. > > CC: Mattijs Korpershoek > Fixes: 5f7e01e9d5d800 ("usb: gadget:

[PATCH] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-10 Thread Mattijs Korpershoek
() is called. Signed-off-by: Mattijs Korpershoek --- On some boards using the dwc2 controller, like the Khadas VIM3L, whenever usb_gadget_release() is called, the D+ and D- lines are in an unknown state. Because of that, the host can't detect usb disconnection. It was attempted to be be fixed

Re: [PATCH v3] usb: gadget: fastboot: detach usb just before rebooting

2023-01-10 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 09:33, Mattijs Korpershoek wrote: > Hi Dario, > > Thank you for your patch. > > On Sat, Jan 07, 2023 at 17:48, Dario Binacchi > wrote: > >> The patch fixes the following error when updating a BSH SMM S2 board: >> 3:72>Start Cmd:FB[

Re: [PATCH 0/2] mach-meson: port dwc2_otg usage to CONFIG_DM_USB_GADGET=y

2023-01-10 Thread Mattijs Korpershoek
On Wed, Dec 14, 2022 at 15:49, neil.armstr...@linaro.org wrote: > Hi, > > On 14/12/2022 15:45, Mattijs Korpershoek wrote: >> Hi Neil, > > > >>> >>> I'll run some tests on other G12 boards but so far this looks very good, >>> thanks ! >&

Re: [PATCH] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-10 Thread Mattijs Korpershoek
Hi Harald, Thank you for your review. On Tue, Jan 10, 2023 at 14:30, Harald Seiler wrote: > Hi, > > On Tue, 2023-01-10 at 10:11 +0100, Mattijs Korpershoek wrote: >> Pullup is used by the usb framework in order to do software-controlled >> usb_gadget_connect() and

Re: [PATCH v4 1/5] asm/arch-meson: add missing meson_sm_write_efuse signature

2023-01-10 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 13:56, Alexey Romanov wrote: > This function can be used by other modules. Also add comments. > > Signed-off-by: Alexey Romanov > Reviewed-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > arch/arm/include/asm/ar

Re: [PATCH v4 3/5] doc/usage: cmd: documentation for meson/sm command

2023-01-10 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 13:56, Alexey Romanov wrote: > Added docs for Meson Security Monitor command. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > doc/usage/cmd/sm.rst | 44 > doc/usage/index.rst

Re: [PATCH v4 5/5] doc/usage: cmd: sm: documentation efusedump cmd

2023-01-10 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 13:56, Alexey Romanov wrote: > Added docs about sm efusedump command, that reads bytes > from efuse memory bank and print them to the console. > > Signed-off-by: Alexey Romanov > Reviewed-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --

Re: [PATCH] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-10 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 14:45, Marek Vasut wrote: > On 1/10/23 14:39, Mattijs Korpershoek wrote: >> Hi Harald, >> >> Thank you for your review. >> >> On Tue, Jan 10, 2023 at 14:30, Harald Seiler wrote: >> >>> Hi, >>> >>

[PATCH v2] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-10 Thread Mattijs Korpershoek
especially useful when a gadget disconnection is initiated but no board_usb_cleanup() is called. Signed-off-by: Mattijs Korpershoek --- On some boards using the dwc2 controller, like the Khadas VIM3L, whenever usb_gadget_release() is called, the D+ and D- lines are in an unknown state. Because of

Re: [PATCH v2] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-11 Thread Mattijs Korpershoek
On Tue, Jan 10, 2023 at 18:23, Marek Vasut wrote: > On 1/10/23 17:29, Mattijs Korpershoek wrote: > > [...] > >> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c >> b/drivers/usb/gadget/dwc2_udc_otg.c >> index 77988f78ab30..d0a9be49ad9c 100644 >> --- a/driver

[PATCH v3] usb: gadget: dwc2_udc_otg: implement pullup()

2023-01-11 Thread Mattijs Korpershoek
especially useful when a gadget disconnection is initiated but no board_usb_cleanup() is called. Signed-off-by: Mattijs Korpershoek --- On some boards using the dwc2 controller, like the Khadas VIM3L, whenever usb_gadget_release() is called, the D+ and D- lines are in an unknown state. Because of

Re: [PATCH 1/2] usb: dwc3-meson-gxl: force mode on child add/removal

2023-01-17 Thread Mattijs Korpershoek
aylibre.com/ > > Signed-off-by: Neil Armstrong Thank you for mentioning me, I appreciate it. Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/dwc3-meson-gxl.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-meson-gxl.

Re: [PATCH 2/2] ARM: meson: switch AXG & GX dwc2 otg to DM

2023-01-17 Thread Mattijs Korpershoek
; https://lore.kernel.org/all/20221024-meson-dm-usb-v1-2-2ab077a50...@baylibre.com/ > > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > arch/arm/mach-meson/board-axg.c | 129 - > arch/arm/mach-meson/board-gx.c | 137

Re: [PATCH 06/14] fastboot: Change fastboot_buf_addr to an address

2023-12-05 Thread Mattijs Korpershoek
AOSP on the Khadas VIM 3 board. Tested-by: Mattijs Korpershoek # on vim3 Reviewed-by: Mattijs Korpershoek Some small nit/question below. > --- > > cmd/fastboot.c| 2 +- > drivers/fastboot/fb_command.c | 13 - > drivers/fastboot/fb_common.c | 15

Re: [PATCH 1/6] dt-bindings: clock: add Mediatek MT8365 SoC clock bindings

2023-12-05 Thread Mattijs Korpershoek
; +#define CLK_TOP_VPLL_DPIX_EN 133 > +#define CLK_TOP_SSUSB_TOP_CK_EN 134 > +#define CLK_TOP_SSUSB_PHY_CK_EN 135 > +#define CLK_TOP_CONN_32K 136 > +#define CLK_TOP_CONN_26M 137 > +#define CLK_TOP_DSP_32K

Re: [PATCH 2/6] clk: mediatek: add clock driver support for MediaTek MT8365 SoC

2023-12-05 Thread Mattijs Korpershoek
les: > - clk-mt8365.c (a96cbb146a9736f501fe66ebda6a9018735e5e8a) > - clk-mt8365-apmixedsys.c (65c9ad77cbc0eed78db94d80041aba675cfbdfa9) > And adapted following the clk attributes supported by U-Boot. > > Signed-off-by: Julien Masson Reviewed-by: Mattijs Korpershoek > --- > driver

Re: [PATCH 3/6] dt-bindings: power: add power-domain header for MediaTek MT8365 SoC

2023-12-05 Thread Mattijs Korpershoek
Hi Julien, Thank you for your patch. On lun., déc. 04, 2023 at 11:48, Julien Masson wrote: > Add power-domain header for MediaTek MT8365 SoC copied from Linux > source code tag v6.7-rc2. > (commit a1571f1f333c2fced076f0d54ed771d1838d827f) > > Signed-off-by: Julien Masson Revie

Re: [PATCH 06/14] fastboot: Change fastboot_buf_addr to an address

2023-12-06 Thread Mattijs Korpershoek
On Tue, Dec 05, 2023 at 20:54, Simon Glass wrote: > Hi Mattijs, > > On Tue, 5 Dec 2023 at 02:16, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> Thank you for your patch. >> >> On dim., déc. 03, 2023 at 17:31, Simon Glass wrote: >>

Re: [PATCH v2 06/21] bootm: Adjust how the board is reset

2023-12-15 Thread Mattijs Korpershoek
o the bootm command. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > boot/bootm.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/boot/bootm.c b/boot/bootm

Re: [PATCH v2 11/21] bootm: Move do_bootm_states() comment to header file

2023-12-15 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On jeu., déc. 14, 2023 at 09:50, Simon Glass wrote: > This is an exported function, so move the function comment to the > bootm.h header file. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: &

Re: [PATCH v2 08/16] fastboot: Remove dependencies on CMDLINE

2023-12-15 Thread Mattijs Korpershoek
s Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Avoid changing the logic when a command is not set > > drivers/fastboot/Kconfig | 1 - > drivers/fastboot/fb_common.c | 30 ++ > 2 files changed, 14 insertions(+), 17 deletio

Re: [PATCH v2 09/16] doc: Mention fastboot dependency on CMDLINE

2023-12-15 Thread Mattijs Korpershoek
y: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > doc/android/fastboot.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/android/fastboot.rst b/doc/android/fastboot.rst > index 1ad8a897c853..933a652538c7 100644

Re: [PATCH] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
happens when log_reg is enabled via CONFIG_LOG_ERROR_RETURN. > Otherwise we may return an invalid/truncated clock rate value. > > Signed-off-by: Julien Masson I'm wondering if there are any other places where this happens, but this change looks good to me. Reviewed-by: Mattijs Korp

Re: [PATCH] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
On ven., déc. 15, 2023 at 13:34, Mattijs Korpershoek wrote: > Hi Julien, > > Thank you for the patch. > > On mar., nov. 21, 2023 at 15:42, Julien Masson wrote: > >> When we call clk_get_rate(), we expect to get clock rate value as >> ulong. >> In that ca

Re: [PATCH v2] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
t; > Signed-off-by: Julien Masson Reviewed-by: Mattijs Korpershoek > --- > Changes in v2: > - remove local var ret (fix warning) > - Link to v1: https://lore.kernel.org/all/871qcj5frz@baylibre.com > --- > drivers/clk/clk-uclass.c | 7 +-- > 1 file changed, 1 ins

[PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-20 Thread Mattijs Korpershoek
Commit 19a91f2464a8 ("Create a new boot/ directory") moved the android_ab.c code under boot/android_ab but did not update the MAINTAINERS entry. Update it so that the maintainer will get cc'ed again. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 2 +- 1 file changed, 1

Re: [PATCH v1] android_ab: don't ignore ab_control_store return code

2023-12-20 Thread Mattijs Korpershoek
free(abc); > + log_err("ANDROID: failed to store boot control block: > %d\n", ret); Same here With that addressed: Reviewed-by: Mattijs Korpershoek > + return ret; > + } > } > free(backup_abc); > #endif > -- > 2.39.2

Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally

2023-12-20 Thread Mattijs Korpershoek
phyinit command is run > only for such SoCs. > > Signed-off-by: Manorit Chawdhry > Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek > --- > > Hello, > > This patch is based on commit > 65eed68772 test/py: Disable error E0611 in two cases for pyli

Re: [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-21 Thread Mattijs Korpershoek
Hi Sam, Thank you for your review. On Thu, Dec 21, 2023 at 08:15, Sam Protsenko wrote: > Hi Mattijs, > > On Wed, Dec 20, 2023 at 10:43 AM Mattijs Korpershoek > wrote: >> >> Commit 19a91f2464a8 ("Create a new boot/ directory") moved the >> android_ab.

[PATCH v2] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-21 Thread Mattijs Korpershoek
Commit 19a91f2464a8 ("Create a new boot/ directory") moved the android_ab.c code under boot/android_ab but did not update the MAINTAINERS entry. Update it so that the maintainer will get cc'ed again. Fixes: 19a91f2464a8 ("Create a new boot/ directory") Signed-of

Re: [PATCH v5 02/23] doc: ti: k3: Correct spelling mistakes and improve clarity

2024-06-02 Thread Mattijs Korpershoek
Hi Jon, Thank you for the patch. On ven., mai 31, 2024 at 17:20, Jonathan Humphreys wrote: > Few cosmetic fixes for clarity and spelling mistakes. > > Signed-off-by: Jonathan Humphreys Reviewed-by: Mattijs Korpershoek > --- > doc/board/ti/k3.rst | 10 +- >

[PATCH] cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n

2024-06-03 Thread Mattijs Korpershoek
IG_CMD_BCB=n. Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") Signed-off-by: Mattijs Korpershoek --- include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/bcb.h b/include/bcb.h index 1941d8c28b4f..a56b547595a6

[PATCH] bootstd: Fix a handful of doc typos in bootmeth

2024-06-03 Thread Mattijs Korpershoek
Fix some trivial typos found by browsing the code. Done with flyspell. Signed-off-by: Mattijs Korpershoek --- include/bootmeth.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/bootmeth.h b/include/bootmeth.h index 0fc36104ece0..529c4d813d82 100644 --- a

Re: [PATCH] usb: dwc3: gadget: fix crash in dwc3_gadget_giveback()

2024-06-03 Thread Mattijs Korpershoek
Hi, On Tue, 28 May 2024 10:35:03 +0200, Neil Armstrong wrote: > If the ep0 stalls or request are dequeued when gagdet is stopped, > the request dma may not be mapped yet and dwc3_flush_cache() may be > called with a NULL pointer. > > Check req->request.dma before calling dwc3_flush_cache() and la

Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver

2024-06-03 Thread Mattijs Korpershoek
his function); > > Add the missing dependency. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > drivers/dfu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig > index 0360d9da142..9712

Re: [PATCH v3 1/8] dfu: add scsi backend

2024-06-04 Thread Mattijs Korpershoek
able to execute any > arbitrary commands just like in the u-boot's shell. Can we please add CONFIG_DFU_SCSI in "Configuration Options" section at the beginning of this document? See: https://docs.u-boot.org/en/latest/usage/dfu.html#configuration-options Note: I requested that h

Re: [PATCH] bootstd: Fix a handful of doc typos in bootmeth

2024-06-04 Thread Mattijs Korpershoek
Hi Quentin, On mar., juin 04, 2024 at 11:47, Quentin Schulz wrote: > Hi Mattijs, > > On 6/3/24 11:11 AM, Mattijs Korpershoek wrote: >> Fix some trivial typos found by browsing the code. >> Done with flyspell. >> >> Signed-off-by: Mattijs Korpershoek &

[PATCH v2 0/2] bootstd: Fix a handful of doc typos in bootmeth

2024-06-04 Thread Mattijs Korpershoek
ixes some trivial typos, second patch replaces all occurences of bootmethod(s) -> bootmeth(s). Signed-off-by: Mattijs Korpershoek --- Changes in v2: - Made into a series - New patch replaces all bootmethod(s) -> bootmeth(s) - Link to v1: https://lore.kernel.org/r/20240603-bootmeth-typos-v1

[PATCH v2 1/2] bootstd: Fix a handful of doc typos in bootmeth

2024-06-04 Thread Mattijs Korpershoek
Fix some trivial typos found by browsing the code. Done with flyspell. Reviewed-by: Quentin Schulz Signed-off-by: Mattijs Korpershoek --- include/bootmeth.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/bootmeth.h b/include/bootmeth.h index

[PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-04 Thread Mattijs Korpershoek
- bootmeth - because 'method' is too vanilla, appears 1300 times in U-Boot """ Replace all occurences in various comments for consistency. [1] https://lore.kernel.org/u-boot/20211023232635.9195-1-...@chromium.org/ Signed-off-by: Mattijs Korpershoek ---

Re: [PATCH] bootstd: Fix a handful of doc typos in bootmeth

2024-06-04 Thread Mattijs Korpershoek
Hi Quentin, Thanks for the review! On mar., juin 04, 2024 at 14:22, Quentin Schulz wrote: > Hi Mattijs, > > On 6/4/24 2:04 PM, Mattijs Korpershoek wrote: [...] >> >> There seems indeed to be some inconsistencies around bootmeths versus >> bootmethods. >>

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-05 Thread Mattijs Korpershoek
Hi Quentin, Thank you for the review. On mar., juin 04, 2024 at 17:25, Quentin Schulz wrote: > Hi Mattijs, > > On 6/4/24 5:15 PM, Mattijs Korpershoek wrote: >> According to [1], we should use bootmeth when describing the >> struct bootmeth: >> >> ""

Re: [PATCH 3/3] regulator: rk8xx: clarify operator precedence

2024-06-05 Thread Mattijs Korpershoek
y: Quentin Schulz Reviewed-by: Mattijs Korpershoek > --- > drivers/power/regulator/rk8xx.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c > index bd5a37e

Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver

2024-06-06 Thread Mattijs Korpershoek
Hi, On Tue, 04 Jun 2024 07:44:25 +0200, Heinrich Schuchardt wrote: > Building the SPI flash DFU driver fails if SPI flash support is missing. > > drivers/dfu/dfu_sf.c:123:29: error: > ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function); > > Add the missing dependency. > > [

Re: [PATCH 1/3] arm: dts: am625_beagleplay: Switch to OF_UPSTREAM

2024-06-06 Thread Mattijs Korpershoek
v6.10-rc1). > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/Makefile| 1 - > arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 4 +- > arch/arm/dts/k3-am625-beagleplay.dts | 932 ---

[GIT PULL] Please pull u-boot-dfu-20240606

2024-06-06 Thread Mattijs Korpershoek
Hi Tom, Please find some fixes for master: - dwc3 fix crash when ep0 stalls or gadget is stopped - Kconfig build fix for DFU_SF (SPI flash DFU driver) The CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20990 Thanks, Mattijs The following changes since commit c0ea

[GIT PULL] Please pull u-boot-dfu-20240606

2024-06-06 Thread Mattijs Korpershoek
Hi Tom, Please find some fixes for master: - dwc3 fix crash when ep0 stalls or gadget is stopped - Kconfig build fix for DFU_SF (SPI flash DFU driver) The CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20990 Thanks, Mattijs The following changes since commit c0ea

Re: [GIT PULL] Please pull u-boot-dfu-20240606

2024-06-06 Thread Mattijs Korpershoek
Hi everyone, On jeu., mai 16, 2024 at 17:12, Mattijs Korpershoek wrote: > Hi Tom, > > Please find some fixes for master: > > - dwc3 fix crash when ep0 stalls or gadget is stopped > - Kconfig build fix for DFU_SF (SPI flash DFU driver) > > The CI job is at > ht

[PATCH 0/6] bootstd: Add Android support

2024-06-06 Thread Mattijs Korpershoek
nfigs/meson64_android.h [5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ [6] https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (6): boot: android: Pr

[PATCH 1/6] boot: android: Provide vendor_bootimg_addr in boot_get_fdt()

2024-06-06 Thread Mattijs Korpershoek
When calling android_image_get_dtb_by_index() using boot image v3+, we should also pass the vendor_boot ramdisk address. Use get_avendor_bootimg_addr() to do so. Note: on boot image v2, this is harmless since get_avendor_bootimg_addr() returns -1. Signed-off-by: Mattijs Korpershoek --- boot

[PATCH 2/6] boot: android: Add image_android_get_version()

2024-06-06 Thread Mattijs Korpershoek
When reading a boot image header, we may need to retrieve the header version. Add a helper function for it. Signed-off-by: Mattijs Korpershoek --- boot/image-android.c | 7 ++- include/image.h | 7 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/boot/image

[PATCH 3/6] bootstd: Add bootflow_iter_check_mmc() helper

2024-06-06 Thread Mattijs Korpershoek
Some bootflows might be able to only boot from MMC devices. Add a helper function these bootflows can use. Signed-off-by: Mattijs Korpershoek --- boot/bootflow.c| 12 include/bootflow.h | 9 + 2 files changed, 21 insertions(+) diff --git a/boot/bootflow.c b/boot

[PATCH 4/6] android: boot: Add set_abootimg_addr() and set_avendor_bootimg_addr()

2024-06-06 Thread Mattijs Korpershoek
useful for implementing an Android bootmethod. Signed-off-by: Mattijs Korpershoek --- cmd/abootimg.c | 10 ++ include/image.h | 14 ++ 2 files changed, 24 insertions(+) diff --git a/cmd/abootimg.c b/cmd/abootimg.c index 88c77d999290..33381e22dec2 100644 --- a/cmd/abootimg.c

[PATCH 6/6] bootstd: Add test for bootmeth_android

2024-06-06 Thread Mattijs Korpershoek
BOOTMETH_ANDROID as a dependency on sandbox so that we can test this with: $ ./test/py/test.py --bd sandbox --build -k test_ut # to build the mmc7.img $ ./test/py/test.py --bd sandbox --build -k bootflow_android Signed-off-by: Mattijs Korpershoek --- arch/sandbox/dts/test.dts | 8 + configs

[PATCH 5/6] bootstd: Add a bootmeth for Android

2024-06-06 Thread Mattijs Korpershoek
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 7 + boot/Kconfig| 14 ++ boot/Makefile | 2 + boot/bootmeth_android.c | 522 boot/bootmeth_android.h

Re: [PATCH 2/3] arm: dts: am625_sk: Switch to OF_UPSTREAM

2024-06-07 Thread Mattijs Korpershoek
gt; > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek Boot tested to main U-Boot via DFU on AM62X SK EVM. Tested-by: Mattijs Korpershoek > --- > arch/arm/dts/Makefile|3 +- > arch/arm/dts/k3-am62-main.dtsi | 1058 --

Re: [PATCH 1/6] usb: gadget: g_dnl: Drop usb_gadget_controller_number()

2024-06-11 Thread Mattijs Korpershoek
gadget: remove usb_gadget_controller_number()") > > Signed-off-by: Marek Vasut Compared with linux commit, and looks good to me. Reviewed-by: Mattijs Korpershoek Tested that I could use fastboot, ums and scan for storage devices on khadas vim3 Tested-by: Mattijs Korpershoek # vim3 >

Re: [PATCH 2/6] usb: gadget: ether: Drop usb_gadget_controller_number()

2024-06-11 Thread Mattijs Korpershoek
gadget: remove usb_gadget_controller_number()") > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Nis

Re: [PATCH 3/6] usb: gadget: Drop usb_gadget_controller_number()

2024-06-11 Thread Mattijs Korpershoek
need this quirk anymore. > > This patch removes the newly unused function. Linux stopped using this > functionality in 2012, remove it from U-Boot as well. > > Matching Linux kernel commit: > ed9cbda63d45 ("usb: gadget: remove usb_gadget_controller_number()") > >

Re: [PATCH 4/6] usb: gadget: Drop all gadget_is_*() functions

2024-06-11 Thread Mattijs Korpershoek
s.h as well. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Simon Glass >

Re: [PATCH 5/6] usb: gadget: Add full ep_matches() check past .match_ep() callback

2024-06-11 Thread Mattijs Korpershoek
y the linux implementation (usb_ep_autoconfig_ss()). Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Simon

Re: [PATCH 6/6] usb: dwc3: gadget: Convert epautoconf workaround to match_ep callback

2024-06-11 Thread Mattijs Korpershoek
eeks or so, otherwise I'll apply the changes. > > Signed-off-by: Marek Vasut To me, this looks good. Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs

Re: [PATCH 2/6] boot: android: Add image_android_get_version()

2024-06-11 Thread Mattijs Korpershoek
Hi Igor, Thank you for the review. On lun., juin 10, 2024 at 11:20, Igor Opaniuk wrote: > Hi Mattijs, > > On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek > wrote: >> >> When reading a boot image header, we may need to retrieve the header >> version. >

Re: [PATCH 3/6] bootstd: Add bootflow_iter_check_mmc() helper

2024-06-11 Thread Mattijs Korpershoek
Hi Igor, Thank you for the review. On lun., juin 10, 2024 at 11:31, Igor Opaniuk wrote: > Hi Mattijs, > > On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek > wrote: >> >> Some bootflows might be able to only boot from MMC devices. >> >> Add a hel

Re: [PATCH 3/6] usb: gadget: Drop usb_gadget_controller_number()

2024-06-11 Thread Mattijs Korpershoek
Hi Lukasz, On mar., juin 11, 2024 at 10:51, Lukasz Majewski wrote: > On Tue, 11 Jun 2024 09:20:33 +0200 > Mattijs Korpershoek wrote: [...] > >> > -- >> > 2.43.0 > > FInally. :-) > > Thanks Mattijs for this cleanup. You should thank Marek, i

Re: [PATCH 5/6] bootstd: Add a bootmeth for Android

2024-06-11 Thread Mattijs Korpershoek
Hi Igor, Thank you for your quick review. On lun., juin 10, 2024 at 17:15, Igor Opaniuk wrote: > Hi Mattijs, > > On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek > wrote: >> >> Android boot flow is a bit different than a regular Linux distro. >> Android re

Re: [PATCH 5/6] bootstd: Add a bootmeth for Android

2024-06-12 Thread Mattijs Korpershoek
Hi Simon, Thank you for your review. On mar., juin 11, 2024 at 12:52, Simon Glass wrote: > Hi Mattijs, > > On Thu, 6 Jun 2024 at 06:24, Mattijs Korpershoek > wrote: >> >> Android boot flow is a bit different than a regular Linux distro. >> Android relies on m

[PATCH v2 4/5] bootstd: Add a bootmeth for Android

2024-06-13 Thread Mattijs Korpershoek
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ Reviewed-by: Simon Glass Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 7 + boot/Kconfig| 16 ++ boot/Makefile | 2 + boot/bootmeth_android.c | 553

[PATCH v2 5/5] bootstd: Add test for bootmeth_android

2024-06-13 Thread Mattijs Korpershoek
Glass Signed-off-by: Mattijs Korpershoek --- arch/sandbox/dts/test.dts | 8 + configs/sandbox_defconfig | 2 +- test/boot/bootflow.c | 65 ++-- test/py/tests/test_ut.py | 76 +++ 4 files changed, 147

[PATCH v2 3/5] android: boot: Add set_abootimg_addr() and set_avendor_bootimg_addr()

2024-06-13 Thread Mattijs Korpershoek
useful for implementing an Android bootmethod. Reviewed-by: Igor Opaniuk Signed-off-by: Mattijs Korpershoek --- cmd/abootimg.c | 10 ++ include/image.h | 14 ++ 2 files changed, 24 insertions(+) diff --git a/cmd/abootimg.c b/cmd/abootimg.c index 327712a536c0..ae7a1a7c83b0 10

[PATCH v2 0/5] bootstd: Add Android support

2024-06-13 Thread Mattijs Korpershoek
nfigs/meson64_android.h [5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/ [6] https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html Signed-off-by: Mattijs Korpershoek --- Changes in v2: - Dropped patch 2/6 boot: android

[PATCH v2 1/5] boot: android: Provide vendor_bootimg_addr in boot_get_fdt()

2024-06-13 Thread Mattijs Korpershoek
don't have CMD_ABOOTIMG, add a weak implementation to avoid linking errors. Signed-off-by: Mattijs Korpershoek --- boot/image-android.c | 5 + boot/image-fdt.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/boot/image-android.c b/boot/image-android.c

[PATCH v2 2/5] bootstd: Add bootflow_iter_check_mmc() helper

2024-06-13 Thread Mattijs Korpershoek
Some bootflows might be able to only boot from MMC devices. Add a helper function these bootflows can use. Reviewed-by: Igor Opaniuk Signed-off-by: Mattijs Korpershoek --- boot/bootflow.c| 12 include/bootflow.h | 9 + 2 files changed, 21 insertions(+) diff --git a

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-06-14 Thread Mattijs Korpershoek
Hi Guillaume, Thank you for testing. On ven., juin 14, 2024 at 11:53, Guillaume LA ROQUE wrote: > Hi, > > i apply  patch series with commit you give in cover letter and test on > TI AM62S-SK board. > Android boot properly , just with a small changes in uboot eenv > > setenv vendor_boot_comp_a

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-16 Thread Mattijs Korpershoek
Hi Heinrich, Thank you for your review. On dim., juin 16, 2024 at 09:38, Heinrich Schuchardt wrote: > On 6/4/24 17:15, Mattijs Korpershoek wrote: >> According to [1], we should use bootmeth when describing the >> struct bootmeth: >> >> """ >> For

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-06-17 Thread Mattijs Korpershoek
Hi Simon, On lun., juin 17, 2024 at 07:53, Simon Glass wrote: > Hi Mattijs, > > On Thu, 13 Jun 2024 at 04:13, Mattijs Korpershoek > wrote: >> >> Android boot flow is a bit different than a regular Linux distro. >> Android relies on multiple partitions in order

Re: [PATCH 00/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass

2024-06-18 Thread Mattijs Korpershoek
rivers/usb/musb-new/ux500.c| 22 ++ > include/linux/usb/gadget.h | 8 > 14 files changed, 172 insertions(+), 81 deletions(-) Tested on Khadas vim3 using fastboot, ums and usb storage scanning. Tested-by: Mattijs Korpershoek # vim3 > >

Re: [PATCH 01/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass

2024-06-18 Thread Mattijs Korpershoek
: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Simon Glass > Cc: Thinh Nguyen > Cc: Tom Rini > Cc: u-boot@lists.

Re: [PATCH] usb: dwc3-generic: Fix build errors when USB_DWC3_GADGET is disabled

2024-06-18 Thread Mattijs Korpershoek
Hi Jonas, On sam., mars 02, 2024 at 14:00, Jonas Karlman wrote: [...] >> >> I will keep you posted. > > Thanks, much appreciated! > > Please also keep in mind that changing the interrupt handling probably > only fixes the second of the two build errors reported and fixed by this > patch. > > T

Re: [PATCH 02/11] usb: gadget: cdns3: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Keep the dm_usb_gadget_handle_interrupts() in this driver for non-DM > case for now, until this driver gets fully converted to DM USB gadget. > > Signed-off-by: Marek Vasut Re

Re: [PATCH 03/11] usb: gadget: dwc2: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek >

Re: [PATCH 05/11] usb: gadget: max3420: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek >

Re: [PATCH 06/11] usb: gadget: mtu3: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek >

Re: [PATCH 04/11] usb: gadget: dwc3: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek >

Re: [PATCH 09/11] usb: gadget: ux500: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek nitpick below (up to you if you want to fix it) > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > C

Re: [PATCH 08/11] usb: gadget: musb: Convert interrupt handling to usb_gadget_generic_ops

2024-06-18 Thread Mattijs Korpershoek
efine its own > IRQ handling implementation without colliding with other controller > drivers. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek >

Re: [PATCH 10/11] usb: gadget: sandbox: Drop dm_usb_gadget_handle_interrupts()

2024-06-18 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On ven., juin 14, 2024 at 02:51, Marek Vasut wrote: > Drop dm_usb_gadget_handle_interrupts() in favor of empty default > implementation of the same in drivers/usb/gadget/udc/udc-uclass.c . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs

Re: [PATCH 11/11] usb: gadget: Mark dm_usb_gadget_handle_interrupts as non-weak for DM_USB_GADGET

2024-06-18 Thread Mattijs Korpershoek
by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Alexander Sverdlin > Cc: Felipe Balbi > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Simon Glass > Cc: Thinh Nguyen > Cc: Tom Rini > Cc: u-boot@lists.denx.de > --- > d

Re: [PATCH v3 1/1] usb: informative message if no controller

2024-06-18 Thread Mattijs Korpershoek
> Signed-off-by: Heinrich Schuchardt Reviewed-by: Mattijs Korpershoek > --- > v3: > plural controllers > v2: > add 'found' at end of message > keep printf > --- > drivers/usb/host/usb-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-06-19 Thread Mattijs Korpershoek
Hi Simon. On mar., juin 18, 2024 at 21:03, Simon Glass wrote: > Hi Mattijs, > > On Mon, 17 Jun 2024 at 09:15, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On lun., juin 17, 2024 at 07:53, Simon Glass wrote: >> >> > Hi Mattijs, >>

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-07-04 Thread Mattijs Korpershoek
Hi Tom, On jeu., juin 20, 2024 at 08:23, Tom Rini wrote: > On Thu, Jun 13, 2024 at 12:13:07PM +0200, Mattijs Korpershoek wrote: > >> Android boot flow is a bit different than a regular Linux distro. >> Android relies on multiple partitions in order to boot. >> >>

Re: [PATCH 1/6] usb: gadget: g_dnl: Drop usb_gadget_controller_number()

2024-07-05 Thread Mattijs Korpershoek
Hi, On Sun, 09 Jun 2024 23:32:14 +0200, Marek Vasut wrote: > The bcdDevice field is defined as > |Device release number in binary-coded decimal > in the USB 2.0 specification. We use this field to distinguish the UDCs > from each other. In theory this could be used on the host side to apply > cert

Re: [PATCH 00/11] usb: gadget: Introduce handle_interrupts ops to USB_GADGET_GENERIC uclass

2024-07-05 Thread Mattijs Korpershoek
Hi, On Fri, 14 Jun 2024 02:51:15 +0200, Marek Vasut wrote: > Introduce .ops for USB_GADGET_GENERIC uclass. The first new ops is > .handle_interrupts which must be implemented by DM capable USB gadget > controller drivers and must implement interrupt handling similar to > dm_usb_gadget_handle_inter

<    1   2   3   4   5   6   7   8   9   10   >