On Sat, Feb 25, 2023 at 11:38 AM Simon Glass wrote:
>
> +Masahiro Yamada
I do not know.
This seems a shorthand in Kconfig level.
masahiro@zoe:~/ref/u-boot(master)$ rgrep '^config SPL_' | wc
5401080 24872
masahiro@zoe:~/ref/u-boot(master)$ rgrep '^config TPL_&
On Sun, Feb 26, 2023 at 11:04 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sat, 25 Feb 2023 at 20:31, Masahiro Yamada wrote:
> >
> > On Sat, Feb 25, 2023 at 11:38 AM Simon Glass wrote:
> > >
> > > +Masahiro Yamada
> >
> >
> >
> &
On Sun, Feb 26, 2023 at 11:44 PM Tom Rini wrote:
>
> On Sun, Feb 26, 2023 at 11:32:03PM +0900, Masahiro Yamada wrote:
> > On Sun, Feb 26, 2023 at 11:04 PM Simon Glass wrote:
> > >
> > > Hi Masahiro,
> > >
> > > On Sat, 25 Feb 2023 at 20:31, Masah
Hi Simon,
On Mon, Feb 27, 2023 at 4:23 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sun, 26 Feb 2023 at 10:36, Masahiro Yamada wrote:
> >
> > On Sun, Feb 26, 2023 at 11:44 PM Tom Rini wrote:
> > >
> > > On Sun, Feb 26, 2023 at 11:32:03PM +0900, Mas
Hi Simon,
On Mon, Feb 27, 2023 at 1:00 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sun, 26 Feb 2023 at 20:36, Masahiro Yamada wrote:
> >
> > Hi Simon,
> >
> > On Mon, Feb 27, 2023 at 4:23 AM Simon Glass wrote:
> > >
> > > Hi Masahiro,
>
on the boundary.
We can make the tristate optional if it does not make the code too ugly.
But, if you do not add CONFIG_MODULES in your Kconfig file,
users will not see 'm' in the first place.
I know some help messages still mention 'm', but is this the problem
you want to solve?
> And as Simon asked in the thread, what about code refactoring that makes
> further maintenance easier? Clearly, such patches would need to be
> against the current appropriate tree.
If such patches clean up the code, they will be appreciated.
--
Best Regards
Masahiro Yamada
On Thu, Jun 22, 2023 at 3:41 AM Tom Rini wrote:
>
> On Tue, Jun 06, 2023 at 08:37:42PM +0900, Masahiro Yamada wrote:
>
> > This function is not used by anyone.
> >
> > Signed-off-by: Masahiro Yamada
> > Reviewed-by: Simon Glass
>
> Applied to u-boot/nex
EFI_ZBOOT_MACH_TYPE:= ARM64
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 68d0134bdbf9..4e4364ad641a 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -487,14 +487,26 @@ UIMAGE_OPTS-y ?=
> UIMAGE_TYPE ?= kernel
> UIMAGE_LOADADDR ?= arch_must_set_this
> UIMAGE_ENTRYADDR ?= $(UIMAGE_LOADADDR)
> -UIMAGE_NAME ?= 'Linux-$(KERNELRELEASE)'
> +UIMAGE_NAME ?= "Linux-$(KERNELRELEASE)"
Unneeded noise change.
--
Best Regards
Masahiro Yamada
ep -i 'architecture specific'
finds similar patterns, but presumably we are not
keen on fixing them tree-wide.
--
Best Regards
Masahiro Yamada
ot/blob/v2023.10/doc/usage/fit/source_file_format.rst
[flat-image-tree]
https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter1-introduction.rst
https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter2-source-file-format.rst
--
Best Regards
Masahiro Yamada
evm_a53_defconfig
make -j "$(nproc)" O=build-main CROSS_COMPILE=aarch64-linux-gnu- \
BINMAN_INDIRS="${STAGE}/ti-linux-firmware" \
BL31="${STAGE}/bl31.bin" \
TEE="${STAGE}/tee-raw.bin" \
all
cp build-main/tispl.bin build-main/u-boot.img "${STAGE}"
Strangely, AM62-SK booted successfully,
but AM64-SK failed.
I do not know why.
--
Best Regards
Masahiro Yamada
u-boot.img
=> u-boot and dt are embedded.
$ fdtdump u-boot.img.backup
=> u-boot and dt are appended after the
FIT structure
--
Best Regards
Masahiro Yamada
On Fri, Sep 22, 2023 at 12:03 AM Masahiro Yamada wrote:
>
> Hi.
>
> I am seeing a boot failure on AM64-SK.
>
>
> I got the following error in SPL of the main core.
> Do you have any clue?
As a side-topic, I downloaded a prebuilt image
from https://www.ti.com/tool/SK-AM6
On Fri, Sep 22, 2023 at 2:27 PM Neha Malcom Francis wrote:
>
> Hi Masahiro
>
> On 21/09/23 21:06, Masahiro Yamada wrote:
> > Hi.
> >
> > Since the TI platform migrated to binman,
> > u-boot.img is built twice.
> >
> > It is created by "mkimag
On Fri, Sep 22, 2023 at 5:04 PM Neha Malcom Francis wrote:
>
> Hi Masahiro
>
> On 22/09/23 12:48, Masahiro Yamada wrote:
> > On Fri, Sep 22, 2023 at 2:27 PM Neha Malcom Francis
> > wrote:
> >>
> >> Hi Masahiro
> >>
> >> On 21/09/23 2
On Mon, Sep 25, 2023 at 1:28 PM Vignesh Raghavendra wrote:
>
> Hi,
>
> On 21/09/23 21:52, Masahiro Yamada wrote:
> > On Fri, Sep 22, 2023 at 12:03 AM Masahiro Yamada
> > wrote:
> >>
> >> Hi.
> >>
> >> I am seeing a boot failure on AM6
On Mon, Sep 25, 2023 at 1:24 PM Vignesh Raghavendra wrote:
>
> Hi Masahiro,
>
> On 21/09/23 20:33, Masahiro Yamada wrote:
> > Hi.
> [...]
>
> > spl: mmc boot mode: fs
> > Found FIT
> > Error reading cluster
> > fit read sector 0, sectors=985528, ds
s because applying
an overlay does not change the compatible string.
With this code in arch/arm64/boot/dts/ti/Makefile:
k3-am642-tqma64xxl-mbax4xxl-sdcard-dtbs := \
k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo
k3-am642-tqma64xxl-mbax4xxl-wlan-dtbs := \
k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-wlan.dtbo
$ fdtdump arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl-sdcard.dtb
2>/dev/null| head -n15 | tail -n2
model = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
compatible = "tq,am642-tqma6442l-mbax4xxl", "tq,am642-tqma6442l",
"ti,am642";
$ fdtdump arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl-wlan.dtb
2>/dev/null| head -n15 | tail -n2
model = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
compatible = "tq,am642-tqma6442l-mbax4xxl", "tq,am642-tqma6442l",
"ti,am642";
These two go into image.fit, but one of them is completely dead
since there is no way to distinguish them.
$ fdtdump arch/arm64/boot/image.fit
...
conf-10 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-10";
kernel = "kernel";
};
...
conf-25 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-25";
kernel = "kernel";
};
I agree with Chen-Yu.
FIT should not include full DTBs.
Bootloaders should assemble the final DTB
from base and overlays on-the-fly.
The FIT spec allows the "fdt" property to list
multiple image nodes.
o config-1
|- description = "configuration description"
|- kernel = "kernel sub-node unit name"
|- fdt = "fdt sub-node unit-name" [, "fdt overlay sub-node unit-name", ...]
|- loadables = "loadables sub-node unit-name"
|- script = "
|- compatible = "vendor
>
> ChenYu
>
>
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> > ge...@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like
> > that.
> > -- Linus Torvalds
--
Best Regards
Masahiro Yamada
On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada wrote:
>
> On Thu, Dec 14, 2023 at 1:03 PM Chen-Yu Tsai wrote:
> >
> > On Sun, Dec 10, 2023 at 1:31 AM Geert Uytterhoeven
> > wrote:
> > >
> > > Hi Laurent,
> > >
> > > On Sat, Dec 9, 2
On Fri, Dec 29, 2023 at 3:39 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Thu, Dec 14, 2023 at 7:34 AM Masahiro Yamada wrote:
> >
> > On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada
> > wrote:
> > >
> > > On Thu, Dec 14, 2023 at 1:03 PM Che
t; > one.
>
> Any thoughts on this request, please?
>
> Regards,
> Simon
>
As I mentioned before, I am concerned with having
the same "compatible" entries, with different contents,
as you use the "compatible" string as an ID to selecting
the target config node, right?
$ fdtdump arch/arm64/boot/image.fit
...
conf-10 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-10";
kernel = "kernel";
};
...
conf-25 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-25";
kernel = "kernel";
};
--
Best Regards
Masahiro Yamada
On Fri, Jan 26, 2024 at 1:04 AM Simon Glass wrote:
>
> Hi,
>
> On Wed, 17 Jan 2024 at 06:14, Simon Glass wrote:
> >
> > Hi Masahiro, Tom,
> >
> > On Tue, 9 Jan 2024 at 07:33, Tom Rini wrote:
> > >
> > > On Tue, Jan 09, 2024 at 11:
On Thu, Feb 1, 2024 at 7:03 AM Rob Herring wrote:
>
> On Tue, Jan 30, 2024 at 3:16 AM Masahiro Yamada wrote:
> >
> > On Fri, Jan 26, 2024 at 1:04 AM Simon Glass wrote:
> > >
> > > Hi,
> > >
> > > On Wed, 17 Jan 2024 at 06:14
-n "$(UIMAGE_NAME)" -d $< $@
scripts/Makefile.lib: --name "$(UIMAGE_NAME)" \
You quoted the definition of UIMAGE_NAME,
and also variable references.
See how it is expanded.
--name "$(UIMAGE_NAME)"
==>
--name ""Linux-$(KERNELRELEASE)""
==>
--name Linux-$(KERNELRELEASE)
You added double quotes in a row, just to cancel it.
--
Best Regards
Masahiro Yamada
gt; +
> +Returns:
> +tuple:
> +str: Model name
> +bytes: Compatible stringlist
> +"""
> +with fsw.add_node(f'fdt-{seq}'):
> +# Get the compatible / model information
> + with open(fname, 'rb') as inf:
> +data = inf.read()
> +fdt = libfdt.FdtRo(data)
> +model = fdt.getprop(0, 'model').as_str()
> +compat = fdt.getprop(0, 'compatible')
> +
> +fsw.property_string('description', model)
> +fsw.property_string('type', 'flat_dt')
> +fsw.property_string('arch', 'arm64')
Why hard-code 'arm64' ?
--
Best Regards
Masahiro Yamada
Hi Simon,
On Tue, Nov 7, 2023 at 3:11 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Tue, 7 Nov 2023 at 03:13, Masahiro Yamada wrote:
> >
> > On Sat, Nov 4, 2023 at 9:42 PM Simon Glass wrote:
> > >
> > > The use of single quotes in the image nam
lt; $@
>
> # XZ
> # ---
> --
> 2.42.0.869.gea05f2083d-goog
>
--
Best Regards
Masahiro Yamada
s):
> +"""Build the FIT from the provided files and arguments
> +
> +Args:
> +args (Namespace): Program arguments
> +
> +Returns:
> +tuple:
> +bytes: FIT data
> +int: Number of configurations generated
> +size: Total uncompressed size of data
> +"""
> +fsw = libfdt.FdtSw()
> +setup_fit(fsw, args.name)
> +seq = 0
> +size = 0
> +entries = []
> +
> +# Handle the kernel
> +with open(args.kernel, 'rb') as inf:
> +comp_data = compress_data(inf, args.compress)
> +size += os.path.getsize(args.kernel)
> +write_kernel(fsw, comp_data, args)
> +
> +for path in args.srcdir:
> +# Handle devicetree files
> +if os.path.isdir(path):
> +for dirpath, _, fnames in os.walk(path):
> +for fname in fnames:
> +if os.path.splitext(fname)[1] != '.dtb':
> +continue
> +pathname = os.path.join(dirpath, fname)
> +seq += 1
> +size += os.path.getsize(pathname)
> +model, compat = output_dtb(fsw, seq, pathname,
> + args.arch, args.compress)
> +entries.append([model, compat])
> +
> +finish_fit(fsw, entries)
> +
> +# Include the kernel itself in the returned file count
> +return fsw.as_fdt().as_bytearray(), seq + 1, size
> +
> +
> +def run_make_fit():
> +"""Run the tool's main logic"""
> +args = parse_args()
> +
> +out_data, count, size = build_fit(args)
> +with open(args.fit, 'wb') as outf:
> +outf.write(out_data)
> +
> +ext_fit_size = None
> +if args.external:
> +mkimage = os.environ.get('MKIMAGE', 'mkimage')
> +subprocess.check_call([mkimage, '-E', '-F', args.fit],
> + stdout=subprocess.DEVNULL)
> +
> +with open(args.fit, 'rb') as inf:
> +data = inf.read()
> +ext_fit = libfdt.FdtRo(data)
> +ext_fit_size = ext_fit.totalsize()
> +
> +comp_size = len(out_data)
> +print(f'FIT size {comp_size:#x}/{comp_size / 1024 / 1024:.1f} MB',
> end='')
> +if ext_fit_size:
> +print(f', header {ext_fit_size:#x}/{ext_fit_size / 1024:.1f} KB',
> end='')
> +print(f', {count} files, uncompressed {size / 1024 / 1024:.1f} MB')
> +
> +
> +if __name__ == "__main__":
> +sys.exit(run_make_fit())
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
--
Best Regards
Masahiro Yamada
efi: vmlinux
> +$(BOOT_TARGETS): vmlinux
> $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
>
> Image.%: Image
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
--
Best Regards
Masahiro Yamada
f
> >
> > +KBUILD_DTBS := dtbs
>
> Might you want to use tabs here as in the lines below?
This should not exist in the first place.
image.fit: dtbs
is better.
--
Best Regards
Masahiro Yamada
>
> +$(obj)/image.fit: $(obj)/Image FORCE
> + $(call cmd,fit,gzip)
The gzip parameter is not used.
Please do
$(call cmd,fit)
In the python script, functions are separated with two blank lines,
but there is only one blank line between parse_args() and setup_fit().
I do not mind either way because it does not contain any class,
but please keep consistency.
--
Best Regards
Masahiro Yamada
On Fri, Dec 1, 2023 at 5:34 AM Simon Glass wrote:
>
> Add a script which produces a Flat Image Tree (FIT), a single file
> containing the built kernel and associated devicetree files.
> Compression defaults to gzip which gives a good balance of size and
> performance.
>
> The files compress from a
On Sat, Dec 2, 2023 at 3:09 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Fri, 1 Dec 2023 at 10:30, Masahiro Yamada wrote:
> >
> > On Fri, Dec 1, 2023 at 5:34 AM Simon Glass wrote:
> > >
> > > Add a script which produces a Flat Image Tree (FIT), a sin
On Fri, Feb 2, 2024 at 6:03 AM Rob Herring wrote:
>
> On Wed, Jan 31, 2024 at 8:09 PM Masahiro Yamada wrote:
> >
> > On Thu, Feb 1, 2024 at 7:03 AM Rob Herring wrote:
> > >
> > > On Tue, Jan 30, 2024 at 3:16 AM Masahiro Yamada
> > > wrote:
> >
1:14 +0900)
UniPhier SoC updates for v2020.10 (2nd)
- minor code cleanups
- sync DT with Linux
----
Masahiro Yamada (6):
ARM: uniphier: rename include guard of include/configs/uniphier.h
ARM: uniphier: rem
I am leaving Socionext. Orphan the UniPhier platform until somebody
takes the role.
Signed-off-by: Masahiro Yamada
---
MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bebe87b4d1..101f4e185d 100644
--- a/MAINTAINERS
+++ b
ini wrote:
> > > >
> > > > On Mon, Apr 27, 2020 at 09:37:28AM +0800, Bin Meng wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Sat, Apr 18, 2020 at 8:37 PM Bin Meng wrote:
> > > > > >
> > > > >
Add -Werror=implicit-function-declaration as Linux does.
If you do not check the prototype, it may go wrong run-time.
It is better to break the build, and require to include correct
headers.
Signed-off-by: Masahiro Yamada
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion
pulls in a lot of bloat. is unneeded in most of
places.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/arm32/cache-uniphier.c | 1 -
arch/arm/mach-uniphier/arm32/psci.c | 1 -
arch/arm/mach-uniphier/arm32/timer.c | 2 +-
arch/arm/mach
drivers/net/smc911x.c has been converted to DM.
select DM_ETH to enable it for all the UniPhier platform boards.
Signed-off-by: Masahiro Yamada
---
arch/arm/Kconfig| 1 +
configs/uniphier_ld4_sld8_defconfig | 1 -
configs/uniphier_v7_defconfig | 1 -
configs
when the system
is booting from the NAND device, so the NAND device becomes read-only.
Set it to 1 in the driver in order to allow the write access to the
device.
Signed-off-by: Masahiro Yamada
Signed-off-by: Miquel Raynal
---
drivers/mtd/nand/raw/denali.c | 1 +
1 file changed, 1 inse
On Fri, May 8, 2020 at 10:39 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Thu, 7 May 2020 at 06:21, Masahiro Yamada
> wrote:
> >
> > Add -Werror=implicit-function-declaration as Linux does.
> >
> > If you do not check the prototype, it may go wrong run-ti
Hi Simon,
On Fri, May 8, 2020 at 10:37 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Thu, 7 May 2020 at 07:10, Masahiro Yamada
> wrote:
> >
> > pulls in a lot of bloat. is unneeded in most of
> > places.
> >
> > Signed-off-by: Masahiro Yamada
On Fri, May 8, 2020 at 11:41 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Thu, 7 May 2020 at 20:31, Masahiro Yamada wrote:
> >
> > Hi Simon,
> >
> >
> > On Fri, May 8, 2020 at 10:37 AM Simon Glass wrote:
> > >
> > > Hi Masahi
On Sat, May 9, 2020 at 3:16 AM Tom Rini wrote:
>
> On Thu, May 07, 2020 at 09:16:40PM -0600, Simon Glass wrote:
> > Hi Masahiro,
> >
> > On Thu, 7 May 2020 at 19:54, Masahiro Yamada wrote:
> > >
> > > On Fri, May 8, 2020 at 10:39 AM Simon
break;
> @@ -1148,7 +1151,7 @@ static void scan_args(struct display_info *disp, int
> argc, char *argv[])
> break;
> case 'P':
> inc = 0;
> - /* no break */
> + /* fallthrough */
> case 'p':
> type = FDT_IS_PROP;
> break;
> --
> 2.26.2
>
--
Best Regards
Masahiro Yamada
Hi Simon,
On Mon, May 11, 2020 at 5:37 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sat, 9 May 2020 at 05:00, Masahiro Yamada wrote:
> >
> > On Sat, May 9, 2020 at 3:16 AM Tom Rini wrote:
> > >
> > > On Thu, May 07, 2020 at 09:16:40PM -06
common.h
> @@ -177,6 +177,6 @@ struct bl2_to_bl31_params_mem {
> struct entry_point_info bl31_ep_info;
> };
>
> -#endif /*__ASSEMBLY__*/
> +#endif /*__ASSEMBLY__ */
>
> #endif /* __BL_COMMON_H__ */
> diff --git a/include/elf.h b/include/elf.h
> index e7c51986df..b04e746d61 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -9,7 +9,7 @@
> #ifndef _ELF_H
> #define _ELF_H
>
> -#ifndef __ASSEMBLER__
> +#ifndef __ASSEMBLY__
> #include "compiler.h"
>
> /* This version doesn't work for 64-bit ABIs - Erik */
> @@ -690,7 +690,7 @@ unsigned long elf_hash(const unsigned char *name);
> #define R_RISCV_64 2
> #define R_RISCV_RELATIVE 3
>
> -#ifndef __ASSEMBLER__
> +#ifndef __ASSEMBLY__
> int valid_elf_image(unsigned long addr);
> unsigned long load_elf64_image_phdr(unsigned long addr);
> unsigned long load_elf64_image_shdr(unsigned long addr);
> --
> 2.26.2.645.ge9eca65c58-goog
>
--
Best Regards
Masahiro Yamada
On Mon, May 11, 2020 at 3:44 PM Masahiro Yamada wrote:
>
> Simon,
>
> On Mon, May 11, 2020 at 7:58 AM Simon Glass wrote:
> >
> > Move this uncommon header out of the common header.
> >
> > Signed-off-by: Simon Glass
>
>
> Why are you adding to
>
is thread, I'll start
> > another). But it's very far from zero size change and given the inline
> > changes I think it'll need real testing.
> >
> > And since the kernel isn't making a huge use yet of fallthrough; we can
> > afford to look a little harder at things.
>
> I think I've figured out the inline issue which is that we need
> scripts/Kconfig.include from the kernel, CC_HAS_ASM_INLINE Kconfig
> option, and re-sync with Kconfiglib, but that's still going to be enough
> stuff that I don't think it's good to pull in at -rc2.
>
I do not get how 'asm inline' support is related
to this topic.
GCC 9 started to support 'asm inline' for the better inlining heuristic.
The kernel uses a bunch of inline assembly
that is not as expensive as it looks.
As GCC is agnostic about the real cost of inline assembly,
'asm inline' is a good hint if people know the real cost is quite small.
Then, GCC will be able to inline more functions.
I do not know how important it is for U-Boot, though.
What is causing you a trouble?
--
Best Regards
Masahiro Yamada
On Thu, May 14, 2020 at 1:13 AM Tom Rini wrote:
>
> On Thu, May 14, 2020 at 01:05:37AM +0900, Masahiro Yamada wrote:
> > Hi Tom,
> >
> > On Wed, May 13, 2020 at 11:42 PM Tom Rini wrote:
> > >
> > > On Tue, May 12, 2020 at 11:04:38PM -0400, Tom Rini wr
This code dates back to 2006, commit 483a0cf804df ("Fixes for gcc 3.4
based m68k toolchain,").
GCC 3.4 is so old. We do not support it.
Signed-off-by: Masahiro Yamada
---
Makefile | 7 ---
1 file changed, 7 deletions(-)
diff --git a/Makefile b/Makefile
index a9d58ca7a0..97fd492
| 523 +--
> drivers/net/smc911x.h| 157
> examples/standalone/Makefile | 5 +-
> examples/standalone/smc911x_eeprom.c | 150 ++++
> 5 files changed, 577 insertions(+), 260 deletions(-)
>
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
>
> --
> 2.25.0
>
--
Best Regards
Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote:
>
> Replace combination of malloc()+memset() with calloc() as the behavior
> is exactly the same and the amount of code is reduced.
>
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
> ---
>
gned-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
> ---
> drivers/net/smc911x.c | 14 +++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 81f8f0d017..44cb45af61 10
e DM EEPROM
> interface and the standalone example would use that.
>
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
> ---
--
Best Regards
Masahiro Yamada
n decide better.
>
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
This is good.
I would swap the patch order 06 and 07 so that
I would need to touch only one file, though.
> ---
> drivers/net/smc911x.c| 14 --
> examp
On Mon, Mar 16, 2020 at 2:01 AM Marek Vasut wrote:
>
> Invest the status handling logic in smc911x_recv(), to make the
> function easier to read, no functional change.
>
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
> ---
>
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote:
>
> These accessors are not overriden by any board, and even if they were,
One more nit.
overriden -> overridden
--
Best Regards
Masahiro Yamada
On Mon, Mar 16, 2020 at 2:01 AM Marek Vasut wrote:
>
> Add support for U-Boot DM and DT probing. Furthermore, build the
> SMC911x standalone EEPROM example only for the non-DM case, as it
> is not converted yet.
>
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
/standalone/smc911x_eeprom.c
Yeah, I was disturbed by this example code.
I agree we should drop it.
Reviewed-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
> Signed-off-by: Marek Vasut
> Cc: Joe Hershberger
> Cc: Masahiro Yamada
> ---
> V2: - Use kzalloc()
> - Return -ENOMEM on alloc fail
> ---
> drivers/net/smc911x.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/smc9
rc1.
The gcc-plugin is the only user of the shared library support.
So, probably it should be moved to scripts/gcc-plugins/Makefile.
It may take more time for U-Boot to catch up,
but U-Boot can cope with it somehow, I think.
> Cc: Masahiro Yamada
Please feel free to replace Cc with:
Reviewed-by: Masahiro Yamada
Thanks!
--
Best Regards
Masahiro Yamada
y miss adding
the objects to the 'targets'.
Somebody had broken the build system?
--
Best Regards
Masahiro Yamada
'git grep' did not find any user of this stub.
Signed-off-by: Masahiro Yamada
---
arch/x86/include/asm/u-boot-x86.h | 2 --
arch/x86/lib/zimage.c | 10 --
2 files changed, 12 deletions(-)
diff --git a/arch/x86/include/asm/u-boot-x86.h
b/arch/x86/include/asm/u-
at EL2
instead of EL1, and this issue does not happen:
|commit f998a052fd94ea082833109f25b94ed5bfa24e8b
|Author: Masahiro Yamada
|Date: Thu Jul 25 10:57:38 2019 +0900
|
|uniphier: run BL33 at EL2
|
|All the SoCs in 64-bit UniPhier SoC family support EL2.
|
|Just hard-code MODE_EL2
Hi.
On Mon, Jun 29, 2020 at 12:29 AM Masahiro Yamada wrote:
>
> On Wed, Jun 24, 2020 at 11:07 AM Volodymyr Babchuk
> wrote:
> >
> > ARM Architecture reference manual clearly states that PE pipeline
> > should be flushed after any change to system registers. Refer to
&
Simon,
On Tue, Jul 7, 2020 at 3:44 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sat, 4 Jul 2020 at 11:43, Masahiro Yamada wrote:
> >
> > 'git grep' did not find any user of this stub.
> >
> > Signed-off-by: Masahiro Yamada
> > ---
> >
On Mon, Jul 6, 2020 at 1:33 PM Masahiro Yamada
wrote:
>
> Hi.
>
> On Mon, Jun 29, 2020 at 12:29 AM Masahiro Yamada wrote:
> >
> > On Wed, Jun 24, 2020 at 11:07 AM Volodymyr Babchuk
> > wrote:
> > >
> > > ARM Architecture reference manual clearly
CONFIG_SPL=y.
Instead of using crappy CONFIG options, checking SPL and SPL_TEXT_BASE
is cleaner.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Kconfig | 33 +
configs/uniphier_ld4_sld8_defconfig | 1 -
2 files changed, 15 insertions(+), 19 deletions
If CONFIG_MICRO_SUPPORT_CARD is unset, the build fails due to
function redefinition.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/sbc/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-uniphier/sbc/Makefile
b/arch/arm/mach-uniphier/sbc/Makefile
index
at EL2
instead of EL1, and this issue went away as a side-effect.
|commit f998a052fd94ea082833109f25b94ed5bfa24e8b
|Author: Masahiro Yamada
|Date: Thu Jul 25 10:57:38 2019 +0900
|
|uniphier: run BL33 at EL2
|
|All the SoCs in 64-bit UniPhier SoC family support EL2.
|
|Just hard-code
Move the bus initialization code to this driver from board files.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/board_init.c | 12 --
arch/arm/mach-uniphier/init.h | 23 ---
arch/arm/mach-uniphier/micro-support-card.c | 13 +-
arch/arm/mach-uniphier/sbc
Signed-off-by: Masahiro Yamada
---
arch/arm/dts/uniphier-ld11-global.dts | 1 +
arch/arm/dts/uniphier-ld11-ref.dts| 1 +
arch/arm/dts/uniphier-ld11.dtsi | 16 +++-
arch/arm/dts/uniphier-ld20-global.dts | 1 +
arch/arm/dts/uniphier-ld20-ref.dts| 1 +
arch/arm/dts/uniphier
o the this driver).
I put this to drivers/bus/uniphier-system-bus.c because this is the
same path as the driver in Linux kernel.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Kconfig| 1 +
drivers/Kconfig | 2 ++
drivers/Makefile | 1 +
d
Now that this directory contains only uniphier_sbc_boot_is_swapped(),
move it to boot-device.c and delete the sbc/ directory entirely.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Makefile | 1 -
arch/arm/mach-uniphier/boot-device/boot-device.c | 9
This was used by the old sLD3 SoC, the support of which was removed
by commit 00aa453ebf56 ("ARM: uniphier: remove sLD3 SoC support").
There is no more user of this function.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/init.h| 5 -
arch/arm/mach-uniphier/sbc/
R_LEN even more, the SPL stack must be
moved somewhere. I put it back to the original location prior to
commit 3ce5b1a8d86d.
With this change, there is no more practical size limit.
Signed-off-by: Masahiro Yamada
---
include/configs/uniphier.h | 4 ++--
1 file changed, 2 insertions(+), 2 dele
I actually do not see this used these days because eMMC or NAND is used
for non-volatile devices. Dump the burden to maintain this crappy code.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/board_init.c | 4 -
arch/arm/mach-uniphier/micro-support-card.c | 97
This UART controller is integrated with a FIFO. Enable it.
You can put the next character into the FIFO while the transmitter
is sending out the current character. This works slightly faster.
Signed-off-by: Masahiro Yamada
---
drivers/serial/serial_uniphier.c | 7 +++
1 file changed, 7
Ensure the transmitter is empty when chaining the baudrate or any
hardware settings. If a character is remaining in the transmitter,
the console will be garbled.
Signed-off-by: Masahiro Yamada
---
drivers/serial/serial_uniphier.c | 8
1 file changed, 8 insertions(+)
diff --git a
After all, I am not a big fan of using a structure to represent the
hardware register map.
You do not need to know the entire register map.
Add only necessary register macros.
Use FIELD_PREP() instead of maintaining a pair of shift and mask.
Signed-off-by: Masahiro Yamada
---
drivers/serial
*/
> - udelay(200);
> + ret = denali_wait_reset_complete(denali);
> + if (ret) {
> + dev_err(denali->dev, "reset not completed.\n");
> + return ret;
> + }
>
%d\n", ret);
> } else {
> + reset_assert_bulk(&resets);
> + udelay(2);
> reset_deassert_bulk(&resets);
>
> /*
Tested-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
n
> (rst_comp) bit after reset.
>
> Tested-by: Masahiro Yamada
> Signed-off-by: Radu Bacrau
> Signed-off-by: Ley Foon Tan
I will include this in my next pull request.
Applied.
Thanks.
--
Best Regards
Masahiro Yamada
has completed its reset and initialization process.
>
> Tested-by: Masahiro Yamada
> Signed-off-by: Radu Bacrau
> Signed-off-by: Ley Foon Tan
>
> ---
> v2:
> - Added "Tested-by" in commit message.
> - Restore "bootstrap process" in comment.
> ---
Now that commit fceee65c878c ("mtd: nand: raw: denali: Assert reset
before deassert") added the reset assertion, this code in the board
file is unneeded.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Makefile | 1 -
arch/arm/mach-uniphier/board_init.c | 4 ---
arc
On Thu, Jul 9, 2020 at 3:09 PM Masahiro Yamada
wrote:
>
> This reverts commit 45f41c134baf5ff1bbf59d33027f6c79884fa4d9.
>
> This weird workaround was the best I came up with at that time
> to boot U-Boot from TF-A.
>
> I noticed U-Boot successfully boots on LD20 (i.e. CA7
On Fri, Jul 10, 2020 at 10:32 PM Masahiro Yamada
wrote:
>
> Now that commit fceee65c878c ("mtd: nand: raw: denali: Assert reset
> before deassert") added the reset assertion, this code in the board
> file is unneeded.
>
> Signed-off-by: Masahiro Yamada
>
On Fri, Jul 10, 2020 at 1:13 AM Masahiro Yamada
wrote:
>
> After all, I am not a big fan of using a structure to represent the
> hardware register map.
>
> You do not need to know the entire register map.
>
> Add only necessary register macros.
>
> Use FIELD_PREP() in
AND driver
Ley Foon Tan (2):
mtd: nand: raw: denali: Assert reset before deassert
mtd: nand: raw: denali: Wait for reset completion status
Masahiro Yamada (14):
Revert "ARM: uniphier: add weird workaround code for LD20"
ARM: uniphier: increase CONFIG_SYS_MONITOR_
This function is only called from fdt_fixup_mtdpart() in the same file.
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3778de536866..b010d0b552ad 100644
--- a
_find().
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index b010d0b552ad..717b2b6354c0 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -951,9 +951,7 @@
Currently, fdt_fixup_mtdparts() only checks the compatible property.
It is pointless to fix up the disabled node.
Skip the node if it has the property:
status = "disabled"
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 17 ++---
1 file changed, 10 insert
On Fri, Jul 17, 2020 at 12:44 AM Simon Glass wrote:
>
> On Wed, 15 Jul 2020 at 04:57, Masahiro Yamada
> wrote:
> >
> > Currently, fdt_fixup_mtdparts() only checks the compatible property.
> > It is pointless to fix up the disabled node.
> >
> &g
_find().
Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
---
Changes in v2:
- rename 'initialized' to 'inited'
common/fdt_support.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3778
Currently, fdt_fixup_mtdparts() only checks the compatible property.
It is pointless to fix up the disabled node.
Skip the node if it has the property:
status = "disabled"
Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
---
(no changes since v1)
common/fdt_supp
(dev)
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-snapdragon/clock-snapdragon.c | 2 +-
arch/arm/mach-snapdragon/pinctrl-snapdragon.c| 2 +-
drivers/ata/dwc_ahci.c | 2 +-
drivers/clk/altera/clk-agilex.c | 2 +-
drivers/clk/altera/clk
-name '*.[ch]' -type f -print | \
xargs sed -i -e 's/([^*)]*\*)devfdt_get_addr(/dev_read_addr_ptr(/'
I manually fixed drivers/usb/host/ehci-mx6.c
Signed-off-by: Masahiro Yamada
---
drivers/adc/exynos-adc.c| 2 +-
drivers/clk/renesas/clk-rcar-gen2.c
This cast is unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/net/fec_mxc.c | 2 +-
drivers/net/fsl_mcdmafec.c| 2 +-
drivers/net/mcffec.c | 2 +-
drivers/net/xilinx_axi_emac.c | 2 +-
drivers/net/xilinx_emaclite.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions
1 - 100 of 6341 matches
Mail list logo
