Re: [PATCH 1/2] tpm: core: Set timeouts before requesting locality

2022-05-18 Thread Joel Stanley
On Fri, 13 May 2022 at 18:30, Eddie James wrote: > > Requesting the locality uses the timeout values, so they need > to be set beforehand. > > Signed-off-by: Eddie James Reviewed-by: Joel Stanley > --- > drivers/tpm/tpm2_tis_core.c | 7 --- > 1 file changed, 4 in

Re: [PATCH] i2c: ast_i2c: Remove SCL direct drive mode

2022-05-18 Thread Joel Stanley
On Wed, 11 May 2022 at 20:52, Eddie James wrote: > > SCL direct drive mode prevents communication with devices that > do clock stretching, so disable. The Linux driver doesn't use > this mode, and the engine can handle clock stretching. > > Signed-off-by: Eddie James Re

[PATCH] MAINTAINERS: aspeed: Add more files and myself as a reviewer

2022-05-18 Thread Joel Stanley
stay informed about u-boot changes. Signed-off-by: Joel Stanley --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56be0bfad00c..28e4d3823861 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -169,12 +169,23 @@ ARM ASPEED M: Ryan Chen

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-27 Thread Joel Stanley
On Mon, 23 May 2022 at 13:25, Ilias Apalodimas wrote: > > On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote: > > Yes, I think so. I tested with an older u-boot (openbmc uses a modified > > v2019.04) with all the TPM core patches, and I think I missed this bit in > > rebasing. > > No worr

Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl

2022-06-01 Thread Joel Stanley
On Wed, 1 Jun 2022 at 16:10, Eddie James wrote: > > Set the pinctrl groups for each I2C bus. These are essential to > I2C operating correctly. > > Signed-off-by: Eddie James Reviewed-by: Joel Stanley Thanks Eddie. > --- > arch/arm/dts/ast2600.dtsi | 33 +

[PATCH] Makefile: Silence new GNU linker warnings

2022-08-02 Thread Joel Stanley
-by: Joel Stanley --- This behaviour can be seen when building with binutils 2.38.90.20220713-2 from Debian testing. Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ff25f9297486..32aac7493f8d 100644 --- a/Makefile +++ b/Makefile @@ -432,7

Re: [PATCH v2] gpio: aspeed: port Linux dt-bindings header file

2022-08-03 Thread Joel Stanley
On Thu, 4 Aug 2022 at 01:02, Dhananjay Phadke wrote: > > Ported as is, makes it easier to add readable GPIO definitions > in DTS files. > > Signed-off-by: Dhananjay Phadke > --- > include/dt-bindings/gpio/aspeed-gpio.h | 49 ++ > 1 file changed, 49 insertions(+) > create

Re: [PATCH v3 0/3] Enable NC-SI support

2022-08-04 Thread Joel Stanley
On Mon, 4 Jul 2022 at 07:58, Joel Stanley wrote: > > Back in 2019 Sam submitted NC-SI support. The NC-SI PHY driver was > merged (patches 1 and 2), but we never got around to merging patches 3 > and 4: > > https://lore.kernel.org/u-boot/20190618013720.2823-1-...@mendozajonas.co

Re: [PATCH] Makefile: Silence new GNU linker warnings

2022-08-05 Thread Joel Stanley
On Tue, 2 Aug 2022 at 10:45, Heinrich Schuchardt wrote: > > On 8/2/22 10:30, Joel Stanley wrote: > > The next version of the linker will complain about rwx segments with > > permissions and executable stacks: > > > > > > https://sourceware.or

Re: [PATCH v3 1/3] net: NC-SI setup and handling

2022-08-07 Thread Joel Stanley
On Sat, 6 Aug 2022 at 23:54, Ramon Fried wrote: > > On Mon, Jul 4, 2022 at 11:20 AM Cédric Le Goater wrote: > > > > On 7/4/22 09:58, Joel Stanley wrote: > > > From: Samuel Mendoza-Jonas > > > > > > Add the handling of NC-SI ethernet frames, and ad

[PATCH v4 0/4] net: Enable NC-SI support

2022-08-08 Thread Joel Stanley
has been in use in the vendor fork for some time. This refreshes his patches and enables support in the Aspeed defconfigs, giving compile coverage to the NC-SI phy. v4 splits the ncsi integration and cmd code into separate patches, and adds r-b from Ramon and Cédric to patches 3 and 4. Joel Stanley

[PATCH v4 1/4] net: NC-SI setup and handling

2022-08-08 Thread Joel Stanley
From: Samuel Mendoza-Jonas Add the handling of NC-SI ethernet frames, and add a check at the start of net_loop() to configure NC-SI before starting other network commands. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- v4: split out cmd addition into a separate patch v3

[PATCH v4 2/4] cmd: Add ncsi command

2022-08-08 Thread Joel Stanley
From: Samuel Mendoza-Jonas Adds an "ncsi" command to manually start NC-SI configuration. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- v4: New patch, split from patch 1 cmd/net.c | 22 ++ net/net.c | 1 + cmd/Kconfig | 8 +++

[PATCH v4 3/4] net/ftgmac100: Add NC-SI mode support

2022-08-08 Thread Joel Stanley
setup is skipped in favour of the NC-SI phy. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Reviewed-by: Ramon Fried --- v4: Add r-b from Cédric and Ramon v3: - Simplify ncsi enable by re-using pdata->phy_interface parsing. use-ncsi st

[PATCH v4 4/4] config/aspeed: Enable NC-SI support

2022-08-08 Thread Joel Stanley
Aspeed BMCs are commonly used with NC-SI. A system indicates the driver should configure the link over NC-SI using the device tree. Add it to the defconfig so we get compile coverage of the driver, even if the EVBs do not normally use it. Signed-off-by: Joel Stanley Reviewed-by: Ramon Fried

Re: [u-boot, v2019.04-aspeed, v1 0/1] Common:fdt: Check for error return

2020-12-02 Thread Joel Stanley
Hello Hongwei, On Wed, 2 Dec 2020 at 19:48, Hongwei Zhang wrote: > > Hello Reviewer, > > Check for negative return value of fdt_noffset from calling > boot_get_fdt_fit(). Otherwise, when fdt subimage is corrupted, the > u-boot report bad hash value but continue loading kernel image and > get hang

Re: [u-boot, v2019.04-aspeed, v1 0/1] Common:fdt: Check for error return

2020-12-07 Thread Joel Stanley
On Thu, 3 Dec 2020 at 19:11, Hongwei Zhang wrote: > > Thanks Joel, > > > From: Joel Stanley > > Sent: Wednesday, December 2, 2020 9:17 PM > > To: Hongwei Zhang > > > > Hello Hongwei, > > > > On Wed, 2 Dec 2020 at 19:48, Hongwei Zhang wrote

Re: [PATCH 2/3] image-cipher: Fix FIT_CIPHER linking

2020-12-07 Thread Joel Stanley
ons image_set_host_blob and > image_get_host_blob are defined twice. > So it is a NAK for me. > > A simple way to fix it to move this block of code from image-fit-sig.c > to iamge-fit.c Agreed, that is a better idea. I'll send a v2. > > Regards, > Philippe >

Re: [PATCH 3/3] mkimge: Reject signing-related flags without FIT_SIGNATURE

2020-12-07 Thread Joel Stanley
e is disabled. > But I think that this help is not correct. If the signature is disabled, > the padding is still available. > So I think that we have an issue in the help too. > > Regards, > Philippe > > Le 11/11/2020 à 12:18, Joel Stanley a écrit : > > When CONFI

[PATCH v2 0/4] mkimage usability fixes

2020-12-07 Thread Joel Stanley
ing the third patch under sandbox_defconfig with FIT_SIGNATURE=n. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972513 Joel Stanley (4): tools/Makefile: FIT_CIPHER requires libssl image-fit: Fix FIT_CIPHER linking mkimage: Move padding commands outside of FIT_SIGNATURE mkimge: Rej

[PATCH v2 1/4] tools/Makefile: FIT_CIPHER requires libssl

2020-12-07 Thread Joel Stanley
erence to `EVP_EncryptUpdate' /usr/bin/ld: aes-encrypt.c:(.text+0xac): undefined reference to `EVP_CIPHER_CTX_free' /usr/bin/ld: aes-encrypt.c:(.text+0xf2): undefined reference to `EVP_EncryptFinal_ex' collect2: error: ld returned 1 exit status Signed-off-by: Joel Stanley

[PATCH v2 2/4] image-fit: Fix FIT_CIPHER linking

2020-12-07 Thread Joel Stanley
Move the implementation to a common file so it can be shaed between image-cipher.c and image-fit-sig.c. Signed-off-by: Joel Stanley --- v2: Fix compilation when signature and ciphering are both enabled --- common/image-fit-sig.c | 14 -- common/image-fit.c | 15 ++

[PATCH v2 3/4] mkimage: Move padding commands outside of FIT_SIGNATURE

2020-12-07 Thread Joel Stanley
These commands were disabled when CONFIG_FIT_SIGNATURE is disabled, but they do not depend on crypto support so they can be unconditionally enabled. Signed-off-by: Joel Stanley -- v2: New patch --- tools/mkimage.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 4/4] mkimge: Reject signing-related flags without FIT_SIGNATURE

2020-12-07 Thread Joel Stanley
e the signing related options. Make it obvious that the commands don't work by removing them from the getopt opt_string. $ mkimage -f machine.its -k keys -K u-boot-pubkey.dtb -r image.fit mkimage: invalid option -- 'k' Error: Invalid option Signed-off-by: Joel Stanley -- v2: L

[U-Boot] Unable to boot evb-ast2500

2018-08-05 Thread Joel Stanley
Hello, I am attempting to boot evb-ast2500 in Qemu before flashing it to a system. It doesn't get past the DRAM step, due to getting stuck endlessly looping in some libfdt code. With some debugging turned on, I get this: OF: translating address: 0040781e OF: parent translation for: OF:

Re: [U-Boot] Unable to boot evb-ast2500

2018-08-06 Thread Joel Stanley
On Mon, 6 Aug 2018 at 19:39, Cédric Le Goater wrote: > > On 08/06/2018 05:25 AM, Joel Stanley wrote: > > Hello, > > > > I am attempting to boot evb-ast2500 in Qemu before flashing it to a > > system. It doesn't get past the DRAM step, due to getting stuck > &

Re: [U-Boot] [PATCH v3 01/13] net: ftgmac100: use the BIT() macro

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:12, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 02/13] net: ftgmac100: use the aligned() macro

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:12, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 03/13] net: ftgmac100: convert to driver model

2018-10-11 Thread Joel Stanley
> Configuration is updated to enable compile again. At this stage, the > driver compiles but is not yet functional. Is this commit message still valid? > > Signed-off-by: Cédric Le Goater The code looks good. Reviewed-by: Joel Stanley

Re: [U-Boot] [PATCH v3 04/13] net: ftgmac100: use setbits_le32() in the reset method

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:12, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 05/13] net: ftgmac100: add MDIO bus and phylib support

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:12, Cédric Le Goater wrote: > > Implement the MDIO bus read/write functions using the readl_poll_timeout() > routine, initialize the bus and scan for the PHY. RGMII and RMII mode > are supported. > > Signed-off-by: Cédric Le Goater Reviewe

Re: [U-Boot] [PATCH v3 06/13] net: ftgmac100: convert the RX/TX descriptor arrays

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:13, Cédric Le Goater wrote: > > Use simple arrays under the device priv structure to hold the RX and > TX descriptors and handle memory coherency by invalidating or flushing > the d-cache when required. > > Signed-off-by: Cédric Le Goater Reviewe

Re: [U-Boot] [PATCH v3 07/13] net: ftgmac100: handle timeouts when transmitting

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:13, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 08/13] net: ftgmac100: add clock support

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:13, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 10/13] net: ftgmac100: Add support for the Aspeed SoC

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:13, Cédric Le Goater wrote: > > The Faraday ftgmac100 MAC controllers as found on the Aspeed SoCs have > some slight differences in the HW interface (End-Of-Rx/Tx-Ring bits). > > Signed-off-by: Cédric Le Goater > Reviewed-by: Simon Glass Reviewe

Re: [U-Boot] [PATCH v3 12/13] aspeed: Activate ethernet devices on the ast2500 Eval Board

2018-10-11 Thread Joel Stanley
On Wed, 10 Oct 2018 at 22:13, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater > Reviewed-by: Simon Glass Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 13/13] aspeed: ast2500: fix D2-PLL clock setting in RGMII mode

2018-10-11 Thread Joel Stanley
ed SoC. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Simon Glass Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] aspeed: Activate ethernet devices on the ast2500 Eval Board

2018-09-10 Thread Joel Stanley
On Mon, 10 Sep 2018 at 23:56, Cédric Le Goater wrote: > diff --git a/arch/arm/dts/ast2500-evb.dts b/arch/arm/dts/ast2500-evb.dts > index 609678ff7989..1bd224dacf78 100644 > --- a/arch/arm/dts/ast2500-evb.dts > +++ b/arch/arm/dts/ast2500-evb.dts > + > +&mac0 { > + status = "okay"; > + > +

Re: [U-Boot] [PATCH 1/3] aspeed: ast2500: Add AHB clock

2018-09-11 Thread Joel Stanley
On Mon, 10 Sep 2018 at 23:48, Cédric Le Goater wrote: > > The AHB clock is used by the FMC/SPI controllers. > > Signed-off-by: Cédric Le Goater > --- > arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 2 ++ > include/dt-bindings/clock/ast2500-scu.h| 1 + > drivers/clk/aspeed/clk_ast250

Re: [U-Boot] [PATCH 2/3] spi: Add support for the Aspeed ast2500 SPI controllers

2018-09-11 Thread Joel Stanley
or the U-Boot SPI > Flash layer which only supports 3 byte addresses. In such a case, a > warning is emitted and the address width is fixed when sent on the > bus. > > Signed-off-by: Cédric Le Goater Looks good. I compared some things against the data sheet, and read throu

Re: [U-Boot] [PATCH 1/3] aspeed: ast2500: Add AHB clock

2018-09-11 Thread Joel Stanley
On Wed, 12 Sep 2018 at 03:13, Cédric Le Goater wrote: > > On 09/11/2018 06:42 PM, Maxim Sloyko wrote: > > > > > > On Tue, Sep 11, 2018 at 12:35 AM, Joel Stanley > <mailto:j...@jms.id.au>> wrote: > > > > On Mon, 10 Sep 2018 at 23:48, C

Re: [U-Boot] [PATCH 3/5] aspeed: ast2500: fix missing break in D2PLL clock enablement

2018-09-12 Thread Joel Stanley
On Mon, 10 Sep 2018 at 23:54, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 4/5] net: ftgmac100: add support for Aspeed SoC

2018-09-12 Thread Joel Stanley
ater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/5] net: re-add support for the Faraday ftgmac100 controller

2018-09-12 Thread Joel Stanley
On Mon, 10 Sep 2018 at 23:54, Cédric Le Goater wrote: > > The driver is based on the previous one and adds the same support for > the Faraday ftgmac100 controller with MAC and MDIO bus support for > RGMII/RMII modes. > > Driver model support was added as well as some enhancements and fixes. > > Si

Re: [U-Boot] [PATCH 3/3] aspeed: Add SPI support to the ast2500 Eval Board

2018-09-12 Thread Joel Stanley
On Mon, 10 Sep 2018 at 23:49, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/4] aspeed: Activate SPI support on the ast2500 Eval Board

2018-09-24 Thread Joel Stanley
On Fri, 21 Sep 2018 at 16:09, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater > Reviewed-by: Jagan Teki Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 3/4] aspeed: Update ast2500 SoC DTS file to Linux v4.17-rc6 level

2018-09-24 Thread Joel Stanley
On Fri, 21 Sep 2018 at 16:09, Cédric Le Goater wrote: > > This is a large update of the AST2500 Soc DTS file bringing it to the > level of commit 927c2fc2db19 : > > Author: Joel Stanley > Date:Sat Jun 2 01:18:53 2018 -0700 > > ARM: dts: aspeed: Fi

Re: [U-Boot] [PATCH 13/17] aspeed: Add support for Clocks needed by MACs

2017-03-20 Thread Joel Stanley
On Tue, Mar 21, 2017 at 7:13 AM, Rick Altherr wrote: > +Joel > > On Mon, Mar 20, 2017 at 10:52 AM, Maxim Sloyko wrote: >> On Mon, Mar 20, 2017 at 10:30 AM, Tom Rini wrote: >>> So this applies to a lot of parts of the series here. What we don't >>> want to do is have places where the DTS here di

[U-Boot] [PATCH] Makefile: Fix linking with modern binutils

2016-12-07 Thread Joel Stanley
xt&id=ff45000fcb56b5b0f1a14a865d3541746d838a0a Signed-off-by: Joel Stanley --- Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index dfed58bec661..0bfd57d81646 100644 --- a/Makefile +++ b/Makefile @@ -792,7 +792,11 @@ ifneq ($(CONFIG_BUILD_TARGET)

Re: [U-Boot] Makefile: Fix linking with modern binutils

2016-12-13 Thread Joel Stanley
Hello Tom, On Sat, Dec 10, 2016 at 12:53 AM, Tom Rini wrote: >> -LDFLAGS_u-boot += $(LDFLAGS_FINAL) >> +# Avoid Not enough room for program headers on binutils 2.28 onwards. >> +# Flag was introduced in 2.26 >> +LDFLAGS_u-boot += $(LDFLAGS_FINAL) \ >> + $(call ld-ifversion, -ge, 2260, --n

Re: [U-Boot] Makefile: Fix linking with modern binutils

2016-12-15 Thread Joel Stanley
On Tue, Dec 13, 2016 at 10:51 PM, Tom Rini wrote: > On Tue, Dec 13, 2016 at 03:31:24PM +1030, Joel Stanley wrote: >> Hello Tom, >> >> On Sat, Dec 10, 2016 at 12:53 AM, Tom Rini wrote: >> >> -LDFLAGS_u-boot += $(LDFLAGS_FINAL) >> >> +# Avoid Not eno

[U-Boot] [PATCH v2] Makefile: Fix linking with modern binutils

2016-12-15 Thread Joel Stanley
ed-off-by: Joel Stanley --- v2: - use ld-option to test for the flag instead of the version, as suggested by Måns - update commit message with clarification from Alan Makefile | 4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a

[U-Boot] [PATCH] aspeed/watchdog: Correct timeout value

2019-06-06 Thread Joel Stanley
el: Aspeed BMC DRAM: 496 MiB WDT: Started with servicing (60s timeout) MMC: In:serial@1e784000 Out: serial@1e784000 Err: serial@1e784000 Watchdog timer expired. Fixes: 06985289d452 ("watchdog: Implement generic watchdog_reset() version") Signed-off-by: Joel S

Re: [U-Boot] [PATCH 4/4] net: NC-SI setup and handling

2019-06-11 Thread Joel Stanley
ration. > > Signed-off-by: Samuel Mendoza-Jonas We need the u-boot net specialists to weigh in, but this looks okay to me. Please clarify the help text for the NCSI command, then add: Reviewed-by: Joel Stanley > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1296,6 +1296,12 @@

Re: [U-Boot] [PATCH 1/4] phy: Add support for the NC-SI protocol

2019-06-11 Thread Joel Stanley
On Thu, 6 Jun 2019 at 04:50, Samuel Mendoza-Jonas wrote: > > This introduces support for the NC-SI protocol, modelled as a phy driver > for other ethernet drivers to consume. > > NC-SI (Network Controller Sideband Interface) is a protocol to manage a > sideband connection to a proper network inter

Re: [U-Boot] [PATCH 2/4] phy: Include NC-SI in phy setup

2019-06-11 Thread Joel Stanley
) and phy_write() to handle a > case like the NC-SI phy which does not define a bus. > > Signed-off-by: Samuel Mendoza-Jonas Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/4] net/ftgmac100: Add NC-SI mode support

2019-06-11 Thread Joel Stanley
On Thu, 6 Jun 2019 at 04:50, Samuel Mendoza-Jonas wrote: > > Update the ftgmac100 driver to support NC-SI instead of an mdio phy > where available. This is a common setup for Aspeed AST2x00 platforms. > > NC-SI mode is determined from the device-tree if either phy-mode sets it > or the use-ncsi pr

Re: [U-Boot] [PATCH] aspeed/watchdog: Correct timeout value

2019-06-16 Thread Joel Stanley
On Fri, 7 Jun 2019 at 14:57, Tom Rini wrote: > > On Thu, Jun 06, 2019 at 05:08:45PM +0930, Joel Stanley wrote: > > > The driver was using milliseconds and programming it into a register > > which takes ticks of the watchdog clock, which runs at 1MHz. This meant > > w

Re: [U-Boot] [PATCH v2 0/4] NC-SI PHY Support

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 08:35, Cédric Le Goater wrote: > > On 18/06/2019 03:37, Samuel Mendoza-Jonas wrote: > > This series introduces support for the NC-SI protocol to u-boot, > > functionality which so far has only been available in vendor trees. > > Would it be complex to add a romulus DT and co

Re: [U-Boot] [PATCH v2 1/4] phy: Add support for the NC-SI protocol

2019-06-18 Thread Joel Stanley
[1]: https://github.com/torvalds/linux/blob/master/net/ncsi/ncsi-pkt.h > > Signed-off-by: Samuel Mendoza-Jonas > --- > v2: > - Fix endianess issue when setting MAC address > - Make checksum offsets easier to read > - Instantiate per-phy ncsi_priv structures > -

Re: [U-Boot] [PATCH v2 2/4] phy: Include NC-SI in phy setup

2019-06-18 Thread Joel Stanley
) and phy_write() to handle a > case like the NC-SI phy which does not define a bus. > > Signed-off-by: Samuel Mendoza-Jonas Reviewed-by: Joel Stanley ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/4] net: NC-SI setup and handling

2019-06-18 Thread Joel Stanley
On Tue, 18 Jun 2019 at 01:38, Samuel Mendoza-Jonas wrote: > > Add the handling of NC-SI ethernet frames, and add a check at the start > of net_loop() to configure NC-SI before starting other network commands. > This also adds an "ncsi" command to manually start NC-SI configuration. > > Signed-off

[U-Boot] [PATCH 0/5] travis: Build and test ASPEED board

2019-07-03 Thread Joel Stanley
tools that need to be merged before this Travis configuration can go in. Joel Stanley (5): configs: aspeed: Unset CONFIG_MMC configs: aspeed: Add HUSH and random ethernet addr traivs: Build aspeed boards travis: Add ASPEED ast2500 to qemu tests travis: Build aspeed board with qemu

[U-Boot] [PATCH 2/5] configs: aspeed: Add HUSH and random ethernet addr

2019-07-03 Thread Joel Stanley
Tests in test/py/tests/test_env.py like this fail without CONFIG_HUSH_PARSER: => => printenv test_env_0 ## Error: "test_env_0" not defined => .=> setenv test_env_0 => => echo $test_env_0 $test_env_0 => F We also want a mac address so the ethernet device work

[U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-03 Thread Joel Stanley
Currently we only have one, but this will expand to cover other boards as they are supported. Signed-off-by: Joel Stanley --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 6662ca126ab5..53dade5ae116 100644 --- a/.travis.yml +++ b/.travis.yml

[U-Boot] [PATCH 1/5] configs: aspeed: Unset CONFIG_MMC

2019-07-03 Thread Joel Stanley
before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info. Change the defconfig to disable MMC until a driver is submitted. Signed-off-by: Joel Stanley

[U-Boot] [PATCH 4/5] travis: Add ASPEED ast2500 to qemu tests

2019-07-03 Thread Joel Stanley
Signed-off-by: Joel Stanley --- .travis.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.travis.yml b/.travis.yml index 53dade5ae116..69ae1c8b4223 100644 --- a/.travis.yml +++ b/.travis.yml @@ -387,6 +387,13 @@ matrix: - TEST_PY_BD="sandbox_flattree"

[U-Boot] [PATCH 5/5] travis: Build aspeed board with qemu HEAD

2019-07-03 Thread Joel Stanley
In order to boot u-boot in the aspeed machine we need to run at least qemu 3059c2f5a813 (v4.0.0-1592-g3059c2f5a813), which is not in a released tag. This should be changed to v4.1.0 when it is released. Signed-off-by: Joel Stanley --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH v2 0/2] uboot-test-hooks: aspeed ast2500 support

2019-07-15 Thread Joel Stanley
7;ve given it a spin and it appears to work: https://travis-ci.com/shenki/u-boot/builds/117772801 Joel Stanley (2): flash: Script to create a flash image from u-boot travis: Add ASPEED AST2500 EVB Qemu bin/flash.create_image_32mb | 9 + bin/travis-ci/conf.e

[U-Boot] [PATCH v2 1/2] flash: Script to create a flash image from u-boot

2019-07-15 Thread Joel Stanley
This creates an empty flash image and places u-boot at the start of it. It will be used by the ASPEED Qemu tests which boot u-boot from an emaulated flash device. Signed-off-by: Joel Stanley --- bin/flash.create_image_32mb | 9 + 1 file changed, 9 insertions(+) create mode 100755 bin

[U-Boot] [PATCH v2 2/2] travis: Add ASPEED AST2500 EVB Qemu

2019-07-15 Thread Joel Stanley
Signed-off-by: Joel Stanley --- bin/travis-ci/conf.evb-ast2500_qemu | 11 +++ py/travis-ci/u_boot_boardenv_evb-ast2500_qemu.py | 7 +++ 2 files changed, 18 insertions(+) create mode 100644 bin/travis-ci/conf.evb-ast2500_qemu create mode 100644 py/travis-ci

Re: [U-Boot] [PATCH 0/5] travis: Build and test ASPEED board

2019-07-16 Thread Joel Stanley
Hello, On Thu, 4 Jul 2019 at 01:35, Joel Stanley wrote: > > Tom suggested I add support for booting the ASPEED EVB configuration in > Qemu. This series fixes up a few things with the defconfig so buildman > passes, and makes u-boot testable: > > https://travis-ci.com/sh

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Joel Stanley
On Wed, 17 Jul 2019 at 19:57, Tom Rini wrote: > > On Thu, Jul 04, 2019 at 11:05:16AM +0930, Joel Stanley wrote: > > > Currently we only have one, but this will expand to cover other boards > > as they are supported. > > > > Signed-off-by: Joel Stanley > > -

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Joel Stanley
On Thu, 18 Jul 2019 at 01:33, Tom Rini wrote: > > On Thu, Jul 18, 2019 at 01:30:01AM +, Joel Stanley wrote: > > On Wed, 17 Jul 2019 at 19:57, Tom Rini wrote: > > > This isn't needed as the job that builds all matches to arm11 arm7 > > > arm920t arm946e

Re: [PATCH next v7 06/12] clk: ast2600: Add RSACLK control for ACRY

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > Add RSACLK enable for ACRY, the HW RSA/ECC crypto engine > of ASPEED AST2600 SoCs. > > As ACRY and HACE share the same reset control bit, we do not > perform the reset-hold-n-release operation during their clock > ungating process. Instead, on

Re: [PATCH next v7 01/12] image: fit: Fix parameter name for hash algorithm

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:49, Chia-Wei Wang wrote: > > Fix inconsistent function parameter name of the hash algorithm. > > Signed-off-by: Chia-Wei Wang > Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in > calculate_hash()") Reviewed-by: Joel Sta

Re: [PATCH next v7 02/12] aspeed: ast2600: Enlarge SRAM size

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:49, Chia-Wei Wang wrote: > > The AST2600 SRAM has been extended to 88KB since A1 > chip revision. This patch updates the SRAM size to > offer more space for early stack/heap use. > > Signed-off-by: Chia-Wei Wang Reviewed-by: Joel Stanley > --

Re: [PATCH next v7 04/12] crypto: aspeed: Add AST2600 HACE support

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > From: Johnny Huang > > Hash and Crypto Engine (HACE) is designed to accelerate the > throughput of hash data digest, and symmetric-key encryption. > > Signed-off-by: Johnny Huang > Signed-off-by: Chia-Wei Wang I see you've re-written the d

Re: [PATCH next v7 07/12] crypto: aspeed: Add AST2600 ACRY support

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > ACRY is deisnged to accerlerate ECC/RSA digital signature designed accelerate > generation and verification. > > Signed-off-by: Chia-Wei Wang > --- > drivers/crypto/aspeed/Kconfig | 10 ++ > drivers/crypto/aspeed/Makefile | 1

Re: [PATCH next v7 08/12] ARM: dts: ast2600: Add ACRY to device tree

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > Add ACRY DTS node and enable it for AST2600 EVB. > > Signed-off-by: Chia-Wei Wang Reviewed-by: Joel Stanley > --- > arch/arm/dts/ast2600-evb.dts | 5 + > arch/arm/dts/ast2600.dtsi| 9 + > 2 file

Re: [PATCH next v7 09/12] ast2600: spl: Locate load buffer in DRAM space

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > Return CONFIG_SYS_LOAD_ADDR pointing to DRAM space for > spl_get_load_buffer() to allow generic SPL image loading > code (e.g. FIT and Ymodem) to store data in DRAM. > > Signed-off-by: Chia-Wei Wang Reviewed-by: Joel Stanl

Re: [PATCH next v7 10/12] configs: ast2600-evb: Enable SPL FIT support

2021-10-20 Thread Joel Stanley
than 64KB to fit into the Aspeed secure boot design. > > Signed-off-by: Chia-Wei Wang Reviewed-by: Joel Stanley > --- > configs/evb-ast2600_defconfig | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/configs/evb-ast2600_defconf

Re: [PATCH next v7 11/12] configs: aspeed: Make EXTRA_ENV_SETTINGS board specific

2021-10-20 Thread Joel Stanley
On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang wrote: > > Move CONFIG_EXTRA_ENV_SETTINGS to board-specific > configuration headers. > > Signed-off-by: Chia-Wei Wang > --- > include/configs/aspeed-common.h | 9 - > include/configs/evb_ast2500.h | 9 + > include/configs/evb_ast2600.

Re: [U-Boot] [PATCH] net: ftgmac100: align RX/TX descriptors on ARCH_DMA_MINALIGN

2019-11-28 Thread Joel Stanley
On Thu, 28 Nov 2019 at 12:37, Cédric Le Goater wrote: > > Fixes: e766849713ff ("net: ftgmac100: convert the RX/TX descriptor arrays") > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Thanks Cédric. This resolves the warnings I saw when running on a machine with

Re: [PATCH next v7 04/12] crypto: aspeed: Add AST2600 HACE support

2021-11-15 Thread Joel Stanley
On Thu, 21 Oct 2021 at 02:13, ChiaWei Wang wrote: > > > From: Joel Stanley > > Sent: Thursday, October 21, 2021 8:08 AM > > > > On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang > > wrote: > > > > > > From: Johnny Huang > > > >

[PATCH 3/3] mkimge: Reject signing-related flags without FIT_SIGNATURE

2020-11-11 Thread Joel Stanley
obvious that the commands don't work by removing them from the getopt opt_string. The tool will now behave as follows: $ mkimage -f machine.its -k keys -K u-boot-pubkey.dtb -r image.fit mkimage: invalid option -- 'k' Error: Invalid option Signed-off-by: Joel Stanley --- tool

[PATCH 1/3] tools/Makefile: FIT_CIPHER requires libssl

2020-11-11 Thread Joel Stanley
o `EVP_EncryptUpdate' /usr/bin/ld: aes-encrypt.c:(.text+0xac): undefined reference to `EVP_CIPHER_CTX_free' /usr/bin/ld: aes-encrypt.c:(.text+0xf2): undefined reference to `EVP_EncryptFinal_ex' collect2: error: ld returned 1 exit status Signed-off-by: Joel Stanley --- t

[PATCH 2/3] image-cipher: Fix FIT_CIPHER linking

2020-11-11 Thread Joel Stanley
#x27; The implementation is the same as common/image-fit-sig.c. Signed-off-by: Joel Stanley --- common/image-cipher.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/common/image-cipher.c b/common/image-cipher.c index 4ca9eec4ef15..fcbbceb847a5 100644 --- a/common/image-cipher.c ++

[PATCH 0/3] mkimage usability fixes

2020-11-11 Thread Joel Stanley
Debian bug for that[1] but in the mean time this changes mkimage's behaviour to fail loudly when FIT_SIGNATURE is disabled. The first two patches fix some issues I found when testing the third patch under sandbox_defconfig with FIT_SIGNATURE=n. [1] https://bugs.debian.org/cgi-bin/bugreport.

[PATCH] ram: aspeed: Rework kconfig options

2022-02-15 Thread Joel Stanley
Ensure the ASPEED related options are grouped together under the RAM option when enabling support. This also makes some minor grammar corrections and renames options so they present cleanly in menuconfig. There should be no functional change to the configuration or binary. Signed-off-by: Joel

Re: [PATCH] net: ftgmac100: Add Aspeed AST2700 support

2024-09-10 Thread Joel Stanley
Hi Jacky, On Mon, 8 Jul 2024 at 15:37, Jacky Chou wrote: > > Add support of Aspeed AST2700 SoC. AST2700 is based on ARM64 so modify > the DMA address related code to fit both ARM and ARM64. Besides, the > RMII/RGMII mode control register is moved from SCU500 to MAC50 so > initialize the registe

[RFC PATCH] mkimage: Allow -o to set hash algorithm in auto mode

2024-10-31 Thread Joel Stanley
this was already the behavior, however -o only affects auto-conf mode. The change in this commit does not affect the auto-conf behaviour. Signed-off-by: Joel Stanley --- RFC. This is useful in testing that the hash infrastructure is working. If there's no appetite for changing the mkimage be

[PATCH] ast2600: spl: Use readl for reading mmio

2024-11-17 Thread Joel Stanley
Signed-off-by: Joel Stanley --- GCC 14 was using this sequence to read the value, leading to the crash: ldrbpl.w r0, [r0, #1280] @ 0x500 arch/arm/mach-aspeed/ast2600/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-aspeed/ast2600/spl.c b/arc

<    1   2