Re: [U-Boot] [PATCH v2 1/4] nand: Add support for unlock.invert

2012-09-18 Thread Joe Hershberger
Hi Scott, On Mon, Sep 17, 2012 at 5:35 PM, Scott Wood wrote: > On Wed, Aug 22, 2012 at 04:49:42PM -0500, Joe Hershberger wrote: >> NAND unlock command allows an invert bit to be set to unlock all but >> the selected page range. >> >> Signed-off-by: Joe Hershberg

Re: [U-Boot] [PATCH 1/2] net: Allow netconsole settings to change after nc_start

2012-09-18 Thread Joe Hershberger
Hi Mike, On Fri, Aug 17, 2012 at 9:28 PM, Mike Frysinger wrote: > On Friday 17 August 2012 15:48:20 Joe Hershberger wrote: >> --- a/drivers/net/netconsole.c >> +++ b/drivers/net/netconsole.c >> >> +static int refresh_settings_from_env(void) > > this func always

[U-Boot] [PATCH 2/2] net: Filter incoming netconsole packets by IP

2012-09-18 Thread Joe Hershberger
Check the incoming packets' source IP address... if ncip isn't set to a broadcast address, only listen to the client at ncip. Signed-off-by: Joe Hershberger --- drivers/net/netconsole.c | 8 ++-- include/net.h| 3 ++- net/net.c| 1 + 3 files

[U-Boot] [PATCH 1/2] net: Allow netconsole settings to change after nc_start

2012-09-18 Thread Joe Hershberger
Refresh the netconsole settings from the env before each packet instead of only on netconsole init. Signed-off-by: Joe Hershberger --- Changes in v2: - Made string pointer const drivers/net/netconsole.c | 96 1 file changed, 65 insertions(+), 31

[U-Boot] [PATCH 0/2] net: Netconsole port configuration and filtering

2012-09-18 Thread Joe Hershberger
This series depends on this patch: http://patchwork.ozlabs.org/patch/174282/ Changes in v2: - Made string pointer const Joe Hershberger (2): net: Allow netconsole settings to change after nc_start net: Filter incoming netconsole packets by IP drivers/net/netconsole.c | 104

Re: [U-Boot] [PATCH 2/2] Add unlzo command

2012-09-18 Thread Joe Hershberger
Hi Mike, On Fri, Aug 17, 2012 at 6:26 PM, Mike Frysinger wrote: > On Friday 17 August 2012 16:59:44 Joe Hershberger wrote: >> --- a/common/Makefile >> +++ b/common/Makefile >> >> ifdef CONFIG_LZMA >> COBJS-$(CONFIG_CMD_UNLZMA) += cmd_unlzma.o >>

Re: [U-Boot] [PATCH 1/6] h2200: Add support for iPAQ h2200

2012-09-19 Thread Joe Hershberger
Hi Marek, On Wed, Sep 19, 2012 at 4:02 PM, Marek Vasut wrote: > Dear Łukasz Dałek, > > [ Joe, see the bottom of my babble here ] > >> + >> +# define CONFIG_USB_ETHER1 >> +# define CONFIG_USBNET_DEV_ADDR "de:ad:be:ef:00:01" >> +# define CONFIG_USBNET_HOST_ADDR "de:ad:b

Re: [U-Boot] [PATCH v7 3/4] OMAP: networking support for SPL

2012-09-20 Thread Joe Hershberger
n v7: > - remove explicit cmd undef from net/tftp.c also > - add GPLv2 header to config_uncmd_spl.h > - remove CONFIG_SPL_BUILD clause at hang() (not needed) Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net/phy: support the mv88e6352 switch

2012-09-21 Thread Joe Hershberger
16:47 >>> To: u-boot@lists.denx.de >>> Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Joe >>> Hershberger >>> Subject: [PATCH] net/phy: support the mv88e6352 switch >>> >>> This patch add support for the configuration of an

[U-Boot] [RFC PATCH 0/5] Add environment call-back capability

2012-09-21 Thread Joe Hershberger
little feedback if this is a good implementation. It certainly cleans up cmd_nvedit.c significantly! Joe Hershberger (5): env: Add support for callbacks to environment vars env: Add a loadaddr env handler env: Add a bootfile env handler env: Add a baudrate env handler env: Add a

[U-Boot] [RFC PATCH 2/5] env: Add a loadaddr env handler

2012-09-21 Thread Joe Hershberger
Remove the hard-coded loadaddr handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_load.c | 24 ++-- common/cmd_nvedit.c| 10 +- include/env_callback.h | 1 + 3 files changed, 24 insertions(+), 11 deletions(-) diff --git a

[U-Boot] [RFC PATCH 4/5] env: Add a baudrate env handler

2012-09-21 Thread Joe Hershberger
Remove the hard-coded baudrate handler and use a callback instead Signed-off-by: Joe Hershberger --- common/Makefile| 2 +- common/cmd_nvedit.c| 35 -- common/serial.c| 58 ++ include/env_callback.h

[U-Boot] [RFC PATCH 5/5] env: Add a console env handler

2012-09-21 Thread Joe Hershberger
Remove the hard-coded console handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c| 31 --- common/console.c | 46 ++ include/env_callback.h | 1 + 3 files changed, 47

[U-Boot] [RFC PATCH 3/5] env: Add a bootfile env handler

2012-09-21 Thread Joe Hershberger
Remove the hard-coded bootfile handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c| 13 - include/env_callback.h | 2 +- net/net.c | 16 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/common

[U-Boot] [RFC PATCH 1/5] env: Add support for callbacks to environment vars

2012-09-21 Thread Joe Hershberger
Add support for callbacks to the "hashtable" functions. One check-patch warning to inter-op with existing hashtable code: WARNING: do not add new typedefs +typedef struct entry ENTRY; Signed-off-by: Joe Hershberger --- arch/arm/cpu/u-boot.lds | 7 +++ common/Makefile | 2

Re: [U-Boot] [PATCH 1/3] common: Add symbol handling for generic lists into Makefile

2012-09-24 Thread Joe Hershberger
iles. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- > Makefile | 21 ++--- > spl/Makefile | 14 +- > 2 files changed, 31 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile >

Re: [U-Boot] [PATCH 2/3] common: Implement support for linker-generated arrays

2012-09-24 Thread Joe Hershberger
begining and end > respecitively. > > This allows for simple run-time traversing of the array, since the > symbols are properly defined. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- > include/linker_lists.h | 125 > +++

Re: [U-Boot] [PATCH 3/3] common: Add .u_boot_list into all linker files

2012-09-24 Thread Joe Hershberger
Hi Marek, On Sun, Sep 23, 2012 at 8:21 PM, Marek Vasut wrote: > Add section for the linker-generated lists into all possible linker > files, so that everyone can easily use these lists. This is mostly > a mechanical adjustment. > > Signed-off-by: Marek Vasut > Cc: Joe Hersh

Re: [U-Boot] [PATCH 1/3] common: Add symbol handling for generic lists into Makefile

2012-09-24 Thread Joe Hershberger
Hi Marex, On Mon, Sep 24, 2012 at 11:04 AM, Marek Vasut wrote: > Dear Joe Hershberger, [...] >> Could you not reuse this complicated logic by defining a make function >> and then call + eval it? Something like this: > > > Can you elaborate more? I don't quite ge

Re: [U-Boot] [PATCH 3/3] common: Add .u_boot_list into all linker files

2012-09-24 Thread Joe Hershberger
Hi Tom, On Mon, Sep 24, 2012 at 12:18 PM, Tom Rini wrote: > On Mon, Sep 24, 2012 at 07:09:35PM +0200, Marek Vasut wrote: >> Dear Tom Rini, >> >> > On Mon, Sep 24, 2012 at 06:53:19PM +0200, Marek Vasut wrote: >> > > Dear Joe Hershberger, >> > > &g

Re: [U-Boot] [PATCH 1/3] common: Add symbol handling for generic lists into Makefile

2012-09-24 Thread Joe Hershberger
Hi Marek, On Mon, Sep 24, 2012 at 12:08 PM, Marek Vasut wrote: > Dear Joe Hershberger, > >> Hi Marex, >> >> On Mon, Sep 24, 2012 at 11:04 AM, Marek Vasut wrote: >> > Dear Joe Hershberger, >> >> [...] >> >> >> Could you not reuse th

Re: [U-Boot] [PATCH V1 1/3] phy: add phy_connect_by_mask

2012-09-26 Thread Joe Hershberger
Hi Troy, On Wed, Aug 22, 2012 at 4:21 PM, Troy Kisky wrote: > On 8/22/2012 1:40 PM, Andy Fleming wrote: >> >> >> >> 1) Modify the driver so that the PHY address is passed in from board >> initialization code programmatically. As a nod to the effort of doing >> so for all boards, you can create a

Re: [U-Boot] KernelDoc

2012-09-26 Thread Joe Hershberger
Hi Marek, On Wed, Sep 26, 2012 at 10:26 AM, Marek Vasut wrote: > Dear Wolfgang Denk, > >> Dear Marek, >> >> In message <201209252246.10322.ma...@denx.de> you wrote: >> > I've had a discussion with Wolfgang just now about U-Boot coding style. I >> > tried using KernelDoc in a patch, which is not p

[U-Boot] Pull request: u-boot-net.git master

2012-09-27 Thread Joe Hershberger
Address) Chander Kashyap (1): PXE: FDT: Add support for fdt in PXE Joe Hershberger (5): net: Make netconsole src and dest ports configurable net: Make the netconsole buffer size configurable net: Improve the speed of netconsole net: Allow netconsole settings to change after

[U-Boot] [RFC PATCH v2 0/5] Add environment call-back capability

2012-09-27 Thread Joe Hershberger
little feedback if this is a good implementation. It certainly cleans up cmd_nvedit.c significantly! Changes in v2: - Added much-needed documentation - Factored out prevch and nextch in env_attr_lookup() Joe Hershberger (5): env: Add support for callbacks to environment vars env: Add a

[U-Boot] [RFC PATCH v2 3/5] env: Add a bootfile env handler

2012-09-27 Thread Joe Hershberger
Remove the hard-coded bootfile handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c| 13 - include/env_callback.h | 2 +- net/net.c | 16 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/common

[U-Boot] [RFC PATCH v2 5/5] env: Add a console env handler

2012-09-27 Thread Joe Hershberger
Remove the hard-coded console handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c| 31 --- common/console.c | 46 ++ include/env_callback.h | 1 + 3 files changed, 47

[U-Boot] [RFC PATCH v2 2/5] env: Add a loadaddr env handler

2012-09-27 Thread Joe Hershberger
Remove the hard-coded loadaddr handler and use a callback instead Signed-off-by: Joe Hershberger --- common/cmd_load.c | 24 ++-- common/cmd_nvedit.c| 10 +- include/env_callback.h | 1 + 3 files changed, 24 insertions(+), 11 deletions(-) diff --git a

[U-Boot] [RFC PATCH v2 4/5] env: Add a baudrate env handler

2012-09-27 Thread Joe Hershberger
Remove the hard-coded baudrate handler and use a callback instead Signed-off-by: Joe Hershberger --- common/Makefile| 2 +- common/cmd_nvedit.c| 35 -- common/serial.c| 58 ++ include

[U-Boot] [RFC PATCH v2 1/5] env: Add support for callbacks to environment vars

2012-09-27 Thread Joe Hershberger
Add support for callbacks to the "hashtable" functions. One check-patch warning to inter-op with existing hashtable code: WARNING: do not add new typedefs +typedef struct entry ENTRY; Signed-off-by: Joe Hershberger --- Changes in v2: - Added much-needed documentation - Factored out

Re: [U-Boot] [PATCH] api: net: fix length check in eth_receive()

2012-09-28 Thread Joe Hershberger
Hi Michael, On Mon, Jun 25, 2012 at 3:50 PM, Michael Walle wrote: > > [removed Piotr Kruszynski from CC because mail address does not exist anymore] > > Hi Joe, > > Am Montag 25 Juni 2012, 22:25:56 schrieb Joe Hershberger: >> Hi Michael, >> >> On Fri, Ju

Re: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000

2012-09-28 Thread Joe Hershberger
Hi Tetsuyuki, On Mon, Jun 25, 2012 at 7:37 AM, Tetsuyuki Kobayashi wrote: > NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. > > Signed-off-by: Tetsuyuki Kobayashi > --- I decided this doesn't hurt and it sort-of documents what "must be" (tm). Applied, thanks. -Joe

Re: [U-Boot] [U-Boot-DM] [PATCH 09/10] dm: net: Move IXP NPE to drivers/net/

2012-09-28 Thread Joe Hershberger
Hi Marek, On Sat, Jul 21, 2012 at 10:02 AM, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Bryan Hundven > Cc: Michael Schwingen > Cc: Wolfgang Denk > Cc: Albert Aribaud > Cc: U-Boot DM > Cc: Joe Hershberger > ---

Re: [U-Boot] [PATCH 4/5] net: emaclite: Support OF initialization

2012-09-28 Thread Joe Hershberger
Hi Michal, On Fri, Jun 29, 2012 at 2:37 AM, Michal Simek wrote: > Support new CONFIG_OF_CONTROL option where device > probing is done based on device tree description. > > Signed-off-by: Michal Simek > CC: Joe Hershberger > --- Appl

Re: [U-Boot] [U-Boot-DM] [PATCH] dm: net: Fixup the armada100 FEC driver

2012-09-28 Thread Joe Hershberger
strict-aliasing] > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: sh_eth: Add support R8A7740 of rmobile (arm core)

2012-09-28 Thread Joe Hershberger
Hi Nobuhiro, On Fri, Aug 3, 2012 at 3:08 AM, Nobuhiro Iwamatsu wrote: > R8A7740 of rmobile has ethernet device, and this is same IP of > sh-ether. This support R8A7740 of rmobile. > > Signed-off-by: Hideyuki Sano > Signed-off-by: Nobuhiro Iwamatsu > --- Applied, thanks. -Joe _

Re: [U-Boot] [PATCHv2 1/5] net: introduce transparent driver private in ueth_data

2012-09-28 Thread Joe Hershberger
Hi Lucas, On Wed, Aug 22, 2012 at 4:04 PM, Lucas Stach wrote: > Avoid clutter in ueth_data. Individual drivers should not mess > with structures belonging to the core like this. > > Signed-off-by: Lucas Stach > Reviewed-by: Marek Vasut > Acked-by: Marek Vasut > Acke

Re: [U-Boot] [PATCHv2 2/5] net: asix: split out basic reset function

2012-09-28 Thread Joe Hershberger
call it > from asix_eth_get_info(), so that it only gets called once. > > Signed-off-by: Lucas Stach > Acked-by: Joe Hershberger > --- Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv2 3/5] net: asix: add write_hwaddr function

2012-09-28 Thread Joe Hershberger
Hi Lucas, On Wed, Aug 22, 2012 at 4:04 PM, Lucas Stach wrote: > All ASIX chipsets aside from AX88172 are able to set the MAC > address on the hardware level. Add a function to expose this > ability. > > To differentiate between chip types we now carry flags as driver > private data. Also while to

Re: [U-Boot] [PATCHv2 4/5] net: asix: add read_mac function

2012-09-28 Thread Joe Hershberger
ices that have their initial MAC stored in > EEPROM. Call this function inasix_eth_get_info(). > > Signed-off-by: Lucas Stach > Reviewed-by: Marek Vasut > Acked-by: Marek Vasut > Acked-by: Joe Hershberger > --- Failed checkpatch.pl

Re: [U-Boot] [PATCHv2 5/5] net: asix: add AX88772B support

2012-09-28 Thread Joe Hershberger
default configuration. So stop > enumeration after we found them to avoid overwriting the > endpoint config with a non-working one. > > Signed-off-by: Lucas Stach > Reviewed-by: Marek Vasut > Acked-by: Marek Vasut > Acked-by: Joe Hershberger > --- Failed c

Re: [U-Boot] [PATCH 2/4 v3] net: Add driver for Zynq Gem IP

2012-09-28 Thread Joe Hershberger
Hi Michal, On Fri, Sep 14, 2012 at 1:23 AM, Michal Simek wrote: > Device driver for Zynq Gem IP. > > Signed-off-by: Michal Simek > CC: Joe Hershberger > CC: Marek Vasut Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lis

Re: [U-Boot] [PATCH] eth_write_hwaddr: Return error for invalid MACs

2012-09-28 Thread Joe Hershberger
Hi Benoît, On Fri, Aug 10, 2012 at 12:56 PM, Benoît Thébaudeau wrote: > If dev->enetaddr was supposed to be set with dev->write_hwaddr() but the MAC > address was not valid, return an error. > > Signed-off-by: Benoît Thébaudeau > Cc: Joe Hershberger > ---

Re: [U-Boot] [PATCH] net/phy: support the mv88e6352 switch

2012-09-28 Thread Joe Hershberger
Signed-off-by: Valentin Longchamp > cc: Holger Brunck > cc: Prafulla Wadaskar > cc: Joe Hershberger > --- Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] Add Vitesse VSC8662 PHY support

2012-09-28 Thread Joe Hershberger
Hi York, On Fri, Aug 17, 2012 at 1:28 PM, York Sun wrote: > From: Priyanka Jain > > -VSC8662 is Dual Port 10/100/1000Base-T Phy, > 100Base-FX/1000/Base-X Gigabit Ethernt Transceiver Phy. > > -Its register set and features are similar to > other Vitesse Phys > > Signed-off-by: Priyanka Jain >

Re: [U-Boot] [PATCH 1/2] FEC: Do not pass unaligned buffer to network stack

2012-09-28 Thread Joe Hershberger
> from time to time. > > Signed-off-by: Marek Vasut > Cc: Benoit Thebaudeau > Cc: Eric Nelson > Cc: Fabio Estevam > Cc: Joe Hershberger > --- Applied, thanks. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] FEC: Properly align address over the buffers for cache ops

2012-09-28 Thread Joe Hershberger
Hi Marek, On Sun, Aug 26, 2012 at 3:19 PM, Marek Vasut wrote: > Align the address that's to be invalidated/flushed properly. > > Signed-off-by: Marek Vasut > Cc: Benoit Thebaudeau > Cc: Eric Nelson > Cc: Fabio Estevam > Cc: Joe Hershberger >

Re: [U-Boot] [PATCH 1/3] FEC: Remove endless loop in the FEC driver

2012-09-28 Thread Joe Hershberger
Hi Marek, On Wed, Aug 29, 2012 at 8:49 AM, Marek Vasut wrote: > The FEC hardware sometimes errors out on data transfer and hangs in > the tightloop adjusted by this patch. So add timeout into the tightloop > to make such a hang recoverable. > > Signed-off-by: Marek Vasut > C

Re: [U-Boot] [PATCH 2/3] FEC: Rework the TX wait mechanism

2012-09-28 Thread Joe Hershberger
is beneficial. > > Rework the sequence that wait for completion of the transmission so that > the TDAR bit is tested first and afterwards check the E-bit being clear. > This cuts down the number of cache invalidation calls to one. > > Signed-off-by: Marek Vasut > Cc: Joe Hers

Re: [U-Boot] [PATCH 3/3] FEC: Replace magic contants

2012-09-28 Thread Joe Hershberger
Hi Marek, On Wed, Aug 29, 2012 at 8:49 AM, Marek Vasut wrote: > Replace the magic contant 1 << 24 with properly defined bits. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Fabio Estevam > Cc: Otavio Salvador > Cc: Stefano Babic &g

Re: [U-Boot] [PATCH v4] PXE: FDT: Add support for fdt in PXE

2012-09-28 Thread Joe Hershberger
Hi Chander, On Fri, Sep 7, 2012 at 12:36 AM, Chander Kashyap wrote: > Now DT support is becoming common for all new SoC's. Hence it is better > to have option for getting specific FDT from the remote server. > > This patch adds support for new label i.e. 'fdt'. This will allow to > retrieve 'fdt

Re: [U-Boot] [PATCH] Quietly ignore DHCP Option 28 (Broadcast Address)

2012-09-28 Thread Joe Hershberger
Hi Brian, On Tue, Sep 11, 2012 at 2:22 PM, Brian Rzycki wrote: > Some DHCP servers (notably dnsmasq) always transmit DHCP Option 28, > Broadcast Address as specified in RFC 2132. Without this patch u-boot > displays the warning: > *** Unhandled DHCP Option in OFFER/ACK: 28 > > The patch suppres

Re: [U-Boot] [PATCH 2/3 V2] common: Implement support for linker-generated arrays

2012-09-28 Thread Joe Hershberger
begining and end > respecitively. > > This allows for simple run-time traversing of the array, since the > symbols are properly defined. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- > include/linker_lists.h | 124 > +++

Re: [U-Boot] [PATCH 2/5] common: Implement support for linker-generated arrays

2012-10-02 Thread Joe Hershberger
y, since the > symbols are properly defined. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- Tested-by: Joe Hershberger Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/5] common: Add symbol handling for generic lists into Makefile

2012-10-02 Thread Joe Hershberger
iles. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- Tested-by: Joe Hershberger Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/5] common: Add .u_boot_list into all linker files

2012-10-02 Thread Joe Hershberger
Marek, On Sat, Sep 29, 2012 at 7:17 PM, Marek Vasut wrote: > Add section for the linker-generated lists into all possible linker > files, so that everyone can easily use these lists. This is mostly > a mechanical adjustment. > > Signed-off-by: Marek Vasut > Cc: Joe Hersh

Re: [U-Boot] [PATCH 4/5] common: Convert the U-Boot commands to LG-arrays

2012-10-02 Thread Joe Hershberger
ntroduced LG-array API instead of directly using linker-generated > symbols. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- Tested-by: Joe Hershberger Acked-by: Joe Hershberger ___ U-Boot mailin

Re: [U-Boot] [PATCH 5/5] common: Discard the __u_boot_cmd section

2012-10-02 Thread Joe Hershberger
ociated with this section from include/command.h . > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Mike Frysinger > --- Tested-by: Joe Hershberger Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de h

Re: [U-Boot] [PATCH 05/12] tools/env: Serialize calls to fw_*env

2012-10-02 Thread Joe Hershberger
Hi Mike, Sorry for the delay... I've been distracted. On Wed, Aug 22, 2012 at 10:33 PM, Mike Frysinger wrote: > On Friday 17 August 2012 16:49:39 Joe Hershberger wrote: >> Use a lock file at /var/lock/fw_printenv.lock. > > the lock should be per-MTD, not per-system. I&#

[U-Boot] [PATCH] net: fix netconsole filtering

2012-10-03 Thread Joe Hershberger
Adjustment of Michael Walle's fix patch Commit 8a0eccb1056b313b45ab62e3aac400f339aa71b4 breaks netconsole. src_ip must not be converted to host byte order, because nc_ip is already stored in network byte order (see string_to_ip(), called by getenv_IPaddr()). Signed-off-by: Joe Hershb

[U-Boot] [PATCH v2 1/5] tools/env: Use a board-specific default env

2012-10-03 Thread Joe Hershberger
config.h Need to define "TEXT_BASE" when building the fw_env tool so that the default env will be correct for environments which use it. Define __ASSEMBLY__ when calling #include so that we only get #defines (all we're interested in). Signed-off-by: Joe Hershberger --- tools/en

[U-Boot] [PATCH v2 5/5] env: Check for NULL pointer in envmatch()

2012-10-03 Thread Joe Hershberger
If the pointer passed into envmatch() is NULL, return -1 instead of crashing. Signed-off-by: Joe Hershberger --- common/cmd_nvedit.c | 3 +++ tools/env/fw_env.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 3474bc6..5a28dee 100644 --- a

[U-Boot] [PATCH v2 3/5] tools/env: Don't call env_init() in fw_getenv()

2012-10-03 Thread Joe Hershberger
We will only call fw_getenv when the env has already been initialized. Signed-off-by: Joe Hershberger --- tools/env/fw_env.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index af879f1..f883804 100644 --- a/tools/env/fw_env.c +++ b/tools/env

[U-Boot] [PATCH v2 0/5] Cleanup fw_*env and a few common env

2012-10-03 Thread Joe Hershberger
This is a gutted version of my previous env series in an effort to reduce the risk to the release that is approaching shortly. Changes in v2: - Further simplified based Mike's comments Joe Hershberger (5): tools/env: Use a board-specific default env tools/env: Remove unneeded compl

[U-Boot] [PATCH v2 2/5] tools/env: Remove unneeded complexity

2012-10-03 Thread Joe Hershberger
The length included the name length, and then it was subtracted back out on each use. Now we don't include it in the first place. Also realloc as we process arguments and eliminate memset. Use memcpy instead of manually copying each byte. Signed-off-by: Joe Hershberger --- Changes

[U-Boot] [PATCH v2 4/5] tools/env: Serialize calls to fw_*env

2012-10-03 Thread Joe Hershberger
Use a lock file at /var/lock/fw_printenv.lock. Avoids seriously confusing the MTD driver. Signed-off-by: Joe Hershberger --- tools/env/fw_env_main.c | 59 +++-- 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/tools/env/fw_env_main.c b

Re: [U-Boot] [PATCH] Change dead code in "test" cmd to debug output

2012-10-03 Thread Joe Hershberger
Hi Mike, On Fri, Aug 17, 2012 at 6:41 PM, Mike Frysinger wrote: > On Friday 17 August 2012 16:56:12 Joe Hershberger wrote: >> --- a/common/cmd_test.c >> +++ b/common/cmd_test.c >> >> -#if 0 >> +#ifdef DEBUG >> { >> - printf("

[U-Boot] [PATCH 2/2] Cleanup cache command prints

2012-10-03 Thread Joe Hershberger
Only print when queried, not every time the setting is changed. Signed-off-by: Joe Hershberger --- common/cmd_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmd_cache.c b/common/cmd_cache.c index 13cc3d8..5512f92 100644 --- a/common/cmd_cache.c +++ b/common

[U-Boot] [PATCH 1/2] Fix checkpatch.pl complaints in cmd_cache.c

2012-10-03 Thread Joe Hershberger
Old code that is not compliant. Signed-off-by: Joe Hershberger --- common/cmd_cache.c | 47 ++- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/common/cmd_cache.c b/common/cmd_cache.c index 9c228e2..13cc3d8 100644 --- a/common

[U-Boot] [PATCH v2] Add a new "ini" command

2012-10-03 Thread Joe Hershberger
This allows you to read ini-formatted data from anywhere and then import one of the sections into the environment This is based on rev 16 at http://code.google.com/p/inih/ Signed-off-by: Joe Hershberger --- Changes in v2: - Documented in README - Made all functions static - Changed if statments

[U-Boot] [PATCH v2] Add a command to access the system timer

2012-10-03 Thread Joe Hershberger
Two sub-commands... start and get. * start sets the reference. * get prints out the time since the last start (in "." format). If get is called without start, returns time since boot. Simple way to benchmark an operation: "timer start;;timer get" Signed-off-by: Joe Hershbe

[U-Boot] [PATCH v2] Output strings from echo with puts where easy

2012-10-03 Thread Joe Hershberger
Change echo to puts characters together where it knows about them together. This improves netconsole performance by greatly reducing the number of packets that are sent. Signed-off-by: Joe Hershberger --- Changes in v2: - Check for someone to specify "\c" more than once in each wor

Re: [U-Boot] [PATCH 1/6] fdt: Check error codes returned from fdtlib when loading ITB

2012-10-04 Thread Joe Hershberger
Hi Jerry, On Fri, Aug 17, 2012 at 3:34 PM, Joe Hershberger wrote: > Before this patch, error codes returned from fdtlib were ignored and > continued access would cause a crash. Now just check if the image is > truncated and error if so. > > Signed-off-by: Joe Hershberger &g

[U-Boot] [PATCH] tools: Add a README note about fw_printenv lock file

2012-10-04 Thread Joe Hershberger
Add a mention of the lock file to the README for the fw_printenv tool. Signed-off-by: Joe Hershberger Reported-by: Luka Perkov --- This patch is independent of the series, but should be applied afterward tools/env/README | 4 1 file changed, 4 insertions(+) diff --git a/tools/env/README

[U-Boot] [PATCH] Improve license declaration for cmd_ini.h

2012-10-04 Thread Joe Hershberger
Instead of referenceing the source webpage (which can change) include the license in the source file. Signed-off-by: Joe Hershberger Reported-by: Igor Grinberg Cc: Igor Grinberg Cc: Tom Rini Cc: Wolfgang Denk --- common/cmd_ini.c | 32 ++-- 1 file changed, 30

[U-Boot] [PATCH] env: cosmetic: Consilidate the default env definition

2012-10-12 Thread Joe Hershberger
There used to be a huge structure duplicated 3 times in the source. Signed-off-by: Joe Hershberger --- common/env_common.c | 97 +--- common/env_embedded.c | 104 ++ include/env_default.h | 135

[U-Boot] [PATCH] tools/env: Fix build failure from missing header include

2012-10-12 Thread Joe Hershberger
This was introduced in: 8679d0ffdcc0beafea8e6942c0c67cf859afa18e - COMMON: Use __stringify() instead of MK_STR() The header is now needed since common.h is not included in this tool. Signed-off-by: Joe Hershberger --- tools/env/fw_env.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [U-Boot] [PATCH] tools/env: Fix build failure from missing header include

2012-10-12 Thread Joe Hershberger
Hi Marek, On Fri, Oct 12, 2012 at 5:20 PM, Marek Vasut wrote: > Dear Joe Hershberger, > >> This was introduced in: >> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e - >> COMMON: Use __stringify() instead of MK_STR() >> >> The header is now needed since c

Re: [U-Boot] [STATUS] v2012.10 released, Merge Window is OPEN

2012-10-15 Thread Joe Hershberger
Hi Wolfgang, On Mon, Oct 15, 2012 at 1:57 PM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <507c3b70.4060...@denx.de> you wrote: >> >> Hopefully I do nid run Jonathan Corbet's gitdm in a wrong way (git log >> -p -M v2012.07..v2012.10 | gitdm -u -s -a -o /tmp/results -h >> /tmp/result

Re: [U-Boot] [PATCH v4] tools/env: add posibility to inject configuration

2012-10-15 Thread Joe Hershberger
Hi Andreas, On Tue, Jan 24, 2012 at 3:10 AM, Andreas Bießmann wrote: > From: Andreas Bießmann > > If one want to use fw_printenv/fw_setenv in special variants (eg compiled in > MTD parameters without configuration file) he need to change the sources. > This patch add the posibillity to change th

Re: [U-Boot] [PATCH v2] Add support for MMC to fw_printenv/setenv

2012-10-15 Thread Joe Hershberger
Hi Christian, On Thu, Jan 5, 2012 at 6:30 PM, Christian Daudt wrote: > Changes from previous: > - Changed // to /* */ > - Ran through checkpatch.pl, cleaned up a number of line-too-big and > extra space in the code that was shifted due to being in the new 'if'. Your patch appears to be corrupt.

Re: [U-Boot] [PATCH v2] Add support for MMC to fw_printenv/setenv

2012-10-15 Thread Joe Hershberger
Hi Christian, On Thu, Jan 5, 2012 at 6:30 PM, Christian Daudt wrote: > Changes from previous: > - Changed // to /* */ > - Ran through checkpatch.pl, cleaned up a number of line-too-big and > extra space in the code that was shifted due to being in the new 'if'. > > Thanks, > csd > > > Subjec

[U-Boot] [PATCH 1/2] tools/env: Fix variable delete operation

2012-10-15 Thread Joe Hershberger
Fix crash introduced by a073d63a36524453a817ab029fad5b188f46127e when attempting to delete a variable. Signed-off-by: Joe Hershberger --- tools/env/fw_env.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 520ce3f..906ccbf

[U-Boot] [PATCH 2/2] tools/env: Improve debug prints

2012-10-15 Thread Joe Hershberger
Provide more information when using redundant environments Consistently print debug info to stderr Signed-off-by: Joe Hershberger --- tools/env/fw_env.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index

Re: [U-Boot] [PATCH 0/7] net/designware: Bug fixes

2012-03-07 Thread Joe Hershberger
net custodian. IIRC, Simon and Mike (added to Cc) volunteered >> to take over. I'm not sure about the outcome though. Simon, Mike, is this now >> decided? > > Nothing is decided yet.  Actually I was discussing off list with Joe > Hershberger if he was wiling to do this work - IMO t

Re: [U-Boot] [PATCH 1/4] net: ll_temac: Add LL TEMAC driver to u-boot

2012-03-27 Thread Joe Hershberger
Hi Michal, On Tue, Mar 27, 2012 at 7:25 AM, Michal Simek wrote: > Dear Stephan, > > > Stephan Linz wrote: >> >> Xilinx LocalLink Tri-Mode Ether MAC driver can be >> used by Xilinx Microblaze or Xilinx ppc405/440 in >> SDMA and FIFO mode. DCR or XPS bus can be used. > > Joe, Wolfgang: I don't agre

[U-Boot] [PATCH v2 05/21] net: Encapsulate CDP packet identification

2012-03-27 Thread Joe Hershberger
Checking for CDP packets should be encapsulated, not copied code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from patch "Move CDP out of net.c" - Changed to static inline arch/powerpc/cpu/mpc8xx/fe

[U-Boot] [PATCH v2 17/21] net: cosmetic: Rename CDPHandler to CDPReceive

2012-03-27 Thread Joe Hershberger
This is not called as a handler, so don't name it that way Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readability" net/cdp.c |2 +- net/cdp.h |2 +- net/net

[U-Boot] [PATCH v2 01/18] net: Refactor IP, UPD, and ICMP header writing functions

2012-03-27 Thread Joe Hershberger
ICMP (ping) was reimplementing IP header code... it now shares code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Eliminate CamelCase in new functions include/net.h |4 +++- net/bootp.c |8 net/net.c

[U-Boot] [PATCH v2 07/21] net: Move PING out of net.c

2012-03-27 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Moved config fixes to a separate patch - Pushed #ifdef CONFIG_CMD_PING into header - Eliminated CamelCase net/Makefile |1 + net/net.c| 133

[U-Boot] [PATCH v2 09/21] net: cosmetic: Un-typedef IP_t

2012-03-27 Thread Joe Hershberger
Rename IP header related things to IP_UDP. The existing definition of IP_t includes UDP header, so name it to accurately describe the structure. Also add a structure that only contains IP header fields to be used by functions that don't need UDP. Signed-off-by: Joe Hershberger Cc

[U-Boot] [PATCH v2 12/21] net: cosmetic: Un-typedef ARP_t

2012-03-27 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types include/net.h |5 ++--- net/arp.c |8 +++

[U-Boot] [PATCH v2 04/21] net: Move CDP out of net.c

2012-03-27 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Moved is_cdp_packet to a separate patch - Fixed blank newline at the end of cdp.h - Pushed #ifdef CONFIG_CMD_CDP into header include/net.h |8 +- net/Makefile |1

[U-Boot] [PATCH v2 13/21] net: cosmetic: Un-typedef ICMP_t

2012-03-27 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types include/net.h |6 -- net/net.c |2 +-

[U-Boot] [PATCH v2 18/21] net: cosmetic: Rename OPT_SIZE to OPT_FIELD_SIZE

2012-03-27 Thread Joe Hershberger
Clearer constant name. Also remove related BOOTP_SIZE which was unused and doesn't take into account VLAN packets. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split from "Improve variable names and code readabil

[U-Boot] [PATCH v2 03/21] net: Move MAC-seeded rand out of bootp.c

2012-03-27 Thread Joe Hershberger
Make the MAC-seeded random number generator available to /net in general. MAC-seeded rand will be needed by link-local as well, so give it an interface. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/Makefile |1 + net/bootp.c| 69

[U-Boot] [PATCH v2 12/18] net: Fix unused variable compile warning

2012-03-27 Thread Joe Hershberger
If CONFIG_BOOTP_SERVERIP is not defined, unused variable warning is reported. This was fixed in origin using a compiler feature instead of a simple reorder of the statements. Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- net/bootp.c |7

[U-Boot] [PATCH v2 03/10] net: cosmetic: net.c checkpatch compliance

2012-03-27 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches net/bootp.c | 340 ++- net/bootp.h | 56 +- 2 files changed, 203 insertions(+), 193

[U-Boot] [PATCH v2 10/10] net: cosmetic: netconsole.c checkpatch compliance

2012-03-27 Thread Joe Hershberger
Requires: --ignore CONSIDER_KSTRTO Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- Changes for v2: - Split into smaller patches drivers/net/netconsole.c | 122 +++-- 1 files changed, 62 insertions(+), 60

[U-Boot] [PATCH v2 10/18] net: Add NetUpdateEther() to handle ARP and Ping replies

2012-03-27 Thread Joe Hershberger
When the network is VLAN or SNAP, NetUpdateEther() will preserve the original Ethernet packet header and simply replace the src and dest MACs and the protocol Signed-off-by: Joe Hershberger Cc: Joe Hershberger Cc: Simon Glass Cc: Mike Frysinger --- include/net.h |1 + net/arp.c

<    4   5   6   7   8   9   10   11   12   13   >