[U-Boot] [PATCH v3 14/21] net: cosmetic: Rename parameter len to payload_len

2012-05-23 Thread Joe Hershberger
This name more explicitly claims that it does not include the header size Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: - Documented arguments to NetSendUDPPacket() include/ne

[U-Boot] [PATCH v3 12/21] net: cosmetic: Un-typedef ARP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case letters Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed ARP_hdr to arp_hdr inc

[U-Boot] [PATCH v3 09/21] net: cosmetic: Split struct ip_udp_hdr into ip_hdr

2012-05-23 Thread Joe Hershberger
Add a structure that only contains IP header fields to be used by functions that don't need UDP Rename IP_HDR_SIZE_NO_UDP to IP_HDR_SIZE Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a

[U-Boot] [PATCH v3 21/21] net: cosmetic: Replace magic numbers in arp.c with constants

2012-05-23 Thread Joe Hershberger
Use field names and sizes when accessing ARP packets Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: include/net.h |6 ++ net/arp.c | 34 +--

[U-Boot] [PATCH v3 08/21] net: cosmetic: Un-typedef IP_t

2012-05-23 Thread Joe Hershberger
Rename IP header related things to IP_UDP. The existing definition of IP_t includes UDP header, so name it to accurately describe the structure. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Cre

[U-Boot] [PATCH v3 19/21] net: cosmetic: Alphabetize includes in net.c

2012-05-23 Thread Joe Hershberger
Easier to find when alphabetized Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: - Slight adjustment to order as recommended by Simon net/net.c | 24 ---

[U-Boot] [PATCH v3 10/21] net: cosmetic: Un-typedef Ethernet_t

2012-05-23 Thread Joe Hershberger
Separate the Ethernet header from the 802 header. Base the size constants on the structs. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a new E802_hdr struct and removed 802 members from Et

[U-Boot] [PATCH v3 06/21] net: Move PING out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Moved config fixes to a separate patch - Pushed #ifdef CONFIG_CMD_PING into header - Eliminated CamelCase Changes for v3: - Added function comments

[U-Boot] [PATCH v3 13/21] net: cosmetic: Un-typedef ICMP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case name Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed ICMP_hdr to icmp_hdr - Rem

[U-Boot] [PATCH v3 11/21] net: cosmetic: Un-typedef VLAN_Ethernet_t

2012-05-23 Thread Joe Hershberger
Eliminate the typedef and remove capital letters Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed VLAN_Ether

[U-Boot] [PATCH v3 00/21] Network stack cosmetic improvements

2012-05-23 Thread Joe Hershberger
uot; patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (21): net: Remove CMD_PING where there's no CMD_NET net: Move MAC-seeded rand out of bootp.c net: Move CDP out of net.c net: Encapsulate CDP packet i

[U-Boot] [PATCH v3 04/21] net: Encapsulate CDP packet identification

2012-05-23 Thread Joe Hershberger
Checking for CDP packets should be encapsulated, not copied code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from patch "Move CDP out of net.c" - Changed to static inline Changes for v3: - Added a function comment - Added a blank l

[U-Boot] [PATCH v3 03/21] net: Move CDP out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Moved is_cdp_packet to a separate patch - Fixed blank newline at the end of cdp.h - Pushed #ifdef CONFIG_CMD_CDP into header Changes for v3: - Fix comment

[U-Boot] [PATCH v3 16/21] net: cosmetic: Rename "x" to "eth_proto"

2012-05-23 Thread Joe Hershberger
x is a poor variable name Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: net/net.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a

[U-Boot] [PATCH v3 03/18] net: Refactor packet length computations

2012-05-23 Thread Joe Hershberger
Save the length when it is computed instead of forgetting it and subtracting pointers to figure it out again. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/arp.c | 13 - net/ping.c |7

[U-Boot] [PATCH v3 07/18] net: Refactor to use NetSendPacket instead of eth_send directly

2012-05-23 Thread Joe Hershberger
Use this entry-point consistently across the net/ code Use a static inline function to preserve code size Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Change NetSendPacket into a static inline Changes for v3: - Rebased onto other changed patches include/net.h

[U-Boot] [PATCH v3 05/18] net: Move debug trace to point of action

2012-05-23 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Refactor bootp packet length computations" Changes for v3: - Rebased onto other changed patches net/bootp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/boo

[U-Boot] [PATCH v3 11/18] net: Don't write the "serverip" env var if configured not to

2012-05-23 Thread Joe Hershberger
Before this patch, bootp would not overwrite the value, but the value was still clobbered in the env Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Added a comment Changes for v3: - Rebased onto other changed patches - Fixed comment style common/cmd_net.c

[U-Boot] [PATCH v3 00/18] Network stack refactoring

2012-05-23 Thread Joe Hershberger
ant on the "Network stack cosmetic improvements" patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (18): net: Refactor IP, UPD, and ICMP header writing functions net: Refactor NetSendUDPPacket to share mo

[U-Boot] [PATCH v3 02/18] net: Refactor NetSendUDPPacket to share more code

2012-05-23 Thread Joe Hershberger
Share more of the code that is common between ARP vs not. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/net.c | 44 +--- 1 files changed, 25 insertions(+), 19

[U-Boot] [PATCH v3 09/18] net: Refactor to separate the UDP handler from the ARP handler

2012-05-23 Thread Joe Hershberger
Call a built-in dummy if none is registered... don't require protocols to register a handler (eliminating dummies) NetConsole now uses the ARP handler when waiting on arp (instead of needing a #define hack in arp.c) Clear handlers at the end of net loop Signed-off-by: Joe Hershberger Cc

[U-Boot] [PATCH v3 01/18] net: Refactor IP, UPD, and ICMP header writing functions

2012-05-23 Thread Joe Hershberger
ICMP (ping) was reimplementing IP header code... it now shares code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Eliminate CamelCase in new functions Changes for v3: - Rebased onto other changed patches include/net.h |4 +++- net/bootp.c |8

[U-Boot] [PATCH v3 06/18] net: Refactor ping receive handler

2012-05-23 Thread Joe Hershberger
There is no need to call through the handler... inline it Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/ping.c | 18 ++ 1 files changed, 2 insertions(+), 16 deletions(-) diff --git a/net

[U-Boot] [PATCH v3 10/18] net: Add net_update_ether() to handle ARP and Ping replies

2012-05-23 Thread Joe Hershberger
When the network is VLAN or SNAP, net_update_ether() will preserve the original Ethernet packet header and simply replace the src and dest MACs and the protocol Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches

[U-Boot] [PATCH v3 12/18] net: Fix unused variable compile warning

2012-05-23 Thread Joe Hershberger
If CONFIG_BOOTP_SERVERIP is not defined, unused variable warning is reported. This was fixed upstream using a compiler feature instead of a simple reorder of the statements. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed

[U-Boot] [PATCH v3 13/18] net: Add option CONFIG_BOOTP_MAY_FAIL

2012-05-23 Thread Joe Hershberger
This is useful if you want to look for a DHCP server, but try some other settings if not available. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Renamed to CONFIG_BOOTP_MAY_FAIL Changes for v3: - Rebased onto other changed patches README |7

[U-Boot] [PATCH v3 04/18] net: Refactor bootp packet length computations

2012-05-23 Thread Joe Hershberger
Eliminate pointer subtraction that recovers values computed earlier Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split debug message move to a separate commit Changes for v3: - Rebased onto other changed patches net/bootp.c | 24 +--- 1

[U-Boot] [PATCH v3 14/18] net: Remove static allocation for MAC address in PingSend()

2012-05-23 Thread Joe Hershberger
Don't force ARP clients to return the MAC address if they don't care (such as ping) Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/arp.c |9 + net/ping.c | 10 +++--- 2 files

[U-Boot] [PATCH v3 16/18] net: Fix net buffer initialization

2012-05-23 Thread Joe Hershberger
A new non-static function net_init() will initialize buffers and read from the environment. Only update from the env on each entry to NetLoop(). Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Unadded explicit parameter name in net.h for NetLoop - Eliminate

[U-Boot] [PATCH v3 15/18] net: Remove unused parameter from NetInitLoop()

2012-05-23 Thread Joe Hershberger
Noone uses it. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Fix net buffer initialization" Changes for v3: - Rebased onto other changed patches - Added a short commit message net/net.c |4 ++-- 1 files changed, 2 insertions(+), 2

[U-Boot] [PATCH v3 08/18] net: Refactor to protect access to the NetState variable

2012-05-23 Thread Joe Hershberger
Changes to NetState now go through an accessor function called net_set_state() Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - net_set_state changed to static inline - States changed to an enum - Eliminate CamelCase in new functions. Changes for v3

[U-Boot] [PATCH v3 18/18] net: Don't copy every packet that waits for an ARP

2012-05-23 Thread Joe Hershberger
Use the NetArpTxPacket for the ARP packet, not to hold what used to be in NetTxPacket. This saves a copy and makes the code easier to understand. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches - Fixed comment

[U-Boot] [PATCH v3 17/18] net: Make sure NetLoop is initialized when using NetConsole

2012-05-23 Thread Joe Hershberger
Fix NetConsole bug that causes first packet header to claim a source IP address of 0.0.0.0 Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches - Fix comment style drivers/net/netconsole.c |6 ++ 1 files

[U-Boot] [PATCH v3 0/3] Add link-local addressing support

2012-05-23 Thread Joe Hershberger
. Tested on da850_am18xxevm Tested on MPC8313ERDB_33 This is dependant on the "Network stack refactoring" patch-series. This is a portion of the changes split from the series: "Add link-local addressing support" Joe Hershberger (3): net: Separate ArpRequest() into lower-level

[U-Boot] [PATCH v3 1/3] net: Separate ArpRequest() into lower-level func

2012-05-23 Thread Joe Hershberger
Link-local support will need to send ARP packets, but needs more fine-grained control over the contents. Split the implementation into 2 parts so link-local can share the code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Add link-local addre

[U-Boot] [PATCH v3 2/3] net: Add link-local addressing support

2012-05-23 Thread Joe Hershberger
Code based on networking/zcip.c in busybox commit 8531d76a15890c2c535908ce888b2e2aed35b172 Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Omitted unrelated whitespace changes - Made do_link_local() static - Pushed #ifdef CONFIG_CMD_LINK_LOCAL into header

[U-Boot] [PATCH v3 3/3] net: Work-around for brain-damaged Cisco equipment with arp-proxy

2012-05-23 Thread Joe Hershberger
eplying to the ARP request for 5ms so that the first packet is sent to the Cisco equipment and all following packets are sent to our device. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Guard with #ifdef CONFIG_CMD_LINK_LOCAL Changes for v3: - Rebased onto oth

[U-Boot] [PATCH v3] net: Allow filtering on debug traces in the net subsystem

2012-05-23 Thread Joe Hershberger
state changes Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Add link-local addressing support" patch-series - This patch is dependant on "Add link-local addressing support" patch-series - Knobs for enabling filters moved into

[U-Boot] Pull request: u-boot-net.git master

2012-05-23 Thread Joe Hershberger
Hi Wolfgang, This should include fixes for all the warnings from db288a96027fa1cb3f8a53f330724f864224a56c "net: Remove volatile from net API" The following changes since commit b86a475c1a602c6ee44f4469d933df8792418a7a: Joe Hershberger (1): MAKEALL: Report boards with errors v

Re: [U-Boot] [PATCH] drivers/net/xilinx_emaclite.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_emaclite.c: In function 'xilinx_emaclite_initialize': > xilinx_emaclite.c:371: warning: assignment from incompatible pointer type > > Signed-off-by: Stephan Linz Applied, thanks. -Joe _

Re: [U-Boot] [PATCH] drivers/net/xilinx_axi_emac.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_axi_emac.c: In function 'xilinx_axiemac_initialize': > xilinx_axi_emac.c:646: warning: assignment from incompatible pointer type > > Signed-off-by: Stephan Linz Applied, thanks. -Joe __

Re: [U-Boot] [PATCH] drivers/net/xilinx_ll_temac.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize': > xilinx_ll_temac.c:332: warning: assignment from incompatible pointer type > xilinx_ll_temac.c:340: warning: assignment from incompatible pointer type > > Signed-off-by:

Re: [U-Boot] [PATCH] net: sh_eth: Add support SH7734 Ethernet device

2012-05-23 Thread Joe Hershberger
Hi Nobuhiro Iwamatsu, On Fri, Feb 3, 2012 at 1:28 AM, Nobuhiro Iwamatsu wrote: > SH7734 has one channel ethernet device. > This support 10/100/1000Base, and RMII/MII/GMII. > And this has the same structure as SH7763. > > Signed-off-by: Nobuhiro Iwamatsu In the future, please run tools/checkpatc

Re: [U-Boot] [PATCH v2] net: sh-eth: Add support Gigabit of SH7734

2012-05-23 Thread Joe Hershberger
Hi Nobuhiro Iwamatsu, On Tue, May 15, 2012 at 8:49 PM, Nobuhiro Iwamatsu wrote: > SH7734 support GMII. This add register infomation and the function > which enable GMII. > > Signed-off-by: Nobuhiro Iwamatsu Applied, thanks. -Joe ___ U-Boot mailing li

Re: [U-Boot] [PATCH 7/7] pxe: add support for parsing local syslinux files

2012-05-23 Thread Joe Hershberger
Hi Rob, On Wed, Mar 28, 2012 at 10:51 AM, Rob Herring wrote: > From: Rob Herring > > Add a new command "sysboot" which parses syslinux menu files and boots > using kernel and initrd specified by menu files. The operation is similar > to "pxe boot" except local files on ext2 or fat filesystem are

Re: [U-Boot] [PATCH v3 08/21] net: cosmetic: Un-typedef IP_t

2012-05-23 Thread Joe Hershberger
Hi Anatolij, On Wed, May 23, 2012 at 5:36 PM, Anatolij Gustschin wrote: > Hi Joe, > > On Wed, 23 May 2012 12:58:04 -0500 > Joe Hershberger wrote: > ... >> --- a/net/rarp.c >> +++ b/net/rarp.c >> @@ -41,7 +41,7 @@ int RarpTry; >>  /* >>   *   Ha

Re: [U-Boot] undefined reference to `net_set_upd_handler'

2012-05-23 Thread Joe Hershberger
Hi Stephan, On Wed, May 23, 2012 at 5:46 PM, Stephan Linz wrote: > Hello Joe, > > just I've tried out your custodian network tree at a99acb7 and run in > the link error below: > > net/libnet.o: In function `NetLoop': > net/net.c:539: undefined reference to `net_set_upd_handler' > > I think it is

Re: [U-Boot] undefined reference to `net_set_upd_handler'

2012-05-23 Thread Joe Hershberger
Hi Stephan, On Wed, May 23, 2012 at 5:50 PM, Joe Hershberger wrote: > Hi Stephan, > > On Wed, May 23, 2012 at 5:46 PM, Stephan Linz wrote: >> Hello Joe, >> >> just I've tried out your custodian network tree at a99acb7 and run in >> the link error below: &g

Re: [U-Boot] [PATCH 7/7] pxe: add support for parsing local syslinux files

2012-05-23 Thread Joe Hershberger
Hi Rob, On Wed, May 23, 2012 at 5:57 PM, Rob Herring wrote: > On 05/23/2012 05:11 PM, Joe Hershberger wrote: >> Hi Rob, >> >> On Wed, Mar 28, 2012 at 10:51 AM, Rob Herring wrote: >>> From: Rob Herring >>> >>> Add a new command "sysboot&

Re: [U-Boot] [PATCH v5 0/5] Kirkwood: add lschlv2 and lsxhl board support

2012-05-25 Thread Joe Hershberger
Hi Prafulla, On Fri, May 25, 2012 at 9:13 AM, Prafulla Wadaskar wrote: >> -Original Message- >> From: Michael Walle [mailto:mich...@walle.cc] >> Sent: 12 May 2012 04:21 >> To: u-boot@lists.denx.de >> Cc: Prafulla Wadaskar; Wolfgang Denk; Mike Frysinger; Joe

Re: [U-Boot] [PATCH v5 2/5] net: add helper to generate random mac address

2012-05-25 Thread Joe Hershberger
On Fri, May 11, 2012 at 5:50 PM, Michael Walle wrote: > Add new function eth_random_enetaddr() to generate a locally administered > ethernet address. > > Signed-off-by: Michael Walle > Cc: Joe Hershberger Acked-by: Joe Hershberger ___

Re: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()

2012-05-25 Thread Joe Hershberger
Hi Michael, On Thu, May 17, 2012 at 3:43 PM, Michael Walle wrote: > > Hi Joe, > > Am Mittwoch 16 Mai 2012, 02:56:39 schrieb Joe Hershberger: >> Hi Michael, >> >> On Fri, May 11, 2012 at 5:50 PM, Michael Walle wrote: >> > Signed-off-by:

Re: [U-Boot] [PATCH 7/7] pxe: add support for parsing local syslinux files

2012-05-25 Thread Joe Hershberger
Hi Rob, On Wed, May 23, 2012 at 6:02 PM, Joe Hershberger wrote: > Hi Rob, > > On Wed, May 23, 2012 at 5:57 PM, Rob Herring wrote: >> On 05/23/2012 05:11 PM, Joe Hershberger wrote: >>> Hi Rob, >>> >>> On Wed, Mar 28, 2012 at 10:51 AM, Rob Herring wrot

Re: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()

2012-05-25 Thread Joe Hershberger
Hi Michael, On Fri, May 25, 2012 at 2:54 PM, Michael Walle wrote: > Am Freitag 25 Mai 2012, 20:50:09 schrieb Joe Hershberger: > [..snip..] >> That way you aren't adding a function that noone else uses and you >> don't need a silly guard around it. > > Hi Joe,

Re: [U-Boot] [PATCH v2] pxe: add support for parsing local syslinux files

2012-05-25 Thread Joe Hershberger
Hi Rob, On Fri, May 25, 2012 at 3:47 PM, Rob Herring wrote: > From: Rob Herring > > Add a new command "sysboot" which parses syslinux menu files and boots > using kernel and initrd specified by menu files. The operation is similar > to "pxe boot" except local files on ext2 or fat filesystem are

Re: [U-Boot] [PATCH v3 02/21] net: Move MAC-seeded rand out of bootp.c

2012-05-29 Thread Joe Hershberger
Hi Michael, On Mon, May 28, 2012 at 5:03 PM, Michael Walle wrote: > [sorry for my first mail.. wasn't intented to be send] > > > Sorry for being too late on this. > > Am Mittwoch 23 Mai 2012, 19:57:58 schrieb Joe Hershberger: >> Make the MAC-seeded random number g

Re: [U-Boot] [PATCH v3 02/21] net: Move MAC-seeded rand out of bootp.c

2012-05-29 Thread Joe Hershberger
Hi Michael, On Tue, May 29, 2012 at 1:23 PM, Michael Walle wrote: > Hi Joe, > > Am Dienstag 29 Mai 2012, 20:08:26 schrieb Joe Hershberger: >> If you can verify that the functionality of the >> CONFIG_BOOTP_RANDOM_DELAY and CONFIG_CMD_LINK_LOCAL are uneffected, >> the

Re: [U-Boot] [PATCH v3 02/21] net: Move MAC-seeded rand out of bootp.c

2012-05-29 Thread Joe Hershberger
Hi Michael, On Tue, May 29, 2012 at 5:06 PM, Michael Walle wrote: > > Hi Joe, > > Am Dienstag 29 Mai 2012, 23:08:23 schrieb Joe Hershberger: >> Hi Michael, >> >> On Tue, May 29, 2012 at 1:23 PM, Michael Walle wrote: >> > Hi Joe, >> > &g

Re: [U-Boot] [PATCH v7 2/4] net: use common rand()/srand() functions

2012-05-31 Thread Joe Hershberger
: Michael Walle > Cc: Joe Hershberger > --- >  include/configs/ETX094.h          |    1 + >  include/configs/MERGERBOX.h       |    1 + >  include/configs/MVBC_P.h          |    1 + >  include/configs/MVBLM7.h          |    1 + >  include/configs/MVSMR.h           |    1 +

Re: [U-Boot] [PATCH v7 2/4] net: use common rand()/srand() functions

2012-05-31 Thread Joe Hershberger
On Thu, May 31, 2012 at 2:04 PM, Joe Hershberger wrote: > Hi Michael, > > On Thu, May 31, 2012 at 1:12 PM, Michael Walle wrote: >> Replace rand() with the functions from lib/. The link-local network code >> stores its own seed, derived from the MAC address. Thus making i

Re: [U-Boot] [PATCH] net: Multiple updates/enhancements to designware.c

2012-06-04 Thread Joe Hershberger
is patch? If yes, perhaps it would be best if I would push > this patch with the other SPEAr platform patches upstream. What do you think? > Can I have your Acked-by? I'm not especially fond of adding prints, but it seems in line with the existing behavior. Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v8 2/4] net: use common rand()/srand() functions

2012-06-04 Thread Joe Hershberger
: Michael Walle > Cc: Joe Hershberger > --- Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Joe Hershberger
Hi Prafulla, On Jun 5, 2012, at 9:10 AM, Prafulla Wadaskar wrote: > > >> -Original Message- >> From: Michael Walle [mailto:mich...@walle.cc] >> Sent: 05 June 2012 16:39 >> To: Prafulla Wadaskar >> Cc: u-boot@lists.denx.de; Joe Hershberger >>

Re: [U-Boot] [PATCH v9 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Joe Hershberger
Hi Prafulla, On Tue, Jun 5, 2012 at 4:36 PM, Michael Walle wrote: > > Hi Prafulla, > > Am Dienstag 05 Juni 2012, 23:33:13 schrieb Michael Walle: >> Changes: >> v9: >>  - rebase to marvell custodian tree, merged with wolfgangs master > [..snip..] > > > I had to merge your tree with wolfgangs maste

Re: [U-Boot] [PATCH] net: configure DWMAC DMA by default AXI burst length

2015-01-27 Thread Joe Hershberger
On Mon, Jan 26, 2015 at 8:54 PM, wrote: > > From: Sonic Zhang > > Board can define its own AXI burst length to improve DWMAC DMA performance. > > Signed-off-by: Sonic Zhang > --- > > drivers/net/designware.c |2 ++ > drivers/net/designware.h |5 + > 2 files changed, 7 insertions(+)

Re: [U-Boot] [PATCH 1/2] RFC: dm: Kconfig: Move all driver model CONFIGs to Kconfig

2015-01-27 Thread Joe Hershberger
On Tue, Dec 9, 2014 at 7:21 AM, Simon Glass wrote: > > Kconfig has been available for a while but there are still driver model > CONFIG options. Move all of these to Kconfig. > > This patch isn't final - I need to wait until the SPL series can be fully > applied, which is in turn waiting on some A

[U-Boot] [RFC PATCH 2/7] net: Rename helper function to be more clear

2015-01-27 Thread Joe Hershberger
Make it clear that the helper is checking the addr, not setting it. Signed-off-by: Joe Hershberger --- net/eth.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/eth.c b/net/eth.c index eac4f7b..65e8c77 100644 --- a/net/eth.c +++ b/net/eth.c @@ -153,11

[U-Boot] [RFC PATCH 0/7] Add Driver Model support to network stack

2015-01-27 Thread Joe Hershberger
For now this simply addresses the MAC part of the network hardware. The next part to implement is the PHY children. I wanted to get early feedback on what I have so far to make sure I'm going in the direction that Simon envisioned. Joe Hershberger (7): net: Provide a function to ge

[U-Boot] [RFC PATCH 7/7] net: Add ARP and PING response to sandbox driver

2015-01-27 Thread Joe Hershberger
The sandbox driver will now generate response traffic to exercise the ping command even when no network exists. This allows the basic data pathways of the DM to be tested. Signed-off-by: Joe Hershberger --- drivers/net/sandbox.c | 75 +++ 1 file

[U-Boot] [RFC PATCH 1/7] net: Provide a function to get the current MAC address

2015-01-27 Thread Joe Hershberger
The current implementation exposes the eth_device struct to code that needs to access the MAC address. Add a wrapper function for this to abstract away the pointer for this operation. Signed-off-by: Joe Hershberger --- arch/mips/cpu/mips32/au1x00/au1x00_eth.c | 2 +- arch/powerpc/cpu/mpc8260

[U-Boot] [RFC PATCH 4/7] net: Refactor in preparation for driver model

2015-01-27 Thread Joe Hershberger
Move some things around and organize things so that the driver model implementation will fit in more easily. Signed-off-by: Joe Hershberger --- include/net.h | 63 + net/eth.c | 75

[U-Boot] [RFC PATCH 3/7] net: Remove unneeded "extern" in net.h

2015-01-27 Thread Joe Hershberger
Many of the functions in net.h were preceded extern needlessly. Removing them to limit the number of checkpatch.pl complaints. Signed-off-by: Joe Hershberger --- include/net.h | 96 +-- 1 file changed, 48 insertions(+), 48 deletions

[U-Boot] [RFC PATCH 5/7] net: Add basic driver model support to Ethernet stack

2015-01-27 Thread Joe Hershberger
First just add support for MAC drivers. Signed-off-by: Joe Hershberger --- common/board_r.c | 4 +- common/cmd_bdinfo.c| 2 + include/dm/uclass-id.h | 1 + include/net.h | 23 net/eth.c | 320 - 5 files

[U-Boot] [RFC PATCH 6/7] net: Add network support to sandbox

2015-01-27 Thread Joe Hershberger
Add basic network support to sandbox which includes a network driver. Signed-off-by: Joe Hershberger --- arch/sandbox/dts/sandbox.dts | 4 ++ drivers/net/Makefile | 2 + drivers/net/sandbox.c| 91 include/configs/sandbox.h| 14

Re: [U-Boot] [PATCH] net: configure DWMAC DMA by default AXI burst length

2015-01-28 Thread Joe Hershberger
On Tue, Jan 27, 2015 at 9:24 PM, Sonic Zhang wrote: > > Hi Joe, > > On Wed, Jan 28, 2015 at 4:43 AM, Joe Hershberger > wrote: > > On Mon, Jan 26, 2015 at 8:54 PM, wrote: > >> > >> From: Sonic Zhang > >> > >> Board can define its o

Re: [U-Boot] [RFC PATCH 1/7] net: Provide a function to get the current MAC address

2015-01-28 Thread Joe Hershberger
On Tue, Jan 27, 2015 at 8:33 PM, Simon Glass wrote: > > Hi Joe, > > On 27 January 2015 at 16:27, Joe Hershberger wrote: > > The current implementation exposes the eth_device struct to code that > > needs to access the MAC address. Add a wrapper function for this to >

Re: [U-Boot] [RFC PATCH 5/7] net: Add basic driver model support to Ethernet stack

2015-01-28 Thread Joe Hershberger
On Tue, Jan 27, 2015 at 8:34 PM, Simon Glass wrote: > > Hi Joe, > > On 27 January 2015 at 16:27, Joe Hershberger wrote: > > First just add support for MAC drivers. > > > > I don't fully understand this partly because my knowledge of the > network stack is li

Re: [U-Boot] [RFC PATCH 6/7] net: Add network support to sandbox

2015-01-28 Thread Joe Hershberger
On Tue, Jan 27, 2015 at 8:34 PM, Simon Glass wrote: > > Hi Joe, > > On 27 January 2015 at 16:27, Joe Hershberger wrote: > > Add basic network support to sandbox which includes a network driver. > > > > Signed-off-by: Joe Hershberger > > --- > &

Re: [U-Boot] [PATCH v3] net: configure DWMAC DMA by default AXI burst length

2015-01-29 Thread Joe Hershberger
_bus register member to struct eth_dma_regs. > > Signed-off-by: Sonic Zhang > --- Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

2015-01-30 Thread Joe Hershberger
On Fri, Jan 30, 2015 at 4:04 AM, Marek Vasut wrote: > > On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote: > > Hi Marek, Tom, > > > > On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote: > > > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote: > > > > If for some reason DMA module

Re: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

2015-01-30 Thread Joe Hershberger
> Cc: Albert Aribaud > Cc: Tom Rini > Cc: Wolfgang Denk > Cc: Pavel Machek > Cc: Joe Hershberger > Cc: Ian Campbell > Cc: Marek Vasut > --- Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] net: tsec: Pending patches

2015-01-30 Thread Joe Hershberger
On Fri, Feb 14, 2014 at 3:49 AM, Claudiu Manoil < claudiu.man...@freescale.com> wrote: > > Hello, > > Would you please consider applying these two "net" tree patches? > > http://patchwork.ozlabs.org/patch/299620/ > (net: Merge asm/fsl_enet.h into fsl_mdio.h) > http://patchwork.ozlabs.org/patch/2994

Re: [U-Boot] [PATCH 1/2] net: tsec: Fix NULL access in case init_phy() fails

2015-01-30 Thread Joe Hershberger
On Tue, Dec 10, 2013 at 7:21 AM, Claudiu Manoil < claudiu.man...@freescale.com> wrote: > > If the PHY is not recognized don't access phydev (NULL) > and return 0 to signal failure. > > Signed-off-by: Claudiu Manoil > --- Applied, Thanks! -Joe ___ U-Boot

Re: [U-Boot] [PATCH v2 2/6] Add MS7206SE ethernet support

2015-01-30 Thread Joe Hershberger
On Thu, Feb 13, 2014 at 8:13 AM, Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > --- Huge apologies for the delay. Applied, Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: phy: micrel: add support for KSZ8895 switch in SMI mode

2015-01-30 Thread Joe Hershberger
On Wed, Feb 19, 2014 at 10:21 AM, Philippe De Muyter wrote: > > This patch adds a phy driver for the Micrel KSZ8895 switch. As the SoC MAC > is directly connected to the switch MAC the link to the switch is always up. > > But the KSZ8895 switch can be hardwired in three configuration modes : > -

Re: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout

2015-01-30 Thread Joe Hershberger
> Cc: Albert Aribaud > Cc: Tom Rini > Cc: Wolfgang Denk > Cc: Pavel Machek > Cc: Joe Hershberger > Cc: Ian Campbell > Cc: Marek Vasut > --- Applied, Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Pull request: u-boot-net.git master

2015-01-30 Thread Joe Hershberger
The following changes since commit 2af13d6b6265a6700c4f65597410b769895024bf: lcd: fix console address is not initialized (2015-01-28 16:58:02 -0500) are available in the git repository at: git://git.denx.de/u-boot-net.git master for you to fetch changes up to 875143f32428b8317a2b890b34a1eeb

[U-Boot] [RFC PATCH v2 0/8] Add Driver Model support to network stack

2015-02-02 Thread Joe Hershberger
efore eth_init()). -Change printfs to debug in sandbox driver -Remove unused priv struct for sandbox driver -Change printfs to debug in sandbox driver -Move static data to priv -Move fake hwaddr to the device tree -Added the raw packet proof-of-concept patch. Joe Hershberger (8): net: Provide a

[U-Boot] [RFC PATCH v2 2/8] net: Rename helper function to be more clear

2015-02-02 Thread Joe Hershberger
Make it clear that the helper is checking the addr, not setting it. Signed-off-by: Joe Hershberger --- Changes in v2: None net/eth.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/eth.c b/net/eth.c index eac4f7b..65e8c77 100644 --- a/net/eth.c +++ b/net

[U-Boot] [RFC PATCH v2 6/8] net: Add network support to sandbox

2015-02-02 Thread Joe Hershberger
Add basic network support to sandbox which includes a network driver. Signed-off-by: Joe Hershberger --- Changes in v2: -Change printfs to debug in sandbox driver -Remove unused priv struct for sandbox driver arch/sandbox/dts/sandbox.dts | 4 +++ drivers/net/Makefile | 2

[U-Boot] [RFC PATCH v2 4/8] net: Refactor in preparation for driver model

2015-02-02 Thread Joe Hershberger
Move some things around and organize things so that the driver model implementation will fit in more easily. Signed-off-by: Joe Hershberger --- Changes in v2: None include/net.h | 63 + net/eth.c | 75

[U-Boot] [RFC PATCH v2 7/8] net: Add ARP and PING response to sandbox driver

2015-02-02 Thread Joe Hershberger
The sandbox driver will now generate response traffic to exercise the ping command even when no network exists. This allows the basic data pathways of the DM to be tested. Signed-off-by: Joe Hershberger --- Changes in v2: -Change printfs to debug in sandbox driver -Move static data to priv

[U-Boot] [RFC PATCH v2 1/8] net: Provide a function to get the current MAC address

2015-02-02 Thread Joe Hershberger
The current implementation exposes the eth_device struct to code that needs to access the MAC address. Add a wrapper function for this to abstract away the pointer for this operation. Signed-off-by: Joe Hershberger --- Changes in v2: None arch/mips/cpu/mips32/au1x00/au1x00_eth.c | 2 +- arch

[U-Boot] [RFC PATCH v2 3/8] net: Remove unneeded "extern" in net.h

2015-02-02 Thread Joe Hershberger
Many of the functions in net.h were preceded extern needlessly. Removing them to limit the number of checkpatch.pl complaints. Signed-off-by: Joe Hershberger --- Changes in v2: None include/net.h | 96 +-- 1 file changed, 48 insertions

[U-Boot] [RFC PATCH v2 8/8] net: Add actual networking support to sandbox's driver

2015-02-02 Thread Joe Hershberger
This doesn't build right now Signed-off-by: Joe Hershberger --- Changes in v2: -Added the raw packet proof-of-concept patch. drivers/net/sandbox-raw.c | 60 +++ drivers/net/sandbox.c | 23 ++ 2 files changed, 83 inser

[U-Boot] [RFC PATCH v2 5/8] net: Add basic driver model support to Ethernet stack

2015-02-02 Thread Joe Hershberger
First just add support for MAC drivers. Signed-off-by: Joe Hershberger --- Changes in v2: -Updated comments -Removed extra parentheses -Changed eth_uclass_priv local var names to be uc_priv -Update error codes -Cause an invalid name to fail binding -Rebase on top of dm/master -Stop maintaining

[U-Boot] [PATCH 1/2] cmd_fdt: Actually fix fdt command in sandbox

2015-02-03 Thread Joe Hershberger
Commit 90bac29a76bc8d649b41a55f2786c0abef9bb2c1 claims to fix this bug that was introduced in commit a92fd6577ea17751ead9b50243e3c562125cf581 but doesn't actually make the change that the commit message describes. Actually fix the bug this time. Signed-off-by: Joe Hershberger --- c

[U-Boot] [PATCH 2/2] cmd_fdt: Print the control fdt in terms of virtual memory

2015-02-03 Thread Joe Hershberger
If you want to inspect the control device tree using the fdt command, the "fdt address -c" command previously unhelpfully printed the phys memory address of the device tree. That address could not then be used to set the fdt address for inspection. Signed-off-by: Joe Hershberger --

[U-Boot] [PATCH v2 2/2] cmd_fdt: Print the control fdt in terms of virtual memory

2015-02-04 Thread Joe Hershberger
hat can be copied directly to the 'fdt address ' command. Signed-off-by: Joe Hershberger --- Changes in v2: -Reworded commit message common/cmd_fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c index 4e9bc6b..b213105 100644 --

[U-Boot] [PATCH v2 1/2] cmd_fdt: Actually fix fdt command in sandbox

2015-02-04 Thread Joe Hershberger
Commit 90bac29a76bc8d649b41a55f2786c0abef9bb2c1 claims to fix this bug that was introduced in commit a92fd6577ea17751ead9b50243e3c562125cf581 but doesn't actually make the change that the commit message describes. Actually fix the bug this time. Signed-off-by: Joe Hershberger --- Chang

<    1   2   3   4   5   6   7   8   9   10   >