Re: u-boot crashes if mass-storage devices are connected via USB-C

guided me write my bug report > > > to this email. "bluetail: please report these usb bugs upstream; they're > > > almost certainly not hardware-specific" > > > > > > But before, jannau aka Janne Grunau asked me to give the version output > >

Re: u-boot crashes if mass-storage devices are connected via USB-C

On 2023-03-02 18:33:15 +0100, Marek Vasut wrote: > On 3/2/23 10:14, Janne Grunau wrote: > > On 2023-03-01 23:51:14 +0100, Marek Vasut wrote: > > > On 3/1/23 21:34, Simon Glass wrote: > > > > +Marek Vasut +Bin Meng +Mark Kettenis +Tom Rini > > > > >

Re: u-boot crashes if mass-storage devices are connected via USB-C

On 2023-03-02 22:05:43 +0100, Marek Vasut wrote: > On 3/2/23 19:51, Janne Grunau wrote: > > On 2023-03-02 18:33:15 +0100, Marek Vasut wrote: > > > On 3/2/23 10:14, Janne Grunau wrote: > > > > On 2023-03-01 23:51:14 +0100, Marek Vasut wrote: > > >

[PATCH] pci: apple: Initialize only enabled ports

The Linux devicetrees for Apple silicon devices are after review feedback switching from deleting unused PCIe ports to disabling them. Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab0...@linaro.org/ Signed-off-by: Janne Grunau --- drivers/pci/pcie_apple.c | 2 ++ 1 file

[PATCH] apple_m1_defconfig: Bump CONFIG_LMB_MAX_REGIONS to 64

large amount of reserved-memory regions. Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index b4ecf73cbc78..755560971e57 100644 --- a/configs/apple_m1_defconfig +++ b/configs

[PATCH] arm: apple: Add initial Apple M2 Ultra support

Apple's M2 Ultra SoC are somewhat similar to the M1 Ultra but needs a tweaked memory map as the M2 Pro/Max SoCs. USB, NVMe, UART, WDT and PCIe are working with the existing drivers. Signed-off-by: Janne Grunau --- arch/arm/mach-apple/board.c

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > Fixes a crash during probing of sd card readers without medium present. > > Link: https://github.com/AsahiLinux/linux/issues/44 > Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html > Signed-off-by: Janne Grunau

Re: [PATCH 1/1] usb: request only 8 bytes for USB_SPEED_FULL bMaxPacketSize0 discovery

On 2022-09-26 01:52:37 +0200, Marek Vasut wrote: > On 8/29/22 08:31, Janne Grunau wrote: > > Fixes probing of various keyboards with DWC3 as integrated into Apple > > silicon SoCs. The problem appears to be requesting more data than the > > devices's bMaxPacketSize0 of

[PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

Fixes a crash during probing of sd card readers without medium present. Link: https://github.com/AsahiLinux/linux/issues/44 Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html Signed-off-by: Janne Grunau --- Changes since v1: - changed unconditiona return to "continu

Re: [PATCH] usb: Add delay for control messages to reach usb stick

icon devices are desktop style machines I expect it's not uncommon to see systems with many USB devices. > + > err = submit_control_msg(dev, pipe, data, size, setup_packet); > if (err < 0) > return err; > -- > 2.17.1 > >From df9e5b78687

Re: [PATCH] usb: Add delay for control messages to reach usb stick

On 2022-08-26 18:20:57 -0600, Simon Glass wrote: > Hi, > > On Fri, 26 Aug 2022 at 13:37, Janne Grunau wrote: > > > > Hej, > > > > On 2022-08-25 23:35:33 -0600, Ashok Reddy Soma wrote: > > > We are seeing timing issues with transcend usb sticks. These dev

[PATCH 1/1] usb: request only 8 bytes for USB_SPEED_FULL bMaxPacketSize0 discovery

Fixes probing of various keyboards with DWC3 as integrated into Apple silicon SoCs. The problem appears to be requesting more data than the devices's bMaxPacketSize0 of 8. Older Logitech unifying receivers (bcdDevice 12.03 or 12.10) are for eaxample affected. Signed-off-by: Janne Grunau T

Re: RFC: Handling of multiple EFI System Partitions

On 2022-12-18 20:40:20 +0100, Heinrich Schuchardt wrote: > > > Am 18. Dezember 2022 15:21:06 MEZ schrieb Mark Kettenis > : > >The Asahi installer, which is what most people use to get their Apple > >Silicon Mac into a state where it is possible to install another OS on > >the machine, offers the

Re: [PATCH RFC 0/6] video: Add UTF-8 support for UEFI applications

Hej Heinrich, On Thu, Jan 18, 2024, at 17:47, Heinrich Schuchardt wrote: > On 1/17/24 23:24, Janne Grunau via B4 Relay wrote: >> Andre submitted 2 years ago DM_VIDEO improvements for UEFI applications >> using UEFI's EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL but did not follow with

Re: [PATCH] arm: apple: t602x: Add missing MMIO regions to memmap

Hej Mark, On Thu, Nov 30, 2023, at 21:45, Mark Kettenis wrote: >> From: Janne Grunau via B4 Relay >> Date: Thu, 30 Nov 2023 13:42:22 +0100 >> >> From: Janne Grunau >> >> The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which >&

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek Vasut wrote: > On 4/4/24 8:25 AM, Janne Grunau via B4 Relay wrote: > > Apple USB Keyboards from 2021 need quirks to be useable. The boot HID > > keyboard protocol is unfortunately not described in the first interface > > desc

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

On Sat, Apr 06, 2024 at 08:52:17PM +0200, Marek Vasut wrote: > On 4/5/24 9:05 PM, Janne Grunau wrote: > > On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek Vasut wrote: > >> On 4/4/24 8:25 AM, Janne Grunau via B4 Relay wrote: > >>> Apple USB Keyboards from 2021 need

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

On Sun, Apr 07, 2024 at 03:05:59AM +0200, Marek Vasut wrote: > On 4/6/24 10:04 PM, Janne Grunau wrote: > > On Sat, Apr 06, 2024 at 08:52:17PM +0200, Marek Vasut wrote: > >> On 4/5/24 9:05 PM, Janne Grunau wrote: > >>> On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek V

Re: [PATCH 4/4] arm: apple: Switch to standard boot

On Mon, Apr 15, 2024 at 04:24:51PM +0200, Mark Kettenis wrote: > > From: Janne Grunau via B4 Relay > > Date: Sun, 17 Mar 2024 15:54:50 +0100 > > > > From: Janne Grunau > > > > Use standard boot instead of the distro boot scripts. > > > > Sig

Re: [PATCH RFC 4/6] efi_selftest: Add international characters test

Hej, On Thu, Jan 18, 2024, at 19:48, Heinrich Schuchardt wrote: > On 1/17/24 23:24, Janne Grunau via B4 Relay wrote: >> From: Andre Przywara >> >> UEFI relies entirely on unicode output, which actual fonts displayed on >> the screen might not be ready for. >&

Re: [PATCH v2 5/6] efi_selftest: Add box drawing character selftest

Hej, On Mon, Feb 12, 2024, at 17:07, Heinrich Schuchardt wrote: > On 10.02.24 13:46, Janne Grunau via B4 Relay wrote: >> From: Andre Przywara >> >> UEFI applications rely on Unicode output capability, and might use that >> for drawing pseudo-graphical interface

Re: [PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

On Wed, Feb 21, 2024, at 13:39, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Apple USB keyboards carry the HID keyboard boot protocol on the second >> interface. Using the second interface in the USB keyboard dr

Re: [PATCH 3/6] usb: xhci: Abort transfers with unallocated rings

Hej, On Wed, Feb 21, 2024, at 13:40, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Discovered while trying to use the second interface in the USB keyboard >> driver necessary on Apple USB keyboards. >>

Re: [PATCH 4/6] usb: kbd: Ignore Yubikeys

Hej, On Wed, Feb 21, 2024, at 13:41, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Hector Martin >> >> We currently only support one USB keyboard device, but some devices >> emulate keyboards for other purposes. Most commonly, p

Re: [PATCH 4/6] usb: kbd: Ignore Yubikeys

Hej, On Mon, Feb 26, 2024, at 21:47, Mark Kettenis wrote: >> Date: Sun, 25 Feb 2024 22:57:23 +0100 >> From: Marek Vasut >> >> On 2/25/24 5:07 PM, Janne Grunau wrote: >> > Hej, >> > >> > On Wed, Feb 21, 2024, at 13:41, Marek Vasut wrote: >

Re: [PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

Hej, On Sun, Feb 25, 2024, at 22:47, Marek Vasut wrote: > On 2/25/24 4:28 PM, Janne Grunau wrote: >> >> >> On Wed, Feb 21, 2024, at 13:39, Marek Vasut wrote: >>> On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >>>> From: Janne Grunau >>>>

[PATCH v2 0/3] Improve robustness of NVMe suuport for Apple silicon devices

compatible strings to the SoC specified ones from the Linux devicetree bindings Janne Grunau (3): arm: apple: nvme: Add SART support and RTKit buffer management MAINTAINERS: Add nvme_apple to Apple SoC section arm: apple: Increase RTKit timeouts MAINTAINERS |

[PATCH v2 2/3] MAINTAINERS: Add nvme_apple to Apple SoC section

Signed-off-by: Janne Grunau --- (no changes since v1) MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 28e4d3823861..a15ba7abdcd6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -121,6 +121,7 @@ F: arch/arm/include/asm/arch-m1/ F: arch/arm

[PATCH v2 3/3] arm: apple: Increase RTKit timeouts

Timeouts are not expected to happen and are handled as fatal errors. Increase all timeouts to 1 second as defensive measure to avoid relying on the timing behaviour of certain firmware versions or configurations. Signed-off-by: Janne Grunau --- (no changes since v1) arch/arm/mach-apple

[PATCH v2 1/3] arm: apple: nvme: Add SART support and RTKit buffer management

or RTKit. These are generic since other devices (none in u-boot so far) require different handling. Signed-off-by: Janne Grunau --- Changes in v2: - The generation compatible strings "apple,sart2" "apple,sart3" got droppend from the bindings merged for Linux 5.19. U

[PATCH 1/2] iommu: Add M2 support to Apple DART driver

"apple,t8112-dart" uses an incompatible register interface but still offers the same functionality. This DART is found on the M2 and M1 Pro/Max/Ultra SoCs. Signed-off-by: Janne Grunau --- drivers/iommu/apple_dart.c | 18 +- 1 file changed, 17 insertions(+), 1 deletio

[PATCH 2/2] arm: apple: Add initial Apple M2 support

Signed-off-by: Janne Grunau --- arch/arm/mach-apple/board.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-apple/board.c b/arch/arm/mach-apple/board.c index 1525a9edee8e..16046423128c 100644 --- a/arch/arm/mach-apple/board.c +++ b/arch/arm/mach-apple/b

Re: [PATCH] usb: Add 1ms delay after first Get Descriptor request

uing subsequent requests to avoid probe failure with > > > this device, since it can be used to connect USB keyboards. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Janne Grunau > > > Cc: Mark Kettenis > > > --- > > &

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

On 2022-09-28 04:20:52 -0600, Simon Glass wrote: > +Marek Vasut > +Tom Rini > > On Sun, 25 Sept 2022 at 23:07, Janne Grunau wrote: > > > > On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > > > Fixes a crash during probing of sd card readers without medium

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

On 2022-11-03 23:23:52 +0100, Marek Vasut wrote: > On 11/3/22 22:36, Janne Grunau wrote: > > On 2022-09-28 04:20:52 -0600, Simon Glass wrote: > > > +Marek Vasut > > > +Tom Rini > > > > > > On Sun, 25 Sept 2022 at 23:07, Janne Grunau wrote: > &g

[PATCH v3 1/1] usb: storage: continue probe on "Invalid device"

iProduct2 USB3.0 Card Reader iSerial 3 201404081410 Link: https://github.com/AsahiLinux/linux/issues/44 Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html Signed-off-by: Janne Grunau Reviewed-by: Simon Glass Reviewed-by: Marek Vasut --- common

[PATCH 1/1] arm: apple: Add M1 Ultra support

The M1 Ultra consists of two M1 Max dies. The second die's I/O is at a consistent offset of 0x20. Signed-off-by: Janne Grunau --- arch/arm/mach-apple/board.c | 167 1 file changed, 167 insertions(+) diff --git a/arch/arm/mach-apple/board.c b

[PATCH 0/3] Improve robustness of NVMe suuport for Apple silicon devices

e firmware included in the first macOS 13 beta release. The increased timeouts in RTKit are a defensive change against future changes. None of the mailbox receive calls is expected to timeout so waiting up to 1 second for a fatal error seems acceptable. cheers Janne Janne Grunau (3): arm: a

[PATCH 1/3] arm: apple: nvme: Add SART support and RTKit buffer management

or RTKit. These are generic since other devices (none in u-boot so far) require different handling. Signed-off-by: Janne Grunau --- arch/arm/include/asm/arch-apple/rtkit.h | 22 ++- arch/arm/include/asm/arch-apple/sart.h | 22 +++ arch/arm/mach-apple/Makefile| 1 + arch/arm/mac

[PATCH 2/3] MAINTAINERS: Add nvme_apple to Apple SoC section

Signed-off-by: Janne Grunau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 28e4d3823861..a15ba7abdcd6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -121,6 +121,7 @@ F: arch/arm/include/asm/arch-m1/ F: arch/arm/mach-apple/ F

[PATCH 3/3] arm: apple: Increase RTKit timeouts

Timeouts are not expected to happen and are handled as fatal errors. Increase all timeouts to 1 second as defensive measure to avoid relying on the timing behaviour of certain firmware versions or configurations. Signed-off-by: Janne Grunau --- arch/arm/mach-apple/rtkit.c | 10 ++ 1

[PATCH 1/1] usb: storage: stop probe on "Invalid device"

Fixes a crash during probing of sd card readers without medium present. Link: https://github.com/AsahiLinux/linux/issues/44 Signed-off-by: Janne Grunau --- common/usb_storage.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/usb_storage.c b/common/usb_storage.c

[U-Boot] [PATCH 1/1] ARM: OMAP4: fix DDR timings for OMAP4430 ES2.0

DDR timings were broken since 47abc3df701d8bc26f311350aa523fc1d0f8ad4e for PandaBoard EA1. Signed-off-by: Janne Grunau --- arch/arm/cpu/armv7/omap4/hw_data.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/cpu/armv7/omap4/hw_data.c b/arch/arm/cpu/armv7/omap4

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

Hej, On Sun, Mar 17, 2024, at 12:07, Janne Grunau via B4 Relay wrote: > From: Janne Grunau > > Add the environment variable "usb_blocklist" to prevent USB devices > listed in it from being used. This allows to ignore devices which > trigger bugs in u-boot's USB stac

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

Hej, On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: > On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Add the environment variable "usb_blocklist" to prevent USB devices >> listed in it from being used. This allows to ig

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

On Mon, Mar 18, 2024, at 06:06, Marek Vasut wrote: > On 3/17/24 7:15 PM, Janne Grunau wrote: >> Hej, > > Hi, > >> On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: >>> On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: >>>> From: Janne G

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

Hej, On Sun, Mar 17, 2024, at 22:39, E Shattow wrote: > Should be usb_denylist, since "block devices" is ambiguous meaning if > it is a list of data chunks (blocks) or if it blocks (deny). There is > no question what a denylist is. I briefly thought of that concluded that the spelling "blocklist"

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

On Mon, Mar 18, 2024 at 03:17:33PM +0100, Marek Vasut wrote: > On 3/18/24 8:33 AM, Janne Grunau wrote: > > >>>>> +static int usb_blocklist_parse_error(const char *blocklist, size_t pos) > >>>>> +{ > >>>>> + pri

Re: [PATCH v3 4/7] efi_selftest: Add international characters test

On Sun, Mar 17, 2024 at 10:24:13AM +0100, Heinrich Schuchardt wrote: > On 3/16/24 22:50, Janne Grunau via B4 Relay wrote: > > From: Andre Przywara > > > > UEFI relies entirely on unicode output, which actual fonts displayed on > > the screen might not be ready for. &g

Re: [PATCH v3 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

On Fri, Mar 22, 2024 at 09:17:08AM +0100, Heinrich Schuchardt wrote: > On 3/22/24 08:47, Janne Grunau via B4 Relay wrote: > > From: Janne Grunau > > > > The xhci driver currently only does the necessary initialization for > > endpoints found in the first interface desc

Re: [PATCH v3 4/6] usb: Add environment based device ignorelist

On Fri, Mar 22, 2024 at 12:56:37PM +0100, Marek Vasut wrote: > On 3/22/24 8:47 AM, Janne Grunau via B4 Relay wrote: > > [...] > > > @@ -1099,6 +1142,20 @@ int usb_select_config(struct usb_device *dev) > > le16_to_cpus(&dev->descriptor.idProd

[PATCH 1/1] arm: apple: Switch to fully dynamic mem layout

(). Tested on Mac Mini (2020) and Macbook Pro 14-inch (2021). Signed-off-by: Janne Grunau --- arch/arm/mach-apple/board.c | 24 configs/apple_m1_defconfig | 1 + include/configs/apple.h | 5 - 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a

Re: [PATCH 1/1] arm: apple: Switch to fully dynamic mem layout

On 2022-02-06 18:02:43 -0500, Tom Rini wrote: > On Sun, Feb 06, 2022 at 10:07:04PM +0100, Janne Grunau wrote: > > > Support for Apple M1 Pro and Max will allow using a single binary for > > all M1 SoCs. The M1 Pro/Max have a different memory layout. The RAM > > start ad

[PATCH v2 1/1] arm: apple: Switch to fully dynamic mem layout

(). Tested on Mac Mini (2020) and Macbook Pro 14-inch (2021). Signed-off-by: Janne Grunau Reviewed-by: Mark Kettenis --- Changed in v2: - ensure adresses are aligned - added space between addresses at the top and stack - added loadaddr and set the default to 0 - pick up Mark's Review

[PATCH 1/1] iommu: Add M1 Pro/Max support to Apple DART driver

For the purpose of this driver (activating bypass mode) t6000-dart and t8103-dart are fully compatible. Signed-off-by: Janne Grunau Reviewed-by: Mark Kettenis --- drivers/iommu/apple_dart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/apple_dart.c b/drivers/iommu

[PATCH 1/1] video: bmp: Support x2r10g10b10 pixel format

Fixes the display of the u-boot logo on Apple silicon devices. Signed-off-by: Janne Grunau --- drivers/video/video_bmp.c | 70 +++ 1 file changed, 56 insertions(+), 14 deletions(-) diff --git a/drivers/video/video_bmp.c b/drivers/video/video_bmp.c index

[PATCH v3 1/1] arm: apple: Switch to fully dynamic mem layout

(). Tested on Mac Mini (2020) and Macbook Pro 14-inch (2021). Signed-off-by: Janne Grunau Reviewed-by: Mark Kettenis --- Changes compared to v2: - rebased to master + Mark's "arm: apple: Add M1 Pro/Max support" 20220208210009.46165-1-kette...@openbsd.org Resolves conflic

Re: [RFC PATCH 2/2] apple: dart: use driver specific instance of LMB

Hej, On Tue, Oct 29, 2024 at 12:48:46PM +0530, Sughosh Ganu wrote: > The LMB module is typically used for managing the platform's RAM > memory. RAM memory gets added to the module's memory map, and > subsequently allocated through various LMB API's. > > The IOMMU driver for the apple platforms al

Re: [PATCH 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

On Sun, Nov 03, 2024 at 07:53:36PM +0530, Sughosh Ganu wrote: > On Sat, 2 Nov 2024 at 16:00, Mark Kettenis wrote: > > > > > From: Sughosh Ganu > > > Date: Fri, 1 Nov 2024 17:17:22 +0530 > > > > > > On Fri, 1 Nov 2024 at 15:47, Janne Grunau wrote: &g

Re: [PATCH v4 05/27] lmb: make LMB memory map persistent and global

On Mon, Aug 26, 2024 at 05:29:18PM +0530, Sughosh Ganu wrote: > The current LMB API's for allocating and reserving memory use a > per-caller based memory view. Memory allocated by a caller can then be > overwritten by another caller. Make these allocations and reservations > persistent using the al

Re: [PATCH v2 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

On Sun, Nov 10, 2024 at 08:52:11PM -0600, Tom Rini wrote: > On Wed, Nov 06, 2024 at 10:10:08PM +0100, Janne Grunau via B4 Relay wrote: > > > The changes in "Make LMB memory map global and persistent" [1] break > > mapping DMA memory in the USB xHCI driver when us

Re: [PATCH 0/2] Fix device removal order for Apple dart iommu

On Fri, Nov 01, 2024 at 11:52:26AM +0530, Sughosh Ganu wrote: > On Fri, 1 Nov 2024 at 04:37, Janne Grunau wrote: > > > > Starting with v2024.10 dev_iommu_dma_unmap calls during device removal > > trigger a NULL pointer dereference since the the iommu device is removed >

[PATCH 0/2] Fix device removal order for Apple dart iommu

the two phased device removal to the EFI loader. Signed-off-by: Janne Grunau --- Janne Grunau (2): iommu: apple: Mark device with DM_FLAG_VITAL efi_loader: remove non vital devices first drivers/iommu/apple_dart.c| 2 +- lib/efi_loader/efi_boottime.c | 1 + 2 files changed, 2

[PATCH 1/2] iommu: apple: Mark device with DM_FLAG_VITAL

Avoids NULL pointer dereferences in apple_dart_unmap when the iommu device is removed before its user. U-boot's device model does not track dependencies between devices. Observed on a M1 Ultra Mac Studio with v2024.10. Signed-off-by: Janne Grunau --- drivers/iommu/apple_dart.c | 2 +- 1

[PATCH 3/4] lmb: Add basic io_lmb functionality

free() can trivially reuse exisiting lmb functions. io_lmb_setup() is separate for unique error log messages. io_lmb_alloc() is a simplified copy of _lmb_alloc_base() since the later has unused features and internal use of the global LMB memory map. Signed-off-by: Janne Grunau --- include/

[PATCH 2/4] lmb: cosmetic: reorder functions and global LMB variable

Low lovel LMB functionality will be used to manage IOVA space in the Apple dart iommu driver. This reordering ensures that those function can not access the global LMB memory map variable. Signed-off-by: Janne Grunau --- lib/lmb.c | 496

[PATCH 4/4] iommu: apple: Manage IOVA separately from global LMB mem map

al") Signed-off-by: Janne Grunau --- drivers/iommu/apple_dart.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/apple_dart.c b/drivers/iommu/apple_dart.c index 611ac7cd6deb4fccd45ccfe8cbb9b3e36e2af753..dfcc85c123441d6291d75898675fce7c1a

[PATCH 1/4] lmb: Do not use global LMB variable in _lmb_free()

It will be re-used with a lmb list pointer as argument for IOVA allocations in the apple_dart iommu driver. Signed-off-by: Janne Grunau --- lib/lmb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index 96a055f951e657bf3acc05c9fa804698ce90c312

[PATCH 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

ore.kernel.org/u-boot/20241031-iommu_apple_dart_ordering-v1-0-8a6877946...@jannau.net/ Signed-off-by: Janne Grunau --- Janne Grunau (4): lmb: Do not use global LMB variable in _lmb_free() lmb: cosmetic: reorder functions and global LMB variable lmb: Add basic io_lmb functionality iommu: appl

Re: [RFC PATCH 2/2] apple: dart: use driver specific instance of LMB

On Tue, Oct 29, 2024 at 02:22:53PM +0530, Sughosh Ganu wrote: > On Tue, 29 Oct 2024 at 14:02, Janne Grunau wrote: > > > > On Tue, Oct 29, 2024 at 12:48:46PM +0530, Sughosh Ganu wrote: > > > The LMB module is typically used for managing the platform's RAM > > >

[PATCH 2/2] efi_loader: remove non vital devices first

markes as vital. The arm boot code already handles devioce removal in this way. Signed-off-by: Janne Grunau --- lib/efi_loader/efi_boottime.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index

Re: [PATCH 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

On Wed, Nov 06, 2024 at 12:43:01AM +0530, Sughosh Ganu wrote: > On Sun, 3 Nov 2024 at 23:06, Janne Grunau wrote: > > > > On Sun, Nov 03, 2024 at 07:53:36PM +0530, Sughosh Ganu wrote: > > > On Sat, 2 Nov 2024 at 16:00, Mark Kettenis > > > wrote: >

Re: [PATCH 3/4] lmb: Add basic io_lmb functionality

On Wed, Nov 06, 2024 at 12:48:45AM +0530, Sughosh Ganu wrote: > On Fri, 1 Nov 2024 at 15:47, Janne Grunau wrote: > > > > These functions can be used with struct lmb pointers and will be used to > > manage IOVA space in the apple_dart iommu driver. This restores part of > &

Re: [PATCH 0/2] Fix device removal order for Apple dart iommu

On Thu, Oct 31, 2024 at 11:48:00PM +0100, Janne Grunau wrote: > Starting with v2024.10 dev_iommu_dma_unmap calls during device removal > trigger a NULL pointer dereference since the the iommu device is removed > before its user. The sparsely used DM_FLAG_VITAL flag is intended f

[PATCH RFC 4/6] efi_selftest: Add international characters test

screen for correctness. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest

[PATCH RFC 1/6] lib: charset: Fix utf8_to_utf32_stream() return value doc string

From: Janne Grunau The comment appears to be copied from utf8_to_cp437_stream() but was not updated. Signed-off-by: Janne Grunau --- include/charset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/charset.h b/include/charset.h index 44034c71d3..714382e1c1 100644

[PATCH RFC 5/6] efi_selftest: Add box drawing character selftest

for correctness. To facilitate this, add a three second delay after the output at this point. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 20 1 file changed, 20 insertions

[PATCH RFC 6/6] efi_selftest: Add symbol character selftest

From: Janne Grunau Draw symbols from code page 437 code points 0x01 - 01f used by UEFI applications to draw user interfaces using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Add a simple test to displaying the Konami code using symbols used by grub2. The output has to be checked manually on the screen for

[PATCH RFC 0/6] video: Add UTF-8 support for UEFI applications

quences in tests as proposed by Heinrich Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przyw...@arm.com/ Signed-off-by: Janne Grunau --- Andre Przywara (2): efi_selftest: Add international characters test efi_selftest: Add box drawing character selftest Janne

[PATCH RFC 3/6] lib/charset: Map cp437 low chars (0x01 - 0x1f) from unicode

From: Janne Grunau Add mappings for code points 1 - 31 as those code points in code page 437 are graphics. Thios fixes rendering issues of various EFI boot loaders (grub2, sd-boot, ...) using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Signed-off-by: Janne Grunau --- include/charset.h

[PATCH RFC 2/6] video: console: Parse UTF-8 character sequences

From: Janne Grunau efi_console / UEFI applications (grub2, sd-boot, ...) pass UTF-8 character sequences to vidconsole which results in wrong glyphs for code points outside of ASCII. The truetype console expects Unicode code points and bitmap font based consoles expect code page 437 code points

[PATCH] video: Support VIDEO_X2R10G10B10 in truetype console

From: Janne Grunau Without explicit support for VIDEO_X2R10G10B10 VIDEO_X8R8G8B8 white will be rendered as cyan-ish. The conversion leaves to lowest 2 bits unset for more compact code. Signed-off-by: Janne Grunau --- drivers/video/console_truetype.c | 10 -- 1 file changed, 8

[PATCH] video: console: Fix buffer overflow in cmd 'font list'

From: Janne Grunau vidconsole_ops.get_font is documented to return -ENOENT after the last video_fontdata entry. Signed-off-by: Janne Grunau --- drivers/video/console_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console_core.c b/drivers/video

[PATCH] arm: apple: t602x: Add missing MMIO regions to memmap

From: Janne Grunau The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which was not used by any driver at the time. The display out exposed as simple-framebuffer use a power-domain controlled by a device in an unmapped region. Add a map covering this region as well as another

[PATCH v2] arm: apple: t602x: Add missing MMIO regions to memmap

From: Janne Grunau The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which was not used by any driver at the time. The display out exposed as simple-framebuffer use a power-domain controlled by a device in an unmapped region. Add a map covering this region as well as another

[PATCH v4 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards

From: Janne Grunau Those keyboards do not return the current device state. Polling will timeout unless there are key presses. This is not a problem during operation but the initial device state query during probing will fail. Skip this step in usb_kbd_probe_dev() to make these devices useable

[PATCH v4 3/6] usb: xhci: Abort transfers with unallocated rings

From: Janne Grunau Discovered while trying to use the second interface in the USB keyboard driver necessary on Apple USB keyboards. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci-ring.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v4 5/6] usb: kbd: support Apple Magic Keyboards (2021)

From: Janne Grunau Apple USB keyboards (Magic Keyboard from 2021 (product id 0x029c)) carry the HID keyboard boot protocol on the second interface descriptor. Probe via vendor and product IDs since the class/subclass/protocol match uses the first interface descriptor. Probe the two first

[PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

evices like Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau --- Changes in v4: - collects "Reviewed-by:" tagDITME: describe what is new in this series revision. - adds comment abo

[PATCH v4 4/6] usb: Add environment based device ignorelist

From: Janne Grunau Add the environment variable "usb_ignorelist" to prevent USB devices listed in it from being bound to drivers. This allows to ignore devices which are undesirable or trigger bugs in u-boot's USB stack. Devices emulating keyboards are one example of undesirab

[PATCH v4 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

From: Janne Grunau The xhci driver currently only does the necessary initialization for endpoints found in the first interface descriptor. Apple USB keyboards (released 2021) use the second interface descriptor for the HID keyboard boot protocol. To allow USB drivers to use endpoints from other

[PATCH v4 1/6] usb: xhci: refactor xhci_set_configuration

From: Janne Grunau In the next step endpoints for multiple interfaces are set up. Move most of the per endpoint initialization to separate function to avoid another identation level. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci.c

[PATCH v2 4/5] arm: apple: Switch to standard boot

From: Janne Grunau Use standard boot instead of the distro boot scripts. Use BOOTSTD_FULL instead of BOOTSTD_DEFAULTS for easier interactive use. Signed-off-by: Janne Grunau --- arch/arm/Kconfig| 2 +- include/configs/apple.h | 20 ++-- 2 files changed, 3 insertions

[PATCH v2 2/5] configs: apple: Use "vidconsole,serial" as stdout/stderr

From: Janne Grunau The display size querying in efi_console relies on this order. The display should be the primary output device and should be used to display more than 80x25 chars. Reviewed-by: Mark Kettenis Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- include/configs/apple.h

[PATCH v2 0/5] configs: apple: Switch to standard boot + small adjustments

addressing Signed-off-by: Janne Grunau --- Changes in v2: - added Reviewed-by: tags - switched to BOOTSTD_FULL to enable efi_bootmgr and make interactive use easier - override BOOTCOMMAND to not list the bootflows - rebased onto v2024.04 - Link to v1: https://lore.kernel.org/r/20240317

[PATCH v2 3/5] configs: apple: Enable CMD_SELECT_FONT and FONT_16X32

From: Janne Grunau Apple devices have high DPI displays so the larger fonts are preferable for improved readability. This does not yet change the used font based on the display's pixel density so the standard 8x16 font is still used by default. Reviewed-by: Mark Kettenis Reviewed-by:

[PATCH v2 1/5] apple_m1_defconfig: Turn on CONFIG_SYS_64BIT_LBA

by: Mark Kettenis Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index e00d72e8be..31d966f0ab 100644 --- a/configs/apple_m1_defconfig +++ b

[PATCH v2 5/5] arm: apple: Do not list bootflows on boot

From: Janne Grunau The bootflow list is only seen briefly and is probably more confusing than helpful. Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index c30aec7c55

[PATCH v2 3/6] lib/charset: Map Unicode code points to CP437 code points 0-31

From: Janne Grunau Code page 437 uses code points 1-31 for glyphs instead of control characters. Map the appropriate Unicode code points to this code points. Fixes rendering of grub2's menu as EFI application using the EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL on a console with bitmap fonts. Signe

[PATCH v2 0/6] video: Add UTF-8 support for UEFI applications

n tests as proposed by Heinrich Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przyw...@arm.com/ Signed-off-by: Janne Grunau --- Changes in v2: - use "CONFIG_IS_ENABLED(CHARSET)" instead of EFI_LOADER - rewritten commit message for mapping CP437 cp 1-31 - extended

  1   2   >