Dear Wolfgang,
>> +PLATFORM_CPPFLAGS += -I$(TOPDIR)/board/gec/gec2410
>
> Why is this needed?
in /board/gec/gec2410/lowlevel_init.S, it includes "gec2410_mem.h",
which is at $(TOPDIR)/board/gec/gec2410.
>> diff --git a/nand_spl/board/gec/gec2410/u-boot.lds
>> b/nand_spl/board/gec/gec2410/u-boot
Hi Ben,
> Next time please remember your signed-off-by line.
OK, thanks.
BR.
Hui.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Scott,
> Why do you need to write to the buffer in the NAND SPL? I don't think you
> need read_byte either.
Yes, we don't use nand_read_byte() and nand_write_buf(), it's just
copy from drivers/mtd/nand/s3c64xx.c.
BR.
Hui.
___
U-Boot mailing list
Dear Wolfgang,
2009/11/1 Wolfgang Denk :
> Dear "Hui.Tang",
>
> In message
> <6c7a9a5dcafb1f535ed33cb29d579db993846325.1256898456.git.zetal...@gmail.com>
> you wrote:
>> Add gec2410_config option for GEC2410
>>
>> Signed-off-by: Hui.Tang
>> ---
>> Makefile | 7 +++
>> 1 files changed, 7
Dear Minkyu,
> I think, It is better to put bottom of s3c24x0 board series. (next to VCMA9)
OK, I will fix it and re-send the patch.
Thanks.
BR.
Hui.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Wolfgang,
>> - printf("s3c2410_nand_correct_data: not implemented\n");
>> + debugX(1, "s3c2410_nand_correct_data: not implemented\n");
>
> I think this should remain a printf().
Since when booting from nand flash, the printf() is not available in
the early stage, here I replace print
6 matches
Mail list logo
