[PATCH v2 1/1] sandbox: fix building with CONFIG_SPL_TIMER=y

2023-02-21 Thread Heinrich Schuchardt
Building sandbox_defconfig with CONFIG_SPL_TIMER=y results in an error include/dm/platdata.h:63:33: error: static assertion failed: "Cannot use U_BOOT_DRVINFO with of-platdata. Please use devicetree instead" Add a missing condition in the sandbox driver. Signed-off-by

[PATCH 1/1] test: unit test for crc8

2023-02-21 Thread Heinrich Schuchardt
Add a unit test for the crc8() function. Signed-off-by: Heinrich Schuchardt --- test/lib/Makefile| 1 + test/lib/test_crc8.c | 29 + 2 files changed, 30 insertions(+) create mode 100644 test/lib/test_crc8.c diff --git a/test/lib/Makefile b/test/lib/Makefile

Re: [PATCH] doc: uefi: fix links

2023-02-21 Thread Heinrich Schuchardt
On 2/20/23 15:37, Vincent Stehlé wrote: Fix a couple of links so that they are rendered correctly with sphinx. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- doc/develop/uefi/fwu_updates.rst | 3 ++- doc/develop/uefi

Re: [PATCH v6 6/6] doc: Add measured boot documentation

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 19:02:42 MEZ schrieb Eddie James : >Briefly describe the feature and specify the requirements. > >Signed-off-by: Eddie James >--- > doc/usage/index.rst | 1 + > doc/usage/measured_boot.rst | 23 +++ > 2 files changed, 24 insertions(+) > create mode

Re: [PATCH RFC 0/3] FMP versioning support

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 11:40:33 MEZ schrieb Masahisa Kojima : >This series aims to add the versioning support >in FMP protocol implementation. > >EDK2 reference implementation utilizes the FMP Payload Header >inserted right before the capsule payload. With this series, >U-Boot also follows the EDK

Re: [PATCH v5 30/44] lib: Add an SPL config for LIB_UUID

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 17:34:11 MEZ schrieb Simon Glass : >This is selected by PARTITION_UUIDS which has a separate option for SPL. >Add an SPL option for LIB_UUID also, so that we can keep them consistent. > >Also add one for PARTITION_TYPE_GUID to avoid a build error in part_efi.c >which wants to

[PATCH] lib: bzip2: remove inlining

2023-02-22 Thread Heinrich Schuchardt
;: function not considered for inlining 726 | __inline__ Int32 BZ2_indexIntoF ( Int32 indx, Int32 *cftab ) | ^ Leave it to the compiler if it inlines or not. Signed-off-by: Heinrich Schuchardt --- lib/bzip2/bzlib.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH] efi_loader: efi_allocate_pages: check parameter pages

2023-02-22 Thread Heinrich Schuchardt
On 2/20/23 09:46, Peng Fan wrote: On 2/20/2023 4:08 AM, Heinrich Schuchardt wrote: On 2/16/23 11:53, Peng Fan (OSS) wrote: From: Peng Fan On i.MX8MM-EVK, when doing UEFI Capsule On Disk, we met such issue, It will create Boot option for capsule on disk: Boot: VenHw(E61D73B9-A384-4ACC

Re: [PATCH v2 03/13] efi: Support a 64-bit frame buffer address

2023-02-23 Thread Heinrich Schuchardt
On 2/22/23 20:12, Simon Glass wrote: The current vesa structure only provides a 32-bit value for the frame buffer. Many modern machines use an address outside the range. It is still useful to have this common struct, but add a separate frame-buffer address as well. Add a comment for vesa_setup_

Re: [PATCH v2 04/13] x86: Add a few more items to bdinfo

2023-02-23 Thread Heinrich Schuchardt
On 2/22/23 20:12, Simon Glass wrote: Add the timer and vendor/model information. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/bdinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/lib/bdinfo.c b/arch/x86/lib/bdinfo.c index 0cb79b01bd3..896de37dce4 1

Re: [PATCH v2 05/13] efi: Use a fixed value for the timer clock

2023-02-23 Thread Heinrich Schuchardt
On 2/22/23 20:12, Simon Glass wrote: It is not yet clear how to read the timer via EFI. The current value seems much too high on a Framework laptop I tried. Adjust it to a lower hard-coded value for now. Signed-off-by: Simon Glass --- (no changes since v1) drivers/timer/tsc_timer.c | 4

Re: [PATCH v2 06/13] efi: Support copy framebuffer

2023-02-23 Thread Heinrich Schuchardt
On 2/22/23 20:12, Simon Glass wrote: Add support for this to EFI in case it becomes useful. At present it just slows things down. You can enable CONFIG_VIDEO_COPY to turn it on. Signed-off-by: Simon Glass --- Changes in v2: - Obtain copy framebuffer size from EFI instead of using a fixed value

Re: bootefi issue

2023-02-23 Thread Heinrich Schuchardt
On 2/23/23 14:38, Alexandre Ghiti wrote: Hi Heinrich, I fell into an issue in u-boot, and I struggle to find the correct fix: I'm loading a kernel of 66MB at kernel_addr_r (=0x8400_, this is the default value) and then I'm booting it using bootefi. But the loaded kernel is overwritten by the

Re: bootefi issue

2023-02-23 Thread Heinrich Schuchardt
On 2/23/23 16:57, Heinrich Schuchardt wrote: On 2/23/23 14:38, Alexandre Ghiti wrote: Hi Heinrich, I fell into an issue in u-boot, and I struggle to find the correct fix: I'm loading a kernel of 66MB at kernel_addr_r (=0x8400_, this is the default value) and then I'm bootin

Re: [PATCH] lib: bzip2: remove inlining

2023-02-23 Thread Heinrich Schuchardt
On 2/23/23 17:30, Tom Rini wrote: On Thu, Feb 23, 2023 at 08:15:25AM +0100, Heinrich Schuchardt wrote: Compiling sandbox_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y and gcc 12.2.0-14ubuntu1 leads to a build error: lib/bzip2/bzlib.c: In function 'BZ2_decompress': lib/bzi

Re: bootefi issue

2023-02-23 Thread Heinrich Schuchardt
On 2/23/23 17:24, Alexandre Ghiti wrote: On Thu, Feb 23, 2023 at 4:57 PM Heinrich Schuchardt wrote: On 2/23/23 14:38, Alexandre Ghiti wrote: Hi Heinrich, I fell into an issue in u-boot, and I struggle to find the correct fix: I'm loading a kernel of 66MB at kernel_addr_r (=0x8400_,

[PATCH 1/1] cmd: bootefi: allocate device-tree copy from high memory

2023-02-23 Thread Heinrich Schuchardt
e the device-tree copy to any address. (Restrictions existed for 32bit ARM before Linux commit 7a1be318f579 ("ARM: 9012/1: move device tree mapping out of linear region") for legacy booting. Reported-by: Alexandre Ghiti Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 15 +++-

[PATCH v2 1/1] cmd: bootefi: allocate device-tree copy from high memory

2023-02-23 Thread Heinrich Schuchardt
e the device-tree copy to any address. (Restrictions existed for 32bit ARM before Linux commit 7a1be318f579 ("ARM: 9012/1: move device tree mapping out of linear region") for legacy booting. Reported-by: Alexandre Ghiti Signed-off-by: Heinrich Schuchardt Tested-by: Alexandre Ghiti --- v2:

[PATCH v2 1/1] cmd: bootefi: allocate device-tree copy from high memory

2023-02-23 Thread Heinrich Schuchardt
e the device-tree copy to any address. (Restrictions existed for 32bit ARM before Linux commit 7a1be318f579 ("ARM: 9012/1: move device tree mapping out of linear region") for legacy booting. Reported-by: Alexandre Ghiti Signed-off-by: Heinrich Schuchardt Tested-by: Alexandre Ghiti --- v2:

Re: [PATCH] lib: bzip2: remove inlining

2023-02-23 Thread Heinrich Schuchardt
On 2/23/23 17:40, Tom Rini wrote: On Thu, Feb 23, 2023 at 05:39:08PM +0100, Heinrich Schuchardt wrote: On 2/23/23 17:30, Tom Rini wrote: On Thu, Feb 23, 2023 at 08:15:25AM +0100, Heinrich Schuchardt wrote: Compiling sandbox_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y and gcc 12.2.0

Pull request for efi-2023-04-rc3-2

2023-02-24 Thread Heinrich Schuchardt
load main U-Boot via partition type GUID Test case for crc8 function ---- Heinrich Schuchardt (5): disk: accessors for conditional partition fields kconfig: new macro IF_ENABLED() spl: allow loading via partition

Re: Pull request for efi-2023-04-rc3-2

2023-02-24 Thread Heinrich Schuchardt
On 2/24/23 15:42, Tom Rini wrote: On Fri, Feb 24, 2023 at 11:02:57AM +0100, Heinrich Schuchardt wrote: The following changes since commit 8c3acb726ef083d3d5de12f20318ee0e5070: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-usb (2023-02-22 13:36:29 -

Re: [PATCH v3 1/1] editorconfig: introduce .editorconfig

2023-03-03 Thread Heinrich Schuchardt
On 3/3/23 16:33, Dzmitry Sankouski wrote: Current process of sending patches includes running checkpatch.pl script for each patch, and fixing found style problems. EditorConfig may help to prevent some style related problems (like spaces vs tab indentation) on the fly. Reviewed-by: Simon Glass

Re: [PATCH v8 4/6] bootm: Support boot measurement

2023-03-03 Thread Heinrich Schuchardt
On 3/3/23 20:25, Eddie James wrote: Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v6: - Added comment for bootm_measure - Fixed

Re: [PATCH v8 6/6] doc: Add measured boot documentation

2023-03-03 Thread Heinrich Schuchardt
On 3/3/23 20:25, Eddie James wrote: Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mo

[PATCH 1/1] efi_loader: describe term_get_char()

2023-03-03 Thread Heinrich Schuchardt
Add a function description. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index 4317630907..d970b667a6 100644 --- a/lib/efi_loader/efi_console.c +++ b

[PATCH 1/1] doc: man-page for panic command

2023-03-03 Thread Heinrich Schuchardt
Provide a man-page for the panic command. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/panic.rst | 33 + doc/usage/index.rst | 1 + 2 files changed, 34 insertions(+) create mode 100644 doc/usage/cmd/panic.rst diff --git a/doc/usage/cmd/panic.rst b

[PATCH 1/1] api: move API related config options into submenu

2023-03-03 Thread Heinrich Schuchardt
Kconfig settings that are related to the API for standalone applications should be in the API sub-menu and not on the top level. CONFIG_STANDALONE_LOAD_ADDR is only relevant if standalone example applications are built. Signed-off-by: Heinrich Schuchardt --- Kconfig | 8 api

Re: [PATCH 09/10] efi: Support showing tables

2023-03-06 Thread Heinrich Schuchardt
On 2/26/23 02:33, Simon Glass wrote: Add a command to display the tables provided by EFI. Signed-off-by: Simon Glass --- cmd/efi.c | 40 +++- doc/usage/cmd/efi.rst | 22 ++ 2 files changed, 61 insertions(+), 1 deletion(-)

Re: [PATCH 1/1] api: move API related config options into submenu

2023-03-06 Thread Heinrich Schuchardt
On 3/4/23 16:32, Tom Rini wrote: On Fri, Mar 03, 2023 at 11:31:22PM +0100, Heinrich Schuchardt wrote: Kconfig settings that are related to the API for standalone applications should be in the API sub-menu and not on the top level. CONFIG_STANDALONE_LOAD_ADDR is only relevant if standalone

qemu_arm_defconfig with LTO fails due to unaligned access

2023-03-07 Thread Heinrich Schuchardt
Hello Ilias, hello Tom, Tom tried to run qemu_arm_defconfig with CONFIG_LTO=y in gitlab. This failed as shown in protocol https://source.denx.de/u-boot/u-boot/-/jobs/589913/raw Executing 'HII database protocols' test_hii_database_new_package_list: data abort pc : [<7ff39b98>] lr : [<7ff

Re: qemu_arm_defconfig with LTO fails due to unaligned access

2023-03-08 Thread Heinrich Schuchardt
Am 8. März 2023 17:18:32 MEZ schrieb Tom Rini : >On Wed, Mar 08, 2023 at 05:12:26AM +0100, Heinrich Schuchardt wrote: >> Hello Ilias, hello Tom, >> >> Tom tried to run qemu_arm_defconfig with CONFIG_LTO=y in gitlab. This >> failed as shown in protocol >> htt

Re: [PATCH 2/2] efi: remove error in efi_disk_remove

2023-03-09 Thread Heinrich Schuchardt
On 3/8/23 14:26, Patrick Delaunay wrote: EFI has no reason to block the driver remove when the associated EFI resources failed to be released. This patch avoids DM issue when an EFI resource can't be released, for example if this resource wasn't created, for duplicated device name (error EFI_ALR

Re: [PATCH 1/2] efi: remove error in efi_disk_probe

2023-03-09 Thread Heinrich Schuchardt
On 3/8/23 14:26, Patrick Delaunay wrote: EFI has no reason to block the dm core device_probe() in the callback efi_disk_probe() registered with EVT_DM_POST_PROBE. This patch avoids to have error in DM core on device_probe() ret = device_notify(dev, EVT_DM_POST_PROBE); only because EFI is no

Re: [PATCH 2/2] efi: remove error in efi_disk_remove

2023-03-09 Thread Heinrich Schuchardt
On 3/9/23 11:59, Patrick DELAUNAY wrote: On 3/9/23 09:54, Heinrich Schuchardt wrote: On 3/8/23 14:26, Patrick Delaunay wrote: EFI has no reason to block the driver remove when the associated EFI resources failed to be released. This patch avoids DM issue when an EFI resource can'

Pull request for efi-2023-04-rc4

2023-03-13 Thread Heinrich Schuchardt
ines/15572 Pull request for efi-2023-04-rc4 Documentation: * man-page for panic command UEFI: * Correct parameter check for SetVariable() Other: * Provide unit test for crc8 ---- Heinrich Schuchardt (3):

next: Pull request efi-next-20230313

2023-03-13 Thread Heinrich Schuchardt
The following changes since commit bcf343146ff365a88481b9a80920ed146c6dee5b: Merge tag 'dm-next-9mar23' of https://source.denx.de/u-boot/custodians/u-boot-dm into next (2023-03-09 11:22:50 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git

Re: [PATCH] arm: enable unaligned accesses by default if EFI is configured

2023-03-17 Thread Heinrich Schuchardt
ning with unaligned accesses disabled and eventually crashes. So let's enable unaligned access for those architectures during our start.S routines and avoid the linker issues. Reported-by: Heinrich Schuchardt The problem was originally reported by Tom. My contribution was to track i

[PATCH 1/1] dm: simplify uclass_pre_remove_device

2023-03-18 Thread Heinrich Schuchardt
Remove a superfluous logical constraint. Signed-off-by: Heinrich Schuchardt --- drivers/core/uclass.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index 1762a0796d..dce5b46fc7 100644 --- a/drivers/core/uclass.c +++ b

[PATCH 1/1] efi_loader: move struct efi_device_path to efi.h

2023-03-19 Thread Heinrich Schuchardt
Avoid forward declaration of struct efi_device_path. Signed-off-by: Heinrich Schuchardt --- include/efi.h | 13 - include/efi_api.h | 6 -- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/include/efi.h b/include/efi.h index c3087d3da2..2f312da3cb 100644

[PATCH 0/2] efi_loader: efi_alloc()

2023-03-19 Thread Heinrich Schuchardt
The incumbent function efi_alloc() is unused. Replace dp_alloc() by a new function efi_alloc() that we can use more widely. Use it to simply efi_str_to_u16(). Heinrich Schuchardt (2): efi_loader: move dp_alloc() to efi_alloc() efi_loader: simplify efi_str_to_u16() include/efi_loader.h

[PATCH 1/2] efi_loader: move dp_alloc() to efi_alloc()

2023-03-19 Thread Heinrich Schuchardt
The incumbent function efi_alloc() is unused. Replace dp_alloc() by a new function efi_alloc() that we can use more widely. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 4 +-- lib/efi_loader/efi_device_path.c | 40 +-- lib/efi_loader

[PATCH 2/2] efi_loader: simplify efi_str_to_u16()

2023-03-19 Thread Heinrich Schuchardt
Use efi_alloc() to allocate memory. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path_to_text.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 9062058ac2

[PATCH 0/2] efi_loader: fix device-path for USB devices

2023-03-19 Thread Heinrich Schuchardt
device path for LUN 0 will be: /VenHw()/USB(0x0,0x0)/USB(0x1,0x0)/USB(0x4,0x0)/Ctrl(0x0) Heinrich Schuchardt (2): efi_loader: support for Ctrl() device path node efi_loader: fix device-path for USB devices include/efi_api.h| 6 lib/efi_loader/efi_device_path.c

[PATCH 1/2] efi_loader: support for Ctrl() device path node

2023-03-19 Thread Heinrich Schuchardt
* Add the definitions for Ctrl() device path nodes. * Implement Ctrl() nodes in the device path to text protocol. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h| 6 ++ lib/efi_loader/efi_device_path_to_text.c | 7 +++ 2 files changed, 13 insertions

[PATCH 2/2] efi_loader: fix device-path for USB devices

2023-03-19 Thread Heinrich Schuchardt
nodes. They include the USB port on the parent hub. Hence they are unique. A USB storage device may contain multiple logical units. These can be modeled as Ctrl() nodes. Reported-by: Patrick Delaunay Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c | 45

Re: [PATCH v2 03/12] x86: Add return-value comment to cpu_jump_to_64bit()

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:48, Simon Glass wrote: This does not mention what it returns. Add the missing documentation. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/c

Re: [PATCH v2 05/12] x86: Exit EFI boot services before starting kernel

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:48, Simon Glass wrote: When running the EFI app, we need to exit boot services before jumping to Linux. At some point it may be possible to jump to Linux and pass on the boot services, so that the Linux efistub can be used. For now, this is not implemented. The EFI entry point ex

Re: [PATCH v2 06/12] x86: Support zboot and bootm in the EFI app

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:48, Simon Glass wrote: These have been disabled due to the rudimentary support available. It is a little better now, so enable these options. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) configs/efi-x86_app32_defconfig | 2

Re: [PATCH v2 07/12] efi: Add another tranch of GUIDs

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:48, Simon Glass wrote: Provide information about the GUIDs supplied by QEMU, so far as it is known. These values are used in the 'efi table' command as well as the printf format string %sU Signed-off-by: Simon Glass --- Changes in v2: - Update commit message to explain why these

Re: [PATCH v2 08/12] efi: Include GUID names with EFI app and payload

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:48, Simon Glass wrote: These are currently only available when running with EFI_LOADER. Expand this to include the app and payload, since it is useful to be able to decode things there. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to enable GUID names with EFI ap

Re: [PATCH v2 09/12] doc: Add help for the efi command

2023-03-19 Thread Heinrich Schuchardt
100644 doc/usage/cmd/efi.rst diff --git a/doc/usage/cmd/efi.rst b/doc/usage/cmd/efi.rst new file mode 100644 index 000..c029c423879 --- /dev/null +++ b/doc/usage/cmd/efi.rst @@ -0,0 +1,197 @@ +.. SPDX-License-Identifier: GPL-2.0+ +.. Copyright 2020, Heinrich Schuchardt + +efi command

Re: [PATCH v2 10/12] efi: Split out table-listing code into a new file

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:49, Simon Glass wrote: This code is used with EFI_LOADER but is also useful (with some modifications) for the EFI app and payload. Move it into a shared file. Show the address of the table so it can be examined if needed. Also show the table name as unknown if necessary. Our list o

Re: [PATCH v2 11/12] efi: Support showing tables

2023-03-19 Thread Heinrich Schuchardt
On 3/10/23 21:49, Simon Glass wrote: Add a command (for the app and payload) to display the tables provided by EFI. Signed-off-by: Simon Glass --- Changes in v2: - Make use of common code cmd/Makefile | 2 +- cmd/efi.c | 33 - doc/usag

Re: [PATCH 2/2] efi_loader: fix device-path for USB devices

2023-03-19 Thread Heinrich Schuchardt
On 3/19/23 20:29, Simon Glass wrote: Hi Heinrich, On Mon, 20 Mar 2023 at 04:25, Heinrich Schuchardt wrote: EFI device paths for block devices must be unique. If a non-unique device path is discovered, probing of the block device fails. Currently we use UsbClass() device path nodes. As

Re: [PATCH 1/2] efi_loader: move dp_alloc() to efi_alloc()

2023-03-20 Thread Heinrich Schuchardt
On 3/20/23 08:38, Ilias Apalodimas wrote: Hi Heinrich, On Sun, Mar 19, 2023 at 09:20:22AM +0100, Heinrich Schuchardt wrote: The incumbent function efi_alloc() is unused. Replace dp_alloc() by a new function efi_alloc() that we can use more widely. [...] #include #include +#include

Re: [PATCH v3 1/4] efi_loader: store firmware version into FmpState variable

2023-03-20 Thread Heinrich Schuchardt
On 3/20/23 06:54, Masahisa Kojima wrote: Firmware version management is not implemented in the current FMP protocol. EDK2 reference implementation capsule generation script inserts the FMP Payload Header right before the payload, it contains the firmware version and lowest supported version. Thi

Re: [PATCH v3 3/4] efi_loader: check lowest supported version in capsule update

2023-03-20 Thread Heinrich Schuchardt
On 3/20/23 06:54, Masahisa Kojima wrote: The FMP Payload Header which EDK2 capsule generation scripts insert contains lowest supported version. This commit reads the lowest supported version stored in the "FmpState" EFI non-volatile variable, then check if the firmware version of ongoing caps

Re: [PATCH 2/2] efi_loader: fix device-path for USB devices

2023-03-21 Thread Heinrich Schuchardt
On 3/20/23 19:39, Simon Glass wrote: Hi Heinrich, On Mon, 20 Mar 2023 at 09:58, Heinrich Schuchardt wrote: On 3/19/23 20:29, Simon Glass wrote: Hi Heinrich, On Mon, 20 Mar 2023 at 04:25, Heinrich Schuchardt wrote: EFI device paths for block devices must be unique. If a non-unique

Re: [PATCH] efi_loader: define allow_unaligned as 'asm volatile'

2023-03-21 Thread Heinrich Schuchardt
file mode 100644 index 74a7fc4a25b6.. --- a/arch/arm/cpu/arm11/sctlr.S +++ /dev/null @@ -1,25 +0,0 @@ -/* SPDX-License-Identifier:GPL-2.0+ */ -/* - * Routines to access the system control register - * - * Copyright (c) 2019 Heinrich Schuchardt - */ - -#include - -/* - * void

Re: [PATCH] efi_driver: fix duplicate efiblk#0 issue

2023-07-02 Thread Heinrich Schuchardt
On 7/3/23 04:47, Masahisa Kojima wrote: The devnum value of the blk_desc structure starts from 0, current efi_bl_create_block_device() function creates two "efiblk#0" devices for the cases that blk_find_max_devnum() returns -ENODEV and blk_find_max_devnum() returns 0(one device found in this case

Re: [PATCH v2] efi_driver: fix duplicate efiblk#0 issue

2023-07-02 Thread Heinrich Schuchardt
f (devnum < 0) return EFI_OUT_OF_RESOURCES; Reviewed-by: Heinrich Schuchardt name = calloc(1, 18); /* strlen("efiblk#2147483648") + 1 */

Re: [PATCH v2] efi_driver: fix duplicate efiblk#0 issue

2023-07-03 Thread Heinrich Schuchardt
On 03.07.23 15:30, Simon Glass wrote: Hi Masahisa, On Mon, 3 Jul 2023 at 07:09, Masahisa Kojima wrote: The devnum value of the blk_desc structure starts from 0, current efi_bl_create_block_device() function creates two "efiblk#0" devices for the cases that blk_find_max_devnum() returns -ENODE

[PATCH 1/1] RISC-V: CONFIG_SPL_OPENSBI_SCRATCH_OPTIONS description

2023-07-03 Thread Heinrich Schuchardt
Describe which numeric values can be used for as scratch options for OpenSBI. Signed-off-by: Heinrich Schuchardt --- common/spl/Kconfig | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 2c042ad306..7f99889ec3 100644 --- a

[PATCH 1/1] tools: spkgimage: correct printf specifier

2023-07-04 Thread Heinrich Schuchardt
line_num); | | | | size_t {aka unsigned int} The correct printf specifier for size_t is '%zu'. Fixes: afdfcb11f97c ("tools: spkgimage: add Renesas SPKG format") Signed-off-by: Heinrich Schuchardt --- tools/renesas_spkgimage.c | 2 +

Re: EFI Secure boot default keys

2023-07-06 Thread Heinrich Schuchardt
2022.04, all other EFI options seem to be in this release and I can boot unsigned EFI images ok. Please turn on CONFIG_CMD_NVEDIT_EFI when building your U-Boot. This option was disabled by the commit:     commit 3b728f8728fa (tag: efi-2020-01-rc1)     Author: Heinrich Schuchardt

Re: EFI Secure boot default keys

2023-07-06 Thread Heinrich Schuchardt
On Wed, Jun 28, 2023 at 04:26:58PM +, Neil Jones wrote: Please can someone describe the format of the file needed for the default / built-in EFI secure boot keys (ubootefi.var) The only docs I have found suggest its best to enroll the keys from within u-boot onto some removable media, then

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-06 Thread Heinrich Schuchardt
On 7/7/23 06:00, Masahisa Kojima wrote: This series introduces the EFI_RAM_DISK_PROTOCOL implementation. The major purpose of this series is a preparation for EFI HTTP(S) boot. Now U-Boot can download the distro installer ISO image via wget or tftpboot commands, but U-Boot can not mount the down

Re: [PATCH] efi_loader: Increase default variable store size to 32K

2023-07-08 Thread Heinrich Schuchardt
On 7/8/23 17:21, Alper Nebi Yasak wrote: Debian's arm64 UEFI Secure Boot shim makes the EFI variable store run out of space while mirroring its MOK database to variables. This can be observed in QEMU like so: $ tools/buildman/buildman -o build/qemu_arm64 --boards=qemu_arm64 -w $ cd build/q

Re: [PATCH] cmd: efidebug: add missing efi_free_pool for dh subcommand

2023-07-08 Thread Heinrich Schuchardt
On 6/29/23 11:08, Ilias Apalodimas wrote: On Thu, 29 Jun 2023 at 05:14, Masahisa Kojima wrote: This adds the missing efi_free_pool call for dh subcommand. Fixes: a80146205d0a ("cmd: efidebug: add dh command") Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt

Re: [PATCH] x86: Update docs link in bootparam header

2023-07-08 Thread Heinrich Schuchardt
On 7/7/23 17:41, Tom Rini wrote: On Fri, Jul 07, 2023 at 07:51:42AM +0100, Paul Barker wrote: After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker --- arch/x86/include/asm/bootparam.h | 2 +- 1 file chan

[PATCH 1/1] doc: harmonize Linux kernel documentation links

2023-07-08 Thread Heinrich Schuchardt
Linux internally uses https://www.kernel.org/doc/html/latest/ for documentation links. When referring to their documentation we should do the same. Signed-off-by: Heinrich Schuchardt --- doc/develop/docstyle.rst | 2 +- doc/usage/blkmap.rst | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type

2023-07-09 Thread Heinrich Schuchardt
two places it bad practice. https://source.denx.de/u-boot/custodians/u-boot-efi/-/issues/11 Reviewed-by: Heinrich Schuchardt } __packed; /* image_capsule_support */

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-09 Thread Heinrich Schuchardt
ion() +* needs to be invoked here to update the boot options and remove the +* unnecessary ones. +*/ As in future we want to integrate more EFI drivers with the driver model such a status should be in a global variable. It will have to be set in ExitBootServices() before i

Re: [PATCH 1/4 v2] efi_loader: reconnect drivers on failure

2023-07-09 Thread Heinrich Schuchardt
On 6/20/23 08:19, Ilias Apalodimas wrote: efi_disconnect_controller() doesn't reconnect drivers in case of failure. Reconnect the disconnected drivers properly Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

Re: [PATCH 2/4 v2] efi_loader: check the status of disconnected drivers

2023-07-09 Thread Heinrich Schuchardt
protocols. While at it fix a memory leak and properly free the opened protocol information when closing a protocol. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

Re: [PATCH] efi_loader: make efi_delete_handle() follow the EFI spec

2023-07-09 Thread Heinrich Schuchardt
On 6/26/23 12:04, Ilias Apalodimas wrote: The EFI doesn't allow removal of handles, unless all hosted protocols are cleanly removed. Our efi_delete_handle() is a bit intrusive. Although it does try to delete protocols before removing a handle, it doesn't care if that fails. Instead it only retu

Re: [PATCH v2] x86: Update docs link in bootparam header

2023-07-09 Thread Heinrich Schuchardt
On 7/9/23 11:44, Paul Barker wrote: After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker Reviewed-by: Heinrich Schuchardt --- arch/x86/include/asm/bootparam.h | 2 +- 1 file changed, 1 insertion

Pull request efi-2023-07-rc7

2023-07-09 Thread Heinrich Schuchardt
efi_firmware_management_capsule_header data type Alper Nebi Yasak (2): efi_loader: Avoid underflow when calculating remaining var store size efi_loader: Increase default variable store size to 64KiB Heinrich Schuchardt (1): doc

Re: [PATCH 1/2] cmd: thordown: Add proper dependency for CMD_THOR_DOWNLOAD

2023-07-09 Thread Heinrich Schuchardt
Am 9. Juli 2023 15:09:57 MESZ schrieb Ashok Reddy Soma : >When CONFIG_CMD_USB and CONFIG_USB are disabled some compilation errors >are seen as below. Thanks for your patch. Currently we have no documentation for the thordown command. We should create a man page in /docs/usage/cmd/. Do you

Re: [PATCH v3 02/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-09 Thread Heinrich Schuchardt
Am 9. Juli 2023 15:33:17 MESZ schrieb Sughosh Ganu : >The EFI capsule authentication logic in u-boot expects the public key >in the form of an EFI Signature List(ESL) to be provided as part of >the platform's dtb. Currently, the embedding of the ESL file into the >dtb needs to be done manually.

Re: [PATCH v1] mkeficapsule: fix efi_firmware_management_capsule_header data type

2023-07-09 Thread Heinrich Schuchardt
Am 10. Juli 2023 08:26:37 MESZ schrieb AKASHI Takahiro : >On Sun, Jul 09, 2023 at 10:31:55AM +0200, Heinrich Schuchardt wrote: >> On 6/16/23 10:28, Stefan Herbrechtsmeier wrote: >> > From: Malte Schmidt >> > >> > The data type of item_offset_list shal

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-11 Thread Heinrich Schuchardt
at 05:19:33PM +0900, Masahisa Kojima wrote: Hi Akashi-san, On Fri, 7 Jul 2023 at 16:16, AKASHI Takahiro wrote: On Fri, Jul 07, 2023 at 08:29:12AM +0200, Heinrich Schuchardt wrote: On 7/7/23 06:00, Masahisa Kojima wrote: This series introduces the EFI_RAM_DISK_PROTOCOL implementation. The

Re: [PATCH v4 0/4] SPL NVMe support

2023-07-12 Thread Heinrich Schuchardt
On 12.07.23 15:06, mchit...@ventanamicro.com wrote: Hi Tom, On Tue, 2023-06-20 at 09:37 -0400, Tom Rini wrote: On Sat, 03 Jun 2023 19:32:52 +0530, Mayuresh Chitale wrote: This patchset adds support to load images of the SPL's next booting stage from a NVMe device. Changes in v4: - Drop patch

[PATCH 1/1] doc: riscv: running SiFive Unleashed image in QEMU

2023-07-13 Thread Heinrich Schuchardt
Describe how to run the SiFive Unleashed image in QEMU. Signed-off-by: Heinrich Schuchardt --- doc/board/sifive/unleashed.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/board/sifive/unleashed.rst b/doc/board/sifive/unleashed.rst index ce38b701d7..3daf7ffde2 100644

Re: [PATCH v2 1/6] efi_loader: add RAM disk device path

2023-07-14 Thread Heinrich Schuchardt
On 14.07.23 07:44, Masahisa Kojima wrote: This is a preparation to add the EFI_RAM_DISK_PROTOCOL. This commit adds the RAM disk device path structure and text conversion to Device Path to Text Protocol. Signed-off-by: Masahisa Kojima --- No update since v1 include/efi_api.h

Re: [PATCH] bootstd: Make efi_mgr bootmeth work for non-sandbox setups

2023-07-14 Thread Heinrich Schuchardt
Am 14. Juli 2023 21:56:02 MESZ schrieb Mark Kettenis : >Enable the bootflow based on this bootmeth if the BootOrder EFI >variable is set. > >Signed-off-by: Mark Kettenis >--- > boot/bootmeth_efi_mgr.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >diff --git a/boot/bootm

Re: [PATCH] bootstd: Make efi_mgr bootmeth work for non-sandbox setups

2023-07-14 Thread Heinrich Schuchardt
On 7/14/23 21:56, Mark Kettenis wrote: Enable the bootflow based on this bootmeth if the BootOrder EFI variable is set. Signed-off-by: Mark Kettenis --- boot/bootmeth_efi_mgr.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/boot/bootmeth_efi_mgr.c b/boot/boo

[PATCH] common: define time_t as 64bit

2023-07-15 Thread Heinrich Schuchardt
To avoid the year 2038 problem time_t must be 64bit on all architectures. Signed-off-by: Heinrich Schuchardt --- include/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/types.h b/include/linux/types.h index baa2c491ea..9df930afd1 100644 --- a

[PATCH 1/1] test: avoid function name 'setup'

2023-07-15 Thread Heinrich Schuchardt
https://docs.pytest.org/en/7.3.x/how-to/nose.html Fixes: 482ef90aeb4c ("test: efi_capsule: refactor efi_capsule test") Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_efi_capsule/capsule_common.py | 2 +- .../test_efi_capsule/test_capsule_firmware_fit.py

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-15 Thread Heinrich Schuchardt
On 7/9/23 10:56, Heinrich Schuchardt wrote: On 6/19/23 23:23, Raymond Mao wrote: Changes for complying to EFI spec §3.5.1.1 'Removable Media Boot Behavior'. Boot variables can be automatically generated during a removable media is probed. At the same time, unused boot variables will b

Pull request efi-2023-10-rc1

2023-07-15 Thread Heinrich Schuchardt
ck devices ---- Heinrich Schuchardt (1): README: remove Minicom comment Ilias Apalodimas (4): efi_loader: reconnect drivers on failure efi_loader: check the status of disconnected drivers efi_loader: fix the return codes of Uninsta

[PATCH 1/1] part: eliminate part_get_info_by_name_type()

2023-07-16 Thread Heinrich Schuchardt
e logic of part_get_info_by_name_type() to part_get_info_by_name() and replace the function in omap_mmc_get_part_size(). Fixes: 56670d6fb83f ("disk: part: use common api to lookup part driver") Signed-off-by: Heinrich Schuchardt --- arch/arm/mach-omap2/utils.c | 3 +-- disk/part.c | 10 ++

Re: [PATCH 1/1] test: avoid function name 'setup'

2023-07-16 Thread Heinrich Schuchardt
On 7/16/23 01:40, Simon Glass wrote: Hi Heinrich, On Sat, 15 Jul 2023 at 03:05, Heinrich Schuchardt wrote: pytest 7.3.2 treats the function name 'setup' as a fixture [1]. This leads to errors like: TypeError: setup() missing 2 required positional arguments: 

Re: [PATCH v2 1/6] efi_loader: add RAM disk device path

2023-07-17 Thread Heinrich Schuchardt
Am 18. Juli 2023 03:31:30 MESZ schrieb Masahisa Kojima : >Hi Heinrich, > >On Fri, 14 Jul 2023 at 22:44, Heinrich Schuchardt wrote: >> >> On 14.07.23 07:44, Masahisa Kojima wrote: >> > This is a preparation to add the EFI_RAM_DISK_PROTOCOL. >> > Th

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-18 Thread Heinrich Schuchardt
ST_ADDOPTS="-ra" https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/16948 shows the errors with the suggested patch. Best regards Heinrich Regards, Raymond On Sat, 15 Jul 2023 at 05:19, Heinrich Schuchardt wrote: On 7/9/23 10:56, Heinrich Schuchardt wrote:

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-18 Thread Heinrich Schuchardt
On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance state from no to yes. Is there any documentation describing the usage of empty capsule to set the image acceptance state? Best regards Heinrich

Re: EFI breaks USB dual port detection - our observations

2023-07-18 Thread Heinrich Schuchardt
Am 18. Juli 2023 20:37:04 MESZ schrieb Suniel Mahesh : >Hi, > >I am testing the USB infrastructure on a Rockchip RK3328 based >roc-rk3328-cc target. > >The USB tree on the device is as follows: > >=> usb tree >USB device tree: > 1 Hub (480 Mb/s, 0mA) > u-boot EHCI Host Controller > > 1

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 03:08, Simon Glass wrote: Hi AKASHI, On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro wrote: An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in EFI world, which in turn generates a corresponding U-Boot block device based on U-Boot's Driver Model. The latter d

Re: [PATCH 1/1] part: eliminate part_get_info_by_name_type()

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 03:08, Simon Glass wrote: Hi Heinrich, On Sun, 16 Jul 2023 at 05:34, Heinrich Schuchardt wrote: Since commit 56670d6fb83f ("disk: part: use common api to lookup part driver") part_get_info_by_name_type() ignores the part_type parameter used to restrict the partition

  1   2   3   4   5   6   7   8   9   10   >