[U-Boot] [PATCH] nand: fix nand read.option parsing

2013-02-07 Thread Harvey Chapman
"nand read.part addr off size" would be treated as "nand read.raw addr off 1" It now fails as intended stating "Unknown nand command suffix '.part'" Signed-off-by: Harvey Chapman --- common/cmd_nand.c |2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-07 Thread Harvey Chapman
[ I started this conversation off-list before I joined the list. ] The idea is to add .part as a valid command suffix to nand read/write so it would match nand erase.part. The code to implement it makes "nand read.part" act identically to "nand read". On Feb 7, 2013, at 4:59 PM, Scott Wood wro

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
On Feb 7, 2013, at 5:22 PM, Scott Wood wrote: > It's fine until you get a bad block in the partition, and you end up > accessing the first block of the next partition (or getting "Attempt to > read/write outside the flash area" if it's the last partition). > > Of course, fixing partition/chip

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
Eh, I shouldn't post code that quickly… Try this: diff --git a/common/cmd_nand.c b/common/cmd_nand.c --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -621,60 +621,80 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, nand = &nand_info[dev]; s = strchr(cmd, '.');

Re: [U-Boot] U-boot nand bug, read.part should fail

2013-02-08 Thread Harvey Chapman
On Feb 8, 2013, at 6:34 PM, Scott Wood wrote: > On 02/08/2013 10:44:30 AM, Harvey Chapman wrote: > This should go inside the "not raw" path of the previous "if" statement. > Please use tabs to indent. > We already have "nand" in this context. > We a

Re: [U-Boot] break command.

2013-02-15 Thread Harvey Chapman
On Feb 15, 2013, at 7:38 AM, Albert ARIBAUD wrote: > On Thu, 14 Feb 2013 12:19:11 -0800 > (PST), Sean Omalley wrote: > >> Is there anyway to break back into u-boot after trying to boot from linux >> (arm)? Similar to Open Firmwares stop-a, ctrl-break? I didn't see anything >> in the documentat

Re: [U-Boot] [RFC PATCH] Provide a mechanism to avoid using #ifdef everywhere

2013-02-19 Thread Harvey Chapman
I'm not sure if this has been discussed, but I've found as a new u-boot user there are often features that require enabling other CONFIG macros that I think should just be auto-enabled as dependencies. Please keep this in mind for any future designs. For example, when enabling CONFIG_CMD_UBI and

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman --- common/cmd_nand.c | 51 +++ 1 file ch

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
as it was created by format-patch? Thanks, Harvey On Feb 25, 2013, at 11:40 PM, Harvey Chapman wrote: > Adjust the sizes calculated for whole partition/chip operations by > removing the size of bad blocks so we don't try to erase/read/write > past a partition/chip boundary. > &

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
On Feb 26, 2013, at 12:22 AM, Harvey Chapman wrote: > [Slightly off-topic, but I can't find the answer with google] > I changed the From: line in this patch e-mail to the address I use for this > list rather than the address I committed with. Will this affect the author > l

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
From: Harvey Chapman Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman --- common/cmd_nand.c |

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman --- common/cmd_nand.c | 51 +++ 1 file ch

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Sorry for all of the e-mails while I fumble with git send-email. On Feb 26, 2013, at 12:43 AM, Harvey Chapman wrote: > Adjust the sizes calculated for whole partition/chip operations by > removing the size of bad blocks so we don't try to erase/read/write > past a partition

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
On Feb 26, 2013, at 8:42 PM, Scott Wood wrote: > On 02/25/2013 11:43:48 PM, Harvey Chapman wrote: > > Looks OK except for style issues: Will do. >> +/* We grab the nand info object here fresh because this is usually >> + * called after arg_off_size() which can ch

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman --- common/cmd_nand.c | 35 +++ 1 file changed, 35 inser

[U-Boot] [PATCH 0/1] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
Accidentally let a test sneak in to the patch. Corrected. Harvey Chapman (1): nand: adjust erase/read/write partition/chip size for bad blocks common/cmd_nand.c | 35 +++ 1 file changed, 35 insertions(+) -- 1.7.10.4

[U-Boot] [PATCH 1/1] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman --- common/cmd_nand.c | 35 +++ 1 file changed, 35 inser

Re: [U-Boot] [PATCH] mkimage: add option for adding dtc binary path via argument

2013-08-14 Thread Harvey Chapman
On May 6, 2013, at 8:59 AM, Luka Perkov wrote: > On Mon, May 06, 2013 at 02:32:51PM +0200, Wolfgang Denk wrote: >> It appears there is no really good reason for this patch, so I think >> we should drop it. > > Ok. Thanks for the review. Would there be any objection to adding an option to pass s

Re: [U-Boot] Failing USB devices

2013-08-23 Thread Harvey Chapman
On Aug 23, 2013, at 6:54 AM, Benoît Thébaudeau wrote: > This is the kind of issue that made me create this (discarded) patch at some > point: > http://patchwork.ozlabs.org/patch/176527/ > > Can you try it? I'm not sure that it will be helpful for your specific case. > > I also have this issue