Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-06 Thread Dragan Simic
wanted to take this via the sunxi tree, as this blocks some board support patches. The patch looks perfectly fine to me. Thus, Reviewed-by: Dragan Simic IIUC Linux gave up on adding rather generic entries up for each and every SPI NOR chip, if there is nothing special about them: https

Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-09 Thread Dragan Simic
On 2023-12-09 21:34, Tom Rini wrote: On Wed, Dec 06, 2023 at 04:24:43PM +, Andre Przywara wrote: On Mon, 4 Dec 2023 00:59:52 + Andre Przywara wrote: Hi, > Add support for the zBIT ZB25VQ128 (128M-bit) SPI NOR flash memory chip, > as used on the Xunlong Orange Pi Zero 3 board. does a

Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-09 Thread Dragan Simic
On 2023-12-09 21:43, Tom Rini wrote: On Sat, Dec 09, 2023 at 09:37:28PM +0100, Dragan Simic wrote: On 2023-12-09 21:34, Tom Rini wrote: > On Wed, Dec 06, 2023 at 04:24:43PM +, Andre Przywara wrote: > > On Mon, 4 Dec 2023 00:59:52 + > > Andre Przywara wrote: > >

Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-09 Thread Dragan Simic
On 2023-12-09 22:21, Tom Rini wrote: On Sat, Dec 09, 2023 at 10:02:09PM +0100, Dragan Simic wrote: On 2023-12-09 21:43, Tom Rini wrote: > On Sat, Dec 09, 2023 at 09:37:28PM +0100, Dragan Simic wrote: > > On 2023-12-09 21:34, Tom Rini wrote: > > > On Wed, Dec 06, 2023 at 04:24

Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

2023-12-09 Thread Dragan Simic
On 2023-12-09 23:13, Tom Rini wrote: On Sat, Dec 09, 2023 at 10:43:35PM +0100, Dragan Simic wrote: On 2023-12-09 22:21, Tom Rini wrote: > On Sat, Dec 09, 2023 at 10:02:09PM +0100, Dragan Simic wrote: > > On 2023-12-09 21:43, Tom Rini wrote: > > > On Sat, Dec 09, 2023 at 09:37:

Re: [PATCH 1/3] iommu: fix compilation when CONFIG_PCI disabled

2023-12-11 Thread Dragan Simic
On 2023-12-11 19:41, Caleb Connolly wrote: The dev_pci_iommu_enable() function is only available when CONFIG_PCI is enabled, replace the runtime check with a preprocessor one to fix compilation with pci disabled. Signed-off-by: Caleb Connolly --- drivers/iommu/iommu-uclass.c | 5 +++-- 1 file

Re: [PATCH] mtd: spi-nor: Add support for Macronix flash part

2023-12-14 Thread Dragan Simic
SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, The patch looks good to me, so: Reviewed-by: Dragan Simic Please see also [1]. I hope you'll be willing to test the patches when they're ready. [1] https://lore.kernel.org/u-boot/0dc545aa9d32038dbe7bc48159519...@manjaro.org/T/#u

Re: [PATCH] rock-pi-4: Enable SPI flash

2023-12-15 Thread Dragan Simic
On 2023-12-15 15:00, Stefan Nagy wrote: The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip (XTX Technology Limited XT25F32). Sync the devicetrees from Linux to enable spi1 and add a device node for the NOR flash chip. In the board's defconfig files enable the Rockchip SPI driver, a

Re: [PATCH] rock-pi-4: Enable SPI flash

2023-12-17 Thread Dragan Simic
On 2023-12-17 12:40, Stefan Nagy wrote: Am Freitag, dem 15.12.2023 um 19:26 +0100 schrieb Dragan Simic: On 2023-12-15 15:00, Stefan Nagy wrote: > The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip > (XTX Technology Limited XT25F32). > > Sync the devicetrees from Lin

Re: Passing boot logs to Linux?

2023-12-19 Thread Dragan Simic
On 2023-12-19 21:33, Daniel Golle wrote: On Tue, Dec 19, 2023 at 08:08:48PM +, Csókás Bence wrote: Is passing the U-Boot boot log to Linux supported yet? We are working with a third-party solution, which works, but is a bit hacky, so I was wondering if an official solution has been merged ye

Re: Passing boot logs to Linux?

2023-12-19 Thread Dragan Simic
On 2023-12-20 05:45, Sean Anderson wrote: On 12/19/23 23:11, Simon Glass wrote: On Tue, 19 Dec 2023 at 13:15, Csókás Bence wrote: Is passing the U-Boot boot log to Linux supported yet? We are working with a third-party solution, which works, but is a bit hacky, so I was wondering if an offic

Re: Passing boot logs to Linux?

2023-12-19 Thread Dragan Simic
nt of nearly useless recorded data. Moreover, if I'm not wrong, viewing or parsing such as-is data would actually require replaying the control sequences, to reproduce the actual console contents as it was recorded, which would be quite cumbersome. On 2023. 12. 20. 6:04, Dragan Simic wr

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-20 08:52, Csókás Bence wrote: On 2023. 12. 20. 8:09, Dragan Simic wrote: On 2023-12-20 07:49, Csókás Bence wrote: On 2023. 12. 19. 21:33, Daniel Golle wrote: What comes to mind is that CONFIG_CONSOLE_RECORD also captures ANSI sequences during menu or count-down before boot, so we&#

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-20 11:31, Mark Kettenis wrote: Date: Tue, 19 Dec 2023 23:45:48 -0500 From: Sean Anderson On 12/19/23 23:11, Simon Glass wrote: > On Tue, 19 Dec 2023 at 13:15, Csókás Bence wrote: >> Is passing the U-Boot boot log to Linux supported yet? We are working >> with a third-party solution,

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-20 20:24, Csókás Bence wrote: On 2023. 12. 20. 9:29, Dragan Simic wrote: On 2023-12-20 08:52, Csókás Bence wrote: On 2023. 12. 20. 8:09, Dragan Simic wrote: On 2023-12-20 07:49, Csókás Bence wrote: I don't think that would be a huge problem, Linux userspace can filter ANSI co

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-20 21:03, Sean Anderson wrote: On 12/20/23 14:24, Csókás Bence wrote: On 2023. 12. 20. 9:29, Dragan Simic wrote: On 2023-12-20 08:52, Csókás Bence wrote: On 2023. 12. 20. 8:09, Dragan Simic wrote: On 2023-12-20 07:49, Csókás Bence wrote: That's what I read as well. Is

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-21 00:27, Csókás Bence wrote: On 2023. 12. 20. 20:58, Dragan Simic wrote: On 2023-12-20 20:24, Csókás Bence wrote: On 2023. 12. 20. 9:29, Dragan Simic wrote: On 2023-12-20 08:52, Csókás Bence wrote: That's what I read as well. Is there support for U-boot to write and Lin

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-21 02:03, Daniel Golle wrote: On Thu, Dec 21, 2023 at 12:55:20AM +0100, Dragan Simic wrote: On 2023-12-21 00:27, Csókás Bence wrote: > Not every system has eMMC/uSD, and as you said, these arguments don't > hold for a 4 MB SPI NAND, for example, one you might find in

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-21 02:37, Dragan Simic wrote: On 2023-12-21 02:03, Daniel Golle wrote: On Thu, Dec 21, 2023 at 12:55:20AM +0100, Dragan Simic wrote: On 2023-12-21 00:27, Csókás Bence wrote: > Not every system has eMMC/uSD, and as you said, these arguments don't > hold for a 4 MB SP

Re: Passing boot logs to Linux?

2023-12-20 Thread Dragan Simic
On 2023-12-21 02:44, Dragan Simic wrote: On 2023-12-21 02:37, Dragan Simic wrote: On 2023-12-21 02:03, Daniel Golle wrote: On Thu, Dec 21, 2023 at 12:55:20AM +0100, Dragan Simic wrote: On 2023-12-21 00:27, Csókás Bence wrote: > Not every system has eMMC/uSD, and as you said, these argume

Re: Passing boot logs to Linux?

2023-12-26 Thread Dragan Simic
Hello, On 2023-12-26 10:46, Simon Glass wrote: On Thu, Dec 21, 2023 at 2:23 AM Dragan Simic wrote: On 2023-12-21 02:44, Dragan Simic wrote: > On 2023-12-21 02:37, Dragan Simic wrote: >> On 2023-12-21 02:03, Daniel Golle wrote: >>> On Thu, Dec 21, 2023 at 12:55:20AM +0100,

Re: Passing boot logs to Linux?

2023-12-26 Thread Dragan Simic
On 2023-12-26 23:38, Csókás Bence wrote: On 2023. 12. 26. 19:09, Dragan Simic wrote: On 2023-12-26 10:46, Simon Glass wrote: On Thu, Dec 21, 2023 at 2:23 AM Dragan Simic wrote: On 2023-12-21 02:44, Dragan Simic wrote: > On 2023-12-21 02:37, Dragan Simic wrote: >> On 2023-12-21 02:0

Re: Passing boot logs to Linux?

2023-12-30 Thread Dragan Simic
On 2023-12-31 00:54, Heinrich Schuchardt wrote: On 12/20/23 05:11, Simon Glass wrote: +Heinrich Schuchardt On Tue, 19 Dec 2023 at 13:33, Daniel Golle wrote: On Tue, Dec 19, 2023 at 08:08:48PM +, Csókás Bence wrote: Is passing the U-Boot boot log to Linux supported yet? We are working wit

Re: [PATCH RFC v2 01/23] rockchip: RK3328: Read the reset cause from clock reset unit for RK3328 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RK3328 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 08/23] rockchip: RK3588: Read the reset cause from clock reset unit for RK3588 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RK3588 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 10/23] rockchip: PX30: Read the reset cause from clock reset unit for PX30 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for PX30 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c|

Re: [PATCH RFC v2 14/23] rockchip: RK3308: Read the reset cause from clock reset unit for RK3308 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RK3308 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 16/23] rockchip: RK3368: Read the reset cause from clock reset unit for RK3368 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RK3368 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 18/23] rockchip: RV1108: Read the reset cause from clock reset unit for RV1108 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RV1108 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 20/23] rockchip: RV1126: Read the reset cause from clock reset unit for RV1126 SoC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Anand Moon Read the reset cause from clock reset unit for RV1126 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon Signed-off-by: Anand Moon --- arch/arm/include/asm/arch-rockchip/cru.h | 2 ++ arch/arm/mach-rockchip/cpu-info.c

Re: [PATCH RFC v2 22/23] sysreset: rockchip: use fst reset for ARM64 SOC

2024-05-31 Thread Dragan Simic
Hello Anand, On 2024-05-31 16:18, Anand Moon wrote: From: Kever Yang Rockchip ARM64 SOC will change cpu entry, only fst reset can reset it. Cc: Jagan Teki Signed-off-by: Kever Yang --- drivers/sysreset/sysreset_rockchip.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/sys

Re: [PATCH next v2 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-07 Thread Dragan Simic
(RK3399 Puma) and RK809 (PX30 Ringneck). Signed-off-by: Quentin Schulz Looking good to me. Reviewed-by: Dragan Simic --- drivers/power/pmic/rk8xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c index 12ff26a0855

Re: [PATCH next v3 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-08 Thread Dragan Simic
On 2024-06-06 10:45, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part number. Right now, only RK808 was properly displayed, with this all currentl

Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

2024-06-09 Thread Dragan Simic
Hello Tony, Please see a few comments below. On 2024-06-10 02:34, Tony Dinh wrote: - Change the spi-max-frequency to 5000 (50 Mhz). According to the data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in the DTS to ensure u-boot is consistent with what Linux kernel expected.

Re: [PATCH 1/1] usb: informative message if no controller

2024-06-17 Thread Dragan Simic
Hello Heinrich, On 2024-06-17 10:16, Heinrich Schuchardt wrote: The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Use log_info(). Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/usb-uclass.c | 2 +-

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-17 Thread Dragan Simic
Hello Michal, On 2024-06-17 15:26, Michal Simek wrote: On 6/17/24 08:28, Dhruva Gole wrote: On Jun 17, 2024 at 09:48:42 +0530, Prasad Kummari wrote: Add support for ISSI 128MB flash IS25LP01GG. This part Can we have the datasheet link for this part? I am assuming it's this? https://www.issi.

Re: [PATCH next v3 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-17 Thread Dragan Simic
Hello Quentin, On 2024-06-17 16:10, Quentin Schulz wrote: On 6/6/24 10:45 AM, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part number. Right now

Re: [PATCH next v3 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-17 Thread Dragan Simic
On 2024-06-17 18:54, Quentin Schulz wrote: On 6/17/24 4:58 PM, Dragan Simic wrote: On 2024-06-17 16:10, Quentin Schulz wrote: On 6/6/24 10:45 AM, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3

Re: [PATCH next] power: rk8xx: fix display name for RK808

2024-06-17 Thread Dragan Simic
;d still suggest [1] that reading the MSB/LSB ID registers (i.e. 0x17 and 0x18) is skipped on the RK808 altogether, because the RK808 datasheet lists those two registers as reserved and provides no methods for determining the chip name. Reviewed-by: Dragan Simic [1] https

Re: [PATCH] mtd: spi-nor: ids: Add IS25LP01GG flash support

2024-06-17 Thread Dragan Simic
On 2024-06-17 15:38, Michal Simek wrote: On 6/17/24 15:31, Dragan Simic wrote: On 2024-06-17 15:26, Michal Simek wrote: On 6/17/24 08:28, Dhruva Gole wrote: On Jun 17, 2024 at 09:48:42 +0530, Prasad Kummari wrote: Add support for ISSI 128MB flash IS25LP01GG. This part Can we have the

Re: [PATCH v2 1/1] usb: informative message if no controller

2024-06-18 Thread Dragan Simic
Hello Heinrich, Please see a nitpick below. On 2024-06-18 10:16, Heinrich Schuchardt wrote: The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Signed-off-by: Heinrich Schuchardt --- v2: add 'found' at

Re: [PATCH next] power: rk8xx: fix display name for RK808

2024-06-18 Thread Dragan Simic
Hello Quentin, On 2024-06-18 11:46, Quentin Schulz wrote: On 6/17/24 7:57 PM, Dragan Simic wrote: On 2024-06-17 18:48, Quentin Schulz wrote: From: Quentin Schulz Commit 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs name") fixed all PMICs name that were broken

Re: [PATCH v3 1/1] usb: informative message if no controller

2024-06-18 Thread Dragan Simic
good to me. Reviewed-by: Dragan Simic --- v3: plural controllers v2: add 'found' at end of message keep printf --- drivers/usb/host/usb-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host

Re: [PATCH v3 1/1] usb: informative message if no controller

2024-06-18 Thread Dragan Simic
On 2024-06-18 12:04, Dragan Simic wrote: On 2024-06-18 11:58, Heinrich Schuchardt wrote: The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Use log_info(). Huh, I missed the "use log_info()&qu

Re: [RFC] rockchip: add support for Radxa ROCK Pi E v3.0 which uses DDR4 SDRAM

2024-06-23 Thread Dragan Simic
Hello Fukaumi, On 2024-06-23 06:15, FUKAUMI Naoki wrote: rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in upstream. only difference between v3.0 and prior ver. is, using rk3328-sdram-ddr4-666.dtsi instead of rk3328-sdram-ddr3-666.dtsi. I think you'll need to get the device tree

Re: [RFC] rockchip: add support for Radxa ROCK Pi E v3.0 which uses DDR4 SDRAM

2024-06-23 Thread Dragan Simic
+Cc: he...@sntech.de +Cc: k...@kernel.org Hello Peter and Fukaumi, On 2024-06-23 15:08, Peter Robinson wrote: On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote: On 2024-06-23 06:15, FUKAUMI Naoki wrote: > rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in > upstream

Re: [RFC] rockchip: add support for Radxa ROCK Pi E v3.0 which uses DDR4 SDRAM

2024-06-23 Thread Dragan Simic
+Cc: he...@sntech.de +Cc: k...@kernel.org Hello Peter and Fukaumi, On 2024-06-23 15:08, Peter Robinson wrote: On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote: On 2024-06-23 06:15, FUKAUMI Naoki wrote: > rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in > upstream

Re: [PATCH 05/14] sunxi: Mark scp as optional

2024-06-24 Thread Dragan Simic
Hello Simon, On 2024-06-23 22:30, Simon Glass wrote: This binary does not prevent the system from booting. Mark it optional so that U-Boot can be built without it. It should read "Lack of this binary..." instead, to properly describe the background of this patch. Signed-off-by: Simon Glass

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-25 Thread Dragan Simic
Hello, On 2024-06-25 12:03, Quentin Schulz wrote: On 6/25/24 8:38 AM, Etienne Dublé wrote: Thanks for reviewing my patches. Le 24/06/2024 à 15:08, Quentin Schulz a écrit : [...]   1 file changed, 11 insertions(+) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 93e83661ce..

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-28 Thread Dragan Simic
Hello, On 2024-06-28 08:51, Etienne Dublé wrote: Le 27/06/2024 à 14:27, Quentin Schulz a écrit : On 6/25/24 1:42 PM, Etienne Dublé wrote: Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address

Re: [RESEND PATCH v4 0/3] provide names for emmc hardware partitions

2024-07-02 Thread Dragan Simic
Hello Tim, On 2024-07-02 20:14, Tim Harvey wrote: On Fri, May 31, 2024 at 8:36 AM Tim Harvey wrote: Modern eMMC v4+ devices have multiple hardware partitions per the JEDEC specification described as: Boot Area Partition 1 Boot Area Partition 2 RPMB Partition General Purpose Partition 1

Re: [PATCH] dm: button: support remapping phone keys

2024-07-14 Thread Dragan Simic
eviewed-by: Dragan Simic --- drivers/button/Kconfig | 11 +++ drivers/button/button-uclass.c | 22 +- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/button/Kconfig b/drivers/button/Kconfig index 3918b05ae03e..6cae16fcc8bf 100644 ---

Re: [PATCH] dm: button: support remapping phone keys

2024-07-15 Thread Dragan Simic
Hello Caleb, On 2024-07-15 08:24, Caleb Connolly wrote: On 14/07/2024 22:47, Dragan Simic wrote: On 2024-07-14 21:49, Caleb Connolly wrote: We don't have audio support in U-Boot, but we do have boot menus. Add an option to re-map the volume and power buttons to up/down/enter so tha

Re: [PATCH] dm: button: support remapping phone keys

2024-07-15 Thread Dragan Simic
On 2024-07-15 09:15, Caleb Connolly wrote: On 15/07/2024 09:03, Dragan Simic wrote: On 2024-07-15 08:24, Caleb Connolly wrote: On 14/07/2024 22:47, Dragan Simic wrote: On 2024-07-14 21:49, Caleb Connolly wrote: We don't have audio support in U-Boot, but we do have boot menus. Add an o

Re: [PATCH] dm: button: support remapping phone keys

2024-07-15 Thread Dragan Simic
Hello Shattow, On 2024-07-15 20:02, E Shattow wrote: Adding my casual opinion to this naming decision: On Sun, Jul 14, 2024 at 11:24 PM Caleb Connolly wrote: On 14/07/2024 22:47, Dragan Simic wrote: > On 2024-07-14 21:49, Caleb Connolly wrote: >> We don't have audio support in

Re: [PATCH 01/14] rockchip: Move the default timer init to a common file

2024-07-19 Thread Dragan Simic
Hello Simon, On 2024-07-20 08:16, Simon Glass wrote: Rather than repeating the same code in two files (SPL and TPL), move it to a shared filed. Signed-off-by: Simon Glass Looking good to me. Thanks for the patch. Reviewed-by: Dragan Simic --- arch/arm/include/asm/arch-rockchip

Re: [PATCH 1/1] mmc: Avoid buffer overrun in mmc_startup()

2024-01-04 Thread Dragan Simic
On 2024-01-04 04:49, Heinrich Schuchardt wrote: If the CSD register contains a reserved value (4 - 7) in bits 0:2 of the TRAN_SPEED field, a buffer overrun occurs. Resize the mapping table. According to the original report https://lore.kernel.org/u-boot/20180826231332.2491-11-ero...@de.adit-jv.

Re: [resend PATCH] bootdev: avoid infinite probe loop

2024-01-04 Thread Dragan Simic
, and promote the probe failure message to log_warning(). Signed-off-by: Caleb Connolly Looks good to me. Reviewed-by: Dragan Simic --- Resend, actually change log message to WARN loglevel. --- boot/bootdev-uclass.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff

Re: [PATCH] iommu: dont fail silently

2024-01-04 Thread Dragan Simic
On 2024-01-04 18:12, Caleb Connolly wrote: When attempting to probe a device which has an associated IOMMU, if the IOMMU device can't be found (no driver, disabled driver, driver failed to probe, etc) then we currently fail to probe the device with no discernable error. If we fail to hook the de

Re: [PATCH] iommu: dont fail silently

2024-01-05 Thread Dragan Simic
On 2024-01-05 14:55, Caleb Connolly wrote: On 04/01/2024 17:47, Dragan Simic wrote: On 2024-01-04 18:12, Caleb Connolly wrote: When attempting to probe a device which has an associated IOMMU, if the IOMMU device can't be found (no driver, disabled driver, driver failed to probe, etc) th

Re: [PATCH] iommu: dont fail silently

2024-01-05 Thread Dragan Simic
On 2024-01-05 17:09, Caleb Connolly wrote: On 05/01/2024 14:47, Dragan Simic wrote: On 2024-01-05 14:55, Caleb Connolly wrote: On 04/01/2024 17:47, Dragan Simic wrote: On 2024-01-04 18:12, Caleb Connolly wrote: When attempting to probe a device which has an associated IOMMU, if the IOMMU

Re: [PATCH] iommu: dont fail silently

2024-01-05 Thread Dragan Simic
On 2024-01-05 18:50, Tom Rini wrote: On Fri, Jan 05, 2024 at 05:48:58PM +0100, Dragan Simic wrote: On 2024-01-05 17:09, Caleb Connolly wrote: > On 05/01/2024 14:47, Dragan Simic wrote: > > On 2024-01-05 14:55, Caleb Connolly wrote: > > > On 04/01/2024 17:47, Dragan Simic wrot

Re: [PATCH 2/2] coreboot: Switch to a monospaced font

2024-01-08 Thread Dragan Simic
On 2024-01-08 10:29, Mark Kettenis wrote: From: Simon Glass Date: Sun, 7 Jan 2024 17:14:55 -0700 The default font is proportional, with different character widths. Select a monospace font for coreboot so that the 'dm tree' output lines up correctly. Update the coreboot tests to match. To

Re: [PATCH 0/1] Skip cleanup test if not built out of tree

2024-01-08 Thread Dragan Simic
On 2024-01-08 22:10, Tobias Deiminger wrote: This patch avoids false positives in cases where tests are invoked with test.py --build-dir=./ . See tbot issue 107 [1] for motivation and prior discussion. Previously it resulted in: E AssertionError: leftovers: net/mdio-uclass.c, net/bootp.c, [..

Re: [PATCH v2] boot: add support for button commands

2024-01-10 Thread Dragan Simic
On 2024-01-09 12:51, Caleb Connolly wrote: With the relatively new button API in U-Boot, it's now much easier to model the common usecase of mapping arbitrary actions to different buttons during boot - for example entering fastboot mode, setting some additional kernel cmdline arguments, or bootin

Re: [PATCH v2] boot: add support for button commands

2024-01-17 Thread Dragan Simic
Hello Caleb and Michael, On 2024-01-11 10:38, Michael Walle wrote: This is simply awesome, but I see one possible issue -- the need to have proper environment variables defined for a particular board or device, to make the buttons work as expected.  Obviously, those environment variables can b

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Dragan Simic
On 2024-01-18 08:59, Michael Walle wrote: Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Dragan Simic
On 2024-01-18 16:11, Michael Walle wrote: Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-26 Thread Dragan Simic
Hello Quentin, On 2024-01-26 11:37, Quentin Schulz wrote: On 1/26/24 03:57, Kever Yang wrote: On 2024/1/25 19:02, Quentin Schulz wrote: We don't have a dedicated CD pin for the SD card connector. https://www.digikey.com/en/products/detail/molex/0472192001/3044807 is the SD card connector we u

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-26 Thread Dragan Simic
On 2024-01-26 12:09, Quentin Schulz wrote: On 1/26/24 12:04, Dragan Simic wrote: On 2024-01-26 11:37, Quentin Schulz wrote: On 1/26/24 03:57, Kever Yang wrote: On 2024/1/25 19:02, Quentin Schulz wrote: We don't have a dedicated CD pin for the SD card connector. https://www.digikey.c

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-26 Thread Dragan Simic
On 2024-01-26 12:29, Quentin Schulz wrote: On 1/26/24 12:24, Dragan Simic wrote: On 2024-01-26 12:09, Quentin Schulz wrote: On 1/26/24 12:04, Dragan Simic wrote: On 2024-01-26 11:37, Quentin Schulz wrote: On 1/26/24 03:57, Kever Yang wrote: On 2024/1/25 19:02, Quentin Schulz wrote: We

Re: [PATCH 13/18] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-01-26 Thread Dragan Simic
On 2024-01-26 14:46, Quentin Schulz wrote: On 1/26/24 12:33, Dragan Simic wrote: On 2024-01-26 12:29, Quentin Schulz wrote: On 1/26/24 12:24, Dragan Simic wrote: On 2024-01-26 12:09, Quentin Schulz wrote: On 1/26/24 12:04, Dragan Simic wrote: On 2024-01-26 11:37, Quentin Schulz wrote: On 1

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Dragan Simic
Hello Kever and Quentin, On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_set

Re: [PATCH v3] arm: dts: rockpro64: Add RockPro64 smbios

2023-11-13 Thread Dragan Simic
On 2023-11-13 11:01, Shantur Rathore wrote: Add smbios information for Pine64 RockPro64 board and enable in config Signed-off-by: Shantur Rathore --- Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++ configs/rock

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-28 Thread Dragan Simic
On 2023-11-29 00:35, Szőke Kálmán Benjamin wrote: Sorry i can not fix it, this is an average e-mail service provider that provides the expected tech level in 2023.Please upgrade your u-boot list website engine to able to support e-mail formats/technologies from 2020s ages. I suggest to use simila

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-29 Thread Dragan Simic
On 2023-11-29 22:12, Szőke Kálmán Benjamin wrote: https://lists.yoctoproject.org/g/main Ah, I already used the same mailing list system. I saw no benefits, though. Eredeti levél Feladó: Dragan Simic Dátum: 2023 november 29 05:47:55 Tárgy: Re: [PATCH 1/1] pico-imx7d

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-29 Thread Dragan Simic
help/ [4] https://lore.kernel.org/u-boot/ Eredeti levél ---- Feladó: Dragan Simic Dátum: 2023 november 29 22:34:25 Tárgy: Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect Címzett: Szőke Kálmán Benjamin On 2023-11-29 22:12, Szőke Kálmán Benjamin

Re: [PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-12-03 Thread Dragan Simic
On 2023-12-03 22:49, Shantur Rathore wrote: On Sun, Dec 3, 2023 at 5:44 PM Simon Glass wrote: In fact, I wonder if we should add something like: u-boot-env { offset = ; }; so the environment gets filled into the SPI flash when we write the image? Do we want to reset the environment to d

Re: [PATCH v2 05/18] rockchip: rk3399: Sort imply statements alphabetically

2024-05-01 Thread Dragan Simic
On 2024-04-30 17:30, Jonas Karlman wrote: Sort imply statements under ROCKCHIP_RK3399 alphabetically. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Looking good to me. Reviewed-by: Dragan Simic --- v2: Collet r-b tags --- arch/arm/mach-rockchip/Kconfig | 26

Re: [PATCH v2 07/18] rockchip: rk3399: Enable random generator on all boards

2024-05-01 Thread Dragan Simic
quot; prop. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Peter Robinson Reviewed-by: Kever Yang Looking good to me. Reviewed-by: Dragan Simic --- v2: Move rng node cleanup to this patch v2: Collect r-b tags --- arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 4 ar

Re: [PATCH v2 08/18] rockchip: rk3399: Imply support for GbE PHY

2024-05-01 Thread Dragan Simic
On 2024-04-30 17:30, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang Looking good to me. Reviewed-by: Dragan Simic --- v2

Re: [PATCH v2 09/18] rockchip: rk3399: Enable DT overlay support on all boards

2024-05-01 Thread Dragan Simic
On 2024-04-30 17:30, Jonas Karlman wrote: Imply OF_LIBFDT_OVERLAY Kconfig options to add device tree overlay support on all RK3399 boards. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Kever Yang Looking good to me. Reviewed-by: Dragan Simic --- v2: Collect r-b

Re: [PATCH v2 11/18] rockchip: rk3399: Add a default spl-boot-order prop

2024-05-01 Thread Dragan Simic
t;same-as-spl" also gets resolved to the SPI flash node and loading FIT from SPI flash works without having the node explicitly referenced in spl-boot-order prop. Signed-off-by: Jonas Karlman Looking good to me. Reviewed-by: Dragan Simic --- v2: Update commit message --- arch/arm/dts

Re: [PATCH v2 22/22] rockchip: rk3399: Drop ethernet0 alias from SoC u-boot.dtsi

2024-05-01 Thread Dragan Simic
On 2024-05-01 18:22, Jonas Karlman wrote: Remove the obsolete ethernet0 alias now that all board device tree files have been fully synced with Linux kernel v6.8. Signed-off-by: Jonas Karlman Nice, thanks for handling the move of the ethernetX aliases around. Reviewed-by: Dragan Simic

Re: [PATCH 00/16] rockchip: Migrate RK3308, RK3328, RK356x and RK3588 to OF_UPSTREAM

2024-05-04 Thread Dragan Simic
Hello Jonas, On 2024-05-04 21:42, Jonas Karlman wrote: This series migrate RK3308, RK3328, RK356x and RK3588 boards that exists in Linux kernel v6.8 to use OF_UPSTREAM. I went quickly through all the patches in this series and they in general look good to me. I didn't check all of them in de

Re: [PATCH v3] mmc: allow use of hardware partition names for mmc partconf

2024-05-14 Thread Dragan Simic
Hello all, On 2024-05-14 01:02, Marek Vasut wrote: On 5/13/24 10:52 PM, Tim Harvey wrote: On Mon, Apr 29, 2024 at 1:51 PM Marek Vasut wrote: On 4/29/24 6:48 PM, Tim Harvey wrote: On Sat, Apr 27, 2024 at 4:20 PM Marek Vasut wrote: On 4/27/24 2:11 AM, Tim Harvey wrote: [...] diff --git

Re: [PATCH next 5/5] power: rk8xx: properly print all supported PMICs name

2024-05-25 Thread Dragan Simic
Hello Quentin, Thanks for fixing this issue! Please see my comments below. On 2024-05-24 13:42, Quentin Schulz wrote: From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part

Re: [PATCH 29/31] rockchip: rk3399-rockpro64: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
for all these nice cleanups! Reviewed-by: Dragan Simic --- arch/arm/dts/rk3399-rockpro64.dtsi | 98 -- configs/rockpro64-rk3399_defconfig | 7 ++- 2 files changed, 97 insertions(+), 8 deletions(-) diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399

Re: [PATCH 30/31] rockchip: rk3399-pinebook-pro: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
the board. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Looking good to me. Reviewed-by: Dragan Simic --- arch/arm/dts/rk3399-pinebook-pro.dts | 24 +++- configs/pinebook-pro-rk3399_defconfig | 6 -- 2 files changed, 11 insertions

Re: [PATCH 31/31] rockchip: rk3399-pinephone-pro: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
serial console. Remove SPL_TINY_MEMSET=y to use full memset in SPL. Signed-off-by: Jonas Karlman Looking good to me. Reviewed-by: Dragan Simic --- arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 12 ++ arch/arm/dts/rk3399-pinephone-pro.dts | 147 ++ configs/pinephone

Re: [PATCH 28/31] rockchip: rk3399-rock-pi-4: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
good to me. Reviewed-by: Dragan Simic --- arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi | 12 ++ arch/arm/dts/rk3399-rock-4c-plus.dts | 1 + arch/arm/dts/rk3399-rock-4se-u-boot.dtsi | 12 ++ arch/arm/dts/rk3399-rock-pi-4.dtsi | 4 +++- arch/arm/dts/rk3399-ro

Re: [PATCH 28/31] rockchip: rk3399-rock-pi-4: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
On 2024-04-01 01:14, Jonas Karlman wrote: On 2024-04-01 00:53, Dragan Simic wrote: Please see my comments below. On 2024-03-31 22:28, Jonas Karlman wrote: Sync rk3399-rock-pi-4 related device tree from linux v6.8. Add SPI flash related options to support booting from SPI flash. Add AHCI=y

Re: [PATCH 28/31] rockchip: rk3399-rock-pi-4: Sync device tree from linux v6.8

2024-03-31 Thread Dragan Simic
On 2024-04-01 01:41, Jonas Karlman wrote: On 2024-04-01 01:30, Dragan Simic wrote: On 2024-04-01 01:14, Jonas Karlman wrote: On 2024-04-01 00:53, Dragan Simic wrote: Please see my comments below. On 2024-03-31 22:28, Jonas Karlman wrote: Sync rk3399-rock-pi-4 related device tree from linux

Re: [PATCH v3] tools: copyfile: use 64k instead of 512 buffer

2024-04-04 Thread Dragan Simic
Hello Ahelenia, Just checking, have you forgotten about this patch? On 2024-03-21 21:50, Dragan Simic wrote: On 2024-03-21 21:37, Ahelenia Ziemiańska wrote: This is a trivial but significant optimization: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (

Re: [PATCH v2] tools: open FIT image read-only

2024-04-04 Thread Dragan Simic
\ -T kernel -C lz4 -d Image-6.6.15.lz4 \ -b mt8173-elm-hana-6.6.15.dtb outf when the inputs were unwritable. Link: https://bugs.debian.org/1063097 Signed-off-by: Ahelenia Ziemiańska Reviewed-by: Dragan Simic --- tools/fit_image.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 0/5] imx93: Conver to OF_UPSTREAM

2024-04-07 Thread Dragan Simic
Hello Peng, Some minor nitpicks... s/Conver to/Convert to/ in the patch subject, and a couple more below. On 2024-03-28 06:05, Peng Fan (OSS) wrote: A few nodes were added to soc and board u-boot.dtsi(lpi2c, usbotg), those nodes s/soc/SoC/ could be dropped after upstream linux supports th

Re: [PATCH 1/2] mmc: Imply HS200 cap with mmc-hs400 prop to match linux

2024-04-08 Thread Dragan Simic
and imply HS200 cap when HS400 cap is signaled using a mmc-hs400 prop. Signed-off-by: Jonas Karlman The description above should use "Linux" instead od "linux", but that's perhaps not worth sending the v2. Otherwise, looking good to me. Great job catching this!

Re: [PATCH 2/2] mmc: Add support for the no-mmc-hs400 prop

2024-04-08 Thread Dragan Simic
tion above should use "Linux" instead od "linux", but that's perhaps not worth sending the v2. Otherwise, looking good to me. Great job catching this! Reviewed-by: Dragan Simic --- drivers/mmc/mmc-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH v4] tools: copyfile: use 64k instead of 512 buffer

2024-04-09 Thread Dragan Simic
goto out; } #endif Also extract the buffer size to a macro. Signed-off-by: Ahelenia Ziemiańska Looking good to me, thanks for the v4. Reviewed-by: Dragan Simic --- tools/fit_common.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/fit_

Re: [PATCH v2 05/14] rockchip: rk3308: Enable random generator

2024-04-09 Thread Dragan Simic
Hello Quentin, On 2024-04-09 17:45, Quentin Schulz wrote: Hi Jonas, On 4/8/24 20:14, Jonas Karlman wrote: The RK3308 SoC contain a crypto engine block that can generate random numbers. Add rng node to soc u-boot.dtsi and enable Kconfig options to take advantage of the random generator. Signe

  1   2   3   >