Hello Heinrich,

Please see a nitpick below.

On 2024-06-18 10:16, Heinrich Schuchardt wrote:
The message 'No working controllers found' provides no clue that this
refers to USB controllers.

Provide a message that refers to USB.

Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
---
v2:
        add 'found' at end of message
        keep printf
---
 drivers/usb/host/usb-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
index a1cd0ad2d66..bd861270af3 100644
--- a/drivers/usb/host/usb-uclass.c
+++ b/drivers/usb/host/usb-uclass.c
@@ -388,7 +388,7 @@ int usb_init(void)

        /* if we were not able to find at least one working bus, bail out */
        if (controllers_initialized == 0)
-               printf("No working controllers found\n");
+               printf("No USB controller found\n");

The plural form, "controllers", should be used instead, because it sounds
more natural.  I wrote it that way in my earlier response. [1]

[1] https://lore.kernel.org/u-boot/f75f053e1fc43307f239451e85dc1...@manjaro.org/

        return usb_started ? 0 : -ENOENT;
 }

Reply via email to