Re: [U-Boot] [U-Boot,v2,00/14] Add rockchip SARADC support

David, > On 19 Sep 2017, at 12:53, David Wu wrote: > > The SARADC is used for adc keys and charging detect at uboot > loader. Except for the rk3036 and rk3228 Socs, the others > support the SARADC IP. I am hoping to apply this series later this week (and include in a PR for on next Monday), but

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Andy, > On 19 Sep 2017, at 11:10, Dr. Philipp Tomsich > wrote: > > Andy, > >> On 19 Sep 2017, at 09:19, Andy Yan wrote: >> >> Hi Philipp: >> >> >> On 2017年09月19日 10:06, Andy Yan wrote: >>> Hi Philipp: >>> >>

Re: [U-Boot] [PATCH] rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs

David, > On 20 Sep 2017, at 14:25, David.Wu wrote: > > Hi Philipp, > > 在 2017/9/20 19:54, Philipp Tomsich 写道: >> Enable the Rockchip SARADC driver on all supported SoCs (i.e. all >> except the RK3036 and RK3228, which don't have this peripheral): >> RK3188, RK3288, RK3328, RK3368, RK3399 and RV

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

Masahiro & Simon, > On 20 Sep 2017, at 15:49, Simon Glass wrote: > > Hi Masahiro, > > On 19 September 2017 at 20:51, Masahiro Yamada > wrote: >> Hi Simon, >> >> >> 2017-09-17 6:23 GMT+09:00 Simon Glass : >> >>> >>> +menu "Logging" >>> + >>> +config LOG >>> + bool "Enable logging supp

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

> On 20 Sep 2017, at 16:41, Bin Meng wrote: > > Hi Simon, > > On Wed, Sep 20, 2017 at 9:50 PM, Simon Glass wrote: >> Hi Bin, >> >> On 17 September 2017 at 21:45, Bin Meng wrote: >>> Hi Simon, >>> >>> On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass wrote: Add the logging header file and i

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

Masahiro, > On 20 Sep 2017, at 19:34, Masahiro Yamada > wrote: > > 2017-09-20 23:37 GMT+09:00 Dr. Philipp Tomsich > : >> Masahiro & Simon, >> >>> On 20 Sep 2017, at 15:49, Simon Glass wrote: >>> >>> Hi Masahiro, >>> >

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Heiko, > On 19 Sep 2017, at 12:16, Dr. Philipp Tomsich > wrote: > >> >> On 19 Sep 2017, at 11:12, Heiko Stübner wrote: >> >> Am Dienstag, 19. September 2017, 11:10:29 CEST schrieb Dr. Philipp Tomsich: >>> Andy, >>> >>>> O

[U-Boot] setjmp/longjmp prototype in U-Boot

Simon & Alexander, It appears our setjmp/longjmp prototypes and implementations are in non-compliance with current C-standards (I checked against both C99 and C2011). U-Boot defines setjmp as: int setjmp(struct jmp_buf_data *jmp_buf) The standard however requires int setjmp(jmp_buf env)

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 11:44, Heiko Stuebner wrote: > > Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner: >> Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb Philipp Tomsich: >>> >>> Recent discussions confirmed (what the code always assumed): the >>> Rockchip BROM

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 11:09, Heiko Stuebner wrote: > > Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb Philipp Tomsich: >> >> Recent discussions confirmed (what the code always assumed): the >> Rockchip BROM always enters U-Boot with the stack-pointer valid >> (i.e. the U-Boot startup c

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 12:25, Dr. Philipp Tomsich > wrote: > >> >> On 21 Sep 2017, at 11:44, Heiko Stuebner > <mailto:he...@sntech.de>> wrote: >> >> Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner: >>> Am Donners

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Stübner wrote: >> Am Donnerstag, 21. September 2017, 12:25:17 CEST schrieb Dr. Philipp Tomsich: >>>> On 21 Sep 2017, at 11:44, Heiko Stuebner wrote: >>>> >>>> Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner: >>>>

Re: [U-Boot] [PATCH v4 1/2] rockchip: rk322x: add sdram driver

> On 27 Sep 2017, at 10:38, Kever Yang wrote: > > Add driver for rk322x to support sdram initialize in SPL. > > Signed-off-by: Kever Yang Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich As previously discussed, I'll merge this in its current form (i.e. duplicating code and data str

Re: [U-Boot] [PATCH] rockchip: rk3188: ram: add support for 16bit row address

Kever, > On 25 Sep 2017, at 10:33, Kever Yang wrote: > > RK3188 using the same ddr_conf for both 15 bit and 16 bit row address. > > Signed-off-by: Kever Yang > --- > > drivers/ram/rockchip/sdram_rk3188.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: implicit declaration back_to_bootrom

On 27 Sep 2017, at 21:05, Heinrich Schuchardt wrote: > > Without #include asm/arch-rockchip/bootrom.h we get: > > arch/arm/mach-rockchip/rk3399-board-spl.c:162:2: > warning: implicit declaration of function ‘back_to_bootrom’ > [-Wimplicit-function-declaration] > > for CONFIG_ROCKCHIP_BACK_TO_BR

Re: [U-Boot] [U-Boot, v2, 2/5] power: pmic: rk816: support rk816 pmic

Kever, > On 28 Sep 2017, at 12:12, Kever Yang wrote: > > Hi Philipp, > > On 09/28/2017 04:47 PM, Philipp Tomsich wrote: >> >> >> On Wed, 27 Sep 2017, Kever Yang wrote: >> >>> From: Elaine Zhang >>> >>> >>> Add Rockchip pmic rk816 support. >>> >>> RK81

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

> On 28 Sep 2017, at 14:35, Simon Glass wrote: > > This currently causes a warning in sandbox and will not do the right > thing: > > drivers/core/read.c: In function ‘dev_read_addr_ptr’: > drivers/core/read.c:64:44: warning: cast to pointer from integer of > different size [-Wint-to-point

[U-Boot] [PULL] Please pull u-boot-rockchip/master

The following changes since commit ec4e99a4a24c84069c710df3202ecb1e501ff60f: Merge git://git.denx.de/u-boot-mmc (2017-09-28 23:31:11 -0400) are available in the git repository at: git://git.denx.de/u-boot-rockchip.git master for you to fetch changes up to a7bff40f3c309f3f81791e65aa9997b25d5

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

Simon, > On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich > wrote: > > >> On 28 Sep 2017, at 14:35, Simon Glass wrote: >> >> This currently causes a warning in sandbox and will not do the right >> thing: >> >> drivers/core/read.c: In function ‘

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

> On 30 Sep 2017, at 22:32, Tom Rini wrote: > > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote: >> Simon, >> >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich >>> wrote: >>> >>> >>>> On 28 Sep 2

[U-Boot] [PULL v2] Please pull u-boot-rockchip

Here’s v2 w/ Jagan’s "armv7: Move L2CTLR read/write to common” modified to not cause any breakage for Tegra. Travis result at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/281769812 Thanks, Philipp. The following changes since commit 6ca43a58db61aea8ca2ebec4003bb6cfacf81d46: e

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

Lukasz & Marek, > On 12 Sep 2017, at 10:43, Łukasz Majewski wrote: > > Hi Dr. Philipp, > >> Hi Lukasz, >>> On 12 Sep 2017, at 10:14, Łukasz Majewski wrote: >>> >>> Hi Philipp, >>> >>> This patch series is waiting for opening new merge window. It is already >>> applied to usb-next tree. >> D

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

+Kever, +Eddie Kever & Eddie, > On 2 Oct 2017, at 12:41, Marek Vasut wrote: > > On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote: >> Lukasz & Marek, >> >>> On 12 Sep 2017, at 10:43, Łukasz Majewski wrote: >>> >>> Hi Dr. Philipp, >

Re: [U-Boot] [PATCH] dwc: ep0: Allocate and flush dwc->ep0_trb in a cache aligned manner

Marek, > On 3 Oct 2017, at 14:04, Marek Vasut wrote: > > On 09/19/2017 01:15 PM, Faiz Abbas wrote: >> A flush of the cache is required before any DMA access can take place. > > You mean invalidation for inbound DMA, flush for outbound DMA, right ? > >> The minimum size that can be flushed from

Re: [U-Boot] [PATCH] rockchip: configs: use rockchip-common.h for rk3368

Klaus, > On 6 Oct 2017, at 10:12, Klaus Goger > wrote: > > rockchip-common.h already defines values that are missing from > rk3368_common.h > > For example BOOT_TARGET_DEVICES was defined empty and therefore > distroboot had no boot targets. > > Signed-off-by: Klaus Goger > > --- > > inclu

Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()

> On 6 Oct 2017, at 13:47, Heinrich Schuchardt wrote: > > On 09/11/2017 10:04 PM, Philipp Tomsich wrote: >> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(), >> retrieving the first address of the node's reg-property and returning >> it as a pointer (or NULL on failure).

Re: [U-Boot] [PATCH v2 1/2] rockchip: configs: only add available BOOT_TARGET_DEVICES

> On 6 Oct 2017, at 17:08, Klaus Goger > wrote: > > BOOT_TARGET_DEVICES should only be added if the corresponding u-boot > command is enabled. > > Signed-off-by: Klaus Goger Reviewed-by: Philipp Tomsich Required changes below. > --- > > Changes in v2: > - Add patch to series to prevent b

Re: [U-Boot] [PATCH v4 03/18] rockchip: enable boot0-hook for all Rockchip SoCs

> On 9 Oct 2017, at 11:37, Andy Yan wrote: > > Hi Philipp: > > > On 2017年10月07日 03:28, Philipp Tomsich wrote: >> Rockchip SoCs bootrom design is like this: >> - First 2KB or 4KB internal memory is for bootrom stack and heap; >> - Then the first 4-byte suppose to be a TAG like 'RK33'; >> - The

Re: [U-Boot] [PATCH 1/1] rockchip: provide installation instruction for Firefly-RK3399.

> On 9 Oct 2017, at 10:00, Mark Kettenis wrote: > >> From: Simon Glass >> Date: Sun, 8 Oct 2017 22:41:50 -0600 >> >> On 27 September 2017 at 21:35, Heinrich Schuchardt >> wrote: >>> Unfortunately installing U-Boot on an SD card for the Firefly-RK3399 >>> is not trivial. >>> >>> I could not

Re: [U-Boot] [PATCH 031/080] serial: ns16550: Fix address translation

> On 9 Oct 2017, at 14:45, Mario Six wrote: > > (adding Philipp since he converted lots of drivers to livetree recently) > > On Mon, Oct 9, 2017 at 6:48 AM, Simon Glass wrote: >> Hi Mario, >> >> On 29 September 2017 at 06:51, Mario Six wrote: >>> The dev_read_addr function does not do any bu

Re: [U-Boot] U-Boot sunxi pinctrl

Joonas, > On 9 Oct 2017, at 17:49, Joonas Kylmälä wrote: > > I see you have been working on pinctrl for sunxi in U-Boot: > . > But I have no idea how old the patches you have send are so I

Re: [U-Boot] [PATCH v4 10/18] rockchip: boot0 hook: support early return for RK3188/RK3066-style BROM

Andy, > On 10 Oct 2017, at 11:01, Andy Yan wrote: > > Hi Philipp: > > On 2017年10月07日 03:28, Philipp Tomsich wrote: >> Some Rockchip BROM versions (e.g. the RK3188 and RK3066) first read 1KB data >> from NAND into SRAM and executes it. Then, following a return to bootrom, the >> BROM loads addit

Re: [U-Boot] [PATCH v4 10/18] rockchip: boot0 hook: support early return for RK3188/RK3066-style BROM

> On 10 Oct 2017, at 11:22, Andy Yan wrote: > > Hi: > > > On 2017年10月10日 17:01, Andy Yan wrote: >> Hi Philipp: >> >> On 2017年10月07日 03:28, Philipp Tomsich wrote: >>> Some Rockchip BROM versions (e.g. the RK3188 and RK3066) first read 1KB data >>> from NAND into SRAM and executes it. Then, fol

Re: [U-Boot] [PATCH v1] Document padding between GPT header and partition entries

> On 17 Oct 2017, at 19:55, Stefan Brüns wrote: > > Commit 02e43537b322 ("part_efi: support padding between the GPT > header and partition entries") added support for deviating from > the typical GPT layout. > > Explicitly state deviations are allowed/possible, and mention when > (SoC SPL) and

Re: [U-Boot] Rockchip GRF/PMUGRF/CRU reg access in U-Boot

Kever, > On 20 Oct 2017, at 03:59, Kever Yang wrote: > > Hi Simon and Philipp. > > I would like to include Heiko who is maintainer of upstream kernel > Rockchip SoC for this topic. > > For the driver related to grf, which including pinctrl, usb phy, gmac and > many other modules, we woul

Re: [U-Boot] [PATCH] dm: serial: Add .pre_probe() function to to wait for previous transmission end

> On 27 Oct 2017, at 00:13, Lukasz Majewski wrote: > > It may happen that the serial IP block is performing some ongoing > transmission (started at e.g. board_init()) when the serial "probe" is > called. > > As a result the serial port IP block is reset, so transmitted data is > corrupted: > >

Re: [U-Boot] [PATCH] arm: Make gcc 6.0 or later a hard requirement now.

> On 4 Dec 2017, at 20:02, Stephen Warren wrote: > > On 12/02/2017 06:12 PM, Tom Rini wrote: >> Move the warning to an error as we have been promising would happen in >> this release. > > Oh. This has broken my U-Boot build/test system. I guess it's entirely my > fault for interpreting the "20

Re: [U-Boot] [PATCH] rockchip: rk3399-puma: preserve leading zeros in serial#

> On 7 Dec 2017, at 16:20, Jakob Unterwurzacher > wrote: > > Linux preserves leading zeros in /proc/cpuinfo, so we > should as well. > > Otherwise we have the situation that > /sys/firmware/devicetree/base/serial-number > and /proc/cpuinfo disagree in Linux. > > Signed-off-by: Jakob Unterwurz

Re: [U-Boot] [U-Boot, v2, 1/2] drivers/reset: support rockchip reset drivers

> On 4 Dec 2017, at 02:04, Kever Yang wrote: > > Philipp, > > > On 11/29/2017 03:49 AM, Dr. Philipp Tomsich wrote: >> Kever, >> >> This series causes build-breakage (even outside of the rockchip targets)... >> See https://travis-ci.org/ptomsich/u

Re: [U-Boot] [U-Boot, v2, 1/2] drivers/reset: support rockchip reset drivers

> On 8 Dec 2017, at 14:27, Dr. Philipp Tomsich > wrote: > >> >> On 4 Dec 2017, at 02:04, Kever Yang > <mailto:kever.y...@rock-chips.com>> wrote: >> >> Philipp, >> >> >> On 11/29/2017 03:49 AM, Dr. Philipp Tomsich wrote: >>

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, this week has been quiet in the Rockchip tree: I only have a change to a snprintf format-string for restoring consistency with Linux. Travis-CI results are available at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/313435652 Thanks, Philipp. The following changes since com

Re: [U-Boot] [PATCH 2/2] disk: part: use common api to lookup part driver

Kever, > On 14 Dec 2017, at 07:39, Kever Yang wrote: > > Do not need to scan disk every time when we get part info > by name. How does this interact with USB devices? I.e.: what happens, when you get the partition-info for a usb drive, then change the attached usb drive (with only a single one

Re: [U-Boot] rk3288: broken boot

Jagan, > On 15 Dec 2017, at 08:08, Jagan Teki wrote: > > Hi Philipp/Kever, > > Issue observed on rk3288 TPL supported board (vyasa), worked on > previous release v2017.11. What exactly is the issue (“broken boot” is not very specific)? > Tried to bisect but i couldn't do it because of changes

Re: [U-Boot] [PATCH] spl: atf: fix the plat_params

Kever, If you need/want to disable this, could you make this conditional on a new Kconfig option? That way we can disable it for those boards that still ship with an old ATF (note that passing NULL also broke the upstream ATF for quite a number of versions…). Alternatively, you could add a boar

Re: [U-Boot] [PATCH 2/2] disk: part: use common api to lookup part driver

> On 15 Dec 2017, at 03:34, Kever Yang wrote: > > Hi Philipp, > > > On 12/14/2017 05:53 PM, Dr. Philipp Tomsich wrote: >> Kever, >> >>> On 14 Dec 2017, at 07:39, Kever Yang wrote: >>> >>> Do not need to scan disk every time when we

Re: [U-Boot] [PATCH v3 1/2] drivers/reset: support rockchip reset drivers

Kever, > On 15 Dec 2017, at 10:02, Kever Yang wrote: > > From: Elaine Zhang > > Create driver to support all Rockchip SoCs soft reset. > Example of usage: > i2c driver: > ret = reset_get_by_name(dev, "i2c", &reset_ctl); > if (ret) { > error("reset_get_by_name() failed

Re: [U-Boot] [U-Boot,v2] rockchip: update boot0 hook

Kever, > On 15 Dec 2017, at 16:58, Philipp Tomsich > wrote: > >> Rockchip SoCs only need boot0 hook at SPL, and the U-Boot proper do not >> need it. >> >> The very beginning of U-Boot proper is different between armv7 and armv8: >> armv7 start with ARM_VECTORS while armv8 start with 'b reset'.

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, there’s a few stabilisation fixes and documentation/packaging improvements on u-boot-rockchip/master for you for merge/pull. A matching Travis CI run is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/318163689 Cheers, Philipp. The following changes since commit 15616a0aa

Re: [U-Boot] [PATCH v4 1/2] drivers/reset: support rockchip reset drivers

Kever, while this version has finally fixed the build errors for the rockchip-targets, it still causes major build failures for other target families: see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/318128281 The new driver still appears to be built for the failing boards. Reg

Re: [U-Boot] [PATCH] Convert CONFIG_TWL4030_USB et al to Kconfig

> On 29 Dec 2017, at 16:32, Adam Ford wrote: > > This converts the following to Kconfig: > CONFIG_TWL4030_USB > CONFIG_OMAP_USB_PHY > CONFIG_ROCKCHIP_USB2_PHY Please split this into three distinct commits, converting each of these PHY changes in a separate patch. This will make life much

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, We have two minor config-fixes for the upcoming release on the Rockchip side for you. Travis-CI (prior to the rebase): https://travis-ci.org/ptomsich/u-boot-rockchip/builds/322304850 I expect to send another pull-request later this week with two more stabilisation fixes (RK3368-uQ7 enviro

Re: [U-Boot] [PATCH V2] Convert CONFIG_USB_MUSB_OMAP2PLUS et al to Kconfig

> On 2 Jan 2018, at 15:35, Andreas Färber wrote: > > Am 02.01.2018 um 15:29 schrieb Andrew F. Davis: >> On 12/29/2017 10:10 AM, Adam Ford wrote: >>> On Fri, Dec 29, 2017 at 10:04 AM, Andreas Färber wrote: Hi, Am 29.12.2017 um 16:52 schrieb Paul Kocialkowski: > Le vendredi 29

Re: [U-Boot] [PATCH 2/2] rockchip: firefly-rk3399: enable SPL_ATF_NO_PLATFORM_PARAM

Kever, > On 3 Jan 2018, at 03:34, Kever Yang wrote: > > Hi Philipp, > > On 01/03/2018 04:16 AM, Philipp Tomsich wrote: >> The Rockchip-released ATF for the Firefly apparently (i.e. Kever >> reported this) does not tolerate a FDT being passed as the platform >> parameter and will run into a hard

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, As mentioned earlier, we had another round of last-minute stabilisation fixes in-flight for the Rockchip tree. Here’s the (hopefully final) pull-request with these fixes for inclusion in 2018.1, which includes the following changes: (a) a config adjustment for the RK3368-uQ7 (Lion) boa

Re: [U-Boot] [PULL] Please pull u-boot-rockchip/master

Travis-CI result: https://travis-ci.org/ptomsich/u-boot-rockchip/builds/324578340 > On 3 Jan 2018, at 18:07, Dr. Philipp Tomsich > wrote: > > Tom, > > As mentioned earlier, we had another round of last-minute stabilisation fixes > in-flight > for the Rockch

Re: [U-Boot] [U-Boot, v3, 07/11] spl: add support to booting with OP-TEE

> On 4 Jan 2018, at 04:51, Kever Yang wrote: > > > > On 01/03/2018 01:20 AM, Philipp Tomsich wrote: >> >> >> On Tue, 19 Dec 2017, Kever Yang wrote: >> >>> OP-TEE is an open source trusted OS, in armv7, its loading and >>> running are like this: >>> loading: >>> - SPL load both OP-TEE and U-

Re: [U-Boot] [PATCH 2/2] rockchip: firefly-rk3399: enable SPL_ATF_NO_PLATFORM_PARAM

Michal, > On 4 Jan 2018, at 08:56, Michal Simek wrote: > > Hi Kever, > > On 3.1.2018 03:34, Kever Yang wrote: >> Hi Philipp, >> >> >> On 01/03/2018 04:16 AM, Philipp Tomsich wrote: >>> The Rockchip-released ATF for the Firefly apparently (i.e. Kever >>> reported this) does not tolerate a FDT

[U-Boot] "Reset" values for clksel_con registers in clk_rk3399.c:rkclk_init()

Kever, I came across an odd question in clk_rk3399.c while implementing the reparenting (for assigned-clock-parents) that I today discussed with David Wu… looks like the following code is supposed to restore the reset values to 3 registers, but both the NDA-version of the TRM and the public vers

Re: [U-Boot] [U-Boot, v2, 16/18] clk: rockchip: Add rk322x gamc clock support

David, As discussed last week (off-list), I implemented infrastructure-support for the 'assigned-clocks', 'assigned-clock-parents' and 'assigned-clock-rates’ properties in the DTS … and validated on the RK3399. For my work-in-progress tree, see the ‘assigned-clocks-wip’ branch at: https:

[U-Boot] [PULL] Please pull from u-boot-rockchip/master

Hi Tom, the below request is for some Rockchip-related changes that had missed the previous merge window and had been queued up in my next-branch. Travis-CI report at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/326751040 Regards, Philipp. The following changes since commit f3

Re: [U-Boot] [PATCH 3/5] api: Flush cache when closing api

> On 30 Apr 2018, at 10:34, Emmanuel Vadot wrote: > > Signed-off-by: Emmanuel Vadot > --- > api/api.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/api/api.c b/api/api.c > index 7eee2fc083..7d1608b520 100644 > --- a/api/api.c > +++ b/api/api.c > @@ -290,6 +290,17 @@ stat

Re: [U-Boot] [PATCH v2 1/3] drivers: Add board uclass

Simon, > On 1 May 2018, at 01:12, Simon Glass wrote: > > Hi, > > On 27 April 2018 at 07:02, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> >>> On 27 Apr 2018, at 14:51, Mario Six >> <mailto:mario@gds

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 6 May 2018, at 16:25, Marty E. Plummer wrote: > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > is incorrectly detected as 0 Bytes of ram. Could you elaborate what the change is and what root-cause this

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 7 May 2018, at 04:34, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wrote: >> Hi Marty, >> >> >> On 05/06/2018 10:25 PM, Marty E. Plummer wrote: >>> Taken from coreboot's src/soc/rockchip/rk3288/sdram.c >>> >>> Without this change, my u-boot build for t

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

Kever, Could you analyse and provide (against master) a patch for this? We’ll need to catch any left-overs from your changes at the start of the cycle before we try to merge any of the more invasive changes you have in-flight. Thanks, Philipp. > On 8 May 2018, at 09:30, Jonathan Gray wrote: >

Re: [U-Boot] rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC

Looks like the designware GMAC driver is trying to enable a clock and can’t deal with the -ENOENT. Could you try to see which clock it is requesting and add the necessary entries in the clock-enable function? If you have a patch, I’ll try to prioritise it, so we get these regressions cleaned up q

Re: [U-Boot] [PATCH] rockchip: clk: rk3288: handle clk_enable requests for GMAC

> On 8 May 2018, at 11:49, Jonathan Gray wrote: > > Since b0ba1e7e9d9b9441a18048ec67a3b3100c096975 > (rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC) > Ethernet no longer probes on RK3288. > > Add no-ops for GMAC clocks observed to be requested which match the > clk_e

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 8 May 2018, at 02:52, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: >> >>> On 7 May 2018, at 04:34, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wr

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Simon, Looks like we’d like to have a 64bit type for size in ‘struct ram_info’ (see below). Let us know what you think of the proposed change. Thanks, Philipp. > On 8 May 2018, at 12:21, Dr. Philipp Tomsich > wrote: > > Marty, > >> On 8 May 2018, at 02:52, Ma

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

Good catch. I had a few merge-conflicts when merging that series. That one might have gotten lost. > On 8 May 2018, at 12:31, Jonathan Gray wrote: > > On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote: >> Kever, >> >> Could you analyse and provi

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 8 May 2018, at 21:21, Marty E. Plummer wrote: > > On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 11:16:28AM +0200, Dr.

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 9 May 2018, at 07:29, Marty E. Plummer wrote: > > On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: >> >>> On 8 May 2018, at 21:21, Marty E. Plummer wrote: >>> >>> On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsi

Re: [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs

Kever, There were a number a merge conflicts with this series and it looks like I missed one of them. This is the risk when I try to resolve conflicts instead of asking for a series to be rebased onto master… Regards, Philipp. > On 9 May 2018, at 10:06, Kever Yang wrote: > > Hi Jonathan, >

Re: [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs

Kever, if this affects all SoCs, then apparently nobody tested -rc3 … I had made sure that all these last-minute changes had gone in before rc3. Regards, Philipp. > On 9 May 2018, at 10:12, Dr. Philipp Tomsich > wrote: > > Kever, > > There were a number a merge conflict

[U-Boot] GCC 7.x vs. C++ comments

Tom, I recently ran a local buildman with a came across these: > cc -Wp,-MD,tools/.gen_eth_addr.d -Wall -Wstrict-prototypes -O2 > -fomit-frame-pointer-include ./include/compiler.h -idirafterinclude > -idirafter./arch/arm/include -I./scripts/dtc/libfdt -I./tools -DUSE_HOSTCC > -D__KERNEL_S

Re: [U-Boot] GCC 7.x vs. C++ comments

> On 9 May 2018, at 15:49, Tom Rini wrote: > > On Wed, May 09, 2018 at 02:46:54PM +0200, Wolfgang Denk wrote: >> Dear Tom, >> >> In message <20180509114828.gg12...@bill-the-cat.ec.rr.com> you wrote: >>> >>> We should go and update [1] to note some special exemptions to the rule. >> >> I'm not

Re: [U-Boot] rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC

> On 14 May 2018, at 12:42, Jonathan Gray wrote: > > On Mon, May 14, 2018 at 11:28:38AM +0200, Wadim Egorov wrote: >> Hi, >> >> >> Am 08.05.2018 um 10:05 schrieb Dr. Philipp Tomsich: >>> Looks like the designware GMAC driver is trying to enable a c

Re: [U-Boot] [PATCH] tools: adopt --std=gnu99 where C99 comments are needed

While it’s not directly related to this patch, we should clearly state that the U-Boot code base (with the possible exception of the tools/ directory, which I have started touching here) has _implicitly_ moved to GNU11 (yes, even newer than C99), when be upgraded beyond GCC 5. For reference, see

Re: [U-Boot] [PATCH v2] Makefile: adopt --std=gnu11 for HOSTCFLAGS on Linux

> On 14 May 2018, at 16:53, Mark Kettenis wrote: > >> From: Philipp Tomsich >> Date: Mon, 14 May 2018 15:22:06 +0200 >> >> Following the conversion of the SPDX license tags, a number of files >> compiled with -pedantic now generate warnings similar to the following >> for using C99-style '//'

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, I have two fixes for regressions (that unfortunately ended up in the last release) in my tree, ready for a merge onto master. Thanks, Philipp. The following changes since commit ca70cbabdcd19bf157ae4fa984559b126071ccff: Merge git://git.denx.de/u-boot-marvell (2018-05-14 08:52:48 -0400)

Re: [U-Boot] [PULL] Please pull u-boot-rockchip/master

Travis report (prior to a final rebase onto your latest master) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/378666041 > On 14 May 2018, at 17:32, Dr. Philipp Tomsich > wrote: > > Tom, > > I have two fixes for regressions (that unfortunately en

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

8, at 09:24, Dr. Philipp Tomsich > wrote: > >> >> On 9 May 2018, at 07:29, Marty E. Plummer wrote: >> >> On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: >>> >>>> On 8 May 2018, at 21:21, Marty E. Plummer wrote: >&

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 19 May 2018, at 12:40, Marty E. Plummer wrote: > > On Mon, May 14, 2018 at 05:56:27PM +0200, Dr. Philipp Tomsich wrote: >> I had a bit more time to look into this and it looks as if we have two >> problem-spots... >> >> First, there's a

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 19 May 2018, at 16:58, Vicente Bergas wrote: > > Hello, > I am writing this from a standalone Sapphire board [1], > that is, without the Excavator base board. > The CPU is the Rockchip RK3399, which implements ARMv8.0-A. > > Currently the boot process is: > 1.- Boot ROM > 2.- SPL

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 24 May 2018, at 18:48, Vicente Bergas wrote: > > Hello Philipp, > your answer is much appreciated. > > On Thu, May 24, 2018 at 1:07 PM, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Vincente, >> &g

Re: [U-Boot] [PATCH v1 1/4] spl: record boot_device into spl_image and call spl_perform_fixups

Lukasz, > On 25 May 2018, at 00:11, Lukasz Majewski wrote: > > Hi Philipp, > >> On some boards, we want to give the board/architecture-specific code a >> chance to look at where the next image has been loaded from and >> perform fixups before starting the next image. This is of particular >> i

Re: [U-Boot] [PATCH 1/3] rockchip: add rv1108 sdram driver

Please split this into multiple patches; e.g.: - the CRU changes are not SDRAM related - same goes for the GRF changes for GPIOs The DRAM driver header file is essentially the same that was added in sdram_rk322x.h with the key difference that 'dfitphywrdatalat’ is exposed in the struc

Re: [U-Boot] [PATCH 3/3] rockchip: updata the style of reporting sdram cap

See below for requested changes. > On 12 Jan 2018, at 03:51, zhihuan he wrote: > > updata the style of reporting sdram capacity to uboot > > Signed-off-by: zhihuan he > --- > > arch/arm/mach-rockchip/rv1108/rv1108.c | 30 ++ > board/rockchip/evb_rv1108/evb_rv1108.c | 47 ---

Re: [U-Boot] [PATCH 2/3] rockchip: Add RV1108 SPL support

See below for comments and requested changes. > On 12 Jan 2018, at 03:45, zhihuan he wrote: > > add rv1108 set for supporting spl. > > Signed-off-by: zhihuan he > --- > > arch/arm/mach-rockchip/Kconfig| 2 + > arch/arm/mach-rockchip/Makefile | 1 + > arch/arm/mach-rockch

Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

Tom, > On 15 Jan 2018, at 11:06, Mario Six wrote: > > Fix a mis-indented function call in clk_fixed_rate.c A general question: do we want to have such gardening commits create an additional indirection in our history for people using git-blame frequently (e.g. I usually use git-blame to find th

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

> On 15 Jan 2018, at 11:24, Dr. Philipp Tomsich > wrote: > >> >> On 15 Jan 2018, at 05:39, Kever Yang wrote: >> >> Hi Bryan, >> >> On 01/12/2018 10:52 PM, Bryan O'Donoghue wrote: >>> This series adds a new OPTEE bootable image ty

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

> On 15 Jan 2018, at 05:39, Kever Yang wrote: > > Hi Bryan, > > On 01/12/2018 10:52 PM, Bryan O'Donoghue wrote: >> This series adds a new OPTEE bootable image type to u-boot, which is >> directly bootable with the bootm command. >> >> There is already a TEE image type but, in this case the TEE

Re: [U-Boot] [PATCH 0/9] Add new OPTEE bootm support to u-boot

> On 15 Jan 2018, at 13:03, Peng Fan wrote: > > On Mon, Jan 15, 2018 at 11:29:41AM +0100, Dr. Philipp Tomsich wrote: >> >>> On 15 Jan 2018, at 11:24, Dr. Philipp Tomsich >>> wrote: >>> >>>> >>>> On 15 Jan 2018, at 05:39, K

Re: [U-Boot] [PATCH 06/15] spl: fit: implement recording of loadables into /fit-images

Michal, > On 18 Jan 2018, at 13:56, Michal Simek wrote: > > Hi Philipp, > > > 2017-09-13 21:29 GMT+02:00 Philipp Tomsich > : > If a FDT was loaded (e.g. to append it to U-Boot image), we store it's > address and record information for all loadables into this FDT. This > allows us to easily k

Re: [U-Boot] [PATCH] spl: use different BOARD_INIT MACRO for spl and tpl

> On 20 Jan 2018, at 11:00, Kever Yang wrote: > > SPL and TPL may not always need spl_board_init() at the same time. > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/list

Re: [U-Boot] [PATCH] spl: add option to disable SPL banner output

> On 25 Jan 2018, at 18:37, Lukasz Majewski wrote: > > From: Anatolij Gustschin > > Selecting this option will reduce SPL boot time by approx. 6 ms > (e. g. with 70 bytes long banner string at 115200 baud). > > Signed-off-by: Anatolij Gustschin > Tested-by: Lukasz Majewski Reviewed-by: Phi

Re: [U-Boot] [PATCH 2/4] usb: gadget: dwc2: Fix warning over 32bit vs 64bit targets

> On 27 Jan 2018, at 20:56, Tom Rini wrote: > > On Sat, Jan 27, 2018 at 08:52:43PM +0100, Marek Vasut wrote: >> On 01/27/2018 08:48 PM, Tom Rini wrote: >>> When we have a driver that is used on both 32bit and 64bit targets and >>> we are talking about address space we cannot use u64 nor u32 and

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, Here’s the changes to the rockchip tree for this iteration (and I expect us to generate a few bug-fixes in the stabilisation phase), just in time for rc1. The key change in in this merge window is improved support for the GMAC across the various Rockchip SOCs and moving the clock-selection f

Re: [U-Boot] [U-Boot,v2,4/5] clk: implement clk_set_defaults()

Michael, > On 28 Jan 2018, at 17:54, Michael Nazzareno Trimarchi > wrote: > > Hi > > > > On 28 Jan. 2018 5:50 pm, "Philipp Tomsich" > > wrote: > > Linux uses the properties 'assigned-clocks', 'assigned-clock-parents' > > and 'assigned-clock-rat

Re: [U-Boot] [U-Boot,v2,4/5] clk: implement clk_set_defaults()

> On 28 Jan 2018, at 18:21, Michael Nazzareno Trimarchi > wrote: > > Hi > > > > On 28 Jan. 2018 6:15 pm, "Dr. Philipp Tomsich" > <mailto:philipp.toms...@theobroma-systems.com>> wrote: > Michael, > >> On 28 Jan 2

<    1   2   3   4   5   6   >