Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors

2014-02-21 Thread Bryan Wu
On Thu, Feb 20, 2014 at 8:19 PM, Stephen Warren wrote: > On 02/13/2014 09:15 PM, Stephen Warren wrote: >> Many USB host controller drivers contain almost identical copies of the >> same virtual root hub descriptors. Put these into a common file to avoid >> duplication. >> >> Note that there were s

[U-Boot] [PATCH] pxe: detect image format before calling bootm/bootz

2014-07-30 Thread Bryan Wu
Trying bootm for zImage will print out several error message which is not necessary for this case. So detect image format firstly, only try bootm for legacy and FIT format image then try bootz for others. Signed-off-by: Bryan Wu --- common/cmd_pxe.c | 10 +++--- 1 file changed, 7 insertions

Re: [U-Boot] [PATCH] pxe: detect image format before calling bootm/bootz

2014-07-31 Thread Bryan Wu
On Thu, Jul 31, 2014 at 10:36 AM, Stephen Warren wrote: > On 07/30/2014 04:54 PM, Bryan Wu wrote: >> >> Trying bootm for zImage will print out several error message which >> is not necessary for this case. So detect image format firstly, only >> try bootm for legacy an

[U-Boot] [PATCH 3/3] bootm: use genimg_get_kernel_addr()

2014-07-31 Thread Bryan Wu
Use the new API which is originally taken out from boot_get_kernel of bootm.c Signed-off-by: Bryan Wu --- common/bootm.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/common/bootm.c b/common/bootm.c index 7ec2ed8..aee68cd 100644 --- a/common

[U-Boot] [PATCH 2/3] pxe: detect image format before calling bootm/bootz

2014-07-31 Thread Bryan Wu
Trying bootm for zImage will print out several error message which is not necessary for this case. So detect image format firstly, only try bootm for legacy and FIT format image then try bootz for others. This patch needs new function genimg_get_kernel_addr(). Signed-off-by: Bryan Wu

[U-Boot] [PATCH 1/3] image: introduce genimg_get_kernel_addr()

2014-07-31 Thread Bryan Wu
Kernel address is normally stored as a string argument of bootm or bootz. This function is taken out from boot_get_kernel() of bootm.c, which can be reused by others. Signed-off-by: Bryan Wu --- common/image.c | 43 +++ include/image.h | 1 + 2 files

[U-Boot] [PATCH 0/3] introduce genimg_get_kernel_addr()

2014-07-31 Thread Bryan Wu
se it. Bryan Wu (3): image: introduce genimg_get_kernel_addr() pxe: detect image format before calling bootm/bootz bootm: use genimg_get_kernel_addr() common/bootm.c | 25 + common/cmd_pxe.c | 15 +++ common/image.c

[U-Boot] [PATCH v2 0/3] introduce genimg_get_kernel_addr()

2014-08-04 Thread Bryan Wu
se it. v2: - move function description to header file - fix coding style issue - use argc < 1 check when calling genimg_get_kernel_addr() in bootm.c Bryan Wu (3): image: introduce genimg_get_kernel_addr() pxe: detect image format before calling bootm/bootz bootm: use genimg_get_ker

[U-Boot] [PATCH v2 2/3] pxe: detect image format before calling bootm/bootz

2014-08-04 Thread Bryan Wu
Trying bootm for zImage will print out several error message which is not necessary for this case. So detect image format firstly, only try bootm for legacy and FIT format image then try bootz for others. This patch needs new function genimg_get_kernel_addr(). Signed-off-by: Bryan Wu Tested-by

[U-Boot] [PATCH v2 1/3] image: introduce genimg_get_kernel_addr()

2014-08-04 Thread Bryan Wu
Kernel address is normally stored as a string argument of bootm or bootz. This function is taken out from boot_get_kernel() of bootm.c, which can be reused by others. Signed-off-by: Bryan Wu Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- common/image.c | 32

[U-Boot] [PATCH v2 3/3] bootm: use genimg_get_kernel_addr()

2014-08-04 Thread Bryan Wu
Use the new API which is originally taken out from boot_get_kernel of bootm.c Signed-off-by: Bryan Wu Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- common/bootm.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/common/bootm.c b/common

Re: [U-Boot] [PATCH 3/3] bootm: use genimg_get_kernel_addr()

2014-08-04 Thread Bryan Wu
On Fri, Aug 1, 2014 at 12:18 PM, Stephen Warren wrote: > On 07/31/2014 06:40 PM, Bryan Wu wrote: >> >> Use the new API which is originally taken out from boot_get_kernel >> of bootm.c > > >> diff --git a/common/bootm.c b/common/bootm.c > > >>

Re: [U-Boot] [U-Boot, 1/3] image: introduce genimg_get_kernel_addr()

2014-08-12 Thread Bryan Wu
On Sun, Aug 10, 2014 at 3:21 PM, Tom Rini wrote: > On Thu, Jul 31, 2014 at 05:39:58PM -0700, Bryan Wu wrote: > >> Kernel address is normally stored as a string argument of bootm or bootz. >> This function is taken out from boot_get_kernel() of bootm.c, which can be &

Re: [U-Boot] [PATCH v2 3/3] bootm: use genimg_get_kernel_addr()

2014-08-14 Thread Bryan Wu
On Thu, Aug 14, 2014 at 6:00 PM, York Sun wrote: > On 08/04/2014 05:43 PM, Bryan Wu wrote: >> Use the new API which is originally taken out from boot_get_kernel >> of bootm.c >> >> Signed-off-by: Bryan Wu >> Tested-by: Stephen Warren >> Reviewed-by: St

Re: [U-Boot] [PATCH v2 3/3] bootm: use genimg_get_kernel_addr()

2014-08-14 Thread Bryan Wu
from > genimg_get_kernel_addr() - that function will need two new parameters. > I'm working on a fix to add this 2 new parameters. -Bryan > >> >> York >> >> ____ >> From: Tom Rini >> Sent: Thu, 14/08/2014 18:38 >>

[U-Boot] [PATCH] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
G_FIT. Reported-by: York Sun Signed-off-by: Bryan Wu --- common/bootm.c | 9 + common/cmd_pxe.c | 9 + common/image.c | 19 ++- include/configs/jetson-tk1.h | 2 ++ include/image.h | 6 ++ 5 files change

Re: [U-Boot] [PATCH] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
York, Could you please to try this patch on your platform? I tested on mine but it's not the same as your setup. Thanks, -Bryan On Fri, Aug 15, 2014 at 10:49 AM, Bryan Wu wrote: > Commit b3dd64f5d537b41fc52a03e697271774891f4a70 introduced a bug for > booting FIT image. It's

Re: [U-Boot] [PATCH] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 11:06 AM, York Sun wrote: > On 08/15/2014 10:50 AM, Bryan Wu wrote: >> York, >> >> Could you please to try this patch on your platform? I tested on mine >> but it's not the same as your setup. > > Bryan, > > I did a quick test an

Re: [U-Boot] [PATCH] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 11:04 AM, Stephen Warren wrote: > On 08/15/2014 11:49 AM, Bryan Wu wrote: >> >> Commit b3dd64f5d537b41fc52a03e697271774891f4a70 introduced a bug for > > > Can we spell out the commit description too, so it's easier to know what it > refe

[U-Boot] [PATCH 2/3] image: move all function comments to header file

2014-08-15 Thread Bryan Wu
Several functions comments are C file with function definition, they should be moved to header file with function declaration. Also update genimg_get_kernel_addr() comments for CONFIG_FIT case. Signed-off-by: Bryan Wu --- common/image.c | 186

[U-Boot] [PATCH v2 1/3] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
name_kernel for CONFIG_FIT. Reported-by: York Sun Signed-off-by: Bryan Wu --- common/bootm.c | 9 + common/cmd_pxe.c | 9 + common/image.c | 19 ++- include/image.h | 6 ++ 4 files changed, 30 insertions(+), 13 deletions(-) diff --git a/common/bootm.c b

[U-Boot] [PATCH 3/3] bootm: make sure pass NULL when argc < 1

2014-08-15 Thread Bryan Wu
arg[0] might not be NULL even if argc < 1, so fix this as before. Signed-off-by: Bryan Wu --- common/bootm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/bootm.c b/common/bootm.c index 85b71ba..e75a825 100644 --- a/common/bootm.c +++ b/common/boot

Re: [U-Boot] [PATCH 2/3] image: move all function comments to header file

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 3:01 PM, Jeroen Hofstee wrote: > Hello Bryan, > > > On 15-08-14 22:55, Bryan Wu wrote: >> >> Several functions comments are C file with function definition, they >> should be moved to header file with function declaration. >> &

Re: [U-Boot] [PATCH 2/3] image: move all function comments to header file

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 3:10 PM, York Sun wrote: > On 08/15/2014 03:07 PM, Bryan Wu wrote: >> On Fri, Aug 15, 2014 at 3:01 PM, Jeroen Hofstee >> wrote: >>> Hello Bryan, >>> >>> >>> On 15-08-14 22:55, Bryan Wu wrote: >>>> >>&g

Re: [U-Boot] [PATCH 2/3] image: move all function comments to header file

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 3:25 PM, York Sun wrote: > On 08/15/2014 03:14 PM, Stephen Warren wrote: >> On 08/15/2014 04:11 PM, Bryan Wu wrote: >>> On Fri, Aug 15, 2014 at 3:10 PM, York Sun wrote: >>>> On 08/15/2014 03:07 PM, Bryan Wu wrote: >>>>> On

Re: [U-Boot] [PATCH] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
On Fri, Aug 15, 2014 at 12:33 PM, Simon Glass wrote: > Hi, > > On 15 August 2014 12:25, Bryan Wu wrote: >> On Fri, Aug 15, 2014 at 11:04 AM, Stephen Warren >> wrote: >>> On 08/15/2014 11:49 AM, Bryan Wu wrote: >>>> >>>> Commit b3dd64f

[U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
name_kernel for CONFIG_FIT. genimg_get_kernel_addr() will ignore those to parameters. Reported-by: York Sun Signed-off-by: Bryan Wu --- common/bootm.c | 9 +++-- common/image.c | 39 +++ include/image.h | 3 +++ 3 files changed, 33 insertions(+

[U-Boot] [PATCH 2/2] bootm: make sure pass NULL when argc < 1

2014-08-15 Thread Bryan Wu
arg[0] might not be NULL even if argc < 1, so fix this as before. Signed-off-by: Bryan Wu --- common/bootm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/bootm.c b/common/bootm.c index 245c82a..ff81a27 100644 --- a/common/bootm.c +++ b/common/bootm.c @@ -73

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-20 Thread Bryan Wu
Hi Simon, Tom and Stephen, Could you guys review this patch which solved the issue York reported? Thanks, -Bryan On Fri, Aug 15, 2014 at 4:51 PM, Bryan Wu wrote: > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced > a bug for booting FIT image. It&#

[U-Boot] [PATCH] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-19 Thread Bryan Wu
mmc_init() fails. Signed-off-by: Bryan Wu --- common/cmd_mmc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index c1916c9..56dcf48 100644 --- a/common/cmd_mmc.c +++ b/common/cmd_mmc.c @@ -195,6 +195,7 @@ static int do_mmcops(cmd_tbl_t

Re: [U-Boot] [PATCH] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-20 Thread Bryan Wu
On Tue, May 20, 2014 at 9:55 AM, Stephen Warren wrote: > On 05/19/2014 06:17 PM, Bryan Wu wrote: >> mmc dev ${devnum} will return 0 as success even if there is no card >> inserted. Booting script like tegra-common-post.h will call mmc dev >> ${devnum} to check the mmc dev

Re: [U-Boot] [PATCH v2 2/6] usb : musb : Adding host controller driver for Mentor USB controller

2008-12-23 Thread Bryan Wu
Hi Thomas and Ajay, I just noticed you guys are adding the musb davinci to u-boot, so I guess I don't need to reinvent wheels. As I subscribed to u-boot mail list recently, I missed your original email. I copy & paste your code to this email and add some comments. Thanks a lot -Bryan - +/*

Re: [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive

2008-12-30 Thread Bryan Wu
On Wed, Dec 31, 2008 at 6:52 AM, Wolfgang Denk wrote: > Dear Mike Frysinger, > > In message <1230623951-16497-1-git-send-email-vap...@gentoo.org> you wrote: >> >> --- a/common/usb_storage.c >> +++ b/common/usb_storage.c >> @@ -1166,6 +1166,11 @@ int usb_stor_get_info(struct usb_device *dev,struct

Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

2009-01-15 Thread Bryan Wu
Hi Thomas, I'm still debugging the MUSB driver on my Blackfin board. I got a issue here: https://blackfin.uclinux.org/gf/project/u-boot/tracker/?action=TrackerItemEdit&tracker_id=153&tracker_item_id=4794 1. when the board power on and run 'usb start', the usb function is ok for usb storage usage.

Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

2009-01-18 Thread Bryan Wu
Best Regards, -Bryan > Thanks, > Thomas. > > >> -Original Message- >> From: cooloney.l...@gmail.com >> [mailto:cooloney.l...@gmail.com] On Behalf Of Bryan Wu >> Sent: Thursday, January 15, 2009 2:16 PM >> To: Abraham, Thomas >> Cc: u-boot@li