Re: [PATCH v1] configs: j7200: Merge HS and non-HS defconfigs

2023-02-22 Thread Andrew Davis
the build will emit warnings, for non-HS devices these can be ignored. Signed-off-by: Manorit Chawdhry --- This will help with keeping the HS and non-HS configs in sync :) Acked-by: Andrew Davis configs/j7200_evm_a72_defconfig| 3 +- configs/j7200_evm_r5_defconfig | 1

Re: [RFC PATCH] binman: bintool: etype: Add support for ti-secure entry

2023-03-01 Thread Andrew Davis
On 2/28/23 9:10 AM, Simon Glass wrote: Hi Neha, On Tue, 28 Feb 2023 at 02:50, Neha Malcom Francis wrote: Hi Simon, On 28/02/23 06:05, Simon Glass wrote: Hi Neha, On Fri, 24 Feb 2023 at 05:03, Neha Malcom Francis wrote: core-secdev-k3 is the TI security development package provided for K

Re: [PATCH V7 01/15] board: siemens: iot2050: Split the build for PG1 and PG2

2023-03-01 Thread Andrew Davis
On 2/28/23 12:19 PM, Jan Kiszka wrote: From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single flash.bin for both variants, so we can also split the build. Having two defcon

Re: [PATCH V7 13/15] iot2050: Refresh defconfigs and activate CONFIG_EFI_SCROLL_ON_CLEAR_SCREEN

2023-03-01 Thread Andrew Davis
On 2/28/23 12:19 PM, Jan Kiszka wrote: From: Jan Kiszka This feature is desired on the platform. As you can see here your split defconfigs are already out of sync and need special maintenance :) Andrew Signed-off-by: Jan Kiszka --- configs/iot2050_pg1_defconfig | 1 + configs/iot2050_

Re: [PATCH V7 01/15] board: siemens: iot2050: Split the build for PG1 and PG2

2023-03-01 Thread Andrew Davis
On 3/1/23 12:29 PM, Jan Kiszka wrote: On 01.03.23 18:26, Andrew Davis wrote: On 2/28/23 12:19 PM, Jan Kiszka wrote: From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single

Re: [PATCH V7 01/15] board: siemens: iot2050: Split the build for PG1 and PG2

2023-03-01 Thread Andrew Davis
On 3/1/23 1:21 PM, Jan Kiszka wrote: On 01.03.23 19:34, Andrew Davis wrote: On 3/1/23 12:29 PM, Jan Kiszka wrote: On 01.03.23 18:26, Andrew Davis wrote: On 2/28/23 12:19 PM, Jan Kiszka wrote: From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use

Re: [PATCH v2 03/10] arm: K3: Add basic support for J784S4 SoC definition

2023-03-21 Thread Andrew Davis
On 3/21/23 9:10 AM, Hari Nagalla wrote: Signed-off-by: Apurva Nandan Signed-off-by: Bryan Bratloff Signed-off-by: Nishant Menon Signed-off-by: Hari Nagalla --- arch/arm/mach-k3/Kconfig | 16 +- arch/arm/mach-k3/Makefile | 2 + arch/arm/mach-k3/a

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system reset. Fix by calling fdt_fixup_msmc_ram only on these specific SoC: - J721S2 - AM654 - J721E This change w

Re: [PATCH v1 2/3] arm: mach-k3: am62: Add CTRLMMR_WKUP_JTAG_DEVICE_ID register definition

2023-07-12 Thread Andrew Davis
On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli Add register address and relevant bitmasks and shifts. Allow reading these information: - device identification - number of cores (part of device identification) - features (currently: PRU / no PRU) - security - functional safe

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
On 7/12/23 9:32 AM, Francesco Dolcini wrote: On Wed, Jul 12, 2023 at 09:15:21AM -0500, Andrew Davis wrote: On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system

Re: [PATCH 01/18] arch: mach-k3: security: fix the check for authentication

2023-07-14 Thread Andrew Davis
On 7/14/23 12:52 AM, Manorit Chawdhry wrote: Fix regression occurred during refactoring for the mentioned commit. Fixes: bd6a24759374 ("arm: mach-k3: security: separate out validating binary logic") Signed-off-by: Manorit Chawdhry --- arch/arm/mach-k3/security.c | 5 +++-- 1 file changed,

Re: [PATCH 14/18] board: ti: keys: add .key and .crt for fit signature signing

2023-07-14 Thread Andrew Davis
On 7/14/23 12:52 AM, Manorit Chawdhry wrote: Fit signature mechanism through the standards require the presence of .key and .crt in the folder with the same name, since we are using our custMpk only for the signing, update the format to that of standards to be compatible for packaging easily. Si

[PATCH] configs: k2x_evm: Always include FIT loading support

2023-07-14 Thread Andrew Davis
Non-HS boards can use FIT images so include the env var commands for these unconditionally. Signed-off-by: Andrew Davis --- include/configs/k2e_evm.h | 11 ++- include/configs/k2hk_evm.h | 11 ++- include/configs/k2l_evm.h | 11 ++- 3 files changed, 6 insertions(+), 27

[PATCH] MAINTAINERS: Take maintainership of TI KeyStone2 support

2023-07-25 Thread Andrew Davis
Add arch/arm/mach-keystone/ into K2 board directory MAINTAINERS file. Convert current entries into regex match style. Assign maintainership to myself. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/MAINTAINERS | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff

[PATCH 1/2] ti: keystone2: Imply NFS command support

2023-07-25 Thread Andrew Davis
TI KS2 boards have the nfs command in their common environment boot configuration, enable this command. Signed-off-by: Andrew Davis --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index bdd535fd73f..c019e56d404 100644 --- a/arch/arm

[PATCH 2/2] ti: keystone2: Move common Kconfig selections to under ARCH_KEYSTONE

2023-07-25 Thread Andrew Davis
These select/imply settings are common to the whole architecture not just these boards, move these settings to the architecture config. Signed-off-by: Andrew Davis --- arch/arm/Kconfig | 5 + arch/arm/mach-keystone/Kconfig | 20 2 files changed, 5

[PATCH 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Simplify this environment variable scheme. Signed-off-by: Andrew Davis --- include/configs/k2e_evm.h| 5 + include/configs/k2g_evm.h| 4

[PATCH 2/2] configs: keystone2: Change to using env files

2023-07-25 Thread Andrew Davis
Move to using .env file for setting up environment variables for K2x_evm. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/Kconfig | 12 +++ board/ti/ks2_evm/k2e_evm.env | 13 +++ board/ti/ks2_evm/k2g_evm.env | 46 + board/ti

Re: [PATCH 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
On 7/25/23 12:18 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 11:40:58AM -0500, Andrew Davis wrote: This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Simplify this environment variable scheme. Signed-off-by: Andrew Davis

[PATCH v2 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Remove setting mtdparts as the DTS already contain the partitions. While here also drop the conflicting definitions from the K2 defconfigs. Signed-off-by: Andrew Davis

[PATCH v2 2/2] configs: keystone2: Change to using env files

2023-07-25 Thread Andrew Davis
Move to using .env file for setting up environment variables for K2x_evm. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/Kconfig | 12 +++ board/ti/ks2_evm/k2e_evm.env | 12 +++ board/ti/ks2_evm/k2g_evm.env | 45 + board/ti

[PATCH 0/2] Allow defconfigs defined from fragments

2023-11-01 Thread Andrew Davis
Hello all, For context see thread ending here[0]. Thanks, Andrew Changes from RFC[1]: - Added Reviewed-by [0] https://marc.info/?l=u-boot&m=169333616210919&w=2 [1] https://lists.denx.de/pipermail/u-boot/2023-August/529084.html Andrew Davis (2): Makefile: Run defconfig files throu

[PATCH 1/2] Makefile: Run defconfig files through the C preprocessor

2023-11-01 Thread Andrew Davis
This allows us to use some of the normal preprocessor directives inside defconfig files. Such as #define and #include. Signed-off-by: Andrew Davis Reviewed-by: Simon Glass --- scripts/kconfig/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig

[PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-11-01 Thread Andrew Davis
Add am62x_beagleplay_r5_defconfig for R5 SPL and am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. These defconfigs are composite defconfigs built from the config fragment board/ti/am62x/beagleplay_*.config applied onto the base am62x_evm_*_defconfig. Signed-off-by: Andrew Davis

[PATCH] arm: mach-k3: Move K3 common schema.yaml out of board directory

2023-11-01 Thread Andrew Davis
This file is common for all K3, move it out of board/ directory and into mach-k3. As we need to change the path in k3-binman.dtsi let's take this opportunity to switch to absolute paths which makes adding non-TI boards (like Toradex Verdin) not need to override these paths. Signed-off-by: A

[PATCH 2/7] arm: mach-k3: j721e: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 2 +- arch/arm/mach-k3/j721e/Kconfig | 56 ++ board/ti/j721e

[PATCH 4/7] arm: mach-k3: am64x: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 2 +- {board/ti => arch/arm/mach-k3}/am64x/Kconfig |

[PATCH 6/7] arm: mach-k3: am62ax: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 2 +- {board/ti => arch/arm/mach-k3}/am62ax/Kconfig |

[PATCH 1/7] board: ti: Add dependency from TARGET selection to SOC

2023-11-01 Thread Andrew Davis
Currently the K3 selection for TARGET boards does not depend on the SoC for which it is based. This leds to the odd ability to select for instance both SOC_K3_AM625 and TARGET_J721E_A72_EVM. To fix this the target choice should depend on the matching SOC config. Signed-off-by: Andrew Davis

[PATCH 3/7] arm: mach-k3: am65x: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 3 +- {board/ti => arch/arm/mach-k3}/am65x/Kconfig |

[PATCH 5/7] arm: mach-k3: am62x: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 4 +-- arch/arm/mach-k3/am62x/Kconfig| 49 +++ board/ti

[PATCH 7/7] arm: mach-k3: j721s2: Move board selection to mach-k3

2023-11-01 Thread Andrew Davis
build. To fix this we need to move the target board choice to a common location for each parent SoC selection. Do this in arch/arm/mach-k3. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig| 2 +- arch/arm/mach-k3/j721s2/Kconfig | 36 + board/ti/j721s2

Re: [PATCH 5/7] arm: mach-k3: am62x: Move board selection to mach-k3

2023-11-02 Thread Andrew Davis
On 11/2/23 3:55 AM, Francesco Dolcini wrote: Hello Andrew, On Wed, Nov 01, 2023 at 03:35:28PM -0500, Andrew Davis wrote: Currently each set of board targets from a vendor is selected inside the board directory for that vendor. This has the problem of multiple targets, one from each vendor

Re: [PATCH 14/15] board: ti: Add j721e_beagleboneai64_* config fragments and env file

2023-11-03 Thread Andrew Davis
On 11/2/23 7:38 PM, Nishanth Menon wrote: Add defconfig fragments for J721E based BeagleBone AI-64 and corresponding customized environment. Signed-off-by: Nishanth Menon --- board/ti/j721e/beagleboneai64.env| 19 board/ti/j721e/beagleboneai64_a72.config | 55 +++

Re: [PATCH 14/15] board: ti: Add j721e_beagleboneai64_* config fragments and env file

2023-11-03 Thread Andrew Davis
On 11/3/23 2:06 PM, Nishanth Menon wrote: On 13:51-20231103, Andrew Davis wrote: On 11/2/23 7:38 PM, Nishanth Menon wrote: Add defconfig fragments for J721E based BeagleBone AI-64 and corresponding customized environment. Signed-off-by: Nishanth Menon --- board/ti/j721e/beagleboneai64.env

Re: [PATCH] arm: mach-k3: Move K3 degenerate keys out of board folder

2023-11-03 Thread Andrew Davis
Cc: Vignesh Raghavendra Cc: Francesco Dolcini Cc: Andrew Davis Similar to the patch https://lore.kernel.org/all/20231101183329.65091-1-...@ti.com/ arch/arm/dts/k3-am625-verdin-wifi-dev-binman.dtsi | 2 +- arch/arm/dts/k3-binman.dtsi | 2 +- {board/ti

Re: [PATCH V2 06/12] arm: mach-k3: Kconfig: Introduce a symbol to indicate J7200

2023-11-06 Thread Andrew Davis
On 11/4/23 2:21 AM, Nishanth Menon wrote: J7200 shares quite a few characteristics with J721E. However a few sets are different. Introduce a Kconfig to differentiate the two to allow for new boards to be introduced in a seamless manner. Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/Kconf

[PATCH] arm: mach-k3: Let the compiler size the mem_map lists

2023-11-06 Thread Andrew Davis
NR_MMU_REGIONS is a copy/paste from another platform that extends this list later. We do not do that, so let the list be the size of the initializer list. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/arm64-mmu.c | 34 ++ 1 file changed, 6 insertions(+), 28

Re: [PATCH V2 08/12] arm: mach-k3: arm64-mmu: Refactor to be independent of board

2023-11-06 Thread Andrew Davis
On 11/4/23 2:21 AM, Nishanth Menon wrote: Refactor J721E J7200 definition to make this independent of board macros. Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/arm64-mmu.c | 50 ++-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/arch/a

Re: [PATCH V2 1/2] arm: mach-k3: Move K3 degenerate keys out of board folder

2023-11-06 Thread Andrew Davis
Menon --- Reviewed-by: Andrew Davis Changes from V1: * Dropped the override from verdin dtsi V1: https://lore.kernel.org/all/20231103224453.3264313-1...@ti.com/ arch/arm/dts/k3-am625-verdin-wifi-dev-binman.dtsi | 4 arch/arm/dts/k3-binman.dtsi

Re: [PATCH V2 2/4] board: beagle: Add BeagleBone AI-64 support

2023-11-06 Thread Andrew Davis
On 11/4/23 3:11 AM, Nishanth Menon wrote: Add base support for BeagleBone AI-64 board support. Further information at https://beagleboard.org/ai-64 Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/Kconfig |1 + board/beagle/beagleboneai64/Kconfig | 59

Re: [PATCH V2 2/2] arm: mach-k3: Move TI dummy keys out of board folder

2023-11-06 Thread Andrew Davis
On 11/3/23 9:45 PM, Nishanth Menon wrote: This file is used to emulate customer keys on TI development board ecosystems, move it out of board/ directory and into mach-k3. And change the relative paths to absolute paths in the binman paths. While at it, drop the reference in verdin-binman file wh

Re: Dropping CONFIG_SCSI

2023-08-21 Thread Andrew Davis
On 8/20/23 12:59 PM, Tom Rini wrote: On Sun, Aug 20, 2023 at 11:49:21AM -0600, Simon Glass wrote: Hi, The deadline has passed for the non-driver model SCSI code. The boards below still have this enabled: $ ./tools/moveconfig.py -f SCSI ~DM_SCSI controlcenterdc am57xx_hs_evm_usb ls1088ardb_sdca

[PATCH] configs: Enable CONFIG_DM_SCSI in am57xx_hs_evm_usb

2023-08-21 Thread Andrew Davis
This should have already been enabled but was missed when converting the base platform defconfig, fix this here. Fixes: 3c5aa6caccab ("configs: Enable CONFIG_BLK in am57xx_evm and am57xx_hs_evm") Signed-off-by: Andrew Davis --- configs/am57xx_hs_evm_usb_defconfig | 4 ++-- 1 file

Re: Config fragments

2023-08-23 Thread Andrew Davis
On 8/23/23 10:30 AM, Simon Glass wrote: Hi, Up until 2023.04 it has been possible to build all the defconfigs but with 2023.07 that changed. Tom mentioned this to me recently. Up until 2023.04 we can enumerate all the board configs that can be built. We can build any of them using a single name

Re: Config fragments

2023-08-29 Thread Andrew Davis
On 8/29/23 11:47 AM, Simon Glass wrote: Hi Andrew, On Wed, 23 Aug 2023 at 10:44, Andrew Davis wrote: On 8/23/23 10:30 AM, Simon Glass wrote: Hi, Up until 2023.04 it has been possible to build all the defconfigs but with 2023.07 that changed. Tom mentioned this to me recently. Up until

[RFC PATCH 1/2] Makefile: Run defconfig files through the C preprocessor

2023-08-29 Thread Andrew Davis
This allows us to use some of the normal preprocessor directives inside defconfig files. Such as #define and #include. Signed-off-by: Andrew Davis --- scripts/kconfig/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/Makefile b/scripts/kconfig

[RFC PATCH 0/2] Allow defconfigs defined from fragments

2023-08-29 Thread Andrew Davis
Hello all, For context see thread ending here[0]. Thanks, Andrew [0] https://marc.info/?l=u-boot&m=169333616210919&w=2 Andrew Davis (2): Makefile: Run defconfig files through the C preprocessor configs: Add am62x_beagleplay_* defconfigs configs/am62x_beagleplay_a53_defco

[RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-08-29 Thread Andrew Davis
Add am62x_beagleplay_r5_defconfig for R5 SPL and am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. These defconfigs are composite defconfigs built from the config fragment board/ti/am62x/beagleplay_*.config applied onto the base am62x_evm_*_defconfig. Signed-off-by: Andrew Davis

Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-08-30 Thread Andrew Davis
On 8/30/23 7:31 AM, Nishanth Menon wrote: On 17:14-20230829, Andrew Davis wrote: Add am62x_beagleplay_r5_defconfig for R5 SPL and am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. These defconfigs are composite defconfigs built from the config fragment board/ti/am62x/beagleplay_

Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-08-30 Thread Andrew Davis
On 8/30/23 9:59 AM, Nishanth Menon wrote: On 09:31-20230830, Andrew Davis wrote: On 8/30/23 7:31 AM, Nishanth Menon wrote: On 17:14-20230829, Andrew Davis wrote: Add am62x_beagleplay_r5_defconfig for R5 SPL and am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. These defconfigs

Re: [RFC PATCH 2/2] binman: j721e: Add firewall configurations for atf

2023-09-05 Thread Andrew Davis
On 9/5/23 3:21 AM, Manorit Chawdhry wrote: The following commits adds the configuration of firewalls required to protect ATF and OP-TEE memory region from non-secure reads and writes using master and slave firewalls present in our K3 SOCs. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-j

[PATCH] Makefile: Force regeneration of env.txt

2023-09-05 Thread Andrew Davis
just force it for now. Signed-off-by: Andrew Davis --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9be24c4ec61..d195590d4b0 100644 --- a/Makefile +++ b/Makefile @@ -1830,7 +1830,7 @@ quiet_cmd_envc = ENVC$@

Re: [PATCH] Makefile: Force regeneration of env.txt

2023-09-05 Thread Andrew Davis
On 9/5/23 1:09 PM, Andrew Davis wrote: If the source .env file changes to one that is also older than the generated env.txt file then it is not regenerated. This means when switching board configs we do not regenerate the env. This can be tested easily with: $ make j721e_evm_a72_defconfig

Re: [RFC PATCH 2/2] binman: j721e: Add firewall configurations for atf

2023-09-06 Thread Andrew Davis
On 9/6/23 12:18 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:22-20230905, Andrew Davis wrote: On 9/5/23 3:21 AM, Manorit Chawdhry wrote: The following commits adds the configuration of firewalls required to protect ATF and OP-TEE memory region from non-secure reads and writes using master and

Re: [RFC PATCH 2/2] binman: j721e: Add firewall configurations for atf

2023-09-08 Thread Andrew Davis
On 9/8/23 6:43 AM, Manorit Chawdhry wrote: Hi Andrew, On 08:54-20230906, Andrew Davis wrote: On 9/6/23 12:18 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:22-20230905, Andrew Davis wrote: On 9/5/23 3:21 AM, Manorit Chawdhry wrote: The following commits adds the configuration of firewalls

Re: [PATCH v3 11/16] board: ti: j784s4: Add support for board detection by EEPROM read

2023-09-08 Thread Andrew Davis
On 9/8/23 9:42 AM, Nishanth Menon wrote: On 16:35-20230908, Apurva Nandan wrote: From: Dasnavis Sabiya The board name is programmed in the EEPROM. Add support for board detection and choose the right dtb based on the board name read from EEPROM. The J784S4/AM69 has two platforms naming J784S4

Re: [PATCH v3 11/16] board: ti: j784s4: Add support for board detection by EEPROM read

2023-09-08 Thread Andrew Davis
On 9/8/23 12:03 PM, Nishanth Menon wrote: On 10:59-20230908, Andrew Davis wrote: On 9/8/23 9:42 AM, Nishanth Menon wrote: On 16:35-20230908, Apurva Nandan wrote: From: Dasnavis Sabiya The board name is programmed in the EEPROM. Add support for board detection and choose the right dtb based

Re: [PATCH] Makefile: Force regeneration of env.txt

2023-09-15 Thread Andrew Davis
On 9/10/23 5:36 PM, Simon Glass wrote: Hi Andrew, On Tue, 5 Sept 2023 at 12:15, Andrew Davis wrote: On 9/5/23 1:09 PM, Andrew Davis wrote: If the source .env file changes to one that is also older than the generated env.txt file then it is not regenerated. This means when switching board

[PATCH v2] Makefile: Force regeneration of env.txt

2023-09-15 Thread Andrew Davis
that is okay for this test $ make am64x_evm_a53_defconfig $ make $ vim include/generated/env.txt Note this is still the J721e env not the AM64 config as expected. As ENV_FILE is set based on configuration, regenerate anytime autoconf.h changes. Signed-off-by: Andrew Davis --- Changes for v2

Re: [PATCH] arch: mach-k3: j721s2_init: Disable the firewalls

2023-03-28 Thread Andrew Davis
: Jayesh Choudhary --- Matches what we do in j721e_init.c, LGTM, Reviewed-by: Andrew Davis arch/arm/mach-k3/j721s2_init.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/arch/arm/mach-k3/j721s2_init.c b/arch/arm/mach-k3/j721s2_init.c index 09e55ed456

[PATCH 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-03-30 Thread Andrew Davis
The J7200 EVM will not include this file, all these J7200 checks look to be copy/paste errors from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis --- include/configs/j721s2_evm.h | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a

[PATCH 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-03-30 Thread Andrew Davis
This belongs in the J721e specific file as it is the only place this is used. Any board level users should use the SOC driver. While here, move the J721e and J7200 SoC IDs out of sys_proto.h and into hardware.h. Add the rest of the SoC IDs for completeness and later use. Signed-off-by: Andrew

[PATCH 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-03-30 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach

[PATCH 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-03-30 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3

[PATCH 04/12] configs: j721x_evm.h: Remove unneeded check for SYS_K3_SPL_ATF

2023-03-30 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis --- include/configs/j721e_evm.h | 4 +--- include/configs/j721s2_evm.h | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-03-30 Thread Andrew Davis
board detection. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 3 +-- arch/arm/mach-k3/am654_init.c | 3 +-- arch/arm/mach-k3/common.c | 10 ++ arch/arm/mach-k3/common.h | 2 ++ arch/arm/mach-k3/include/mach

[PATCH 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-03-30 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files changed, 10 insertions(+), 22

[PATCH 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-03-30 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654-ddrss.c | 4 2

[PATCH 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-03-30 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1 - board/siemens/iot2050/board.c

[PATCH 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-03-30 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c| 64

[PATCH 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-03-30 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

[PATCH 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-03-30 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 51

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the config sections of the fitImage. Our env var settings for chosing which section to boot from needs to

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:36 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core

Re: [PATCH v2 02/18] binman: ti-secure: Add support for TI signing

2023-04-04 Thread Andrew Davis
On 4/4/23 7:13 AM, Neha Malcom Francis wrote: The ti-secure entry contains certificate for binaries that will be loaded or booted by system firmware whereas the ti-secure-rom entry contains certificate for binaries that will be booted by ROM. Support for both these types of certificates is necess

Re: [PATCH v2 05/18] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-04-04 Thread Andrew Davis
On 4/4/23 7:13 AM, Neha Malcom Francis wrote: By providing entries in the binman node of the device tree, binman will be able to find and package board config artifacts generated by TIBoardConfig with sysfw.bin and generate the final image sysfw.itb. It will also pick out the R5 SPL and sign it w

[PATCH] binman: Use unsigned long over typedef ulong

2023-04-04 Thread Andrew Davis
d for typedef'ing it in some of the tests, so also remove those. Signed-off-by: Andrew Davis --- include/binman_sym.h| 8 tools/binman/test/blob_syms.c | 2 -- tools/binman/test/u_boot_binman_syms.c | 2 -- tools/binman/test/u_boot_binman_s

Re: [PATCH v2 00/18] Migration to using binman to generate

2023-04-04 Thread Andrew Davis
rm support strategy. Thank you! For the whole series, Acked-by: Andrew Davis [0] https://lists.denx.de/pipermail/u-boot/2023-April/514400.html

Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
On 4/2/23 5:44 AM, Christian Gmeiner wrote: Hi Andrew Am Do., 30. März 2023 um 22:30 Uhr schrieb Andrew Davis : This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need to check for TI_I2C_BOARD_DETECT

[PATCH v2 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-05 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

[PATCH v2 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-05 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach

[PATCH v2 00/12] Remove K3 misc sys_proto.h header

2023-04-05 Thread Andrew Davis
Hello all, Some minor cleanups with end patch removing sys_proto.h. Why? Becouse I don't like headers of "miscellaneous". Thanks, Andrew Changes from v1: - Added reviewed by tag - Rebased on latest Andrew Davis (12): arm: mach-k3: Move MSMC fixup to SoC level arm: mach-k3:

[PATCH v2 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-05 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/j721s2_evm.h b

[PATCH v2 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-05 Thread Andrew Davis
This belongs in the J721e specific file as it is the only place this is used. Any board level users should use the SOC driver. While here, move the J721e and J7200 SoC IDs out of sys_proto.h and into hardware.h. Add the rest of the SoC IDs for completeness and later use. Signed-off-by: Andrew

[PATCH v2 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-05 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files changed, 10 insertions(+), 22

[PATCH v2 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-05 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions(-) diff --git a/board/ti/j721e

[PATCH v2 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-05 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3

[PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-05 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654-ddrss.c | 4 2

[PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis --- arch/arm

[PATCH v2 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-05 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 51

[PATCH v2 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-05 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

[PATCH v2 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-05 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c| 64

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
needed. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 5 - arch/arm/mach-k3/am642_init.c | 4 ++-- arch/arm/mach-k3/am654_init.c | 4 ++-- arch/arm/mach-k3/common.c | 10 ++ arch/arm/mach-k3/common.h

Re: [PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
that sayed you can add my Rb. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654-ddrss.c | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-k3/include/mach/sys_proto.h b/arch/arm/mach-k3/in

[PATCH v3 00/12] Remove K3 misc sys_proto.h header

2023-04-06 Thread Andrew Davis
d detection can use other methods - Added more reviewed by tags Changes from v1: - Added reviewed by tag - Rebased on latest Andrew Davis (12): arm: mach-k3: Move MSMC fixup to SoC level arm: mach-k3: Move J721e SoC detection out of common section soc: soc_ti_k3: Use hardware.h to remo

[PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm/mach-k3/include/mach/sys_proto.h | 3 --- 4 files

[PATCH v3 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-06 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

[PATCH v3 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files

  1   2   3   4   >