Re: [PATCH 06/25] binman: Use 'files-compress' to set compression for files

2020-10-19 Thread Alper Nebi Yasak
On 19/10/2020 05:41, Simon Glass wrote: > At present we use 'compress' as the property to set the compression of > a 'files' entry. But this conflicts with the same property for entries, > of which Entry_section is a subclass. > > Strictly speaking, since Entry_files is in fact a subclass of > Ent

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-10-19 Thread Alper Nebi Yasak
On 19/10/2020 05:41, Simon Glass wrote: > When a section is compressed, all entries within it are grouped together > into a compressed block of data. This obscures the start of each > individual child entry. > > Avoid reporting bogus 'image-pos' properties in this case, since it is > not possible

Re: [patch 4/8] RFC: drivers/video/rockchip/rk_edp.c: Change clock rate

2020-10-22 Thread Alper Nebi Yasak
On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote: > The current code is setting the clock rate to 19200, but > due to the current device-tree configuration and linux code, > it should rather be 1. > This looks like it's ACLK_VOP to me. FYI, coreboot sets it to 192 MHz for rk3288 and 200

[PATCH] video: rockchip: Restrict EDP, VOP, MIPI files to GPL-2.0

2020-10-22 Thread Alper Nebi Yasak
es are already 2.0+ there and rk_lvds.c has no counterpart, so keep them as is. Cc: Simon Glass Cc: Philipp Tomsich Cc: Eric Gao Cc: Jacob Chen Signed-off-by: Alper Nebi Yasak --- See Tom Rini's comment [1] and the preceding discussion for more context. [1] https://patchwork.ozlabs.o

[PATCH 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-10-22 Thread Alper Nebi Yasak
dor firmware is possible on gru boards as well, do the same thing for them too. Signed-off-by: Alper Nebi Yasak --- board/google/gru/gru.c | 23 +++ configs/chromebook_bob_defconfig | 1 + 2 files changed, 24 insertions(+) diff --git a/board/google/gru/gru.c b/board/g

[PATCH 1/2] rockchip: rk3399: Re-init clocks in U-Boot proper

2020-10-22 Thread Alper Nebi Yasak
ss of being upstreamed). This is meant to be a rk3399 version of commit d3cb46aa8c41 ("rockchip: Init clocks again when chain-loading") which can detect the discrepancy, but this patch can not so it always re-inits. Signed-off-by: Alper Nebi Yasak --- The rk3288 version has rockchip

[PATCH v3 1/2] video: backlight: Support PWMs without a known period_ns

2020-10-22 Thread Alper Nebi Yasak
a PWM channel that has a fixed period, checking that the resulting duty_cycle matches on a set_config() even if the requested period_ns can't be set. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- Changes in v3: - Add tag: "Reviewed-by: Simon Glass " - Adjust to m

[PATCH v3 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-10-22 Thread Alper Nebi Yasak
Linux, before it was converted to YAML at 5df5a577a6b4 ("dt-bindings: pwm: Convert google,cros-ec-pwm.txt to YAML format") in their repo. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- I'm testing on a rk3399-gru-kevin with a lot of other patches to get it and it&#

Re: [patch 2/8] RFC: drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-10-23 Thread Alper Nebi Yasak
On 23/10/2020 11:49, Arnaud Patard (Rtp) wrote: > Alper Nebi Yasak writes: >> I think instead of supporting both devices in the same driver, it'd be >> cleaner to split chip-specific parts into rk3288_edp.c and rk3399_edp.c >> like the other ones for vop, hdmi, etc; t

Re: [PATCH 1/2] rockchip: rk3399: Re-init clocks in U-Boot proper

2020-10-24 Thread Alper Nebi Yasak
On 24/10/2020 03:05, Simon Glass wrote: > Hi Alper, > > On Thu, 22 Oct 2020 at 14:37, Alper Nebi Yasak > wrote: >> >> It's possible to chainload U-Boot proper from the vendor firmware in >> rk3399 chromebooks, but the way the vendor firmware sets up clocks

Re: [PATCH 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-10-24 Thread Alper Nebi Yasak
On 24/10/2020 03:05, Simon Glass wrote: > Hi Alper, > > On Thu, 22 Oct 2020 at 14:38, Alper Nebi Yasak > wrote: >> >> Commit fe974716326c ("rockchip: rk3288: Allow setting up clocks in >> U-Boot proper") fixes some clock issues when chainloading U-Boo

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-10-26 Thread Alper Nebi Yasak
On 26/10/2020 22:22, Simon Glass wrote: > Hi Alper, > > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > wrote: >> >> On 19/10/2020 05:41, Simon Glass wrote: >>> When a section is compressed, all entries within it are grouped together >>> into a compres

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-10-26 Thread Alper Nebi Yasak
On 26/10/2020 22:22, Simon Glass wrote: > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > wrote: >> On 19/10/2020 05:41, Simon Glass wrote: >>> for entry in self._entries.values(): >>> data = entry.GetData() >>> -base

[PATCH v2 1/2] rockchip: rk3399: Init clocks in U-Boot proper if SPL was not run

2020-10-27 Thread Alper Nebi Yasak
the init if it was not. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Check for SPL handoff instead of always re-initializing v1: https://patchwork.ozlabs.org/project/uboot/patch/20201022203740.24528-1-alpernebiya...@gmail.com/ drivers/clk/rockchip/clk_rk3399.c | 22 +++

[PATCH v2 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-10-27 Thread Alper Nebi Yasak
dor firmware is possible on gru boards as well, do the same thing for them too. On rk3399, this needs to detect whether SPL was run via handoff, so enable that and bloblist kconfigs it needs for chromebook_bob. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Enable kconfigs needed for using

[PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-10-27 Thread Alper Nebi Yasak
Add "boe,nv101wxmn51" to the compatible node. This is the panel for chromebook_bob. Signed-off-by: Alper Nebi Yasak --- I didn't test this as I don't have a gru-bob, but this panel is listed among Linux's simple-panel compatibles [1] just like gru-kevin's (which I

[PATCH 1/2] video: simple_panel: Add sharp,lq123p1jx31 display

2020-10-27 Thread Alper Nebi Yasak
Add "sharp,lq123p1jx31" to the compatible node. This is the panel for chromebook_kevin. Signed-off-by: Alper Nebi Yasak --- drivers/video/simple_panel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c index 6c

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-27 Thread Alper Nebi Yasak
Signed-off-by: Arnaud Patard > I didn't test individual patches, but non-pinebook-pro parts of this series as a whole (after some more patches of mine) get me a vidconsole on the rk3399-gru-kevin's display, so I'm going to send "Tested-by"s to the patches I had included in my branch: Tested-by: Alper Nebi Yasak

Re: [patch v2 02/10] drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-10-27 Thread Alper Nebi Yasak
a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper Nebi Yasak

Re: [patch v2 03/10] drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration

2020-10-27 Thread Alper Nebi Yasak
1): Tested-by: Alper Nebi Yasak

Re: [patch v2 00/10] rk3399 (Pinebook pro) EDP support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > This patchset add support for the rk3399 eDP. It has been tested on the > pinebook > pro and Google Kevin chromeos devices. > > The changes have been written by studying the linux code, since I didn't find > any > manual for theses part of the RK

Re: [patch v2 04/10] drivers/video/rockchip/rk_vop.c: Reserve efi fb memory

2020-10-27 Thread Alper Nebi Yasak
ested-by: Alper Nebi Yasak

Re: [patch v2 07/10] drivers/pwm/rk_pwm.c: Fix default polarity

2020-10-27 Thread Alper Nebi Yasak
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE > by default instead. > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper Nebi Yasak

Re: [patch v2 10/10] drivers/video/rockchip/rk_vop.c: Add reset support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > In order to ensure that the VOP registers are in correct state, > add missing support for the VOP reset lines found in the device-tree > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper Nebi Yasak

Re: [patch v2 09/10] drivers/video/rockchip/rk_edp.c: Add missing reset support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > In order to ensure that the eDP registers are in correct state, > add missing support for the eDP reset lines found in the device-tree. > > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested

Re: [patch v2 08/10] drivers/video/rockchip/rk_vop.c: Fix format of fbbase in debug string

2020-10-27 Thread Alper Nebi Yasak
(see comment in patch 1): Tested-by: Alper Nebi Yasak

Re: [PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-10-27 Thread Alper Nebi Yasak
On 28/10/2020 00:52, Mark Kettenis wrote: >> From: Alper Nebi Yasak >> Date: Wed, 28 Oct 2020 00:41:55 +0300 >> >> Add "boe,nv101wxmn51" to the compatible node. This is the panel for >> chromebook_bob. > > I do have bob, and would be interested in

[PATCH] cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT

2020-10-30 Thread Alper Nebi Yasak
0 00 00 in-header: 03 df 00 00 0e 00 00 00 in-data: 00 00 00 00 00 00 00 00 00 00 00 00 10 00 ec_command_inptr: len=14, din=f412df30 key_matrix_decode: num_keys = 1 valid=1, row=4, col=11 keycode=28 1 valid keycodes found {0d} Signed-off-b

[PATCH 2/2] mtd: spi-nor-ids: Add Gigadevice GD25LQ64C

2020-10-31 Thread Alper Nebi Yasak
bps 2 write: 14 ticks, 285 KiB/s 2.280 Mbps 3 read: 3 ticks, 1333 KiB/s 10.664 Mbps The values are the same as in Linux, except adjusted for the U-Boot definition of INFO(). Signed-off-by: Alper Nebi Yasak --- This is from Linux's drivers/mtd/spi-nor/gigadevice.c which is GPL-2.0,

[PATCH 1/2] mtd: spi-nor: Correct spi-nor-ids.c license to GPL-2.0

2020-10-31 Thread Alper Nebi Yasak
for SPL") which marked the then-new file incorrectly as GPL-2.0+. This corrects the file's license header to GPL-2.0, which is also necessary to sync further changes from Linux. Signed-off-by: Alper Nebi Yasak --- drivers/mtd/spi/spi-nor-ids.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-11-04 Thread Alper Nebi Yasak
On 03/11/2020 18:11, Simon Glass wrote: > Hi Alper, > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > wrote: >> >> On 26/10/2020 22:22, Simon Glass wrote: >>> I've added a few test cases along these lines in v2, and one of them >>> certainly d

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-11-04 Thread Alper Nebi Yasak
On 30/10/2020 21:15, Simon Glass wrote: > Hi Alper, > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > wrote: >> What I meant is using pairs of , >> to avoid losing position information of >> compressed entries, but honestly I'm not sure if any of thi

Re: [rockchip] broken SPI on RockPro64 and other RK3399 targets

2020-11-05 Thread Alper Nebi Yasak
On 05/11/2020 18:55, Marcin Juszkiewicz wrote: > I wanted to update U-Boot on my RockPro64 board from some random build > of 2020.07-rc with out of tree patches to official one. Built, flashed > and then got this: > > Loading Environment from SPI Flash... Invalid bus 0 (err=-19) > *** Warning -

Re: [rockchip] broken SPI on RockPro64 and other RK3399 targets

2020-11-05 Thread Alper Nebi Yasak
On 05/11/2020 20:04, Marcin Juszkiewicz wrote: > W dniu 05.11.2020 o 17:49, Alper Nebi Yasak pisze: > >> I suspect this change in that commit (rk3399-u-boot.dtsi): >> >>> / { >>> aliases { >>> mmc0 = &sdhci; >>>

Re: [PATCH 1/1] cros_ec: Handling EC_CMD_GET_NEXT_EVENT

2020-11-09 Thread Alper Nebi Yasak
On 09/11/2020 23:34, Heinrich Schuchardt wrote: > With commit 690079767803 ("cros_ec: Support keyboard scanning with > EC_CMD_GET_NEXT_EVENT") check_for_keys() tries to read keyboard > strokes using EC_CMD_GET_NEXT_EVENT. But the sandbox driver does > not understand this command. We need to reply w

Re: [PATCH] cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT

2020-11-09 Thread Alper Nebi Yasak
On 09/11/2020 22:37, Simon Glass wrote: > Hi Heinrich, > > On Mon, 9 Nov 2020 at 12:34, Heinrich Schuchardt wrote: >> >> On 10/30/20 6:25 PM, Alper Nebi Yasak wrote: >>> The cros_ec_keyb driver currently uses EC_CMD_MKBP_STATE to scan the >>> keyboard,

[PATCH] sandbox: cros_ec: Basic support for EC_CMD_GET_NEXT_EVENT

2020-11-10 Thread Alper Nebi Yasak
river send basic responses to the command, but the response only supports keyboard scans for now. Fixes: 690079767803 ("cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT") Reported-by: Heinrich Schuchardt Signed-off-by: Alper Nebi Yasak --- This doesn't test the -EC_RE

Re: [PATCH] binman: Handle tool paths containing '~' correctly

2020-11-10 Thread Alper Nebi Yasak
On 09/11/2020 17:45, Simon Glass wrote: > At present if CROSS_COMPILE contains a tilde, such as > ~/.buildman-toolchains/gcc-7.3.0-nolibc/i386-linux/bin/i386-linux-gcc > then binman gives a confusing error: > >binman: Error 255 running '~/..buildman-toolchains/gcc-7.3.0- ... > > Fix this by e

Re: [PATCH] sandbox: cros_ec: Basic support for EC_CMD_GET_NEXT_EVENT

2020-11-10 Thread Alper Nebi Yasak
On 10/11/2020 20:08, Heinrich Schuchardt wrote: > On 10.11.20 15:00, Alper Nebi Yasak wrote: >> Since commit 690079767803 ("cros_ec: Support keyboard scanning with >> EC_CMD_GET_NEXT_EVENT") the cros-ec-keyb driver has started using this >> command, but the sandbox

Re: [PATCH] rockchip: Move Bob specific bits to it's specific u-boot.dtsi

2020-11-10 Thread Alper Nebi Yasak
On 10/11/2020 20:18, Hugh Cole-Baker wrote: > Hi, > >> On 10 Nov 2020, at 07:34, Kever Yang wrote: >> >> Hi Peter, >> >> On 2020/11/9 上午7:02, Peter Robinson wrote: >>> Move the bits that are device specific to the -u-boot.dtsi as the >>> bits may be different on other devices and hence breaks SPI

[PATCH v2] sandbox: cros_ec: Basic support for EC_CMD_GET_NEXT_EVENT

2020-11-13 Thread Alper Nebi Yasak
d will not trigger and will not be tested anymore. Fixes: 690079767803 ("cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT") Reported-by: Heinrich Schuchardt Signed-off-by: Alper Nebi Yasak Tested-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- Changes in v2: - Add tag:

Re: [BUG] Hang shortly after loading FDT when booting on RK3399

2020-11-17 Thread Alper Nebi Yasak
On 17/11/2020 04:49, Jean Lucas wrote: > Hello all, > > On Pine64 RockPro64 and Pinebook Pro (both RK3399), flashing U-Boot > v2021.01-rc2-47-g9324c9a823 defconfig and mainline ATF > v2.4-rc0-2-gd01f31c03 to SPI flash of both devices results in a hang > shortly after loading the appropriate FDT

Re: [BUG] Hang shortly after loading FDT when booting on RK3399

2020-11-17 Thread Alper Nebi Yasak
On 17/11/2020 17:11, Peter Robinson wrote: > On Tue, Nov 17, 2020 at 12:43 PM Alper Nebi Yasak > wrote: >> >> On 17/11/2020 04:49, Jean Lucas wrote: >>> Hello all, >>> >>> On Pine64 RockPro64 and Pinebook Pro (both RK3399), flashing U-Boot >>&

Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-28 Thread Alper Nebi Yasak
On 21/01/2022 18:20, Simon Glass wrote: > On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak > wrote: >> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c >> index 278473899c7c..f0d7ba4774d6 100644 >> --- a/drivers/mmc/rockchip_sdhci.c >> +++

[PATCH v4 0/4] rockchip: sdhci: Fix reinit and add HS400 Enhanced Strobe support

2022-01-28 Thread Alper Nebi Yasak
8_sdhci_set_enhanced_strobe - Let set_enhanced_strobe() unset the ES bit if mode is not HS400_ES - Rewrote cover letter v1: https://patchwork.ozlabs.org/project/uboot/list/?series=269768&state=* Alper Nebi Yasak (4): mmc: sdhci: Add HS400 Enhanced Strobe support rockchip: sdhci: Fix RK3399

[PATCH v4 1/4] mmc: sdhci: Add HS400 Enhanced Strobe support

2022-01-28 Thread Alper Nebi Yasak
Delegate setting the Enhanced Strobe configuration to individual drivers if they set a function for it. Return -ENOTSUPP if they do not, like what the MMC uclass does. Signed-off-by: Alper Nebi Yasak Reviewed-by: Jaehoon Chung --- Changes in v4: - Add comment for SDHCI set_enhanced_strobe

[PATCH v4 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-28 Thread Alper Nebi Yasak
least on a chromebook_kevin. Signed-off-by: Alper Nebi Yasak --- RK3568 parts only build-tested as I don't have a RK3568 board. Changes in v4: - Add comment for Rockchip SDHCI set_control_reg() driver data op - Add comment for Rockchip SDHCI set_ios_post() driver data op Changes in v2: -

[PATCH v4 3/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399

2022-01-28 Thread Alper Nebi Yasak
(). This is mostly ported from Linux's Arasan SDHCI driver which happens to be the underlying IP. (drivers/mmc/host/sdhci-of-arasan.c in Linux tree). Signed-off-by: Alper Nebi Yasak --- Changes in v4: - Add comment for Rockchip SDHCI set_enhanced_strobe() driver data op Changes in v2: - Uns

[PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-01-28 Thread Alper Nebi Yasak
e the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in Linux tree). Signed-off-by: Alper Nebi Yasak --- Only build-tested as I don't have a RK3568 board. (no changes since v3) Changes in v3: - Set DWCMSHC_CARD_IS_EMMC bit in rk3568_emmc_phy_init() Changes in v2: - Rename rk3568_set_enhan

[PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-29 Thread Alper Nebi Yasak
es an IndexError if a blank line was removed. Let print() print the new lines, and use size-independent ways to check strings to fix the diff output. Signed-off-by: Alper Nebi Yasak --- tools/moveconfig.py | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH] armv8: spl: Fix build with LINUX_KERNEL_IMAGE_HEADER

2022-01-29 Thread Alper Nebi Yasak
included in U-Boot proper's linker script to fix the error. Signed-off-by: Alper Nebi Yasak --- I won't actually need this header in the SPL, but I need the build to succeed with SPL and this config both selected. I did test that booting bare-metal still works on my rk3399 chromebook_

[PATCH] rockchip: Set default LNX_KRNL_IMG_TEXT_OFFSET_BASE to SYS_TEXT_BASE

2022-01-29 Thread Alper Nebi Yasak
offset from 2MiB alignment which must also be customized through LNX_KRNL_IMG_TEXT_OFFSET_BASE. Set it equal to SYS_TEXT_BASE by default for Rockchip boards, which happens to make this offset zero and works fine on chromebook_kevin both for chainloading and bare-metal use. Signed-off-by: Alper Nebi

[PATCH] Convert CONFIG_REMAKE_ELF to Kconfig

2022-01-29 Thread Alper Nebi Yasak
This converts the following to Kconfig: CONFIG_REMAKE_ELF Signed-off-by: Alper Nebi Yasak --- Added the Kconfig fragment and just ran `moveconfig.py --commit --yes` at commit 6146cd62aedc ("Merge branch '2022-01-24-assorted-updates'"), before the recent changes. Also ran i

Re: [PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-30 Thread Alper Nebi Yasak
On 30/01/2022 00:09, Simon Glass wrote: > On Sat, 29 Jan 2022 at 08:22, Alper Nebi Yasak > wrote: >> Commit 37f815cad07d ("moveconfig: Use a function to read files") adds a >> helper function that can read a file as lines, but strips the newline >> char

[PATCH 0/5] binman: Improvements to FIT entry type

2022-02-06 Thread Alper Nebi Yasak
asier way to know the positions. I would try to refactor and experiment with FIT things more, but I know Simon's currently working on converting SPL_FIT_GENERATOR to binman. Instead I'm just sending things I have already done with some tests added, hopefully without too many conflict

[PATCH 1/5] binman: Fix subentry expansion for FIT entry type

2022-02-06 Thread Alper Nebi Yasak
s possible that unexpanded child entries have no data of their own. The FIT entry type doesn't currently do this, which means putting a "u-boot" entry inside it doesn't work as expected. Implement ExpandEntries() for FIT and add a copy of a simple FIT image test that checks su

[PATCH 2/5] binman: Register and check bintools from FIT subentries

2022-02-06 Thread Alper Nebi Yasak
heck their existence by copying the appropriate method from Section entry type. Also add tests that check if these subentries can use and warn about binary tools. Signed-off-by: Alper Nebi Yasak --- tools/binman/etype/fit.py | 14 +++ tools/binman/ftest.py

[PATCH 3/5] binman: Check missing bintools of Section subclasses

2022-02-06 Thread Alper Nebi Yasak
for subclasses of Section which might need binary tools. Make sure missing binary tools are checked for subclasses of the Section entry type as well, by calling the parent class' implementation in the relevant Section method. Signed-off-by: Alper Nebi Yasak --- This starts being test

[PATCH 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-06 Thread Alper Nebi Yasak
implements. Also fix the subentry alignment test which now attempts to write symbols to a nonexistent SPL ELF test file by creating it first. Signed-off-by: Alper Nebi Yasak --- tools/binman/etype/fit.py | 70 +++ tools/binman/ftest.py | 1 + 2 files changed

[PATCH 5/5] binman: Update image positions of FIT subentries

2022-02-06 Thread Alper Nebi Yasak
tioned above, and add tests for the two ways binman can pack them in. Signed-off-by: Alper Nebi Yasak --- tools/binman/etype/fit.py | 51 + tools/binman/ftest.py | 112 ++ 2 files changed, 163 insertions(+) diff --git a/tools/binman/etyp

Re: [PATCH 0/5] binman: Improvements to FIT entry type

2022-02-07 Thread Alper Nebi Yasak
On 07/02/2022 23:22, Simon Glass wrote: > On Sun, 6 Feb 2022 at 14:03, Alper Nebi Yasak > wrote: >> >> I've managed to build images like in doc/chromium/chainload.rst wtih >> binman, but ran into an issue with entry expansion in FIT and worked on >> it a bit.

[PATCH v2 0/5] binman: Improvements to FIT entry type

2022-02-07 Thread Alper Nebi Yasak
Changes in v2: - Split reused testSimpleFit code into a helper function - Check missing_bintools list instead of catching Fdt exceptions - Add tag: "Reviewed-by: Simon Glass " v1: https://patchwork.ozlabs.org/project/uboot/list/?series=284714 Alper Nebi Yasak (5): binman: Fix subentr

[PATCH v2 1/5] binman: Fix subentry expansion for FIT entry type

2022-02-07 Thread Alper Nebi Yasak
s possible that unexpanded child entries have no data of their own. The FIT entry type doesn't currently do this, which means putting a "u-boot" entry inside it doesn't work as expected. Implement ExpandEntries() for FIT and add a copy of a simple FIT image test that checks su

[PATCH v2 2/5] binman: Register and check bintools from FIT subentries

2022-02-07 Thread Alper Nebi Yasak
heck their existence by copying the appropriate method from Section entry type. Also add tests that check if these subentries can use and warn about binary tools. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- Changes in v2: - Add tag: "Reviewed-by: Simon Glass " tools

[PATCH v2 3/5] binman: Check missing bintools of Section subclasses

2022-02-07 Thread Alper Nebi Yasak
for subclasses of Section which might need binary tools. Make sure missing binary tools are checked for subclasses of the Section entry type as well, by calling the parent class' implementation in the relevant Section method. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- This s

[PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-07 Thread Alper Nebi Yasak
implements. Also fix the subentry alignment test which now attempts to write symbols to a nonexistent SPL ELF test file by creating it first. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- Changes in v2: - Add tag: "Reviewed-by: Simon Glass " tools/binman/etype/f

[PATCH v2 5/5] binman: Update image positions of FIT subentries

2022-02-07 Thread Alper Nebi Yasak
tioned above, and add tests for the two ways binman can pack them in. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- Changes in v2: - Check missing_bintools list instead of catching Fdt exceptions - Add tag: "Reviewed-by: Simon Glass " tools/binman/etyp

Re: Running qemu tests on RISC-V

2022-02-08 Thread Alper Nebi Yasak
On 08/02/2022 20:13, Simon Glass wrote: > Hi Heinrich, > > On Tue, 8 Feb 2022 at 08:34, Heinrich Schuchardt wrote: >> >> On 2/8/22 15:52, Simon Glass wrote: >>> Hi Heinrich, >>> >>> On Tue, 8 Feb 2022 at 01:21, Heinrich Schuchardt wrote: Hello Simon, The qemu-riscv32_spl_defconfig

Re: [PATCH] binman: Correct the error message for a bad hash algorithm

2022-02-08 Thread Alper Nebi Yasak
files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Alper Nebi Yasak I saw the failing build for my series [1]. Looks to me like binman doesn't support crc32 in hash nodes, and turning FIT into a Section simply exposed that. I tried a sloppy fix, see below. [1] https://source.den

Re: Running qemu tests on RISC-V

2022-02-08 Thread Alper Nebi Yasak
On 08/02/2022 23:43, Simon Glass wrote: > Thanks for testing it. I don't see this on > > 8b139f4e1c0 (HEAD, us/master) Merge tag 'u-boot-imx-20220207' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx > > : > > tools/binman/binman --toolpath ./tools build -u -d u-boot.dtb -O . > -m --a

[PATCH] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-08 Thread Alper Nebi Yasak
was disabled to mitigate this issue. Signed-off-by: Alper Nebi Yasak --- This applies on top of u-boot-dm/master, and does not resend my "binman: Update image positions of FIT subentries" patch [1] which should be applied on top of this. [1] https://patchwork.ozlabs.org/project/uboot

[PATCH v2] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-09 Thread Alper Nebi Yasak
was disabled to mitigate this issue. Signed-off-by: Alper Nebi Yasak --- This applies on top of u-boot-dm/master, and does not resend my "binman: Update image positions of FIT subentries" patch [1] which should be applied on top of this. [1] https://patchwork.ozlabs.org/project/uboot

Re: Running qemu tests on RISC-V

2022-02-09 Thread Alper Nebi Yasak
On 07/02/2022 19:49, Tom Rini wrote: > And as an aside, if anyone has tips on changes that would need to be > made to our Dockerfile so that some of those tools that let you run app > from a container "normally" would work with our container, that'd be > handy and appreciated. I also don't know wh

Re: Running qemu tests on RISC-V

2022-02-09 Thread Alper Nebi Yasak
On 09/02/2022 00:55, Simon Glass wrote: > Hi Alper, > > On Tue, 8 Feb 2022 at 14:36, Alper Nebi Yasak > wrote: >> If I run `touch fw_dynamic.bin` it no longer does, maybe check if such a >> file exists in your include paths. > > OK that is it, thanks. > > I

Re: [PATCH 00/24] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script

2022-02-11 Thread Alper Nebi Yasak
Hi, On 08/02/2022 21:49, Simon Glass wrote: > At present rockchip 64-bit boards make use of a FIT-generator script > written in Python. The script supports splitting an ELF file into several > 'loadable' nodes in the FIT. Binman does not current support this feature. > > This series adds binman s

Re: [PATCH 01/24] moveconfig: Show the config name rather than the defconfig

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > The _defconfig suffix is unnecessary when showing matching boards. Drop > it. > > Signed-off-by: Simon Glass > --- > > tools/moveconfig.py | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/tools/moveconfig.py b/to

Re: [PATCH 02/24] moveconfig: Allow regex matches when finding combinations

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > It is useful to be able to search for CONFIG options that match a regex, > such as this, which lists boards which define SPL_FIT_GENERATOR and > anything not starting with ROCKCHIP: > >./tools/moveconfig.py -f SPL_FIT_GENERATOR ~ROCKCHIP.* > > Add sup

Re: [PATCH 03/24] spl: x86: Correct the binman symbols for SPL

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > These symbols are incorrect, meaning that binman cannot find the > associated entry. This leads to errors like: > > binman: Section '/binman/simple-bin': Symbol '_binman_spl_prop_size' >in entry '/binman/simple-bin/u-boot-spl/u-boot-spl-nodtb': >En

Re: [PATCH 04/24] spl: Allow disabling binman symbols in SPL

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > When CONFIG_SPL_FIT is enabled we do not access U-Boot directly in > the image, since it is embedded in a FIT which is parsed at runtime. > > Provide a CONFIG option to drop the symbols in this case. > > Signed-off-by: Simon Glass > --- > > common/spl/

Re: [PATCH 06/24] dtoc: Support adding a string list to a device tree

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > Add a new function to add a string list. > > Signed-off-by: Simon Glass > --- > > tools/dtoc/fdt.py | 18 ++ > tools/dtoc/test_fdt.py | 8 > 2 files changed, 26 insertions(+) > > diff --git a/tools/dtoc/fdt.py b/tools/dto

Re: [PATCH 09/24] dtoc: Support reading a list of arguments

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > It is helpful to support a string or stringlist containing a list of > space-separated arguments, for example: > >args = "-n fred", "-a", "123"; > > This resolves to the list: > >-n fred -a 123 Would be clearer as ['-n', 'fred', '-a', '123'] >

Re: [PATCH 11/24] elf: Add a way to read segment information from an ELF file

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > Add a function which reads the segments and the entry address. > > Also fix a comment nit in the tests while we are here. > > Signed-off-by: Simon Glass > --- > > tools/binman/elf.py | 37 + > tools/binman/elf_t

Re: [PATCH 14/24] binman: Support a list of strings with the mkimage etype

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:49, Simon Glass wrote: > At present the 'args' property of the mkimage entry type is a string. This > makes it difficult to include CONFIG options in that property. In > particular, this does not work: > >args = "-n CONFIG_SYS_SOC -E" > > since the preprocessor does not opera

Re: [PATCH 16/24] binman: Move entry-data collection into a Entry method

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Collecting the data from a list of entries and putting it in a file is > a useful operation that will be needed by other entry types. Put this into > a method in the Entry class. > > Add some documentation about how to collect data for an entry type. > >

Re: [PATCH 17/24] binman: fit: Refactor to reduce function size

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Split subnode and property processing into separate functions to make > the _AddNode() function a little smaller. Tweak a few comments. > > This does not change any functionality. > > Signed-off-by: Simon Glass > --- I know this just moves code around a

Re: [PATCH 20/24] binman: Support splitting an ELF file into multiple nodes

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Some boards need to load an ELF file using the 'loadables' property, but > the file has segments at different memory addresses. This means that it > cannot be supplied as a flat binary. > > Allow generating a separate node in the FIT for each segment in th

Re: [PATCH 22/24] rockchip: Support building the all output files in binman

2022-02-15 Thread Alper Nebi Yasak
On 08/02/2022 21:50, Simon Glass wrote: > Add the required binman images to replace the Makefile rules which are > currently used. This includes subsuming: > >- tpl/u-boot-tpl-rockchip.bin if TPL is enabled >- idbloader.img if either or both of SPL and TPL are enabled >- u-boot.itb2 if

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-15 Thread Alper Nebi Yasak
On 14/02/2022 12:09, Jan Kiszka wrote: > On 07.02.22 23:08, Alper Nebi Yasak wrote: >> The binman FIT entry type shares some code with the Section entry type. >> This shared code is bound to grow, since FIT entries are conceptually a >> variation of Section entries. >&g

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-18 Thread Alper Nebi Yasak
On 18/02/2022 19:50, Jan Kiszka wrote: > On 15.02.22 18:06, Jan Kiszka wrote: >> On 15.02.22 17:50, Jan Kiszka wrote: >>> On 15.02.22 13:27, Alper Nebi Yasak wrote: >>>> The AddMissingProperties() and SetCalculatedProperties() methods were >>>> disabled fo

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-22 Thread Alper Nebi Yasak
On 21/02/2022 07:40, Simon Glass wrote: > On Sat, 19 Feb 2022 at 08:53, Simon Glass wrote: >> On Fri, 18 Feb 2022 at 10:34, Alper Nebi Yasak >> wrote: >>> I can reproduce this and tried a few things, but more issues just kept >>> popping up (outside u-boot as

Re: rk3399-gru-kevin: issues on bringup

2021-11-25 Thread Alper Nebi Yasak
On 25/11/2021 03:12, Simon Glass wrote: > On Sun, 7 Nov 2021 at 10:26, Alper Nebi Yasak > wrote: >> I did so and updated the branches, now the series goes like this: >> >> rockchip: gru: Set up SoC IO domain registers >> rockchip: gru: Add more devicetree setti

[PATCH 0/4] rockchip: Improve support for Bob chromebook and add support for Kevin

2021-11-25 Thread Alper Nebi Yasak
/2779784/ Alper Nebi Yasak (2): rockchip: gru: Set up SoC IO domain registers rockchip: bob: Enable more configs Marty E. Plummer (1): rockchip: rk3399: Add support for chromebook_kevin Simon Glass (1): rockchip: gru: Add more devicetree settings arch/arm/dts/Makefile

[PATCH 1/4] rockchip: gru: Set up SoC IO domain registers

2021-11-25 Thread Alper Nebi Yasak
The RK3399 SoC needs to know the voltage value provided by some regulators, which is done by setting relevant register bits. Configure these the way other RK3399 boards do, but with values set in coreboot. Signed-off-by: Alper Nebi Yasak --- There is a driver for this on Rockchip's re

[PATCH 2/4] rockchip: gru: Add more devicetree settings

2021-11-25 Thread Alper Nebi Yasak
d-off-by: Simon Glass [Alper: move to -u-boot.dtsi, rewrite commit message, add more nodes] Co-developed-by: Alper Nebi Yasak Signed-off-by: Alper Nebi Yasak --- Kept sign-off and author as Simon based on the aforementioned commit. arch/arm/dts/rk3399-gru-u-boot.dtsi | 55 ++

[PATCH 3/4] rockchip: bob: Enable more configs

2021-11-25 Thread Alper Nebi Yasak
ust be operable by U-Boot. Enable the relevant config option to allow this. Bob boards also use the Winbond W25Q64DW SPI flash chip, enable support for Winbond SPI flash chips in the board config so U-Boot can boot with this chip. Signed-off-by: Alper Nebi Yasak --- configs/chro

[PATCH 4/4] rockchip: rk3399: Add support for chromebook_kevin

2021-11-25 Thread Alper Nebi Yasak
eMMC and USB issues. Cc: Marty E. Plummer Cc: Simon Glass [Alper: commit message, resync config with Bob, update MAINTAINERS, add to Rockchip doc, add Kconfig help message, set regulator] Co-developed-by: Alper Nebi Yasak Signed-off-by: Alper Nebi Yasak --- Marty had signed-off an earl

Re: [PATCH 1/4] rockchip: gru: Set up SoC IO domain registers

2021-12-07 Thread Alper Nebi Yasak
On 03/12/2021 06:31, Simon Glass wrote: > On Thu, 25 Nov 2021 at 10:40, Alper Nebi Yasak > wrote: >> The RK3399 SoC needs to know the voltage value provided by some >> regulators, which is done by setting relevant register bits. Configure >> these the way other RK3399 bo

Re: [PATCH 0/4] rockchip: Improve support for Bob chromebook and add support for Kevin

2021-12-07 Thread Alper Nebi Yasak
On 03/12/2021 06:31, Simon Glass wrote: > On Thu, 25 Nov 2021 at 10:39, Alper Nebi Yasak > wrote: >> I have recently started testing booting U-Boot from SPI on my gru-kevin >> >> [...] >> >> Other useful things for these boards: >> - Patch to fix a hang

Re: [PATCH 4/4] rockchip: rk3399: Add support for chromebook_kevin

2021-12-07 Thread Alper Nebi Yasak
On 03/12/2021 06:31, Simon Glass wrote: > On Thu, 25 Nov 2021 at 10:40, Alper Nebi Yasak > wrote: >> Add support for Kevin, an RK3399-based convertible chromebook that is >> very similar to Bob. This patch is mostly based on existing support for >> Bob, with only minor ch

Re: [PATCH 0/4] rockchip: Improve support for Bob chromebook and add support for Kevin

2021-12-07 Thread Alper Nebi Yasak
On 03/12/2021 23:13, Simon Glass wrote: > On Fri, 3 Dec 2021 at 05:20, Peter Robinson wrote: >> On Fri, Dec 3, 2021 at 3:32 AM Simon Glass wrote: >>> On Wed, 1 Dec 2021 at 07:23, Peter Robinson wrote: >>>> On Thu, Nov 25, 2021 at 5:39 PM Alper Nebi Yasak >>&g

<    1   2   3   4   5   >