[PATCH v2 4/4] binman: Document how CROSS_COMPILE, CC, HOSTCC etc. are used in README

2020-09-06 Thread Alper Nebi Yasak
Explain that binman interprets these environment variables in the "External tools" section to run target/host specific versions of the tools, and add a new section on how to use CROSS_COMPILE to run the tests on non-x86 machines. Signed-off-by: Alper Nebi Yasak --- Changes in v2: -

Re: [PATCH v4 2/3] binman: Support help messages for missing blobs

2020-09-08 Thread Alper Nebi Yasak
On 06/09/2020 19:39, Simon Glass wrote: > When an external blob is missing it can be quite confusing for the user. > Add a way to provide a help message that is shown. > > Signed-off-by: Simon Glass > --- > > (no changes since v3) > > Changes in v3: > - Add a way to show help messages for missi

Re: [PATCH v4 1/3] binman: Allow selecting default FIT configuration

2020-09-08 Thread Alper Nebi Yasak
On 06/09/2020 19:39, Simon Glass wrote: > Add a new entry argument to the fit entry which allows selection of the > default configuration to use. This is the 'default' property in the > 'configurations' node. > > Update the Makefile to pass in the value of DEVICE_TREE or > CONFIG_DEFAULT_DEVICE_TR

Re: [PATCH v4 1/3] binman: Allow selecting default FIT configuration

2020-09-09 Thread Alper Nebi Yasak
On 09/09/2020 02:56, Simon Glass wrote: > On Tue, 8 Sep 2020 at 11:33, Alper Nebi Yasak > wrote: >> I might be too late to say this but the SEQ thing looks ugly to me. >> Maybe there could be some generic control-flow-like nodes that could >> generate and insert things i

Re: [PATCH v4 2/3] binman: Support help messages for missing blobs

2020-09-09 Thread Alper Nebi Yasak
On 09/09/2020 02:56, Simon Glass wrote: > On Tue, 8 Sep 2020 at 10:37, Alper Nebi Yasak > wrote: >> >> result = {} >> tag = None >> for line in my_data.decode('utf-8').splitlines(): >> m_tag = re_tag.match(line) >>

[PATCH] pwm: cros_ec: Rename "priv_auto_alloc_size" to "priv_auto"

2021-05-14 Thread Alper Nebi Yasak
as well. Fixes: 1b9ee2882e6b ("pwm: Add a driver for Chrome OS EC PWM") Signed-off-by: Alper Nebi Yasak --- drivers/pwm/cros_ec_pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/cros_ec_pwm.c b/drivers/pwm/cros_ec_pwm.c index 44f4105dfd54..4a39c319aa2

[PATCH 1/2] phy: meson-axg-mipi: Rename "priv_auto_alloc_size" to "priv_auto"

2021-05-14 Thread Alper Nebi Yasak
) Fixes: 7ef19503bacf ("phy: Add Amlogic AXG MIPI D-PHY driver") Signed-off-by: Alper Nebi Yasak --- drivers/phy/meson-axg-mipi-dphy.c| 2 +- drivers/phy/meson-axg-mipi-pcie-analog.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/meson-ax

[PATCH 2/2] phy: meson-axg-mipi: Access parent ofnode through dev_ofnode()

2021-05-14 Thread Alper Nebi Yasak
547551aa019 ("phy: Add Amlogic AXG MIPI PCIe Analog PHY driver") Signed-off-by: Alper Nebi Yasak --- drivers/phy/meson-axg-mipi-pcie-analog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/meson-axg-mipi-pcie-analog.c b/drivers/phy/meson-axg-mipi-pcie-a

Re: [PATCH] pwm: cros_ec: Rename "priv_auto_alloc_size" to "priv_auto"

2021-05-14 Thread Alper Nebi Yasak
On 14/05/2021 23:44, Simon Glass wrote: > Hi Alper, > > On Fri, 14 May 2021 at 07:49, Alper Nebi Yasak > wrote: >> >> With commit 41575d8e4c33 ("dm: treewide: Rename auto_alloc_size members >> to be shorter") "priv_auto_alloc_size" was rena

[PATCH] sandbox: cros-ec: Add tests for the cros-ec-pwm driver

2021-05-16 Thread Alper Nebi Yasak
ndbox pwm. Signed-off-by: Alper Nebi Yasak --- This depends on a small fix [1] for cros-ec-pwm which otherwise fails to build. [1] https://patchwork.ozlabs.org/project/uboot/patch/20210514134840.19380-1-alpernebiya...@gmail.com/ arch/sandbox/dts/test.dts | 6 +++ arch/sandbox/includ

Re: [PATCH] sandbox: cros-ec: Add tests for the cros-ec-pwm driver

2021-05-19 Thread Alper Nebi Yasak
On 16/05/2021 23:05, Heinrich Schuchardt wrote: > Am 16. Mai 2021 17:41:44 MESZ schrieb Alper Nebi Yasak > : >> This patch lets sandbox-cros-ec emulate a limited pwm device which has >> multiple channels but can only set a duty cycle for each, as the actual >> EC doesn&#x

[PATCH v2] sandbox: cros-ec: Add tests for the Chrome OS PWM driver

2021-05-19 Thread Alper Nebi Yasak
ode to the sandbox test device-tree unfortunately makes it the first PWM device, so this also touches some other tests to make sure they still use the sandbox PWM. Signed-off-by: Alper Nebi Yasak --- This depends on a small fix [1] for cros-ec-pwm which otherwise fails to build.

Re: [PATCH v2] sandbox: cros-ec: Add tests for the Chrome OS PWM driver

2021-05-19 Thread Alper Nebi Yasak
On 19/05/2021 18:34, Simon Glass wrote: > Hi Alpher, > > On Wed, 19 May 2021 at 09:30, Alper Nebi Yasak > wrote: >> >> This patch adds a limited pulse-width modulator to sandbox's Chrome OS >> Embedded Controller emulation. The emulated PWM device supports mu

[PATCH v3] sandbox: cros-ec: Add tests for the Chromium OS EC PWM driver

2021-05-19 Thread Alper Nebi Yasak
ce node to the sandbox test device-tree unfortunately makes it the first PWM device, so this also touches some other tests to make sure they still use the sandbox PWM. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- This depends on a small fix [1] for cros-ec-pwm which otherwise fail

[PATCH] test: Fix filesystem tests always being skipped

2021-05-20 Thread Alper Nebi Yasak
oned commit. If the guestmount executables are unavailable, the mounts fallback to using sudo and result in no failures. Fixes: 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system") Signed-off-by: Alper Nebi Yasak --- There is more discussion at Heinrich's revert-p

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Alper Nebi Yasak
On 17/05/2021 17:06, Andy Shevchenko wrote: > I would like to be helpful here and when I have time, I'll look at it > closer if nobody beats me up to it. Currently I checked the reason why > we skip them in my scenario: > short test summary info > ==

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Alper Nebi Yasak
On 17/05/2021 16:21, Heinrich Schuchardt wrote: > If you are asked for a sudo password, you have not install libguestfs. > > Please, install the missing package. This also might have ended up not in PATH like mkfs.* weren't in mine, does e.g. "guestmount --version" work from your shell?

[PATCH 0/4] Fix CIs skipping filesystem, EFI secure boot and EFI capsule tests

2021-06-04 Thread Alper Nebi Yasak
he current master branch with the following commands, so it's not due to this series: $ tools/buildman/buildman -O clang -o build-sandbox -w --boards="sandbox" $ test/py/test.py --bd sandbox -k test_authvar.py [5] https://dev.azure.com/u-boot/u-boot/_build/results?buildId=2333&

[PATCH 1/4] tools: docker: Install a readable kernel for libguestfs-tools

2021-06-04 Thread Alper Nebi Yasak
y used for virtualization, we can use the kernel package specialized for that. On Ubuntu systems kernel images are not readable by non-root users, so explicitly add read permissions with chmod as well. Signed-off-by: Alper Nebi Yasak --- tools/docker/Dockerfile | 4 1 file changed, 4 insertion

[PATCH 2/4] Azure: Add fuse device for sandbox test.py tests

2021-06-04 Thread Alper Nebi Yasak
board, add the fuse device only when testing on sandbox. Signed-off-by: Alper Nebi Yasak --- .azure-pipelines.yml | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index 35ab7f30b276..a4d796c41895 100644 --- a/.azure

[PATCH 3/4] Azure: Add loop devices and CAP_SYS_ADMIN for sandbox test.py tests

2021-06-04 Thread Alper Nebi Yasak
sh or directly using libguestfs Python bindings to create and populate the images, but switching the test setups to these is nontrivial and is left as future work. Signed-off-by: Alper Nebi Yasak --- .azure-pipelines.yml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff

[PATCH 4/4] Azure/GitLab: Install a readable kernel for libguestfs-tools

2021-06-04 Thread Alper Nebi Yasak
build the container, try to explicitly install it in the CI scripts so that it's not immediately necessary to rebuild the container for that change. Signed-off-by: Alper Nebi Yasak --- .azure-pipelines.yml | 5 + .gitlab-ci.yml | 5 + 2 files changed, 10 insertions(+) diff --

[PATCH 1/2] test/py: Use loop mounts if guestmount fails in filesystem tests

2021-06-04 Thread Alper Nebi Yasak
keep tests running. Also stop checking if guestmount is in PATH, as trying to run a missing guestmount can now follow the same failure codepath and fall back to loop mounts anyway. Signed-off-by: Alper Nebi Yasak --- test/py/tests/test_fs/conftest.py | 31 +++ 1

[PATCH 2/2] test/py: Wait for guestmount worker to exit after running guestunmount

2021-06-04 Thread Alper Nebi Yasak
mplement a utility function that can do this by polling the process repeatedly for a given duration, optionally killing the process if it won't terminate on its own. Apply the suggested solution with this utility function, which makes the failing tests succeed again. Signed-off-by: Alper Nebi Ya

Re: [PATCH] dtoc: Allow overriding cc with $CC

2021-06-07 Thread Alper Nebi Yasak
On 07/06/2021 18:48, Simon Glass wrote: > From: Patrick Georgi > > The Chromium OS build system isn't particularly happy about using cc > directly and fails the build when doing so. > > Update it to allow overriding this. > > Signed-off-by: Patrick Georgi > Signed-off-by: Simon Glass > --- >

[PATCH] tools: Fix default target compile tools in Python tools

2021-06-07 Thread Alper Nebi Yasak
fix to the custom defaults and return the intended executables. Fixes: 1e4687aa47ed ("binman: Use target-specific tools when cross-compiling") Signed-off-by: Alper Nebi Yasak --- tools/patman/tools.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/patman/tools.py b/

[PATCH v2 0/3] Fix CIs skipping filesystem, EFI secure boot and EFI capsule tests

2021-06-13 Thread Alper Nebi Yasak
onfiguration is accessible to me. Changes in v2: - Always pass in /dev/fuse to Azure's docker run invocation. - Drop patch to install kernel in CI scripts v1: https://patchwork.ozlabs.org/project/uboot/list/?series=247294 Alper Nebi Yasak (3): tools: docker: Install a readable kernel

[PATCH v2 2/3] Azure: Add fuse device for test.py tests

2021-06-13 Thread Alper Nebi Yasak
The EFI secure boot and capsule test setups need to prepare disk images for their tests using virt-make-fs, which requires access to the host fuse device. This is not exposed to the docker container by default and has to be added explicitly. Add it. Signed-off-by: Alper Nebi Yasak --- Changes

[PATCH v2 1/3] tools: docker: Install a readable kernel for libguestfs-tools

2021-06-13 Thread Alper Nebi Yasak
y used for virtualization, we can use the kernel package specialized for that. On Ubuntu systems kernel images are not readable by non-root users, so explicitly add read permissions with chmod as well. Signed-off-by: Alper Nebi Yasak Acked-by: Heinrich Schuchardt --- Changes in v2: - Add tag "Ack

[PATCH v2 3/3] Azure: Add loop devices and CAP_SYS_ADMIN for sandbox test.py tests

2021-06-13 Thread Alper Nebi Yasak
sh or directly using libguestfs Python bindings to create and populate the images, but switching the test setups to these is nontrivial and is left as future work. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Always pass in /dev/fuse to Azure's docker run invocation. - Remove &qu

Re: [PATCH v2 1/3] tools: docker: Install a readable kernel for libguestfs-tools

2021-06-21 Thread Alper Nebi Yasak
On 14/06/2021 20:29, Heinrich Schuchardt wrote: > On 6/13/21 4:07 PM, Alper Nebi Yasak wrote: >> >> supermin: failed to find a suitable kernel (host_cpu=x86_64). >> >> I looked for kernels in /boot and modules in /lib/modules. >> >> [...] >&

Re: SSL certificate for source.denx.de has expired

2021-06-21 Thread Alper Nebi Yasak
On 21/06/2021 20:42, Heinrich Schuchardt wrote: > Hello Harald, > > please, renew the certificate for source.denx.de. It just expired: > > Not After > 6/21/2021, 7:33:23 PM (Central European Summer Time) > > Shouldn't a Let's Encrypt script renew it automatically? For reference, I get a valid c

[PATCH v3 0/3] Fix CIs skipping filesystem, EFI secure boot and EFI capsule tests

2021-06-21 Thread Alper Nebi Yasak
patchwork.ozlabs.org/project/uboot/list/?series=247294 Alper Nebi Yasak (3): tools: docker: Install a readable kernel for libguestfs-tools Azure: Add fuse device for test.py tests Azure: Add loop devices and CAP_SYS_ADMIN for sandbox test.py tests .azure-pipelines.yml| 17 +++

[PATCH v3 1/3] tools: docker: Install a readable kernel for libguestfs-tools

2021-06-21 Thread Alper Nebi Yasak
y used for virtualization, we can use the kernel package specialized for that. On Ubuntu systems kernel images are not readable by non-root users, so explicitly add read permissions with chmod as well. Signed-off-by: Alper Nebi Yasak Acked-by: Heinrich Schuchardt --- Changes in v3: - Only set /boot/

[PATCH v3 2/3] Azure: Add fuse device for test.py tests

2021-06-21 Thread Alper Nebi Yasak
The EFI secure boot and capsule test setups need to prepare disk images for their tests using virt-make-fs, which requires access to the host fuse device. This is not exposed to the docker container by default and has to be added explicitly. Add it. Signed-off-by: Alper Nebi Yasak --- (no

[PATCH v3 3/3] Azure: Add loop devices and CAP_SYS_ADMIN for sandbox test.py tests

2021-06-21 Thread Alper Nebi Yasak
sh or directly using libguestfs Python bindings to create and populate the images, but switching the test setups to these is nontrivial and is left as future work. Signed-off-by: Alper Nebi Yasak --- (no changes since v2) Changes in v2: - Always pass in /dev/fuse to Azure's docker run

Re: [PATCH 1/2] test/py: Use loop mounts if guestmount fails in filesystem tests

2021-06-27 Thread Alper Nebi Yasak
On 26/06/2021 21:29, Simon Glass wrote: > On Fri, 4 Jun 2021 at 13:05, Alper Nebi Yasak > wrote: >> >> If guestmount isn't available on the system, filesystem test setup falls >> back to using loop mounts to prepare its disk images. If guestmount is >> availab

Re: [PATCH 2/2] test/py: Wait for guestmount worker to exit after running guestunmount

2021-06-27 Thread Alper Nebi Yasak
On 26/06/2021 21:29, Simon Glass wrote: > On Fri, 4 Jun 2021 at 13:05, Alper Nebi Yasak > wrote: >> >> Some filesystem tests are failing when their image is prepared with >> guestmount, but succeeding if loop mounts are used instead. The reason >> seems to be a r

Re: buildman error

2021-06-30 Thread Alper Nebi Yasak
On 30/06/2021 14:07, Wasim Khan wrote: > I am using latest u-boot code and trying to run buildman with my local patch > for lx2160 platform on master branch. > Getting below error . > > u-boot$ ./tools/buildman/buildman --list-tool-chains > aarch64 : > /opt/gcc-linaro-7.4.1-2019.02-x86_64_a

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-02 Thread Alper Nebi Yasak
On 02/07/2021 22:01, Tom Rini wrote: > Hey all, > > I started taking a look at moving to guestfish to see if this resolves > the latest problem I've run in to: > https://source.denx.de/u-boot/u-boot/-/jobs/284763#L307 > which I think is due to guestmount not being done in time for the test. That

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-02 Thread Alper Nebi Yasak
On 02/07/2021 23:03, Alper Nebi Yasak wrote: > On 02/07/2021 22:01, Tom Rini wrote: >> Hey all, >> >> I started taking a look at moving to guestfish to see if this resolves >> the latest problem I've run in to: >> https://source.denx.de/u-boot/u-boot/-/jobs/

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-03 Thread Alper Nebi Yasak
On 02/07/2021 23:24, Tom Rini wrote: > On Fri, Jul 02, 2021 at 11:03:52PM +0300, Alper Nebi Yasak wrote: >> On 02/07/2021 22:01, Tom Rini wrote: >>> Hey all, >>> >>> I started taking a look at moving to guestfish to see if this resolves >>>

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-05 Thread Alper Nebi Yasak
On 05/07/2021 00:14, Tom Rini wrote: > On Sat, Jul 03, 2021 at 05:38:07PM -0400, Tom Rini wrote: >> On Sat, Jul 03, 2021 at 05:27:44PM +0300, Alper Nebi Yasak wrote: >>> >>> >>> On 02/07/2021 23:24, Tom Rini wrote: >>>> On Fri, Jul 02, 2021 at 11:03

Re: rk3399-gru-kevin: issues on bringup

2020-08-13 Thread Alper Nebi Yasak
Hi Simon, Marty, I'm interested in getting U-Boot to work with Kevin as well, but don't have a Servo (or the willingness to open up the case yet), so I've been trying to boot from depthcharge as in README.chromium-chainload. I don't have a way to see serial output and I see no other signs of

[PATCH 1/2] video: backlight: Support PWMs without a known period_ns

2020-09-23 Thread Alper Nebi Yasak
The PWM device provided by Chrome OS EC doesn't really support anything other than setting a relative duty cycle. To support it as a backlight, this patch makes the PWM period optional in the device tree and pretends the valid brightness range is its period_ns. Signed-off-by: Alper Nebi

[PATCH 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-23 Thread Alper Nebi Yasak
for when we want to re-enable it. The cros_ec_set_pwm_duty() function is taken from Depthcharge's cros_ec_set_bl_pwm_duty() but modified to use the generic pwm type. The driver itself is very loosely based on rk_pwm.c for the general pwm driver structure. Signed-off-by: Alper Nebi Yasak --

Re: [PATCH 1/2] video: backlight: Support PWMs without a known period_ns

2020-09-25 Thread Alper Nebi Yasak
On 24/09/2020 19:08, Simon Glass wrote: > Hi Alper, > > On Wed, 23 Sep 2020 at 10:52, Alper Nebi Yasak > wrote: >> >> The PWM device provided by Chrome OS EC doesn't really support anything >> other than setting a relative duty cycle. To support it as a bac

Re: [PATCH 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-25 Thread Alper Nebi Yasak
On 24/09/2020 19:08, Simon Glass wrote: > Hi Alper, > > On Wed, 23 Sep 2020 at 10:52, Alper Nebi Yasak > wrote: >> >> This PWM is used in rk3399-gru-bob and rk3399-gru-kevin to control >> the display brightness. We can only change the duty cycle, so on >> s

[PATCH v2 1/2] video: backlight: Support PWMs without a known period_ns

2020-09-26 Thread Alper Nebi Yasak
a PWM channel that has a fixed period, checking that the resulting duty_cycle matches on a set_config() even if the requested period_ns can't be set. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Add sandbox test to pwm.c (using sandbox_pwm's channel 2) - Add comments to pwm_s

[PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-26 Thread Alper Nebi Yasak
Linux, before it was converted to YAML at 5df5a577a6b4 ("dt-bindings: pwm: Convert google,cros-ec-pwm.txt to YAML format") in their repo. Signed-off-by: Alper Nebi Yasak --- I'm testing on a rk3399-gru-kevin with a lot of other patches to get it (and it's screen) barely working,

Re: [PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-27 Thread Alper Nebi Yasak
On 27/09/2020 12:29, Arnaud Patard (Rtp) wrote: > Peter Robinson writes: >> A quick look at the Linux DT for the GRU Chromebooks and it looks like >> the panels are also attached via EDP like on the Pinebook Pro so this >> patch series adding initial support for the rk3399 EDP might be of use >> h

Re: [patch 0/8] RFC: Pinebook pro EDP support

2020-09-27 Thread Alper Nebi Yasak
On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote: > This patchset add support for the rk3399 edp. It has been tested on the > pinebook > pro devices. The only missing part is a hack used to get stable edp output > after > a warn reset, which is possibly specific to this device. I'm not sure if it's

Re: [patch 0/8] RFC: Pinebook pro EDP support

2020-09-28 Thread Alper Nebi Yasak
On 28/09/2020 09:41, Arnaud Patard (Rtp) wrote: > Here, it's set to 1920x1080, and I have CONFIG_DISPLAY_ROCKCHIP_HDMI > disabled, since there's no HDMI output on the PBP. Can you try with the > screen size set to the one of your panel and disable the HDMI output ? > I suspect it won't change anyth

[PATCH 1/2] treewide: Fix wrong CONFIG_IS_ENABLED() handling

2020-09-30 Thread Alper Nebi Yasak
ot;CONFIG_IS_ENABLED(CONFIG"` by running ':%s/CONFIG_IS_ENABLED(CONFIG_\(\w+\))/CONFIG_IS_ENABLED(\1)/g' in vim. Signed-off-by: Alper Nebi Yasak --- drivers/clk/rockchip/clk_rk3399.c | 2 +- drivers/spi/nxp_fspi.c | 10 +- drivers/sysreset/sysreset_mpc83xx.c | 8 --

[PATCH 2/2] checkpatch.pl: Make CONFIG_IS_ENABLED(CONFIG_*) an error

2020-09-30 Thread Alper Nebi Yasak
CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix, e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Make including the prefix an error in checkpatch.pl so calls in the wrong format aren't accidentally reintroduced. Signed-off-by: Alper Nebi Yasak --- scripts/checkpatch.p

[PATCH v2 1/2] treewide: Fix wrong CONFIG_IS_ENABLED() handling

2020-10-04 Thread Alper Nebi Yasak
ot;CONFIG_IS_ENABLED(CONFIG"` by running ':%s/CONFIG_IS_ENABLED(CONFIG_\(\w+\))/CONFIG_IS_ENABLED(\1)/g' in vim. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- Changes in v2: - Add tag: "Reviewed-by: Simon Glass " v1: https://patchwork.ozlabs.org/project/uboot/patch/2

[PATCH v2 2/2] checkpatch.pl: Make CONFIG_IS_ENABLED(CONFIG_*) an error

2020-10-04 Thread Alper Nebi Yasak
CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix, e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Make including the prefix an error in checkpatch.pl so calls in the wrong format aren't accidentally reintroduced. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Add p

[PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-06 Thread Alper Nebi Yasak
goes away when I disable higher log levels, and it claims to have successfully probed the device. Signed-off-by: Alper Nebi Yasak --- I'm testing this with a lot of other patches to make the board work. The actual tree I'm using is available here: https://github.com/alpernebbi/

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-13 Thread Alper Nebi Yasak
On 12/10/2020 06:34, Simon Glass wrote: > On Tue, 6 Oct 2020 at 14:40, Alper Nebi Yasak > wrote: >> >> Found this by comparing it to the coreboot driver, a form of this call >> was introduced there in their commit b9a7877568cf ("rockchip/*: refactor >> edp d

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Alper Nebi Yasak
On 14/10/2020 18:24, Tom Rini wrote: > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: >> I think it is OK to change the file to GPL2. I'm not sure if changing >> coreboot parts to 2.0+ is an option. I believe the use of 2+ in U-Boot >> is for fairly narrow reasons, but I'm not sure if

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Alper Nebi Yasak
On 14/10/2020 22:31, Tom Rini wrote: > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: >> On 14/10/2020 18:24, Tom Rini wrote: >>> Ugh. In so far as anything can be re-licensed, who did it all >>> originally? I suspect coreboot isn't interest

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-15 Thread Alper Nebi Yasak
On 15/10/2020 10:19, Arnaud Patard (Rtp) wrote: > Alper Nebi Yasak writes: >> I'm not sure re-porting is a great idea from the technical perspective. >> I've been reading both drivers to compare them, there are also things in >> U-Boot that're missing from core

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-14 Thread Alper Nebi Yasak
On 13/06/2022 05:31, Peng Fan (OSS) wrote: >> 在 2022/6/11 0:47, Alper Nebi Yasak 写道: >>> Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables >>> you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares >>> certain symbols

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-14 Thread Alper Nebi Yasak
On 13/06/2022 05:34, Peng Fan (OSS) wrote: > 在 2022/6/11 20:44, Alper Nebi Yasak 写道: >> CONFIG_IS_ENABLED(BINMAN) doesn't work, but IS_ENABLED(CONFIG_BINMAN) >> worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you >> a git branch if you want? > &

Re: [PATCH] tools: binman: install btool

2022-06-14 Thread Alper Nebi Yasak
On 14/06/2022 13:42, Peng Fan (OSS) wrote: > From: Peng Fan > > btool is needed after install binman to system. > > Signed-off-by: Peng Fan > --- Reviewed-by: Alper Nebi Yasak > Tom, Simon, Alper > This is a bug fix, if possible, please pick it up. > > too

[PATCH v2 0/8] spl: binman: Fixes for BINMAN_SYMBOLS

2022-06-18 Thread Alper Nebi Yasak
_SYMBOLS - Add new patch to check binman symbols at runtime - Add new patch to disable u_boot_any symbols for i.MX8M boards - Pick Peng's __image_copy_start fix Alper Nebi Yasak (7): spl: binman: Fix use of undeclared u_boot_any symbols spl: binman: Make TPL_BINMAN_SYMBOLS depend o

[PATCH v2 1/8] spl: binman: Fix use of undeclared u_boot_any symbols

2022-06-18 Thread Alper Nebi Yasak
returning early in those cases. Signed-off-by: Alper Nebi Yasak --- (no changes since v1) common/spl/spl.c | 10 +++--- common/spl/spl_ram.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 2a69a7c9324d..5630dcdb5c1e 100644 --- a

[PATCH v2 2/8] spl: binman: Make TPL_BINMAN_SYMBOLS depend on TPL_FRAMEWORK

2022-06-18 Thread Alper Nebi Yasak
igned-off-by: Alper Nebi Yasak --- (no changes since v1) common/spl/Kconfig.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl index 9a0e719cf949..834cb6b6dd82 100644 --- a/common/spl/Kconfig.tpl +++ b/common/spl/Kconfig.tpl @@

[PATCH v2 3/8] spl: binman: Declare extern symbols for VPL as well

2022-06-18 Thread Alper Nebi Yasak
The binman extern symbol declarations in spl.h are missing the VPL symbols recently added to spl.c, add them like the others. Signed-off-by: Alper Nebi Yasak --- (no changes since v1) include/spl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/spl.h b/include/spl.h index

[PATCH v2 4/8] spl: binman: Split binman symbols support from enabling binman

2022-06-18 Thread Alper Nebi Yasak
es to work with CONFIG_IS_ENABLED(BINMAN_SYMBOLS). Co-developed-by: Peng Fan [Alper: New config for phase symbols, update Kconfigs, commit message] Signed-off-by: Alper Nebi Yasak --- See Peng's patch [1] included in these changes. [1] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMB

[PATCH v2 5/8] spl: binman: Add config options for binman symbols in VPL

2022-06-18 Thread Alper Nebi Yasak
The SPL code declares binman symbols for U-Boot phases depending on CONFIG_IS_ENABLED(BINMAN_UBOOT_SYMBOLS). This config exists for SPL and TPL, also add a version for VPL. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Update VPL configs for the new BINMAN_UBOOT_SYMBOLS common/spl

[PATCH v2 6/8] spl: binman: Check at runtime if binman symbols were filled in

2022-06-18 Thread Alper Nebi Yasak
layouts. Fix the affected values, and check the magic symbol wherever it makes sense. Signed-off-by: Alper Nebi Yasak --- (no changes since v1) common/spl/spl.c| 1 + include/binman_sym.h| 45 - tools/binman/elf.py

[PATCH v2 7/8] spl: binman: Disable u_boot_any symbols for i.MX8M boards

2022-06-18 Thread Alper Nebi Yasak
uild error described above. Explicitly disable the 'u_boot_any' symbols for i.MX8M boards. They are already effectively unusable, and they are incompatible with the boards' current binman image descriptions. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Add new patch to disab

[PATCH v2 8/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol

2022-06-18 Thread Alper Nebi Yasak
file Signed-off-by: Peng Fan Reviewed-by: Tom Rini Reviewed-by: Alper Nebi Yasak --- This is from Peng's i.MX8M binman symbols series [1], picked it onto this series because it made more sense as a binman symbols fix. [1] armv8: u-boot-spl.lds: mark __image_copy_start as sy

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-18 Thread Alper Nebi Yasak
On 15/06/2022 02:25, Peng Fan wrote: >> Subject: Re: [PATCH 7/8] binman_sym: guard with >> CONFIG_IS_ENABLED(BINMAN_SYMBOLS) >> >> On 13/06/2022 05:34, Peng Fan (OSS) wrote: >>> 在 2022/6/11 20:44, Alper Nebi Yasak 写道: >>>> CONFIG_IS_ENABLED(BINMAN)

Re: Extend binman to generate boot headers

2022-06-20 Thread Alper Nebi Yasak
On 16/06/2022 11:45, Peng Fan wrote: > Hi all, > > I am thinking to extend binman to generate i.MX container > header and IVT header, that means to replace mkimage to generate header. > > There is an NXP downstream imx-mkimage that diverge from upstream that > double effort. There are still requi

Re: [PATCH V2] imx: imx93_11x11_evk: using binman to pack images

2022-06-21 Thread Alper Nebi Yasak
On 13/06/2022 09:13, Peng Fan (OSS) wrote: > From: Peng Fan > > Use BINMAN to generate flash.bin > > Signed-off-by: Peng Fan > --- > > Based on > https://patchwork.ozlabs.org/project/uboot/cover/20220611132035.32698-1-peng@oss.nxp.com/ > > V2: > Typo correct > > arch/arm/dts/imx93-11

Re: [PATCH v2 1/2] ARM: imx: imx8mn-evk: generate a single bootable flash.bin

2022-06-22 Thread Alper Nebi Yasak
On 09/06/2022 23:49, Heiko Thiery wrote: > To have a flash.bin file that also contains the U-Boot and TF-A/ATF > create this like already done for other imx8 boards. > > Signed-off-by: Heiko Thiery > Reviewed-by: Fabio Estevam > Reviewed-by: Peng Fan > --- > v2: sync with current master and fix

Re: [PATCH v2 2/2] ARM: imx: imx8mn-evk: use one common u-boot.dtsi for the evk boards

2022-06-22 Thread Alper Nebi Yasak
On 09/06/2022 23:49, Heiko Thiery wrote: > To have only one place to describe the binman images us the > imx8mn-u-boot.dtsi. To have support for different DDR firmwares this > nodes are included dependent on the used DDR config option. > > Signed-off-by: Heiko Thiery > Reviewed-by: Fabio Estevam

Re: [PATCH v2 2/2] ARM: imx: imx8mn-evk: use one common u-boot.dtsi for the evk boards

2022-06-22 Thread Alper Nebi Yasak
On 10/06/2022 00:38, Heiko Thiery wrote: > Hi Tim, Hi Simon, > > [SNIP] > >> >> Heiko, >> >> You can add multi-dtb support to this so that it's usable by the other >> imx8mn boards with the following: >> >> [...] >> >> I don't mind sending this as a follow-up to your patch here. > > Since this

Re: [PATCH v2 0/8] spl: binman: Fixes for BINMAN_SYMBOLS

2022-06-24 Thread Alper Nebi Yasak
On 23/06/2022 06:00, Peng Fan (OSS) wrote: > Hi Alper, > > 在 2022/6/18 20:13, Alper Nebi Yasak 写道: >> There's some trouble with an i.MX8M series [1] trying to use binman >> symbols. The crux of it is the 'u_boot_any' symbols BINMAN_SYMBOLS >> config

Re: [PATCH V7 2/4] ddr: imx8m: helper: load ddr firmware according to binman symbols

2022-06-28 Thread Alper Nebi Yasak
y KBs. > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > Signed-off-by: Peng Fan > Reviewed-by: Alper Nebi Yasak > [Alper: Check BINMAN_SYMS_OK instead] > Signed-off-by: Alper Nebi Yasak > --- > drivers/ddr/imx/phy/helper.c | 47 +++--

Re: [PATCH RFC v3 00/11] Integration of tiboot3.bin, sysfw.itb and

2022-07-01 Thread Alper Nebi Yasak
On 15/06/2022 09:47, Neha Malcom Francis wrote: > [...] > > Neha Malcom Francis (11): > j721e_evm: schema: yaml: Add general schema and J721E board config > files > ti: tools: config: Add board config class to generate config binaries > ti: etype: sysfw: Add entry type for sysfw > ti:

Re: [PATCH RFC v3 02/11] ti: tools: config: Add board config class to generate config binaries

2022-07-01 Thread Alper Nebi Yasak
On 15/06/2022 09:47, Neha Malcom Francis wrote: > For validating config files and generating binary config artifacts, here > board specific config class is added. > > Add function cfgBinaryGen() in tibcfg_gen.py. It uses TIBoardConfig > class to load given schema and config files in YAML, validate

Re: [PATCH RFC v3 03/11] ti: etype: sysfw: Add entry type for sysfw

2022-07-01 Thread Alper Nebi Yasak
gt; tools/binman/test/232_ti_sysfw.dts | 13 + > 5 files changed, 60 insertions(+) > create mode 100644 tools/binman/etype/ti_sysfw.py > create mode 100644 tools/binman/test/232_ti_sysfw.dts Reviewed-by: Alper Nebi Yasak Minor points below. > diff --git a/Makefile b/Mak

Re: [PATCH RFC v3 04/11] ti: etype: dm: Add entry type for TI DM

2022-07-01 Thread Alper Nebi Yasak
644 tools/binman/etype/ti_dm.py > create mode 100644 tools/binman/test/225_ti_dm.dts Reviewed-by: Alper Nebi Yasak Same minor issues as the previous patch. > diff --git a/Makefile b/Makefile > index d20d264c53..9b29e8e6a2 100644 > --- a/Makefile > +++ b/Makefile > @@

Re: [PATCH RFC v3 05/11] ti: etype: x509: Add etype for x509 certificate for K3 devices

2022-07-01 Thread Alper Nebi Yasak
On 15/06/2022 09:47, Neha Malcom Francis wrote: > K3 devices requires x509 certificate to be added as header of bootloader > binaries that allows ROM to validate the integrity of the image. Etype > that generates a TI x509 certificate is added. > > Currently this etype is scaled for J721E. For J72

Re: [PATCH RFC v3 09/11] ti: dtsi: j721e: Use binman to package sysfw.itb and tiboot3.bin

2022-07-01 Thread Alper Nebi Yasak
On 15/06/2022 09:48, Neha Malcom Francis wrote: > By providing entries in the binman node of the device tree, binman will > be able to find and package board config binary artifacts generated by > TIBoardConfig with sysfw.bin and generate the final image sysfw.itb. > > k3-j721e-r5-binman.dtsi has

Re: [PATCH RFC v3 10/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-07-01 Thread Alper Nebi Yasak
On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin must be packaged (with ATF, OPTEE, DM and A72 SPL) for J721E. > Binman picks up and packages entries according to the > description given in the device tree. > > k3-j721e-a72-binman.dtsi has been introduced for A72 specific binman > node.

Re: [PATCH RFC v3 11/11] ci: world_build: test: Add requirements.txt

2022-07-01 Thread Alper Nebi Yasak
; >> build.sh >if [[ "${BUILDMAN}" != "" ]]; then > + pip install -r test/py/requirements.txt >ret=0; >tools/buildman/buildman -o /tmp -P -E -W ${BUILDMAN} > ${OVERRIDE} || ret=$?; >if [[ $ret -ne 0 ]]; then Reviewed-by: Alper Nebi Yasak

Re: Binman entry 'u-boot-any' not found in list

2022-10-31 Thread Alper Nebi Yasak
On 31/10/2022 15:56, Roger Quadros wrote:> On 31/10/2022 05:40, Neha Malcom Francis wrote: >> On 30/10/22 07:13, Simon Glass wrote: >>> On Fri, 28 Oct 2022 at 04:58, Fabio Estevam wrote: [Adding Alper - binmam maintainer and Oliver, who faced the same issue on imx8] (Sorry I've been un

Re: binman and faked blobs failures

2022-04-16 Thread Alper Nebi Yasak
On 12/04/2022 00:28, Tom Rini wrote: > [...] > > Note that nothing changed for the board but on the second build now the > faked blob is unhappy and causes a failure message that I don't see the > first time, and probably shouldn't see this time either? This is a > problem for me in that it's on

Re: [RESEND, RFC 1/8] tools: config: yaml: Add board config class to generate config binaries

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > For validating config files and generating binary config artifacts, here > board specific config class is added. > > Add function cfgBinaryGen() in tibcfg_gen.py. It uses TIBoardConfig > class to load given schema and config files in YAML, validate

Re: [RESEND, RFC 2/8] binman: etype: sysfw: Add entry type for sysfw

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > For K3 devices that require a sysfw image, add entry for SYSFW. It can > contain system firmware image that can be packaged into sysfw.itb by > binman. The method ReadBlobContents in sysfw.py runs the TI K3 > certificate generation script to create

Re: [RESEND, RFC 5/8] binman: sysfw: Add support for packaging tiboot3.bin and sysfw.itb

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > For devices that require sysfw.itb, board config binary artifacts must > be populated in the R5 output directory. These can be used by binman to > package sysfw.itb. > > config.mk for mach-k3 updated to generate the required binaries using > tibcfg

Re: [RESEND, RFC 6/8] binman: dtsi: sysfw: j721e: Use binman to package sysfw.itb

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > By providing entries in the binman node of the device tree, binman will > be able to find and package board config binary artifacts generated by > TIBoardConfig with sysfw.bin and generate the final image sysfw.itb. > > j721e-r5-binman.dtsi has bee

Re: [RESEND, RFC 7/8] binman: etype: dm: Add entry type for TI DM

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > K3 devices introduces the concept of centralized power, resource and > security management to System Firmware. This is to overcome challenges > by the traditional approach that implements system control functions on > each of the processing units. >

Re: [RESEND, RFC 8/8] binman: dtsi: tispl: j721e: Use binman to package tispl.bin

2022-04-18 Thread Alper Nebi Yasak
On 06/04/2022 15:29, Neha Malcom Francis wrote: > Explicit make commands were earlier used to generate tispl.bin image, > now it is replaced using binman. > > Binman picks up and packages entries according to the description of > entries given in the binman node in the device tree. The make comman

[PATCH] MAINTAINERS: Add Alper as a binman maintainer

2022-04-22 Thread Alper Nebi Yasak
I ended up learning most of binman internals while trying to add a few features to it, and I recently started reviewing binman series that would not affect me personally. I'll keep working on it and try to do more reviews. Add myself as a maintainer for binman. Signed-off-by: Alper Nebi

Re: [PATCH 7/7] binman: Refuse to replace sections for now

2022-04-23 Thread Alper Nebi Yasak
On 20/04/2022 00:54, Simon Glass wrote: > On Sun, 27 Mar 2022 at 09:32, Alper Nebi Yasak > wrote: >> >> Binman interfaces allow attempts to replace any entry in the image with >> arbitrary data. When trying to replace sections, the changes in the >> section entry&#x

<    1   2   3   4   5   >