On 14/05/2021 23:44, Simon Glass wrote:
> Hi Alper,
>
> On Fri, 14 May 2021 at 07:49, Alper Nebi Yasak <alpernebiya...@gmail.com>
> wrote:
>>
>> With commit 41575d8e4c33 ("dm: treewide: Rename auto_alloc_size members
>> to be shorter") "priv_auto_alloc_size" was renamed to "priv_auto". This
>> driver was sent to the mailing list before that change, merged after it,
>> and still has the old form. Apply the rename here as well.
>>
>> Fixes: 1b9ee2882e6b ("pwm: Add a driver for Chrome OS EC PWM")
>> Signed-off-by: Alper Nebi Yasak <alpernebiya...@gmail.com>
>> ---
>>
>> drivers/pwm/cros_ec_pwm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <s...@chromium.org>
>
> Can you enable this driver so it is not dead code, and add a sandbox test?
I'll try adding a sandbox test as a new patchset.
>>
>> diff --git a/drivers/pwm/cros_ec_pwm.c b/drivers/pwm/cros_ec_pwm.c
>> index 44f4105dfd54..4a39c319aa2a 100644
>> --- a/drivers/pwm/cros_ec_pwm.c
>> +++ b/drivers/pwm/cros_ec_pwm.c
>> @@ -80,5 +80,5 @@ U_BOOT_DRIVER(cros_ec_pwm) = {
>> .id = UCLASS_PWM,
>> .of_match = cros_ec_pwm_ids,
>> .ops = &cros_ec_pwm_ops,
>> - .priv_auto_alloc_size = sizeof(struct cros_ec_pwm_priv),
>> + .priv_auto = sizeof(struct cros_ec_pwm_priv),
>> };
>> --
>> 2.31.1
>>
>
> Regards,
> Simon
>
