[PATCH v2 1/1] acpi: Add missing RISC-V acpi_table header

2023-07-25 Thread Heinrich Schuchardt
The pci_mmc.c driver can generate ACPI info and therefore includes asm/acpi_table.h. This file does not exist for the RISC-V architecture and thus code compilation fails when using this driver on RISC-V Create an empty include file. Signed-off-by: Heinrich Schuchardt --- v2: Add include

Re: [bug report] fs: fat: create correct short names

2023-07-26 Thread Heinrich Schuchardt
On 26.07.23 09:02, Dan Carpenter wrote: Hello Heinrich Schuchardt, The patch 28cef9ca2e86: "fs: fat: create correct short names" from Nov 20, 2020, leads to the following Smatch static checker warning: fs/fat/fat_write.c:61 str2fat() warn: impossible condition '(c &

[PATCH 1/1] fat: correct sign for deletion mark

2023-07-26 Thread Heinrich Schuchardt
2387a ("fs: fat: call set_name() only once") Fixes: 28cef9ca2e86 ("fs: fat: create correct short names") Signed-off-by: Heinrich Schuchardt --- fs/fat/fat_write.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.

Re: [PATCH 1/1] efi_loader: simplify dp_fill()

2023-07-26 Thread Heinrich Schuchardt
On 23.07.23 05:48, Simon Glass wrote: Hi Heinrich, On Fri, 21 Jul 2023 at 00:34, Heinrich Schuchardt wrote: Move the recursive dp_fill(dev->parent) call to a single location. Determine uclass_id only once. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c |

[PATCH 1/1] virtio: provide driver name in debug message

2023-07-26 Thread Heinrich Schuchardt
If a driver cannot be bound, provide the driver name in the debug message. Now the debug message may look like this: (virtio-pci.l#0): virtio-rng driver not configured Signed-off-by: Heinrich Schuchardt --- drivers/virtio/virtio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 2/6] arm_ffa: introduce armffa command

2023-07-26 Thread Heinrich Schuchardt
On 3/29/22 17:16, abdellatif.elkhl...@arm.com wrote: From: Abdellatif El Khlifi Provide armffa command showcasing the use of the FF-A driver The armffa command allows to query secure partitions data from the secure world and exchanging messages with the partitions. Signed-off-by: Abdellatif E

Re: [PATCH v4 1/9] spl: Add generic spl_load function

2023-07-26 Thread Heinrich Schuchardt
On 7/24/23 19:12, Sean Anderson wrote: Implementers of SPL_LOAD_IMAGE_METHOD have to correctly determine what type of image is being loaded and then call the appropriate image load function correctly. This is tricky, because some image load functions expect the whole image to already be loaded (C

Re: [PATCH] efi_loader: fix an IS_ERR() vs NULL check

2023-07-27 Thread Heinrich Schuchardt
On 7/27/23 09:16, Dan Carpenter wrote: The efi_parse_pkcs7_header() function returns NULL on error so the check for IS_ERR() should be changed to a NULL check. Signed-off-by: Dan Carpenter --- lib/efi_loader/efi_capsule.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

Re: [PATCH] efi_loader: fix uninitialized variable bug in efi_set_load_options()

2023-07-27 Thread Heinrich Schuchardt
On 7/27/23 09:15, Dan Carpenter wrote: Check for efi_search_protocol() failure before dereferencing "handler" to avoid a crash. Signed-off-by: Dan Carpenter Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_load_options.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] test: unicode: fix a sizeof() vs ARRAY_SIZE() bug

2023-07-27 Thread Heinrich Schuchardt
On 7/27/23 09:12, Dan Carpenter wrote: The u16_strlcat() is in units of u16 not bytes. So the limit needs to be ARRAY_SIZE() instead of sizeof(). Reviewed-by: Heinrich Schuchardt Signed-off-by: Dan Carpenter --- test/unicode_ut.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: bugs with EFI "reserved" memory and LMB?

2023-07-27 Thread Heinrich Schuchardt
On 27.07.23 13:08, Emanuele Ghidoli wrote: Efi loader module have its own memory management that flags as reserved the area between ram_top to ram_end (currently where dt reserved-memory is falling). uboot lmb updates reserved-memory by adding these efi loader module areas (see lmb_reserve_commo

Re: [PATCH v4.1 10/9] spl: Convert NVMe to spl_load

2023-07-27 Thread Heinrich Schuchardt
On 24.07.23 20:09, Sean Anderson wrote: This converts the blk load method (used exclusively by NVMe) to use spl_load. As a consequence, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- As suggested by Heinrich. common/spl/spl_blk_fs.c | 62 ++---

[PATCH 1/1] pci: correct function name in message

2023-07-27 Thread Heinrich Schuchardt
If an error message contains a function name, it should match the name of the function throwing the message. Fixes: 7739d93d8288 ("pci: Match region flags using a mask") Signed-off-by: Heinrich Schuchardt --- drivers/pci/pci-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] efi_loader: Fix memory corruption on 32bit systems

2023-07-27 Thread Heinrich Schuchardt
Am 28. Juli 2023 03:51:55 MESZ schrieb Simon Glass : >Hi, > >On Thu, 27 Jul 2023 at 08:36, Dan Carpenter wrote: >> >> On Thu, Jul 27, 2023 at 11:22:15AM +0300, Ilias Apalodimas wrote: >> > Hi Dan, >> > >> > [...] >> > >> > > @@ -313,7 +313,7 @@ static int cmp_pe_section(const void *arg1, const

[PATCH v2 1/1] doc: update doc/sphinx/requirements.txt

2023-07-27 Thread Heinrich Schuchardt
Update the following requirements to their latest version: * Pygments - syntax highlighting * pytz - world timezone definitions * certifi - Mozilla's CA bundle Signed-off-by: Heinrich Schuchardt --- v2: fix typo in title --- doc/sphinx/requirements.txt | 6 +++--- 1 file ch

Re: [PATCH] docs: boards: ti: add openocd spl debugging docs

2023-07-27 Thread Heinrich Schuchardt
On 7/21/23 21:19, Jason Kacines wrote: Add documentation on how to use OpenOCD to debug U-Boot for TI K3 Generation boards. Signed-off-by: Jason Kacines Thank you for providing OpenOCD usage guidance. This patch cannot be applied to origin/master. Please, rebase it. Please, remove trailing

Re: [PATCH v2] efi_loader: make efi_delete_handle() follow the EFI spec

2023-07-28 Thread Heinrich Schuchardt
;handle)) return 0; @@ -727,10 +728,13 @@ int efi_disk_remove(void *ctx, struct event *event) return 0; } + ret = efi_delete_handle(handle); + if (ret != EFI_SUCCESS) + return -1; I guess we should add a comment here ex

Re: [PATCH 02/16] doc: board: ti: am62x/j7200: Update with common boot flow diagram

2023-07-28 Thread Heinrich Schuchardt
On 7/27/23 11:40, Neha Malcom Francis wrote: These look nice! On 27/07/23 13:30, Nishanth Menon wrote: Update the bootflow svg diagram and reuse across the platforms as they are common. We should add SPDX license information to all the SVG files that you created. e.g. like the license i

Re: [PATCH 1/1] efi_loader: device paths for special block devices

2023-07-28 Thread Heinrich Schuchardt
On 28.07.23 11:14, Ilias Apalodimas wrote: Hi Heinrich, On Fri, Jul 21, 2023 at 12:03:46AM +0200, Heinrich Schuchardt wrote: The UEFI specification does not provide node types matching UCLASS_BLKMAP, UCLASS_HOST, UCLASS_VIRTIO block devices. The current implementation uses VenHw() nodes with

[PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

2023-07-28 Thread Heinrich Schuchardt
ff-by: Heinrich Schuchardt --- board/emulation/qemu-riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig index 6114e1b812..21d6160f01 100644 --- a/board/emulation/qemu-riscv/Kconfig +++ b/board/emulation/qemu-riscv/Kc

[PATCH 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt --- doc/develop/spl.rst | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/develop/spl.rst b

[PATCH v2 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin Meng --- v2: add missing comma --- doc/develop/spl.rst | 13 ++--- 1 file changed, 10 insertions

Pull request for efi-2023-10-rc2

2023-07-28 Thread Heinrich Schuchardt
* Fix device paths for special block devices Dan Carpenter (1): efi_loader: fix uninitialized variable bug in efi_set_load_options() Heinrich Schuchardt (5): doc: update doc/sphinx/requirements.txt efi_loader

Re: [PATCH v2 1/1] doc: U-Boot boot phases

2023-07-28 Thread Heinrich Schuchardt
On 7/28/23 19:32, Simon Glass wrote: Hi Heinrich, On Fri, 28 Jul 2023 at 09:58, Heinrich Schuchardt wrote: Add more detail to the description of U-Boot boot phases: * describe which steps are optional * mentions alternative boot flows Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin

[PATCH 1/1] doc: move README.falcon to HTML

2023-07-28 Thread Heinrich Schuchardt
Move the Falcon mode documentation to HTML. Signed-off-by: Heinrich Schuchardt --- doc/README.falcon | 232 doc/develop/falcon.rst | 258 + doc/develop/index.rst | 1 + 3 files changed, 259 insertions(+), 232

Re: [PATCH] doc: board: ti: Add SPDX License to svg images

2023-07-28 Thread Heinrich Schuchardt
On 7/28/23 22:05, Nishanth Menon wrote: Add Licensing to svg images to clarify the terms. Signed-off-by: Nishanth Menon Reviewed-by: Heinrich Schuchardt

[PATCH 1/1] efi_loader: fix invocation of efi_prepare_aligned_image

2023-07-30 Thread Heinrich Schuchardt
When passing a pointer to a size_t variable to a function writing an u64 value to the address a buffer overrun occurs on 32bit systems. Fixes: 163a0d7e2cbd ("efi_loader: add PE/COFF image measurement") Reported-by: Dan Carpenter Signed-off-by: Heinrich Schuchardt --- lib/

[PATCH 1/1] tools/fdt_add_pubkey: error handling in add_pubkey

2023-07-30 Thread Heinrich Schuchardt
* If info is NULL, do not dereference it. * If mmap fails, print an error message. Fixes: 30238e99619c ("tools: add fdt_add_pubkey") Signed-off-by: Heinrich Schuchardt --- tools/fdt_add_pubkey.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/fdt_add_

[PATCH 1/1] efi_selftest: remove superfluous assignments

2023-07-30 Thread Heinrich Schuchardt
s: ee3c8ba85525 ("efi_selftest: fix memory allocation in HII tests") Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_hii.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_hii.c b/lib/efi_selftest/efi_selftest_hii.c index

[PATCH 1/1] efi_loader: error handling in tcg2_hash_pe_image()

2023-07-30 Thread Heinrich Schuchardt
ned-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_tcg2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 49f8a5e77c..18abe91bce 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_loader/efi_tcg2.c @@ -931,7 +931,7

[PATCH 1/1] efi_loader: overflow in efi_allocate_pages

2023-07-30 Thread Heinrich Schuchardt
On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which does not occur in 64bit arithmetics. An overflow of (pages << EFI_PAGE_SHIFT) on 64bit systems should be treated as an error. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_memory.c | 7 ++- 1

[PATCH 1/1] efi_loader: out of memory in efi_mem_carve_out

2023-07-30 Thread Heinrich Schuchardt
Handle out of memory situation in efi_mem_carve_out(). Fixes: 5d00995c361c ("efi_loader: Implement memory allocation and map") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_memory.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efi_loader/efi_memory.c b/lib/

[PATCH 1/1] efi_loader: out of memory in efi_add_memory_map_pg

2023-07-30 Thread Heinrich Schuchardt
Handle out of memory situation in efi_add_memory_map_pg(). Fixes: 5d00995c361c ("efi_loader: Implement memory allocation and map") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_memory.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_memo

[PATCH v2 1/1] efi_loader: overflow in efi_allocate_pages

2023-07-30 Thread Heinrich Schuchardt
On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which does not occur in 64bit arithmetics. An overflow of (pages << EFI_PAGE_SHIFT) on 64bit systems should be treated as an error. Signed-off-by: Heinrich Schuchardt --- v2: %s/size/sizeof/ lib/efi_loader/

[PATCH v2 1/1] efi_loader: out of memory in efi_mem_carve_out

2023-07-30 Thread Heinrich Schuchardt
Handle out of memory situation in efi_mem_carve_out(). Fixes: 5d00995c361c ("efi_loader: Implement memory allocation and map") Signed-off-by: Heinrich Schuchardt --- v2: non leak newlist --- lib/efi_loader/efi_memory.c | 6 ++ 1 file changed, 6 insertions(+) diff -

[PATCH 1/1] efi_loader: memory leak efi_add_memory_map_pg

2023-07-30 Thread Heinrich Schuchardt
Don't leak newlist if we error out. Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_memory.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loade

[PATCH 1/1] efi_loader: error handling in efi_disk_add_dev

2023-07-30 Thread Heinrich Schuchardt
efi_loader: add file/filesys support") Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 18 +++--- lib/efi_loader/efi_disk.c | 15 +-- lib/efi_loader/efi_file.c | 12 3 files changed, 32 insertions(+), 13 deletions(-) diff --git a/inclu

[PATCH 1/1] efi_loader: catch out of memory in file_open

2023-07-30 Thread Heinrich Schuchardt
If calloc() return NULL, don't dereference it. Fixes: 2a92080d8c44 ("efi_loader: add file/filesys support") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/e

[PATCH 1/1] cmd: avoid overflow in mtd_is_aligned_with_min_io_size

2023-07-30 Thread Heinrich Schuchardt
Multiplication of u32 factors has an u32 result even if an overflow occurs. An overflow may occur in u64 data_off = page * mtd->writesize; The size of the flash device may exceed 4 GiB. Play it safe and use u64 consistently. Signed-off-by: Heinrich Schuchardt --- cmd/mtd.c |

[PATCH 1/1] boot: fix bootdev_list()

2023-07-30 Thread Heinrich Schuchardt
c [ ] 18446744073709551614 spi_flash spi.bin@0.bootdev Convert the status to a positive number. Now we get Seq Probed Status UclassName --- -- -- -- c [ ] 2 spi_flash spi.bin@0.bootdev Signed-off-by: Heinrich Schuchardt --- boot/boot

[PATCH 1/1] fs: fat: avoid multiplication overflow

2023-07-30 Thread Heinrich Schuchardt
The product of two 32 bit integers is a 32 bit integer. Hence clustcount * bytesperclust may overflow on > 4 GiB devices. Change the type of clustcount. Fixes: cb8af8af5ba0 ("fs: fat: support write with non-zero offset") Signed-off-by: Heinrich Schuchardt --- fs/fat/fat_write.

[PATCH 1/1] cmd/bootdev: print readable status code

2023-07-30 Thread Heinrich Schuchardt
device_probe() called by the 'bootdev info' command returns 0 or a negative error code. itoa() cannot print negative numbers. Convert the error code to a positive number. Signed-off-by: Heinrich Schuchardt --- cmd/bootdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 1/1] doc: describe QEMU virtio block device

2023-07-30 Thread Heinrich Schuchardt
Enhance the description of QEMU block devices * Describe how to attach a virtio-blk device. * Sort the command lines for MMC to match the other devices. Signed-off-by: Heinrich Schuchardt --- doc/board/emulation/blkdev.rst | 14 -- 1 file changed, 12 insertions(+), 2 deletions

[PATCH v2 1/1] doc: describe QEMU virtio block device

2023-07-30 Thread Heinrich Schuchardt
Enhance the description of QEMU block devices * Describe how to attach a virtio-blk device. * Sort the command lines for MMC to match the other devices. Signed-off-by: Heinrich Schuchardt --- v2: %s/if=virtio/if=none/ --- doc/board/emulation/blkdev.rst | 14 -- 1 file

Pull request for spl-2023-10-rc2

2023-07-30 Thread Heinrich Schuchardt
ines/17127 Pull request for spl-2023-10-rc2 SPL: * use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME when booting from NVMe * initialize PCI before booting ---- Heinrich Schuchardt (5): spl

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

2023-07-30 Thread Heinrich Schuchardt
On 7/31/23 08:04, Leo Liang wrote: On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote: The EFI_RNG_PROTOCOL is needed for Linux' KASLR. QEMU can provide a virtio-rng device to emulate a hardware random number generator which is supported by our virtio_rng driver. Ena

[U-BOOT TEST HOOKS][PATCH 1/1] qemu-riscv: enable virtio-rng-pci

2023-07-31 Thread Heinrich Schuchardt
Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should enable CONFIG_DM_RNG in U-Boot. For the EFI unit test for the protocol to succeed a virtio-rng-pci device has to be provided when invoking QEMU. Reported-by: Leo Liang Signed-off-by: Heinrich Schuchardt --- See related

Re: [PATCH 1/1] cmd: avoid overflow in mtd_is_aligned_with_min_io_size

2023-07-31 Thread Heinrich Schuchardt
On 7/31/23 09:00, Michael Nazzareno Trimarchi wrote: Hi On Sun, Jul 30, 2023 at 3:03 PM Heinrich Schuchardt wrote: Multiplication of u32 factors has an u32 result even if an overflow occurs. An overflow may occur in u64 data_off = page * mtd->writesize; The size of the fl

Re: [U-BOOT TEST HOOKS][PATCH 1/1] qemu-riscv: enable virtio-rng-pci

2023-07-31 Thread Heinrich Schuchardt
On 7/31/23 10:48, Bin Meng wrote: On Mon, Jul 31, 2023 at 4:00 PM Leo Liang wrote: On Mon, Jul 31, 2023 at 09:25:07AM +0200, Heinrich Schuchardt wrote: Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should enable CONFIG_DM_RNG in U-Boot. For the EFI unit test fo

[U-BOOT-TEST-HOOKS][PATCH v2 1/1] qemu-riscv: enable virtio-rng-device

2023-07-31 Thread Heinrich Schuchardt
Linux' KASLR uses the EFI_RNG_PROTOCOL as entropy source. We should enable CONFIG_DM_RNG in U-Boot. For the EFI unit test for the protocol to succeed a virtio RNG device has to be provided when invoking QEMU. Reported-by: Leo Liang Signed-off-by: Heinrich Schuchardt --- v2: use v

[PATCH v2 1/1] efi_loader: error handling in tcg2_hash_pe_image()

2023-07-31 Thread Heinrich Schuchardt
continue in case hash_algo_list[] contains an unsupported entry. Fixes: 163a0d7e2cbd ("efi_loader: add PE/COFF image measurement") Signed-off-by: Heinrich Schuchardt --- v2: drop the error message fix tcg2_create_digest() too --- lib/efi_loader/efi_tcg2.c | 6 ++ 1 file

Re: [PATCH v2 1/1] efi_loader: overflow in efi_allocate_pages

2023-07-31 Thread Heinrich Schuchardt
On 31.07.23 14:46, Ilias Apalodimas wrote: Hi Heinrich, On Sun, 30 Jul 2023 at 13:51, Heinrich Schuchardt wrote: On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which does not occur in 64bit arithmetics. You mean this cant happen in 32 bits but can in 64bit

Re: [PATCH] cmd: improve string matching for hex

2023-07-31 Thread Heinrich Schuchardt
On 31.07.23 16:03, Dan Carpenter wrote: Match the "=0x" instead of just "=0". Signed-off-by: Dan Carpenter --- We sometimes two character partial matching for commands so people can type "re" instead of "read". But here reading two characters doesn't seem correct. cmd/nvedit_efi.c | 2 +-

[PATCH 0/2] test: unit test for semihosting

2023-07-31 Thread Heinrich Schuchardt
* Provide a unit test for semihosting testing, reading and writing a file. * Enable semihosting on qemu_arm64_defconfig. Semihosting is already enabled for the board in u-boot-testhooks. Heinrich Schuchardt (2): configs: enable SEMIHOSTING on qemu_arm64_defconfig test: unit test for

[PATCH 1/2] configs: enable SEMIHOSTING on qemu_arm64_defconfig

2023-07-31 Thread Heinrich Schuchardt
We need a platform on which we can test our semihosting code. Signed-off-by: Heinrich Schuchardt --- configs/qemu_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig index 94bd966784..2080f5ee9a 100644 --- a/configs

[PATCH 2/2] test: unit test for semihosting

2023-07-31 Thread Heinrich Schuchardt
Provide a unit test for semihosting testing reading and writing a file. Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_semihosting/conftest.py| 23 + test/py/tests/test_semihosting/test_hostfs.py | 33 +++ 2 files changed, 56 insertions(+) create mode

Re: [PATCH 1/3] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-07-31 Thread Heinrich Schuchardt
On 8/1/23 00:33, Sean Anderson wrote: With CONFIG_IS_ENABLED we can eliminate some ifdefs. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- common/dlmalloc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/common/dlmalloc.c b/common

Re: [PATCH 2/3] malloc: Don't statically initialize av_ if using malloc_init

2023-08-01 Thread Heinrich Schuchardt
On 8/1/23 00:33, Sean Anderson wrote: When we enable malloc_init, there is no need to statically initialize av_, since we are going to do it manually. This lets us move av_ to .bss, saving around 1-2k of data (depending on the pointer size). cALLOc must be adjusted to not access top before ma

[PATCH 1/1] common: fix detection of SYS_MALLOC_F_LEN=0x0

2023-08-01 Thread Heinrich Schuchardt
: c0126bd862a0 ("spl: Support bootstage, log, hash and early malloc in TPL") Fixes: b61694705217 ("SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default") Signed-off-by: Heinrich Schuchardt --- Kconfig | 2 +- common/Makefile | 2 +- 2 files changed, 2 i

Re: [PATCH 2/3] malloc: Don't statically initialize av_ if using malloc_init

2023-08-01 Thread Heinrich Schuchardt
On 01.08.23 18:02, Sean Anderson wrote: On 8/1/23 03:04, Heinrich Schuchardt wrote: On 8/1/23 00:33, Sean Anderson wrote: When we enable malloc_init, there is no need to statically initialize av_, since we are going to do it manually. This lets us move av_ to .bss, saving around 1-2k of

Re: [PATCH 2/3] malloc: Don't statically initialize av_ if using malloc_init

2023-08-01 Thread Heinrich Schuchardt
On 01.08.23 18:27, Sean Anderson wrote: On 8/1/23 12:23, Heinrich Schuchardt wrote: On 01.08.23 18:02, Sean Anderson wrote: On 8/1/23 03:04, Heinrich Schuchardt wrote: On 8/1/23 00:33, Sean Anderson wrote: When we enable malloc_init, there is no need to statically initialize av_, since

[PATCH 1/1] cmd/sbi: display new extensions

2023-08-02 Thread Heinrich Schuchardt
The SBI specification v2.0-rc2 defines new extensions: * Nested Acceleration Extension (NACL) * Steal Time Accounting (STA) Allow the sbi command to display these. Add missing implementation IDs. Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm/sbi.h | 2 ++ cmd/riscv/sbi.c

Re: [PATCH] efi_loader: check uuid_str_to_bin return value

2023-08-02 Thread Heinrich Schuchardt
On 7/31/23 10:53, Masahisa Kojima wrote: Check the uuid_str_to_bin return value, skip the node if the image-type-id property is wrong format. Addresses-Coverity-ID: 463145 ("Error handling issues") Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt --- lib/

Re: [PATCH V3] doc: board: ti: k3: Add a guide to debugging with OpenOCD

2023-08-02 Thread Heinrich Schuchardt
On 8/1/23 19:41, Nishanth Menon wrote: From: Jason Kacines Bootloader debug usually tends to be a bit dicey prior to DDR and serial port getting active in the system. JTAG typically remains the only practical debug option during the initial bringup. OpenOCD is one of the most popular environme

Re: [PATCH v5 00/11] spl: Use common function for loading/parsing images

2023-08-02 Thread Heinrich Schuchardt
On 8/3/23 03:31, Tom Rini wrote: On Wed, Aug 02, 2023 at 09:13:21PM -0400, Sean Anderson wrote: On 8/2/23 16:11, Tom Rini wrote: On Mon, Jul 31, 2023 at 06:42:52PM -0400, Sean Anderson wrote: This series adds support for loading all image types (Legacy, FIT (with and without LOAD_FIT_FULL), a

Pull request efi-2023-10-rc2-2

2023-08-03 Thread Heinrich Schuchardt
DM_FLAG_ comment Dan Carpenter (2): efi_loader: Fix memory corruption on 32bit systems efi_loader: fix an IS_ERR() vs NULL check Heinrich Schuchardt (11): doc: U-Boot boot phases doc: move README.falcon to HTML doc: describe QEMU virtio block device efi_selftest

Re: [PATCH] doc: ti: Explain how the various gadget devices can be used

2023-08-06 Thread Heinrich Schuchardt
On 8/4/23 21:37, Miquel Raynal wrote: Describe the current situation wrt the handling of USB devices on AM33xx based boards, taking the example of a common board (the Beagle Bone Black) and explaining how the different USB gadgets can be used. Signed-off-by: Miquel Raynal --- I've tried to be

Re: [PATCH 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-07 Thread Heinrich Schuchardt
On 04.08.23 21:13, Miquel Raynal wrote: While it may sound totally obvious for the regular U-Boot developer to get the parameters of the bind/unbind commands from the output of 'dm tree', it did not felt straightforward to me until I was explicitly told to look there. And even when I knew the com

Re: [PATCH 2/2] usb: udc: Try to clarify an error message

2023-08-07 Thread Heinrich Schuchardt
On 04.08.23 21:14, Miquel Raynal wrote: At some point when trying to use USB gadgets, two situations may arise and lead to a failure. Either the UDC (USB Device Controller) is not available at all (not described or not probed) or the UDC is already in use. For instance, as the USB Ethernet gadget

Re: [PATCH] doc: Begin adding a best practices document for board ports

2023-08-08 Thread Heinrich Schuchardt
On 8/8/23 00:15, Tom Rini wrote: To help guide developers down the right path, begin a document that lists some best practices to follow when creating a new board port. Signed-off-by: Tom Rini --- doc/develop/board_best_practices.rst | 26 ++ doc/develop/index.rst

Pull request for doc-2023-10-rc3

2023-08-09 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit ef8336e2705fce2502383f25d68188c6b1f94dd0: Merge branch '2023-08-08-introuce-Arm-FF-A-support' (2023-08-08 15:23:16 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/doc-2023-10-rc3 for y

Re: [PATCH v11 3/8] tpm: Support boot measurements

2023-08-09 Thread Heinrich Schuchardt
On 8/9/23 10:34, Ilias Apalodimas wrote: Hi Eddie On Mon, Aug 07, 2023 at 02:25:37PM -0500, Eddie James wrote: Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in

Re: [PATCH v8 8/9] doc: Add documentation to highlight capsule generation related updates

2023-08-10 Thread Heinrich Schuchardt
On 10.08.23 16:23, Sughosh Ganu wrote: The EFI capsules can now be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu Acked-by: Heinrich Schuchardt --- Changess since V7: * Change the name of the file which contains

Re: [PATCH] doc/sphinx/requirements.txt: Bump certifi up

2023-08-10 Thread Heinrich Schuchardt
On 8/1/23 20:53, Tom Rini wrote: Upgrade certifi to the latest version, to remove e-Tugra from the root store. Link: https://groups.google.com/a/mozilla.org/g/dev-security-policy/c/C-HrP1SEq1A?pli=1 Signed-off-by: Tom Rini Reviewed-by: Simon Glass --- doc/sphinx/requirements.txt | 2 +- 1

Re: bugs with EFI "reserved" memory and LMB?

2023-08-11 Thread Heinrich Schuchardt
On 7/27/23 14:14, Emanuele Ghidoli wrote: On 27/07/2023 13:21, Heinrich Schuchardt wrote: On 27.07.23 13:08, Emanuele Ghidoli wrote: Efi loader module have its own memory management that flags as reserved the area between ram_top to ram_end (currently where dt reserved-memory is falling

[PATCH 1/1] lmb: description lmb_is_reserved, lmb_is_reserved_flags

2023-08-12 Thread Heinrich Schuchardt
* provide a description for function lmb_is_reserved() * improve the description of funciton lmb_is_reserved_flags() Signed-off-by: Heinrich Schuchardt --- include/lmb.h | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/include/lmb.h b/include/lmb.h

[PATCH v2 1/1] lmb: description lmb_is_reserved, lmb_is_reserved_flags

2023-08-12 Thread Heinrich Schuchardt
* provide a description for function lmb_is_reserved() * improve the description of funciton lmb_is_reserved_flags() Signed-off-by: Heinrich Schuchardt --- v2: fix lmb_is_reserved description --- include/lmb.h | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions

[PATCH 1/1] common: return type board_get_usable_ram_top

2023-08-12 Thread Heinrich Schuchardt
board_get_usable_ram_top() returns a physical address that is stored in gd->ram_top. The return type of the function should be phys_addr_t like the current type of gd->ram_top. Signed-off-by: Heinrich Schuchardt --- arch/arm/mach-imx/imx8m/soc.c | 2 +- arch/arm/mach-mvebu

[PATCH 1/1] efi_loader: fix efi_add_known_memory()

2023-08-13 Thread Heinrich Schuchardt
by calling board_get_usable_ram_top(). Fixes: 7b78d6438a2b ("efi_loader: Reserve unaccessible memory") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_m

[PATCH 1/1] doc: description of board_get_usable_ram_top()

2023-08-13 Thread Heinrich Schuchardt
Improve the description of function board_get_usable_ram_top(). Signed-off-by: Heinrich Schuchardt --- include/init.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/include/init.h b/include/init.h index 8873081685..dc3c1f220c 100644 --- a/include/init.h

Re: [PATCH 1/1] common: return type board_get_usable_ram_top

2023-08-13 Thread Heinrich Schuchardt
On 8/13/23 15:36, Simon Glass wrote: Hi Heinrich, On Sat, 12 Aug 2023 at 23:01, Heinrich Schuchardt wrote: board_get_usable_ram_top() returns a physical address that is stored in gd->ram_top. The return type of the function should be phys_addr_t like the current type of gd->r

[PATCH 1/1] doc: add partition API to HTML documentation

2023-08-15 Thread Heinrich Schuchardt
* Convert comments in part.h to Sphinx style. * Create documentation page for the partition API. * Add the partition API page to the API index page. Signed-off-by: Heinrich Schuchardt --- doc/api/index.rst | 1 + doc/api/part.rst | 6 ++ include/part.h| 210

Re: [PATCH 1/1] doc: add partition API to HTML documentation

2023-08-15 Thread Heinrich Schuchardt
On 8/15/23 16:44, Simon Glass wrote: Hi Heinrich, On Tue, 15 Aug 2023 at 04:32, Heinrich Schuchardt wrote: * Convert comments in part.h to Sphinx style. * Create documentation page for the partition API. * Add the partition API page to the API index page. Signed-off-by: Heinrich

[PATCH 1/1] spl: don't assume NVMe partition 1 exists

2023-08-15 Thread Heinrich Schuchardt
: blk: Support loading images from fs") Signed-off-by: Heinrich Schuchardt --- common/spl/spl_blk_fs.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/common/spl/spl_blk_fs.c b/common/spl/spl_blk_fs.c index 16ecece702..eb6f526689 100644 --- a/common/spl/spl_blk_fs.c +++ b/

Pull request for efi-2023-10-rc3

2023-08-15 Thread Heinrich Schuchardt
le_ram_top Bin Meng (1): bootmeth: efi: Make distro_efi_boot() static Heinrich Schuchardt (5): lmb: description lmb_is_reserved, lmb_is_reserved_flags doc: description of board_get_usable_ram_top() doc: add partit

Re: Booting Windows 11

2023-08-16 Thread Heinrich Schuchardt
On 8/16/23 03:22, Simon Glass wrote: Hi Heinrich, I thought I would try booting Windows on U-Boot but it does not get very far. Have you tried that? I note a ew odd things below. Is there a validation suite for it? https://github.com/sjg20/u-boot/tree/efi2 qemu-x86_64_defconfig does not build

Re: Booting Windows 11

2023-08-16 Thread Heinrich Schuchardt
On 8/16/23 09:41, Heinrich Schuchardt wrote: On 8/16/23 03:22, Simon Glass wrote: Hi Heinrich, I thought I would try booting Windows on U-Boot but it does not get very far. Have you tried that? I note a ew odd things below. Is there a validation suite for it? https://github.com/sjg20/u-boot

Re: Booting Windows 11

2023-08-16 Thread Heinrich Schuchardt
Hello Simon, these are the EFI configuration tables that EDK II is publishing: Configuration tables: ee4e5898-3914-4259-9d6e-dc7bd79403cf 05ad34ba-6f02-4214-952e-4da0398e2bb9 7739f24c-93d7-11d4-9a3a-0090273fc14d 4c19049f-4137-4dd3-9c10-8b97a83ffdfa 49152e77-1ada-4764-b7a2-7afefed95e8b

Re: [PATCH 1/1] doc: add partition API to HTML documentation

2023-08-16 Thread Heinrich Schuchardt
OK thank you, I will send an mail about it. Do you think you could base your part on [1], since I changed the same file? It is available at u-boot-dm/methb-working The patch is already merged: commit 5aae021c30940a57862c1ea6a3cf8eeb88ca2c1c Best regards Heinrich

[PATCH 1/1] fs/erofs: avoid noisy messages

2023-08-17 Thread Heinrich Schuchardt
system, this only deserves a debug message. Signed-off-by: Heinrich Schuchardt --- fs/erofs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/erofs/super.c b/fs/erofs/super.c index d33926281b..d405d488fd 100644 --- a/fs/erofs/super.c +++ b/fs/erofs/super.c @@ -68,14

Re: Doc style for method functions

2023-08-17 Thread Heinrich Schuchardt
On 16.08.23 19:47, Simon Glass wrote: Hi Jonathan, On Wed, 16 Aug 2023 at 11:15, Jonathan Corbet wrote: Simon Glass writes: Hi Jonathan, I would like to do something like this: struct part_driver { /** * get_info() - Get information about a partition ^ causes err

Re: [PATCH v2 14/20] efi: x86: Use the installed SMBIOS tables

2023-08-17 Thread Heinrich Schuchardt
Am 18. August 2023 02:26:53 MESZ schrieb Simon Glass : >U-Boot sets up the SMBIOS tables during startup. Rather than creating a >new set, install the existing ones. Rely on the ACPI table's memory-map >record to cover the tables. > >Tidy up the installation-condition code while we are here. > >S

Re: [PATCH v2 12/20] x86: smbios: Add a Kconfig indicating SMBIOS-table presence

2023-08-17 Thread Heinrich Schuchardt
Am 18. August 2023 02:26:51 MESZ schrieb Simon Glass : >When booted from coreboot, U-Boot does not build the SMBIOS tables, but >it should still pass them on to the OS. Add a new option which indicates >whether SMBIOS tables are present, however they were built. > >Flip the ordering so that the

Re: [PATCH v2 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-08-17 Thread Heinrich Schuchardt
Am 18. August 2023 02:26:50 MESZ schrieb Simon Glass : >It is not always the case that U-Boot builds the ACPI tables itself. For >example, when booting from coreboot, the ACPI tables are built by >coreboot. > >Correct the Makefile condition so that U-Boot can pass on tables built >by a previous

Re: [PATCH 1/1] Documentation extended with specific information for VirtualBox

2023-08-18 Thread Heinrich Schuchardt
On 17.08.23 15:46, thomas.mittelsta...@de.bosch.com wrote: From: Thomas Mittelstaedt Signed-off-by: Thomas Mittelstaedt --- doc/develop/uefi/u-boot_on_efi.rst | 76 ++ 1 file changed, 76 insertions(+) diff --git a/doc/develop/uefi/u-boot_on_efi.rst b/doc/develo

[PATCH 1/1] doc: board: ti: k3: image alt texts

2023-08-18 Thread Heinrich Schuchardt
Provide alternative texts for images. Fixes: 6e8fa0611f19 ("board: ti: k3: Convert boot flow ascii flow to svg") Signed-off-by: Heinrich Schuchardt --- doc/board/ti/k3.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/board/ti/k3.rst b/doc/board/ti/k3.rst index

[PATCH 1/1] doc: board: ti: am62x: provide image alt texts

2023-08-18 Thread Heinrich Schuchardt
Provide alternative texts for images. Fixes: 34f76921d801 ("doc: board: ti: am62x: Convert the image format to svg") Signed-off-by: Heinrich Schuchardt --- doc/board/ti/am62x_sk.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am

[PATCH 1/1] doc: board: ti: am65x: provide image alt text

2023-08-18 Thread Heinrich Schuchardt
Provide alternative text for image. Fixes: fd358121bdb8 ("doc: board: ti: am65x: Update with boot flow diagram") Signed-off-by: Heinrich Schuchardt --- doc/board/ti/am65x_evm.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/board/ti/am65x_evm.rst b/doc/board/ti/am65x_evm

Pull request doc-2023-10-rc3-2

2023-08-18 Thread Heinrich Schuchardt
Other: * Quieten test for erofs filesystem presence * spl: don't assume NVMe partition 1 exists Fabio Estevam (1): doc: csf_examples: csf.sh: Remove unneeded export ATF_LOAD_ADDR line Heinrich Schuchardt (1): spl:

[PATCH 0/2] risc-v: implement DBCN based debug console

2023-08-19 Thread Heinrich Schuchardt
Currently we only offer an SBI based debug UART for SBI v0.1. With OpenSBI 1.3 the Debug Console Extension (DBCN) has become available. This allows us to implement a debug UART in a device independent manor. Heinrich Schuchardt (2): risc-v: implement DBCN write byte risc-v: implement DBCN

<    5   6   7   8   9   10   11   12   13   14   >