This matches how this would be done in Linux and these functions
do the alignment for us which makes the code look cleaner.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/security.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-k3/security.c
Before this was named just evm, which doesn't match the naming
of the other TI board file directory and makes it look like a
common directory for evms. Name this omap3.
Signed-off-by: Andrew Davis
---
arch/arm/mach-omap2/omap3/Kconfig | 2 +-
board/ti/{evm => omap3}/Kconfig | 2 +
These hardware register definitions are common for all K3, remove
duplicate data them by moving them to hardware.h.
While here do some minor whitespace cleanup + grouping.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am642_init.c | 1 -
arch/arm/mach-k3/include/mach
This matches the others here.
Signed-off-by: Andrew Davis
---
tools/k3_gen_x509_cert.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh
index 029247c105..d9cde07417 100755
--- a/tools/k3_gen_x509_cert.sh
+++ b/tools
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti
The functions board_fit_image_post_process() and board_tee_image_process()
are not actually board specific (despite their names). Any board using the
OMAP2 family can use these functions. Move them to boot-common.c.
Signed-off-by: Andrew Davis
---
arch/arm/mach-omap2/boot-common.c | 16
On 10/7/22 6:47 PM, Heinrich Schuchardt wrote:
On 10/7/22 22:37, Andrew Davis wrote:
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
Changes from v1:
- None
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/doc/board/ti
* BASH code should be labeled as such.
* Code blocks should be indented by 4 spaces.
Fix these here.
Suggested-by: Heinrich Schuchardt
Signed-off-by: Andrew Davis
---
Changes from v1:
- New patch with fixes suggested by Heinrich
doc/board/ti/j721e_evm.rst | 24
1
On 11/4/22 8:08 AM, Tom Rini wrote:
On Fri, Nov 04, 2022 at 11:49:39AM +, Peter Robinson wrote:
Hi Bryan,
This series will introduce basic support (SD and UART) support for Texas
Instruments AM62Ax SK EVM.
The am62ax shares many of the same features as the am62x however it uses
a new 32bi
On 4/15/22 9:09 AM, Vignesh Raghavendra wrote:
Add info of boot flow and build steps for AM62x SK.
Signed-off-by: Vignesh Raghavendra
---
doc/board/ti/am62x_sk.rst | 231 ++
This isn't specific to the SK, more the AM62x in general, suggest name
am62x.rst.
Non-FIT image loading support should be disabled for TI secure
devices as the image handlers for those image types do not follow
our secure boot checks.
Signed-off-by: Andrew Davis
---
boot/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/Kconfig b/boot/Kconfig
This matches what this support is called in the non-SPL case. The postfix
_SUPPORT is redundant as enabling Kconfig options implies support.
With this we can use CONFIG_IS_ENABLED() as needed.
Signed-off-by: Andrew Davis
---
common/spl/Kconfig | 6 +++---
common/spl
Booting of non-FIT images bypass our chain-of-trust boot flow,
these options should not be allowed when high security is set.
Signed-off-by: Andrew Davis
---
common/spl/Kconfig | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
TI secure devices chain-of-trust depends on FIT image processing,
enable it by default on these devices. This also reduces the delta
between the secure and non-secure defconfig files.
Signed-off-by: Andrew Davis
---
boot/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/boot/Kconfig
On 11/6/22 2:49 AM, Heinrich Schuchardt wrote:
On 11/1/22 15:06, Andrew Davis wrote:
On 10/7/22 6:47 PM, Heinrich Schuchardt wrote:
On 10/7/22 22:37, Andrew Davis wrote:
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
Changes from v2:
- s/DM/DM Firmware
Changes from v1:
- None
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions
* BASH code should be labeled as such.
* Code blocks should be indented by 4 spaces.
Fix these here.
Suggested-by: Heinrich Schuchardt
Signed-off-by: Andrew Davis
---
Changes from v2:
- None
Changes from v1:
- New patch with fixes suggested by Heinrich
doc/board/ti/j721e_evm.rst | 24
On 5/9/22 2:29 AM, Roger Quadros wrote:
Introduce k3-am642-evm-binman.dtsi to provide binman configuration.
R5 build is still not converted to use binman so restrict binman.dtsi
to A53 builds only.
This patch also take care of building Secure (HS) images using
binman instead of tools/k3_fit_atf
On 5/25/22 3:30 AM, Roger Quadros wrote:
Hi Andrew,
On 25/05/2022 01:03, Andrew Davis wrote:
On 5/9/22 2:29 AM, Roger Quadros wrote:
Introduce k3-am642-evm-binman.dtsi to provide binman configuration.
R5 build is still not converted to use binman so restrict binman.dtsi
to A53 builds only
On 5/31/22 12:06 AM, Roger Quadros wrote:
Hi,
On 27/05/2022 20:50, Alper Nebi Yasak wrote:
On 26/05/2022 17:15, Tom Rini wrote:
On Thu, May 26, 2022 at 10:28:45AM +0300, Roger Quadros wrote:
Any thoughts on how to get the new ti-secure etype work with atf-bl31 and
tee-os etypes so that it can
On 6/1/22 5:55 AM, Roger Quadros wrote:
On 01/06/2022 13:42, Neha Malcom Francis wrote:
Hi Roger,
On 01/06/22 14:53, Roger Quadros wrote:
Hi,
On 01/06/2022 09:08, Neha Malcom Francis wrote:
Hi Roger,
On 31/05/22 16:32, Roger Quadros wrote:
On 06/05/2022 07:37, Neha Malcom Francis wrote
The content of these files are only used in SPL builds. The contents are
already ifdef for the same, remove that and only include the whole file
in the build when building for SPL.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/Makefile | 13 -
arch/arm/mach-k3/am625_init.c
clear and matches all the K3 devices added since.
Signed-off-by: Andrew Davis
---
arch/arm/dts/Makefile | 2 +-
arch/arm/mach-k3/Kconfig | 14 +++---
arch/arm/mach-k3/Makefile | 2 +-
arch/arm/mach-k3/{am6_init.c
From: "Andrew F. Davis"
Print statements in SPL depend on lib/common support, due to this many
such print statements are ifdef'd. Instead of checking at each call site
move the check to the common.h header and remove these inline checks.
Signed-off-by: Andrew F. Davis
Reviewed-by: Simon Glass
On AM43xx HS devices, QSPI boot is XIP and we use a single stage
bootloader. Add a defconfig for this.
Signed-off-by: Andrew Davis
---
MAINTAINERS | 1 +
configs/am43xx_hs_evm_qspi_defconfig | 74
2 files changed, 75 insertions(+)
create
Additions have been made to the non-HS defconfig without the same
being made to the HS defconfig, sync them.
Signed-off-by: Andrew Davis
---
configs/am65x_hs_evm_a53_defconfig | 23 ++-
configs/am65x_hs_evm_r5_defconfig | 8
2 files changed, 30 insertions(+), 1
Additions have been made to the non-HS defconfig without the same
being made to the HS defconfig, sync them.
Signed-off-by: Andrew Davis
---
configs/j721e_hs_evm_a72_defconfig | 42 ++
configs/j721e_hs_evm_r5_defconfig | 56 +-
2 files changed
Sync new additions to non-HS defconfig with HS defconfig.
Signed-off-by: Andrew Davis
---
configs/am57xx_hs_evm_defconfig | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
index aa0b466d95
This isn't strictly needed as these firewalls should all be disabled on
GP, but it also doesn't hurt, so do this unconditionally to remove this
use of CONFIG_TI_SECURE_DEVICE.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am6_init.c | 4
arch/arm/mach-k3/j721e_init.c | 4 ---
On HS-FS devices signing boot images is optional. To ease use
we check if we are HS-FS and if no certificate is attached
to the image we skip the authentication step with a warning
that this will fail when the device is set to security enforcing.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3
We can skip the image authentication check at runtime if the device is GP.
This reduces the delta between GP and HS U-Boot builds. End goal is
to re-unify the two build types into one build that can run on all
device types.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/Makefile | 3
device boot.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/common.c| 51 +++-
arch/arm/mach-k3/common.h| 10 +
arch/arm/mach-k3/include/mach/hardware.h | 10 +
3 files changed, 70 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach
but if we run into a signed image we should at
least try to ignore the certificate and boot the image anyway. This could
help with users of GP devices who only have HS images available.
If this does happen, print a nice big warning.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/secur
From: Yogesh Siraswar
The x509 certificate SWRV is currently hard-coded to 0. This need to be
updated to 1 for j721e 1.1, j7200 and am64x. It is don't care for other
k3 devices.
Added new config K3_X509_SWRV to k3. Default is set to 1.
Signed-off-by: Yogesh Siraswar
Reviewed-by: Dave Gerlach
Read the swrv.txt file from the TI Security Development Tools when
TI_SECURE_DEVICE is enabled. This allows us to set our software
revision in one place and have it used by all the tools that create
TI x509 boot certificates.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/config.mk | 8
The ISW_ENTRY_ADDR symbol was used for OMAP devices in place of
SPL_TEXT_BASE. Keystone2 HS devices were not using it right either.
Remove ISW_ENTRY_ADDR and use SPL_TEXT_BASE directly.
Signed-off-by: Andrew Davis
---
arch/arm/Kconfig | 15 ---
arch/arm/mach
On 7/16/22 7:00 AM, Simon Glass wrote:
Hi Andrew,
On Fri, 15 Jul 2022 at 09:35, Andrew Davis wrote:
From: "Andrew F. Davis"
Print statements in SPL depend on lib/common support, due to this many
such print statements are ifdef'd. Instead of checking at each call site
move t
-16090.4
Andrew
Andrew Davis (4):
firmware: ti_sci: Reduce output on ti_sci_do_xfer error
firmware: ti_sci: Factor out message alloc failed message
firmware: ti_sci: Remove inline keyword from functions
firmware: ti_sci: Move ACK checking to ti_sci_do_xfer() function
drivers/firmware
benefit to this due to the larger function size reducing
cache locality, but there is a huge size penalty. Remove inline keyword.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers
This ti_sci_do_xfer() function already prints out the reason for the
failure, and the caller of each of these functions should also notify
the user of the failed task. Remove this extra level of error message.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 132
We can check if the message was acknowledged in the common
ti_sci_do_xfer() which lets us remove it from after each call to this
function. This simplifies the code and reduces binary size.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 165 ++
1
We don't need to print the same message in every location, just
print it in the function that fails and remove all the extra
message printouts.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 40 ---
1 file changed, 4 insertions(+), 36 dele
On 7/25/22 11:57 AM, Tom Rini wrote:
On Fri, Jul 15, 2022 at 11:34:32AM -0500, Andrew Davis wrote:
K3 SoCs are available in a number of device types such as
GP, HS-FS, EMU, etc. Like OMAP SoCs we can detect this at runtime
and should print this out as part of the SoC information line.
We add
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that
are now available in dts/upstream. Update the appended files based on
version of latest OF_UPSTREAM sync point (v6.7-rc7).
Signed-off-by: Andrew Davis
---
As suggested here[0].
Based on Mar 4 -next.
[0] https
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that
are now available in dts/upstream. Update the appended files based on
version of latest OF_UPSTREAM sync point (v6.7-rc7).
Signed-off-by: Andrew Davis
---
Changes for v2:
- Rebased on latest -next to fix merge conflict
On 2/28/24 12:21 AM, Manorit Chawdhry wrote:
Hi Andrew,
On 10:30-20240214, Andrew Davis wrote:
Much like we have for ATF, OP-TEE has a standard address that we load
it too and run it from. Add a Kconfig item for this to remove some
hard-coding and allow this address to be more easily changed
On 2/28/24 12:24 AM, Manorit Chawdhry wrote:
Hi Andrew,
On 10:30-20240214, Andrew Davis wrote:
The address we load TF-A and OP-TEE to is configurable by Kconfig
CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory
are often statically defined. As these binaries are
On 3/6/24 7:35 AM, Bryan Brattlof wrote:
On February 14, 2024 thus sayeth Andrew Davis:
The address we load TF-A and OP-TEE to is configurable by Kconfig
CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory
are often statically defined. As these binaries are dynamically
an that up on `make clean'. Also we probably want
to hide it in `git status' list. This patch makes the described changes,
and also adds `-P' parameter to the CPP command that produces the
`generated_defconfig' to avoid generating linemarkers.
All look like sensible improvem
On 3/22/24 8:10 AM, Neha Malcom Francis wrote:
Clean up templatized boot binaries for all K3 boards. This includes
modifying the k3-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and
UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse
code.
All k3--binman.dtsi will conta
On 3/26/24 9:26 AM, Martyn Welch wrote:
With the current config for tha SK-AM62, fdtfile isn't set in the U-Boot
environment. When using bootflow to boot from a block device, where the
extlinux.conf file specifies `fdtdir`, a fallback device tree is being
constructed from the `soc` (`k3`) and `bo
Enable OF_UPSTREAM for Keystone boards. Remove DT files that
are now available in dts/upstream.
Signed-off-by: Andrew Davis
---
arch/arm/dts/Makefile | 7 -
arch/arm/dts/keystone-clocks.dtsi | 411 -
arch/arm/dts/keystone-k2e-clocks.dtsi
Add a new defconfig file for the AM335x High Security EVM. This config
is specific for the case of SPI booting.
Signed-off-by: Andrew Davis
---
configs/am335x_hs_evm_spi_defconfig | 26 ++
1 file changed, 26 insertions(+)
create mode 100644 configs
Looks like way too many tabs, do you have your editor set to 8 space tabs for
DTS files?
Otherwise, LGTM,
Reviewed-by: Andrew Davis
+};
+
&mcu_ringacc {
ti,sci = <&dm_tifs>;
};
to uc_pdata->name not
being unique and rproc_init() will fail.
Fix this by using combination of dev->name and dev->parent->name instead
of using just the dev->name to populate uc_pdata->name.
Signed-off-by: MD Danish Anwar
---
Reviewed-by: Andrew Davis
Cc: Andrew Davis
F
commit, and the name
does not linewrap, even if it is more than 80 chars.
repo [1] into dts/upstream)
No newline.
Signed-off-by: Jonathan Humphreys
Reviewed-by: Andrew Davis
---
arch/arm/dts/k3-j784s4-r5-evm.dts | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/dts/k3-j784s
On 8/12/24 6:48 AM, Chintan Vankar wrote:
From: Kishon Vijay Abraham I
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS
driver in board_init_f().
Signed-off-by: Kishon Vijay Abraham I
Signed-off-by: Siddharth Vadapalli
Signed-off-by: Chintan Vankar
---
Link to v4:
https://l
On 8/14/24 12:17 AM, Chintan Vankar wrote:
On 13/08/24 23:57, Andrew Davis wrote:
On 8/12/24 6:48 AM, Chintan Vankar wrote:
From: Kishon Vijay Abraham I
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS
driver in board_init_f().
Signed-off-by: Kishon Vijay Abraham I
Signed
On 10/10/24 1:50 PM, Simon Glass wrote:
Hi Neha,
On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis wrote:
The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing,
modify the message to show exactly what is meant:
"DRAM: 2 GiB (available for U-Boot out of total 32 GiB)"
Sign
what has been done already for AM64x, might
be good at some point to just do this for all the K3 SoCs. I wonder how
much of the contents of these functions are common across them all..
For now, LGTM,
Reviewed-by: Andrew Davis
v2:
- Drop duplicate CONFIG_SOC_K3_AM62A7 entry from arch/arm
On 1/6/25 4:04 AM, Jayesh Choudhary wrote:
The default value for the mux to select the parent clock,
AUDIO_REFCLK1_CTRL_CLK_SEL is '1' (31) but the mux input for 31
is marked as 'Reserved' so the ti-sci-clk call for get-parent fails.
Mark it to a valid value, '11100' (28) for MAIN_PLL4_HSDIV2
On 1/6/25 3:34 AM, Manorit Chawdhry wrote:
From: Neha Malcom Francis
Clean up templatized boot binaries for j784s4 soc. This includes
modifying the k3-j784s4-binman.dtsi to use SPL_BOARD_DTB,
BOARD_DESCRIPTION and UBOOT_BOARD_DESCRIPTION from the files that
include it to further reuse code.
k3
On 2/3/25 10:43 PM, Manorit Chawdhry wrote:
Hi Andrew,
On 14:44-20250203, Andrew Davis wrote:
On 1/6/25 3:34 AM, Manorit Chawdhry wrote:
From: Neha Malcom Francis
Clean up templatized boot binaries for j784s4 soc. This includes
modifying the k3-j784s4-binman.dtsi to use SPL_BOARD_DTB
On 2/6/25 4:52 AM, Manorit Chawdhry wrote:
Hi Andrew,
On 09:35-20250205, Andrew Davis wrote:
On 2/4/25 11:50 PM, Manorit Chawdhry wrote:
Hi Andrew,
On 09:43-20250204, Andrew Davis wrote:
On 2/3/25 10:43 PM, Manorit Chawdhry wrote:
Hi Andrew,
On 14:44-20250203, Andrew Davis wrote:
On 1/6
On 2/4/25 11:50 PM, Manorit Chawdhry wrote:
Hi Andrew,
On 09:43-20250204, Andrew Davis wrote:
On 2/3/25 10:43 PM, Manorit Chawdhry wrote:
Hi Andrew,
On 14:44-20250203, Andrew Davis wrote:
On 1/6/25 3:34 AM, Manorit Chawdhry wrote:
From: Neha Malcom Francis
Clean up templatized boot
defconfig?
Otherwise whole series looks fine to me,
Reviewed-by: Andrew Davis
CONFIG_REMOTEPROC_TI_PRU=y
-CONFIG_CMD_REMOTEPROC=y
CONFIG_RESET_TI_SCI=y
CONFIG_DM_RTC=y
CONFIG_RTC_EMULATION=y
On 2/7/25 12:51 AM, Daniel Schultz wrote:
Private keys to sign bootloader images shouldn't be commit or part
of this repository. Add config entries to use keys located outside
of U-Boot to sign images.
The custMpk.pem was always a placeholder, we fill it with the TI Dummy
key as an example. Th
On 1/29/25 4:52 PM, Judith Mendez wrote:
From: Hari Nagalla
Some K3 devices like AM64, AM62 devices have a M4 processor in MCU
voltage domain.
Add a remote proc driver to support this subsystem to be able to load
and boot the M4 core.
Signed-off-by: Hari Nagalla
[Judith: Fixed comments and c
On 2/19/25 4:48 AM, Chintan Vankar wrote:
Add configs for enabling Ethernet boot in R5SPL, also disable not required
configs to avoid memory limitation.
Signed-off-by: Chintan Vankar
---
Link to v1:
https://lore.kernel.org/r/20250107093840.2211381-6-c-van...@ti.com/
Changes from v1 to v2:
- U
*/
...
}
Might make the intention a bit much, so either way is fine with me,
Acked-by: Andrew Davis
+ goto add_carveout;
/* Find existing matching subnode and remove it */
fdt_for_each_subnode(subnode, blob, nodeoffset) {
@@ -154,6 +152,7 @@ int fdt_fixup_reserved
301 - 371 of 371 matches
Mail list logo
