[RFC PATCH] Kbuild: Always use $(PHASE_)

2025-03-04 Thread Tom Rini
It is confusing to have both "$(PHASE_)" and "$(XPL_)" be used in our Makefiles as part of the macros to determine when to do something in our Makefiles based on what phase of the build we are in. For consistency, bring this down to a single macro and use "$(PHASE_)" only. Signed-off-by: Tom Rini

[PATCH 2/3] net: ravb: Fix RX frame size limit

2025-03-04 Thread Paul Barker
The value written to the RFLR register includes the length of the CRC data at the end of each Ethernet frame. So we need to increase the value written to this register to ensure that we can receive full size frames. While we're here we can also copy the improved comment from the Linux kernel. Fix

Re: [PATCH] scripts/setlocalversion: Reinstate .scmversion support

2025-03-04 Thread Rasmus Villemoes
On Tue, Mar 04 2025, Tom Rini wrote: > On Tue, Mar 04, 2025 at 03:28:17PM +0100, Marek Vasut wrote: >> On 3/4/25 10:24 AM, Rasmus Villemoes wrote: >> > On Sun, Mar 02 2025, Marek Vasut wrote: >> > >> > > The .scmversion is used by oe-core to append U-Boot version string. >> > > >> > > LOCALVER

[PATCH RFC/RFT 2/3] i2c: omap24xx_i2c: support CONFIG_I2C_REPEATED_START in DM_I2C xfer

2025-03-04 Thread Aniket Limaye
Repeated Start Condition (Sr) can be used to transfer multiple i2c msgs without sending a Stop condition (P). So far, the driver default was to always send a Stop condition after every i2c msg. Add support for a config option (CONFIG_I2C_REPEATED_START) to disable sending the Stop condition by def

RE: [PATCH 1/5] reset: rzg2l-usbphy-ctrl: Add new driver

2025-03-04 Thread Biju Das
Hi Paul, > -Original Message- > From: U-Boot On Behalf Of Paul Barker > Subject: [PATCH 1/5] reset: rzg2l-usbphy-ctrl: Add new driver > > Add a new driver to control the USB 2.0 PHY reset controller on the Renesas > RZ/G2L and related SoCs. > > Signed-off-by: Paul Barker > --- > driv

Re: [PATCH 0/8] membuff: Add tests and update to support a flag for empty/full

2025-03-04 Thread Rasmus Villemoes
On Tue, Mar 04 2025, Simon Glass wrote: > Hi Rasmus, > > On Fri, 18 Oct 2024 at 08:55, Simon Glass wrote: >> >> Hi Rasmus, >> >> On Fri, 18 Oct 2024 at 01:05, Rasmus Villemoes wrote: >> > >> > On tor, okt 17 2024, Simon Glass wrote: >> > >> > > >> > > membuf: Support a flag for being full >>

Re: [PATCH] net: dhcp6: Send DHCPv6 using multicast MAC

2025-03-04 Thread Tom Rini
On Mon, Jan 27, 2025 at 02:06:13PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > In IPv6, the broadcast MAC address is not used. Instead, it should use > the multicast address (see RFC RFC2464). > > Signed-off-by: Sean Edmond > --- > net/dhcpv6.c | 12 ++-- > n

Re: [PATCH] lib: ecdsa: fix prevent memory leak in ecdsa_add_verify_data

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 01:37:21PM +0100, Quentin Schulz wrote: > Hi Tom, > > On 3/4/25 5:41 AM, Tom Rini wrote: > > On Fri, 07 Feb 2025 00:47:59 +0300, Anton Moryakov wrote: > > > > > - Ensure `free_ctx` is called in both error and success paths. > > > - Fix memory leak in `ctx.signature` when `

boottime->efi_allocate_pages() returning EFI_NOT_FOUND

2025-03-04 Thread Ben Schneider
Hi, I'm trying to boot a compressed (via zboot) Linux kernel image for aarch64 and running into an error I didn't expect. To decompress itself, the kernel will run efi_zboot_entry() (found in drivers/firmware/efi/libstub/zboot.c) which wants additional memory so it asks for it via a call to the UE

[PATCH] clk: rzg2l: Ignore disable for core clocks

2025-03-04 Thread Paul Barker
Following on from commit 9a699a0a0d62 ("clk: rzg2l: Ignore enable for core clocks"), we also need to ignore attempts to disable core clocks to avoid the need for conditionals around clk_disable_bulk() calls in drivers which support both RZ/G2L and other Renesas SoCs. Signed-off-by: Paul Barker --

[PATCH 1/3] net: ravb: Add dependency on CONFIG_BITBANGMII

2025-03-04 Thread Paul Barker
The Renesas RAVB driver always requires bitbang MDIO bus support. Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver") Signed-off-by: Paul Barker --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 1563404ca17

Re: [PATCH] scripts/setlocalversion: Reinstate .scmversion support

2025-03-04 Thread Marek Vasut
On 3/4/25 3:42 PM, Tom Rini wrote: [...] export LOCALVERSION = "${UBOOT_LOCALVERSION}" U-Boot and Linux builds in OE-core work differently. Linux uses SCC to apply patches onto a git tree (i.e. it behaves like "git am *patch") and therefore the "-dirty" suffix is not added. U-Boot recipe use

Re: [PATCH 0/4] tools: Minor clean-ups for the command library

2025-03-04 Thread Tom Rini
On Mon, 03 Feb 2025 09:26:41 -0700, Simon Glass wrote: > This series adds comments and fixes pylint warnings in the command > library. It also introduces a new, simpler way of running a single > command. > > > Simon Glass (4): > u_boot_pylib: Correct case for test_result > u_boot_pylib: Add

Re: [PATCH] gpio: 74x146: depend on DM_SPI

2025-03-04 Thread Tom Rini
On Mon, 17 Feb 2025 12:18:03 +0100, J. Neuschäfer wrote: > Currently, Kconfig allows building CONFIG_DM_74X164 without > CONFIG_DM_SPI, which results in linker errors because this driver > actually uses dm_spi_* functions: > > drivers/gpio/74x164_gpio.o: in function `gen_74x164_write_conf': > u

Re: [PATCH] wget: check return value of store_block()

2025-03-04 Thread Sughosh Ganu
On Tue, 4 Mar 2025 at 16:28, Sughosh Ganu wrote: > > The tcp_stream_rx() function calls store_block() to check if the > destination memory region is available for the chunk of data to be > copied to it. The store_block() function returns a negative value in > case the destination memory region is

Re: [PATCH 0/7] binman: Check code-coverage requirements

2025-03-04 Thread Simon Glass
Hi, On Tue, 4 Mar 2025 at 06:09, Simon Glass wrote: > > This series adds a cover-coverage check to CI for Binman. The iMX8 tests > are still not completed, so a work-around is included for those. > > A few fixes are included for some other problems. > > > Jiaxun Yang (1): > binman: Workaround l

Re: [PATCH 4/5] efi_loader: Clean up usage of structure jmp_buf_data

2025-03-04 Thread Ilias Apalodimas
On Sun, 2 Mar 2025 at 14:22, Heinrich Schuchardt wrote: > > From: Yao Zi > > Structure jmp_buf_data provides the underlying format of jmp_buf, which > we actually don't care about. Clean up existing code to use the standard > jmp_buf type. This introduces no functional change. > > Signed-off-by:

Re: [PATCH v2 12/14] dm: usb: initialize and scan multiple buses simultaneously with uthread

2025-03-04 Thread Simon Glass
Hi Jerome, On Thu, 27 Feb 2025 at 10:30, Jerome Forissier wrote: > > > > On 2/27/25 17:25, Simon Glass wrote: > > Hi Jerome, > > > > On Tue, 25 Feb 2025 at 09:35, Jerome Forissier > > wrote: > >> > >> Use the uthread framework to initialize and scan USB buses in parallel > >> for better performa

Re: [PATCH v2 14/14] test: dm: add test for spawn and wait commands

2025-03-04 Thread Simon Glass
Hi Jerome, On Thu, 27 Feb 2025 at 10:12, Jerome Forissier wrote: > > Hi Simon, > > On 2/27/25 17:25, Simon Glass wrote: > > Hi Jerome, > > > > On Tue, 25 Feb 2025 at 09:35, Jerome Forissier > > wrote: > >> > >> Test the spawn and wait commands. > >> > >> Signed-off-by: Jerome Forissier > >> ---

Re: [PATCH v4 05/12] power-domain: Add refcounting

2025-03-04 Thread Miquel Raynal
>> >> It is very surprising that such an uclass, specifically designed to >> >> handle resources that may be shared by different devices, is not keeping >> >> the count of the number of times a power domain has been >> >> enabled/disabled to avoid shutting it down unexpectedly or disabling it >>

Re: Rate of innovation in the project (Was: Re: Rate of change in the project)

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 06:13:36AM -0700, Simon Glass wrote: > Hi Tom, > > (I changed the subject as 'change' sounds like change for change's sake) Frankly, you have a lot of "tidy up" patches where nothing was functionally wrong. > On Mon, 24 Feb 2025 at 16:23, Tom Rini wrote: > > > > On Sat,

Re: [PATCH v4 00/29] arm: Support building as an EFI app

2025-03-04 Thread Igor Opaniuk
Hello Simon, On Sat, Feb 15, 2025 at 2:08 PM Simon Glass wrote: > > The original x86 EFI-app was written back in 2015, about a year before > the EFI-loader was introduced. At that point, ARM mostly used U-Boot and > FIT (Flat Image Tree). > > Today, sadly, there are a few efforts to re-invent FIT

[PATCH v3 04/14] sandbox: add initjmp()

2025-03-04 Thread Jerome Forissier
Add ininijmp() to sandbox. The implementation is taken verbatim from barebox [1]. It is quite complex because contrary to U-Boot platform code we don't know how the system's C library implements the jump buffer, so we can't just write the function and stack pointers into it. FIXME: this patch shou

[PATCH v3 09/14] test: lib: add uthread test

2025-03-04 Thread Jerome Forissier
Add a uhread framework test to the lib tests. Update the API documentation to use the test as an example. Signed-off-by: Jerome Forissier Acked-by: Ilias Apalodimas --- doc/api/uthread.rst | 12 +++ test/lib/Makefile | 1 + test/lib/uthread.c | 80 +++

[PATCH v3 08/14] lib: time: hook uthread_schedule() into udelay()

2025-03-04 Thread Jerome Forissier
Introduce a uthread scheduling loop into udelay() when CONFIG_UTHREAD is enabled. This means that any uthread calling into udelay() may yield to uthread and be scheduled again later. The granunlarity of the scheduling loop is defined by CONFIG_UTHREAD_GRANULARITY. The lower the value, the tighter t

[PATCH v3 03/14] riscv: add initjmp()

2025-03-04 Thread Jerome Forissier
Implement initjmp() for RISC-V. Signed-off-by: Jerome Forissier --- arch/Kconfig| 1 + arch/riscv/lib/setjmp.S | 10 ++ 2 files changed, 11 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 7a3141e92b3..aa60c5ff03c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@

[PATCH v3 14/14] MAINTAINERS: add UTHREAD

2025-03-04 Thread Jerome Forissier
Add myself as the maintainer for the UTHREAD framework, the spawn/wait commands and the associated tests. Signed-off-by: Jerome Forissier --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c1851280e6e..27887bca55d 100644 --- a/MAINTAINERS

[PATCH v3 10/14] dm: usb: move bus initialization into new static function usb_init_bus()

2025-03-04 Thread Jerome Forissier
To prepare for the introduction of coroutines in the USB initialization sequence, move code out of usb_init() into a new helper function: usb_init_bus(). No functional change. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas --- drivers/usb/host/usb-uclass.c | 88 ++

[PATCH v3 05/14] test: lib: add initjmp() test

2025-03-04 Thread Jerome Forissier
Test the initjmp() function when HAVE_INITJMP is set. Use the test as an example in the API documentation. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas --- doc/api/setjmp.rst | 10 +++ test/lib/Makefile | 1 + test/lib/initjmp.c | 72 ++

[PATCH v3 11/14] dm: usb: initialize and scan multiple buses simultaneously with uthread

2025-03-04 Thread Jerome Forissier
Use the uthread framework to initialize and scan USB buses in parallel for better performance. The console output is slightly modified with a final per-bus report of the number of devices found, common to UTHREAD and !UTHREAD. The USB tests are updated accordingly. Tested on two platforms: 1. arm

[PATCH v3 06/14] uthread: add cooperative multi-tasking interface

2025-03-04 Thread Jerome Forissier
Add a new internal API called uthread (Kconfig symbol: UTHREAD) which provides cooperative multi-tasking. The goal is to be able to improve the performance of some parts of U-Boot by overlapping lengthy operations, and also implement background jobs in the U-Boot shell. Each uthread has its own sta

[PATCH v3 12/14] cmd: add spawn and wait commands

2025-03-04 Thread Jerome Forissier
Add a spawn command which runs another command in the background, as well as a wait command to suspend the shell until one or more background jobs have completed. The job_id environment variable is set by spawn and wait accepts optional job ids, so that one can selectively wait on any job. Example

[PATCH v3 00/14] Uthreads

2025-03-04 Thread Jerome Forissier
This series introduces threads and uses them to improve the performance of the USB bus scanning code and to implement background jobs in the shell via two new commands: 'spawn' and 'wait'. Note that it needs to be applied on top of "common: clean up usage of structure jmp_buf_data" by Heinrich S. [

[PATCH v3 13/14] test: cmd: add test for spawn and wait commands

2025-03-04 Thread Jerome Forissier
Test the spawn and wait commands. Signed-off-by: Jerome Forissier --- test/cmd/Makefile | 1 + test/cmd/spawn.c | 32 2 files changed, 33 insertions(+) create mode 100644 test/cmd/spawn.c diff --git a/test/cmd/Makefile b/test/cmd/Makefile index d8a5e77402d..c

[PATCH v3 01/14] arch: introduce initjmp() and Kconfig symbol HAVE_INITJMP

2025-03-04 Thread Jerome Forissier
Add the HAVE_INIJMP symbol to be set by architectures that support initjmp(), a non-standard extension to setjmp()/longjmp() allowing to initialize a jump buffer with a function pointer and a stack pointer. This will be useful to later introduce threads. With this new function it becomes possible t

[PATCH v3 02/14] arm: add initjmp()

2025-03-04 Thread Jerome Forissier
Implement initjmp() for Arm. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas --- arch/Kconfig | 1 + arch/arm/lib/setjmp.S | 11 +++ arch/arm/lib/setjmp_aarch64.S | 9 + 3 files changed, 21 insertions(+) diff --git a/arch/Kconfig b/arch/

[PATCH v3 07/14] cyclic: invoke uthread_schedule() from schedule()

2025-03-04 Thread Jerome Forissier
Make the schedule() call from the CYCLIC framework a uthread scheduling point too. This makes sense since schedule() is called from a lot of places where uthread_schedule() needs to be called. Signed-off-by: Jerome Forissier Reviewed-by: Ilias Apalodimas --- common/cyclic.c | 3 +++ i

Re: [PATCH 3/8] membuf: Rename struct

2025-03-04 Thread Simon Glass
Rename the struct to match the function prefix and filenames. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/serial.h | 2 +- boot/bootmeth_extlinux.c | 2 +- common/console.c | 24 +- drivers/usb/emul/sandbox_keyb.c | 2 +- include/asm-ge

Re: [PATCH 7/8] membuf: Minor code-style improvements

2025-03-04 Thread Simon Glass
Show the start in end in the comment. Comment a missing variable in membuf_readline() and fix its line length. Signed-off-by: Simon Glass --- include/membuf.h | 6 -- lib/membuf.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) Applied to sjg/master, thanks!

Re: [PATCH 1/8] membuff: Rename functions to have membuf_ prefix

2025-03-04 Thread Simon Glass
The double 'f' is not necessary and is a bit annoying as elsewhere in U-Boot we use 'buf'. Rename all the functions before it is used more widely. Signed-off-by: Simon Glass --- boot/bootmeth_extlinux.c| 6 +-- common/console.c| 32 ++--- drivers/serial/sandbox.

Re: [PATCH 4/8] membuf: Include stdbool

2025-03-04 Thread Simon Glass
This uses a bool type so include the required header. Signed-off-by: Simon Glass --- include/membuf.h | 2 ++ 1 file changed, 2 insertions(+) Applied to sjg/master, thanks!

Re: [PATCH 6/8] membuf: Add some tests

2025-03-04 Thread Simon Glass
Add tests for the membuf implementation. Signed-off-by: Simon Glass --- test/lib/Makefile | 1 + test/lib/membuf.c | 239 ++ 2 files changed, 240 insertions(+) create mode 100644 test/lib/membuf.c Applied to sjg/master, thanks!

Re: [PATCH 0/5] net: lwip: root certificates

2025-03-04 Thread Simon Glass
Hi Jerome, On Thu, 27 Feb 2025 at 09:43, Jerome Forissier wrote: > > > > On 2/27/25 17:27, Simon Glass wrote: > > Hi Jerome, > > > > On Thu, 27 Feb 2025 at 09:09, Jerome Forissier > > wrote: > >> > >> This series adds support for HTTP server authentication using root (CA) > >> certificates. > >>

Re: [PATCH v3 1/4] video: bridge-uclass: add get_display_timing ops

2025-03-04 Thread Simon Glass
On Mon, 24 Feb 2025 at 05:02, Svyatoslav Ryhel wrote: > > Add get_display_timing ops for internal bridges linked to > panels that do not support EDID (MIPI-DSI panels for example) > or have EDID not routed. > > Tested-by: Dang Huynh (PineTab 2) > Signed-off-by: Svyatoslav Ryhel > --- > drivers/

Re: [PATCH v3 2/4] video: bridge-uclass: add inline fallbacks of video bridge functions

2025-03-04 Thread Simon Glass
On Mon, 24 Feb 2025 at 05:02, Svyatoslav Ryhel wrote: > > Hide video bridge functions behind config condition and add inline > fallbacks to avoid erroring out when using header without config > enabled. > > Signed-off-by: Svyatoslav Ryhel > --- > include/video_bridge.h | 33 +

Re: [PATCH v3 4/4] test: dm: add video bridge tests

2025-03-04 Thread Simon Glass
On Mon, 24 Feb 2025 at 05:03, Svyatoslav Ryhel wrote: > > Add tests for video bridge ops. > > Signed-off-by: Svyatoslav Ryhel > --- > arch/sandbox/dts/test.dts | 46 +++ > configs/sandbox_defconfig | 2 ++ > test/dm/Makefile | 1 + > test/dm/video_bridge.c|

[PATCH 1/7] binman: Exclude dist-packages and site-packages

2025-03-04 Thread Simon Glass
Newer versions of the python3-coverage tool require a directory separator before and after the directory name. Add this so that system package are not included in the coverage report. Signed-off-by: Simon Glass --- tools/u_boot_pylib/test_util.py | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH 0/7] binman: Check code-coverage requirements

2025-03-04 Thread Simon Glass
This series adds a cover-coverage check to CI for Binman. The iMX8 tests are still not completed, so a work-around is included for those. A few fixes are included for some other problems. Jiaxun Yang (1): binman: Workaround lz4 cli padding in test cases Simon Glass (6): binman: Exclude dist

[PATCH 3/7] binman: fit: Drop unused code

2025-03-04 Thread Simon Glass
The key-name-hint case is not tested so is presumably not used. Drop it. Signed-off-by: Simon Glass --- tools/binman/etype/fit.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index 803fb66ea83..ed3cac4ee7e 100644 --- a/tools/binman/e

[PATCH 4/7] binman: Drop algo check in CheckSetHashValue()

2025-03-04 Thread Simon Glass
The CheckAddHashValue() function is always called before this one, so the algorithm check is never used. Replace it with an assert to avoid a coverage error. Signed-off-by: Simon Glass --- tools/binman/state.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/binman/s

[PATCH 2/7] binman: Drop GetRootSkipAtStart()

2025-03-04 Thread Simon Glass
This method is not called anymore, so drop it. Signed-off-by: Simon Glass --- tools/binman/etype/section.py | 17 - 1 file changed, 17 deletions(-) diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py index 5c371397ffb..1d50bb47753 100644 --- a/tools/binma

[PATCH 6/7] binman: Work around missing test coverage

2025-03-04 Thread Simon Glass
The iMX8 entry-types don't have proper test coverage. Add a work-around to skip this for now. Signed-off-by: Simon Glass --- tools/binman/main.py| 8 +++- tools/u_boot_pylib/test_util.py | 16 +++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/tool

[PATCH 5/7] binman: Workaround lz4 cli padding in test cases

2025-03-04 Thread Simon Glass
From: Jiaxun Yang Newer lz4 util is not happy with any padding at end of file, it would abort with error message like: Stream followed by undecodable data at position 43. Workaround by skipping testCompUtilPadding test case and manually strip padding in testCompressSectionSize test case. Signe

Re: [PATCH 0/7] binman: Check code-coverage requirements

2025-03-04 Thread Simon Glass
Hi Tom, On Thu, 27 Feb 2025 at 10:04, Tom Rini wrote: > > On Thu, Feb 27, 2025 at 09:25:25AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 25 Feb 2025 at 14:53, Tom Rini wrote: > > > > > > On Tue, Feb 25, 2025 at 02:44:12PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

[PATCH 7/7] CI: Run code-coverage test for Binman

2025-03-04 Thread Simon Glass
Binman includes a good set of tests covering all of its functionality. This includes a code-coverage test. However to date the code-coverage test has not been checked automatically by CI, relying on people to run 'binman test -T' themselves. Plug the gap to avoid bugs creeping in future. Signed-

Re: [PATCH 2/5] arm: include asm-generic/int-ll64.h in setjmp.h

2025-03-04 Thread Jerome Forissier
On 3/2/25 15:21, Heinrich Schuchardt wrote: > Don't assume that u32 and u64 are already defined. > > Signed-off-by: Heinrich Schuchardt > --- > arch/arm/include/asm/setjmp.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/setjmp.h b/arch/arm/include/asm/setjmp

Re: [PATCH 1/5] sandbox: remove linux/types.h dependency in setjmp.h

2025-03-04 Thread Jerome Forissier
On 3/2/25 15:21, Heinrich Schuchardt wrote: > ulong is defined in linux/types.h use unsigned long instead. > > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/include/asm/setjmp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sandbox/include/asm/setjmp

Re: [PATCH 5/5] arm: use type jmp_buf instead of struct jmp_buf_data

2025-03-04 Thread Jerome Forissier
On 3/2/25 15:21, Heinrich Schuchardt wrote: > Instead of using the implementation specific struct jmp_buf_data use the > standard compliant type jmp_buf when switching exception levels. > > Signed-off-by: Heinrich Schuchardt > --- > arch/arm/cpu/armv7/exception_level.c | 6 +++--- > arch/arm/

Re: [PATCH 4/5] efi_loader: Clean up usage of structure jmp_buf_data

2025-03-04 Thread Jerome Forissier
On 3/2/25 15:21, Heinrich Schuchardt wrote: > From: Yao Zi > > Structure jmp_buf_data provides the underlying format of jmp_buf, which > we actually don't care about. Clean up existing code to use the standard > jmp_buf type. This introduces no functional change. > > Signed-off-by: Yao Zi >

Re: [PATCH v4 05/12] power-domain: Add refcounting

2025-03-04 Thread Simon Glass
Hi Miquel, On Mon, 3 Mar 2025 at 01:43, Miquel Raynal wrote: > > Hello Simon, > > On 08/02/2025 at 08:09:30 -03, Fabio Estevam wrote: > > > Hi Simon, > > > > On Wed, Jan 29, 2025 at 7:22 AM Miquel Raynal > > wrote: > >> > >> It is very surprising that such an uclass, specifically designed to >

Re: [PATCH v2 2/5] samsung: snow: Use BLOBLIST_FIXED

2025-03-04 Thread Simon Glass
Hi Tom, On Thu, 27 Feb 2025 at 10:04, Tom Rini wrote: > > On Thu, Feb 27, 2025 at 09:31:24AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 27 Feb 2025 at 09:26, Tom Rini wrote: > > > > > > On Thu, Feb 27, 2025 at 09:17:15AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed

Re: [PATCH v2 5/6] efi_loader: move path out of file_handle

2025-03-04 Thread Gabriel D'Alimonte
Hi Ilias, Thanks for the review! On Thu, Feb 20, 2025 at 2:55 AM Ilias Apalodimas wrote: > > Hi Gabriel, > > On Mon, 17 Feb 2025 at 20:31, Gabriel Dalimonte > wrote: > > > > In order to support renaming via SetInfo(), path must allow for longer > > values than what was originally present when f

Re: [PATCH 0/7] binman: Check code-coverage requirements

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 06:10:27AM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 27 Feb 2025 at 10:04, Tom Rini wrote: > > > > On Thu, Feb 27, 2025 at 09:25:25AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 25 Feb 2025 at 14:53, Tom Rini wrote: > > > > > > > > On Tue, Feb 25, 20

Re: [PATCH 7/7] CI: Run code-coverage test for Binman

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 06:09:44AM -0700, Simon Glass wrote: > Binman includes a good set of tests covering all of its functionality. > This includes a code-coverage test. > > However to date the code-coverage test has not been checked > automatically by CI, relying on people to run 'binman test

Rate of innovation in the project (Was: Re: Rate of change in the project)

2025-03-04 Thread Simon Glass
Hi Tom, (I changed the subject as 'change' sounds like change for change's sake) On Mon, 24 Feb 2025 at 16:23, Tom Rini wrote: > > On Sat, Feb 22, 2025 at 05:00:59PM -0700, Simon Glass wrote: > > Hi Tom, > > > > (I think you chopped off too much context, so I've added it below) > > That's fine.

Re: [PATCH 5/5] arm: use type jmp_buf instead of struct jmp_buf_data

2025-03-04 Thread Ilias Apalodimas
On Sun, 2 Mar 2025 at 14:22, Heinrich Schuchardt wrote: > > Instead of using the implementation specific struct jmp_buf_data use the > standard compliant type jmp_buf when switching exception levels. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas > --- > arch/arm/cpu/arm

Re: [PATCH 3/5] common: clean up setjmp.h

2025-03-04 Thread Jerome Forissier
On 3/2/25 15:21, Heinrich Schuchardt wrote: > Separate setjmp.h into an architecture independent part and an architecture > specific part. This simplifies moving from using struct jmp_buf_data > directly to using type jmp_buf in our code which is the C compliant way. > > Signed-off-by: Heinrich

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-04 Thread Sebastian Reichel
Hi, On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > However, I have a question regarding the Type-C controller's > connection to the PMIC via I2C. I didn't see a corresponding > controller node in the device tree source (dts) file that would > support this function. > > I feel this

[PATCH 0/2] Enable support for VAB flow on Agilex5 SoCFPGA boards

2025-03-04 Thread Naresh Kumar Ravulapalli
Enable support for VAB flow on Agilex5 SoCFPGA boards boards. VAB flow authenticates image certificates during U-Boot booting and halts the booting if the authentication fails. The flow has been tested on Agilex5 SoCFPGA board and confirmed by checking the UART console log messages which logs succ

[PATCH 1/2] arch: arm: dts: Enable kernel itb file generation for Agilex5 SoCFPGA

2025-03-04 Thread Naresh Kumar Ravulapalli
Load and entry addresses are corrected for Agilex5 SoCFPGA board which would enable to generate the kernel itb file with the right addresses. Signed-off-by: Naresh Kumar Ravulapalli --- arch/arm/dts/socfpga_soc64_fit-u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/d

Re: [PATCH v2 1/8] dt-bindings: clk: define additional PMC clocks

2025-03-04 Thread Sumit Garg
On Mon, Mar 03, 2025 at 10:26:15AM +, manikanda...@microchip.com wrote: > Hi Eugen and Sumit, > > On 28/02/25 5:07 pm, Sumit Garg wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Fri, 28 Feb 2025 at 16:45, Eugen Hristev >

[PATCH 2/2] configs: Enable VAB flow for Agilex5 SoCFPGA boards

2025-03-04 Thread Naresh Kumar Ravulapalli
Vendor Authorized Boot flow configurations are enabled for boards based on Agilex5 SoCFPGA. Also, required changes are made to the SoCFPGA make file for building and linking relevant secure source code files. Signed-off-by: Naresh Kumar Ravulapalli --- arch/arm/mach-socfpga/Makefile| 2

Re: [PATCH 2/2] powerpc: mpc8xxx_spi: Catch bad chip variants earlier

2025-03-04 Thread J . Neuschäfer
On Mon, Mar 03, 2025 at 12:08:38PM +0800, Peng Fan wrote: > Hi, > > On Mon, Feb 17, 2025 at 04:48:48PM +0100, J. Neuschäfer via B4 Relay wrote: > >From: "J. Neuschäfer" > > > >Currently, enabling the MPC8xxx SPI driver on an unexpected SoC results > >in a wall of errors because spi8xxx_t isn't de

Re: [PATCH] lib: ecdsa: fix prevent memory leak in ecdsa_add_verify_data

2025-03-04 Thread Quentin Schulz
Hi Tom, On 3/4/25 5:41 AM, Tom Rini wrote: On Fri, 07 Feb 2025 00:47:59 +0300, Anton Moryakov wrote: - Ensure `free_ctx` is called in both error and success paths. - Fix memory leak in `ctx.signature` when `do_add` fails." Triggers found by static analyzer Svace. Applied to u-boot/next, t

Re: [PATCH v3 3/4] video: bridge: add transparent LVDS de/encoder bridge

2025-03-04 Thread Simon Glass
On Mon, 24 Feb 2025 at 05:03, Svyatoslav Ryhel wrote: > > Add a simple and transparent LVDS de/encoder driver with a powerdown > gpio and a power supply. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/bridge/Kconfig | 7 ++ > drivers/video/bridge/Makefile | 1 + > drivers

Re: [PATCH v3 1/2] CI: Move default image under global defaults

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 08:35:56AM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 27 Feb 2025 at 10:03, Tom Rini wrote: > > > > On Thu, Feb 27, 2025 at 09:26:10AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 24 Feb 2025 at 16:14, Tom Rini wrote: > > > > > > > > On Sat, Feb 22, 20

[PATCH 1/2] vepxress64: disable CRC32 by default to prevent aborts

2025-03-04 Thread Harrison Mutai
On fast models, the CRC32 feature is disabled by default. When enabled in U-Boot, it leads to synchronous aborts due to unrecognized instructions. This change ensures CRC32 is disabled by default to maintain compatibility. Signed-off-by: Harrison Mutai --- configs/vexpress_fvp_defconfig | 1 + 1

Re: [PATCH v1] board: verdin-am62: fix missing memory fixup call

2025-03-04 Thread Tom Rini
On Mon, 03 Mar 2025 19:16:03 +0100, Stefan Eichenberger wrote: > The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a > common location and Fixup DDR size when ECC is enabled") broke DRAM > support for the Verdin AM62. This was partially fixed with commit > 3f866c47b582 ("board:

Re: [PATCH v2 0/5] Syncing up on skip-at-start

2025-03-04 Thread Tom Rini
On Wed, 26 Feb 2025 09:26:13 -0700, Simon Glass wrote: > This series has the skip-at-start change and a few fixes. > > Sadly it also includes a revert for the dm_probe_devices() patch, since > it breaks jerry (RK3288). I will need to investigate way. > > It is based on -next and I can send a PR

[PATCH RFC/RFT 0/3] omap24xx_i2c: Enable Repeated Start functionality

2025-03-04 Thread Aniket Limaye
This series implements Repeated Start functionality for the DM_I2C xfer API (omap_i2c_xfer()) First, split out the actual implementation for each individual i2c msg transfer into a new function __omap24_i2c_xfer_msg() and use this to implement omap_i2c_xfer(). Then, add support for the Repeated S

[PATCH RFC/RFT 1/3] i2c: omap24xx_i2c: Use new function __omap24_i2c_xfer_msg()

2025-03-04 Thread Aniket Limaye
Remove __omap24_i2c_read/write() usage from omap_i2c_xfer() in favour of the more flexible __omap24_i2c_xfer_msg(). Consequently, these are also no longer needed when DM_I2C is enabled. New function __omap24_i2c_xfer_msg() will take care of individual read OR write transfers with a target device.

[PATCH RFC/RFT 3/3] drivers: i2c: Kconfig: Add config for I2C_REPEATED_START

2025-03-04 Thread Aniket Limaye
Add a Kconfig option to disable sending Stop conditions between multiple i2c_msgs within a single xfer. Enable it by default for ARCH_K3 platforms. The namespace for the config is not respecting the CONFIG_SYS_I2C convention since the legacy API has already been using CONFIG_I2C_REPEATED_START Si

Re: [PATCH] scripts/setlocalversion: Reinstate .scmversion support

2025-03-04 Thread Marek Vasut
On 3/4/25 10:24 AM, Rasmus Villemoes wrote: On Sun, Mar 02 2025, Marek Vasut wrote: The .scmversion is used by oe-core to append U-Boot version string. LOCALVERSION is not fully compatible replacement as it adds trailing "-dirty" string at the end of version string in case the U-Boot git tree

Re: [PATCH v2 0/4] USB-PD TCPM improvements

2025-03-04 Thread Anand Moon
Hi Sebastian, On Tue, 4 Mar 2025 at 18:12, Sebastian Reichel wrote: > > Hi, > > On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote: > > However, I have a question regarding the Type-C controller's > > connection to the PMIC via I2C. I didn't see a corresponding > > controller node in the

Re: [PATCH] scripts/setlocalversion: Reinstate .scmversion support

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 03:28:17PM +0100, Marek Vasut wrote: > On 3/4/25 10:24 AM, Rasmus Villemoes wrote: > > On Sun, Mar 02 2025, Marek Vasut wrote: > > > > > The .scmversion is used by oe-core to append U-Boot version string. > > > > > > LOCALVERSION is not fully compatible replacement as it

Re: [PATCH 0/8] membuff: Add tests and update to support a flag for empty/full

2025-03-04 Thread Simon Glass
Hi Rasmus, On Fri, 18 Oct 2024 at 08:55, Simon Glass wrote: > > Hi Rasmus, > > On Fri, 18 Oct 2024 at 01:05, Rasmus Villemoes wrote: > > > > On tor, okt 17 2024, Simon Glass wrote: > > > > > > > > membuf: Support a flag for being full > > > > > > > No, that is the worst of all worlds, especia

Re: xPL Proposal

2025-03-04 Thread Simon Glass
Hi Tom, On Thu, 27 Feb 2025 at 13:30, Tom Rini wrote: > > On Thu, Feb 27, 2025 at 12:32:42PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 27 Feb 2025 at 10:17, Tom Rini wrote: > > > > > > On Thu, Feb 27, 2025 at 09:24:45AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed

Re: [PATCH 0/7] binman: Check code-coverage requirements

2025-03-04 Thread Simon Glass
Hi Tom, On Tue, 4 Mar 2025 at 07:20, Tom Rini wrote: > > On Tue, Mar 04, 2025 at 06:10:27AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 27 Feb 2025 at 10:04, Tom Rini wrote: > > > > > > On Thu, Feb 27, 2025 at 09:25:25AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue,

Re: [PATCH v3 1/2] CI: Move default image under global defaults

2025-03-04 Thread Simon Glass
Hi Tom, On Thu, 27 Feb 2025 at 10:03, Tom Rini wrote: > > On Thu, Feb 27, 2025 at 09:26:10AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 24 Feb 2025 at 16:14, Tom Rini wrote: > > > > > > On Sat, Feb 22, 2025 at 05:24:05PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Sat

Re: [PATCH 8/8] membuf: Support a flag for being full

2025-03-04 Thread Simon Glass
At present the membuf implementation wastes a slot in the fifo so it can detect the difference between a full and an empty buffer. Add the option of supporting a boolean flag, if desired. For now it is off. The code-size penalty is non-zero, but the space penalty is small and could be reduced on

Re: [PATCH 5/8] membuf: Correct implementation of membuf_dispose()

2025-03-04 Thread Simon Glass
This should free the pointer, not the address of the pointer. Fix it. Signed-off-by: Simon Glass --- lib/membuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to sjg/master, thanks!

Re: [PATCH] configs: j784s4-am69: Enable UFS

2025-03-04 Thread Tom Rini
On Mon, Feb 17, 2025 at 01:47:12PM +0530, Udit Kumar wrote: > J784S4 EVM board has UFS flash, So enable UFS configs > > Cc: Neha Francis > Signed-off-by: Udit Kumar > --- > Bootlogs > https://gist.github.com/uditkumarti/828f4a7731d952f92b627f7ac46da5dd > > configs/am69_sk_a72_defconfig| 5

Re: xPL Proposal

2025-03-04 Thread Tom Rini
On Tue, Mar 04, 2025 at 08:35:29AM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 27 Feb 2025 at 13:30, Tom Rini wrote: > > > > On Thu, Feb 27, 2025 at 12:32:42PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 27 Feb 2025 at 10:17, Tom Rini wrote: > > > > > > > > On Thu, Feb 27, 20

[PATCH 5/5] renesas_rzg2l_smarc_defconfig: Enable USB support

2025-03-04 Thread Paul Barker
Enable support for USB 2.0, USB 1.1 and USB storage devices on the Renesas RZ/G2L EVK. Also enable the 'usb' command to support USB scanning and debugging. Signed-off-by: Paul Barker --- configs/renesas_rzg2l_smarc_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/re

[PATCH 4/5] phy: rcar: Support RZ/G2L USB PHY

2025-03-04 Thread Paul Barker
Extend the existing Renesas R-Car gen3 USB 2.0 PHY driver to support the RZ/G2L and related SoCs. Also enable this driver by default for the RZ/G2L SoC family. Signed-off-by: Paul Barker --- drivers/phy/Kconfig | 4 +- drivers/phy/phy-rcar-gen3.c | 79 ++

Re: [PATCH v2] MAINTAINERS: Update contact information for Greg Malysa

2025-03-04 Thread Tom Rini
On Fri, 28 Feb 2025 14:28:27 -0500, Greg Malysa wrote: > My previous address is no longer accessible, but I will continue to be > involved in maintaining the ADI sc5xx platforms. This updates my contact > information and hopefully avoids bouncing emails from other developers. > > Applied to u-b

Re: [PATCH] spi: Introduce initial eeprom driver mode support

2025-03-04 Thread Tom Rini
On Mon, Feb 24, 2025 at 11:43:38AM +, Loureiro, Joao wrote: > This patch introduces the initial SPI EEPROM driver mode support > analogous to the I2C EEPROM driver mode support. The SPI EEPROM > driver mode support is enabled by default in the sandbox_defconfig. > > Signed-off-by: João Lourei

[PATCH 3/5] reset: rzg2l-usbphy-ctrl: Connect up vbus regulator

2025-03-04 Thread Paul Barker
Bind the USB VBUS regulator driver under the USB PHY reset driver for the Renesas RZ/G2L and related SoCs. This additional bind is needed as the corresponding device tree node does not contain a compatible string. Signed-off-by: Paul Barker --- drivers/reset/Kconfig | 1 + dri

[PATCH 0/2] vepxpress64: disable CRC32 by default and add FVP with TF-A guide

2025-03-04 Thread Harrison Mutai
This patch introduces two updates to the vexpress64 project: - Disable CRC32 by default to prevent aborts in a standard FVP setup. - Add a guide for running FVP with TF-A, providing a clear starting point for users. Harrison Mutai (2): vepxress64: disable CRC32 by default to prevent aborts

[PATCH 1/1] dumpimage: fix handling of StarFive SPL too long

2025-03-04 Thread Heinrich Schuchardt
The header of the StarFive U-Boot SPL file u-boot-spl.normal.out has a field indicating the payload size. When copying U-Boot SPL from a partition the copied file might be too long. Currently in this situation a misleading error message 'Incorrect CRC32' is written. We must use the payload size a

  1   2   >